[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #66250|0 |1 is obsolete|| --- Comment #29 from Aleisha Amohia --- Created attachment 77028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77028=edit Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #66248|0 |1 is obsolete|| --- Comment #27 from Aleisha Amohia --- Created attachment 77026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77026=edit Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #66247|0 |1 is obsolete|| --- Comment #26 from Aleisha Amohia --- Created attachment 77025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77025=edit Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #66249|0 |1 is obsolete|| --- Comment #28 from Aleisha Amohia --- Created attachment 77027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77027=edit Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21080] patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Jonathan Druart --- Hum, maybe it comes from local changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21080] New: patron attribute classes break patron's edit view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 Bug ID: 21080 Summary: patron attribute classes break patron's edit view Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 7154 When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154 [Bug 7154] Group borrower attributes and link between patron category and attribute -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7154] Group borrower attributes and link between patron category and attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7154 Jonathan Druart changed: What|Removed |Added Blocks||21080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21080 [Bug 21080] patron attribute classes break patron's edit view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #31 from Katrin Fischer --- I feel like Chris makes some valid points here when he says there is no proof that the additional changes are needed. We have tested this patch and found it to fix the problem we had reported. Patron images don't longer overlay and repeat. If we change the code further - what is the bug it fixes? What should be in the test plan? >FTR: I have no problem undefing the entire $image_data reference. As soon as I >>have time, I will submit a follow-up patch. I also inadvertently removed the >>statements which short-circuit the loop in the case of no image data. That >needs >to be corrected as well. Does this mean the patch should not be used as is? Could the additional requested changes moved to another bug report for attending to them later? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Katrin Fischer changed: What|Removed |Added Attachment #76993|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 77024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77024=edit Bug 21050: Fix datepickers on LabelItemSearch calendar.inc must be in the jsinclude block when jsfooter is set Test plan: - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Date picker should work now Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 Katrin Fischer changed: What|Removed |Added Assignee|philippe.blo...@inlibro.com |koha-b...@lists.koha-commun ||ity.org --- Comment #14 from Katrin Fischer --- Thx for the reply Philippe. Resetting assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer --- Tests pass, but I can't get authorities to sort. I am sorry, can you please check if it works for you? I tried ... resetting indexes, reindexing multiple times, multiple reset_all, really stuck here :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21038] Reserves should be holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- String change, moving to PQA directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21038] Reserves should be holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038 Katrin Fischer changed: What|Removed |Added Attachment #77021|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 77023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77023=edit Bug 21038: Reserves should be holds This patch corrects the text of the warning about discharges cancelling holds. To test, apply the patch and view the discharge for a patron who has holds: - "Borrower" is changed to "patron" - "reserves" is changed to "holds" - "canceled" (18 instances in the templates) is changed to "cancelled" (51 instances). Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21038] Reserves should be holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > Tested on bionic: > > % sudo koha-create xxx > % sudo koha-shell xxx > % grep docdir $KOHA_CONF > /usr/share/doc/koha-common > > % ls /usr/share/doc/koha-common|grep history.txt > history.txt I will try testing this in the docker environment, which seems to be to blame right now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What|Removed |Added Attachment #72785|0 |1 is obsolete|| --- Comment #11 from Owen Leonard --- Created attachment 77022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77022=edit Bug 10442: Remove references to non-standard "error" class The CSS for is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard . To test: - In Acquisitions -> Late orders, locate an order from a vendor which doesn't have an email address. Selecting that order and clicking "Claim" should trigger an error dialog, "This vendor has no email." It should be styled correctly. - With AcqCreateItem set to "when placing an order," add to an existing order using the "From a new (empty) record" option. Add two items with identical barcodes and submit the form. A error should show at the top of the page. - With AcqCreateItem set to "when receiving an order," receive an order and add two items with identical barcodes. Submitting the form should trigger an error message at the top of the page. With the remaining cases I don't know how to trigger the errors in question, so a visual check of the changes may be required: - Administration -> Funds -> "You are not authorized to modify this fund" - Administration -> Search engine configuration (/admin/searchengine/elasticsearch/mappgings.pl) -> Various modification errors. - With the AutoEmailOpacUser preference set to "send," adding a patron without an email address can trigger an error, "This member has no email." - With plugins enabled, and installed, there are error messages displayed under various circumstances. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21038] Reserves should be holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038 --- Comment #1 from Owen Leonard --- Created attachment 77021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77021=edit Bug 21038: Reserves should be holds This patch corrects the text of the warning about discharges cancelling holds. To test, apply the patch and view the discharge for a patron who has holds: - "Borrower" is changed to "patron" - "reserves" is changed to "holds" - "canceled" (18 instances in the templates) is changed to "cancelled" (51 instances). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21038] Reserves should be holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21038 Owen Leonard changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20714] Bug1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20714 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|FIXED |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #10 from Nick Clemens --- Created attachment 77020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77020=edit Bug 19722: (follow-up) Adjust template parameters Before we passed 'too_many_items' this was renamed to 'too_many_items_display' but deletion template lacked changes To test: 1 - Test a batch deletion by list and file 2 - Test with deleting biblios and without 3 - Results should be as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 --- Comment #1 from Owen Leonard --- Created attachment 77019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77019=edit Bug 21041: "Merge patrons" button remains disabled with "Select all" option This patch modifies the JavaScript functions for the select all/clear all links so that each action triggers the "change" event, required to enable or disabled the "merge selected patrons" button. To test, apply the patch and perform a patron search which will return multiple results. - Test the "select all" and "clear all" links, and confirm that the "Merge selected patrons" button is enabled and disabled. - Test that checking and unchecking multiple checkboxes still works correctly to enable and disable the button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15869] Change framework on overlay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #8 from Nick Clemens --- Patches updated just to see. I think the condition was right (it is checking if there are two variables left in the parameters) but agree it is ugly - changed to take a hash It still needs unit tests, feel free to help :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15869] Change framework on overlay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15869] Change framework on overlay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Attachment #70800|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 77018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77018=edit Bug 15869: Change framework on overlay This patch allows for selection of framework to use when overlaying records - by default it is set to keep the initial framework To test: 1 - Create some records using one framework 2 - Export the records 3 - Edit the records to add fields not in original framework 4 - Stage records using a rule that will find matches 5 - Import 6 - Note records contain new fields on display, but they are lost on edit 7 - Apply patch 8 - Stage records again 9 - Select a framework that contains the new fields on import 10 - Import records 11 - Note records now use selected framework and are displayed/edited correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21041] "Merge patrons" button remains disabled with "Select all" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21041 Owen Leonard changed: What|Removed |Added Version|18.05 |master Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Severity|enhancement |normal Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20740] Update two-column templates with Bootstrap grid: Administration part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20740] Update two-column templates with Bootstrap grid: Administration part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740 --- Comment #1 from Owen Leonard --- Created attachment 77017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77017=edit Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4 This patch modifies several administration templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20739] Update two-column templates with Bootstrap grid: Administration part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20739 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20739] Update two-column templates with Bootstrap grid: Administration part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20739 --- Comment #1 from Owen Leonard --- Created attachment 77016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77016=edit Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20738] Update two-column templates with Bootstrap grid: Administration part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20738 --- Comment #1 from Owen Leonard --- Created attachment 77015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77015=edit Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20738] Update two-column templates with Bootstrap grid: Administration part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20738 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Adam Goforth changed: What|Removed |Added CC||koha-support@international- ||library.de --- Comment #8 from Adam Goforth --- The checkout history is used in a couple of workflows we have at my library, so it would be really nice if we didn't have to wait until upgrading to 18.11 to get this fix. Are there currently any plans to backport the fix to 18.05? If not, would it be helpful for me to create a patch for it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #5 from Jonathan Druart --- Tested on bionic: % sudo koha-create xxx % sudo koha-shell xxx % grep docdir $KOHA_CONF /usr/share/doc/koha-common % ls /usr/share/doc/koha-common|grep history.txt history.txt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736 --- Comment #1 from Owen Leonard --- Created attachment 77014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77014=edit Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20736] Update two-column templates with Bootstrap grid: Administration part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20736 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What|Removed |Added Attachment #77012|0 |1 is obsolete|| --- Comment #21 from Nick Clemens --- Created attachment 77013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77013=edit Bug 18635 - Unit tests I also adjust a few tests that assume value of $nb_of_patrons to not rely on existing datas To test: 1 - Apply this patch only 2 - Prove t/db_dependent/Koha/Patrons.t 3 - Tests fail 4 - Apply other patch 5 - Tests pass Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What|Removed |Added Attachment #77005|0 |1 is obsolete|| Attachment #77006|0 |1 is obsolete|| --- Comment #19 from Nick Clemens --- Created attachment 77011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77011=edit Bug 18635 - Koha::Patron->guarantees() should return results alphabetically To test: 1 - Add the same guarantor to a number of patrons, ensuring random order alphabetically 2 - View the guarantors record, note unordered list of guarantees 3 - Apply patch 4 - Guarantees are alphabetical Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #20 from Nick Clemens --- Created attachment 77012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77012=edit Bug 18635 - Unit tests To test: 1 - Apply this patch only 2 - Prove t/db_dependent/Koha/Patrons.t 3 - Tests fail 4 - Apply other patch 5 - Tests pass Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #20 from Nick Clemens --- Created attachment 77010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77010=edit Bug 19482: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #19 from Nick Clemens --- Created attachment 77009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77009=edit Bug 19482: (follow-up) QA fixes Remove debug statement Use disaled select to match other fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nick Clemens changed: What|Removed |Added Attachment #72878|0 |1 is obsolete|| Attachment #72879|0 |1 is obsolete|| Attachment #72880|0 |1 is obsolete|| --- Comment #17 from Nick Clemens --- Created attachment 77007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77007=edit Bug 19482 - DB changes Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #18 from Nick Clemens --- Created attachment 77008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77008=edit Bug 19482 - Add support for defining 'mandatory' mappings To test: 1 - Apply patch 2 - ./installer/data/mysql/updatedatabase.pl 3 - Clear all ES mappings form the db: DELETE FROM search_field; DELETE FROM search_marc_map; DELETE FROM search_marc_to_field; 4 - Reset ES mapping: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1 5 - issues should now be uneditable and not removable Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635
--- Comment #18 from Jonathan Druart
---
I do not think it was, tests in t/db_dependent/Patrons.t are pointless.
Anyway, did you see that we already have a subtest for this method, in the same
file?
t/db_dependent/Koha/Patrons.t:subtest 'guarantees' => sub {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #17 from Nick Clemens --- (In reply to Jonathan Druart from comment #13) > (In reply to Marcel de Rooy from comment #12) > > Nick, > > What are you doing here?! > > Deleting tests without further notice? > > > > Failed QA > > Which tests are missing? Maybe as_list, is it what you meant? When I moved the tests I also deleted tests, that was an error, undone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 --- Comment #16 from Nick Clemens --- Created attachment 77006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77006=edit Bug 18635 - Unit tests To test: 1 - Apply this patch only 2 - Prove t/db_dependent/Patron.t 3 - Tests fail 4 - Apply other patch 5 - Tests pass Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What|Removed |Added Attachment #66557|0 |1 is obsolete|| Attachment #66558|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 77005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77005=edit Bug 18635 - Koha::Patron->guarantees() should return results alphabetically To test: 1 - Add the same guarantor to a number of patrons, ensuring random order alphabetically 2 - View the guarantors record, note unordered list of guarantees 3 - Apply patch 4 - Guarantees are alphabetical Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18635] Koha::Patron->guarantees() should return results alphabetically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21028] www/history.t is failing on jenkins for Ubuntu 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21028 --- Comment #4 from Jonathan Druart --- It's a www test, so it means the interface is hit. It's not test related. So I am expecting about.pl to not display the history.txt content (tab Timeline) on bionic. Could someone confirm? There is something hidden we should understand asap, it could have other problematic side-effects. Or Maybe none... :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604
--- Comment #30 from Chris Nighswonger ---
(In reply to Marcel de Rooy from comment #24)
> (In reply to Chris Nighswonger from comment #22)
> > (In reply to Marcel de Rooy from comment #19)
> > > Chris:
> > > I have the impression
> >
> > Just an impression? ;-) Did you test and find a case where this fix does not
> > work?
> Please keep in mind that we both have the same goal: fix bugs and improve
> code. QAing is more than testing. A careful look at the code can in my
> experience reveal bugs just as easy or show you what to test.
No offense intended. I understand that we have the same goal. I appreciate your
contribution to the QA process. Please keep in mind that my time is extremely
limited. Much more so than devs who are paid to work on Koha as I am paid to
work on other projects. When you provide QA feedback without a supporting
proof-case, it means that the dev has to spend time ensuring 1. your
observation is valid and 2. Ensuring that the fix does not cause other
problems. Time is expensive to be spending on an impression without
accompanying demonstrable failure cases.
>
> > $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is
> > a reference to a hash created by DBI containing the results of the SELECT.
> > DBI creates a new hash on every row retrieval[1], ensuring that the data
> > contained at our reference is fresh every time.
> The crux is here indeed. This is only partially true. The code does only
> update $image_data in two of the if statement branches. So my observation
> and request is just to clear $image_data each time in the loop or put its
> definition into the loop. Clearing the other variables might be unneeded
> since they are created in the loop.
> So this reveals a test case: Make sure that record 1 in the loop is a patron
> image and record 2 comes in the eq 'none' branch. Record 2 will use the old
> value of $image_data.
FTR: I have no problem undefing the entire $image_data reference. As soon as I
have time, I will submit a follow-up patch. I also inadvertently removed the
statements which short-circuit the loop in the case of no image data. That
needs to be corrected as well.
That said: Your suggested case does not cause the failure you suggest. I
understand that $image_data never drops out of scope during the loop execution.
I understand that in theory the reference can contain "stale" data. I just have
not been handed and cannot establish a test case where it does.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21071] Search results not sorting in staff client advanced search when only AdvancedSearchTypes checkboxes are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21071 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Looks ok on master, can you define "does not work"? Do you get an error? No result? Sort option is not selected? Do you sort on the search result or the advanced search view? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #78 from Nick Clemens --- QA tool will warn of deleted/created in same patchset - pfft - can squash on push It also complains of pod on the Schema files - I think is a red herring TT warns cleared -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #74 from Nick Clemens --- Created attachment 77001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77001=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #75 from Nick Clemens --- Created attachment 77002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77002=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #77 from Nick Clemens --- Created attachment 77004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77004=edit Bug 19166: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #76 from Nick Clemens --- Created attachment 77003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77003=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #73 from Nick Clemens --- Created attachment 77000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77000=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #72 from Nick Clemens --- Created attachment 76999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76999=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #69 from Nick Clemens --- Created attachment 76996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76996=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Conflicts: C4/Budgets.pm Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #70 from Nick Clemens --- Created attachment 76997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76997=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #71 from Nick Clemens --- Created attachment 76998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76998=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Attachment #76994|0 |1 is obsolete|| --- Comment #68 from Nick Clemens --- Created attachment 76995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76995=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Attachment #74893|0 |1 is obsolete|| Attachment #74894|0 |1 is obsolete|| Attachment #74895|0 |1 is obsolete|| Attachment #74896|0 |1 is obsolete|| Attachment #74897|0 |1 is obsolete|| Attachment #74898|0 |1 is obsolete|| Attachment #74899|0 |1 is obsolete|| Attachment #74900|0 |1 is obsolete|| Attachment #75043|0 |1 is obsolete|| --- Comment #67 from Nick Clemens --- Created attachment 76994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76994=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 --- Comment #5 from Jonathan Druart --- Created attachment 76993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76993=edit Bug 21050: Fix datepickers on LabelItemSearch calendar.inc must be in the jsinclude block when jsfooter is set Test plan: - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Date picker should work now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Jonathan Druart changed: What|Removed |Added Blocks||21050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 [Bug 21050] Datepickers on LabelItemSearch broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050 Jonathan Druart changed: What|Removed |Added Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED Depends on||19709 --- Comment #4 from Jonathan Druart --- Caused by commit 3c887b4e07acf9459767a7b934aa4f6c16cae534 Bug 19709: Move template JavaScript to the footer: Labels Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21050] Datepickers on LabelItemSearch broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050
--- Comment #3 from Jonathan Druart
---
Hum, it is failing now (?)
ReferenceError: _ is not defined
at line:
var MSG_PLEASE_ENTER_A_VALID_DATE = (_("Please enter a valid date (should match
%s)."));
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #25 from Jonathan Druart --- Removing from PQA for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #24 from Katrin Fischer --- We fix a wrong call... but the feature will remain broken. Might just be hiding the real problem. Maybe we should change this bug to 'update option is broken in bulkmarcimport.pl' for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #23 from Katrin Fischer --- It doesn't work, see my tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 --- Comment #6 from Marjorie Barry-Vila --- In 17.05, there is an other problem: when creating a new suggestion, active funds do not appear at first time. You have to save the suggestion and then go back to see active funds (with all inactive funds too). Anyone works on this? Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21040] Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21040 Marjorie Barry-Vila changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11176 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Marjorie Barry-Vila changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21040 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21040] Funds from inactive budgets appear in 'Funds' dropdown on suggestion.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21040 Marjorie Barry-Vila changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > (In reply to Marcel de Rooy from comment #20) > > (In reply to Jonathan Druart from comment #19) > > > First patch is useless without the second patch... > > > > Not so sure about that. Please explain. > > Comments 6 to 9 I saw them. But that does not make this patch useless. We fix a wrong call. If it is in enclosed by if($update), the fix is conditional. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #21 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #20) > (In reply to Jonathan Druart from comment #19) > > First patch is useless without the second patch... > > Not so sure about that. Please explain. Comments 6 to 9 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Jonathan Druart changed: What|Removed |Added Severity|normal |minor --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Is the bug that there are 2 Edit links for both that lead to the same page? step 4 is used for both housebound module and additional attributes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > First patch is useless without the second patch... Not so sure about that. Please explain. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #31 from Jonathan Druart --- (In reply to Katrin Fischer from comment #29) > Why BLOCKED? See comment 20. (In reply to Martin Renvoize from comment #30) > I believe Tomas is working on bug 20443.. which I think is the blocker here. See assignee field, I am working on it. Please do not change anything here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 --- Comment #19 from Jonathan Druart --- First patch is useless without the second patch... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 --- Comment #13 from Blou --- We'd love to, and we'll certain support (with testing) anyone working on it or similar patch, but it won't be us (inLibro) doing the coding at this point I'm sorry to say. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #16 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #15) > (In reply to Jonathan Druart from comment #12) > > (In reply to Marcel de Rooy from comment #11) > > > Line 680 still contains: > > > [% IF s.authorised_value == selected_status %] > > > Around line 308 you are replacing it by suggestion.STATUS. Please explain. > > > If I am not mistaken, it comes from: my $suggestion_ref = $input->Vars; > > > Where is the field STATUS filled? > > > > 361 suggestion => $suggestion_ref, > OK. But what about line 680? The selected_status there is not filled > anywhere? It sounds like a bug but I cannot recreate from the UI, maybe this is never used? Could you have a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19524] Share patron lists between staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 --- Comment #12 from Kyle M Hall --- Created attachment 76992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76992=edit Bug 19524: Use existing logged_in_user variable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #71 from Nick Clemens --- Applied cleanly on master for me - I moved additional tests to subtest in Acquisition.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #67 from Nick Clemens --- Created attachment 76988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76988=edit Bug 18736: Follow to clean up admin policy preference Two preferences were merged into the same box. This likely was unintended. This reformats them. TEST PLAN - Go to Acquisitions tab of the system preference -- in the policy section PurgeSuggestionsOlderThan and OrderPriceRounding are in the same box Apply this patch Refresh the page -- OrderPriceRounding is in its own box, and better formatted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #69 from Nick Clemens --- Created attachment 76990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76990=edit Bug 18736: (follow-up) Undo changes to GetLateOrders GetLateOrders calculates subtotal based on rrp which is a 2 decimal precision field. If we need more precision here it should be fixed on a separate bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #66 from Nick Clemens --- Created attachment 76987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76987=edit Bug 18736: Follow to prevent duplicate run noise TEST PLAN - update the database twice -- noise apply patch update the database -- no noise -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #68 from Nick Clemens --- Created attachment 76989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76989=edit Bug 18736: (follow-up) Add missing test cases We now fully cover GetBudgetsPlanCell in these tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #70 from Nick Clemens --- Created attachment 76991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76991=edit Bug 18736: (follow-up) Unit tests Test coverage for new C4::Acquisition functions. prove t/Acquisition.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #65 from Nick Clemens --- Created attachment 76986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76986=edit Bug 18736: (follow-up) Add tests and FIXME for GetbudgetsPlanCell prove t/db_dependent/Budgets.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #64 from Nick Clemens --- Created attachment 76985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76985=edit Bug 18736: (follow-up) Correctly assign values in subroutines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #63 from Nick Clemens --- Created attachment 76984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76984=edit Bug 18736: (follow-up) Use CAST instead of CEIL for appropriate rounding -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
