[Koha-bugs] [Bug 21096] New: Garbled username on intranet login page.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Bug ID: 21096 Summary: Garbled username on intranet login page. Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ultron9...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 77149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77149=edit The attached picture of garbled username on koha intranet page. Hello, I recently found that one could create a new account(one that could access intranet page as well as opac page) with using Mandarin for username. Although username shown on opac page was fine, username shown somehow came into garbled as long as moving forward to other features or setting on intranet page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 --- Comment #57 from Mason James --- (In reply to Narcis Garcia from comment #52) > PHP uses parameter "upload_tmp_dir", usually set at php.ini or webserver > site profile. Doesn't Perl have some similar to not make necessary to check > filesystem paths and permissions? > > I have a Koha 17.11 running in Debian 9 (Stretch) without problem about > uploads. How does Koha 17.11 deal with this? fyi: i've hit this problem on deb9 with 17.11.6 + plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21031] Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21031 --- Comment #13 from David Cook --- Created attachment 77148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77148=edit Apache_rewrite_log.txt Apologies for the delay on getting this out. As you can see, because we're in a directory ending in "api", the "api" gets stripped out of the uri: [Fri Jul 20 13:43:01.358964 2018] [rewrite:trace1] [pid 11341] mod_rewrite.c(477): [client 192.168.1.100:15501] 192.168.1.100 - - [192.168.1.200/sid#7f1ca31258b0][rid#7f1c9d3a50a0/initial] pass through /api/v1/cities [Fri Jul 20 13:43:01.359158 2018] [rewrite:trace3] [pid 11341] mod_rewrite.c(477): [client 192.168.1.100:15501] 192.168.1.100 - - [192.168.1.200/sid#7f1ca31258b0][rid#7f1c9d3a50a0/initial] [perdir /home/dcook/koha/api/] strip per-dir prefix: /home/dcook/koha/api/v1/cities -> v1/cities [Fri Jul 20 13:43:01.359189 2018] [rewrite:trace3] [pid 11341] mod_rewrite.c(477): [client 192.168.1.100:15501] 192.168.1.100 - - [192.168.1.200/sid#7f1ca31258b0][rid#7f1c9d3a50a0/initial] [perdir /home/dcook/koha/api/] applying pattern '^(v[0-9]+)/(.*)$' to uri 'v1/cities' [Fri Jul 20 13:43:01.359271 2018] [rewrite:trace2] [pid 11341] mod_rewrite.c(477): [client 192.168.1.100:15501] 192.168.1.100 - - [192.168.1.200/sid#7f1ca31258b0][rid#7f1c9d3a50a0/initial] [perdir /home/dcook/koha/api/] rewrite 'v1/cities' -> '/api/v1/app.pl/api/v1/cities' [Fri Jul 20 13:43:01.359302 2018] [rewrite:trace2] [pid 11341] mod_rewrite.c(477): [client 192.168.1.100:15501] 192.168.1.100 - - [192.168.1.200/sid#7f1ca31258b0][rid#7f1c9d3a50a0/initial] [perdir /home/dcook/koha/api/] trying to replace prefix /home/dcook/koha/api/ with /api/ [Fri Jul 20 13:43:01.359334 2018] [rewrite:trace2] [pid 11341] mod_rewrite.c(477): [client 192.168.1.100:15501] 192.168.1.100 - - [192.168.1.200/sid#7f1ca31258b0][rid#7f1c9d3a50a0/initial] [perdir /home/dcook/koha/api/] trying to replace context docroot /home/dcook/koha/api with context prefix /api [Fri Jul 20 13:43:01.359353 2018] [rewrite:trace1] [pid 11341] mod_rewrite.c(477): [client 192.168.1.100:15501] 192.168.1.100 - - [192.168.1.200/sid#7f1ca31258b0][rid#7f1c9d3a50a0/initial] [perdir /home/dcook/koha/api/] internal redirect with /api/v1/app.pl/api/v1/cities [INTERNAL REDIRECT] I admit that I don't 100% understand some of the later lines. I get the "strip per-dir prefix", "applying pattern", "rewrite" and "internal redirect", but I don't understand why "trying to replace prefix" and "trying to replace context docroot" happen. Maybe I need to increase the trace level to 5 from 3 - I don't know. But yeah the important thing is that the RewriteRule for non-Plack Apache configuration shouldn't include the "api" path since the directory-level configuration means "api" gets stripped out of the incoming uri. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20300] Import authorities data fail in module Stage MARC record for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20300 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Attachment #76658|0 |1 is obsolete|| --- Comment #23 from Aleisha Amohia --- Created attachment 77147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77147=edit Bug 12365: (follow-up) Adding maxlength attribute and popover Test that you can't add a note of more than 100 characters. Test notes with rules, notes are hidden by 'View note' and the popover correctly displays note. View the note by hovering over the link I've moved the Note column so the popover displays nicely and doesn't cover the buttons. I've also changed the placement so that it doesn't cover information in the row. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12365] Notes for rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21095] Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 --- Comment #1 from Nick Clemens --- Created attachment 77146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77146=edit Bug 21095: Add ccode facets info to tests To test: 1 - prove -v t/db_dependent/Search.t 2 - Koha asks "Why am I getting these crazy facets!?!" 3 - Apply patch 4 - prove -v t/db_dependent/Search.t 5 - Koha purrs (tests pass) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21095] Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Nick Clemens changed: What|Removed |Added Blocks||21095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 [Bug 21095] Tests should expect ccodes facets now (since we have ccode facets) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21095] Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Nick Clemens changed: What|Removed |Added Depends on||18322 Assignee|ch...@bigballofwax.co.nz|n...@bywatersolutions.com CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 [Bug 18322] Add facets for ccode to zebra -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21095] New: Tests should expect ccodes facets now (since we have ccode facets)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21095 Bug ID: 21095 Summary: Tests should expect ccodes facets now (since we have ccode facets) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Since bug 18322 added ccode facets to zebra we should expect to get them in tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #12 from David Cook --- Sounds good to me. I'm all for having method naming conventions. With Perl's "method names as strings" (https://perldoc.perl.org/perlobj.html#Method-Call-Variations), I think you can get the flexibility of Option 1 while using the code in Option 2. my $method = "filter_by_$arg"; my $filtered = $obj->$method(); Boom! And yeah by standardizing method naming conventions, I think we could potentially see some code re-use for methods that are more complex than your average DIBC methods but less complex than super unique methods. You can do some cool stuff with aliasing functions so that you can have different module-specific names for the same generic method as well, so you might get that relevant API while still having code re-use. I see nothing to disagree with (which must be novel considering it's me). Awesome ideas, Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #34 from Aleisha Amohia --- Created attachment 77145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77145=edit Bug 8628: [FOLLOW-UP] Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #77027|0 |1 is obsolete|| --- Comment #32 from Aleisha Amohia --- Created attachment 77143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77143=edit Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #77028|0 |1 is obsolete|| --- Comment #33 from Aleisha Amohia --- Created attachment 77144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77144=edit Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #77026|0 |1 is obsolete|| --- Comment #31 from Aleisha Amohia --- Created attachment 77142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77142=edit Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8628] Add digital signs to the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What|Removed |Added Attachment #77025|0 |1 is obsolete|| --- Comment #30 from Aleisha Amohia --- Created attachment 77141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77141=edit Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20975] Improve auto escaping performance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975 Jonathan Druart changed: What|Removed |Added Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #9 from Jonathan Druart --- No longer valid, new version of bug 13618 has been submitted. Thanks for the feedback Julian! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #219 from Jonathan Druart --- I am back! Next version has been pushed to the remote branch - https://gitlab.com/joubu/Koha/commits/bug_13618 Here is commit message of the main patch: As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain
[Koha-bugs] [Bug 15428] Different timeout preference for opac and intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 --- Comment #7 from Chris Nighswonger --- The INSERTS are great, and they represent the quickest way to duplicate a setup for testing. I'll work on this over the next few weeks unless someone gets to it before me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21094] Syndetics: always use https instead of http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21094 --- Comment #1 from Owen Leonard --- Created attachment 77140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77140=edit Bug 21094: Syndetics: always use https instead of http This patch removes the 'using_https' check in OPAC templates in calls to Syndetics resources. Instead, https is always used. To test, apply the patch and enable Syndetics-related preferences. View the following pages in the OPAC: - Bibliographic detail page - Browse shelf section of the bibliographic detail page - Search results - List contents - Recent comments - Recent comments RSS - User summary page - Circulation history NOTE: I tested with made-up Syndetics credentials. This means my changes didn't make the template explode, but it doesn't confirm conclusively that the resources work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21094] Syndetics: always use https instead of http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21094 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13560] Add an 'Add' option in MARC modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21085] Can't edit patrons with housebound module active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href=
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21076] Javascript error on article requests page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21076 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20974] Remove files left behind after removing Solr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20974 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21064] Advanced cataloging editor - rancor - check for changes should return 'undefined' instead of 'undef'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21064 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21053] Editing 008 field with a hash overwrites data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21053 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21086] Wrong mock of DateTime->now in tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13560] Add an 'Add' option in MARC modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #23 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #26 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #25 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #111 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21094] New: Syndetics: always use https instead of http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21094 Bug ID: 21094 Summary: Syndetics: always use https instead of http Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: katrin.fisc...@bsz-bw.de, k...@bywatersolutions.com, testo...@bugs.koha-community.org Blocks: 17137 As per bug 17137, we should be using SSL for all external resources. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137 [Bug 17137] Omnibus: Always use SSL when referencing external sources -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137 Owen Leonard changed: What|Removed |Added Depends on||21094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21094 [Bug 21094] Syndetics: always use https instead of http -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17137] Omnibus: Always use SSL when referencing external sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137 Owen Leonard changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] New: Problem when using specify due date with fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Bug ID: 21093 Summary: Problem when using specify due date with fast add Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When using the specify due date option and then created a fast add, the checkbox "Remember for sesssion" gets automatically checked and even after unchecking it and using "Clean" the date keeps reappearing until you switch to another patron account. To test: - Set the specify due date option to a date, don't check the checkbox - Enter an unknown barcode - Click on fast add - Add a record - Add an item (don't change the barcode!) - The item is checked out to the patron - Verify: The checkbox is "Remember for session" is checked now - Uncheck checkbox and clear the specified date - Check out another item - Verify that the date is back. So there is 2 problems here: - Checkbox should not check itself - it shoudl be able to clear the date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Problem when using specify due date with fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Katrin Fischer changed: What|Removed |Added Version|master |17.11 --- Comment #1 from Katrin Fischer --- Tested with 17.11.06, need to retest in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 Katrin Fischer changed: What|Removed |Added CC||christian.stelzenmueller@bs ||z-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 --- Comment #6 from Katrin Fischer --- patronimages are activated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 --- Comment #5 from Katrin Fischer --- Hi Chris, was not sure how to report best, so I have created INSERTS of the data with workbench: INSERT INTO `creator_layouts` (`layout_id`,`barcode_type`,`start_label`,`printing_type`,`layout_name`,`guidebox`,`oblique_title`,`font`,`font_size`,`units`,`callnum_split`,`text_justify`,`format_string`,`layout_xml`,`creator`) VALUES (20,'CODE39',1,'BAR','Testlayout',0,1,'TR',10,'POINT',0,'L','barcode','\n \n\n \n firstname surname\n \n Bibliothek: branchcode\n \n Ablaufdatum: 31.06.2014\n \n\n','Patroncards'); INSERT INTO `creator_templates` (`template_id`,`profile_id`,`template_code`,`template_desc`,`page_width`,`page_height`,`label_width`,`label_height`,`top_text_margin`,`left_text_margin`,`top_margin`,`left_margin`,`cols`,`rows`,`col_gap`,`row_gap`,`units`,`creator`) VALUES (24,0,'Testtemplate1','Default description',0,0,0,0,0,0,0,0,0,0,0,0,'POINT','Patroncards'); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 --- Comment #4 from Chris Nighswonger --- (In reply to Katrin Fischer from comment #2) > Created attachment 77138 [details] > Patron card template > > We are aware that the values make no sense - it's what you get when you save > without changing anything on the form. The form doesn't require any fields, > so that could happen by accident. Likewise, the out put of: SELECT * FROM creator_templates WHERE template_id = \G -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 --- Comment #3 from Chris Nighswonger --- (In reply to Katrin Fischer from comment #1) > Created attachment 77137 [details] > Patron card layout It would be helpful to have the output of the following SELECT: SELECT * FROM creator_layouts WHERE layout_id = \G -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 --- Comment #4 from Owen Leonard --- Created attachment 77139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77139=edit Bug 20828: Step 4 of moremember is used for Housebound and additional attributes This patch modifies the patron edit process so that "Housebound roles" can be edited as a separate step. To test, apply the patch and open an existing patron's detail page (moremember.tt). Test the "edit" links for 'Housebound roles' and 'Additional attributes and identifiers' and confirm that each opens its own edit page, and saving changes works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21085] Can't edit patrons with housebound module active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085 Owen Leonard changed: What|Removed |Added Blocks||20828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Owen Leonard changed: What|Removed |Added Depends on||21085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21085 [Bug 21085] Can't edit patrons with housebound module active -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 --- Comment #2 from Katrin Fischer --- Created attachment 77138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77138=edit Patron card template We are aware that the values make no sense - it's what you get when you save without changing anything on the form. The form doesn't require any fields, so that could happen by accident. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 Owen Leonard changed: What|Removed |Added Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 --- Comment #1 from Katrin Fischer --- Created attachment 77137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77137=edit Patron card layout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] New: Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 Bug ID: 21092 Summary: Bad template in patron card creator can cause server issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org While creating the PDF file for a patron card batch the CPU goes to 100% and brings the server down. We have seen this behaviour in 2 separate package installations running 17.11.07 so far. We have sadly not been able to make it happen in a dev environment. Filing the report in hope that someone has an idea or seen something similar that will help us to nail down the problem. So far we think the problem is related to 0 values in a patron card template. I will attach screenshots of the layout and patron card template used, when the problem appears. To test: - Add patron card template - Add patron card layout (or use existing) - Create batch of patrons - Export - Click on PDF link - Boom! There is no error, the system just keeps loading. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Nick Clemens changed: What|Removed |Added Attachment #77066|0 |1 is obsolete|| --- Comment #31 from Nick Clemens --- Created attachment 77136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77136=edit Bug 12001: [17.11.X] Remove simple calls to GetMemberAccountRecords I chose not to backport the main patchset as it was big and didn't apply clean, however, this problem seems to be an issue in 17.11.x This patchset removes the calls where only the total is fetched/used Please consider for backport To test: 1 - Have a patron with some fines 2 - View these pages and confirm fine amounts display: circ/circulation.pl opac/opac-main.pl opac/opac-reserve.pl opac/opac-user.pl reserve/request.pl 3 - Apply patch 4 - View pages again, confirm fines display correctly and no errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 --- Comment #1 from Owen Leonard --- Created attachment 77135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77135=edit Bug 21091: Move add item template JavaScript to a separate file This patch moves the JavaScript in the add item template to separate files: 1 JS file and 1 include file containing translatable strings. While moving the JS to cataloging_additem.js I have made some changes to quiet ESLint warnings (spacing, variable definition). To test, apply the patch and open the add item page for an existing record. Test the various JS-driven functionalities: - Table sorting - Table column configuration - Table searching - Table inline edit/delete links (click anywhere in the table row) - Add multiple item form show/hide - Add multiple item warning when adding 100+ items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21090] Description of itemtype group doesn't show when there is an itemtype with the same code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21090 --- Comment #3 from Katrin Fischer --- Hi Owen, - yes, you are not supposed to see the other itemtypes, only the group - no, staff should still display them all We saw this on 17.11 - had no time to retest on master yet :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21091] New: Move add item template JavaScript to a separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Bug ID: 21091 Summary: Move add item template JavaScript to a separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org I would like to modify the add item template (additem.tt) to move JavaScript from the to separate files: cataloging_additem.js and cataloging_additem.inc (for defining translatable strings used in the js). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Mathieu Pelletier changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Mathieu Pelletier --- This does work for me using the second patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #110 from Martin Renvoize --- Code all looks good now, tests all pass and qa script is happy. All my testing seems solid too, passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77124|0 |1 is obsolete|| --- Comment #109 from Martin Renvoize --- Created attachment 77134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77134=edit Bug 19166: DO NOT PUSH Schema updates Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77123|0 |1 is obsolete|| --- Comment #108 from Martin Renvoize --- Created attachment 77133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77133=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77121|0 |1 is obsolete|| --- Comment #106 from Martin Renvoize --- Created attachment 77131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77131=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77122|0 |1 is obsolete|| --- Comment #107 from Martin Renvoize --- Created attachment 77132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77132=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77120|0 |1 is obsolete|| --- Comment #105 from Martin Renvoize --- Created attachment 77130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77130=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77119|0 |1 is obsolete|| --- Comment #104 from Martin Renvoize --- Created attachment 77129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77129=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77118|0 |1 is obsolete|| --- Comment #103 from Martin Renvoize --- Created attachment 77128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77128=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77117|0 |1 is obsolete|| --- Comment #102 from Martin Renvoize --- Created attachment 77127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77127=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77116|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize --- Created attachment 77126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77126=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Martin Renvoize changed: What|Removed |Added Attachment #77115|0 |1 is obsolete|| --- Comment #100 from Martin Renvoize --- Created attachment 77125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77125=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 --- Comment #8 from Owen Leonard --- (In reply to Keshav Gupta from comment #7) > This seems to be some Template data related issue. Is anyone find Solution > for the same??? This bug report confirms that the problem exists, and the lack of a patch on this bug report indicates that there isn't a solution yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard --- This isn't working for me. I'm still getting a 404 error after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #98 from Nick Clemens --- Created attachment 77123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77123=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #99 from Nick Clemens --- Created attachment 77124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77124=edit Bug 19166: DO NOT PUSH Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #97 from Nick Clemens --- Created attachment 77122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77122=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #95 from Nick Clemens --- Created attachment 77120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77120=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #96 from Nick Clemens --- Created attachment 77121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77121=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #93 from Nick Clemens --- Created attachment 77118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77118=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #94 from Nick Clemens --- Created attachment 77119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77119=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #92 from Nick Clemens --- Created attachment 77117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77117=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #91 from Nick Clemens --- Created attachment 77116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77116=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Attachment #77105|0 |1 is obsolete|| Attachment #77106|0 |1 is obsolete|| Attachment #77107|0 |1 is obsolete|| Attachment #77108|0 |1 is obsolete|| Attachment #77109|0 |1 is obsolete|| Attachment #77110|0 |1 is obsolete|| Attachment #77111|0 |1 is obsolete|| Attachment #77112|0 |1 is obsolete|| Attachment #77113|0 |1 is obsolete|| Attachment #77114|0 |1 is obsolete|| --- Comment #90 from Nick Clemens --- Created attachment 77115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77115=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21090] Description of itemtype group doesn't show when there is an itemtype with the same code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21090 --- Comment #2 from Owen Leonard --- Is the ITEMTYPECAT choice supposed to replace all the individual item types it contains? Is ITEMTYPECAT supposed to work in the staff client? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #88 from Nick Clemens --- Created attachment 77113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77113=edit Bug 19166: (follow-up) Adjust table and files and QA issues Move to aqinvoice_adjustment Move to Koha::Acquisition::Invoice::Adjustments Test if variable exists before count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #86 from Nick Clemens --- Created attachment 77111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77111=edit Bug 19166: Correct charset collate Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #89 from Nick Clemens --- Created attachment 77114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77114=edit Bug 19166: DO NOT PUSH Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #85 from Nick Clemens --- Created attachment 77110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77110=edit Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes This patch adds the ADJ_REASON authorised value category tot he atomic update, and fixes code to display a hint of no reasons are defined other minor updates to remove warns in logs To test: Apply patches Run updates Check authorised value categories to see ADJ_REASON exists Add an adjustment, not you have no reaosn drop down Note there is a hint if you hover Add a value to ADJ_REASON add another adjustment, note you can now add reasons (or not) Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #81 from Nick Clemens --- Created attachment 77106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77106=edit Bug 19166: Add the ability to add adjustments to an invoice This patchset adds the ability to add adjustments to an invoice, one can provide a reason, an adjustment amount, select a budget, and choose whether to encumber the funds before the invoice is closed or not To test: 1 - Create a new invoice with or without a shipping cost 2 - Note there are no existing adjustments 3 - Add an adjustment 4 - Submit the form withno changes, nothing happens 5 - Update the adjustment you created, ensure changes are saved but no extra adjustment created 6 - Add another invoice prodiving only reason or amount (you can have 0 value adjustments) 7 - Verify the adjustment total at bottom is correct 8 - Recieve some orders 9 - Verify totals are correct Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #83 from Nick Clemens --- Created attachment 77108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77108=edit Bug 19166: Get correct value for encumbering when open for new lines https://bugs.koha-community.org/show_bug.cgi?id=19166 Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #87 from Nick Clemens --- Created attachment 77112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77112=edit Bug 19166: (follow-up) Reformat the new adjustments markup This follow-up makes some changes to the way invoice adjustments are displayed and added: - Move this section into a to set it off visually from the other sections of the page. - Take the "add adjustment" fields out of the table and display them in a standard way. - Hide the "add adjustment" fields by default, shown via "add an adjustment" link. - Add deletion confirmation to adjustment deletions. To test, add, delete, and change invoice adjustments as instructed in the original test plan. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #82 from Nick Clemens --- Created attachment 77107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77107=edit Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered To test: 1. prove -v t/db_dependent/Budgets.t 2. Should return green Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 --- Comment #84 from Nick Clemens --- Created attachment 77109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77109=edit Bug 19166: (follow-up) Shipment cost is always added to 'spent' Two koha professionals agreed, also it is current behvaiour so this patch removes a change Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Attachment #77104|0 |1 is obsolete|| --- Comment #80 from Nick Clemens --- Created attachment 77105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77105=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Nick Clemens changed: What|Removed |Added Attachment #76995|0 |1 is obsolete|| Attachment #76996|0 |1 is obsolete|| Attachment #76997|0 |1 is obsolete|| Attachment #76998|0 |1 is obsolete|| Attachment #76999|0 |1 is obsolete|| Attachment #77000|0 |1 is obsolete|| Attachment #77001|0 |1 is obsolete|| Attachment #77002|0 |1 is obsolete|| Attachment #77003|0 |1 is obsolete|| Attachment #77004|0 |1 is obsolete|| --- Comment #79 from Nick Clemens --- Created attachment 77104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77104=edit Bug 19166: Database changes Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21088 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21088] Load the correct biblio or item-level link from tracklinks.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21088 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21018 --- Comment #1 from Jonathan Druart --- Is it a duplicate of bug 21018? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21090] Description of itemtype group doesn't show when there is an itemtype with the same code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21090 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Hum, looks ok for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20226] Get rid of CATCODE_MULTI param decision in patron perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
