[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144 Katrin Fischer changed: What|Removed |Added Attachment #77420|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 77421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77421=edit Bug 21144: Add ROADTYPE to default authorised values categories The ROADTYPE category was missing from the default list of authorised value categories available. To test: - Verify ROADTYPE is not listed as authorised value category - Apply patch and run database update - Verify ROADTYPE is now listed - Add an entry, for example: AV = Avenue - Add or edit a patron, verify a pull down with your entry shows on the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18223] Request for ID to be included on patron details of overdue report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18223 Katrin Fischer changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19044] Add BDS integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19044 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19044] Add BDS integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19044 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |Needs Signoff --- Comment #4 from Katrin Fischer --- Hi David, I think because this wasn't set to 'needs sign-off' it wasn't noticed by the testers and now no longer applies :( Please rebase if you are still interested in having this included in Koha and set to 'needs sign-off'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14771] Allow patrons to pick a username
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14771 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|allow patrons to pick a |Allow patrons to pick a |username|username --- Comment #1 from Katrin Fischer --- Still valid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144 --- Comment #1 from Katrin Fischer --- Created attachment 77420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77420=edit Bug 21144: Add ROADTYPE to default authorised values categories The ROADTYPE category was missing from the default list of authorised value categories available. To test: - Verify ROADTYPE is not listed as authorised value category - Apply patch and run database update - Verify ROADTYPE is now listed - Add an entry, for example: AV = Avenue - Add or edit a patron, verify a pull down with your entry shows on the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference can result in unexpected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131 --- Comment #6 from David Cook --- Btw, I am super duper happy to follow a standard, so long as I actually know what the standard is... I see in https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages_2 that the subject line describes the fix and not the problem though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference can result in unexpected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > Hi David, we standardized the commit messages a bit more: > https://wiki.koha-community.org/wiki/Commit_messages > - Start with Bug : > - Describe the fix in the subject, not the problem :) Thanks, Katrin. I actually wrote to koha-devel asking about https://wiki.koha-community.org/wiki/Commit_messages#Examples, when I was writing up this bug report, because I didn't understand the examples. But I realize now that the page actually starts with https://wiki.koha-community.org/wiki/Commit_messages#Good_commit_messages. I had no idea! But according to https://wiki.koha-community.org/wiki/Commit_messages#Subject_line, the prototypical example seems to describe the problem and not the fix :S. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Jonathan Druart --- I guess you have some data inconsistencies, or the bug comes somewhere else. I do not see how it could be related to this bug (I may be wrong ofc). Maybe you will get the same error browsing the acq module? I am resetting to needs signoff in order to get other tests on it, let me know if you have more pointers to give me! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21144] ROADTYPE missing from authorised value categories list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21144] New: ROADTYPE missing from authorised value categories list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144 Bug ID: 21144 Summary: ROADTYPE missing from authorised value categories list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The ROADTYPE authorised value category used on the patron form is missing from the defaults listed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 --- Comment #5 from Katrin Fischer --- Amazingly this is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11969] show patrons star rating on their reading history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14662] Add empty entry to pull down when subfield is mandatory and linked to authorized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Having a go at this :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14662] Add empty entry to pull down when subfield is mandatory and linked to authorized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 --- Comment #6 from Katrin Fischer --- Created attachment 77419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77419=edit Bug 14662: Add empty entries to pull downs on item form for mandatory subfields The code assumed that if a subfield is marked as mandatory, there should be no empty entry in the pull downs. This assumption is not correct, as it leads to the first entry of the pull down being preselected if there is no default set. Which means you will never be alerted of any cataloguing errors and errors will be very hard to find later on. Correct behaviour would be to preselect the empty value when there is no default. This means on saving the item an error message is triggered and the cataloger is forced to set the value. To test: - Adapt your frameworks: - Make 942$c non-mandatory - In 952 make itemtype, classification source and some other pull downs like location or collection mandatory - Add a new item - Verify that the first value of each pull down is preselected, there is no way to trigger the 'required' error - Apply patch - Add a new item - Verify that classification source is preselected according to the DefaultClassificationSource system preference - Verify that the itemtype is preselected according to 942$c in the bibliographic record - Verify all mandatory fields can be set to empty - Verify that you can't save before correctly setting them - Change the 942$c in the record to empty - Add another item - Verify the itemtype is now empty - Change your frameworks and set a default for itemtype (Ex: BK) - Repeat default check with another pull down like collection or location -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21143] New: Mechanism added to permit merging of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21143 Bug ID: 21143 Summary: Mechanism added to permit merging of items Change sponsored?: --- Product: Koha Version: 17.11 Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: emj...@pa.net QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl For enhancement in item maintenance -- it would be helpful at times to be able to merge item records just as we do bibliographic records -- be able to select the fields that we want from each of the items and merge into one. For example, our library has an older copy of an item that has been lost and replaced before the lost item was deleted. It would be nice to take the circulation history of the lost item and merge it onto the new item. This would be possible if all of the fields of the 952 were able to be merged. One could select that the 952$l (total checkouts), 952$m (total renewals), and 952$n (total holds) of the lost item be used on the replacement item. This would help to remind us WHY we chose to replace the item, since it hasn't circulated since being purchased! (isn't that always the way!) This would be much more efficient than deleting the newer item and modifying the lost item with all the information for the current copy. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer --- Hi Pierre-Luc, taking a quick look. The QA script notes some issues: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc FAIL forbidden patterns forbidden pattern: tab char (line 44) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 3) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 37) Please note, that once this is pushed, the new cookie should be documented here: https://wiki.koha-community.org/wiki/Use_of_Cookies I will leave the question of where the Javascript should go to Owen, but feel like it might be better in a separate .js file. I wonder if libraries would like to have this optional for privacy reasons. It might be safer to add a pref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312 Katrin Fischer changed: What|Removed |Added Attachment #72638|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Katrin Fischer changed: What|Removed |Added Attachment #76778|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 77418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77418=edit Bug 21033: Remove few warns in acqui/basket.pl Resolve (line numbers based on 16.11.x): Use of uninitialized value in hash element at acqui/basket.pl line 337. Use of uninitialized value in hash element at acqui/basket.pl line 338. Use of uninitialized value in hash element at acqui/basket.pl line 340. Use of uninitialized value in hash element at acqui/basket.pl line 342. Use of uninitialized value in hash element at acqui/basket.pl line 344. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591. Test plan: If you have older acq data, you may have records in aqorders with field tax_rate_on_ordering is NULL. These orders will trigger the above warns. If you do not have, you could simulate by setting this field to NULL. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21033] Remove few warns in acqui/basket.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8457] Number of results shown in 'scan index' search, doesn't match results found in catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8457 Katrin Fischer changed: What|Removed |Added Summary|No results found on |Number of results shown in |term/phrase click in scan |'scan index' search, |index results list |doesn't match results found ||in catalog --- Comment #11 from Katrin Fischer --- The misunderstanding here might be that we are talking about the results shown when you click on one of the results of the scan - the number shown doesn't match. So: - Search for 'der' with scan (sample data shows 2 entries) - Click on 'der' -> verify different result lists for differnet settings of QueryAutoTruncate For me: - 100 in result list with QueryAutoTruncate Off.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21112] Re-indent staff client cart template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21112 Katrin Fischer changed: What|Removed |Added Attachment #77257|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 77417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77417=edit Bug 21112: Re-indent staff client cart template This patch reindents the template for the staff client cart, basket.tt - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, apply the patch and add multiple items to the cart in the staff client. View the cart and confirm that it looks as it should both in the "brief" and "more details" views. HTML validation before and after the patch should return the same results. Signed-off-by: DEVINIM Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21112] Re-indent staff client cart template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21112 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Devinim, don't forget to change the status to "signed off" :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21112] Re-indent staff client cart template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21112 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21094] Syndetics: always use https instead of http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21094 Katrin Fischer changed: What|Removed |Added Attachment #77292|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 77416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77416=edit Bug 21094: Syndetics: always use https instead of http This patch removes the 'using_https' check in OPAC templates in calls to Syndetics resources. Instead, https is always used. To test, apply the patch and enable Syndetics-related preferences. View the following pages in the OPAC: - Bibliographic detail page - Browse shelf section of the bibliographic detail page - Search results - List contents - Recent comments - Recent comments RSS - User summary page - Circulation history NOTE: I tested with made-up Syndetics credentials. This means my changes didn't make the template explode, but it doesn't confirm conclusively that the resources work. Signed-off-by: John Doe Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21094] Syndetics: always use https instead of http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21094 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21093] Problem when using specify due date with fast add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21093 Katrin Fischer changed: What|Removed |Added Version|17.11 |master --- Comment #2 from Katrin Fischer --- Almost the same issue on master, checkbox will be checked, but clearing it works better: To test: - Set the specify due date option to a date, don't check the checkbox - Enter an unknown barcode - Click on fast add - Add a record - Add an item (don't change the barcode!) - The item is checked out to the patron - Verify: The checkbox is "Remember for session" is checked now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096
Katrin Fischer changed:
What|Removed |Added
Attachment #77271|0 |1
is obsolete||
--- Comment #10 from Katrin Fischer ---
Created attachment 77415
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77415=edit
Bug 21096: Do not display loggedinusername in template
This patch is a little fix for a much bigger hidden issues.
The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")
What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834 $s_userid = $session->param('id') // ''
The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?
Test plan:
Make sure the original issue is fixed
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21096] Garbled username on intranet login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21096 Katrin Fischer changed: What|Removed |Added Summary|Garbled username on |Garbled username on |intranet login page.|intranet login page CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20765] Search for items by acqdate does not work in label batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20765 --- Comment #5 from Katrin Fischer --- Hi Frido, using kohadevbox for testing: Zebra version: Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 --- Comment #13 from Katrin Fischer --- With both patches it works for me as well. I have the 404 for before applying the patch and correct redirects after. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added Attachment #76863|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 77414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77414=edit Bug 21018: Allow uris defined in the item We need to search for uri defined for the itemnumber we passed in parameter. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added Attachment #76601|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 77413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77413=edit Bug 21018: Fix TrackClicks for 952$u Caused by commit 51b6cf2aafbfb45b9fcb072403b986fe3c2add53 Bug 19847: Track links within the records and 404 for others We should also accept uri stored in items.uri (952$u) Test plan: - Turn on TrackClicks - Defined uri for some items - At the OPAC click on the link (from opac-detail.pl) => Without this patch you will get 404 (redirected from tracklinks.pl) => With this patch applied you will be redirected correctly and the linktracker will be filled correctly Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21018] OPAC Resource URL Broken if Tracklinks is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21018 Katrin Fischer changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #10 from Katrin Fischer --- *** Bug 21088 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21088] Load the correct biblio or item-level link from tracklinks.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21088 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21018 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21090] Description of itemtype group doesn't show when there is an itemtype with the same code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21090 Katrin Fischer changed: What|Removed |Added Version|master |17.11 --- Comment #4 from Katrin Fischer --- I can't reproduce the issue on master. So far only confirmed for 17.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer changed: What|Removed |Added Attachment #77395|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 77412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77412=edit Bug 21139: No table in toolbar We do not need this selector, we will not have a table in the toolbar Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer changed: What|Removed |Added Attachment #77392|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 77409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77409=edit Bug 21139: Floating toolbars - Remove unecessary height This patch remove some pixels under the toolbar, they were used by the hidden element. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer changed: What|Removed |Added Attachment #77394|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 77411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77411=edit Bug 21139: Floating toolbar - Resize toolbar on window resize Prior to this patch the toolbar was not resized when the window was resized Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer changed: What|Removed |Added Attachment #77393|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 77410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77410=edit Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize To test: - add/edit a patron - resize the window => Without this patch a horizontal scrollbar appears when resized shorter Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Katrin Fischer changed: What|Removed |Added Attachment #77391|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 77408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77408=edit Bug 21139: Floating toolbar - Remove dup id We should not have twice the same id, we always use fixFloat() on an element with an id and then duplicate this element. The id must be changed (just in case) Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #14 from Victor Grousset/tuxayo --- > The bug title is not very descrpitive, maybe fix in order to lure testers in? "Add fees when overdue notices triggers" ? I'm not sure to understand well enough to be sure if that's the aim. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #13 from Victor Grousset/tuxayo --- Wait, maybe comment 4 is still valid? Or should we move on independently of bug 12769 that might be to wide to manage to make it through? (and which is also in discussion) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Victor Grousset/tuxayo changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #12 from Victor Grousset/tuxayo --- There doesn't seems to be any pending points right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #19 from Barton Chittenden --- Mason, I'm really interested in having this, and I'd be happy to test and sign off if you can rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21141] Batch item modification tool throws error 500 when an itemnumber is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 Victor Grousset/tuxayo changed: What|Removed |Added Summary|Batch item modification |Batch item modification |throws error 500 when an|tool throws error 500 when |itemnumber is invalid |an itemnumber is invalid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21142] Batch item modification tool is corrupted by BOM (byte order mark) in the uploaded file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142 --- Comment #3 from Victor Grousset/tuxayo --- I'm not sure to work on this. Anyone can feel free to take it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21142] Batch item modification tool is corrupted by BOM (byte order mark) in the uploaded file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142 --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 77407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77407=edit Numbers with BOM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21142] Batch item modification tool is corrupted by BOM (byte order mark) in the uploaded file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142 --- Comment #1 from Victor Grousset/tuxayo --- Created attachment 77406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77406=edit Numbers without BOM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21141] Batch item modification throws error 500 when an itemnumber is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21142 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21142] Batch item modification tool is corrupted by BOM (byte order mark) in the uploaded file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21141 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21142] New: Batch item modification tool is corrupted by BOM (byte order mark) in the uploaded file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21142 Bug ID: 21142 Summary: Batch item modification tool is corrupted by BOM (byte order mark) in the uploaded file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grous...@biblibre.com QA Contact: testo...@bugs.koha-community.org It also affects "Item number files" which triggers bug 21141 But it's easier to test with barcodes. And the fix should be the same. == Test plan == 1. Go to Staff › Tools › Batch item modification 2. Upload the file from the attachments (see next comments) named numbers-without-BOM.csv 3. See that it complains about non existing barcodes but the codes look ok 4. Upload the file from the attachments named numbers-with-BOM.csv 5. See that the first line is corrupted. Something like "3131545845784555" If you don't know how to check that my test files are correct. On a Unix-like system do: file numbers-with-BOM.csv file numbers-without-BOM.csv less numbers-with-BOM.csv less numbers-without-BOM.csv -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7547] Printing a sorted cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7547 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #17 from Jonathan Druart --- Since these patches the "Column visibility" button is displayed at the OPAC: https://screenshots.firefox.com/OEOzq6a0aEozv8rU/catalogue.kohadev.org It should not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19291] Make breadcrumbs for OPAC search history consistent with other patron account pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19291 Katrin Fischer changed: What|Removed |Added Attachment #77363|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 77405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77405=edit Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard Followed the test plan and it works. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=21137 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 --- Comment #18 from Katrin Fischer --- Created attachment 77404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77404=edit Bug 21137: Standardize breadcrumbs for tags page Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Katrin Fischer changed: What|Removed |Added Attachment #77397|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Katrin Fischer changed: What|Removed |Added Attachment #77399|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 77402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77402=edit Bug 21137: use logged_in_user from opac-user.pl Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Katrin Fischer changed: What|Removed |Added Attachment #77398|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 77401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77401=edit Bug 21137: Replace USER_INFO with logged_in_user This patch set does several things: - it removes USER_INFO and BORROWER_INFO These 2 variables contained logged-in patron's info. They must be accessed from logged_in_user - Use patron-title.inc for the breadcrumb at the OPAC, for consistencies Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Katrin Fischer changed: What|Removed |Added Attachment #77400|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 77403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77403=edit Bug 21137: Replace BORROWER_INFO with logged_in_user it also removes 'category_type' and 'description' from a couple of opac scripts, they are not needed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Passed QA --- Comment #14 from Katrin Fischer --- Smuggled in a small follow-up - same pattern as patch on bug 19291. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 --- Comment #10 from Katrin Fischer --- Created attachment 77397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77397=edit Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard Followed the test plan and it works. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Katrin Fischer changed: What|Removed |Added Attachment #77376|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 77398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77398=edit Bug 21137: Replace USER_INFO with logged_in_user This patch set does several things: - it removes USER_INFO and BORROWER_INFO These 2 variables contained logged-in patron's info. They must be accessed from logged_in_user - Use patron-title.inc for the breadcrumb at the OPAC, for consistencies Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Katrin Fischer changed: What|Removed |Added Attachment #77377|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 77399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77399=edit Bug 21137: use logged_in_user from opac-user.pl Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21137] Replace BORROWER_INFO and USER_INFO with logged_in_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21137 Katrin Fischer changed: What|Removed |Added Attachment #77378|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 77400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77400=edit Bug 21137: Replace BORROWER_INFO with logged_in_user it also removes 'category_type' and 'description' from a couple of opac scripts, they are not needed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21141] Batch item modification throws error 500 when an itemnumber is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 --- Comment #4 from Victor Grousset/tuxayo --- Note that when uploading a barcode file, there is an error handling logic which displays the invalid numbers. So the fix could be built from there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21141] Batch item modification throws error 500 when an itemnumber is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 --- Comment #3 from Victor Grousset/tuxayo --- Details: Error is here: https://gitlab.com/koha-community/Koha/blob/ce96080f3005be5a63c9f2cab8d4b6c81e9b5b27/tools/batchMod.pl#L580 Because $biblio is undef Because $itemdata is undef (or empty I forgot) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21141] Batch item modification throws error 500 when an itemnumber is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 --- Comment #2 from Victor Grousset/tuxayo --- I'm not sure to work on this. Anyone can feel free to take it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21141] Batch item modification throws error 500 when an itemnumber is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 --- Comment #1 from Victor Grousset/tuxayo --- Actually just one invalid itemnumber is enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21141] New: Batch item modification throws error 500 when an itemnumber is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21141 Bug ID: 21141 Summary: Batch item modification throws error 500 when an itemnumber is invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grous...@biblibre.com QA Contact: testo...@bugs.koha-community.org Error example: Can't call method "title" on an undefined value at /home/koha/src/tools/batchMod.pl line 591, <$fh> line 6. == Test plan == 1. Create a file named valid-itemnumbers.csv with valid itemnumbers With the following structure: 5456 5495 6546 2. Go to Staff › Tools › Batch item modification 3. Tick "Item number file" 4. Upload the file (click "continue") 5. See that it works 6. Create a file named invalid-itemnumbers.csv with invalid itemnumbers 7. Retry 8. See that it fails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #20 from Jonathan Druart --- Created attachment 77396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77396=edit Bug 20044: Fix input_marceditor selectors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #11 from Owen Leonard --- (In reply to Jonathan Druart from comment #10) > Or without patches from this bug, i.e. with patches from bug 20365? I have this problem on master, only happens after applying this patch set (not with the patch dependencies). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044
--- Comment #19 from Jonathan Druart
---
I do on debian, both Firefox 61.0.1 (64-bit) and Chromium Version 67.0.3396.87
It comes from select2.inc:
8 width: function() {
9 var width = this.element.outerWidth();
After this line width is always = 0
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 --- Comment #10 from Jonathan Druart --- I do not recreate that, could you confirm you do not have this issue on master? Or without patches from this bug, i.e. with patches from bug 20365? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #10 from Owen Leonard --- Created attachment 77395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77395=edit Bug 21139: No table in toolbar We do not need this selector, we will not have a table in the toolbar Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #8 from Owen Leonard --- Created attachment 77393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77393=edit Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize To test: - add/edit a patron - resize the window => Without this patch a horizontal scrollbar appears when resized shorter Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #7 from Owen Leonard --- Created attachment 77392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77392=edit Bug 21139: Floating toolbars - Remove unecessary height This patch remove some pixels under the toolbar, they were used by the hidden element. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Owen Leonard changed: What|Removed |Added Attachment #77379|0 |1 is obsolete|| Attachment #77380|0 |1 is obsolete|| Attachment #77381|0 |1 is obsolete|| Attachment #77382|0 |1 is obsolete|| Attachment #77383|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 77391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77391=edit Bug 21139: Floating toolbar - Remove dup id We should not have twice the same id, we always use fixFloat() on an element with an id and then duplicate this element. The id must be changed (just in case) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 --- Comment #9 from Owen Leonard --- Created attachment 77394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77394=edit Bug 21139: Floating toolbar - Resize toolbar on window resize Prior to this patch the toolbar was not resized when the window was resized Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21139] The floating toolbars have some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21139 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044 --- Comment #18 from Owen Leonard --- (In reply to Jonathan Druart from comment #17) > There is something wrong with the select2: > https://screenshots.firefox.com/LinttprCI59Mq0Jn/pro.kohadev.org I do not see this problem with Firefox on Windows 10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21140] New: Mechanism added to import functionality & cataloging re: MARC21 fields 035 & 001, frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21140 Bug ID: 21140 Summary: Mechanism added to import functionality & cataloging re: MARC21 fields 035 & 001, frameworks Change sponsored?: --- Product: Koha Version: 17.11 Hardware: PC OS: Windows Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: emj...@pa.net QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Would like to see the following enhancements to import functionality: 1. When importing a bibliographic record into Koha, the imported 001 would automatically move to the 035$a. Would like to see the following enhancements to cataloging: 1. Have the option to have the 999$c copied into the 001 when the bibliographic record is initially saved. 2. The ability to select which framework we wish to have as the default framework. This would permit us to better follow the cataloging rules and practices governed by AACR2r, RDA, LC, and local practice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference can result in unexpected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131 --- Comment #4 from Katrin Fischer --- Hi David, we standardized the commit messages a bit more: https://wiki.koha-community.org/wiki/Commit_messages - Start with Bug : - Describe the fix in the subject, not the problem :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference can result in unexpected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference can result in unexpected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131 Katrin Fischer changed: What|Removed |Added Attachment #77389|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 77390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77390=edit Bug 21131: Remove the TinyMCE.isDirty() check that caused unexpected behaviour When using the WYSIWYG editor for system preferences, the editor only updates the textarea element if the content is different from the original content. This means if you change a system preference and then change it back to the original content, the textarea will have the 2nd last change you made. This patch removes the TinyMCE.isDirty() check, which was responsible for comparing the original and changed content. Every input/keydown/dragend or TinyMCE command will cause the textarea element to be updated and trigger the input event which causes the "modified" class to be added to the element, so that the system preference can be saved. __TEST PLAN__ _Before applying_ 0. Change "UseWYSIWYGinSystemPreferences" to "Show" 1. Change "opaccredits" to "123a" 2. Click "Save all OPAC preferences" 3. Reload the page 4. Change "opaccredits" to "123" 5. Change "opaccredits" to "123a" 6. Click "Save all OPAC preferences" 7. Reload the page 8. Note that "opaccredits" says "123" _Apply the patch_ _After applying_ 1. Change "opaccredits" to "123a" 2. Change "opaccredits" to "123" 3. Click "Save all OPAC preferences" 4. Reload the page 5. Note that "opaccredits" says "123" (and not "123a") 6. Change "opaccredits" to "1234" 7. Click "Save all OPAC preferences" 8. Reload the page 9. Note that "opaccredits" says "1234" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard --- I get an error when I try to view detail.pl: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.created_by' in 'field list' at /home/vagrant/kohaclone/Koha/Objects.pm line 269 at /home/vagrant/kohaclone/C4/Templates.pm line 122 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference can result in unexpected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131 Owen Leonard changed: What|Removed |Added Attachment #77322|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 77389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77389=edit Bug 21131 - Changing and restoring a WYSIWYG preference can result in unexpected behaviour When using the WYSIWYG editor for system preferences, the editor only updates the textarea element if the content is different from the original content. This means if you change a system preference and then change it back to the original content, the textarea will have the 2nd last change you made. This patch removes the TinyMCE.isDirty() check, which was responsible for comparing the original and changed content. Every input/keydown/dragend or TinyMCE command will cause the textarea element to be updated and trigger the input event which causes the "modified" class to be added to the element, so that the system preference can be saved. __TEST PLAN__ _Before applying_ 0. Change "UseWYSIWYGinSystemPreferences" to "Show" 1. Change "opaccredits" to "123a" 2. Click "Save all OPAC preferences" 3. Reload the page 4. Change "opaccredits" to "123" 5. Change "opaccredits" to "123a" 6. Click "Save all OPAC preferences" 7. Reload the page 8. Note that "opaccredits" says "123" _Apply the patch_ _After applying_ 1. Change "opaccredits" to "123a" 2. Change "opaccredits" to "123" 3. Click "Save all OPAC preferences" 4. Reload the page 5. Note that "opaccredits" says "123" (and not "123a") 6. Change "opaccredits" to "1234" 7. Click "Save all OPAC preferences" 8. Reload the page 9. Note that "opaccredits" says "1234" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21131] Changing and restoring a WYSIWYG preference can result in unexpected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21131 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Katrin Fischer changed: What|Removed |Added Attachment #77175|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 77388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77388=edit Bug 21099: Reposition floating toolbars earlier To recreate: - Go to the advanced search form - scrolldown to position the toolbar on top of the window - scrollup https://screenshots.firefox.com/NnkFg3iOXqLPxfkd/pro.kohadev.org The toolbar should have been repositioned earlier Test plan: Edit a patron - scrolldown - scrollup - unfold the form in the header (tab "Search patrons", link "[+]") - scrolldown - scrollup Advanced search scrolldown scrollup You should notice the difference with and without this patch Signed-off-by: Pierre-Luc Lapointe Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21099] Floating toolbars reposition too late
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21099 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21092] Bad template in patron card creator can cause server issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21092 --- Comment #8 from Katrin Fischer --- Thx! We haven't been able yet to narrow it down more, but it's a little scary. So would be nice to figure out what happens there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19039] Results of virtual shelves (lists) not sortable by date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19039 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- After creating a list which is sorted by default by date added, when I view it in the OPAC the "Sort by" dropdown doesn't have "Date added" preselected. Everything else looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch | items.homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011 --- Comment #8 from Katrin Fischer --- Idea: no itemtype set. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch | items.homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > Some help with -h would be nice, but not blocker. Yes, the idea is to collect ideas first. Then it will certainly rewritten depending on the needs we found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20509] Data consistency - authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20509] Data consistency - authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509 Katrin Fischer changed: What|Removed |Added Attachment #76538|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 77386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77386=edit Bug 20509: Search for not defined authority codes This patch adds a new check in misc/maintenance/search_for_data_inconsistencies.pl to search for not defined authority codes. Test plan: Set some auth_header.authtypecode to not defined authority codes in Koha (UPDATE auth_header SET authtypecode="XXX" WHERE authid=42;) Then run `misc/maintenance/search_for_data_inconsistencies.pl` Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20509] Data consistency - authority types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509 --- Comment #5 from Katrin Fischer --- Created attachment 77387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77387=edit Bug 20509: Add to script documentation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21011] Data inconsistencies - items.holdingbranch | items.homebranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21011 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
