[Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 Saiful Amin changed: What|Removed |Added CC||saiful@semanticconsulting.c ||om --- Comment #15 from Saiful Amin --- (In reply to Nick Clemens from comment #12) > Created attachment 76807 [details] [review] > Bug 20564: Don't use system to unzip files > > To test: > 1 - Setup a zip file for patron images and cover images > 2 - Test each tool > 3 - Get a '500 error' after upload (note images do upload and attach) > 4 - Apply patch > 5 - Restart all the things > 6 - Test agtain, uploads should complete and results display This is great patch, except for a typo. It worked only after I changed this line in tools/picture-upload.pl [17.11.5]: qx/unzip $filename -d $dirname/; with this: qx/unzip $tempfile -d $dirname/; The patch can be modified accordingly before it can be signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18609] Make attachment of MARC records for list/cart email optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18609 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 2172 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2172] Cart attaches an iso2709 file, which confuses 99% of patrons.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2172 --- Comment #4 from Katrin Fischer --- *** Bug 18609 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 --- Comment #2 from Katrin Fischer --- Created attachment 77724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77724&action=edit Bug 19500: Make module names on letters overview page translatable While the module pull down on adding and editing a letter is written out and fully translatable, the overview page showed the internal 'module code'. Patch also renames the "Members" module into the "Patrons" module to match Koha's terminology. To test: - Before applying the patch: - Add or edit a notice, look at the pull down for module - Go back to the overview page - Verify the module names don't match - Apply the patch: - Check again, pull downs should now match - Verify that Members is now Patrons everywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19500] Make module names on letters overview page translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Katrin Fischer changed: What|Removed |Added Summary|Difference in Koha module |Make module names on |names for notices linked to |letters overview page |Holds/Reserves |translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #77720|0 |1 is obsolete|| --- Comment #78 from Charles Farmer --- Created attachment 77723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77723&action=edit Bug 11297 - Modify Z3950server schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #77718|0 |1 is obsolete|| --- Comment #76 from Charles Farmer --- Created attachment 77721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77721&action=edit Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #77719|0 |1 is obsolete|| --- Comment #77 from Charles Farmer --- Created attachment 77722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77722&action=edit Bug 11297 - Add atomicupdate patch and modify kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #75 from Charles Farmer --- All we changed inside the JS was a datatable sort, but the whole JS got accidentally bundled inside one the previous patches when the JS code was moved at the bottom of the page. I went ahead and reread every last patches we submitted to make sure to carry only what was necessary. Back to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21209] New: When trying to edit housebound roles, the edit button goes to patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21209 Bug ID: 21209 Summary: When trying to edit housebound roles, the edit button goes to patron attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Once the patron has defined housebound roles, the edit button goes to the patron attributes page. To reproduce : 1) Make sure the HouseboundModule is enabled in system preferences 2) Go to a patron file 3) Next to Housebound roles, click on "Add" 4) Check "Yes" next to one of the two roles (or both) 5) Click "Save" 6) The "Add" button is now "Edit", click on it The page is the one to edit patron attributes and not housebound roles. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #72063|0 |1 is obsolete|| --- Comment #74 from Charles Farmer --- Created attachment 77720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77720&action=edit Bug 11297 - Modify Z3950server schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #72062|0 |1 is obsolete|| --- Comment #73 from Charles Farmer --- Created attachment 77719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77719&action=edit Bug 11297 - Add atomicupdate patch and modify kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Attachment #72061|0 |1 is obsolete|| --- Comment #72 from Charles Farmer --- Created attachment 77718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77718&action=edit Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Caroline Cyr La Rose --- Names are displaying fine now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 --- Comment #2 from Jonathan Druart --- Created attachment 77717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77717&action=edit Bug 21208: Fix housebound deliverer/chooser names When creating a housebound visit, the names of the chooser and deliverer are the same as the housebound patron (even though the housebound patron does not have chooser and deliverer roles). It has been caused by: commit 5f80977875ff124d411f2cd89de4a944fa9c27af Bug 18403: Use patron-title.inc when hidepatronname is used patron-title.inc now starts looking for a variable named "patron", which exists in members/housebound. A better fix could be to renamed this "patron" variable tested by patron-title.inc, but at first glance it's the only place this issue exists. Test plan: 1- Make sure HouseboundModule is enabled in system preferences 2- Go to a patron file (Patron A) 3- Edit this patron's housebound roles to Chooser 4- Go to another patron file (Patron B) 5- Edit this patron's housebound roles to Deliverer 6- Go to a third patron's file (Patron C) 7- Go to the Housebound tab 8- Fill out the housebound profile for Patron c 9- Click on "Add a new delivery" 10- Fill out day and time 11- Check the Chooser drop down 12- Check the Deliverer drop down 13- Save the delivery 14- Notice the Chooser and Deliverer names are correct 15- Click on the name of the Chooser, it goes to Patron A's file 16- Go back and click on the name of the Deliverer, it goes to Patron B's file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart changed: What|Removed |Added Blocks||21208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Jonathan Druart changed: What|Removed |Added Depends on||18403 --- Comment #1 from Jonathan Druart --- Caused by: commit 5f80977875ff124d411f2cd89de4a944fa9c27af Bug 18403: Use patron-title.inc when hidepatronname is used Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #71 from Charles Farmer --- I'll fail it for now, just to explicitly show that this shouldn't be tested as-is. The patch already had to be rebased anyway because of bug 19436. The modification you're pointing at shouldn't take too long. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED Severity|normal |major Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Maryse Simard changed: What|Removed |Added Attachment #77545|0 |1 is obsolete|| --- Comment #5 from Maryse Simard --- Created attachment 77716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77716&action=edit Bug 19991: use Modern::Perl in OPAC perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; errors/400.pl errors/401.pl errors/402.pl errors/403.pl errors/404.pl errors/500.pl opac-account-pay-paypal-return.pl opac-alert-subscribe.pl opac-authorities-home.pl opac-authoritiesdetail.pl opac-browser.pl opac-ics.pl opac-image.pl opac-imageviewer.pl opac-messaging.pl opac-modrequest-suspend.pl opac-modrequest.pl opac-mymessages.pl opac-overdrive-search.pl opac-passwd.pl opac-patron-image.pl opac-privacy.pl opac-ratings-ajax.pl opac-ratings.pl opac-readingrecord.pl opac-renew.pl opac-sendshelf.pl opac-serial-issues.pl opac-showreviews.pl opac-suggestions.pl opac-tags_subject.pl opac-topissues.pl opac-user.pl sco/help.pl sco/printslip.pl sco/sco-patron-image.pl svc/overdrive_proxy svc/suggestion unapi Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19991] use Modern::Perl in OPAC perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19991 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 Jonathan Druart changed: What|Removed |Added Depends on||18276 --- Comment #2 from Jonathan Druart --- Caused by: commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What|Removed |Added Blocks||21168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 [Bug 21168] Error on circ/returns.pl after deleting checked-in item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 --- Comment #1 from Jonathan Druart --- Created attachment 77715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77715&action=edit Bug 21168: Handle deleted checked-in items on checking in circ/returns.pl generates a server error when attempting to checkin an item while the list of previously-returned items contains an item that has been deleted. Error text: Can't call method "biblio" on an undefined value at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 606. Test plan: - checkout two items - checkin item1 - on a separate tab, delete item1 - on the original tab (which still shows item1 in the list of Checked-In Items), attempt to check in item2 => No error appears -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21168] Error on circ/returns.pl after deleting checked-in item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21168 Jonathan Druart changed: What|Removed |Added Version|17.05 |master Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20631] C4::Acounts claims to use ReturnLostItem but doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20631 Maryse Simard changed: What|Removed |Added Attachment #77603|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 77714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77714&action=edit Bug 20631: Remove unused RemoveLostItem from C4::Accounts RemoveLostItem was 'used' in C4::Accounts, but is not actually used there. Call has been removed by commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82 Bug 15896 - Use Koha::Account::pay internally for makepayment To test: - Verify that the routine was actually not used! Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21208] New: Housebound deliverer/chooser have wrong name when creating a visit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21208 Bug ID: 21208 Summary: Housebound deliverer/chooser have wrong name when creating a visit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When creating a housebound visit, the names of the chooser and deliverer are the same as the housebound patron (even though the housebound patron does not have chooser and deliverer roles). To reproduce : 1- Make sure HouseboundModule is enabled in system preferences 2- Go to a patron file (Patron A) 3- Edit this patron's housebound roles to Chooser 4- Go to another patron file (Patron B) 5- Edit this patron's housebound roles to Deliverer 6- Go to a third patron's file (Patron C) 7- Go to the Housebound tab 8- Fill out the housebound profile for Patron c 9- Click on "Add a new delivery" 10- Fill out day and time 11- Check the Chooser drop down, notice the only choice is Patron C and not Patron A, choose Patron C anyway 12- Check the Deliverer drop down, notice the only choice is Patron C and not Patron B, choose Patron C anyway 13- Save the delivery 14- Notice the Chooser and Deliverer are both Patron C 15- Click on the name of the Chooser, it goes to Patron A's file 16- Go back and click on the name of the Deliverer, it goes to Patron B's file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Maryse Simard changed: What|Removed |Added Attachment #77706|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 77713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77713&action=edit Bug 19390: Make jQuery selector more specific, so OPAC view link can open in new tab The OPAC view link in the staff result list already had a target="_blank", but it didn't work, because of the JavaScript for the result list browser in staff. The JavaSript code was looking for the links to the detail page in staff and this also selected the link to the detail page in OPAC. By changing detail.pl to \detail.pl opac-detail.pl will no longer be selected. To test: - Search in the staff interface - Click "OPAC view" links in staff result lists - Click "OPAC view' links in detai page - Verify both now open in a new tab - Click other links and test that navigation (previous, next, return to results) works as expected - Inside the staff client, you should see something like searchid=scs_1533922927978 added to the URLs Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21164] Fix alignment on new basket form in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21164 Pierre-Luc Lapointe changed: What|Removed |Added Attachment #77496|0 |1 is obsolete|| --- Comment #2 from Pierre-Luc Lapointe --- Created attachment 77712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77712&action=edit Bug 21164: Fix alignment on new basket form in acquisitions This patch removes some unnecessary " "'s from the template for creating a new basket in acquisitions. This fixes the alignment on the form fields. To test, apply the patch and go to Acquisitions -> Vendor -> New basket. All the form fields should be correctly left-aligned with each other. Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21164] Fix alignment on new basket form in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21164 Pierre-Luc Lapointe changed: What|Removed |Added CC||pierre-luc.lapointe@inLibro ||.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21185] Incorrect title tag on tags review page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21185 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21185] Incorrect title tag on tags review page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21185 Maryse Simard changed: What|Removed |Added Attachment #77588|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 77711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77711&action=edit Bug 21185: Incorrect title tag on tags review page This patch corrects the title tag on the tags review page. To test, apply the patch and go to Tools -> Tags. The page title (probably shown in the browser tab) should start with "Koha ->" instead of "Home ->". Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21157] Improve style of OPAC login modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21157 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21034] Re-indent circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Owen Leonard changed: What|Removed |Added Attachment #76656|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 77710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77710&action=edit Bug 21034: Re-indent circulation.tt This patch reindents the template for the checkout page, circulation.tt: - Trailing spaces removed - Indentation changed to a consistent 4 spaces - Markup indentation made more consistent To test, view the checkout page under various circumstances: - No card number submitted - Name submitted (patron search results) - Card number submitted - Restricted patron - Patron with circulation messages - On-site checkouts - Check all tabs: checkouts, relatives' checkouts holds, article requests, restrictions, clubs HTML validation before and after the patch should return the same results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18480] Get rid of unwanted / distracting link in patron search for fund owner
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20690] Update two-column templates with Bootstrap grid: Acquisitions part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20690 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20672] Update two-column templates with Bootstrap grid: Acquisitions part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20672 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #25 from Owen Leonard --- Created attachment 77708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77708&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard changed: What|Removed |Added Attachment #77165|0 |1 is obsolete|| Attachment #77166|0 |1 is obsolete|| Attachment #77167|0 |1 is obsolete|| --- Comment #24 from Owen Leonard --- Created attachment 77707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77707&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a , with the preference name as the and the description as the . - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #26 from Owen Leonard --- Created attachment 77709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77709&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19500] Difference in Koha module names for notices linked to Holds/Reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit | |y.org | Component|Notices |I18N/L10N Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Severity|enhancement |minor CC||frede...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 --- Comment #1 from Katrin Fischer --- Created attachment 77706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77706&action=edit Bug 19390: Make jQuery selector more specific, so OPAC view link can open in new tab The OPAC view link in the staff result list already had a target="_blank", but it didn't work, because of the JavaScript for the result list browser in staff. The JavaSript code was looking for the links to the detail page in staff and this also selected the link to the detail page in OPAC. By changing detail.pl to \detail.pl opac-detail.pl will no longer be selected. To test: - Search in the staff interface - Click "OPAC view" links in staff result lists - Click "OPAC view' links in detai page - Verify both now open in a new tab - Click other links and test that navigation (previous, next, return to results) works as expected - Inside the staff client, you should see something like searchid=scs_1533922927978 added to the URLs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19271] Show vendor name and format prices on ordered/spent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19271 --- Comment #1 from Katrin Fischer --- Created attachment 77705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77705&action=edit Bug 19271: Show vendor name and format prices on ordered/spent lists Improvements to the display of lists of ordered and received orders: - Format prices according to CurrencyFormat system preference - Show the vendor's name instead of the internal number To test: - Make sure you have some pending and received orders - Access the Spent and Ordered pages by clicking on the amount ordered or spent on the acq start page - Verify that - All price information is shown according to CurrencyFormat - Vendor name shows -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19271] Show vendor name and format prices on ordered/spent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19271 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19271] Show vendor name and format prices on ordered/spent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19271 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Summary|Show vendor name instead of |Show vendor name and format |internal number on |prices on ordered/spent |ordered/spent lists |lists -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard changed: What|Removed |Added Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Owen Leonard changed: What|Removed |Added Attachment #77191|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 77704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77704&action=edit Bug 15287: Use font-awesome on the OPAC This patch replaces Bootstrap's glyphicons with Font Awesome icons. To test, apply the patch and clear your browser cache and regenerate the OPAC CSS from the LESS file if necessary. Check these icons and confirm they look correct: - Cart and Lists icons in the OPAC header - User icon in the header when the browser window is narrow - Languages menu when multiple languages are installed and the OpacLangSelectorMode system preference is "top" or "both top and footer." - Set the SuspendHoldsOpac system preference to "allow" and log in to the OPAC as a user who has one or more holds. - Check the appearance of the "suspend" and "resume" buttons both in the table of holds and at the bottom. - With one or more clubs defined, log in to the OPAC and check the "Clubs" tab on the user summary page. The "Enroll" and "Cancel enrollment" buttons should look correct. - On the "your messaging" tab in the OPAC, the "Digests only" information icon should look correct. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15287] Use font-awesome on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15287 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Blocks||21206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Blocks|21204 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 [Bug 21204] Move C4::Acquisition code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Depends on||21184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 Jonathan Druart changed: What|Removed |Added Depends on|21184 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 Jonathan Druart changed: What|Removed |Added Blocks||21204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 [Bug 21204] Move C4::Acquisition code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21204] Move C4::Acquisition code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21204 Jonathan Druart changed: What|Removed |Added Depends on||21184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21184 [Bug 21184] C4::Items - Remove GetBarcodeFromItemnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21203] ILS-DI - GetRecords crashes on non-existent records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 Jonathan Druart changed: What|Removed |Added Blocks||21202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 --- Comment #1 from Jonathan Druart --- Created attachment 77703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77703&action=edit Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for the last 3 patrons who checked out the items. I have no idea if it is a desired effects but, as this code has been there for a very long time (2005), I suspect it's not. The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say anything about the checkouts info. Test plan: hit /ilsdi.pl?service=GetRecords&id=1 and confirm the info about items are displayed correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 Jonathan Druart changed: What|Removed |Added Depends on||21203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21203 [Bug 21203] ILS-DI - GetRecords crashes on non-existent records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 --- Comment #1 from Jonathan Druart --- Created attachment 77702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77702&action=edit Bug 21207: Remove unused RM C4::Overdues::GetItems sub Test plan: git grep GetItems | grep -v GetItemsInCollection | grep -v GetItemsForInventory | grep -v GetItemsInfo | grep -v GetItemsLocationInfo | grep -v GetItemsAvailable | grep -v GetItemsByBiblioitemnumber should not return any occurrences of code in perl scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart changed: What|Removed |Added Depends on||21207 --- Comment #23 from Jonathan Druart --- Bug 21207 - C4::Overdues::GetItems is not used Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 [Bug 21207] C4::Overdues::GetItems is not used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Jonathan Druart changed: What|Removed |Added Blocks||15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21207] New: C4::Overdues::GetItems is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21207 Bug ID: 21207 Summary: C4::Overdues::GetItems is not used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org And should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #5 from Jonathan Druart --- This is ready for testing, no test plan provided. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #4 from Jonathan Druart --- The whole dependency tree has been pushed to https://gitlab.com/joubu/Koha/commits/bug_21206 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart changed: What|Removed |Added Blocks||21206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Depends on||21205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #2 from Jonathan Druart --- Created attachment 77700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77700&action=edit Bug 21206: Remove GetItem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #1 from Jonathan Druart --- Created attachment 77699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77699&action=edit Bug 21206: Replace C4::Items::GetItem Note: This is here for information purpose, feel free to test it if you wan to play with it. TODO: C4::Reserves::_get_itype is not longer in use No more GetItem must be returned by: git grep GetItem|grep -v GetItemsAvailableToFillHoldRequestsForBib|grep -v GetItemsForInventory|grep -v GetItemsInfo|grep -v GetItemsLocationInfo|grep -v GetItemsInCollection|grep -v GetItemCourseReservesInfo|grep -v GetItemnumbersFromOrder|grep -v GetItemSearchField|grep -v GetItemTypesCategorized|grep -v GetItemNumbersFromImportBatch|cut -d':' -f1|sort|uniq -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 --- Comment #3 from Jonathan Druart --- Created attachment 77701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77701&action=edit Bug 21206: Fix Returns.t we are calling several times effective_itemtype Must be fixed later -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Jonathan Druart changed: What|Removed |Added Depends on||21206 --- Comment #10 from Jonathan Druart --- Bug 21206 - C4::Items - Remove GetItem Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Jonathan Druart changed: What|Removed |Added Blocks||18252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 [Bug 18252] Move C4::Items code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21206] New: C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Bug ID: 21206 Summary: C4::Items - Remove GetItem Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Let's use Koha::Items! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #37 from Owen Leonard --- I've rebased these patches and moved the changes in staff-global.css to staff-global.scss. Staff client CSS will have to be recompiled for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #35 from Owen Leonard --- Created attachment 77696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77696&action=edit Bug 20600: (follow-up) Remove console.log! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205
--- Comment #2 from Jonathan Druart
---
Created attachment 77698
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77698&action=edit
Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls
This is done to ease the move of C4::Items (bug 18252) to Koha::Items
my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber});
will become
my @itemnumbers = $order_object->items->get_column('itemnumbers');
Test plan:
- Create an order with several items
- Receive some items
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #33 from Owen Leonard --- Created attachment 77694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77694&action=edit Bug 20600: (follow-up) Add date range filtering It makes more sense to be able to filter placed and updated dates by range. This patch adds that. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #36 from Owen Leonard --- Created attachment 77697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77697&action=edit Bug 20600: (follow-up) Move template JavaScript to the footer This patch moves the ILL requests template's JavaScript to the footer. Also changed: - Removed unused jQuery checkboxes plugin - Some tags have been corrected to be self-closing. - Title tag has been corrected - Table row limit of 10 has been removed in favor of accepting default used elsewhere. To test, apply the patch and follow the original test plan for this bug. Everything should work as expected. Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #34 from Owen Leonard --- Created attachment 77695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77695&action=edit Bug 20600: (follow-up) Fix filtering There was a bug whereby filtering by date would fail if the selected date syspref was set to dmydot or metric. Rather than use the display date value, We now use the non-display date value that is always in a predictable ISO8601 format to construct the Date objects used for comparison. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #32 from Owen Leonard --- Created attachment 77693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77693&action=edit Bug 20600: (follow-up) Remove date formatting It is not required Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard changed: What|Removed |Added Attachment #75848|0 |1 is obsolete|| Attachment #75849|0 |1 is obsolete|| Attachment #75850|0 |1 is obsolete|| Attachment #75851|0 |1 is obsolete|| Attachment #75852|0 |1 is obsolete|| Attachment #75853|0 |1 is obsolete|| Attachment #75871|0 |1 is obsolete|| --- Comment #30 from Owen Leonard --- Created attachment 77691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77691&action=edit Bug 20600: Add filtering of ILL requests in list This patch adds the ability for the ILL request list in the staff interface to be filtered by a number of criteria: - Status - Date placed - Date modified - Pickup branch - Borrower card number To test: 1) Apply patch 2) Ensure you have a reasonable range of ILL requests created 3) Navigate to the "View ILL requests" page 4) Choose one or more filtering criteria 5) Click "Search" 6) Observe the results are filtered to match the selected criteria 7) Click "Clear" 8) Observe your results are returned to their initial state 9) Repeat steps 4 -> 6 until you are happy. Dates supplied by the /api/v1/illrequests API route were not conforming to the preference specified by the dateformat syspref. This patch addresses that. It has been addressed as part of this bug since we are adding filtering of requests by some date fields and, therefore, needed dates in a predictable format. To test: 1) Apply the patch 2) Ensure you have at least one ILL request created 3) Make a request to the /api/v1/illrequests endpoint 4) Observe that dates supplied for "placed_formatted" & "updated_formatted" conform to your dateformat syspref. 5) Change your date format syspref, repeat steps 3 & 4 Signed-off-by: Magnus Enger Works as advertised. Nice enh! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #31 from Owen Leonard --- Created attachment 77692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77692&action=edit Bug 20600: (follow-up) Do not use $_ in loop Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart changed: What|Removed |Added Blocks||21205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21205] C4::Acquisition - Remove GetOrderFromItemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21205 Jonathan Druart changed: What|Removed |Added Depends on||15184 --- Comment #1 from Jonathan Druart --- Koha::Acquisition::Order->items comes from bug 15184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 [Bug 15184] Ability to duplicate existing order lines to a given basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20554] New OPAC CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 Owen Leonard changed: What|Removed |Added Attachment #76524|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
