[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #9 from Katrin Fischer --- Thx! you had me a little worried there :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #8 from Pierre-Marc Thibault --- Hopefully this makes up my mistake. The problem was here and the patch fixes it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Pierre-Marc Thibault changed: What|Removed |Added Attachment #80437|0 |1 is obsolete|| --- Comment #7 from Pierre-Marc Thibault --- Created attachment 80564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80564=edit Bug 21552: Use raw filter for displaying RoutingListNote The RoutingListNote system preference works like other prefs allowing you to insert your own content on the routling list template using HTML. The default text even uses HTML, so it looks broken without this patch. To test: - Add a subscription - Add a new routing list to it - Add some patrons to it - Save - preview routing list - Verify that the note shows and is formatted correctly. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #6 from Pierre-Marc Thibault --- Sorry Katrin, I took the wrong tab to do my tests. I shall corrige this immediately and sign off this ASAP I confirm the validity of your patch. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #5 from Katrin Fischer --- I have no idea as it really should not work as there is a html filter on the element in master. :( Are you on recent master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #4 from Pierre-Marc Thibault --- Hi Katrin, I can confirm that the patch has not been applied. In the reference, I decided to insert the message you see on master : To change this note edit RoutingListNote system preference. and what I see is : To change this note edit RoutingListNote system preference. I don't know why, but I don't have a problem on my side. Do you know why the current code is not working correctly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 --- Comment #3 from Katrin Fischer --- Hi Pierre-Marc, on master it shows for me: To change this note edit RoutingListNote system preference. So the HTML shows unrendered. Can you check if you have the patch applied already and what you put into the preference? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21552] RoutingListNote should use raw filter and display HTML unescaped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21552 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com --- Comment #2 from Pierre-Marc Thibault --- I put some custom html in the RoutingListNote preference and looked at the preview. It does not seem there is a problem in the first place as there are no html nodes in the preview I opened by clicking "Save and preview routing slip". Am I missing a step? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Attachment #80562|0 |1 is obsolete|| --- Comment #15 from Christopher Brannon --- Created attachment 80563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80563=edit Bug 21503: Fix AV to fail to other values To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to the requested shelving location code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Attachment #80558|0 |1 is obsolete|| --- Comment #14 from Christopher Brannon --- Created attachment 80562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80562=edit Bug 21503: Fix AV to fail to other values To Test (Test both detail.pl and opac-detail.pl for functionality): 1) Apply patch (restart_all) 2) Look up an item that has a shelving location with a description defined (opac description too). 3) Remove opac description from shelving location. Refresh opac-detail.pl and note that description fails back to the regular description. Refresh detail.pl and note no change. 4) Remove regular description from shelving location. Refresh opac-detail.pl and detail.pl. Note that both default to the shelving location code. 5) Remove the shelving location from the LOC table all together. Refresh opac-detail.pl and detail.pl. Note that both default to the requested selving location code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Attachment #80545|0 |1 is obsolete|| --- Comment #13 from Christopher Brannon --- Created attachment 80561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80561=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||pierre-marc.thibault@inlibr ||o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 Pierre-Marc Thibault changed: What|Removed |Added Attachment #80559|0 |1 is obsolete|| --- Comment #3 from Pierre-Marc Thibault --- Created attachment 80560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80560=edit Bug 21556: Deleting same record twice leads to fatal software error If you delete a record, confirm the deletion, and try to delete the record and confirm it again befoe the first deletion completes, you'll generate a fatal software error. This patch unbinds the click handlers for the "Delete record" button after the deletion is confirmed and just before the Javascript processes the redirect to the next page in the process. To test: 1) You will need a bibliographic record that is able to be deleted 2) Click "Edit", then "Delete record", then "OK" 3) While the browser is reloading, click "Edit", then "Delete record", then "OK 4) Observe a fatal error such as "Internal server error" or 'Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 406.' 5) Apply the patch 6) Run "restart_all" on kohadevbox (or otherwise restart Plack if running Plack) 7) Navigate to another bibliographic record that is able to be deleted 8) Click "Edit", then "Delete record", then "OK" 9) While the browser is reloading, click "Edit", then "Delete record" 10) Observe that no fatal software error is generated 11) You are redirected to http://localhost:8081/cgi-bin/koha/catalogue/search.pl (on kohadevbox) Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21556] Deleting same record twice leads to fatal software error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21556 Pierre-Marc Thibault changed: What|Removed |Added Attachment #80442|0 |1 is obsolete|| --- Comment #2 from Pierre-Marc Thibault --- Created attachment 80559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80559=edit Bug 21556: Deleting same record twice leads to fatal software error If you delete a record, confirm the deletion, and try to delete the record and confirm it again befoe the first deletion completes, you'll generate a fatal software error. This patch unbinds the click handlers for the "Delete record" button after the deletion is confirmed and just before the Javascript processes the redirect to the next page in the process. To test: 1) You will need a bibliographic record that is able to be deleted 2) Click "Edit", then "Delete record", then "OK" 3) While the browser is reloading, click "Edit", then "Delete record", then "OK 4) Observe a fatal error such as "Internal server error" or 'Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 406.' 5) Apply the patch 6) Run "restart_all" on kohadevbox (or otherwise restart Plack if running Plack) 7) Navigate to another bibliographic record that is able to be deleted 8) Click "Edit", then "Delete record", then "OK" 9) While the browser is reloading, click "Edit", then "Delete record" 10) Observe that no fatal software error is generated 11) You are redirected to http://localhost:8081/cgi-bin/koha/catalogue/search.pl (on kohadevbox) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 --- Comment #12 from Christopher Brannon --- Created attachment 80558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80558=edit Bug 21503: Fix AV to fail to other values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Tomás Cohen Arazi changed: What|Removed |Added Keywords||release-notes-needed QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tomás Cohen Arazi --- Pushed for 18.11. Thanks all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21297] "More lists" screen missing "Select an Existing list" fieldset when all lists are public
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21297 Katrin Fischer changed: What|Removed |Added CC||aratt...@nwacc.edu --- Comment #9 from Katrin Fischer --- *** Bug 21566 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21566] Lists function not displaying lists when trying to add a book to a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21566 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- It's a bit of a strange bug: Bug 21297: Display public lists to existing lists when adding a new item It will be fixed in the upcoming releases (see notes on the bug) *** This bug has been marked as a duplicate of bug 21297 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #18 from Tomás Cohen Arazi --- Pushed for 18.11. Thanks all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21566] Lists function not displaying lists when trying to add a book to a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21566 --- Comment #1 from Owen Leonard --- Sorry if this is a dumb question, but are you logged in as a user who has permission to edit/add to existing lists? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21479] Removing from cart removes 2 items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21479 --- Comment #17 from Jonathan Druart --- Created attachment 80557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80557=edit Bug 21479: Remove the trace if the node does not exist Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21536] t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Pushed for 18.11. Thanks all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21553] Javascript error on rota page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21553 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi --- Pushed for 18.11. Thanks all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #43 from Jonathan Druart --- Created attachment 80555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80555=edit Bug 15836: Handle non-existent regexs For other types of split rules Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #44 from Jonathan Druart --- Created attachment 80556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80556=edit Bug 15836: Fix display input in any situations Fix when switching an existing rule to RegEx Signed-off-by: Christian Stelzenmüller Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #40 from Jonathan Druart --- Created attachment 80552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80552=edit Bug 15836: Mark C4::ClassSource subs DEPRECATED These subs are no longer used from scripts and should be removed. It should be done on a separate bug report given that additional work is needed Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #42 from Jonathan Druart --- Created attachment 80554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80554=edit Bug 15836: Add missing svc script Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #38 from Jonathan Druart --- Created attachment 80550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80550=edit Bug 15836: UI changes The script admin/classsources.pl has been adjusted to follow usual patterns used in other Koha scripts. $op can be add_source, add_source_validate, etc. Deletion steps have been removed (there is a JS confirmation box) to simplify both script and template. Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What|Removed |Added Attachment #80339|0 |1 is obsolete|| Attachment #80340|0 |1 is obsolete|| Attachment #80341|0 |1 is obsolete|| Attachment #80342|0 |1 is obsolete|| Attachment #80343|0 |1 is obsolete|| Attachment #80344|0 |1 is obsolete|| Attachment #80345|0 |1 is obsolete|| Attachment #80346|0 |1 is obsolete|| Attachment #80347|0 |1 is obsolete|| --- Comment #36 from Jonathan Druart --- Created attachment 80548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80548=edit Bug 15836: DB changes Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836
--- Comment #39 from Jonathan Druart
---
Created attachment 80551
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80551=edit
Bug 15836: Add the ability to defined custom methods to split call number in
labels
Currently the call number splitting seems to be mostly implemented for
DDC and LC classifications.
Those are both not very common in some countries.
A lot of libraries use their own custom classification schemes so the call
number
plitting is something that should be individually configurable.
This enhancement adds the ability to define custom splitting rules based
on regular expressions.
How does it work so far?
From C4/Labels/Label.pm there are 3 differents splitting methods defined,
depending on items.cn_source.
if cn_source is "lcc' or 'nlm' we split using Library::CallNumber::LC
if cn_source is 'ddc' we split using a in-house method
Finally there is a fallback method to split on space
And nothing else is done for other cn_source
The idea of this patch is to mimick what was done for the "filing rules" and
add
the ability to define "splitting rules" that will be used by the
"Classification sources".
A classification source will then have:
* a filing rule used to sort items by callnumbers
* a splitting rule used to print labels
To acchieve this goal this enhancement will do the following
modifications at DB level:
* New table class_split_rules
* New column class_sources.class_split_rule
Test plan:
* Execute the update database entry to create the new table and
column.
I. UI Changes
a) Create/modify/delete a filing rule
b) Create/modify/delete a splitting rule
c) Create/modify/delete a classification source
=> A filing rule or splitting rule cannot be removed if used by a
classification source
II. Splitting rule using regular expressions
a) Create a splitting rule using the "Splitting routine" "RegEx"
b) Define several regular expressions, they will be applied one after
the other in the same order you define them.
Something like:
s/\s/\n/g # Break on spaces
s/(\s?=)/\n=/g# Break on = (unless it's done already)
s/^(J|K)\n/$1 / # Remove the first break if callnumber starts with J or K
c) You can test the regular expressions using filling the textarea with
a list of callnumbers. Then click "Test" and confirm the callnumbers are
split how you expected.
d) Finally create a new classification source that will use this new
splitting rule.
III. Print the label!
a) Create a layout. It should have the "Split call numbers" checkbox
ticked, and display itemcallnumber
b) Use this layout to export labels, use items with different
classification source ('lcc', 'ddc', but also the new one you have
create)
=> The callnumbers should have been split according to the regex you
defined earlier!
Notes:
* The update database entry fill the class_sources.class_split_rule
with the value of class_sources.class_sort_rule
If default rules exist it will not work, we should add a note in the
release notes (would be enough?)
* C4::ClassSplitRoutine::* should be moved to Koha::ClassSplitRule,
but it sounded better to keep the same pattern as ClassSortRoutines
* Should not we use a LONGTEXT for class_split_rules.split_regex instead
of VARCHAR(255)?
* class_sources.sql should be filled for other languages before pushed
to master!
IMPORTANT NOTES: The regular expressions are stored as it, and eval is
used to evaluate it (perlcritic raises a warning about it (Expression
form of "eval"). It can lead to serious security issues (execution of
arbitrary code on the server), especially if the modifier 'e' is used.
We could then remedy the situation with one of these following points:
- Assume that this DB data is safe (We can add a new permission?)
- Assume that the data is not safe and deal with possible attack
Cons: how be sure we are exhaustive? Making sure it matches ^s///[^e/]*$
would be enough?
- Use Template Toolkit syntax instead (Really safer?)
[% callnumber.replace('\s', '\n').replace ... %]
- Cut the regex parts: find, replace, modifiers
like we already do for Marc modification template. Cons: we are going to
have escape problems, the "find" and "replace" parts should not be
handle the same way (think "\n", "\\n", "\1", "\s", etc.)
I did not manage to implement this one easily.
Signed-off-by: Christian Stelzenmüller
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #41 from Jonathan Druart --- Created attachment 80553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80553=edit Bug 15836: Add tests Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #37 from Jonathan Druart --- Created attachment 80549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80549=edit Bug 15836: DBIC Schema change Signed-off-by: Christian Stelzenmüller -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14391] Granular permissions for the administration module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #23 from Katrin Fischer --- Rebased and fixed for latest changes on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14391] Granular permissions for the administration module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #22 from Katrin Fischer --- Created attachment 80547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80547=edit Bug 14391: Keep parameters_remaining_permissions for now Since this patch has been written, new references to this permission have been added to the code: - t/db_dependent/api/v1/stockrotationstage.t - t/db_dependent/api/v1/cities.t - admin/overdrive.pl Instead of removing the permission, let's keep it for now and do more clean-up later in separate patches if required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21467] Allow several receipts for a given subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 --- Comment #8 from Jonathan Druart --- Created attachment 80546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80546=edit Bug 21467: Display a summary line per parent_ordernumber This will help to keep track of the different orders for a given subscription. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Attachment #80544|0 |1 is obsolete|| --- Comment #11 from Christopher Brannon --- Created attachment 80545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80545=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Attachment #80521|0 |1 is obsolete|| --- Comment #10 from Christopher Brannon --- Created attachment 80544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80544=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14391] Granular permissions for the administration module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #21 from Katrin Fischer --- Created attachment 80543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80543=edit Bug 14391: (QA follow-up) Fix some typos Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14391] Granular permissions for the administration module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #20 from Katrin Fischer --- Created attachment 80542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80542=edit Bug 14391: (QA follow-up) Resolve POD warn on svc..systempreferences *** WARNING: No items in =over (at line 48) / =back list at line 54 in file svc/config/systempreferences *** WARNING: No items in =over (at line 73) / =back list at line 79 in file svc/config/systempreferences => If you use 'over', you should add 'item'-s. Test plan: Run perldoc svc/config/systempreferences Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14391] Granular permissions for the administration module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14391] Granular permissions for the administration module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Katrin Fischer changed: What|Removed |Added Attachment #80004|0 |1 is obsolete|| Attachment #80005|0 |1 is obsolete|| Attachment #80006|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 80541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80541=edit Bug 14391: Add granular permissions to the administration module So far the administration module only allowed for 2 permissions: - circulation conditions (manage_circ_rules) - everything else (parameters_remaining_permissions) With this patch almost every section of the administration page will have its own granular permission. To test: - Create different staff users: 1) One with parameters_remaining_permissions 2) One with parameters 3) One with catalogue and no parameters 4) One superlibrarian - Apply the patch - Run the database update - Check the staff users: 1) All subpermissions, but manage_circ_rules should be checked 2) Nothing should have changed 3) manage_item_serach_fields shoudl be checked (page had catalogue permission before) 4) Nothing should have changed - Try different settings of the permissions and verify that - Administration page behaves correctly - Administration menu behaves correctly ! You shoudl only see what you have permission for https://bugs.koha-community.org/show_bug.cgi?id=14391 Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10708] Make fine receipt customizable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 --- Comment #9 from Barton Chittenden --- I can't tell if bug 12285 is simply related, or whether it's a duplicate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Barton Chittenden changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10708 CC||bar...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10708] Make fine receipt customizable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 Barton Chittenden changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12285 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21566] New: Lists function not displaying lists when trying to add a book to a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21566 Bug ID: 21566 Summary: Lists function not displaying lists when trying to add a book to a list Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: aratt...@nwacc.edu QA Contact: testo...@bugs.koha-community.org Created attachment 80540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80540=edit Add to a list screen When cataloging a new book, the lists used to appear in drop down fashion after clicking the 'Add to' button. Now, it only seems to allow the creation of a new list when all I want to do is add a book to an existing list. Thank you! Aly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #15 from Katrin Fischer --- We could also start supporting other ASCII characters like ;/% for subfield codes, that would give us more subfields for items to use - but it won't work right now and the upper case letter use is a reality not only for us but other libraries too (see Severine's comment). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- Not sure if we should facilitate MARC deviation ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What|Removed |Added Attachment #80538|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 80539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80539=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What|Removed |Added Attachment #80536|0 |1 is obsolete|| --- Comment #21 from Cori Lynn Arnold --- Comment on attachment 80536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80536 Bug 18823: Fix patch issues This didn't work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #12 from Owen Leonard --- Created attachment 80538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80538=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 Cori Lynn Arnold changed: What|Removed |Added CC||carn...@dgiinc.com Assignee|n...@bywatersolutions.com |carn...@dgiinc.com Status|Needs Signoff |ASSIGNED --- Comment #6 from Cori Lynn Arnold --- Will need to be rebased with depends on bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 DEVINIM changed: What|Removed |Added Attachment #79867|0 |1 is obsolete|| --- Comment #5 from DEVINIM --- Created attachment 80537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80537=edit Bug 20817 - Add ability to retain 9xx fields when adding on order item to existing record Test plan: 1 - Edit the MarcItemFieldsToOrder and MarcFieldsToOrder syspref. For example: MarcItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$c nonpublic_note: 975$d public_note: 975$e loc: 975$f ccode: 975$g price: 975$h replacementprice: 975$i itemcallnumber: 975$j notforloan: 975$m uri: 975$n copyno: 975$o MarcFieldsToOrder price: 975$h 2 - Stage your order file from vendor. (Test file : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57715 ) 3 - Add to basket from staged file 4 - You are notified of duplicates 5 - View duplicates and choose the existing record to order from 6 - The values in the staged file should be used to create the new item(s) (we should not have to set quantity,price, etc) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #20 from Cori Lynn Arnold --- Created attachment 80536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80536=edit Bug 18823: Fix patch issues Tests: 1) Open advanced cataloging editor 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) not that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch 6) Make changes and verify the changes are applied (either through searching again, or through the Staged MARC management in Tools) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #187 from Charles Farmer --- I've submitted a rebased version of the patchset, since there was another SHA1 problem since I last tried to apply. -- Michal, could you give me more information about your install process? I was not able to get the error message you showed, and since the calendar table should be created after bug_17015_part1_create_discrete_calendar.sql, I'm lost. I'm personally using the _english_ web-based installer. I drop the database, git-bz apply 17015, and I visit the intranet page to begin the installation process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #79035|0 |1 is obsolete|| --- Comment #186 from Charles Farmer --- Created attachment 80535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80535=edit Bug 17015: (follow-up) keep kohastructure.sql clean to avoid bugs when installing a fresh koha directly over this patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #4|0 |1 is obsolete|| --- Comment #185 from Charles Farmer --- Created attachment 80534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80534=edit Bug 17015: Fixes to cronjob Fixes a typo in the add_days cronjob. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #3|0 |1 is obsolete|| --- Comment #184 from Charles Farmer --- Created attachment 80533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80533=edit Bug 17015: Fixes to migration script Fixes a few errors in the migration script. When first generation the discrete_calendar table, holidays should now be correctly imported for all branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #2|0 |1 is obsolete|| --- Comment #183 from Charles Farmer --- Created attachment 80532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80532=edit Bug 17015: Improved UI readability * The calendar tool page no longer shows past holidays in the lists on the right side of the page. * Improved wording in the "Hints" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #1|0 |1 is obsolete|| --- Comment #182 from Charles Farmer --- Created attachment 80531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80531=edit Bug 17015: Improve stability for very old loans This patch fixes a crash when calculating fines for hourly loans created before the earliest date in the 'discrete_calendar' table. The SQL call has been altered to find the closest day (using DATEDIFF). QA Green. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #74863|0 |1 is obsolete|| --- Comment #178 from Charles Farmer --- Created attachment 80527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80527=edit Bug 17015: Remove old Koha::Calendar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #0|0 |1 is obsolete|| --- Comment #181 from Charles Farmer --- Created attachment 80530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80530=edit Bug 17015: Updated patch after bug 19204 This is a small modification to bring the patch up-to-date with current master after the changes made in 19204. Tests in db_dependent/Circulation.thave been changed slightly since DiscreteCalendar strictly prevents changing holidays in the past. This patch requires 20660. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #74862|0 |1 is obsolete|| --- Comment #177 from Charles Farmer --- Created attachment 80526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80526=edit Bug 17015: Peformance tests for Koha::DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77607|0 |1 is obsolete|| --- Comment #179 from Charles Farmer --- Created attachment 80528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80528=edit Bug 17015: Code quality fixes on QA feedback Changes: * Koha::DiscreteCalendar->new uses a hashref instead of a hash This meant changing every call to the Calendar and explains why this patch is so big. Most changes are simply adding braces to the new() call. + Added table encoding to atomic update + Added table definition to kohastructure.sql - Removed `repeatable_holidays`, `special_holidays` from kohastructure.sql Also added relevant DROP TABLEs to a new atomicupdate (part3) + Added 'override' param to Koha::DiscreteCalendar Without this param (off by default), edit_holiday will not modify past dates. This caused issues with some tests that required this functionality to work properly. Adding 'override => 1' to the function call will allow past dates to happen, but should only be called for testing. * Holds.t, Hold.t, CalcDateDue.t have been corrected. Prior to his patch, theses tests used hardcoded dates to test calendar functionalities, however, DiscreteCalendar is only usable one year into the past by default. They have been modified to be centered around '$today' * 'use strict; use warnings;' changed to 'use Modern::Perl;' in modified files. * Atomic update no longer takes params * Javascript moved to the bottom of discrete_calendar.tt * Calendar css moved out of tt file and into new discrete_calendar.css * All references to C4::Calendar and Koha::Calendar should now be removed * Some comments corrected All relevant tests passed for me on a fresh database. QA tool green. Test plan has not changed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #77608|0 |1 is obsolete|| --- Comment #180 from Charles Farmer --- Created attachment 80529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80529=edit Bug 17015: Add gen_time to TestBuilder + Adds a gen_time() function to TestBuilder. TestBuilder now passes green. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #74860|0 |1 is obsolete|| --- Comment #175 from Charles Farmer --- Created attachment 80524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80524=edit Bug 17015: Tests for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #74861|0 |1 is obsolete|| --- Comment #176 from Charles Farmer --- Created attachment 80525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80525=edit Bug 17015: Koha now uses the new DiscreteCalendar module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #5 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #4)
> Created attachment 80522 [details] [review]
> Bug 21486: Fix 'AU' for SIP
We should not re-add code we removed :)
One possible fix would be to call unblessed_all_relateds, but we should be more
specific. The problem here is that I have no idea which info is needed in
$ilspatron{items}.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Charles Farmer changed: What|Removed |Added Attachment #74859|0 |1 is obsolete|| --- Comment #174 from Charles Farmer --- Created attachment 80523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80523=edit Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21486] SIP does not return checked out (charged) items on patron_information request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 --- Comment #4 from Jonathan Druart --- Created attachment 80522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80522=edit Bug 21486: Fix 'AU' for SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Christopher Brannon changed: What|Removed |Added Attachment #80152|0 |1 is obsolete|| Attachment #80233|0 |1 is obsolete|| Attachment #80439|0 |1 is obsolete|| --- Comment #9 from Christopher Brannon --- Created attachment 80521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80521=edit Bug 21503: Tests for the existing behavior This patch introduces 7 tests for the current behaviour for the AuthorisedValues template plugin. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/AuthorisedValues.t => SUCCESS: Tests pass, all green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21553] Javascript error on rota page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21553 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Ooops.. I think I introduced this one in the first place during a Stock Rotation rebase.. my bad. Looks good now, thanks for fixing it. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21553] Javascript error on rota page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21553 Martin Renvoize changed: What|Removed |Added Attachment #80514|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 80520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80520=edit Bug 21553: Remove JS error on the Rota view JS error was: ReferenceError: _ is not defined The strings after staff-global.js (for the function _) Test plan: Turn on StockRotation system preference 1) Go to a staff detail page 2) Switch to rota page 3) Check web developer tools Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600
--- Comment #57 from Josef Moravec ---
Comment on attachment 78463
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78463
Bug 20600: Add filtering of ILL requests in list
Review of attachment 78463:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20600=78463)
-
::: Koha/REST/V1/Illrequests.pm
@@ +65,5 @@
> }
> +
> +# Create new "formatted" columns for each date column
> +# that needs formatting
> +foreach(@req_list) {
I do not like this. The date should not be formatted on API level. It should be
left to client/UI.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9775] unitprice should be hidden when creating an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Martin Renvoize changed: What|Removed |Added QA Contact||testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18507] Shibboleth auto-provisioning - Sync
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507 Martin Renvoize changed: What|Removed |Added Assignee|gmcha...@gmail.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #24 from Blou --- Hi Katrin, are you talking about koha-qa.pl ? I seem to have the latest version, and am not getting those messages. Any parameter I'm missing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #70 from Josef Moravec --- One more think on authorised values: generaly it is better to take them in from AuthorisedValues template plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #19 from Cori Lynn Arnold --- Created attachment 80519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80519=edit Bug 18823: Refactor and fix issue with updating import batch record Rebased code with changes from Bug 19263 Added missing function from previous patch to make saves of edits to import batches Changed setting for import batches created by Rancor to 'staged' as there is no mechanism to change them from 'staging' Changes to make batch names work with single quotes "Client's Batch" Changes to fix QA tool issues (i.e. bootstrap button & undef) Tests: 1) Open advanced cataloging editor 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) not that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch 6) Make changes and verify the changes are applied (either through searching again, or through the Staged MARC management in Tools) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #20 from Martin Renvoize --- A useful addition, code works well and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Martin Renvoize changed: What|Removed |Added Attachment #79658|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 80518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80518=edit Bug 20450: (follow-up) Add missing template filters This patch adds two missing template filters as pointed out by the template test. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Martin Renvoize changed: What|Removed |Added Attachment #79605|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 80517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80517=edit Bug 20450: Add collection to item table when placing a hold on a specific copy (OPAC) This patch adds a new collection column to the item table when selecting a specific item for a hold. The column will only appear if at least one item has a collection set. To test, in OPAC: - Place a specific hold on - a record with one or more items with collections - a record with one or more items without collections - Verify the collections display correctly when they exist - Verify the table still works as expected Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] Add collection to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Martin Renvoize changed: What|Removed |Added Attachment #79604|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 80516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80516=edit Bug 20450: Add collection to item table when placing a hold on a specific copy (Intranet) This patch adds a new collection column to the item table when selecting a specific item for a hold. The column will only appear if at least one item has a collection set. To test, in staff: - Place a specific hold on - a record with one or more items with collections - a record with one or more items without collections - Verify the collections display correctly when they exist - Verify the table still works as expected Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #11 from Martin Renvoize --- Checking for digits and word characters as per Jonathans suggestion sounds sane to me... is there really a case out there where a field may contain another character outside that range? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21503] Update AuthorisedValues.pm to fall back to code if description doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21503 Tomás Cohen Arazi changed: What|Removed |Added Attachment #80439|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20896] Move serial enumeration to the right of callnumber on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Makes sense, trivial patch, no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20896] Move serial enumeration to the right of callnumber on staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20896 Martin Renvoize changed: What|Removed |Added Attachment #79534|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 80515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80515=edit Bug 20896: Move serial enumeration after callnumber on intranet detail page The column with serial enumeration/chronology information is moved from the back to the right of itemcallnumber on the intranet detail page. To test: - Apply patch - Look at different detail pages in staff: - 1 or more items have serial enumeration information - no item has serial enumeration informatoin - Verify - itemcallnumber is now followed by serial information, if an item with the field filled in exists for the record - all other functionality, like sorting, works as expected https://bugs.koha-community.org/show_bug.cgi?id=20896 Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21215] Saved SQL reports code improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21215 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- Lots of tabs introduced so we're failing the QA scripts I'm afraid.. Otherwise I like it.. please fix the tabs Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Owen Leonard changed: What|Removed |Added Depends on||21216 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21216 [Bug 21216] Add filter/search options to notices table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #35 from Jonathan Druart --- (In reply to Josef Moravec from comment #34) > Hi Jonathan, > > I have few questions: > > 1. Why do you decide to make new modules under C4 namespace? I have mimicked what was done in C4::ClassSortRules. It sounded better to keep them tied at the same place (ClassSource.pm, ClassSortRoutine.pm and ClassSplitRoutine.pm) > 2. The patches are not applicable on top of bug 14931, should it depend on > it? It's bug 14391, and it does not apply anymore. I will rebase on top when ready. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21216] Add filter/search options to notices table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21216 Owen Leonard changed: What|Removed |Added Blocks||20966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 [Bug 20966] Add column configuration to table of orders in a basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14391] Granular permissions for the administration module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #18 from Jonathan Druart --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc CONFLICT (content): Merge conflict in installer/data/mysql/userpermissions.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #69 from Josef Moravec --- Comment on attachment 80505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80505 Bug 20581: (follow-up) Fix statusalias return Review of attachment 80505: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20581=80505) - ::: Koha/Illrequest.pm @@ +113,5 @@ > > +my $statusalias = $request->statusalias; > + > +Return a request's status alias, if one is defined, otherwise > +return implicit undef Please add the information that status alias is of type Koha::AuthorisedValue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21553] Javascript error on rota page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21553 Owen Leonard changed: What|Removed |Added Attachment #80506|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 80514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80514=edit Bug 21553: Remove JS error on the Rota view JS error was: ReferenceError: _ is not defined The strings after staff-global.js (for the function _) Test plan: Turn on StockRotation system preference 1) Go to a staff detail page 2) Switch to rota page 3) Check web developer tools Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21553] Javascript error on rota page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21553 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
