[Koha-bugs] [Bug 21616] New: Translation toolchain has no tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21616 Bug ID: 21616 Summary: Translation toolchain has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: pasi.kalli...@joensuu.fi QA Contact: testo...@bugs.koha-community.org There are no tests for the translation toolchain. At minimum, there should be tests for extracting translatable strings from TT files, possible tests for creating and updating po-files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21614] Search bar on Stock rotation page displays both [-] and [+] simultaneously
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 --- Comment #1 from Caroline Cyr La Rose --- I'm not sure what is the decision process to choose which search bar to put at the top of a page, but I feel like "Search patrons" is not useful in this case. I would put the same search bar as in "Rotation collections" with Check out, Check in, Renew and Search the catalog, the latter being selected by default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21615] New: "Stock rotation" is at the wrong place in the Tools left side menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21615 Bug ID: 21615 Summary: "Stock rotation" is at the wrong place in the Tools left side menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org I noticed "Stock rotation" is in the "Patrons and circulation" section of the left-hand side menu when we are on the stock rotation page. To reproduce: 1) Activate the stock rotation module in system preferences 2) Go to Tools 3) Notice the "Stock rotation" link is in the "Catalog" section 4) Click on "Stock rotation" 5) Notice the "Stock rotation" link is in the "Patrons and circulation" section in the left-hand side menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21614] New: Search bar on Stock rotation page displays both [-] and [+] simultaneously
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21614 Bug ID: 21614 Summary: Search bar on Stock rotation page displays both [-] and [+] simultaneously Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When I go to the stock rotation page, the search bar at the top of the page is set to "Search patrons" and both [-] and [+] are displayed. To reproduce: 1) Activate stock rotation module in system preferences 2) Go to Tools > Stock rotation 3) Notice the [-] and [+] next to the search bar at the top 4) Try clicking on [-] and [+], nothing happens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #19 from Alex Buckley --- Newly rebased patches. Also fixed warnings from qa test tool. As testing this is reliant on bug 14576 (currently set to 'patch doesnt apply' you may need to wait for the patches on 14576 to be rebased before testing this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #17 from Alex Buckley --- Created attachment 80894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80894=edit Bug 21159: Implementing syspref to enable blanking of item shelving location on issue. This patch builds upon the functionality implemented in bug 14576, by allowing library staff to automatically change the item shelving location of items which are circulated. In the case of this patch it automatically blanks the item shelving locations of items when they are issued if the BlankItemLocationOnCheckout syspref is enabled. t/db_dependent/Circulation/issue.t contains tests for BlankItemLocationOnCheckout. Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patches on bug report 14576, and this patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added one new syspref: UpdateItemLocationOnCheckout which is off by default) 5. Check the item out again and notice the shelving location is not changed, showing that when the UpdateItemLocationOnCheckout is not enabled and the shelving location is not changed upon issue. 6. Enable the aforementioned syspref in the Administration->Global system preferences->Circulation interface 7. Check out the item and notice the shelving location is changed to no value, showing when the UpdateItemLocationOnCheckout syspref is enabled it blanks the shelving location on the issue of an item. 8. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #80892|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #18 from Alex Buckley --- Created attachment 80895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80895=edit Bug 21159: Corrected typo Same test plan as first patch. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #80893|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #15 from Alex Buckley --- Created attachment 80892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80892=edit Bug 21159 - Implementing syspref to enable blanking of item shelving location on issue. This patch builds upon the functionality implemented in bug 14576, by allowing library staff to automatically change the item shelving location of items which are circulated. In the case of this patch it automatically blanks the item shelving locations of items when they are issued if the BlankItemLocationOnCheckout syspref is enabled. t/db_dependent/Circulation/issue.t contains tests for BlankItemLocationOnCheckout. Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patches on bug report 14576, and this patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added one new syspref: UpdateItemLocationOnCheckout which is off by default) 5. Check the item out again and notice the shelving location is not changed, showing that when the UpdateItemLocationOnCheckout is not enabled and the shelving location is not changed upon issue. 6. Enable the aforementioned syspref in the Administration->Global system preferences->Circulation interface 7. Check out the item and notice the shelving location is changed to no value, showing when the UpdateItemLocationOnCheckout syspref is enabled it blanks the shelving location on the issue of an item. 8. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #16 from Alex Buckley --- Created attachment 80893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80893=edit Bug 21159 - Corrected typo Same test plan as first patch. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #77871|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What|Removed |Added Attachment #77870|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Alex Buckley changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #91 from Alex Buckley --- Applying: Bug 14576: Allow arbitrary automatic update of location on checkin Using index info to reconstruct a base tree... M C4/Items.pm M C4/Reserves.pm M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Reserves.pm Auto-merging C4/Items.pm CONFLICT (content): Merge conflict in C4/Items.pm Failed to merge in the changes. Patch failed at 0001 Bug 14576: Allow arbitrary automatic update of location on checkin The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14576-Allow-arbitrary-automatic-update-of-loca-FkmjWf.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #90 from Alex Buckley --- Hi Nick Can you please rebase? The conflict against master to be resolved is only small but git-bz fails to merge it automatically. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #11 from Alex Buckley --- Hi all I've added unit tests for the two new subroutines I added to C4/Reserves.pm which were RevertWaitingStatus() and RevertItemLevelHoldToBibLevelHold(). Also all three patches pass the QA test tool now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #10 from Alex Buckley --- Created attachment 80891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80891=edit Bug 20844: Added tests of the RevertWaitingStatus and RevertItemLevelHoldToBibLevelHold subroutines in C4/Reserves.pm I have added unit tests for the two aforementioned subroutines which I added in the previous patches on bug 20844, to the t/db_dependent/Holds/RevertWaitingStatus.t test. Test plan: 1. Apply the patches on bug 20844 2. Go into koha-shell from the Koha home dir: sudo koha-shell 3. Run the RevertWaitingStatus.t test file: prove t/db_dependent/Holds/RevertWaitingStatus.t Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #9 from Alex Buckley --- Created attachment 80890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80890=edit Bug 20844: Fixed error when cancelling hold from cataloguing/additem.pl Also fixed qa test tool failure on C4/Circulation.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Attachment #80761|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21277] fr-CA translation for notices in sample_notices.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21277 --- Comment #4 from Caroline Cyr La Rose --- Created attachment 80889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80889=edit Bug 21277: (follow-up) fr-CA translation for notices in sample_notices.sql This follow-up patch adds fr-CA translation for the SR_SLIP notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 --- Comment #137 from Srdjan Jankovic --- It is a huge pain, you have to have their test account. Which includes a password, and I'm not sure how is that dealt with in automated tests scenarios. The test is more or less a repeat of what is done in WebService::ILS itself, just through Koha. The main reason why I made WebService::ILS outside Koha is to cheat a bit - I could tests the whole structure locally and relieve that pain to some extent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21613] Turn strict SQL modes on for tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21602] Self registration doesn't take into account the ages for the selected patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21602 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- The test is done in members/memberentry.pl, it must be moved to a module. But then we will need to handle this error from other areas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21613] Turn strict SQL modes on for tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 Jonathan Druart changed: What|Removed |Added Summary|Turn strict SQL mode on for |Turn strict SQL modes on |tests |for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #41 from Christopher Brannon --- Need some instructions on using the Import batch settings. I am lost. Are there specific instructions somewhere? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21613] Turn strict SQL mode on for tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 --- Comment #1 from Jonathan Druart --- Created attachment 80887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80887=edit Bug 21613: Add a test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21613] Turn strict SQL mode on for tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 --- Comment #2 from Jonathan Druart --- Created attachment 80888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80888=edit Bug 21613: Turn strict SQL modes on for tests This patch will turn the strict SQL modes on When tests are ran with prove. Test plan: - Apply the first patch - prove t/db_dependent/Koha/Database.t => Will pass if you have 1 in your koha-conf.xml => Will fail otherwise - Apply the second patch - prove t/db_dependent/Koha/Database.t => Will pass whatever the value of strict_sql_modes in your koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21613] Turn strict SQL mode on for tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21613] Turn strict SQL mode on for tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 Jonathan Druart changed: What|Removed |Added Depends on||21597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21613] New: Turn strict SQL mode on for tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 Bug ID: 21613 Summary: Turn strict SQL mode on for tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org In order to make sure developers will be aware of possible regressions we should turn the strict SQL mode on for tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21597] Test suite is still failing with new default SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart changed: What|Removed |Added Blocks||21613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21613 [Bug 21613] Turn strict SQL mode on for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #40 from Christopher Brannon --- Cori Lynn, Minor requests. I am not a cataloger. I'd be happy to test, but a couple things I request: Write the test as basic and complete as you can. The more detail you can give, the more people are able to participate and follow up. I don't know off the top of my head how to open the advanced editor without some research. If you could include the steps to get there, that would be great. This is my personal bias, but anytime you can include steps that show behavior before, and then after the patch is applied, is a plus. We don't always notice what is different, especially if we don't hang out in those areas a lot. These are just minor suggestions. If I can figure out how to get there, I will certainly test what I can. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21606] Issues with matching rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21606] Issues with matching rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21606] Issues with matching rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 --- Comment #1 from Jonathan Druart --- Created attachment 80886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80886=edit Bug 21606: [sql_modes] Fix matching rules insert Fix: Incorrect integer value: '' for column 'offset' Incorrect integer value: '' for column 'score' Test plan: Add/edit matching rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 --- Comment #1 from Jonathan Druart --- Created attachment 80885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80885=edit Bug 21604: Fix add/edit fund/budget [Strict SQL modes context] For insert aqbudgetperiods: Incorrect integer value: '' for column 'budget_period_id' For insert/update aqbudgets Incorrect integer value: '' for column 'budget_owner_id' Incorrect decimal value: '' for column 'budget_encumb' Test plan: Add/edit budgets and funds A good example of why we should use Koha::Object for all our objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21603] Remove Group by clause in SearchCourses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21603] Remove Group by clause in SearchCourses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 --- Comment #2 from Jonathan Druart --- Created attachment 80884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80884=edit Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 'koha_kohadev.c.department' isn't in GROUP BY Test plan: Prove that the test fail without this patch and pass with this patch applied (switch on the SQL modes) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21612] Incorrect GROUP BY in Koha::Virtualshelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21612] Incorrect GROUP BY in Koha::Virtualshelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 --- Comment #1 from Jonathan Druart --- Created attachment 80883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80883=edit Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves 'koha_kohadev.me.shelfname' isn't in GROUP BY Same as commit 7e220e0d8f107cce63f32bfaa1919c04b4dea6e2 Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Test plan: - Add public and privates shelves - Shares some of them - List them => The correct numbers of shelves must be displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||21612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 [Bug 21612] Incorrect GROUP BY in Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21612] Incorrect GROUP BY in Koha::Virtualshelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Jonathan Druart changed: What|Removed |Added Blocks||17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Jonathan Druart changed: What|Removed |Added Blocks||17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||21610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 [Bug 21610] Koha::Object->store needs to handle incorrect values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21606] Issues with matching rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 Jonathan Druart changed: What|Removed |Added Blocks||17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21605] Cannot create EDI account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 Jonathan Druart changed: What|Removed |Added Blocks||17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What|Removed |Added Depends on||21601, 21603, 21604, 21605, ||21606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21601 [Bug 21601] Cannot create lists https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 [Bug 21603] Remove Group by clause in SearchCourses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 [Bug 21604] Cannot add/edit funds, cannot add budgets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 [Bug 21605] Cannot create EDI account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 [Bug 21606] Issues with matching rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21603] Remove Group by clause in SearchCourses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 Jonathan Druart changed: What|Removed |Added Blocks||17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 Jonathan Druart changed: What|Removed |Added Blocks||17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21605] Cannot create EDI account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 Jonathan Druart changed: What|Removed |Added Depends on|21597 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21606] Issues with matching rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 Jonathan Druart changed: What|Removed |Added Depends on|21597 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21604] Cannot add/edit funds, cannot add budgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 Jonathan Druart changed: What|Removed |Added Depends on|21597 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21601] Cannot create lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21601 Jonathan Druart changed: What|Removed |Added Depends on|21597 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21603] Remove Group by clause in SearchCourses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 Jonathan Druart changed: What|Removed |Added Depends on|21597 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 [Bug 21597] Test suite is still failing with new default SQL modes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21597] Test suite is still failing with new default SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 Jonathan Druart changed: What|Removed |Added Blocks|21603, 21604, 21605, 21606, | |21601 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21601 [Bug 21601] Cannot create lists https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 [Bug 21603] Remove Group by clause in SearchCourses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604 [Bug 21604] Cannot add/edit funds, cannot add budgets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 [Bug 21605] Cannot create EDI account https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606 [Bug 21606] Issues with matching rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21612] New: Incorrect GROUP BY in Koha::Virtualshelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612 Bug ID: 21612 Summary: Incorrect GROUP BY in Koha::Virtualshelves Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Same as commit 7e220e0d8f107cce63f32bfaa1919c04b4dea6e2 Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record for get_private_shelves, get_public_shelves and get_some_shelves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Jonathan Druart changed: What|Removed |Added CC||julian.maur...@biblibre.com ||, ||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #4 from Jonathan Druart --- Created attachment 80882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80882=edit Bug 21610: Fix integers and dates values at Koha::Object->store level With strict SQL modes, we are facing several issues when objects are stored. The following errors can be raised by DBIx::Class when an object does not have a valid (as defined at DB level) value: - Incorrect integer value: '' for column COLUMN - Incorrect decimal value: '' for column COLUMN - Column 'COLUMN' cannot be null - Field 'COLUMN' doesn't have a default value - Incorrect date value: '' for column 'COLUMN' We already handled some of them for Koha::Patron. As we do not want to provide such changes for all Koha::* modules we are going to fix this at Koha::Object->store level in order to provide a global fix. This is related to bug 21599 (for item types) and bug 21596 (for patrons) Test plan: - Apply first patch, run the tests => Patch fail because of the previous error in Koha::ItemType->store, to make them pass you can replace $self->notforloan(0) unless $self->notforloan; with $self->notforloan(undef) unless $self->notforloan; - Apply second patch, run the tests => They fail because of dates and/or integers values - Apply third patch, run the tests => They now pass Deep code review wanted! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #3 from Jonathan Druart --- Created attachment 80881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80881=edit Bug 21610: Remove specific changes we made previously We handled integers and dates for Koha::Patron and Koha::ItemType, we want now Koha::Object to deal with. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 --- Comment #2 from Jonathan Druart --- Created attachment 80880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80880=edit Bug 21610: Add tests Adding few tests to Koha/Object.t in order to highlight what we are trying to fix. Note that Koha::ItemType->store was wrong for notforloan, the default value should be null `notforloan` smallint(6) DEFAULT NULL, but the previous fix (bug 21599) made it default to '0' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18490] Transfer message confusing, cancel button missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 Christopher Brannon changed: What|Removed |Added Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Severity|enhancement |major --- Comment #26 from Christopher Brannon --- Changing this to a bug fix, as it fixes dialog issues and a known bug. Not really adding anything new in terms of features. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #25 from Christopher Brannon --- I've isolated the flaw. We are good to go again. Test plan remains the same. I will also submit a patch to clean up the tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #24 from Christopher Brannon --- Created attachment 80879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80879=edit Bug 21346: Fixes dual modals on waiting hold. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21611] Priority in request.pl shows 1 instead of Waiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 --- Comment #1 from Christopher Brannon --- As is, bug gives a misleading status, and makes it impossible to set back to priority 1. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21605] Cannot create EDI account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- I do not plan to fix this one, Koha::Object should be used to take advantage of the generic/global solution (see bug 21610) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21601] Cannot create lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21601 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- Will be fixed by bug 21610. *** This bug has been marked as a duplicate of bug 21610 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Jonathan Druart changed: What|Removed |Added Summary|Koha::Object->store need to |Koha::Object->store needs |handle incorrect values |to handle incorrect values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store need to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Jonathan Druart changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #1 from Jonathan Druart --- *** Bug 21601 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21599] Incorrect decimal value: '' for column 'defaultreplacecost' - Cannot create item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21599 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21610 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] New: Koha::Object->store need to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Bug ID: 21610 Summary: Koha::Object->store need to handle incorrect values Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org With strict SQL modes, we are facing several issues when objects are stored. The following errors can be raised by DBIx::Class when an object does not have a valid (as defined at DB level) value: - Incorrect integer value: '' for column COLUMN - Incorrect decimal value: '' for column COLUMN - Column 'COLUMN' cannot be null - Field 'COLUMN' doesn't have a default value - Incorrect date value: '' for column 'COLUMN' We already handled some of them for Koha::Patron. As we do not want to provide such changes for all Koha::* modules we are going to fix this at Koha::Object->store level in order to provide a global fix. This is related to bug 21599 (for item types) and bug 21596 (for patrons) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21596] Handle default values when storing Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21596 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21610 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21611] New: Priority in request.pl shows 1 instead of Waiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 Bug ID: 21611 Summary: Priority in request.pl shows 1 instead of Waiting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To test: 1) Place and item on hold. 2) Trigger the hold. 3) Go to request.pl. Notice that priority shows "1" rather than "Waiting", even though it shows as waiting in the Pickup library column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #242 from Alex Buckley --- Created attachment 80878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80878=edit Bug 19532: Fix t/db_dependent/Koha/Recalls.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21603] Remove Group by clause in SearchCourses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart --- 'koha_kohadev.c.department' isn't in GROUP BY then later: Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.20/DBI.pm line 2064 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #241 from Alex Buckley --- Hi all I've added the additional patches now. All patches apply cleanly on master as of 18th of Oct 2018. I am setting this to 'Needs signoff'. Just a note I have noticed some DB errors (e.g. when paying fees on paycollect.pl, and upon returning items). I found from using git bisect these errors were being caused by the regressions introduced by one of the patches on bug 20521: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73683=diff You may have also seen the emails regarding bug 20521 in the Koha-devel mailing list. I've filed another bug report for the DB error on paycollect.pl - Bug 21593 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21593) - which Nick Clements has just attached a fix for. So in short if you experience DB errors during testing they may be due to 20521, not neccessarily recalls. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21597] Test suite is still failing with new default SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21597 --- Comment #29 from Jonathan Druart --- (In reply to Nick Clemens from comment #28) > Patches here pushed to master, will need an new omnibus or to adjust and > reopen With bug 21600 the tests should be ok. Others are not tests related (even if tests should have caught them!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21600] t/db_dependent/api/v1/patrons.t is failing with new SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 --- Comment #3 from Jonathan Druart --- Created attachment 80877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80877=edit Bug 21600: Use str param instead of dt for output_pref Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21600] t/db_dependent/api/v1/patrons.t is failing with new SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 Jonathan Druart changed: What|Removed |Added Attachment #80875|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 80876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80876=edit Bug 21600: /patrons should have timestamp/datetime values converted from rfc3339 into valid MySQL values Bug 21597 enabled the option so set strict SQL modes in koha-conf.xml to be able to improve Koha's comformance to current standards on DB engines. This causes lots of parts of Koha to fail because they rely on MySQL fallbacks that are no longer default behaviours. While we can workaround this by setting SQL modes on runtime, the decision has been that this needs fixing. This patch deals with the /patrons API failing to correctly convert datetimes into valid SQL timestamps. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass - Add 1 on your koha-conf.xml $ sudo vim /etc/koha/sites/kohadev/koha-conf.xml - Restart memcached and Plack: $ restart_all - Run: k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail due to updated_on and/or lastseen fields wrong format (MySQL error) - Apply this patch - Run: k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! It all makes sense! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21600] t/db_dependent/api/v1/patrons.t is failing with new SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21601] Cannot create lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21601 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Thx for filing, that's the bug I ran into! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21600] t/db_dependent/api/v1/patrons.t is failing with new SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21600] t/db_dependent/api/v1/patrons.t is failing with new SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 80875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80875=edit Bug 21600: /patrons should have timestamp/datetime values converted from rfc3339 into valid MySQL values Bug 21597 enabled the option so set strict SQL modes in koha-conf.xml to be able to improve Koha's comformance to current standards on DB engines. This causes lots of parts of Koha to fail because they rely on MySQL fallbacks that are no longer default behaviours. While we can workaround this by setting SQL modes on runtime, the decision has been that this needs fixing. This patch deals with the /patrons API failing to correctly convert datetimes into valid SQL timestamps. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass - Add 1 on your koha-conf.xml $ sudo vim /etc/koha/sites/kohadev/koha-conf.xml - Restart memcached and Plack: $ restart_all - Run: k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail due to updated_on and/or lastseen fields wrong format (MySQL error) - Apply this patch - Run: k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! It all makes sense! - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21600] t/db_dependent/api/v1/patrons.t is failing with new SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21600] t/db_dependent/api/v1/patrons.t is failing with new SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21600 Tomás Cohen Arazi changed: What|Removed |Added CC||josef.mora...@gmail.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21607] Koha::Account::Line->apply should store credit offsets as negative amounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21607 Michal Denar changed: What|Removed |Added Attachment #80858|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 80874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80874=edit Bug 21607: Make Koha::Account::Line->apply store credits as negative amounts This is a trivial patch, that makes offsets have 'amount' stored as negative values for applied credits. The behaviour is changed on the tests and adjusted in the code. To test: - Run $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21607] Koha::Account::Line->apply should store credit offsets as negative amounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21607 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21609] New: Store pre-rendered html in search engine (zebra or elastic).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21609 Bug ID: 21609 Summary: Store pre-rendered html in search engine (zebra or elastic). Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org XSLT rendering is slow, I started to think about whether it would be possible to store pre-rendered HTML in zebra or elastic, so that we only have to run the marcxml to html xslt transformations at indexing time rather than per, search. It's a time vs. space optimization, and I don't know if the html generated by xslt ever gets cached; if it does, we might not see any benefit. Anyway, putting it out for discussion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #28 from Owen Leonard ---
The QA tool fails acqui/z3950_search.tt: parse error -
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
line 124: unexpected end of directive
[% IF ( Koha.Preference('AdditionalFieldsInZ3950ResultSearch') != '' %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #39 from Cori Lynn Arnold --- Created attachment 80873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80873=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #37 from Cori Lynn Arnold --- Created attachment 80871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80871=edit Bug 18823: Rancor - save override warnings Rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #38 from Cori Lynn Arnold --- Created attachment 80872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80872=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #36 from Cori Lynn Arnold --- Created attachment 80870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80870=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What|Removed |Added Attachment #80627|0 |1 is obsolete|| Attachment #80628|0 |1 is obsolete|| Attachment #80637|0 |1 is obsolete|| Attachment #80861|0 |1 is obsolete|| Attachment #80868|0 |1 is obsolete|| --- Comment #35 from Cori Lynn Arnold --- Created attachment 80869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80869=edit Bug 18823: Rancor - add support for editing/searching records rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #7 from Owen Leonard --- I think a separate bug for expanding those abbreviations would be good. Unless there is a difficult space restraint my vote would be to avoid abbreviations whenever we can. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What|Removed |Added Attachment #80866|0 |1 is obsolete|| --- Comment #34 from Cori Lynn Arnold --- Created attachment 80868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80868=edit Bug 18823: Rancor - add support for editing/searching records rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 Martin Renvoize changed: What|Removed |Added Blocks|18589 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
