[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #20 from David Cook --- Jerome and I were chatting in IRC and it seems like $c->req->body might not be properly handling multipart/form-data data. But could we just take the psgi.input straight from Mojolicious and plug it into CGI::Emulate::PSGI's app callback? I don't see why we couldn't do that in theory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582
--- Comment #19 from David Cook ---
Comment on attachment 74517
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74517
Bug 20582: Turn Koha into a Mojolicious application
Review of attachment 74517:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20582=74517)
-
::: Koha/App/Plugin/CGIBinKoha.pm
@@ +44,5 @@
> +$c->rendered;
> +})->name('cgi');
> +}
> +
> +sub _psgi_env {
Could we use https://mojolicious.org/perldoc/Mojo/Message/Request#env to just
get a PSGI environment hash from Mojolicious?
I haven't delved into these patches, but aren't we basically just using
Mojolicious as a proxy to CGI::Emulate::PSGI, which looks like it comes
straight out of Plack::App::WrapCGI anyway?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 Alex Buckley changed: What|Removed |Added Status|Failed QA |BLOCKED --- Comment #16 from Alex Buckley --- Hi there I am going to put this bug report status on 'Blocked' until I have a bit more time to revisit this particular bug. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #10 from Alex Buckley --- Created attachment 81641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81641=edit Bug 7046: Implemented subscription renewal dropdown sub length element To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Patch applies and functions as expected in line with test plan. Signed-off-by: Dilan Johnpullé -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #11 from Alex Buckley --- Created attachment 81642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81642=edit Bug 7046: (follow-up) Tidy up to address test feedback * Removed underscores from start of subroutine * Removed tabs in subscription-renew.tt * Added test for C4/Serials/getsublength() in t/db_dependen/Serials/ReNewSubscription.t * Added missing filters Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Alex Buckley changed: What|Removed |Added Attachment #69408|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20344] Transferring an item while on hold results in a transfer where the destination is the same as the source
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20344 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|alexbuck...@catalyst.net.nz |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18926] Web installer doesn't work with plack enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18926 Alex Buckley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5800] Hold Policy "home library only" incompatible with CircControl "patron home library"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5800 Alex Buckley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21713] ExpireReservesonHolidays not obeying calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21713 --- Comment #3 from Kelly McElligott --- Yes Katrin that would be a good system preference to use for a work around, however, if the library does not want to give the patron all the days they are closed included in their reservesmaxpickupdelay Although the cron does not remove the hold, it is misleading to the staff to see that a hold "could" cancel on a day that the library is actually closed. This date is also shown in the OPAC to display the patron when their hold has expired. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19247] Feature release change tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #13 from David Cook --- This does sound cool! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #37 from David Cook --- (In reply to Tomás Cohen Arazi from comment #36) > I need to implement a way to hook record/item updates so changes are pushed > to an external service. Ideally through the use of plugins so a more generic > job queue was the first thing to consider. Then if we replace (say) > rebuild_zebra.pl -d with this, we should add a way to inject new 'tasks' > derived from this events (so a record update should trigger a zebra/ES > indexing step, and also look for things (plugins) that would require > actions. It felt simpler if it just sent broadcast messages through a socket > to any service listening there. > I like ZeroMQ because it doesn't need a server, you just use your own > service. > > So, one event => multiple actions. I've been wanting a hook for record/item creation/update/deletion as well, so it sounds like our desire is similar there! I'm sure many people have a variety of external services which would like event-driven updates from Koha. I read about ZeroMQ a while ago, but I didn't realize it doesn't need a dedicated broker (ie server). That's interesting! It would be fun to play with that. In the context of #15032, would you still want to use a message queue? I could see Koha sending a message to an importer service (in a pub/sub pattern), but I'm not sure how Koha would know when the import task is finished without having a result store. I suppose we could have a result store though. We could send a message to the importer service, and then asynchronously poll the result store to see when the task is done? I suppose that has disadvantages in that if the task fails, you're polling forever. And if you're polling, you also lose any sort of progress meter (although I always assumed we faked the progress with our current background implementation anyway). I guess those are just implementation details though. (With #10662, the Koha web UI connects to the OAI-PMH harvester demon through a Unix socket. It has bidirectional communication though as it has a request-reply relationship.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #18 from David Cook --- (In reply to M. Tompsett from comment #17) > That's the problem. I'm stuck in a weird loop install in my kohadevbox. I'll > probably destroy it, and up it just to restart. But perhaps there is > something wrong in the installation steps? > I sometimes get stuck in a weird install loop on kohadevbox too. Are you using Plack? I find restarting the Plack daemon usually fixes it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20602] Use search fields weight/relevancy on OPAC simple search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20602 --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #10) > I think it can't be avoided, we are not trying to rebuild Zebra as is, but > something that will hopefully work better :) We can hope! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #128 from David Cook --- I don't love the sound of these patches... (or the implementation of Koha::I18N). What's performance like for handling all the translations at run time? (Might not be a huge issue with template caching?) That said, the current system for generating translations is also painful. I have often wished that we could do something like Messages.Properties in Java or resources in Android Java development, which seem a more flexible for developers and easier for translators. Although I guess those might suffer from pluralization problems too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582
Jerome Charaoui changed:
What|Removed |Added
CC||jchara...@cmaisonneuve.qc.c
||a
--- Comment #18 from Jerome Charaoui ---
Has anyone tested this with file uploads? For some reason I'm unable to upload
any files. For example, when I try to stage a MARC upload, the application
responds with an HTTP 200 OK with the following content:
{"fileid":null,"errors":null,"status":"failed"}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Isabel Pineda changed: What|Removed |Added CC||isabel.pin...@ds.edu.sv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19247] Feature release change tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #12 from Alex Buckley --- Hi Martin Thanks very much. Yes, I would like to breathe more life into this one. I have been busy testing patches over the last while, I can start working on revisiting this one tonight to try to move it along. Will be in touch when it is ready to test :) Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Text to go in the||If a borrower has no email release notes||address but does have a ||smsalertnumber value set ||then send the suggestion ||notice as an sms. CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Alex Buckley changed: What|Removed |Added Text to go in the||This new feature introduces release notes||the ability for borrowers ||to place a recall on an ||item from the OPAC detail. ||Borrowers can see details ||of their requested recalls ||in the OPAC and can cancel ||the recall before it is ||returned. || ||Librarians can ||view and administer the ||recalls in the Circulation ||interface of the staff ||client which displays a ||list of recalls, overdue ||recalls and recalls ||awaiting pickup. || ||The ||amount of time the recalled ||item has to be returned and ||the amount of time it will ||wait for pickup can be set ||in circulation and fine ||rules in the unit of hours ||or days. || ||After an item is ||recalled it cannot be ||renewed. When the item is ||returned the recall can be ||confirmed or cancelled. || ||Recalls are marked as ||overdue by the ||overdue_notices.pl cronjob. Keywords|release-notes-needed| --- Comment #325 from Alex Buckley --- Thanks Martin. I have added release notes to the bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Text to go in the||This enhancement gives release notes||librarians easier control ||over waiting holds when ||items are marked as lost. || ||When an item with a waiting ||item-level hold on it is ||marked as lost the ||librarian is given the ||option to retain the hold ||or to cancel it. || ||When a ||lost item has an allocated ||waiting bib-level hold on ||it then if the ||'LostBibLevelHoldsRevert' ||syspref is enabled then the ||allocated hold is reverted ||to an unallocated bib-level ||hold. || ||If the ||'LostItemCancelOutstandingT ||ransfers' syspref is ||enabled then any ||outstanding holds on the ||lost item are cancelled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #21 from Alex Buckley --- Thanks Owen for testing my patch I have tested your follow-up and the dialogs look correct so I have signed off on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #20 from Alex Buckley --- Created attachment 81640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81640=edit Bug 20844: (follow-up) Fix style of dialogs This patch modifies the add item and item detail templates so that the hold cancellation dialogs match other similar dialogs in Koha. To test, apply the patch and perform step 10 or the original test plan. Confirm that the confirmation dialogs look correct. Confirmation dialogs look correct Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley changed: What|Removed |Added Attachment #81624|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 --- Comment #17 from M. Tompsett --- Whatever for the 1-4 steps. I did the equivalent. It worked. > 5. Do a 'standard' install > a. perl Makefile.PL (select 'standard') > b. make > c. sudo make install > d. Configure your database, web server, ... and go through the web >install process Encountered a bump here, but got through it. I was just accepting defaults mostly. > 6. Verify that the cpanfile got copied into PERL_MODULE_DIR (which > should be /usr/share/koha/lib) Yes. > 7. Go to the about page of this fresh install and compare it with your > dev install That's the problem. I'm stuck in a weird loop install in my kohadevbox. I'll probably destroy it, and up it just to restart. But perhaps there is something wrong in the installation steps? Could you flush out the testing steps on a kohadevbox to painful detail? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21656] Syntax Error in Stock Rotation Default Notice Template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21656 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #18 from Martin Renvoize --- Good catch Caroline.. I'd completely missed passing a couple of variables through. Should work as expected now.. you were completely right in your testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Martin Renvoize changed: What|Removed |Added Attachment #80930|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 81639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81639=edit Bug 21387: Receive items from - form should include tax hints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Martin Renvoize changed: What|Removed |Added Attachment #81357|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 81637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81637=edit Bug 21694: Add the Koha::Account->lines method Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Martin Renvoize changed: What|Removed |Added Attachment #81358|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 81638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81638=edit Bug 21694: Keep the context Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21694] Add the Koha::Account->lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- I can't replicate the sha1 issue I'm afraid.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21699] Allowing circulation Messages to be editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 --- Comment #2 from Lisette Scheer --- We would find this very helpful as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21476] Incorrect filter prevents HTML5 media from playing in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21476] Incorrect filter prevents HTML5 media from playing in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21476 --- Comment #8 from Nick Clemens --- (In reply to Devinim from comment #6) > Tested and works as described. But, there is a MIMETYPE error when we try to > apply that scenario. > we may have two 856 fields . If the first field is url and second field is > media it works without error. However, if the first field is media and > second field isn't , it gives an error. I cannot recreate this error, can you supply a sample record, or the links used? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21699] Allowing circulation Messages to be editable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- The issue is that when a hold is found the expiration date set by the patron (not needed after...) is overwritten by the latest possible pick-up date if that is after the expiration date. This means there is no way we can revert a hold from waiting in a clean way. Currently the expirationdate is kept when reverting, which means that we will have all reverted holds expire - for a short pick-up time set... they will expire very soon after reverting. I think the only thing we can do is set the expirationdate to blank. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Nick Clemens changed: What|Removed |Added Depends on||21608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens changed: What|Removed |Added Blocks||21729 --- Comment #13 from Nick Clemens --- (In reply to Katrin Fischer from comment #12) > Hm, I wasn't aware it has ever worked (changing priority once waiting). > > So only one fix needed then: When you revert, you need to clear the > expiration date, or the reverted hold will expire way too soon. Katrin and I discussed this today - while the expiration date reset may be desirable this bug restores existing behaviour from 17.11 New bug 21729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 [Bug 21729] When reverting a hold the expirationdate should be reset? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21729] New: When reverting a hold the expirationdate should be reset?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Bug ID: 21729 Summary: When reverting a hold the expirationdate should be reset? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com See bug 21608 and bug 21611 - existing behvaiour from 17.11 is restored by those bugs - but it is possible we should consider broader options for what happens when a hold is reset from 'found' status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on||21728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Blocks||14825 Depends on||21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Blocks||21728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21728] New: Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 Bug ID: 21728 Summary: Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org All account handling should go via the Koha::Account class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on|21002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on||21727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::update_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::update_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on||21722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on||21721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What|Removed |Added Depends on||21720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20978 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21727 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::update_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21002 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21002 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added Blocks|21002 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Depends on|20978 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::update_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What|Removed |Added Depends on||21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::update_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21002 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Blocks||21727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 [Bug 21727] Add Koha::Account::update_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::update_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] New: Add Koha::Account::update_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Bug ID: 21727 Summary: Add Koha::Account::update_debit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org There should be a high-level method for update existing debits, similar to Koha::Account::add_credit and Koha::Account::add_debit It will handle updating the line, and adding an offset. Envisaged use case is for debit amendments and fine increments. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21727 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21725] Incorrect HAVING in group by in Acquisitions.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 --- Comment #8 from Martin Renvoize --- Indeed.. I couldn't work out how to move it to the WHERE clause.. I tried pretty hard to during work on but 21385. I agree, this is the MySQL bug highlighted by Nick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17875] Linking to series authority records fails when a space precedes the semicolon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17875 --- Comment #3 from Margaret --- Thanks Katrin! There is also Bug 16804 - Searching can be broken by search terms containing semicolons in XSLT, which may be helped by bug 14716. For what it is worth I don't think this is a duplicate of 16804 exactly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 --- Comment #5 from Katrin Fischer --- Thx Julian! It didn't happen on mine, probably not enough data! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21585] Ignore missing firstname in ILL requests table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21585 --- Comment #4 from Owen Leonard --- I can't reproduce this bug either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #64 from Katrin Fischer --- Thank you, Joubu! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21725] Incorrect HAVING in group by in Acquisitions.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > I wanted to move the condition to the WHERE clause. The advantage to have it > into the HAVING clause was to not repeat the condition. With this patch we > c/p the condition and have it in the HAVING clause... :) I tried moving things to the where, but this removed orders from the total_orders count so I went this route. I can confirm setting the modes as you explain and then running the query fails for me However: Server version: 10.1.26-MariaDB-0+deb9u1 Debian 9.1 Possibly: https://bugs.mysql.com/bug.php?id=51058 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Julian Maurice changed: What|Removed |Added Status|Signed Off |Failed QA CC||julian.maur...@biblibre.com --- Comment #4 from Julian Maurice --- The SQL queries have a JOIN clause with aqorders_items. Without the GROUP BY it can return multiple rows for the same order. It shouldn't be removed. On master, ordered.pl displays a table of 15 rows With the patch applied, it displays a table of 22 rows Same thing on spent.pl with different numbers. Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 --- Comment #15 from Owen Leonard --- (In reply to Katrin Fischer from comment #13) > I checked hidden by default and not toggable for the "Supplier report", but > it won't go away. Yes, I didn't see that Bug 18639 had added a column, requiring a change to columns_settings.yml. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Owen Leonard changed: What|Removed |Added Attachment #81498|0 |1 is obsolete|| --- Comment #14 from Owen Leonard --- Created attachment 81636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81636=edit Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > See bug 21526 comment 19. There are plenty to fix. I got rid of the URL build step in the controller, it is now clear text, and the param's are URI-filtered as they should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #4) > I can't add a new subfield with these patches. When clicking on "New" > nothing happens. > > I notice there is also a little error with the tabs on top, there is a gab > between them and the form below. It works for me, Katrina. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #324 from Martin Renvoize --- I'll be keeping a github branch updated with my work: https://github.com/colinsc/koha/compare/master...PTFS-Europe:bug_19532_recalls#diff-932a11a39c3f8c7127afb9c9a44318e7R349 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #63 from Jonathan Druart --- I have added the "Sponsored-by" line" to the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #323 from Martin Renvoize --- I'm working on a number of QA followups.. to save the email spamming I'll upload the final set at the end of my work.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Martin Renvoize changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #62 from Jonathan Druart --- Created attachment 81635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81635=edit Bug 15836: Fix display input in any situations Fix when switching an existing rule to RegEx Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #61 from Jonathan Druart --- Created attachment 81634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81634=edit Bug 15836: Handle non-existent regexs For other types of split rules Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #60 from Jonathan Druart --- Created attachment 81633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81633=edit Bug 15836: Add missing svc script Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836
--- Comment #57 from Jonathan Druart
---
Created attachment 81630
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81630=edit
Bug 15836: Add the ability to defined custom methods to split call number in
labels
Currently the call number splitting seems to be mostly implemented for
DDC and LC classifications.
Those are both not very common in some countries.
A lot of libraries use their own custom classification schemes so the call
number
plitting is something that should be individually configurable.
This enhancement adds the ability to define custom splitting rules based
on regular expressions.
How does it work so far?
From C4/Labels/Label.pm there are 3 differents splitting methods defined,
depending on items.cn_source.
if cn_source is "lcc' or 'nlm' we split using Library::CallNumber::LC
if cn_source is 'ddc' we split using a in-house method
Finally there is a fallback method to split on space
And nothing else is done for other cn_source
The idea of this patch is to mimick what was done for the "filing rules" and
add
the ability to define "splitting rules" that will be used by the
"Classification sources".
A classification source will then have:
* a filing rule used to sort items by callnumbers
* a splitting rule used to print labels
To acchieve this goal this enhancement will do the following
modifications at DB level:
* New table class_split_rules
* New column class_sources.class_split_rule
Test plan:
* Execute the update database entry to create the new table and
column.
I. UI Changes
a) Create/modify/delete a filing rule
b) Create/modify/delete a splitting rule
c) Create/modify/delete a classification source
=> A filing rule or splitting rule cannot be removed if used by a
classification source
II. Splitting rule using regular expressions
a) Create a splitting rule using the "Splitting routine" "RegEx"
b) Define several regular expressions, they will be applied one after
the other in the same order you define them.
Something like:
s/\s/\n/g # Break on spaces
s/(\s?=)/\n=/g# Break on = (unless it's done already)
s/^(J|K)\n/$1 / # Remove the first break if callnumber starts with J or K
c) You can test the regular expressions using filling the textarea with
a list of callnumbers. Then click "Test" and confirm the callnumbers are
split how you expected.
d) Finally create a new classification source that will use this new
splitting rule.
III. Print the label!
a) Create a layout. It should have the "Split call numbers" checkbox
ticked, and display itemcallnumber
b) Use this layout to export labels, use items with different
classification source ('lcc', 'ddc', but also the new one you have
create)
=> The callnumbers should have been split according to the regex you
defined earlier!
Notes:
* The update database entry fill the class_sources.class_split_rule
with the value of class_sources.class_sort_rule
If default rules exist it will not work, we should add a note in the
release notes (would be enough?)
* C4::ClassSplitRoutine::* should be moved to Koha::ClassSplitRule,
but it sounded better to keep the same pattern as ClassSortRoutines
* Should not we use a LONGTEXT for class_split_rules.split_regex instead
of VARCHAR(255)?
* class_sources.sql should be filled for other languages before pushed
to master!
IMPORTANT NOTES: The regular expressions are stored as it, and eval is
used to evaluate it (perlcritic raises a warning about it (Expression
form of "eval"). It can lead to serious security issues (execution of
arbitrary code on the server), especially if the modifier 'e' is used.
We could then remedy the situation with one of these following points:
- Assume that this DB data is safe (We can add a new permission?)
- Assume that the data is not safe and deal with possible attack
Cons: how be sure we are exhaustive? Making sure it matches ^s///[^e/]*$
would be enough?
- Use Template Toolkit syntax instead (Really safer?)
[% callnumber.replace('\s', '\n').replace ... %]
- Cut the regex parts: find, replace, modifiers
like we already do for Marc modification template. Cons: we are going to
have escape problems, the "find" and "replace" parts should not be
handle the same way (think "\n", "\\n", "\1", "\s", etc.)
I did not manage to implement this one easily.
Sponsored-by: Goethe-Institut
Signed-off-by: Christian Stelzenmüller
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #59 from Jonathan Druart --- Created attachment 81632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81632=edit Bug 15836: Add tests Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #58 from Jonathan Druart --- Created attachment 81631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81631=edit Bug 15836: Mark C4::ClassSource subs DEPRECATED These subs are no longer used from scripts and should be removed. It should be done on a separate bug report given that additional work is needed Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #56 from Jonathan Druart --- Created attachment 81629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81629=edit Bug 15836: UI changes The script admin/classsources.pl has been adjusted to follow usual patterns used in other Koha scripts. $op can be add_source, add_source_validate, etc. Deletion steps have been removed (there is a JS confirmation box) to simplify both script and template. Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Jonathan Druart changed: What|Removed |Added Attachment #81033|0 |1 is obsolete|| Attachment #81034|0 |1 is obsolete|| Attachment #81035|0 |1 is obsolete|| Attachment #81036|0 |1 is obsolete|| Attachment #81037|0 |1 is obsolete|| Attachment #81038|0 |1 is obsolete|| Attachment #81039|0 |1 is obsolete|| Attachment #81040|0 |1 is obsolete|| Attachment #81041|0 |1 is obsolete|| --- Comment #54 from Jonathan Druart --- Created attachment 81627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81627=edit Bug 15836: DB changes Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call numbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 --- Comment #55 from Jonathan Druart --- Created attachment 81628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81628=edit Bug 15836: DBIC Schema change Sponsored-by: Goethe-Institut Signed-off-by: Christian Stelzenmüller Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21725] Incorrect HAVING in group by in Acquisitions.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 --- Comment #6 from Jonathan Druart --- I wanted to move the condition to the WHERE clause. The advantage to have it into the HAVING clause was to not repeat the condition. With this patch we c/p the condition and have it in the HAVING clause... :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21725] Incorrect HAVING in group by in Acquisitions.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 --- Comment #5 from Jonathan Druart --- As I said on bug 21714 I do not recreate the issue. That would be good to understand why. The query is (I removed the WHERE clause): SELECT aqbasket.basketno, aqbasket.basketname, aqbasket.note, aqbasket.booksellernote, aqbasket.contractnumber, aqbasket.creationdate, aqbasket.closedate, aqbasket.booksellerid, aqbasket.authorisedby, aqbasket.booksellerinvoicenumber, aqbasket.basketgroupid, aqbasket.deliveryplace, aqbasket.billingplace, aqbasket.branch, aqbasket.is_standing, aqbasket.create_items, SUM(aqorders.quantity) AS total_items, SUM( IF ( aqorders.orderstatus = 'cancelled', aqorders.quantity, 0 ) ) AS total_items_cancelled, COUNT(DISTINCT aqorders.biblionumber) AS total_biblios, SUM( IF(aqorders.datereceived IS NULL AND (aqorders.datecancellationprinted IS NULL OR aqorders.datecancellationprinted='-00-00') , aqorders.quantity , 0) ) AS expected_items FROM aqbasket LEFT JOIN aqorders ON aqorders.basketno = aqbasket.basketno GROUP BY aqbasket.basketno, aqbasket.basketname, aqbasket.note, aqbasket.booksellernote, aqbasket.contractnumber, aqbasket.creationdate, aqbasket.closedate, aqbasket.booksellerid, aqbasket.authorisedby, aqbasket.booksellerinvoicenumber, aqbasket.basketgroupid, aqbasket.deliveryplace, aqbasket.billingplace, aqbasket.branch, aqbasket.is_standing, aqbasket.create_items HAVING (closedate IS NULL OR (expected_items > 0)); Can you confirm it fail for you after having set the modes accordingly? SET SESSION sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; Server version: 10.0.36-MariaDB-0+deb8u1 (Debian) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #120 from David Gustafsson --- Ok, help pages will have to moved to online manual as previously noted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m --- Comment #26 from Victor Grousset/tuxayo --- Hi, we got the error at /usr/share/koha/lib/C4/Auth_with_ldap.pm line 101 on two instances when updating from 17.11.06 to 17.11.09 And 0 worked (with a restart of memcached and starman/plack) Here is the rest of the config if that can help those for which anonymous_bind isn't enough. ldaps://SOME_IP_ADDR CN=FOOBAR,OU=FOOBAR,OU=FOOBAR,DC=FOOBAR,DC=FOOBAR FOOBAR ou=FOOBAR,ou=FOOBAR,dc=FOOBAR,dc=FOOBAR cn=%s, ou=FOOBAR,ou=FOOBAR,dc=FOOBAR,dc=FOOBAR 1 1 0 0 0 [...] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
