[Koha-bugs] [Bug 21740] Fixed-lenght fields show _ instead @ when editing subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21740 ByWater Sandboxes changed: What|Removed |Added Attachment #81920|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 81923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81923=edit Bug 21740: Show @ when editing fixed-length fields on bibliographic frameworks This is a consistency issue: we store '@' as the subfield for fixed-lenght fields, yet on editing '_' is displayed (on the form and the tab). This was probably done to avoid URI encoding problems in the past. This patch restores the '@' everywhere. To test: - Open the MARC structure for any bibliographic MARC framework - Choose Actions > Subfields on any fixed-length field => ERROR: Notice the tab has an underscore (_) and the subfield code is '_' as well. - Cancel => SUCCESS: '@' is displayed on the list - Apply this patch - Restart all the things: $ restart_all - Choose Actions > Subfields on any fixed-length field => SUCCESS: '@' is displayed in the tab title, and on the 'Subfield code' form field. - Save some changes => SUCCESS: Things work correctly. - Sign off :-D Signed-off-by: Pierre-Marc Thibault Signed-off-by: Devinim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21753] issuingrules.chargename is unused and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com --- Comment #3 from Pierre-Marc Thibault --- Can you provide a test plan so it will be easy to test and sign it? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21755] Show patron updated date in circ menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||pierre-marc.thibault@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21755] Show patron updated date in circ menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 Pierre-Marc Thibault changed: What|Removed |Added Attachment #81891|0 |1 is obsolete|| --- Comment #2 from Pierre-Marc Thibault --- Created attachment 81922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81922=edit Bug 21755: Show patron updated date in circ menu In borrowers table the column updated_on stores the last updated date and time. Display this in the circ menu. Test plan: 1) Go to a patron details page /cgi-bin/koha/members/moremember.pl 2) Look at left menu, you see "Updated on" and a date and time 3) Edit this patron and save 4) Check that "Updated on" changed 5) Click on each tab of menu to check this date is displayed Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #33 from Christopher Brannon --- Okay, patches for cleanup are set. Now addressing the waiting hold at the wrong location. It must: * Bring up a modal. * Only prompt to send the item to the pickup location. * Update current location in item. * Initiate a transfer. * Update the reserve from a W to T in the found field. * Remove the waiting date in the reserves. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #32 from Christopher Brannon --- Created attachment 81921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81921=edit Bug 21346: Convert dialogs to modals This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21740] Fixed-lenght fields show _ instead @ when editing subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21740 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21740] Fixed-lenght fields show _ instead @ when editing subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21740 Pierre-Marc Thibault changed: What|Removed |Added Attachment #81733|0 |1 is obsolete|| --- Comment #2 from Pierre-Marc Thibault --- Created attachment 81920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81920=edit Bug 21740: Show @ when editing fixed-length fields on bibliographic frameworks This is a consistency issue: we store '@' as the subfield for fixed-lenght fields, yet on editing '_' is displayed (on the form and the tab). This was probably done to avoid URI encoding problems in the past. This patch restores the '@' everywhere. To test: - Open the MARC structure for any bibliographic MARC framework - Choose Actions > Subfields on any fixed-length field => ERROR: Notice the tab has an underscore (_) and the subfield code is '_' as well. - Cancel => SUCCESS: '@' is displayed on the list - Apply this patch - Restart all the things: $ restart_all - Choose Actions > Subfields on any fixed-length field => SUCCESS: '@' is displayed in the tab title, and on the 'Subfield code' form field. - Save some changes => SUCCESS: Things work correctly. - Sign off :-D Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21730] PA_CLASS missing from list of authorized values categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730 --- Comment #3 from Pierre-Marc Thibault --- I'm sorry. I should probably have added this in the previous comment, but you have inserted AV_CLASS instead of PA_CLASS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21759 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] _FixAccountForLostAndReturned does not always create an account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21727 CC||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Tomás Cohen Arazi --- Just a guess: this could be implemented using Koha::Account::Line->adjust, provided we allowed negative increments and a suitable update type/offset type is defined. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21730] PA_CLASS missing from list of authorized values categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730 Pierre-Marc Thibault changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||pierre-marc.thibault@inlibr ||o.com --- Comment #2 from Pierre-Marc Thibault --- PA_CLASS is still missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] _FixAccountForLostAndReturned does not always create an account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Tomás Cohen Arazi changed: What|Removed |Added Depends on||13098 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 [Bug 13098] Item lost multiple times by the same patron will create only be charged once -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13098] Item lost multiple times by the same patron will create only be charged once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 [Bug 21759] _FixAccountForLostAndReturned does not always create an account offset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21619] Tax hints should not be abbreviated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619 Caroline Cyr La Rose changed: What|Removed |Added Attachment #80929|0 |1 is obsolete|| --- Comment #6 from Caroline Cyr La Rose --- Created attachment 81919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81919=edit Bug 21619: Expand tax abreviations in acquisitions form hints Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21619] Tax hints should not be abbreviated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21619] Tax hints should not be abbreviated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619 --- Comment #5 from Caroline Cyr La Rose --- Tax hints on both ordering and receiving forms are now long form. This does not affect the tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] _FixAccountForLostAndReturned does not always create an account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] _FixAccountForLostAndReturned does not always create an account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Kyle M Hall changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21759] New: _FixAccountForLostAndReturned does not always create an account offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21759 Bug ID: 21759 Summary: _FixAccountForLostAndReturned does not always create an account offset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If a lost item is stilled owed in full, the fee is reduced to 0 but no corresponding account offset is generated. All changes to accountlines should generate a corresponding account offset. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #45 from Kyle M Hall --- Created attachment 81918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81918=edit Bug 19066: (QA follow-up) Remove bad and unecessary test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Caroline Cyr La Rose changed: What|Removed |Added Attachment #81639|0 |1 is obsolete|| --- Comment #20 from Caroline Cyr La Rose --- Created attachment 81917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81917=edit Bug 21387: Receive items from - form should include tax hints Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 --- Comment #19 from Caroline Cyr La Rose --- The hints in ordering and receiving form now match. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21758] New: Navigation in Z39.50 result pages not working in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21758 Bug ID: 21758 Summary: Navigation in Z39.50 result pages not working in Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org When I try to add a record to a basket from Z39.50, I can't seem to go to the next pages of results. I'm stuck on the first page. To reproduce: 1) Go to Acquisitions 2) Search for a Vendor (or add a vendor) 3) Create a new basket 4) Click 'Add to basket' 5) Choose 'from external source' 6) Search for a term (I searched for 'cats' in title and the target is Library of Congress) 7) Check the number of results (I get 1 to 20 of 20, which I find suspect, I'm pretty sure LOC has more than 20 titles containing 'cats' in their collection) 8) Check the number of results pages (I have 1 / 286) 9) Click on Next page (nothing happens) 10) Enter a page number in the 'Go to page' box and click 'Go' (I get an error message saying 'Please choose at least one external target') Can someone test and tell me if they get the same thing? Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #205 from David Gustafsson --- But to clarify, I will increase test coverage and add test for "ecode_record_from_result" on monday, and we can take it from there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #44 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #43) > Back to Signed Off.. Tomas, did you fancy taking a look at my follow-up and > verifying the add_credit use.. do we need to also account for library_id in > the API endpoints. Everything looks correct. But t/db_dependent/Accounts.t is failing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Josef Moravec changed: What|Removed |Added Summary|Patron detail script|Patron detail script |cleanup |(moremember.pl) cleanup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 --- Comment #1 from Josef Moravec --- Created attachment 81916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81916=edit Bug 21757: Clenup of moremember.pl and its templates This patch: - removes unused templates - use objects as much as possible - remove many template params Test plan: 1) Apply the patch 2) Play with patron detail page and try to broke it anyhow ;) - messaging preferences - enhanced attributes - guarantors and guarantees - fines - messages - checkouts - overdues - use different date formats, price formats and address formats - ... there is many thinks you could try with this one page ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Josef Moravec changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] New: Patron detail script cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Bug ID: 21757 Summary: Patron detail script cleanup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org The moremember.pl script is too long ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comment #17 from Martha Fuerst --- This is still a problem in 18.05. We have a workaroud (pay the fine in chunks), but if you pick the wrong chunks, it can still be an issue. Would love a fix. Thanks! -Marti Fuerst, Huntsville Madison-County Library System -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 --- Comment #8 from Martin Renvoize --- Going to rebase this little tree against 19066 as it's close to going in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize changed: What|Removed |Added Blocks||21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Depends on||19066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 [Bug 19066] Add branchcode to accountlines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 --- Comment #18 from Martin Renvoize --- As CI maintainer, I've set Tomas to QA this one.. I think he's best placed to give it the final go ahead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Martin Renvoize changed: What|Removed |Added Attachment #75090|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 81915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81915=edit Bug 19185: Add selenium tests for installation and onboarding process Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #17 from Martin Renvoize --- With a bit of perseverance, I got it to work. Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Martin Renvoize changed: What|Removed |Added Attachment #75089|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 81914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81914=edit Bug 19185: Ease elements selection - The marcflavour select needs an id to be selected easily - "Continue to the next step" should be a button (like others) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Martin Renvoize changed: What|Removed |Added Attachment #75088|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 81913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81913=edit Bug 19185: Use submit button if only one exists on the page During the installation process we do not have fieldset.action, in order to not complicate changes we are just going to use the submit button if only one exists. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #43 from Martin Renvoize --- Back to Signed Off.. Tomas, did you fancy taking a look at my follow-up and verifying the add_credit use.. do we need to also account for library_id in the API endpoints. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #42 from Martin Renvoize --- Created attachment 81912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81912=edit Bug 19066: (QA follow-up) Add handling in add_credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Component|Architecture, internals,|Circulation |and plumbing| CC||gmcha...@gmail.com, ||kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added Keywords||Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Failed QA --- Comment #24 from Martin Renvoize --- I'd like to see some tests for various combinations of process_fee, rentalcharge and rental_charge_daily before passing this. Looking at the code there seems to be a little disparity between charging the amount returned by GetIssuingCharges followed by a second charge calculated using rental_charge_daily.. sometimes it looks like a combined charge, sometimes it looks like two charges and sometimes two charges with the second change also being a combined charge. Hence the asking for a few more tests ;) Also.. i think I'd prefer that the calculation was folded into GetIssuingCharges myself.. it seems somewhat fraught with peril to be duplicating this code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923 --- Comment #18 from Fridolin SOMERS --- (In reply to Marcel de Rooy from comment #17) > Hmm. In 17.05.x I still find this bug labeled as 18923, but in 16.11.x it > pops up under 18922 ? What happened ? Whooo indeed, i dont understand because cherry-picked SHA is OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #20 from Martin Renvoize --- Works well, no regressions found.. passed qa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 Martin Renvoize changed: What|Removed |Added Attachment #81908|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 Martin Renvoize changed: What|Removed |Added Attachment #81909|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Martin Renvoize changed: What|Removed |Added Attachment #81793|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 81911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81911=edit Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=20996 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Martin Renvoize changed: What|Removed |Added Attachment #81792|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 81910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81910=edit Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize https://bugs.koha-community.org/show_bug.cgi?id=20996 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #65 from Martin Renvoize --- Created attachment 81909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81909=edit Bug 20966: (follow-up) Add template variable filter; Fix table export This patch makes to corrections: 1. The "$raw" filter has been added to the column configuration 2. The columns configuration now specifies which columns are exported in Copy, Excel, etc. operations. To test, apply the patch and test the various table export buttons on a both a closed and open basket. Confirm that the 'Modify' and 'Cancel' columns are not exported. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #64 from Martin Renvoize --- Created attachment 81908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81908=edit Bug 20966: Add column configuration to table of orders in a basket This patch adds column configuration to the table of orders in a basket. It replaces the "Show all details" checkbox which previously was used to show the hidden "tax included" columns. Now those columns are hidden by default in the columns configuration file. To test, apply the patch and view a basket with multiple orders. Test all DataTables functionality (paging, sorting, filtering) including showing and hiding columns. Test with both an open and a closed basket. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #28 from Kyle M Hall --- Created attachment 81907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81907=edit Bug 15561 [QA Followup] - Add atomic update, fix other issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #27 from Kyle M Hall --- Created attachment 81906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81906=edit Bug 15561 [QA Followup] - Rename ExpireReservesMaxPickUpDelayCharge to WaitingHoldCancelationFee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #26 from Kyle M Hall --- Created attachment 81905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81905=edit Bug 15561 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What|Removed |Added Attachment #81901|0 |1 is obsolete|| --- Comment #204 from David Gustafsson --- Created attachment 81903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81903=edit Bug 19893: Add code review fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall changed: What|Removed |Added Attachment #63358|0 |1 is obsolete|| Attachment #63359|0 |1 is obsolete|| Attachment #63360|0 |1 is obsolete|| Attachment #63361|0 |1 is obsolete|| --- Comment #25 from Kyle M Hall --- Created attachment 81904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81904=edit Bug 15561 - Add ability to charge cancelation fee from "Holds over" tab The fee set in ExpireReservesMaxPickUpDelayCharge can only be charged by the automatic expiration cron script. Some libraries would prefer to manually cancel holds via the "Holds over" tab of the "Holds awaiting pickup" page but still be able to charge the cancellation fee. Test Plan: 1) Apply this patch 2) Set ExpireReservesMaxPickUpDelayCharge to some number 3) Go to the Holds awaiting pickup page 4) Go to the Holds over tab 5) Note the new checkbox for charging the fee 6) Test canceling a single hold with the checkbox checked 7) Note a fee is charged 8) Test canceling a single hold with the checkbox unchecked 9) Note a fee is not charged 10) Test canceling all holds with the checkbox checked 11) Note the patrons are charged fees 12) Test canceling all holds without the checkbox checked 13) Note the patrons are not charged fees Signed-off-by: Jason Burds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #203 from David Gustafsson --- Forgot to add it to sysprefs.sql though, will fix this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #41 from Martin Renvoize --- Koha::Account->add_credit isn't handled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 --- Comment #202 from David Gustafsson --- *"I have _now_ replaced them with exceptions instead." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #201 from David Gustafsson ---
(In reply to Joonas Kylmälä from comment #197)
> Thanks for the patch!
>
> Instead of croak or die the exceptions need to be used, e.g.
> Koha::Exceptions::Exception->throw(""). Please do a git diff
> origin/master..HEAD to see all the dies and croaks (assuming HEAD contains
> your patches). And the many for loops I mentioned are in the subroutine
> marc_records_to_documents Koha/SearchEngine/Elasticsearch.pm – though take
> this as an optional thing to fix as I know this bug is blocking quite many
> other things.
>
> Continuing still code review... About
> installer/data/mysql/atomicupdate/
> bug_19893_elasticsearch_index_status_sysprefs.sql – a) is it a good idea to
> have these as a syspref (even though the user cannot see them)? b) if it's a
> good idea then the sysprefs should also be in
> installer/data/mysql/sysprefs.sql because otherwise in a new Koha
> installation the syspref will be missing.
>
> In the file Koha/SearchEngine/Elasticsearch.pm: s/string on the
> format/string in the format/
>
> Then we also need a test plan for this code. Like what steps need to be
> taken to index authorities and biblios and what should be the expected
> result.
>
> Unit tests
> (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:
> _Unit_tests_are_required_.28updated_Apr_26.2C_2017.29): at least
> decode_record_from_result is missing one
>
> If all the above mentioned things get fixed then I'm probably ready to
> sign-off but I still need to test this code actually before that.
I for some reason read it as "die" should be replaced with "croak". I have not
replaced them with exceptions instead.
I think it's a bit of an anti-pattern to put a block of code into a function if
only invoked in one location, so would prefer to leave the code as it is.
About the syspref, sadly there is no persistent variable store in Koha that I
know of. In other places where this is needed (like Koha version number), it is
stored in the syspref-table.
Fixed the grammatical error.
I don't know how much time I have to spend on unit tests. I think there is
close to 100% code coverage trough the other tests, but I recently checked this
with cover and there are some minor execution-paths that are never reached.
Which I could fix. If I where to write unit tests for all new helper-methods
added it could take some time.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #243 from Owen Leonard --- Created attachment 81902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81902=edit Bug 10662: (follow-up) Template corrections and improvements This patch makes a number of corrections and improvements to the OAI harvester templates: - Add missing DataTables CSS include - Replace YUI grid with Bootstrap - Correct style of inline dialogs (.dialog.alert, .dialog.message) - Correct class of form hint and error messages - Format dates in saved and submitted requests tables - Add title-string sorting to DataTables configuration - Add delete confirmation to saved and submitted tables - Disable sorting on action columns - Style action links inside tables as buttons - Removed commented markup - Add missing JavaScript include (tools-menu.js) to highlight active section in sidebar menu - Add CodeMirror styling to record view page (CodeMirror XML mode file is added to enable this) - Remove invalid
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 David Gustafsson changed: What|Removed |Added Attachment #81822|0 |1 is obsolete|| --- Comment #200 from David Gustafsson --- Created attachment 81901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81901=edit Bug 19893: Add code review fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com --- Comment #10 from Fiona Borthwick --- There is still interest from our customer base on this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #26 from Martin Renvoize --- As an initial step for Jenkins and the use of Selenium testing on the installer, this patch works. Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Attachment #69844|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Attachment #69843|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Attachment #81893|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 81900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81900=edit Bug 19821: Require database_test != database To prevent developpers to drop their database. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Attachment #75092|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 81899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81899=edit Bug 19821: Use database_test entry if exists If the database_test entry exists in the config file we are going to use it. This will be a trick for developers and CI Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #19 from Martin Renvoize --- Created attachment 81894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81894=edit Bug 19821: Run tests on a separate database Running the tests on the same database as the one used for dev has some drawbacks: - Everybody has different data, so we cannot make any assumptions about data in tests and it can make tests fail for non-obvious reasons. - Tests have to clean up every change to the database using SQL transactions, so we cannot write testable code that use transactions (AFAIK) - Transactions in tests happen to be committed sometimes, resulting in garbage data added to the dev database This patch provides a .proverc file that will load t/lib/Bootstrap.pm before the tests are run. t/lib/Bootstrap.pm is responsible for recreating a fresh database and telling the test scripts to use it. To use it, just run prove normally from the root directory of Koha. By default, the database is 'koha_test' and it's created using MARC21 SQL files, it can be changed by running: prove --norc \ --Mt::lib::Bootstrap=database,koha_test,marcflavour,UNIMARC Test plan: 1. mysql> GRANT ALL PRIVILEGES ON koha_test.* TO @localhost 2. cd /path/to/koha 3. prove t/db_dependent/.t 4. Verify that it created the database koha_test and that the one you use usually was untouched (you can edit the test file and comment the lines related to a transaction (txn_begin, txn_rollback)) Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Attachment #75091|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 81898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81898=edit Bug 19821: Do not modify KOHA_CONF, use new database_test entry instead I have tried to use the original idea of this patch for bug 19185, but it cannot work as it. ENV is not shared between processus and KOHA_CONF will not be read by webserver (used for selenium tests). Moreover on bug 19185 we are testing the installation process and we do not want the database to be populated with sample data, we just need a new and clean DB. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Attachment #75045|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 81897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81897=edit Bug 19821: Ignore .proverc and .proverc.dist in Makefile.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Attachment #71817|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 81896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81896=edit Bug 19821: Install sample data, ES mappings and Version syspref Also move .proverc to .proverc.dist, so it cannot be used by accident. Different ways to use it: 1/ prove --rc .proverc.dist Use defaults 2/ cp .proverc.dist .proverc && prove Allows to configure db name, marcflavour, and prove options Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #20 from Martin Renvoize --- Created attachment 81895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81895=edit Bug 19821: Close filehandle after writing Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Fridolin SOMERS changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #242 from Owen Leonard ---
(In reply to David Cook from comment #241)
> - DataTable styling
I'm preparing a template follow-up to this, but the only thing that is a
blocker interface-wise is the DataTables styling. The problem is this is
missing from the template:
[% Asset.css("css/datatables.css") | $raw %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #18 from Jonathan Druart --- Created attachment 81893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81893=edit Bug 19821: Require database_test != database To prevent developpers to drop their database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #17 from Martin Renvoize --- Can we add a test for existance of database_test before running the DROP DATABASE commands -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Assignee|mar...@bugs.koha-community. |josef.mora...@gmail.com |org.xinxidi.net | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #66 from Jonathan Druart
---
+my $consent = Koha::Patron::Consents->search({
+borrowernumber => getborrowernumber($user),
+type => 'GDPR_PROCESSING',
+given_on => { '!=', undef },
+})->next;
+if( !$consent ) {
->count could have been better.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec changed: What|Removed |Added Attachment #46935|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 81892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81892=edit Bug 15400: Display date of birth and age more consistantly Test plan: 0) Apply the patch 1) Go to all of these pages Patron detail Other patron pages - look on the left side (circ-menu) Patron search Guarantor search ( go to child patron -> edit -> in guarantor section click "Set to patron" Search through "Check out" (in the header) 2) Confirm that does show date of birth and date consistantly, try it on patrons with and without date of birth set to find possible reggressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21755] Show patron updated date in circ menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21755] Show patron updated date in circ menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21755 --- Comment #1 from Fridolin SOMERS --- Created attachment 81891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81891=edit Bug 21755: Show patron updated date in circ menu In borrowers table the column updated_on stores the last updated date and time. Display this in the circ menu. Test plan: 1) Go to a patron details page /cgi-bin/koha/members/moremember.pl 2) Look at left menu, you see "Updated on" and a date and time 3) Edit this patron and save 4) Check that "Updated on" changed 5) Click on each tab of menu to check this date is displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529
--- Comment #44 from M. Tompsett ---
(In reply to Marcel de Rooy from comment #43)
> -C4::Letters::SendQueuedMessages(
> -{
> -verbose => $verbose,
> -username => $username,
> -password => $password,
> -method => $method,
> -limit=> $limit,
> -type => $type,
> -}
> +C4::Letters::SendQueuedMessages( { verbose => $verbose, username =>
> $username, password => $password, method => $method } );
> +sleep(15);
> Why do you remove limit and type? Why add sleep (debug leftover)?
I too thought it was a bad thing, which is why the third patch fixes it.
However, I thought I patched up the ZEBRA stuff.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21751] fixFloat toolbar not displaying properly in Chrome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 Jonathan Druart changed: What|Removed |Added Summary|"#searchheader" toolbar not |fixFloat toolbar not |displaying properly in |displaying properly in |Chrome |Chrome CC||oleon...@myacpl.org Severity|minor |normal --- Comment #5 from Jonathan Druart --- We could revert commit 592905a4d2d41a1a7b757c48fbac8fc6f025bf9b Bug 21139: (follow-up) Floating toolbars - Remove unecessary height But I would prefer to find a better fix as it degrades the ergonomic for FF -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Martin Renvoize changed: What|Removed |Added Blocks||21756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Martin Renvoize changed: What|Removed |Added Blocks|21756 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Update C4::Accounts::manualinvoice to use Koha::Account->add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
