[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21731 CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21731] t::lib::QA::TemplateFilters missing built-in TT filter "xml" causes false warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21731 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21770 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21778] Sorting is inconsistent on patron search based on permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 --- Comment #1 from Nick Clemens --- Created attachment 82015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82015=edit Bug 21778: Sort user list by surname,firstname unless user cannot manage patron lists OR edit patrons To test: 1 - Create four users: 1 superlibrarian (or with both edit patrons and manage patron lists) 1 with only edit patrons and catalogue 1 with only add to list and catalogue 1 with catalogue but neither edit patrons or manage patron lists 2 - Search patrons signed in as each user 3 - Note different sorting 4 - Apply patch 5 - Try searching with each patron 6 - Results should always be sorted by surname, firstname 7 - Only in the case of neither extra permission should the checkboxes be absent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21778] Sorting is inconsistent on patron search based on permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21778] New: Sorting is inconsistent on patron search based on permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Bug ID: 21778 Summary: Sorting is inconsistent on patron search based on permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When searching for patrons the results are sorted by surname, firstname if CAN_user_tools_manage_patron_lists otherwise they are sorted by cardnumber This seems to be a confusion in the template - the checkbox column is only hidden if the user cannot edit patrons or add them to a list, however, the sorting assumes it is hidden if they cannot add patrons to a list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #12 from Alex Buckley --- Thanks Katrin great suggestion I have attached the follow-up changing the system preference name to 'FallbackToSMSIfNoEmail'. Ready to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #11 from Alex Buckley --- Created attachment 82014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82014=edit Bug 21241: (follow-up) Renamed system preference Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Chris Cormack changed: What|Removed |Added Attachment #81764|0 |1 is obsolete|| --- Comment #28 from Chris Cormack --- Created attachment 82013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82013=edit Bug 21526: Fix search result pages (url vs uri vs raw) query_cgi is uri_escaped from the pl, so we should displayed as raw Test plan: Use wide characters ❤ Search, filter, facets, search history, rss (both interfaces) Please test deeply! Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Chris Cormack changed: What|Removed |Added Attachment #81530|0 |1 is obsolete|| --- Comment #26 from Chris Cormack --- Created attachment 82011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82011=edit Bug 21526: Use the 'url' filter when needed Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Chris Cormack changed: What|Removed |Added Attachment #81763|0 |1 is obsolete|| --- Comment #27 from Chris Cormack --- Created attachment 82012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82012=edit Bug 21526: (follow-up) Use the 'url' filter when needed Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #10 from Katrin Fischer --- Maybe FallbackToSMSIfNoEmail ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 --- Comment #8 from Jonathan Druart --- The 3 patches should not be picked, the last one is an alternative patch for the first one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Jonathan Druart changed: What|Removed |Added Attachment #82010|Bug 21770: Allow|[ALTERNATIVE-PATCH] Bug description|html_entity for href|21770: Allow html_entity ||for href -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 --- Comment #9 from Alex Buckley --- I realize the syspref name 'MessageTransportTypeFallbackToSMSIfNoPatronEmail' is pretty long, if you would like me to shorten it please let me know the name you would prefer and I can quickly write and attach a follow-up patch changing the name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Danielle Elder changed: What|Removed |Added CC||danielle@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Text to go in the|If a borrower has no email |If the release notes|address but does have a |MessageTransportTypeFallbac |smsalertnumber value set|kToSMSIfNoPatronEmail |then send the suggestion|syspref is enabled then |notice as an sms. |when a borrower has no ||email address but does have ||a smsalertnumber then ||suggestion notice ||message_transport_type is ||set to sms. Summary|Set suggestion notices |Set suggestion notices |message_transport_type to |message_transport_type to |sms if patrons has no email |sms if syspref is enabled |but smsalertnumber set |and patron has an ||smsalertnumber but no email ||address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 Nick Clemens changed: What|Removed |Added Depends on||21562 CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||katrin.fisc...@bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21562 [Bug 21562] Sorting on checkout date is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21562] Sorting on checkout date is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21562 Nick Clemens changed: What|Removed |Added Blocks||21777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 [Bug 21777] Checkouts table in circulation is out of alignment (Bug 21562) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21776] Set ACQ_NOTIF_ON_RECEIV notice message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21776 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||21241 Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21777] New: Checkouts table in circulation is out of alignment (Bug 21562)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21777 Bug ID: 21777 Summary: Checkouts table in circulation is out of alignment (Bug 21562) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com On bug 21562 a scret sorting column was added, however, we didn't add the column on the table, only on the rows fetch by ajax checkouts Also we need a DB update to default the column to hidden and cannot be toggled by default -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21776] New: Set ACQ_NOTIF_ON_RECEIV notice message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21776 Bug ID: 21776 Summary: Set ACQ_NOTIF_ON_RECEIV notice message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org At present the ACQ_NOTIF_ON_RECEIV is hardcoded to always have a message_transport_type of 'email' in C4::Acquisition::NotifyOrderUsers(). If a patron does not have an email address set then they will not receieve these notices. This patch utilizes the new system preference 'MessageTransportTypeFallbackToSMSIfNoPatronEmail' introduced in the patches on bug 21241. If this syspref is enabled then when a borrower has a smsalertnumber but no email address the ACQ_NOTIF_ON_RECEIV notice message_transport_type will be set to 'sms'. If the syspref is not enabled then the notice message_transport_type will not be set to 'sms' under any combination of conditions. i.e. the syspref prevents an automatic fallback to using sms which could be costly for libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21241] Set suggestion notices message_transport_type to sms if patrons has no email but smsalertnumber set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 Alex Buckley changed: What|Removed |Added Blocks||21776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21776 [Bug 21776] Set ACQ_NOTIF_ON_RECEIV notice message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 --- Comment #7 from Kyle M Hall --- Created attachment 82010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82010=edit Bug 21770: Allow html_entity for href We certainly should not expect this filter to be used much for href, but we have one occurrence that needs it. Test plan: t/template_filters.t and xt/find-missing-filters.t must return green Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 --- Comment #6 from Kyle M Hall --- Created attachment 82009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82009=edit Bug 21770: Add tests for html_entity Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21770] t::lib::QA::TemplateFilters should allow html_entity in href
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21770 Kyle M Hall changed: What|Removed |Added Attachment #81980|0 |1 is obsolete|| Attachment #81983|0 |1 is obsolete|| Attachment #81984|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 82008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82008=edit Bug 21770: t::lib::QA::TemplateFilters should allow html_entity in href Bug 21740 highlighted the situation in which the href is not a link (and thus requiring to be URI/URL encoded). This was fixed on the bug, but the xt/find-missing-filters.t tests fail on it, becuase they enforce uri filters on href without exceptions. This patch adds the exception for those href's starting with '#' To test: - Run: $ kshell k$ prove xt/find-missing-filters.t => FAIL: Tests fail - Apply this patch - Run: k$ prove xt/find-missing-filters.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Attachment #81768|0 |1 is obsolete|| --- Comment #20 from Josef Moravec --- Created attachment 82007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82007=edit Bug 21706: (QA follow-up) Fix tabs Not all href's should have parameters URI encoded. Because sometimes they are just where for use by JavaScript libraries which fail in that situations. For fixed-lenght fields we use @ as the subfield code and it breaks the bootstrap tabs if we URI encode the '@'. This fixes the tabs issues on fixed-lenght fields in the authority type editing pages. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Attachment #81765|0 |1 is obsolete|| --- Comment #17 from Josef Moravec --- Created attachment 82004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82004=edit Bug 21706: Make authority framework subfield links work (TT filter) This patch removes URL building from the controller and does it on the templates, using the right 'uri' filter for the query parameters. To test: - Go to Home > Administration > Athority types - On any of the listed frameworks, pick the 'MARC structure' action in the dropdown - On any subfield, hover on the actions dropdown => FAIL: The URLs are wrongly formed - Click on the links => FAIL: You get errors because of the bad URL - Apply this patch - Reload the 'MARC structure' page - On any subfield, hover on the actions dropdown => SUCCESS: LInks look correct - Click on any of them => SUCCESS: They work! - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Attachment #81767|0 |1 is obsolete|| --- Comment #19 from Josef Moravec --- Created attachment 82006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82006=edit Bug 21706: (follow-up) Fix subfield delete button Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Attachment #81766|0 |1 is obsolete|| --- Comment #18 from Josef Moravec --- Created attachment 82005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82005=edit Bug 21706: (follow-up) remove unused template params The original patch removed the need to add URLs to the template variables. This patch removes that in the controller. Bonus: fixes 'html' filter in URL replacing it by 'uri'. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21706] Editing subfields in authority frameworks is broken (TT filter)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #77 from Martin Renvoize --- Odd.. I didn't get that warning at all when I tested the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21766] Default sounds broken in 18.05 - wrong filter/link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21766 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21766] Default sounds broken in 18.05 - wrong filter/link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21766 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Martin please include the tests from bug 21775 when you will push this fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21766] Default sounds broken in 18.05 - wrong filter/link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21766 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21766] Default sounds broken in 18.05 - wrong filter/link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21766 Jonathan Druart changed: What|Removed |Added Attachment #81973|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 82003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82003=edit Bug 21766: Correct filtering on AUDIO_ALERT_PATH js I managed to introduce a bad filter whilst backporting bug 15734 to the 18.05.x series. This patch attempts to correct that. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21775] Lack of tests for audio alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 --- Comment #4 from Jonathan Druart --- Created attachment 82002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82002=edit Bug 21775: [18.05.x] Add selenium tests for audio alerts To prevent future regressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21775] Lack of tests for audio alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 --- Comment #3 from Jonathan Druart --- Attached to its own bug report to make it part of master. Initially written for bug 21766. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21775] Lack of tests for audio alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2 from Jonathan Druart --- Attached to its own bug report to make it part of master. Initially written for bug 21776. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21775] Lack of tests for audio alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 --- Comment #1 from Jonathan Druart --- Created attachment 82001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82001=edit Bug 21775: Add selenium tests for audio alerts To prevent future regressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21775] Lack of tests for audio alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21775] New: Lack of tests for audio alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 Bug ID: 21775 Summary: Lack of tests for audio alerts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org This code is not reliable, we faced too many regressions. We need a Selenium test to cover it and prevent future regressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21766] Default sounds broken in 18.05 - wrong filter/link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21766 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21775 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21774] New: Subfield clone fields dissapear when editing a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21774 Bug ID: 21774 Summary: Subfield clone fields dissapear when editing a record Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: je...@medios.es QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When editing an item record that has repetable subfields, these subfields dissapear on the editing screen in those records that have more than one value. - On the cataloging screen (basic screen), create a new record - Go to a field with repetable subfields and associated with authorised values CCODE - Select a value for the subfield 952$8) - Clone the subfield - select another value for the new subfield - Save the record - Edit the record to modify => the clone subfields have disappeared. Seems to be related to bug 17818 Verified happening on 17.11.04 and 18.05.05-1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21696] Use Koha::Account->lines from Koha::Account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21696 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21673] Koha::Account::Lines->total_outstanding must be used when needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21673 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21647] Clean up SRU fields mapping templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21647 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #76 from Nick Clemens --- Last two patches pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20629] Remove ability to 'reverse' payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20435] Allow lowercase prefix in inventory value builder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20435 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 --- Comment #27 from je...@medios.es --- Thanks Victor, 0 did the trick for me... I discovered that I also had problems with the user I was testing with: Despite being active and able to browse the directory with shelldap, it wouldn't be able to login successfully to koha. Deleting the user and creating it again cleared the error for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21619] Tax hints should not be abbreviated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21619] Tax hints should not be abbreviated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619 Jonathan Druart changed: What|Removed |Added Attachment #81919|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 82000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82000=edit Bug 21619: Expand tax abreviations in acquisitions form hints Signed-off-by: Caroline Cyr La Rose Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21387] Receive items from - form should include tax hints the same as the ordering form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21387 Jonathan Druart changed: What|Removed |Added Attachment #81917|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 81999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81999=edit Bug 21387: Receive items from - form should include tax hints Signed-off-by: Caroline Cyr La Rose Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #75 from Jonathan Druart --- Created attachment 81998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81998=edit Bug 20996: Remove warning 'Un-mocked method' t/db_dependent/api/v1/illrequests.t .. Un-mocked method 'status_graph()' called at /home/vagrant/kohaclone/Koha/Illrequest.pm line 439. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 Jonathan Druart changed: What|Removed |Added Attachment #81996|0 |1 is obsolete|| --- Comment #74 from Jonathan Druart --- Created attachment 81997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81997=edit Bug 20996: (RM follow-up) Fix the api tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #73 from Jonathan Druart --- I get a warning with the last patch: t/db_dependent/api/v1/illrequests.t .. Un-mocked method 'status_graph()' called at /home/vagrant/kohaclone/Koha/Illrequest.pm line 439. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #105 from Martin Renvoize --- I'll try and take a look at tests tomorrow, sorry guys. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21693] Clean up checkout notes template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21693 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #6 from Nick Clemens --- Before this patch the 'Mark seen' and 'Mark not seen' buttons work. I can't make them work with this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #104 from Katrin Fischer --- Hm, didn't realize Martin's comments were from today, not sure if someone else would be able to help out here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #103 from Katrin Fischer --- I'm sorry, we've already passed feature slush :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21766] Default sounds broken in 18.05 - wrong filter/link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21766 Martin Renvoize changed: What|Removed |Added Attachment #81995|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 Martin Renvoize changed: What|Removed |Added Attachment #81994|0 |1 is obsolete|| --- Comment #72 from Martin Renvoize --- Created attachment 81996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81996=edit Bug 20996: (RM follow-up) Fix the api tests https://bugs.koha-community.org/show_bug.cgi?id=21766 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #71 from Martin Renvoize --- Added a follow-up for the RM that should fix the last remaining failing test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21766] Default sounds broken in 18.05 - wrong filter/link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21766 --- Comment #3 from Martin Renvoize --- Created attachment 81995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81995=edit Bug 20996: (RM follow-up) Fix the api tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20996] Fix API response time on ILL request endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996 --- Comment #70 from Martin Renvoize --- Created attachment 81994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81994=edit Bug 20996: (RM follow-up) Fix the api tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21773] New: Increase minimum MockModule version (and switch to ->redefine)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21773 Bug ID: 21773 Summary: Increase minimum MockModule version (and switch to ->redefine) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Our minimum version of MockModule is very low and as such doesn't support the safer 'redefined' method. If at all possible, it would be great to up this module version and replace our calls to mock with calls to redefine so we can catch when methods are renamed or removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #102 from Blou --- We're in mud, we've no way to prioritize this in the next few weeks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #60 from Andrew Isherwood --- Created attachment 81993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81993=edit Bug 20600: (follow-up) Fix errant tabs How on earth these tabs crept in I have no idea... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #101 from Martin Renvoize --- We're in Slush.. so a quick followup could still just make it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 --- Comment #59 from Andrew Isherwood --- Created attachment 81992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81992=edit Bug 20600: (follow-up) Rebase on current master Significant things have changed in master due to ILL enhancement patches being pushed. This patch rebases this bug on top of them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #100 from Martin Renvoize --- I jumped the gun here.. C4::Breeding needs updated tests to cover the new functionality. Sorry guys.. it had been a long week when I qa'd this first time around. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- We should replace the remaining DBIx code fragments scattered here and there.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21610 --- Comment #1 from Jonathan Druart --- Indeed, I think we should fix it at Koha::Object level (once again), but on top of bug 21610. We could move the handle of default values to a specific (private) method and call it with get_dirty_columns on ->store, ->update or ->set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21610] Koha::Object->store needs to handle incorrect values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21761 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21654] Installer is loading a non-existing file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Devinim changed: What|Removed |Added Attachment #81956|0 |1 is obsolete|| Attachment #81989|0 |1 is obsolete|| --- Comment #4 from Devinim --- Created attachment 81991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81991=edit Bug 19489 - (Object Method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21772] New: RT46421 - SelfCheck Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Bug ID: 21772 Summary: RT46421 - SelfCheck Display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: k...@bywatersolutions.com Reporter: je...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Work to be: 1) Move opac-user.pl holds tab content into include file 2) Add holds to to sco, use new include file 3) Add patron fines info to sco. 4) Modify script to search for and pass in patron holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 --- Comment #21 from Martin Renvoize --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #31 from Owen Leonard --- Created attachment 81990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81990=edit Bug 18584: Our legacy code contains trailing-spaces This patch removes trailing spaces from acquisitions-search.inc Mentored-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19489] Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 --- Comment #3 from Devinim --- Created attachment 81989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81989=edit (Object method) Development for fines and Fees Module - Detailed Description of charges in Patron Account Tab/Fines Tab Test plan: 1) Apply this patch 2) Choose a patron with overdue items applied fines 3) Click Fines from left menu 4) Test the values in barcode, due date and return date in Pay fines and Account tabs 5) Also test Column visibility, Print and Details buttons for functioning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21619] Tax hints should not be abbreviated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21619 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21730] PA_CLASS missing from list of authorized values categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Jonathan Druart --- (In reply to Pierre-Marc Thibault from comment #3) > I'm sorry. I should probably have added this in the previous comment, but > you have inserted AV_CLASS instead of PA_CLASS. Oops! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21730] PA_CLASS missing from list of authorized values categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730 Jonathan Druart changed: What|Removed |Added Attachment #81781|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 81988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81988=edit Bug 21730: Add missing PA_CLASS authorized values categories PA_CLASS is missing from the list of AV category Test plan: Execute the update DB entry Confirm that you now have PA_CLASS in the AV category list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 --- Comment #6 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #5) > Signed-off-by: Katrin Fischer Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 Katrin Fischer changed: What|Removed |Added Attachment #81986|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 81987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81987=edit Bug 21771: (Follow-up) Revert the shift statement Obviously you should never shift an items from an array if you need that item later on :) Signed-off-by: Marcel de Rooy Tested with entering userid as well as entering email.. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20023] Password recovery should be case insensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023 --- Comment #31 from Marcel de Rooy --- Sorry for all confusion people. But fixed ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 --- Comment #4 from Katrin Fischer --- I'll run a test with 17.11.11 as I was just working on this immediately. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20023] Password recovery should be case insensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023 Marcel de Rooy changed: What|Removed |Added Resolution|--- |FIXED Status|Passed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 Bug 21771 depends on bug 20023, which changed state. Bug 20023 Summary: Password recovery should be case insensitive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023 What|Removed |Added Status|Passed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20023] Password recovery should be case insensitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20023 Marcel de Rooy changed: What|Removed |Added Attachment #81985|0 |1 is obsolete|| --- Comment #30 from Marcel de Rooy --- Comment on attachment 81985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81985 Bug 20023: (Follow-up) Revert the shift statement Moved to 21771 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 --- Comment #3 from Marcel de Rooy --- Attention RM and Rmaints : This patch is a fix of the last follow-up on 20023. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #2 from Marcel de Rooy --- Moving to PQA directly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21771] Password recovery is broken (see 20023)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21771 --- Comment #1 from Marcel de Rooy --- Created attachment 81986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81986=edit Bug 21771: (Follow-up) Revert the shift statement Obviously you should never shift an items from an array if you need that item later on :) Signed-off-by: Marcel de Rooy Tested with entering userid as well as entering email.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
