[Koha-bugs] [Bug 17683] OPAC_SEARCH_LIMIT no longer accepts group codes as limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17683 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Martin, is it possible this was fixed by bug 21911? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results in column Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643 --- Comment #6 from Katrin Fischer --- Created attachment 83861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83861=edit Screenshot of result list with nfl = 1 = Treatment, itemtype books = nfl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results in column Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643 Katrin Fischer changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|REOPENED --- Comment #5 from Katrin Fischer --- Actually, I figured it out: - Change the description of NOT_LOAN = 1 to something easy to recognize - Set an itemtype to "not for loan" - Search for records with items of that item type in staff - Look at the search results - The items will be listed as unavailable, which I think is ok, BUT: each item will show the value of the not for loan = 1, which is not correct I think if the itemtype is marked as not for loan, we should leave it as showing them as unavailable, without looking up a wrong authorised value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results in column Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results in column Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I am failing to replicate this - given it's age, I think if it wasn't a configuration issue, it might have been fixed in a different way by now. Please reopen with a test plan if this is still an issue! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22109] Koha to Marc Mapping Chart is not in english in the English version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22109 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22123] Hardcoded values in subfield constraint visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22123 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure about this one - what would be the advantage of moving them into the db? The 3 checkboxes GUI seems like the easiest way to translate this to the user. For people working with SQL we keep some documentation here: https://wiki.koha-community.org/wiki/Hidden_values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22123] New: Hardcoded values in subfield constraint visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22123 Bug ID: 22123 Summary: Hardcoded values in subfield constraint visibility Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: pasi.kalli...@koha-suomi.fi QA Contact: testo...@bugs.koha-community.org Target Milestone: --- The MARC subfield constraint editor shows checkboxes for the subfield visibility (OPAC, Intranet, Editor, Collapsed, Flagged). The state of these checkboxes is encoded in the database as a single integer, and the conversion is done in marc_subfields_structure.js via hardcoded magic values: if ( flagged_checked ) { hidden_value='-8'; } else if ( opac_checked && ! intranet_checked && ! editor_checked && collapsed_checked ) { hidden_value='-7'; } else if ( opac_checked && intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='-6'; etc. These should be moved into the database, perhaps as authorised values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14772] Remove or clarify checkbox «flagged» on subfield visibility frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- The only references I can find to "flagged" are in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt and koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js. And koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js is only found in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt. There is another reference to "-8" in Koha/Filter/MARC/ViewPolicy.pm. -- It might be worth leaving in Koha/Filter/MARC/ViewPolicy.pm for backward compatibility for hiding values... but I think we could remove it from the templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18039] Move the mandatory and optional files for non-english languages into 'default' directory so bug 17855 permits use of other languages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21738] [ILS-DI] Error placing a hold on a title without item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21738 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|[ILS-DI] error while|[ILS-DI] Error placing a |holding a title without |hold on a title without |item|item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21491] When 'Default lost item fee refund on return policy' is unset it says no but acts as if 'yes'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21491] When 'Default lost item fee refund on return policy' is unset it says no but acts as if 'yes'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21491 Katrin Fischer changed: What|Removed |Added Attachment #83443|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 83860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83860=edit Bug 21491: Display 'Yes' as selected if no refundlostitemfee rules are set To test: 1 - Delete all refund_lost_item_fee_rules form the db delete from refund_lost_item_fee_rules; 2 - View the Standard circ rules - Default lost item fee refund shows as 'No' 3 - View circ rules for a single library, shows as 'Default (Yes)' 4 - Return a lost item, it actually does refund (this is in the LostItemFeeRules code, default 1 if not set) 5 - Apply patch 6 - Rule shows as 'Yes' 7 - View a specifc rule, still says Default (Yes) Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17353] Add phone number column to checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17353] Add phone number column to checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 Katrin Fischer changed: What|Removed |Added Attachment #83743|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 83858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83858=edit Bug 17353: Add phone number column to checkout search This patch adds borrowers.phone as 'Primary phone' in the checkout search results. It also ads the table to columns configuration To test: 1 - Perform a checkout search 2 - Note phone is not displayed 3 - Apply patch 4 - Note phone does not display 5 - Visit columns configuration 6 - Unhide the 'phone' column 7 - Note phone displays 8 - Ensure page functions as before patch Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17353] Add phone number column to checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 --- Comment #8 from Katrin Fischer --- Small favor: can we please use a clearer name for the table, that is consistent with the others? This uses: table_borrowers. Most use *-table and hyphens. Also... patron vs. borrower. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17353] Add phone number column to checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 Katrin Fischer changed: What|Removed |Added Patch complexity|Trivial patch |Small patch --- Comment #11 from Katrin Fischer --- see comment 8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17353] Add phone number column to checkout search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 Katrin Fischer changed: What|Removed |Added Attachment #83775|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 83859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83859=edit Bug 17353: (follow-up) Adjust config variable for moremember.tt too Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21989] JS error in "Add orders from MARC file" - addorderiso2709.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||oleon...@myacpl.org --- Comment #1 from Katrin Fischer --- Owen, could you have a look maybe? Is this an urgent one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22091] Need Details of Books or Accession Number issued to particular patron via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22091 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Rohit, this looks more like a support question/configuration issue. Bugzilla is intended for problems relating to the code/software directly. I think this is a question better suited to the mailing lists: https://koha-community.org/support/koha-mailing-lists/ Or ask some community members in IRC: https://koha-community.org/get-involved/irc/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 --- Comment #4 from Aleisha Amohia --- (In reply to Jon Knight from comment #2) > Appears to be missing 'use Modern::Perl;' in: > > t/Barcodes_annual.t The reason this was skipped is because there is no use strict; use warnings; so we don't want to add them if they're not already being used. It was likely accidentally added to the commit message. Patch has been rebased and is ready to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022 Aleisha Amohia changed: What|Removed |Added Attachment #70717|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 83857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83857=edit Bug 20022 - use Modern::Perl in t (test) perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 00-checkdatabase-version.t 00-deprecated.t 00-valid-xml.t AuthoritiesMarc_MARC21.t AuthoritiesMarc_UNIMARC.t Barcodes_EAN13.t Barcodes_hbyymmincr.t Barcodes_incremental.t Bookseller.t Budgets.t ClassSortRoutine.t ClassSortRoutine_Dewey.t ClassSortRoutine_Generic.t ClassSortRoutine_LCC.t ClassSource.t Contract.t Creators.t EdiInvoice.t Edifact.t Ediorder.t Ediordrsp.t External/Syndetics.t Form_MessagingPreferences.t Heading.t HtmlTags.t Installer_PerlDependencies.t Installer_pm.t ItemCirculationAlertPreference.t Koha_Util_MARC.t Labels.t Labels_split_ccn.t Labels_split_ddcn.t Labels_split_lccn.t Log.t Members_Attributes.t Members_Messaging.t Output.t Output_JSONStream.t Patroncards.t Patroncards_Batch.t Patroncards_Layout.t Patroncards_Lib.t Patroncards_Patroncard.t Patroncards_Profile.t Patroncards_Template.t Print.t QueryParser.t Scheduler.t Scrubber.t Stats.t SuggestionEngine.t TmplToken.t db_dependent/00-strict.t db_dependent/Amazon.t db_dependent/Heading_MARC21.t db_dependent/LDAP/test_ldap_add.pl db_dependent/Languages.t db_dependent/MungeMarcPrice.t db_dependent/Record/Record.t db_dependent/RecordProcessor_EmbedSeeFromHeadings.t db_dependent/Reports.t db_dependent/Service.t db_dependent/SuggestionEngine_ExplodedTerms.t db_dependent/Tags.t :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21750] Move collection code to its own column in checkins table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21750 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Dependency is FQA - moving to BLOCKED for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] Ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 --- Comment #4 from Katrin Fischer --- Never hurts to be specific :) Good catch, Frido! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] Ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] Ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Katrin Fischer changed: What|Removed |Added Attachment #83733|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 83856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83856=edit Bug 22082: ambiguous column in patron stats In Reports > Patrons statistics, the combination of activity and extended attributes generates an invalid SQL query with error : ERROR 1052 (23000): Column 'borrowernumber' in IN/ALL/ANY subquery is ambiguous This is because FROM contains tables borrowers and borrower_attributes both containing borrowernumber column. Test plan : 1) Be sure to have a patron extended attribute 2) Be sure you have some recent circulation activity 3) Go to Reports > Patrons statistics 4) Select 'active' in 'Patron activity' and 1 years of activity 5) Check 'Row' in 'Patron category' 6) Check 'Columns' in a extended attribute 7) Submit 8) Without patch you have no results, with patch you have exepected results Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21954] Koha update having a strange effect on checkout rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21954 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- It's generally recommended to configure an All-All-All rule as there are some cases where it's needed. I think one of the cases is when the record has no itemtype set, but it's needed for max holds calculation. Could this be the case here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22002] Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 --- Comment #5 from Katrin Fischer --- Created attachment 83855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83855=edit Bug 22002: (QA follow-up) Remove some debugging code from template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22082] Ambiguous column in patron stats
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22082 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|ambiguous column in patron |Ambiguous column in patron |stats |stats -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22002] Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Sorry for missing the issue before! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22002] Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22002] Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Katrin Fischer changed: What|Removed |Added Attachment #83368|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 83854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83854=edit Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it Caused by commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0 Bug 21621: Remove incorrect GROUP BY from tools/letter.pl The test plan was not complete enough. Test plan: 1) Go to Home › Tools › Notices & slips 2) Choose a letter to edit, e.g. PREDUE. Note that there is only a single row. 3) Click the edit button on the notice. 4) Expand the 'Print' section. Put text into the Message subject and Message body text areas. 5) Click save, this will take you back to the 'Notices & slips' page. 6) Clone PREDUE for a specific library 7) The 'all libraries' option must list the templates for all libraries, but without duplicate 8) Select a library in the dropdown list: only the templates for the given library is listed, without duplicate Signed-off-by: Barton Chittenden Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7960] choice to not show the text labels for item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Aleisha Amohia changed: What|Removed |Added Attachment #76608|0 |1 is obsolete|| --- Comment #17 from Aleisha Amohia --- Created attachment 83853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83853=edit Bug 7960: Add class to item type descriptions so they can be hidden with CSS This patch adds the class "itypetext" around item type descriptions so they can easily be hidden with CSS. To test: 1. Navigate to the pages listed below to confirm that the text descriptions do show. 2. Add .itypetext { display:none; } to IntranetUserCSS and OPACUserCSS system preferences and save. 3. Go back to the pages listed below and confirm that the text descriptions DO NOT show. = STAFF CLIENT = - catalogue/advsearch.tt - catalogue/detail.tt - catalogue/results.tt - reserve/request.tt - virtualshelves/shelves.tt = OPAC = - opac-advsearch.tt - opac-detail.tt - opac-readingrecord.tt - opac-reserve.tt - opac-results-grouped.tt - opac-shelves.tt - opac-user.tt Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7960] choice to not show the text labels for item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21084] Searching for authorities with 'contains' gives no results if search terms include punctuation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084 Katrin Fischer changed: What|Removed |Added Attachment #82966|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 83852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83852=edit Bug 21084: Fix automatic truncation in authority search - Makes token splitting work like in biblio search - Only adds right hand truncation since that's what Zebra also does - Only adds truncation if the token is not a phrase and ends in a word character - Adds tests to existing and new QueryBuilder functions Test plan: 1. Create an authority record for "Duck, Donald" 2. Try contains type authority searches with the following terms and make sure they find the record: Duck, Donald donald duck don duck "Duck, Donald" 3. Make sure the following search works but does not find anything: "Duck, Don" Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21084] Searching for authorities with 'contains' gives no results if search terms include punctuation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084 --- Comment #5 from Katrin Fischer --- Much better! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21084] Searching for authorities with 'contains' gives no results if search terms include punctuation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21084 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21921] Add date publication year to biblio Z39.50 search form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21921 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- This works well, but can you please add it to the search form in acq too? While the sequence is different (bug 22122), we currently offer the same search options there and I think it would be better to not have the forms drift apart. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22122] New: Make sequence of Z39.50 search options match in acq and cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22122 Bug ID: 22122 Summary: Make sequence of Z39.50 search options match in acq and cataloguing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Target Milestone: --- While we offer the same search options for Z39.50 search in catalouging and acquisition the sequence of search options is totally different. This seems unnecessary from a functional point of view and only confusing. Personally, I'd prefer cataloguing as it has ISBN and ISSN together at the top, followed by title and author grouped together. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20729] Update style of datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Katrin Fischer changed: What|Removed |Added Attachment #83830|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 83851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83851=edit Bug 20729: Update style of datepickers This patch updates the styling of form fields which are configured to use the jQueryUI datepicker widget. Some CSS has been added, and the default datepicker configuration has been changed. To test, apply the patch, rebuild the staff client CSS file, and clear your cache if necessary. Test pages which include a datepicker to confirm that they look correct and work correctly. Some examples: - Circulation -> Check out -> Specify due date - Patrons -> Add patron -> Date of birth, registration date, expiry date fields - Serials -> Search subscriptions -> Search results page sidebar - Tools -> News -> Add news item And confirm that this change hasn't adversely affected the calendar tool: - Tools -> Calendar Signed-off-by: Lucas Gass Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20729] Update style of datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20729 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 --- Comment #7 from Katrin Fischer --- Thank you, Owen, I really like the solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21850] Remove search request from page title of OPAC result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21850 Katrin Fischer changed: What|Removed |Added Attachment #83673|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 83850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83850=edit Bug 21850: Remove search request from page title of OPAC result list This patch modifies the OPAC search results template so that advanced search terms are not shown in the page title and breadcrumbs. This removes potentially confusing computer-oriented code from the public view. For simple searches the search term is displayed, using the same logic that determines whether the search bar should be populated with the last search term. To test: - Apply the patch - Peform a simple keyword search in the OPAC - On the results page the title and breadcrumbs should show 'Results of search for [your keyword] - Perform an advanced search with multiple parameters - The page title and breadrumbs should show only 'Search results' - The breadcrumbs should also show a link back to Advanced search using the returntosearch parameter Signed-off-by: Maryse Simard Signed-off-by: mikael Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should return if no patron is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date descending as a default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399 Katrin Fischer changed: What|Removed |Added Attachment #83466|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 83849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83849=edit Bug 21399: Sort patron fines in OPAC by date descending as a default This patch modifies the DataTables configuration of the logged-in user's "Fines and charges" table in the OPAC so that the table is sorted by date, descending. To test, apply the patch and log in to the OPAC as a user with multiple fines. Go to the "your fines" page and confirm that the table is sorted by default on the first column with the newest entries first. Signed-off-by: Nazlı Çetin Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21399] Sort patron fines in OPAC by date descending as a default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21399 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21913] Clean up payment details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Katrin Fischer changed: What|Removed |Added Attachment #83828|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 83848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83848=edit Bug 21913: Clean up payment details page This patch makes various corrections and improvements to the payment details page: - Grid converted to Bootstrap - Correct title tag - Add patron toolbar - Adding missing patron-related JavaScript - Improve some language To test, apply the patch and locate a patron who has one or more payments on their account. - Open Fines -> Account -> Details of a transaction - Confirm that the page looks correct and adjusts well at various browser widths. - Confirm that patron toolbar items work correctly Signed-off-by: Jose-Mario Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21913] Clean up payment details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21913 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21871] Show authority 856 links in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21871 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- The display works, but I think the code for the TrackClicks should not be there. The linktracker table only has a bilbionumber column, nothing is tracked there if you click on the authority links now. I suggest removing it and adding a separate bug to make it possible to track links for authorities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #29 from Katrin Fischer --- Added the missing filters in a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #26 from Katrin Fischer --- Created attachment 83845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83845=edit Bug 20809: (follow-up) Corrections to CSS and JS This follow-up modifies JavaScript so that the confirmation dialog is triggered when deleting a patron image from the modal window. The CSS is modified to improve the alignment of patron image and edit button. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #28 from Katrin Fischer --- Created attachment 83847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83847=edit Bug 20809: (QA follow-up) Fix missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #27 from Katrin Fischer --- Created attachment 83846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83846=edit Bug 20809: (follow-up) Add missing JS to view log page If the log viewer is being used to track patron-related data the patron-related JavaScript file should be included. To test, apply the patch and open a patron record. In the left-hand sidebar choose Modification Log. Test the patron image edit/replace process from the patron image in the sidebar and confirm that it works correctly. Signed-off-by: Lucas Gass Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 --- Comment #25 from Katrin Fischer --- Created attachment 83844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83844=edit Bug 20809: Link patron image to patron image add/edit form This patch modifies an include file so that it is possible with edit a patron's image on any patron-related page which uses that include. To test you must have the patronimages system preference enabled. Apply the patch and open any patron record for viewing. - Hover the mouse over the patron image. - If the patron has a previously-defined patron image, should you see an "Edit" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. - If a patron has no patron image defined, you should see an "Add" button appear. Clicking the button should display a modal dialog titled "Edit patron image." Test that the "Upload," "Delete," and "Cancel" buttons work correctly. This process should work from any page which shows the patron sidebar: Check out, Details, Fines, Routing lists, Circulation history, etc. Patch works as described. Signed-off-by: Dilan Johnpullé Signed-off-by: Katrin Fischer Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20809] Link patron image to patron image add/edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20809 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #24 from Katrin Fischer --- There are some complaints from the QA tool: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc FAIL filters missing_filter at line 148 () FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL filters missing_filter at line 272 ( To update the image for [% patron.title %] [% patron.firstname | html %] [% patron.surname | html %], select a new image file and click 'Upload.' Click the 'Delete' button to remove the current image.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22101] ILL requests missing in menu on advanced search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101 Katrin Fischer changed: What|Removed |Added Keywords|Academy | CC||katrin.fisc...@bsz-bw.de Summary|Ill Requests missing in |ILL requests missing in |menu on advanced search |menu on advanced search |page|page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22101] Ill Requests missing in menu on advanced search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22101 Katrin Fischer changed: What|Removed |Added Attachment #83821|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 83843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83843=edit Bug 22101: Ill Requests missing in menu on advanced search page This patch adds [% USE Koha %] to header.inc so that Koha.Preference calls will work correctly. To test, apply the patch and log in to the staff client as a user who has permission to access the ILL module. - Go to the catalog's advanced search page - Cnfirm there is a header menu item under "More" for "ILL requests." Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Katrin Fischer changed: What|Removed |Added Attachment #83763|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 83842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83842=edit Bug 22083: Typo in circulation_batch_checkouts.tt There is a typo in circulation_batch_checkouts.tt that makes Koha skip a warning if the user cannot borrow due to circulation rules. This patch corrects this typo. To test: 1. In Administration > Global system preferences, 'Allow' BatchCheckouts and enter patron categories in BatchCheckoutsValidCategories 2. Go to Administration > Circulation and fines rules 3. Enter a rule where a certain category of patrons (that is in BatchCheckoutsValidCategories) cannot take out a particular item type 4. Search the catalog for an item of that item type 5. Copy the barcode 6. Go into patrons and find a patron of that category 7. Click on the Batch checkout tab 8. Paste the barcode in the box and click Check out 9. It should say 'Too many checked out' 10. Apply the patch 11. Try the check out again, it should show both warnings ('Too many checked out' and 'This patron can't check out this item per library circulation policy') Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22083] Typo in circulation_batch_checkouts.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Thx, Caroline! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22009] Fix error messages for classification sources and filing rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22009 Katrin Fischer changed: What|Removed |Added Summary|Possible mistake in error |Fix error messages for |messages for classification |classification sources and |sources and filing rules|filing rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 Katrin Fischer changed: What|Removed |Added Depends on||22121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 Katrin Fischer changed: What|Removed |Added Blocks||22112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 [Bug 22112] Omnibus: Use Price filter everywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 --- Comment #1 from Katrin Fischer --- Created attachment 83841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83841=edit Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref To test: - Install BLDSS backend see: https://wiki.koha-community.org/wiki/ILL_backends - Add a new BLDSS ILL request - Edit ILL request - Fill in Price paid field - Verify Price paid is formatted correctly on 'Manage ILL request' page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22121] New: Display 'Price paid' on ILL requests according to CurrencyFormat pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 Bug ID: 22121 Summary: Display 'Price paid' on ILL requests according to CurrencyFormat pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 Katrin Fischer changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22120] Add price formatting to patron summary print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22120] Add price formatting to patron summary print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120 --- Comment #1 from Katrin Fischer --- Created attachment 83840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83840=edit Bug 22120: Add price formattig to patron summary print The patron summary print lists the replacement prices and rental charges of items and totals them. With this patch they will be formatted according to the CurrencyFormat system preference. To test: - Find or create a patron with some checkouts - Make sure some items have replacement price set and some have a rental charge - "Print summary" from the account in staff - Verify that charges and prices in the checkouts table are formatted correctly - Toggle CurrencyFormat to different settings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 Katrin Fischer changed: What|Removed |Added Depends on||22120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120 [Bug 22120] Add price formatting to patron summary print -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22120] New: Add price formatting to patron summary print
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22120 Bug ID: 22120 Summary: Add price formatting to patron summary print Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: katrin.fisc...@bsz-bw.de Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Blocks: 22112 Target Milestone: --- Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 [Bug 22112] Omnibus: Use Price filter everywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22119] Add price formatting in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22119] Add price formatting in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 --- Comment #1 from Katrin Fischer --- Created attachment 83839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83839=edit Bug 22119: Add price formatting in more places in circulation This adds some missing Price filters to some places in circulation. To check verify the amount are displayed according to setting of CurrencyFormat (use FR or CH for seeing a change) Use a patron account with no pending fines at the beginning for all tests. 1) - Switch RentalFeesCheckoutConfirmation to "Ask" - Check out an item with a rental charge - Verify message is formatted correctly: Rental charge for this item: ... 2) - Switch RentalsInNoissuesCharge to "Don't include" - Make sure patron has only Rental fines on their account - Check out another item - Verify message is formatted correctly: The patron has unpaid charges for holds, rentals etc ... 3) - Switch BatchCheckouts to "Allow" - Add the patron category of your test patron to BatchCheckoutsValidCategories - Checkout any item - Verify the message in the information column is formatted correctly: The patron has unpaid charges for holds, rentals etc of ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22119] New: Add price formatting in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 Bug ID: 22119 Summary: Add price formatting in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: katrin.fisc...@bsz-bw.de Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Blocks: 22112 Target Milestone: --- Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 [Bug 22112] Omnibus: Use Price filter everywhere -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22112] Omnibus: Use Price filter everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 Katrin Fischer changed: What|Removed |Added Depends on||22119 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22119 [Bug 22119] Add price formatting in circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/