[Koha-bugs] [Bug 14000] Icons not longer appear on sco
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14000 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Still valid, also for the Finish button: Finish No icon displays. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14261] Discharge management issues on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14261 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16466 CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16466] Patron discharge page should show pending requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16466 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14261 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15192] sanitize_records.pl Unknown option: auto_search (should be auto-search)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15192 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Fixed by bug 17196: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=2096876b36e466becf589cc9433822a57db379a8 *** This bug has been marked as a duplicate of bug 17196 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Katrin Fischer changed: What|Removed |Added CC||pablo.bian...@gmail.com --- Comment #139 from Katrin Fischer --- *** Bug 15192 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15457] HEA : Display of charts is cut on Koha community statistics website
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15457 Katrin Fischer changed: What|Removed |Added Component|Websites, Mailing Lists,|Hea |etc | Version|master |unspecified CC||katrin.fisc...@bsz-bw.de Product|Koha|Project Infrastructure QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17496] install-CPAN.pl documentation/removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 --- Comment #2 from Katrin Fischer --- Created attachment 84944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84944=edit Bug 17496: Remove undocumented/maintained install-CPAN.pl file The install-CPAN.pl file was added in 2007 and hasn't been updated or documented since. This patch removed it from Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17131] Zebra index for Title is too broad
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17131 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- I've added an index to our installations that only indexed 245abnp. Would this work? If yes, what should the index be called? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17496] install-CPAN.pl documentation/removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17496] install-CPAN.pl documentation/removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 Katrin Fischer changed: What|Removed |Added Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Easiest way to start discussion... move this in the needs sign-off queue. Some historical information can be found in the git log, but no details: http://git.koha-community.org/gitweb/?p=koha.git;a=history;f=install-CPAN.pl;h=43555ca38eb53c99e11bc0b95f7d0fadf04c4712;hb=df611b17d12b63bb2f14909969ff8e8f67a332d0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5655] printing of fines should support more than one line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5655 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15273 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 Katrin Fischer changed: What|Removed |Added CC||neng...@gmail.com --- Comment #14 from Katrin Fischer --- *** Bug 5655 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18658] Prevent Modify action when reserved item is awaiting collection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18658 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- On master and I think a few versions back a waiting hold can't be suspended or cancelled from the OPAC. As this was filed against 16.05 I'll set to RESOLVED FIXED. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18670] RewriteLog and RewriteLogLevel unavailable in Apache 2.4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- The lines still appear: debian/templates/apache-site-https.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/opac-rewrite.log debian/templates/apache-site-https.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/intranet-rewrite.log debian/templates/apache-site.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/opac-rewrite.log debian/templates/apache-site.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/intranet-rewrite.log etc/koha-httpd.conf: #RewriteLog __LOG_DIR__/koha-opac-rewrite.log etc/koha-httpd.conf: #RewriteLogLevel 1 etc/koha-httpd.conf: #RewriteLog __LOG_DIR__/koha-intranet-rewrite.log etc/koha-httpd.conf: #RewriteLogLevel 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- The barcode and callnumber are only visilble, when the hold is waiting or when it's an item level hold. I think the barcode column is misused for status messages - it also shows when the item is waiting. Maybe a separate status column would be better? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19648] Repeated positions and some options missing in cataloguing plugin 007 (XML file)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648 --- Comment #2 from Katrin Fischer --- Created attachment 84943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84943=edit Bug 19648: Revise marc21_field_007.xml - Removes some doubled up entries - Fixes some whitespace issues - Adds some missing entries, for example: 007, nonprojected graphic, secondary support material a-c To test: - Verify that the 007 cataloging plugin works correctly and matches standard: http://www.loc.gov/marc/bibliographic/bd007k.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19648] Repeated positions and some options missing in cataloguing plugin 007 (XML file)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19648] Repeated positions and some options missing in cataloguing plugin 007 (XML file)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648 Katrin Fischer changed: What|Removed |Added Summary|Repeated positions in field |Repeated positions and some |007 for sound recording |options missing in |(XML file) |cataloguing plugin 007 (XML ||file) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19648] Repeated positions in field 007 for sound recording (XML file)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19648 Katrin Fischer changed: What|Removed |Added Severity|trivial |normal CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20544] Wrong comment in database documentation for items.itemnotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20544 Katrin Fischer changed: What|Removed |Added Component|Database|Developer documentation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20544] Wrong comment in database documentation for items.itemnotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20544 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Wrong comment in|Wrong comment in database |items.itemnotes |documentation for ||items.itemnotes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE=utf8_bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670
Katrin Fischer changed:
What|Removed |Added
CC||ere.maij...@helsinki.fi,
||katrin.fisc...@bsz-bw.de
--- Comment #1 from Katrin Fischer ---
I confirm, it's still _ci:
--
-- Table structure for table 'search_marc_map'
--
DROP TABLE IF EXISTS search_marc_map;
CREATE TABLE `search_marc_map` (
id int(11) NOT NULL AUTO_INCREMENT,
index_name ENUM('biblios','authorities') NOT NULL COMMENT 'what storage index
this map is for',
marc_type ENUM('marc21', 'unimarc', 'normarc') NOT NULL COMMENT 'what MARC
type this map is for',
marc_field VARCHAR(255) NOT NULL COMMENT 'the MARC specifier for this field',
PRIMARY KEY(`id`),
UNIQUE key `index_name` (`index_name`, `marc_field` (191), `marc_type`),
INDEX (`index_name`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
As we are also using uppercase letters to extent the item subfields, I'd be
interested in fixing this. Note: we already have the different collation on
marc_subfield_structure.tagsubfield
for the same reason.
Can we agree on this change?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE=utf8_bin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670 Katrin Fischer changed: What|Removed |Added Severity|trivial |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20174] Remove xml_sax.pl target from Makefile.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20174 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20174] Remove xml_sax.pl target from Makefile.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20174 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20174] Remove xml_sax.pl target from Makefile.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20174 --- Comment #2 from Katrin Fischer --- Created attachment 84942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84942=edit Bug 20174: Remoe xml_sax.pl target from Makefile.pl There appears to be no xml_sax.pl in Koha, so the reference should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20174] Remove xml_sax.pl target from Makefile.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20174 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Can confirm the line is still there: Makefile.PL: './xml_sax.pl'=> 'PERL_MODULE_DIR', I can't find a file in Koha with this name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22299] Typo in parameter of import_patrons.pl: preserve_extended_atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22299 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > There seems also to be an issue with the sort order used not being > higlighted in some cases when coming from the advanced search (see bug 21071) Wrong tab/bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21710] Fix typo atributes in some installer files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Katrin Fischer changed: What|Removed |Added Summary|Typo: atributes |Fix typo atributes in some ||installer files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20544] Wrong comment in items.itemnotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20544 --- Comment #1 from Katrin Fischer --- Created attachment 84941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84941=edit Bug 20544: Wrong comment database documentation on itemnotes Fixes the comments in kohastructure.sql to state the right MARC21 fields for itemnotes (public and internal). To test: - Create a new Koha database and make sure it still installs - Read the patch and check comments are correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20544] Wrong comment in items.itemnotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20544 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21071] Search results not sorting in staff client advanced search when only AdvancedSearchTypes checkboxes are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21071 --- Comment #4 from Katrin Fischer --- There is a mismatch between search parameters specifically for relevance: When coming from the advanced search, the form uses: relevance When doing a search on simple search: relevance_dsc I know I could fix the highlighting, but I am not sure if search needs a fix instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21071] Search results not sorting in staff client advanced search when only AdvancedSearchTypes checkboxes are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21071 Katrin Fischer changed: What|Removed |Added Version|17.11 |master --- Comment #3 from Katrin Fischer --- I think I see what Lucy might have meant: When coming form advanced search, the sorting option used is not highlighted on the sort pulldown. To test: - Make sure defaultSortField/defaultSortOrder are set to relevance - Go to advanced search - Check item type "Books" (assuming sample data) - Search - Open pull down for "Sort" on top - Verify none of the options is 'checked' - Change default sort to "title" - Repeat steps - option is now checked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21071] Search results not sorting in staff client advanced search when only AdvancedSearchTypes checkboxes are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21071 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22299 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22299] Typo in parameter of import_patrons.pl: preserve_extended_atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22299 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21071 --- Comment #2 from Katrin Fischer --- There seems also to be an issue with the sort order used not being higlighted in some cases when coming from the advanced search (see bug 21071) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] New: Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Bug ID: 22300 Summary: Staff search results: Opt groups in 'sort' pull down are not well formatted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Target Milestone: --- In older versions (17.11) the groups of the various sort options were bold, options indented and sections divided by thin lines. In master and 18.11 the display isn't as nice and harder to read. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21268] Can't add to basket from staged file if base-level allocated is zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21268
--- Comment #3 from Katrin Fischer ---
I tested a bit on master: the funds = 0 now show when adding a new order, but
are for example not in the fund pull down on receiving the order.
> acqui/addorderiso2709.pl:if ( !defined $r->{budget_amount} ||
> $r->{budget_amount} == 0 ) {
> acqui/basket.pl:if (!defined $r->{budget_amount} ||
> $r->{budget_amount} == 0) {
> acqui/booksellers.pl:if (!defined $r->{budget_amount} ||
> $r->{budget_amount} == 0) {
> acqui/neworderbiblio.pl:if (!defined $r->{budget_amount} ||
> $r->{budget_amount} == 0) {
> acqui/neworderempty.pl:if (!defined $r->{budget_amount} ||
> $r->{budget_amount} <0) {
> acqui/orderreceive.pl:if ( !defined $r->{budget_amount} ||
> $r->{budget_amount} == 0 ) {
> acqui/parcels.pl:if (!defined $r->{budget_amount} || $r->{budget_amount}
> == 0) {
>
>
> It's '== 0' vs '< 0'
>
> So we we should fix neworderempty and replace '<0' with '== 0'
I am not sure what would be the right behaviour here. I think having to add
0.01 just to make a fund you want to use for handling 'free' orders is a bit
clumsy right now. I wonder if the cleaner solution would be to just check if
the fund exists and omit testing for the amount in all places. Or: Only test
for negative with <0 everywhere.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21268] Can't add to basket from staged file if base-level allocated is zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21268 --- Comment #2 from Katrin Fischer --- We have seen the issue for normal ordering as well after migrations where the amounts hadn't been set yet or for funds that are set up purely for handling donations or 'exchanged' items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22299] Typo in parameter of import_patrons.pl: preserve_extended_atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22299 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22299] Typo in parameter of import_patrons.pl: preserve_extended_atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22299 --- Comment #1 from Katrin Fischer --- Created attachment 84940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84940=edit Bug 22299: Fix typo in option of import_patrons.pl Fix typo in 'p|preserve-extended-atributes' option of the import_patrons.pl script. To test: - Use the script to import patron data. - Verify behaviour is the same with and without the patch concerning the preserve-extended_at(t)tributes option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21710] Typo: atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Katrin Fischer changed: What|Removed |Added Attachment #84939|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21710] Typo: atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | --- Comment #3 from Katrin Fischer --- I've split the changes into 2 patches: - The changes to the installer are easy and will only effect display. - The change to the parameter of the script is trickier - it will break the use of the script for people having it automated with the typo... not sure what to do here. First thing I will do is moving the issue to a separate bug 22299. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22299] New: Typo in parameter of import_patrons.pl: preserve_extended_atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22299 Bug ID: 22299 Summary: Typo in parameter of import_patrons.pl: preserve_extended_atributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Target Milestone: --- Moving the typo fix from bug 21710 to this new bug as it might need more discussion. Fixing the typo as the attached patch does could potentially break automated scripts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21710] Typo: atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 --- Comment #2 from Katrin Fischer --- Created attachment 84939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84939=edit Bug 21710: Fix typo in option of import_patrons.pl Fix typo in 'p|preserve-extended-atributes' option of the import_patrons.pl script. To test: - Use the script to import patron data. - Verify behaviour is the same with and without the patch concerning the preserve-extended_at(t)tributes option -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21710] Typo: atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 --- Comment #1 from Katrin Fischer --- Created attachment 84938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84938=edit Bug 21710: Fix typo in atributes in installer Adds the missing t to some atributes in the web installer files. To test: Easiest to verify by looking at the patches, changes appear in comments and the text shown by the nb-NO and English web installer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22170] Library group description input field should be longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170 --- Comment #3 from Katrin Fischer --- Created attachment 84937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84937=edit Bug 22056: Remove remaining files in test directories It looks like these directories and test files were added by bug 5309. Later, most of the files were removed as no longer needed by bug 14321. Test: Verify that the files removed are no longer in use and can be safely removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22170] Library group description input field should be longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | --- Comment #2 from Katrin Fischer --- I tried to copy parts of what Owen did recently with the 'Draw SQL charts' modal, hopefully it makes sense :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22170] Library group description input field should be longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170 --- Comment #1 from Katrin Fischer --- Created attachment 84936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84936=edit Bug 22170: Improve display of add/edit library group modal Tries to bring the emodal for adding/editing library root and sub groups more in line with the rest of Koha. To test: - Go to Administration > Library groups - With and without patch test following actions: - Add a new root group - Edit root group - Add sub-group entry - Edit sub-group entry - Verify that with the patch the display of the labels is more standard (bold and aligned to the right) and the input fields are a bit longer to allow for easier data entry. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22170] Library group description input field should be longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22171] Format shipping cost on invoice.pl with with 2 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22171 --- Comment #1 from Katrin Fischer --- Created attachment 84935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84935=edit Bug 22171: Fix shipping cost display on invoice When not 0 the shipping cost on the invoice would display with a lot of numbers after the comma. This fixed it to display with only 2. To test: - Make sure you have an invoice with shipping cost set (example: 5.00) - Open the invoice for editing (invoice.pl) - Verify the shipping cost displays with too many decimals (5.00) - Apply patch - Verify now the shipping cost displays correctly (5.00) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22171] Format shipping cost on invoice.pl with with 2 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22171 Katrin Fischer changed: What|Removed |Added Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22171] Format shipping cost on invoice.pl with with 2 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22171 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22171] Format shipping cost on invoice.pl with with 2 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22171 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||oleon...@myacpl.org --- Comment #31 from Katrin Fischer --- This might a little change soon depending on Owen's work on bug 22015. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #55 from Katrin Fischer --- Patch currently doesn't apply, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #15 from Katrin Fischer --- On second thought - Andrew, can we have some unit tests for testing the new behaviour of the method please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 --- Comment #14 from Katrin Fischer --- This works as described but doesn't cover one use case: A library that doens't want to allow OPAC initiated requests. Something to think about later maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 --- Comment #13 from Katrin Fischer --- Created attachment 84934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84934=edit Bug 20639: (QA follow-up) Rephrase system preference Rephrases system preference a tiny bit and explaining case of leaving the pref empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Katrin Fischer changed: What|Removed |Added Attachment #79477|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 84932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84932=edit Bug 20639: Add ILLOpacbackends syspref This adds the ILLOpacbackends syspref, allowing users to refine the ill backends available to opac users for initiating ill requests Remove default assignment for backends We don't need a default assignment for the ILLOpacbackends assignment, if the pref isn't set, it returns undef anyway. Also, having this default assignment actually breaks the fetching of the preference Signed-off-by: niamh.walker-hea...@it-tallaght.ie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Katrin Fischer changed: What|Removed |Added Attachment #79478|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 84933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84933=edit Bug 20639: (follow-up) Fix population of backends The OPAC view wasn't correctly restricting the display of backends when the ILLOpacbackends preference was set. See the test plan on comment 7 Signed-off-by: niamh.walker-hea...@it-tallaght.ie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 --- Comment #191 from Katrin Fischer --- I still have one issue with this: I don't like -1 in illrequests.status_alias meaning 'no status set'. I'd be much happier with NULL. But I think we should be able to work this out separately from this bug and maybe at the end or on another branch of the 'ILL tree'. Maybe others can give some input then too on how to handle the situation with the Authorised values best. The functionality works now well enough for me to pass it and move on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84818|0 |1 is obsolete|| --- Comment #188 from Katrin Fischer --- Created attachment 84929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84929=edit Bug 20581: (follow-up) Fix status_alias comparison status_alias will arrive in the Koha object as a string, so when we special case it, we should also pass a string Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84791|0 |1 is obsolete|| --- Comment #186 from Katrin Fischer --- Created attachment 84927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84927=edit Bug 20581: (follow-up) Fix typo in DB upgrade IN -> ON Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84819|0 |1 is obsolete|| --- Comment #189 from Katrin Fischer --- Created attachment 84930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84930=edit Bug 20581: (follow-up) Fix unit test Since we're now storing the authorised_value column as the foreign key, rather than the id, we need to account for this in the test Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84814|0 |1 is obsolete|| --- Comment #187 from Katrin Fischer --- Created attachment 84928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84928=edit Bug 20581: (follow-up) Overload status_alias We need Koha::Illrequest->status_alias to return the correct authorised value. Since the foreign key uses a non-unique column, we need to take into account the authorised value category too. This patch overloads status_alias with some additional logic that considers the request's branch and the authorised value category to attempt to return the correct value. The same logic is applied to the custom statusalias method, which returns the entire AuthorisedValue object Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84844|0 |1 is obsolete|| --- Comment #190 from Katrin Fischer --- Created attachment 84931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84931=edit Bug 20581: (follow-up) Passed value to status_alias Now we have overloaded status_alias, we can no longer pass it undef (as it uses that to determine if it's being used as a getter or setter). So we now pass it -1 to indicate it should actually be setting undef (a hack, I know, but what are you going to do...) This patch makes sure ill-request.pl conforms to that. It also fixes the testing of the passed parameter, which was wrong. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84784|0 |1 is obsolete|| --- Comment #184 from Katrin Fischer --- Created attachment 84925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84925=edit Bug 20581: (follow-up) Fix dependency requirement Since this bug is now dependent on Bug 20600 (Provide the ability for users to filter ILL requests) we need to make the status filtering aware of the custom statuses. This patch does that. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84783|0 |1 is obsolete|| --- Comment #183 from Katrin Fischer --- Created attachment 84924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84924=edit Bug 20581: (follow-up) Fix QA errors This patch fixes the "missing_filter" errors on ill-requests.tt Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84782|0 |1 is obsolete|| --- Comment #182 from Katrin Fischer --- Created attachment 84923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84923=edit Bug 20581: (follow-up) Fix typo in kohastructure Fix the missing comma Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84785|0 |1 is obsolete|| --- Comment #185 from Katrin Fischer --- Created attachment 84926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84926=edit Bug 20581: (follow-up) Do not use PK for AV FK As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c133 We switch from using authorised_values.id when creating the foreign key illrequests.status_alias, we now use authorised_values.authorised_value I have added a migration from using id -> authorised_value, so when existing users of this bug get this version, their DB migrates nicely instead of just breaking. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84780|0 |1 is obsolete|| --- Comment #180 from Katrin Fischer --- Created attachment 84921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84921=edit Bug 20581: (follow-up) Fix AV population As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c72 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84781|0 |1 is obsolete|| --- Comment #181 from Katrin Fischer --- Created attachment 84922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84922=edit Bug 20581: (follow-up) Modify POD As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c69 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84777|0 |1 is obsolete|| --- Comment #177 from Katrin Fischer --- Created attachment 84918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84918=edit Bug 20581: (follow-up) Allow for undefined lib As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c59 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84778|0 |1 is obsolete|| --- Comment #178 from Katrin Fischer --- Created attachment 84919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84919=edit Bug 20581: (follow-up) Fix statusalias return As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c57 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84774|0 |1 is obsolete|| --- Comment #174 from Katrin Fischer --- Created attachment 84915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84915=edit Bug 20581: Fix display of status alias in OPAC Fix for status alias display in OPAC, we should be displaying the status name, not the status code. Signed-off-by: niamh.walker-hea...@it-tallaght.ie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84776|0 |1 is obsolete|| --- Comment #176 from Katrin Fischer --- Created attachment 84917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84917=edit Bug 20581: (follow-up) Display status name Rather than display the status code for custom statuses, we should be displaying the name Signed-off-by: niamh.walker-hea...@it-tallaght.ie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84779|0 |1 is obsolete|| --- Comment #179 from Katrin Fischer --- Created attachment 84920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84920=edit Bug 20581: (follow-up) Fix fallback status_alias As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c68 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84771|0 |1 is obsolete|| --- Comment #171 from Katrin Fischer --- Created attachment 84912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84912=edit Bug 20581: Provide status_alias on IllRequest This patch provides status_alias support for the Koha::Illrequest object. - New 'statusalias' getter method, returns the request's status_alias authorised value object if set, otherwise undef - Overloads existing 'status' method, getter/setter accessors intact, but setting the request's status now implicitly removes any status_alias that has been set Signed-off-by: niamh.walker-hea...@it-tallaght.ie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84775|0 |1 is obsolete|| --- Comment #175 from Katrin Fischer --- Created attachment 84916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84916=edit Bug 20581: Unit tests for status_alias This patch adds unit tests for the specific status_alias functionality added in this bug - Creation of the ILLSTATUS authorised value - Illrequest->statusalias accessor - Illrequest->status overloading to reset status_alias To test: 1) Apply this patch 2) prove t/db_dependent/Illrequests.t Signed-off-by: niamh.walker-hea...@it-tallaght.ie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84772|0 |1 is obsolete|| --- Comment #172 from Katrin Fischer --- Created attachment 84913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84913=edit Bug 20581: API provide status_alias embed - This patch provides the illrequests API route with an additional embed, called 'status_alias'. Requesting this embed returns an object for the request's status_alias authorised value, or null if one is not set. - This patch also adds the new status_alias as a default embed on the API call made by the illlist view Signed-off-by: niamh.walker-hea...@it-tallaght.ie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84773|0 |1 is obsolete|| --- Comment #173 from Katrin Fischer --- Created attachment 84914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84914=edit Bug 20581: Add display of status_alias to staff vw - This patch adds display of the new status_alias value, when set, in favour of the request's status value. - It also allows the user to set a status_alias for an existing request. When set, this value will be displayed in preference to the status. Signed-off-by: niamh.walker-hea...@it-tallaght.ie Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Attachment #84770|0 |1 is obsolete|| --- Comment #170 from Katrin Fischer --- Created attachment 84911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84911=edit Bug 20581: Modifications to database schema - This patch provides an illrequests.status_alias column that is a foreign key to authorised_values.id. This provides the ability for an ILL request to have an optional status alias that is defined as an authorised valued. - A new ILLSTATUS authorised value category is also made available during install. Signed-off-by: niamh.walker-hea...@it-tallaght.ie Following commit was squashed into this one: Bug 20581: (follow-up) Modify DB updgrade As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c56 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20581] Allow manual selection of custom ILL request statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 --- Comment #5 from Katrin Fischer --- I am still not sure if the fix is right :( My reasoning is that people might have added sub groups for organizing relying on the fact that they will not take effect. So changing it one way or the other now will make someone unhappy. Allowing only the root group settings seems the more logical path to me. Also: An empty root group won't show up (good), but an empty sub group will. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- Hi Kyle, I have seen the issue on updating, but I am not able to create the first setup from the GUI anymore, I only get the checkbox options when I am at root level. I am not sure what the best solution is, changing the GUI to allow for both or improving the update scripts? RootGroup Searchgroup Can you take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 --- Comment #4 from Katrin Fischer --- Hm, I think I misread the test plan. So the 'attributes' are set top level and then inherited? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Katrin Fischer changed: What|Removed |Added Version|unspecified |master CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22282] Internal software error when exporting basket group as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22282 Katrin Fischer changed: What|Removed |Added Attachment #84891|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 84910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84910=edit Bug 22282 - Fix PDF issue when exporting PDF in French format. Fixing up QA comments, keeping 1st instance and removing the 2nd. Original test plan by Christophe Croullebois. To test : Without the patch : 1° select in Acquisitions preferences/OrderPdfFormat French 3-page 2° restart plack if needed 3° In acqui/basketgroup.pl select closed tab 4° Click on "Export as PDF" button 5° You should see a blank page saying "Internal Server Error" With the patch : Do the same Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22282] Internal software error when exporting basket group as PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22282 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer --- This works nicely and is an easy fix which is unlikely to have any side effects. It would probably still be nice to have a regression test to avoid future breakage. Leaving final decision to Nick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Katrin Fischer changed: What|Removed |Added Attachment #84894|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 84909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84909=edit Bug 21832: Restore is_expired in ILS-DI GetPatronInfo service Since Bug 17578 removed C4::Member::GetMemberDetails, the information "is_expired" disappeared from ILS-DI service GetPatronInfo. I propose to restore in by adding the code that exisited in C4::Member::GetMemberDetails directly in C4::ILSDI::Services. Test plan : 1) Enable ILS-DI webservice 2) Choose a patron not expired 3) Call web-service (replace X with patron's borrowernumber) : /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=X 4) You see : 0 5) Choose a patron expired 6) Call web-service (replace X with patron's borrowernumber) : /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=X 7) You see : 1 Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21444] Permanent location should show with cart location - returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21444
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||martin.renvoize@ptfs-europe
||.com
--- Comment #5 from Katrin Fischer ---
Hi Christopher,
I'have tested it and it works nicely. I wonder if it should be Book cart
(permanent location) as the first is the current... but I think both work.
But I'd like to ask you to move the display logic, like setting the () to the
template.
I have to say that I am confused by all the checking before your patch and
after - but I notice it's different than before?
-$ri{'location'} = $shelflocations->{$shelfcode} if ( defined(
$shelfcode ) && defined($shelflocations) && exists(
$shelflocations->{$shelfcode} ) );
+my $permshelfcode = $ri{'permlocation'};
+$ri{'location'} = ( $shelflocations->{$permshelfcode} ne '' ) ?
$shelflocations->{$permshelfcode} : ( $permshelfcode ) ? $permshelfcode :
undef;
+$ri{'location'} .= ( ( $shelflocations->{$shelfcode} ne '' ) && (
$shelfcode ne $permshelfcode ) ) ? ' (' . $shelflocations->{$shelfcode} . ')' :
( ( $shelfcode ) && ( $shelfcode ne $permshelfcode ) ) ? ' (' . $shelfcode .
')' : undef;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #23 from Katrin Fischer --- Hi Owen, this seems to work well overall, but there is one little change to before: When a record has no ratings yet, on the detail page one star shows in yellow by default. Could we change that to be zero stars as before? Stars seem a little bit bigger than before (but nicer icons). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22293] Sticky toolbar making vendor form uneditable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 --- Comment #6 from Katrin Fischer --- Thx for the quick fix and 2 sign-offs! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22293] Sticky toolbar making vendor form uneditable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 Katrin Fischer changed: What|Removed |Added Attachment #84904|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 84908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84908=edit Bug 22293: Sticky toolbar making vendor form uneditable The new floating toolbar plugin doesn't like a particular combination of markup: A toolbar inside a form which is styled "display:inline." The staff client CSS styles forms that way globally, so it must be explicitly overridden in these situations. Changing the default will have broad consequences, so I propose an inline style to fix this. To test, apply the patch and go to Acquisitions. Add or edit a vendor and confirm that after scrolling down the page the form is still editable. Signed-off-by: Andrew Isherwood Signed-off-by: Mikaël Olangcay Brisebois Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22293] Sticky toolbar making vendor form uneditable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22293] Sticky toolbar making vendor form uneditable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22293 Katrin Fischer changed: What|Removed |Added Version|unspecified |master Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22261] Revise style of DataTables menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
