[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||maryse.sim...@inlibro.com --- Comment #10 from Maryse Simard --- Patch doesn't apply Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14866: Make high holds work with different item types .git/rebase-apply/patch:88: space before tab in indent. .git/rebase-apply/patch:89: space before tab in indent. [% END %] warning: 2 lines add whitespace errors. Using index info to reconstruct a base tree... M C4/Circulation.pm M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt .git/rebase-apply/patch:88: space before tab in indent. .git/rebase-apply/patch:89: space before tab in indent. [% END %] warning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging admin/smart-rules.pl CONFLICT (content): Merge conflict in admin/smart-rules.pl Auto-merging C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14866: Make high holds work with different item types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #82708|0 |1 is obsolete|| --- Comment #8 from José-Mario Monteiro-Santos --- Created attachment 85205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85205=edit Bug 21091: Move add item template JavaScript to a separate file This patch moves the JavaScript in the add item template to separate files: 1 JS file and 1 include file containing translatable strings. While moving the JS to cataloging_additem.js I have made some changes to quiet ESLint warnings (spacing, variable definition). To test, apply the patch and open the add item page for an existing record. Test the various JS-driven functionalities: - Table sorting - Table column configuration - Table searching - Table inline edit/delete links (click anywhere in the table row) - Add multiple item form show/hide - Add multiple item warning when adding 100+ items Signed-off-by: Jose-Mario Monteiro-Santos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 José-Mario Monteiro-Santos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20485] Don't account for items timestamps when combining "dont_export_items=1" and "date" in export_records.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20485 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Failed QA --- Comment #5 from Maryse Simard --- With the patch applied, I still get the biblio for wich items were modified in the output. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18939] Record matching rules didnot work by matching with callnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18939 Nick Clemens changed: What|Removed |Added Text to go in the||See bug 18939 - typo in release notes||commit messages CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22239] JavaScript error on subscription detail page when there are no orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22239] JavaScript error on subscription detail page when there are no orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 Katrin Fischer changed: What|Removed |Added Attachment #85190|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 85204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85204=edit Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree. Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18393] Statistics wizard for acquisitions not filtering correctly by collection code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12488] Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #89 from Nick Clemens --- I looked at this today, but the update statement is a little confusing. Should we update a library's mappings in updates? or simply require that they reset mappings when upgrading? I am okay with updating, but it also seems some of the lines are unnecessary with the generic statement of lower casing at the top? Can you review and format the update using skeleton.perl? Or let me know if I missed something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22171] Format shipping cost on invoice.pl with with 2 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22171 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20174] Remove xml_sax.pl target from Makefile.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20174 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22287] Correct new charts CSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22287 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Katrin Fischer changed: What|Removed |Added Attachment #85186|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 85203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85203=edit Bug 22300: Staff search results: Opt groups in 'sort' pull down are not well formatted This patch adds some CSS to style the staff client search results sort menu headings. Formerly these were tags with a default browser style. To test, apply the patch and regenerate the staff client CSS. - Perform a catalog search in the staff client. - On the search results page, test the "Sort" menu. Confirm that the menu headers more clearly indicate the sections. - Test the "Add to list" button menu too, where the same style will be in use. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Charles Farmer changed: What|Removed |Added Attachment #84860|0 |1 is obsolete|| --- Comment #5 from Charles Farmer --- Created attachment 85202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85202=edit Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Charles Farmer changed: What|Removed |Added Attachment #78103|0 |1 is obsolete|| --- Comment #4 from Charles Farmer --- Created attachment 85201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85201=edit Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: Self issue an item 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22347] Translatability of ILSDI results for getavaibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Would you want it to be only in one langauge or should there be something like a language parameter to get different translations when needed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19534] Adding collection code attribute to cover image div
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19534 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from José-Mario Monteiro-Santos --- Patch doesn't apply Applying: Bug [19534] - [Adding collection code attribute to cover image div] Adds collection code value to cover image class, so specific collection code icons can be assigned to search results Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt error: Failed to merge in the changes. Patch failed at 0001 Bug [19534] - [Adding collection code attribute to cover image div] Adds collection code value to cover image class, so specific collection code icons can be assigned to search results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22351] SCSS conversion broke style on last checked out information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22351 Katrin Fischer changed: What|Removed |Added Attachment #85185|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 85200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85200=edit Bug 22351: SCSS conversion broke style on last checked out information This patch makes a minor change to the staff client SCSS to correct an error which happened in the SCSS conversion. To test, apply the patch and regenerate the staff client CSS. Check out an item to a patron. The box showing information about the item you just checked out should be flush with the checkout form box. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22351] SCSS conversion broke style on last checked out information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22351 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21034] Re-indent circulation.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||maryse.sim...@inlibro.com --- Comment #9 from Maryse Simard --- Patch doesn't apply Applying: Bug 21034: Re-indent circulation.tt Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 21034: Re-indent circulation.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22351] SCSS conversion broke style on last checked out information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22351 --- Comment #3 from Katrin Fischer --- *** Bug 21363 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21363] Unwanted margin between checkout form and last checked out information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21363 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 22351 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22008] Missing constraints on accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||maryse.sim...@inlibro.com --- Comment #11 from Maryse Simard --- Patch doesn't apply Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22008: Add missing constraints to accountlines Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 22008: Add missing constraints to accountlines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #82557|0 |1 is obsolete|| --- Comment #2 from José-Mario Monteiro-Santos --- Created attachment 85199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85199=edit Bug 21870: Convert browser alerts to modals: OPAC user summary This patch updates the user summary page in the OPAC so that JavaScript alerts are replaced with Bootstrap modals. This provides us the ability to more carefully control the content of confirmation dialogs and their control buttons. A global function for defining a modal confirmation boxes has been added, to which one can pass: - The modal title - Body - Text for submit and cancel buttons - A callback function to trigger on submit To test, apply the patch and clear your browser cache if necessary. - Log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request Signed-off-by: Jose-Mario Monteiro-Santos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Attachment #85160|0 |1 is obsolete|| --- Comment #445 from Katrin Fischer --- Created attachment 85198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85198=edit Bug 7143: (follow-up) Update about page for new devs (Academy) It's now 2019! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11375] Improve patrons permissions display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||maryse.sim...@inlibro.com --- Comment #24 from Maryse Simard --- Patch doesn't apply Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11375: Improve patrons permissions display Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Removing koha-tmpl/intranet-tmpl/prog/css/treeview/jquery.treeview.css Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-red.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-red-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-gray.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-gray-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-famfamfam.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-famfamfam-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-default.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-default-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-black.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/treeview-black-line.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/plus.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/minus.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/folder.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/folder-closed.gif Removing koha-tmpl/intranet-tmpl/prog/css/treeview/images/file.gif Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Removing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.treeview.pack.js error: Failed to merge in the changes. Patch failed at 0001 Bug 11375: Improve patrons permissions display The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11375-Improve-patrons-permissions-display-P1z7Qv.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Genevieve Beaudry changed: What|Removed |Added CC||genevieve.beaudry@inlibro.c ||om --- Comment #31 from Genevieve Beaudry --- at step 11, I get the following error: Use of inherited AUTOLOAD for non-method Koha::Hold::ModReserveAffect() is deprecated. This will be fatal in Perl 5.28 at /inlibro/git/koha-master-dev-inlibro/Koha/Hold.pm line 385. Can't locate object method "_columns" via package "177333" (perhaps you forgot to load "177333"?) at /inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 443. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820
Charles Farmer changed:
What|Removed |Added
Attachment #85161|0 |1
is obsolete||
--- Comment #20 from Charles Farmer ---
Created attachment 85196
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85196=edit
Bug 3820: Add changes to MEMBERS MODIFY logaction
This patch attemps to add a more refined and detailed info structure
detailing what fields were changed and what they were changed from and
to.
Test Plan: Enable BorrowersLog in the system preferences and undertake a
series of borrower detail changes. Go to view the actionlogs and note
that MEMBER MODIFY logs now detail what fields you have changed using
the following form:
{ FIELD1: { before: BEFORE_VALUE, after: AFTER_VALUE } }
Signed-off-by: Owen Leonard
Signed-off-by: Charles Farmer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3820] Members in Log Viewer Showing ?? in UPDATE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Charles Farmer changed: What|Removed |Added Attachment #85162|0 |1 is obsolete|| --- Comment #21 from Charles Farmer --- Created attachment 85197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85197=edit Bug 3820: (follow-up) Clean up warnings Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22225] Tax hints and prices on orderreceive.pl may not match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5 --- Comment #2 from Pierre-Marc Thibault --- Can you please provide a test plan so we can easily confirm it works? Thank you -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login attempts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #4 from Agnes Rivers-Moore --- We have had some accounts apparently fail to allow repeat login attempts to the limit in our preferences. In investigating this, support noted that the database counter resets back to zero after a successful login, leaving no record of the failed attempts. We would really like Koha to keep the log of successful and unsuccessful account login attempts - with timestamp. Even if we don't have it logged and visible to staff it would be helpful to support for troubleshooting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18952] Show internal note in acquisitions details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Pierre-Marc Thibault changed: What|Removed |Added Attachment #84901|0 |1 is obsolete|| --- Comment #9 from Pierre-Marc Thibault --- Created attachment 85195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85195=edit Bug 18952: Add internal note to acq details tab Any important notes about an order are usually added to the internal note. This patch makes the note visible on the acq detail tab in the staff client. To test: - Add a basket - Order something - Add an internal note for the order - Go to the detail page of the ordered record - Switch to the Acquisition details tab - Verify that with the patch the internal note shows - Verify that the new column can be toggled using the column visibility settings Signed-off-by: Maryse Simard Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22353] New: ReturnBeforeExpiry date supplanted by SpecifyDueDate preference date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22353 Bug ID: 22353 Summary: ReturnBeforeExpiry date supplanted by SpecifyDueDate preference date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alexandre.bre...@ccsr.qc.ca QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Target Milestone: --- When ReturnBeforeExpiry preference is activated, the item due date can’t be placed after the patron account end date. However, if we manually specify a return date before we create the loan, this date will be overcame without any mention. A warning message should inform us that the due date manually entered will go beyond the patron account end date. Thanks you, Alexandre -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22156] Subscription result list sorts on "checkbox" by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22156] Subscription result list sorts on "checkbox" by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #84149|0 |1 is obsolete|| --- Comment #8 from José-Mario Monteiro-Santos --- Created attachment 85194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85194=edit Bug 22156: (17.11.x) Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22156] Subscription result list sorts on "checkbox" by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 José-Mario Monteiro-Santos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22156] Subscription result list sorts on "checkbox" by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #84148|0 |1 is obsolete|| --- Comment #7 from José-Mario Monteiro-Santos --- Created attachment 85193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85193=edit Bug 22156: Subscription result list sorts on "checkbox" by default This patch adds default sorting by title to the subscription search results list. Previously no default sort was defined, so it defaulted to sorting by the first column in the table. To test, apply the patch and go to Serials. - Perform a search of subscriptions which will return multiple results. - Confirm that the table of open subscriptions is sorted by default by title ascending. - Confirm the same for the table of closed subscriptions. Signed-off-by: Jose-Mario Monteiro-Santos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22170] Library group description input field should be longer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170 Mikaël Olangcay Brisebois changed: What|Removed |Added Attachment #84972|0 |1 is obsolete|| --- Comment #6 from Mikaël Olangcay Brisebois --- Created attachment 85192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85192=edit Bug 22170: Improve display of add/edit library group modal Tries to bring the emodal for adding/editing library root and sub groups more in line with the rest of Koha. To test: - Go to Administration > Library groups - With and without patch test following actions: - Add a new root group - Edit root group - Add sub-group entry - Edit sub-group entry - Verify that with the patch the display of the labels is more standard (bold and aligned to the right) and the input fields are a bit longer to allow for easier data entry. Signed-off-by: Owen Leonard Signed-off-by: Mikaël Olangcay Brisebois -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #12 from José-Mario Monteiro-Santos --- Patch doesn't apply Applying: Bug 15505 - Mark Hold Items 'On hold' instead of 'Available' .git/rebase-apply/patch:51: trailing whitespace. } warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Items.pm M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc M koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl M t/db_dependent/Items.t .git/rebase-apply/patch:51: trailing whitespace. } warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Items.t CONFLICT (content): Merge conflict in t/db_dependent/Items.t Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging C4/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15505 - Mark Hold Items 'On hold' instead of 'Available' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Joy Nelson changed: What|Removed |Added Status|ASSIGNED|In Discussion CC||j...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17236] Add minute and hours to last checked out item display for hourly loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17236 Mikaël Olangcay Brisebois changed: What|Removed |Added Attachment #85181|0 |1 is obsolete|| --- Comment #3 from Mikaël Olangcay Brisebois --- Created attachment 85191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85191=edit Bug 17236: Add minute and hours to last checked out item on circulation for hourly loans This is a simple fix using the right TT filter: [% issue.date_due | $KohaDates as_due_date => 1 %] The time part of the due date will only display if it's an hourly loan (!=23:59) To test: - Check out 2 items - One with a loan period in days - One with a loan period in hours - Verify the the due date only shows the date part - Apply patch - Return items and repeat - Verify that now the time part will show for the hourly loan Signed-off-by: Owen Leonard Signed-off-by: Mikaël Olangcay Brisebois -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 Genevieve Beaudry changed: What|Removed |Added CC||genevieve.beaudry@inlibro.c ||om Status|Needs Signoff |Signed Off --- Comment #6 from Genevieve Beaudry --- patch working -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22239] JavaScript error on subscription detail page when there are no orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 Charles Farmer changed: What|Removed |Added Attachment #84540|0 |1 is obsolete|| --- Comment #3 from Charles Farmer --- Created attachment 85190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85190=edit Bug 22239: JavaScript error on subscription detail page when there are no orders This page modifies the subscription detail page so that a JavaScript error isn't triggered when a subscription has no acquisition details. To test, apply the patch and go to Serials. - Locate a subscription which isn't tied to acquisitions. In the browser console there should be no errors. - Locate a subscription which is part of an order. There should be an 'Acquisitions details' tab and the order information on that tab should be displayed as a collapsible tree. Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22239] JavaScript error on subscription detail page when there are no orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22323] cronjob runreport.pl CSV encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22323 Mikaël Olangcay Brisebois changed: What|Removed |Added Attachment #85061|0 |1 is obsolete|| --- Comment #2 from Mikaël Olangcay Brisebois --- Created attachment 85189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85189=edit Bug 22323: cronjob runreport.pl CSV add encoding Cronjob runreport.pl runs SQL reports and can export as CSV. This export needs to be UTF-8 encoded. This pathes replaces use of Text::CSV_XS by Text::CSV::Encoded like in other places like tools/viewlog.pl. It adds a decode of headers bcause they will be encoded lika other lines. Test plan: 1) Create a new item with itemnotes 'accentué' 2) Create a SQL report with : SELECT barcode,itemnotes AS itè FROM items WHERE itemnotes LIKE 'accenté' 3) Run this report 4) You see well encoded header and content 5) Run from command line (replace X by report number) : misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results 6) You well encoded header and content 7) Go to saved reports table 8) Look at saved results of report 9) You well encoded header and content Signed-off-by: Mikaël Olangcay Brisebois -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22323] cronjob runreport.pl CSV encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22323 Mikaël Olangcay Brisebois changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18166] Show internal and vendor notes for received orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #84949|0 |1 is obsolete|| --- Comment #3 from José-Mario Monteiro-Santos --- Created attachment 85188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85188=edit Bug 18166: Show internal and vendor notes for receivied orders This copies the logic for showing, adding and editing vendor and internal notes from the pending orders to the received orders. To test: - In acquisitions create a basket with orders - Make your you have some internal and vendor notes - Close the basket and receive shipment - Create or reuse an invoice - Receive some of your orders - Verify that the notes don't show for received orders - Apply patch - Verify that the edit/change vendor/internal note links work the same on pending and received orders Signed-off-by: Jose-Mario Monteiro-Santos -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18166] Show internal and vendor notes for received orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 José-Mario Monteiro-Santos changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jose-mario.monteiro-santos@ ||inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21335] Remove redundant includes of right-to-left.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Charles Farmer changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21335] Remove redundant includes of right-to-left.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Charles Farmer changed: What|Removed |Added Attachment #85184|0 |1 is obsolete|| --- Comment #4 from Charles Farmer --- Created attachment 85187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85187=edit Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available Signed-off-by: Owen Leonard Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21845] Sort of issues in OPAC subscription table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845 Mikaël Olangcay Brisebois changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mikael.olangcay-brisebois@i ||nLibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21335] Remove redundant includes of right-to-left.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com Status|Signed Off |Patch doesn't apply --- Comment #3 from Charles Farmer --- Bug 10659 seems the be getting in the way of a clean apply. I'll rebase and submit my signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Pierre-Marc Thibault changed: What|Removed |Added Attachment #84980|0 |1 is obsolete|| --- Comment #2 from Pierre-Marc Thibault --- Created attachment 85186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85186=edit Bug 22300: Staff search results: Opt groups in 'sort' pull down are not well formatted This patch adds some CSS to style the staff client search results sort menu headings. Formerly these were tags with a default browser style. To test, apply the patch and regenerate the staff client CSS. - Perform a catalog search in the staff client. - On the search results page, test the "Sort" menu. Confirm that the menu headers more clearly indicate the sections. - Test the "Add to list" button menu too, where the same style will be in use. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22351] SCSS conversion broke style on last checked out information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22351 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22351] SCSS conversion broke style on last checked out information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22351 Pierre-Marc Thibault changed: What|Removed |Added Attachment #85182|0 |1 is obsolete|| --- Comment #2 from Pierre-Marc Thibault --- Created attachment 85185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85185=edit Bug 22351: SCSS conversion broke style on last checked out information This patch makes a minor change to the staff client SCSS to correct an error which happened in the SCSS conversion. To test, apply the patch and regenerate the staff client CSS. Check out an item to a patron. The box showing information about the item you just checked out should be flush with the checkout form box. Signed-off-by: Pierre-Marc Thibault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #5 from Owen Leonard --- But wait there's more: Some content blocks in the OPAC affect the layout of the page in such a way that it's necessary to check for the existence of the content in the template. How should that be handled? Another plugin method for counting results? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22301] Paying fines is broken when using CurrencyFormat = FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22301 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22299] Typo in parameter of import_patrons.pl: preserve_extended_atributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22299 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22227] Make GET /cities staff only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should return if no patron is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21710] Fix typo atributes in some installer files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20544] Wrong comment in database documentation for items.itemnotes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20544 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #30 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13044] Deprecate old book drop mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 --- Comment #15 from Benjamin Daeuber --- (In reply to Benjamin Daeuber from comment #14) > > Perhaps I'm misunderstanding this, but doesn't the proposed functionality of > defaulting the date to the last day the library was open obviate the need > for any checkboxes? We could create a syspref to default check-in date to > that last day the library was open, then perhaps a permission that allows > staff to change (or not) this date on demand. Then no one needs to check > anything. I also think "remember date" should be the default functionality. Or perhaps if library's want to turn bookdrop mode on or off on demand, a single checkbox that sets the date to the library's last open date, and a permission that gives certain staff the ability to manipulate the calendar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121 Nick Clemens changed: What|Removed |Added Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22352] Items location not shown correctly in email sent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13044] Deprecate old book drop mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 --- Comment #14 from Benjamin Daeuber --- (In reply to George Williams (NEKLS) from comment #13) > I just discovered this bug Wednesday so I'm late to the party here. I have > the same concern as Lisette with specifying return dates, but after reading > all of the previous comments my recommendation incorporates some of the > discussion that's already been going on. My overriding concern is for > making these ideas as simple as possible for staff. > > Currently staff see "Forgive overdue charges" and "Bookdrop mode" in the set > of options on the right hand side of the check in screen. If the > "SpecifyReturnDate" system preference is set to "Allow" they see the > "Specify return date" options under the checkin barcode input box. If the > "SpecifyReturnDate" system preference is set to "Don't allow," they don't > see anything under the barcode input box. > > Also, currently, if the "Bookdrop mode" checkbox is checked, an "alert" > class is added to the barcode input box. > > My recommendation is that the checkbox options on the right hand side of the > screen be expanded to include "Forgive overdue charges," "Bookdrop mode," > and "Specify return date." And the ability to use "Forgive overdue charges" > and "Specify return date" should be tied to permissions. > > Then, under the checkin barcode input box, only have the "Specify return > date" options appear if "Bookdrop mode" or "Specify return date" were > selected. > > On selecting the "Bookdrop mode" checkbox, the "Specify return date" options > would display under the checking barcode box and would lock the date to the > last open date on the logged in library's calendar. Checking "Bookdrop > mode" would also automatically check the "Remember for next checkin" > checkbox and add the "alert" class to the barcode input box. > > On selecting the "Specify return date" checkbox, the "Specify return date" > options would display under the checking barcode box and staff would be able > to select valid dates in the past from the datepicker calendar. Checking > the "Specify return date" checkbox would no automatically check the > "Remember for next checkin" checkbox - but it would add an "alert" class to > the barcode input box. > > Currently we have "SpecifyReturnDate" turned off in our system and we ask > staff to use bookdrop mode because it's less complicated than specifying a > return date. Since we have 52 libraries all using the same shared Koha, and > since working in Koha is only a portion of staff's job responsibilities, > making Koha as easy to operate for staff is very important to us. When > training staff, it's a lot easier to train them on "When you check things > from the book-drop in every morning, check the 'Bookdrop mode' checkbox" > than it is to train them on "Enter the date as the last date your library > was open, then click the little checkbox next to that date that says > 'Remember for next check in.' I would be opposed to anything that makes > setting a due date for checking in book drop items more complicated than > checking one checkbox. Perhaps I'm misunderstanding this, but doesn't the proposed functionality of defaulting the date to the last day the library was open obviate the need for any checkboxes? We could create a syspref to default check-in date to that last day the library was open, then perhaps a permission that allows staff to change (or not) this date on demand. Then no one needs to check anything. I also think "remember date" should be the default functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21335] Remove redundant includes of right-to-left.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Owen Leonard changed: What|Removed |Added Attachment #84947|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 85184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85184=edit Bug 21335: Remove redundant includes of right-to-left.css Fixes redundant includes of the right-to-left.css file. There is no need to include it in the .tt files as it's part of the doc-head-close.inc. Note: Make sure your *BaseURL preferences are correctly set as this will make the switching between languages work correctly and throw you back to the start page otherwise every time you switch Test: - Install an RTL language like Arabic (ar-Arab) - Test various pages with English and RTL language: - Authorities home page - Adding a new bibliographic record - Adding a new item or editing items - Advanced cataloguing (Rancor) editor - Labels start page - OPAC detail page - Verify display is correct and right-to-left.css is available Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21335] Remove redundant includes of right-to-left.css
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Niamh changed: What|Removed |Added CC||niamh.walker-headon@it-tall ||aght.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18625] Update borrower last seen from SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22352] New: Items location not shown correctly in email sent lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352 Bug ID: 22352 Summary: Items location not shown correctly in email sent lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: alexandre.bre...@ccsr.qc.ca QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Target Milestone: --- Created attachment 85183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85183=edit no home library The lists sent by mail doesn’t show correctly the home library of items. The mail shows the current location and that’s all. Rather than this, the mail shows an authorized value. The home library isn’t shown which is useful for the students to guide them where the books are. 1) Go to lists 2) Choose a list and send it at one of your emails and close the window 3) In the sent mail, watch the infos below the “Item” mention, they are wrong (see picture underlined in red) note that the home library isn't following the current location of the book. We have the authorized value of the item shown there. Best regards, Alexandre -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22332] Limit to currently available items in home library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- This would be very helpful! Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22327] Circulation Rules simplification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22327 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22305] Add syspref to allow ILL to be hidden in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22305 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20461] New subscription form: "Item type" and "item type for older issues" fields are ignored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20461 --- Comment #15 from Victor Grousset/tuxayo --- Just to be sure, if at the creation of the subscription, the previousitemtype is forgotten. Then invalid item will still be created right? In that case (I'm not sure to have re-understood everything), is it relevant to: Do a follow-up bugzilla with a patch that prevent from changing an item's itype to "" or NULL. That it to say, if previousitemtype is invalid, don't use it. That would also deal will add the existing subscriptions that are still creating invalid items even after this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21683 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
--- Comment #1 from Nick Clemens ---
The issue appears to be from incorrectly assigned 'accountno' in
Koha::Account->pay
88 # We should remove accountno, it is no longer needed
89 my $last = $self->lines->search(
90 {},
91 { order_by => 'accountno' } )->next();
92 my $accountno = $last ? $last->accountno + 1 : 1;
The default order is ASC, so we end up assigning the lowest here
Then in C4::Circulation->_FixAccountForLostAndReturned
2387 # check for charge made for lost book
2388 my $accountlines = Koha::Account::Lines->search(
2389 {
2390 itemnumber => $itemnumber,
2391 accounttype => { -in => [ 'L', 'Rep', 'W' ] },
2392 },
2393 {
2394 order_by => { -desc => [ 'date', 'accountno' ] }
2395 }
2396 );
We order the lines by accountno to get the most recent, however, the numbers
are wrong so we don't get the most recent payment or write off.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22331] Lost items that are written off gives credit when returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22331 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21683] Remove accountlines.accountno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22331 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9181] Add patron messaging preference to Batch Patrons Modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 --- Comment #3 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6252] Patron import tool should let you set messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6252 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17350] Add option to delete data stored in saved_reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350 Danielle Elder changed: What|Removed |Added CC||danielle@bywatersolutions.c ||om --- Comment #2 from Danielle Elder --- I do get requests from libraries to "clean this up". It does interfere with usability. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
