[Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 --- Comment #9 from Katrin Fischer --- (In reply to Katrin Fischer from comment #8) > (In reply to Brian from comment #7) > > I just know that it is related to at least 3 other patches of a ticket that > > concerns a problem with the Validation for *MandatoryField and > > *UnwantedField sysprefs. For now I'm putting my foot in the door as to > > speak so I receive email updates when progress is made and hopefully the > > patch is eventually finished > > There are no other bugs linked to this, so you probably will not receive any > emails. This is at the moment a bit of a dead end. Filing a new separate omnibus bug for validation issues and link them there could be a good idea. I just wouldn't use this here as development seems to have stopped. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- (In reply to Brian from comment #7) > I just know that it is related to at least 3 other patches of a ticket that > concerns a problem with the Validation for *MandatoryField and > *UnwantedField sysprefs. For now I'm putting my foot in the door as to > speak so I receive email updates when progress is made and hopefully the > patch is eventually finished There are no other bugs linked to this, so you probably will not receive any emails. This is at the moment a bit of a dead end. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20307] Language overlay for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #6 from Katrin Fischer --- (In reply to Jonathan Druart from comment #5) > Should we continue on the same way of item types (translation from the UI), > or extract the strings from the DB then use the new Koha::I18 module > (translation from POs)? If I am not mistaken the translation from POs would always require to run jobs on the server, maintain your own po files... put them in the right place. I think we need something that can be done in the GUI to manage the translations. I am not sure if that could be achieved differently than what you have done for the itemtypes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22448] advance_notices.pl generates DUE(DGST) too early
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22448 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Due messages are sent the day the item is due = can be returned without without being late. I think this is the correct behavior, it warns you before things get overdue. (2019-03-04 sent on -05 would be overdue) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11969] Show patrons star rating on their reading history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Hayley Mapley changed: What|Removed |Added Attachment #85354|0 |1 is obsolete|| --- Comment #4 from Hayley Mapley --- Created attachment 86047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86047=edit Bug 11969: Show patrons star rating on their reading history This patch adds display of a user's ratings to their reading history in the OPAC. Also changed: Removed obsolete "border" attribute from the template. To test, apply the patch and rebuild the OPAC CSS. OpacStarRatings should be enabled. - Log in to the OPAC as a user with a reading history and titles in that history which have ratings. - Under the "your reading history" tab, your ratings should show under rated titles with the date of the rating. - Test also with OpacStarRatings disabled. Signed-off-by: Hayley Mapley Star ratings are displayed in Reading History with OpacStarRatings enabled, and are not displayed when OpacStarRatings is disabled, as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11969] Show patrons star rating on their reading history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Hayley Mapley changed: What|Removed |Added Attachment #85539|0 |1 is obsolete|| --- Comment #2 from Hayley Mapley --- Created attachment 86046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86046=edit Bug 15911: Use noEnterSubmit CSS class instead of prevent_submit.js This patch removes the use of a separate js file, prevent_submit.js, in favor of using a CSS class to trigger the same functionality in staff-global.js. To test, apply the patch and test the following pages to confirm that pressing "Enter" when the cursor is in any field in the main form does not submit the form. - In Acquisitions, add to a basket from a new (empty) record - In Acquisitions, receive an order line - In Serials, locate a subscription and open the "Edit serials" page from the "Serial collection" page. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429
--- Comment #11 from David Cook ---
(In reply to Christian Stelzenmüller from comment #9)
> > "Aha... it's the parentheses which are the problem. They're being
> > interpreted as
> > regex metacharacters and not literal values!"
>
> We noticed that there seems to be an infinite loop if the template has some
> or all entries with "0" in it (like in default when creating a new
> template). Could this be the same cause?
Sorry, I just realized that you were referring to the template rather than the
layout.
Yes, it would be a related problem, but a separate issue.
If 'label_width' is 0, then $self->{'width'} will be 0.
That means that this condition will be triggered:
if (($string_width + $text_attribs->{'llx'}) > $self->{'width'})
And because $self->{'width'} is 0, then the following condition would never
feasibly be triggered:
if (($string_width + $text_attribs->{'llx'}) < $self->{'width'})
And this condition is the only thing that can stop the infinite loop.
Really the line wrapping code looks like it would benefit from a re-write.
I'd suggest opening a new bug report.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22429] Infinite loop in patron card printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #10 from David Cook --- (In reply to Christian Stelzenmüller from comment #9) > > "Aha... it's the parentheses which are the problem. They're being > > interpreted as > > regex metacharacters and not literal values!" > > We noticed that there seems to be an infinite loop if the template has some > or all entries with "0" in it (like in default when creating a new > template). Could this be the same cause? I don't think it would be the exact same cause, but probably related. My guess would be that the other regular expression used for "trimming" the long line might have problems with the 0s. I could probably look at that later today. Infinite loops are very easy to encounter with this code because it only breaks the loops for some very specific positive conditions. There probably should be some kind of sanity check to prevent infinite loops, or a more mathematically precise loop... I have an urgent matter at hand but I'll keep this in mind to look at later today... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #6 from Joy Nelson --- In order to preserve the current functionality of the long overdue cronjob not following the 'calendar/closed days', we will need a new syspref in the Long Overdue area. DefaultLongOverdueCalendar: Use Calendar/Ignore Calendar when working out the period for setting items to long overdue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley changed: What|Removed |Added Attachment #85981|0 |1 is obsolete|| --- Comment #7 from Hayley Mapley --- Created attachment 86045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86045=edit Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #1 from Andrew --- Furthermore "closed days to be taken into account" on ExcludeHolidaysFromMaxPickUpDelay is very much open to two contradictory readings. Does taking closed days "into account" mean we are *counting* those days? Or does it mean we *are* using the calendar and therefore *not counting* those days? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21948] Clean up style of item detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8775] Add collection code to lost report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Katrin Fischer --- Hi Bin, please make sure to change the status to "Signed Off" when signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should return if no patron is passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #22 from Lucas Gass --- cant cleanly apply this to 18.05.x. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley changed: What|Removed |Added Attachment #83467|0 |1 is obsolete|| --- Comment #30 from Hayley Mapley --- Created attachment 86044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86044=edit Bug 17140: fix rounding errors when paying fines Whenever a fine (accountlines in DB) has a precision longer than two floating points, it becomes very hard for a user to clear it. Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen. But entering any of those value in Pay Fine will not clear it. The user has no way to know the exact value to enter. This fix makes sure that the intent of the user is met, by matching the EXACT needed sum when the difference is less than 0.01. TEST 1) Create a 1.035 fine - Go to a Patron screen - Fines tab on the left - Create manual invoice 2) go to Pay fines, click Pay amount on bottom left. 3) It will show 1.03 as Total, and as Collect from patron. Click confirm. 4) An error message will appear. 5) Apply patch, do again. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22249] Error when submitting Mana comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22222] Mana subscription search always returns all results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 Josef Moravec changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|alex.arn...@biblibre.com|josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22222] Mana subscription search always returns all results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2 --- Comment #1 from Josef Moravec --- Created attachment 86043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86043=edit Bug 2: Don't send empty params to mana service Test plan: 0) Do not apply the patch 1) Go to serials > Search on Mana 2) Insert some value into the form 3) Submit -> you get many (3000+) results 4) Apply the patch and restart_all 5) Repeat, now, you get only the subscription matching your query -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 --- Comment #6 from Katrin Fischer --- This could also be seen as a regression to previous versions (bug fix vs. enh) - see first comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Liz Rea changed: What|Removed |Added Attachment #85367|0 |1 is obsolete|| --- Comment #7 from Liz Rea --- Created attachment 86033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86033=edit Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Attachment #86033|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #1 from Josef Moravec --- Created attachment 86034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86034=edit Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #2 from Josef Moravec --- Created attachment 86035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86035=edit Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Josef Moravec changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #3 from Josef Moravec --- Created attachment 86036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86036=edit Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #8 from Liz Rea --- Created attachment 86037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86037=edit Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Hayley Mapley changed: What|Removed |Added Attachment #86039|0 |1 is obsolete|| --- Comment #11 from Hayley Mapley --- Created attachment 86042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86042=edit Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22436] add move or copy control field from or to subfield in MARC modification templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22436 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens changed: What|Removed |Added Attachment #86025|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 86041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86041=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 --- Comment #14 from Nick Clemens --- Created attachment 86032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86032=edit Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Liz Rea changed: What|Removed |Added Attachment #86037|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #10 from Liz Rea --- Created attachment 86039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86039=edit Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #9 from Liz Rea --- Created attachment 86038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86038=edit Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
--- Comment #1 from Jonathan Druart
---
Created attachment 86040
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86040=edit
Bug 22453: Make TestBuilder generates dates taking into account the timezone
I have no idea why this only appears today but TestBuilder generates dates
using DateTime->now,
which does not take into account the timezone.
It has been highlights by a failing test today on U18.
Why today whereas this patch was pushed few weeks ago?
Why U18 and not D9?
The output of the test is:
koha_1 | # Failed test 'With BorrowerLogs and
TrackLastPatronActivity we should not spam the logs'
koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421.
koha_1 | # got: '2'
koha_1 | # expected: '1'
koha_1 | # Looks like you failed 1 test of 4.
koha_1 |
koha_1 | # Failed test 'BorrowersLog tests'
koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422.
koha_1 | # Looks like you failed 1 test of 33.
koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t
Actually there are 2 logs, one for the cardnumber that is expected, and on for
updated_on:
"updated_on" : {
"after" : "2019-03-04 21:10:00",
"before" : "2019-03-04 18:10:00"
}
Apart from the fact that we may want to remove this updated_on field from
MODIFY,
the before/after dates differ from 3 hours.
Here it's currently 18:10 and in UTC-3
To prevent such behaviors in tests (create stuffs in the future...), we should
use our Koha::DateUtils::dt_from_string method that takes care of the timezone
used in other places of Koha.
Test plan:
prove t/db_dependent/Koha/Patrons.t
May fail without this patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22453] New: TestBuilder should generate now() using the current timezone
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
Bug ID: 22453
Summary: TestBuilder should generate now() using the current
timezone
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Test Suite
Assignee: jonathan.dru...@bugs.koha-community.org
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Target Milestone: ---
I have no idea why this only appears today but TestBuilder generates dates
using DateTime->now, which does not take into account the timezone.
It has been highlights by a failing test today on U18.
Why today whereas this patch was pushed few weeks ago?
Why U18 and not D9?
The output of the test is:
koha_1 | # Failed test 'With BorrowerLogs and
TrackLastPatronActivity we should not spam the logs'
koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421.
koha_1 | # got: '2'
koha_1 | # expected: '1'
koha_1 | # Looks like you failed 1 test of 4.
koha_1 |
koha_1 | # Failed test 'BorrowersLog tests'
koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422.
koha_1 | # Looks like you failed 1 test of 33.
koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t
Actually there are 2 logs, one for the cardnumber that is expected, and on for
updated_on:
"updated_on" : {
"after" : "2019-03-04 21:10:00",
"before" : "2019-03-04 18:10:00"
}
Apart from the fact that we may want to remove this updated_on field from
MODIFY, the before/after dates differ from 3 hours.
Here it's currently 18:10 and in UTC-3
To prevent such behaviors in tests (create stuffs in the future...), we should
use our Koha::DateUtils::dt_from_string method that takes care of the timezone
used in other places of Koha.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #29 from Hayley Mapley --- (In reply to Blou from comment #28) > Hi Hayley, > Have you tried applying only 83467 (the last one), which is separated from > the others (see my previous comments)? Or maybe its solution is not what > you're looking for... Hi Blou, My bad! I missed your comment. Will try to sign off today. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 --- Comment #2 from Jonathan Druart --- Created attachment 86031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86031=edit Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 --- Comment #1 from Jonathan Druart --- Created attachment 86030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86030=edit Bug 22219: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22452] 'Caracters' is typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 --- Comment #1 from Josef Moravec --- Created attachment 86029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86029=edit Bug 22452: Fix typo caracters -> characters There is typo in modal where you can add a comment to mana Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new commment (max 35 characters)' 3) The same in mana search resultss and in reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22452] 'Caracters' is typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22452] 'Caracters' is typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec changed: What|Removed |Added Assignee|oleon...@myacpl.org |josef.mora...@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results in column Location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643 --- Comment #7 from Jonathan Druart --- I do not recreate: 1. Setting NOT_LOAN=1 to "X" MariaDB [koha_kohadev]> select * from authorised_values where category="NOT_LOAN"; ++--+--+--+--+--+ | id | category | authorised_value | lib | lib_opac | imageurl | ++--+--+--+--+--+ | 32 | NOT_LOAN | -1 | Ordered | NULL | NULL | | 33 | NOT_LOAN | 1| X| NULL | | | 34 | NOT_LOAN | 2| Staff Collection | NULL | NULL | ++--+--+--+--+--+ 3 rows in set (0.00 sec) 2. Setting Computer file as not for loan MariaDB [koha_kohadev]> select notforloan from itemtypes where itemtype="CF"; ++ | notforloan | ++ | 1 | ++ 3. Set this itemtype for a given item: MariaDB [koha_kohadev]> select itype from items where biblionumber=4; +---+ | itype | +---+ | CF| | BK| | BK| | BK| +---+ I see: https://snag.gy/YojeUb.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22452] New: 'Caracters' is typo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Bug ID: 22452 Summary: 'Caracters' is typo Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org Target Milestone: --- in mana related templates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Josef Moravec changed: What|Removed |Added Attachment #84533|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 86028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86028=edit Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #7 from Nick Clemens --- Dependencies pushed to master, yet: error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 21721: Use Koha::Account->add_debit in AddRenewal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22442] Item search CSV export broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #19 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #65 from Cori Lynn Arnold --- Can't search the import batch I just created and added two records to. Steps to reproduce: 1. Create a new import batch (Settings->Import batches...) called "New Batch" 2. Make "New Batch" searchable and a save target https://paste.pics/300ea164128d55e87c65652f1abd6223 3. Create 2 records. One with 001 as faw00012345, the other with 001 as faw00054321 ; 245 as "Penultimate Test" for one, "Antonomasia Test" for the other. Save both to "New Batch" import batch. 4. Search using the left hand search area for "Penultimate Test" in keywords Expected: "New Batch" is listed as a searchable target. Result: "New Batch" is not listed as a searchable target. https://paste.pics/33d5257511e53ee1d46722c1b1a8cece -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025 --- Comment #4 from Jonathan Druart --- I would expect the warnings to appear if you are doing an update, not an insert. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025 --- Comment #3 from Jonathan Druart --- I do not recreate against master, can you share an example file? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390 --- Comment #6 from Jonathan Druart --- Created attachment 86027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86027=edit Bug 22390: Never copy items if original order has been created from a subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22442] Item search CSV export broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22442] Item search CSV export broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Josef Moravec changed: What|Removed |Added Attachment #86021|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 86026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86026=edit Bug 22442: (bug 13618 follow-up) Fix item search CSV export We must not filter assignements statements. Test plan: Export item search result as CSV Without this patch the biblio and biblioitem values are not displayed. With this patch applied everything is displayed correctly Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens changed: What|Removed |Added Attachment #85396|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 86025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86025=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens changed: What|Removed |Added Attachment #68675|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens changed: What|Removed |Added Attachment #67817|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Attachment #85968|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart changed: What|Removed |Added Assignee|hayleymap...@catalyst.net.n |koha-b...@lists.koha-commun |z |ity.org Status|Pushed to Master|ASSIGNED --- Comment #44 from Jonathan Druart --- Resetting to New. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart changed: What|Removed |Added Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Pushed for QA --- Comment #15 from Jonathan Druart --- Opened bug 22451 and switched back to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22451] New: Asset plugin is using the version from the DB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Bug ID: 22451 Summary: Asset plugin is using the version from the DB Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Target Milestone: --- Should not be retrieved with Koha::Version? See bug 20658 comment 13. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22451 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22404] Some labels in subscription add form has wrong parameter "for"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22404 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #43 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Nick Clemens changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- Please rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22360] On order information missing in OPAC normal display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #13 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22370] OPAC users should not be allowed to view staff news items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22370 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #94 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > Sorry, Jonathan, I don't understand yet. Maybe we can take a look at it > together sometime? Scratch comment 2, we could replace it instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17496] install-CPAN.pl documentation/removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Leaving this open for a week in case any one cares to comment, then will push -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 --- Comment #4 from Jonathan Druart --- Created attachment 86024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86024=edit Bug 19046: Make seach pulldown to retain index selection This patch also fixes add the term in the search input Test plan: Enable IntranetCatalogSearchPulldown Search for a term using the search input in the header (simple search) Re-do selecting different indices The selection must retain on the search result page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Nick Clemens changed: What|Removed |Added Text to go in the||This patchset makes some release notes||changes to Elasticsearch ||mappings in the database. ||The changes alter existing ||indices and are intended to ||fix issues with the current ||mappings, however, if you ||have done customization of ||mappings you may want to ||back them up before ||upgrading. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Liz Rea changed: What|Removed |Added Attachment #86015|0 |1 is obsolete|| Attachment #86016|0 |1 is obsolete|| --- Comment #23 from Liz Rea --- Created attachment 86022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86022=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #24 from Liz Rea --- Created attachment 86023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86023=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #93 from Nick Clemens --- (In reply to Nick Clemens from comment #92) Talked with Ere, he verified these make sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Jonathan Druart changed: What|Removed |Added Status|REOPENED|NEW --- Comment #6 from Jonathan Druart --- Indeed, you are right. The description of bug 16276 says: """ We would like to automate the delation of expired patrons to comply to french laws regarding privacy. But we don't want to delate an expired patron which is still using the OPAC for bibliographical purpose, like managing lists. We would like to be able to say when the patron logged himself for the last time to permit this. """ It could be renamed last_login to avoid ambiguity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added Blocks||22442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 [Bug 22442] Item search CSV export broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22442] Item search CSV export broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Jonathan Druart changed: What|Removed |Added Depends on||13618 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22442] Item search CSV export broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 --- Comment #1 from Jonathan Druart --- Created attachment 86021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86021=edit Bug 22442: (bug 13618 follow-up) Fix item search CSV export We must not filter assignements statements. Test plan: Export item search result as CSV Without this patch the biblio and biblioitem values are not displayed. With this patch applied everything is displayed correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22442] Item search CSV export broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #14 from Liz Rea --- I've got a bad git email address hiding out somewhere in my git config, so sorry if those look like my old email address at Catalyst. I'm still signing off and if you're inclined you can change them to wizzy...@gmail.com. I don't want to clutter the bug by fixing it but I'll fix it before I do my next one. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
