[Koha-bugs] [Bug 22702] circulation note on patron page should allow for HTML tags

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22702] circulation note on patron page should allow for HTML tags

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702

--- Comment #1 from Lucas Gass  ---
Created attachment 87940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87940=edit
Attachment to Bug 22702 - circulation note on patron page should allow for HTML
tags

Bug 22702: circulation note on patron page should allow for HTML tags

 TEST PLAN: 
 1. add a circulation note to a patron account that includes some HTML tags
like: TEST
 2. visit the check out page and notice the tags display literally
 3. visit the details page and notice the tags display literally 
 4. apply patch 
 5. look again at the check out and details pages and notice the notes
rendering HTML

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22702] circulation note on patron page should allow for HTML tags

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702

Lucas Gass  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22702] New: circulation note on patron page should allow for HTML tags

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702

Bug ID: 22702
   Summary: circulation note on patron page should allow for HTML
tags
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Some libraries like to include links and other HTML in the circulation note.
This currently uses the html filter and should be switched to $raw. This should
not be problematic since only staff can do this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||Delete from 19.05 release
  release notes||notes, has been reverted!
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22650] Can place multiple item level holds on a single item

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22615] Add /ill_backends endpoint

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Bin  changed:

   What|Removed |Added

 CC||bin@inlibro.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22657] Remove JavaScript from OPAC suggestion validation of required fields

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22657

Bin  changed:

   What|Removed |Added

 CC||bin@inlibro.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22683] Make issue and old_issue prefetchable from Koha::Account::Line

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22683

Bin  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bin@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22657] Remove JavaScript from OPAC suggestion validation of required fields

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22657

Bin  changed:

   What|Removed |Added

  Attachment #87526|0   |1
is obsolete||

--- Comment #2 from Bin  ---
Created attachment 87939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87939=edit
Bug 22657: Remove JavaScript from OPAC suggestion validation of required fields

This patch modifies the OPAC suggestion form so that it doesn't require
JavaScript for form validation. This change doesn't alter the behavior
of the form for users but does fit with the general goal of progressive
enhancement for the OPAC.

The patch adds "required" labels to required fields to better identify
required fields.

To test, apply the patch and make sure there are required fields
specified in the OPACSuggestionMandatoryFields system preference.

 - Log in to the OPAC and go to Your purchase suggestions -> New
   purchase suggestion.
 - Verify that the fields specified in OPACSuggestionMandatoryFields are
   highlighted and marked "required."
 - Verify that you can't submit the form without filling out these
   fields.

Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Bin  changed:

   What|Removed |Added

  Attachment #87932|0   |1
is obsolete||

--- Comment #2 from Bin  ---
Created attachment 87938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87938=edit
Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl

This patch removes many DB queries and uses state-of-the-art Koha code
to accomplish the same things it did before.

To test:
- Apply this patch
- Open opac-ISBDdetail.pl for a known record
=> SUCCESS: No behaviour change.
- Sign off :-D

Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695

Bin  changed:

   What|Removed |Added

  Attachment #87930|0   |1
is obsolete||

--- Comment #3 from Bin  ---
Created attachment 87937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87937=edit
Bug 22695: Remove non-XSLT search results view from the staff client

This patch removes the option to select non-XSLT search results in the
staff client. The patch removes the markup from the template, updates
the system preference options, and modifies Search.pm so that OPAC and
staff client results XSLT functions are not tied together.

To test, apply the patch and set the XSLTResultsDisplay to a blank
value. Run the database update. The value of the XSLTResultsDisplay
system preference should now be "default."

Perform a catalog search in the staff client. The results should be
shown using the XSLT view.

Test that OPAC search results respect the OPACXSLTResultsDisplay
preference when enabled and disabled.

Signed-off-by: Pierre-Marc Thibault 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22652] Editing Course reserves is broken

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22652

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #87763|0   |1
is obsolete||

--- Comment #8 from Mikaël Olangcay Brisebois 
 ---
Created attachment 87936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87936=edit
Bug 22652 - Editing Course reserves is broken

Signed-off-by: Liz Rea 
Signed-off-by: Mikaël Olangcay Brisebois


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21676] Advanced editor - Rancor - complains on empty line at end

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21676

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22701] Make items prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|tomasco...@gmail.com|koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22701] Make items prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22407
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
[Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than
searching for the object
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||22701


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701
[Bug 22701] Make items prefetchable from Koha::Biblio
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22701] New: Make items prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22701

Bug ID: 22701
   Summary: Make items prefetchable from Koha::Biblio
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

José-Mario Monteiro-Santos  changed:

   What|Removed |Added

 CC||jose-mario.monteiro-santos@
   ||inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

José-Mario Monteiro-Santos  changed:

   What|Removed |Added

  Attachment #87422|0   |1
is obsolete||

--- Comment #40 from José-Mario Monteiro-Santos 
 ---
Created attachment 87934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87934=edit
Bug 20959: (QA follow-up) Add missing $KohaDates filter

This patch adds a missing $KohaDates filter to the display of the book
drop mode "effective checkin" date.

To test, apply the patch and go to Circulation -> Check in.

Check the "Book drop mode" box. The message which displays should show a
correctly-formatted effective checkin date.

Signed-off-by: Jose-Mario Monteiro-Santos


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #87878|0   |1
is obsolete||

--- Comment #5 from Pierre-Marc Thibault  ---
Created attachment 87935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87935=edit
Bug 18011: Enrollment period date on patron category can be set in the past
without any error/warning messages

This patch modifies the patron category edit form so that the enrollment
period datepicker widget cannot be used to select a date in the past.

The  element had a "datepicker" class, which triggers a default
datepicker configuration. This was overriding the configuration in the
page-specific JavaScript file.

To test, apply the patch and go to Administration -> Patron categories.

Click the "Enrollment period -> Until date" field and verify that dates
before today are disabled.

Signed-off-by: Pierre-Marc Thibault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959

José-Mario Monteiro-Santos  changed:

   What|Removed |Added

  Attachment #86729|0   |1
is obsolete||

--- Comment #39 from José-Mario Monteiro-Santos 
 ---
Created attachment 87933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87933=edit
Bug 20959: Style checkin form more like the checkout form, with collapsed
settings panel

This patch modifies the structure of the checkin form so that settings
(Specify return date, book drop mode, forgive overdue charges) are in a
collapsed panel when inactive. The style of the barcode field and the
mode notification messages has been changed to reduce the vertical
motion of the form when selecting options.

Some class names have been changed in circulation.tt and circulation.js
to make them appropriate for use on both forms.

To test, apply the patch and clear your browser cache if necessary.

 - View the checkin page. The "checkin settings" panel should be
   collapsed by default.
 - Confirm that the settings panel collapses and expands as it should.
 - Confirm that selecting "Forgive overdue charges" or "Book drop mode"
   trigger the display of the correct message and that the style of the
   barcode field is changed.
 - Confirm that after submitting a barcode for check-in, the
   settings panel stays open and your selected settings are still
   selected.
 - Test with CircSidebar enabled and disabled.

Signed-off-by: Jose-Mario Monteiro-Santos


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 87932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87932=edit
Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl

This patch removes many DB queries and uses state-of-the-art Koha code
to accomplish the same things it did before.

To test:
- Apply this patch
- Open opac-ISBDdetail.pl for a known record
=> SUCCESS: No behaviour change.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||k...@bywatersolutions.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #87928|0   |1
is obsolete||

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 87931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87931=edit
Bug 22700: Make biblio_metadata prefetchable from Koha::Biblio

This patch makes $biblio->metadata be prefetchable as the Coding
guidelines require.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: No regressions!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #87910|0   |1
is obsolete||

--- Comment #2 from Pierre-Marc Thibault  ---
Created attachment 87930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87930=edit
Bug 22695: Remove non-XSLT search results view from the staff client

This patch removes the option to select non-XSLT search results in the
staff client. The patch removes the markup from the template, updates
the system preference options, and modifies Search.pm so that OPAC and
staff client results XSLT functions are not tied together.

To test, apply the patch and set the XSLTResultsDisplay to a blank
value. Run the database update. The value of the XSLTResultsDisplay
system preference should now be "default."

Perform a catalog search in the staff client. The results should be
shown using the XSLT view.

Test that OPAC search results respect the OPACXSLTResultsDisplay
preference when enabled and disabled.

Signed-off-by: Pierre-Marc Thibault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||pierre-marc.thibault@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #149 from David Gustafsson  ---
Created attachment 87929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87929=edit
Bug 14957: Put database updates in perl script

Also add schema changes to kohastructure.sql and syspref to sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18205] API interface to Koha::Logger

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205

--- Comment #27 from Lari Taskula  ---
(In reply to Martin Renvoize from comment #26)
> Lari, can you state exactly what it is about MojoX::Log::Log4Perl that you
> wish to use within the Mojo layer of Koha?

Hi. Thanks for taking a look! The reason for adding this module was to enable
Mojo::Log logging with our log4perl configurations so that our log4perl-logging
works for other Mojolicious plugins such as Mojolicious::Plugin::OpenAPI. I
don't think the standard Koha::Logger was able to handle this alone with the
way you proposed:

> $app->log(Koha::Logger->get)

If you can provide a simple alternative solution to Koha::Logger to achieve
this functionality, I'm okay with not including this dependency. Unfortunately
I personally cannot invest more work into this feature as I don't work as a
Koha developer as of now.

Your proposed way is of course better and hopefully you can make it work :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Simplify visibility |Simplify visibility logic
   |opac-ISBDdetail.pl  |in opac-ISBDdetail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22696] Simplify visibility opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||22700


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700
[Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22696


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696
[Bug 22696] Simplify visibility logic in opac-ISBDdetail.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 87928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87928=edit
Bug 22700: Make biblio_metadata prefetchable from Koha::Biblio

This patch makes $biblio->metadata be prefetchable as the Coding
guidelines require.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: No regressions!
- Sign off :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||22700


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700
[Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22700] New: Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

Bug ID: 22700
   Summary: Make biblio_metadata prefetchable from Koha::Biblio
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22407


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
[Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than
searching for the object
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22698] Fix incorrect button classes

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22698

--- Comment #1 from Owen Leonard  ---
Created attachment 87927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87927=edit
Bug 22698: Fix incorrect button classes

This patch builds on Bug 22023 in making further corrections to toolbar
button classes.

To test, apply the patch and view the following pages to confirm that
toolbar buttons are consistent:

- Acquisitions -> Vendor -> View basket.
- Administration -> Additional fields -> Select a table.
- Administration -> Audio alerts.
- Catalog -> Advanced search -> More/fewer options link
- Cataloging -> Edit record -> Advanced editor -> Advanced search.
- Cataloging -> Edit record -> Advanced editor -> Macros.
- Cataloging -> Edit record -> MARC21 008 value builder.
- Cataloging -> Search results.
- Circulation -> Checkout notes.
- Circulation: Sticky due date clear button, view restrictions, override
   restrictions temporarily, add message, delete message
- Course reserves: Toolbar buttons on that page and the course reserve
   detail page.
- ILL requests -> View ILL requests. The "New ILL request" and "List
   requests" button.
- Lists and Lists -> View list.
- Patrons -> Search -> Merge patrons.
- Patrons -> View patron -> "Edit" button on patron image (patronimages
   must be enabled).
- Patrons -> View patron -> "More" menu -> Manage API keys.
- Patrons -> View patron -> "More" menu -> Set permissions.
- Patrons -> View patron -> Delete circulation message link.
- Patrons -> View patron -> Edit patron.
- Patrons -> View patron -> Housebound.
- Reports -> Dictionary.
- Serials -> Numbering patterns.
- Serials -> Subscription -> Receive.
- Tools -> Labels -> Manage -> Label batches: Export selected.
- Tools -> Patron card creator -> Manage -> Card batches -> Edit batch.
- Tools -> Patron card creator. The "New" and "Manage" buttons.
- Tools -> Patron clubs.
- Tools -> Quote editor -> Import quotes.
- Tools -> Rotating collections. Toolbar buttons on that page and the
   collection view page.
- Tools -> Tags.
- Tools -> Upload local cover image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22698] Fix incorrect button classes

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22698

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22139] Fields of ACCTDETAILS not working properly

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139

--- Comment #5 from Lisette Scheer  ---
We are also having this issue. 
We are using TT syntax in this notice and it was working yesterday but not
today for borrower information. It does work still for branch information.
We updated to 18.11.03 overnight. 
Lisette

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #7 from axel  ---
Created attachment 87926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87926=edit
adding of the rescearch of merge in the log viewer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22699] New: Remove documentation on Keywords to MARC mapping

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22699

Bug ID: 22699
   Summary: Remove documentation on Keywords to MARC mapping
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 11529
  Target Milestone: ---

Once bug 11529 is pushed, we'll also need to update the manual and remove any
reference to that functionality.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
[Bug 11529] Add subtitle, medium and part fields to biblio table
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22699] Remove documentation on Keywords to MARC mapping

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22699

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |BLOCKED

--- Comment #1 from Katrin Fischer  ---
Blocked until 11529 is pushed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||22699


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22699
[Bug 22699] Remove documentation on Keywords to MARC mapping
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023

Owen Leonard  changed:

   What|Removed |Added

 Blocks||22698


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22698
[Bug 22698] Fix incorrect button classes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22698] New: Fix incorrect button classes

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22698

Bug ID: 22698
   Summary: Fix incorrect button classes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 22023
  Target Milestone: ---

Bug 22023 made a change to our Bootstrap CSS which required an update to the
standard set of classes we use for toolbar buttons. Many buttons were updated
by that patch, but some still remain to be fixed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023
[Bug 22023] Further improve responsive layout handling of staff client menu bar
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #87151|0   |1
is obsolete||

--- Comment #129 from Nick Clemens  ---
Created attachment 87925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87925=edit
Bug 14576: (QA follow-up) Tidy up feature documentation

To test:
Apply this patch with all of the others
run the updatedatabase, it should work
install a new Koha, this pref should be installed and look fine in the
interface.
Check the syspref, make sure the text looks ok and makes sense.

Bonus points:
for checking to make sure PROC: _PERM_ appears in the new
pereference if InProcessingToShelvingCart was set
for checking to make sure _ALL_: CART appears in the new preferenec if
ReturnToShelvingCart was previously set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala  changed:

   What|Removed |Added

  Text to go in the||Sponsored by the National
  release notes||Library of Finland.
   ||Keywords to MARC mapping
   ||functionality has been
   ||replaced with additional
   ||Koha fields in the
   ||bibliographic framework.
   ||
   ||The keyword mapping only
   ||offered a single field,
   ||subtitle, and the
   ||information was always
   ||retrieved from the MARC
   ||record, which made it
   ||relatively slow. The
   ||subtitle and other relevant
   ||fields are now available as
   ||normal Koha fields:
   ||
   ||-
   ||biblio.medium - Medium
   ||information (MARC 21: 245h,
   ||UNIMARC: 200b)
   ||-
   ||biblio.subtitle - Subtitle
   ||(MARC 21: 245b, UNIMARC:
   ||200e)
   ||- biblio.part_number
   ||- Part number (MARC 21:
   ||245n, UNIMARC: 200h)
   ||-
   ||biblio.part_name - Part
   ||name (MARC 21: 245p,
   ||UNIMARC: 200i)
   ||
   ||The
   ||subfields in the default
   ||framework are automatically
   ||updated to include these
   ||new fields unless they are
   ||already mapped to another
   ||Koha field.
   ||
   ||Note that
   ||misc/batchRebuildBiblioTabl
   ||es.pl needs to be run to
   ||populate the fields in the
   ||database, and it will take
   ||some time for larger
   ||databases.
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22697] Reindent catalogue/result.tt

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22697] Reindent catalogue/result.tt

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697

--- Comment #1 from Owen Leonard  ---
Created attachment 87924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87924=edit
Bug 22697: Reindent catalogue/result.tt

This patch reindents the template for staff client catalogue search
results. The only non-whitespace changes are comments to help identify
closing tags and template directives.

To test, apply the patch and perform a catalog search in the staff
client. The results should look correct.

The diff using the '-w' flag to ignore whitespace should
highlight only moved lines and added comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22697] New: Reindent catalogue/result.tt

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697

Bug ID: 22697
   Summary: Reindent catalogue/result.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 22695
  Target Milestone: ---

The template for catalog search results in the staff client would be much more
readable if it were indented consistently.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695
[Bug 22695] Remove non-XSLT search results view from the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695

Owen Leonard  changed:

   What|Removed |Added

 Blocks||22697


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697
[Bug 22697] Reindent catalogue/result.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22683] Make issue and old_issue prefetchable from Koha::Account::Line

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22683

--- Comment #2 from Tomás Cohen Arazi  ---
Comment on attachment 87751
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87751
Bug 22683: Allow prefetch with Koha::Account::Line->checkouts

>+__PACKAGE__->belongs_to(
>+  "issue",
>+  "Koha::Schema::Result::Issue",
>+  { "foriegn.issue_id" => "self.issue_id" },

"foriegn"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #92 from Ere Maijala  ---
(In reply to Katrin Fischer from comment #82)
> Bad (blocker):
> - git grep bibliosubtitle.subtitle still shows several occurrences to be
> fixed

Fixed.

> - Can you explain the use of $raw on the subtitle in
> koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt and
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt

I suppose it's because of the html2text filter, but I just kept what there
already was. 

> Non-blocker notes:
> - Need to leave a note on Taiga/bug here that the Koha-to-keyword content
> needs to be removed from the manual

Can I access Taiga somewhere or is it better to just file a bug?

> - Will need extensive release notes notes.

I'll try to come up with something.

> Pre-existing:
> - GetHoldsQueueItems: biblioitems.publicationsyear is listed twice in the
> SQL query

Fixed here.

> - Why so many occurrences of [% subtitl %]?

I've kept as much of the code intact as possible. Since the old code used that,
I've kept it intact. Also, we concatenate multiple values in the database with
' | ', so splitting and handling them one by one allows one to customize the
display more. 

> - The ',' between subtitles will in opac-results.pl, opac-showreviews-rss.tt
> will look not work for MARC21 libraries using proper ISBD punctuation in
> their records.

I agree, but I believe that hasn't changed here. It could be handled as a
separate issue.

> II Questions:
> 
> - In the database update we don't check if libraries had already mapped the
> fields to other database columns. The remapping might leave data and reports
> orphaned. Should we check for this and at least print a warning?

Good point, check added.

> - What is our recommendation on how to populate the new db fields? Can we
> imagine something that works faster than touch_all_biblios.pl? SQL updates?  
> What's the difference between touch_all_biblios.pl and
> batchRebuildBiblioTables.pl?

batchRebuildBiblioTables.pl is recommended. touch_all_biblios.pl also indexes
all changes, which isn't necessary here.

> - Why was the -t test option removed from batchRebuildBiblioTables.pl?

It served no purpose. There was no useful output or anything that I could think
of to use it for. 

> - AFAIK UNIMARC doesn't have ISBD punctuation in the records. Do we need to
> introduce a separator for UNIMARC between title and subtitle?

That'd probably be nice, but I believe that could be done in a separate bug.
Since most of the existing templates didn't have that, I don't think it's
vital. Also, I believe the code in opac-detail could be improved if comma is
not the best separator.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87778|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #6 from axel  ---
Created attachment 87923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87923=edit
Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #5 from axel  ---
Created attachment 87922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87922=edit
Bug 22632: Add logging of merged patrons

without this patch , when patrons are merged , you can't see the merge in the
log viewer.

To test:
-Apply the patch
-Make sure you have "BorrowersLog" on in you System Preference
-Search patrons
-Check two ore more patrons
-Merge selected patrons
-Merge patrons
-Go to log viewer
- Make sure there is the line with the action : "Merge"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

axel  changed:

   What|Removed |Added

  Attachment #87921|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #4 from axel  ---
Created attachment 87921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87921=edit
Unit Testing of patch 22632

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #87920|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
I think something went wrong here with the patch attached. Obsoleting the last
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22632] Add logging of merged patrons

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632

--- Comment #2 from axel  ---
Created attachment 87920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87920=edit
Bug 21003: Made Edit keywords more consistent in add_items-step2.tt

When adding a course reserve with a barcode that already exists, the
title, breadcrumbs, and legend of the form all specify that the user is
editing, and not adding, the book.

Test plan:
Same as comment 1

Signed-off-by: Devinim 
Signed-off-by: Bin Wen 

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #89 from Ere Maijala  ---
Created attachment 87917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87917=edit
Bgu 11529: Update kohafield in default framework only if not already set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #91 from Ere Maijala  ---
Created attachment 87919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87919=edit
Bug 11529: Remove duplicate column name from select query

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala  changed:

   What|Removed |Added

  Attachment #87261|0   |1
is obsolete||

--- Comment #88 from Ere Maijala  ---
Created attachment 87916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87916=edit
Bug 11529: DBIx schema changes

Updates to Biblio schema and removal of FieldMapping schema.

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #90 from Ere Maijala  ---
Created attachment 87918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87918=edit
Bug 11529: Replace bibliosubtitle with biblio in all framework sql's.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala  changed:

   What|Removed |Added

  Attachment #87260|0   |1
is obsolete||

--- Comment #87 from Ere Maijala  ---
Created attachment 87915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87915=edit
Bug 11529: Remove field mapping table and admin page

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala  changed:

   What|Removed |Added

  Attachment #87258|0   |1
is obsolete||

--- Comment #85 from Ere Maijala  ---
Created attachment 87913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87913=edit
Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala  changed:

   What|Removed |Added

  Attachment #87259|0   |1
is obsolete||

--- Comment #86 from Ere Maijala  ---
Created attachment 87914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87914=edit
Bug 11529: Clean up subtitle usage

Unify and clean up subtitle usage so that it's always used as a simple array
and not the old hash structure.

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala  changed:

   What|Removed |Added

  Attachment #87257|0   |1
is obsolete||

--- Comment #84 from Ere Maijala  ---
Created attachment 87912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87912=edit
Bug 11529: Use new biblio fields whenever possible

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Ere Maijala  changed:

   What|Removed |Added

  Attachment #87256|0   |1
is obsolete||

--- Comment #83 from Ere Maijala  ---
Created attachment 87911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87911=edit
Bug 11529: Add new fields to biblio table

Signed-off-by: Michal Denar 

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20485] Don't account for items timestamps when combining "dont_export_items=1" and "date" in export_records.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20485

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22696] Simplify visibility opac-ISBDdetail.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Simplify visibility |Simplify visibility
   |opac-ISBD.pl|opac-ISBDdetail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22696


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696
[Bug 22696] Simplify visibility opac-ISBD.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22696] Simplify visibility opac-ISBD.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||22694


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694
[Bug 22694] Add a method for checking OpacHiddenItems exceptions in
Koha::Patron::Category
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22696] New: Simplify visibility opac-ISBD.pl

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22696

Bug ID: 22696
   Summary: Simplify visibility opac-ISBD.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Take advantage of bug 22694 to simplify the logic in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695

--- Comment #1 from Owen Leonard  ---
Created attachment 87910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87910=edit
Bug 22695: Remove non-XSLT search results view from the staff client

This patch removes the option to select non-XSLT search results in the
staff client. The patch removes the markup from the template, updates
the system preference options, and modifies Search.pm so that OPAC and
staff client results XSLT functions are not tied together.

To test, apply the patch and set the XSLTResultsDisplay to a blank
value. Run the database update. The value of the XSLTResultsDisplay
system preference should now be "default."

Perform a catalog search in the staff client. The results should be
shown using the XSLT view.

Test that OPAC search results respect the OPACXSLTResultsDisplay
preference when enabled and disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22695] Remove non-XSLT search results view from the staff client

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 87909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87909=edit
Bug 22694: Add Koha::Patron::Category->override_hidden_items

This patch introduces a method to determine for a given category if
patrons belonging to it override OpacHiddenItems policies.

To test:
- Apply the patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patron/Category.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 87908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87908=edit
Bug 22694: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22695] New: Remove non-XSLT search results view from the staff client

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695

Bug ID: 22695
   Summary: Remove non-XSLT search results view from the staff
client
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: katrin.fisc...@bsz-bw.de, n...@bywatersolutions.com,
testo...@bugs.koha-community.org
Blocks: 12561
  Target Milestone: ---

There are no bugs blocking the removal of the non-XSLT search results view in
the staff client, so it is safe to remove.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561
[Bug 12561] Omnibus: Deprecate non-XSLT detail and result views
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561

Owen Leonard  changed:

   What|Removed |Added

 Depends on||22695


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695
[Bug 22695] Remove non-XSLT search results view from the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||22694


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694
[Bug 22694] Add a method for checking OpacHiddenItems exceptions in
Koha::Patron::Category
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22694] Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||22457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457
[Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22694] New: Add a method for checking OpacHiddenItems exceptions in Koha::Patron::Category

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22694

Bug ID: 22694
   Summary: Add a method for checking OpacHiddenItems exceptions
in Koha::Patron::Category
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

In order to better organize the code for checking visibility confingurations in
many opac-*.pl controller scripts this method will be introduced.

At the end of the path, it will be replaced by a table column on bug 22457.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339

--- Comment #8 from Frank Hansen  ---
Yes, it seems to work after all. 
Leader fields is indexed as it should. Perfekt!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #87906|0   |1
is obsolete||

--- Comment #2 from Andrew Isherwood  ---
Comment on attachment 87906
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87906
Bug 15260: (follow-up) Fix misnamed variable

>From 12eecbfc9f52184475299caf02a8efae8e86f5ba Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood 
>Date: Fri, 12 Apr 2019 12:31:31 +0100
>Subject: [PATCH] Bug 15260: (follow-up) Fix misnamed variable
>
>This was causing the amount to push by to be incorrectly calculated
>---
> Koha/Calendar.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm
>index 47c1728575..932b7f1c1e 100644
>--- a/Koha/Calendar.pm
>+++ b/Koha/Calendar.pm
>@@ -218,7 +218,7 @@ sub addDays {
> my $dow = $base_date->day_of_week;
> my $days = $days_duration->in_units('days');
> # Is it a period based on weeks
>-my $push_amt = $days_duration % 7 == 0 ?
>+my $push_amt = $days % 7 == 0 ?
> $self->get_push_amt($base_date) : 1;
> if ( $days_duration->is_negative() ) {
> $base_date = $self->prev_open_days($base_date, $push_amt);
>-- 
>2.11.0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #1 from Andrew Isherwood  ---
Created attachment 87906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87906=edit
Bug 15260: (follow-up) Fix misnamed variable

This was causing the amount to push by to be incorrectly calculated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges

2019-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339

Björn Nylén  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   3   >