[Koha-bugs] [Bug 22764] More YUI grid cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Katrin Fischer changed: What|Removed |Added Attachment #88674|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 88677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88677=edit Bug 22764: More YUI grid cleanup This patch cleans up a few places where templates still contain YUI grid markup. Some other minor markup problems are also fixed. - additional-fields.tt: - Converts YUI grid to Bootstrap - Replaces obsolete tag with styled - Adds _() function to string in embedded JavaScript - detail.tt: - Fixes some stray YUI grid classes - Fixes corresponding JavaScript to enable page adjustments - moredetail.tt: - Removes unnecessary YUI grid markup To test, apply the patch and view the affected pages, confirming that everything looks correct and that the page adjusts well to various browser widthds. When testing the bibliographic detail page, enable AmazonCoverImages and view a record with and without an Amazon cover image. The layout should work in both cases. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22764] More YUI grid cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22764] More YUI grid cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 --- Comment #6 from Katrin Fischer --- Created attachment 88678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88678=edit Bug 22764: Change marcfield to MARC field in alert message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22764] More YUI grid cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > All these pages look good, at all screen sizes. The details.tt seems clean > with or without Amazon cover images and at all screen sizes. Thx for your testing notes! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22738] Software Error after LDAP Authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 Katrin Fischer changed: What|Removed |Added CC|koha-b...@lists.koha-commun | |ity.org | Severity|major |normal --- Comment #19 from Katrin Fischer --- Hi, adding the mailing list CC won't help, especially not the koha-bugs one as this is for the bugzilla changes and only very few are subscribed there (not including the bugzilla user itself). The normal mailing lists has a much wider audience. I suggest sending all information to the koha-devel list: http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel Someone might be able to spot the issue, that we haven't been able to figure out. Severity has been downgraded because we can't reproduce the problem at the moment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 --- Comment #12 from Katrin Fischer --- Maybe the fix from bug 20891 would be helpful here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22768] Basic MARC editor tab keyboard navigation broekn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22768 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22738] Software Error after LDAP Authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 mor...@iza.org changed: What|Removed |Added CC||koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20891 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21716 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22738] Software Error after LDAP Authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22738 mor...@iza.org changed: What|Removed |Added Severity|normal |major Priority|P5 - low|P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891
Katrin Fischer changed:
What|Removed |Added
Attachment #88637|0 |1
is obsolete||
--- Comment #21 from Katrin Fischer ---
Created attachment 88675
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88675=edit
Bug 20891: Escape list's names in JSON
When someone uses \ in the description of a list, the datatable in staff
won't load and keeps processing.
Test plan:
- Create a list named "alert('hola');"
- Create another list named "k\o\h\a"
- Hit /cgi-bin/koha/virtualshelves/shelves.pl
=> Without this patch the lists will not be displayed, JSON is
malformated
=> With this patch everything is ok
Signed-off-by: Marcel de Rooy
Signed-off-by: Liz Rea
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What|Removed |Added Severity|minor |normal --- Comment #23 from Katrin Fischer --- Updating severity a little bit - broken searches can be quite an issue for the library and are hard to fix without SQL access. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Katrin Fischer changed: What|Removed |Added Attachment #88638|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 88676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88676=edit Bug 20891: Escape html then JSON To my understanding we need to escape first html chars then to JSON. If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON IIRC we should keep the 2 different ways to use it: * [% To.json( string ) %] * [% string | $To %] otherwise it will be hard to use it when called in argument of patron-title.inc (`git grep To.json`) Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891
--- Comment #20 from Katrin Fischer ---
Tested with a little meaner version: alert('hola\');\
Seems to work like a charm!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Katrin Fischer changed: What|Removed |Added CC||pasi.kalli...@koha-suomi.fi --- Comment #7 from Katrin Fischer --- *** Bug 13231 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Katrin Fischer changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from Katrin Fischer --- Marking this a duplicate of the older bug 17661, because there are more people on CC list there. Not sure if the patch here could be rescued? *** This bug has been marked as a duplicate of bug 17661 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22766] Tags cloud link in OPAC does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22766 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|minor |critical Version|18.11 |master --- Comment #2 from Katrin Fischer --- Confirmed. - Make sure Tags are activatd - Add some tags and mark them 'approved' - Log out - Go to Tag cloud in the OPAC - Nothing displays -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21986] Quotation marks are wrongly escaped in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 Katrin Fischer changed: What|Removed |Added CC||api...@punsarn.asia --- Comment #21 from Katrin Fischer --- *** Bug 22769 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22769] Editing a record value missing if value has double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22769 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi apirak, this sounds like bug 21986 and should be fixed in version 18.05.10. *** This bug has been marked as a duplicate of bug 21986 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21986] Quotation marks are wrongly escaped in several places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21986 Katrin Fischer changed: What|Removed |Added CC||b.paster...@gmail.com --- Comment #20 from Katrin Fischer --- *** Bug 22367 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22367] Editing a record has quotes changed to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22367 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21986 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22769] New: Editing a record value missing if value has double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22769 Bug ID: 22769 Summary: Editing a record value missing if value has double quote Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: api...@punsarn.asia QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Target Milestone: --- Test plan: [0] Use staff interface [1] Add record [2] Add title with double quote in the middle of title example. 'The test "123" koha' [3] Edit record [4] Go to title field [5] In input box, value has missing also happends in editing Authorities record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #30 from paxed --- or something like [% SET location = BLOCK %]OPAC news[% END %] would let the text be translatable while still being assigned into a variable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22764] More YUI grid cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 --- Comment #3 from Lucas Gass --- All these pages look good, at all screen sizes. The details.tt seems clean with or without Amazon cover images and at all screen sizes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22764] More YUI grid cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22764] More YUI grid cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22764 Lucas Gass changed: What|Removed |Added Attachment #88621|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 88674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88674=edit Bug 22764: More YUI grid cleanup This patch cleans up a few places where templates still contain YUI grid markup. Some other minor markup problems are also fixed. - additional-fields.tt: - Converts YUI grid to Bootstrap - Replaces obsolete tag with styled - Adds _() function to string in embedded JavaScript - detail.tt: - Fixes some stray YUI grid classes - Fixes corresponding JavaScript to enable page adjustments - moredetail.tt: - Removes unnecessary YUI grid markup To test, apply the patch and view the affected pages, confirming that everything looks correct and that the page adjusts well to various browser widthds. When testing the bibliographic detail page, enable AmazonCoverImages and view a record with and without an Amazon cover image. The layout should work in both cases. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22316 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22316] Double quotes in some patron's attributes breaks patrons search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22316 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22715 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #120 from Josef Moravec --- Just rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86610|0 |1 is obsolete|| --- Comment #119 from Josef Moravec --- Created attachment 88673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88673=edit Bug 8995: (follow-up) Tak system preference item-level_itypes into account Signed-off-by: Magnus Enger Tested with all 9 current patches. Works as advertised, including OPACURLOpenInNewWindow. If a record has no items, no OpenURL link is displayed. All the suggested tests pass. I did not test with XSLT turned off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86609|0 |1 is obsolete|| --- Comment #118 from Josef Moravec --- Created attachment 88672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88672=edit Bug 8995: (follow-up) Add one more test fot get_openurl Test plan: prove t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86608|0 |1 is obsolete|| --- Comment #117 from Josef Moravec --- Created attachment 88671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88671=edit Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins Signed-off-by: Magnus Enger Test plan: 1) Ensure the COinS span tag is still included on this pages. You need to look into html source and search for span tag with class 'Z3988', which has COinS string in title. Staff client: catalogue -> ISBDdetail catalogue -> MARCdetail catalogue -> detail virtualshelves -> shelves OPAC (you should have COinSinOPACResults system preference enabled): opac detail opac search opac shelves 2) Run tests: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86607|0 |1 is obsolete|| --- Comment #116 from Josef Moravec --- Created attachment 88670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88670=edit Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86605|0 |1 is obsolete|| --- Comment #114 from Josef Moravec --- Created attachment 88668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88668=edit Bug 8995: (follow-up) Added test Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86606|0 |1 is obsolete|| --- Comment #115 from Josef Moravec --- Created attachment 88669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88669=edit Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86604|0 |1 is obsolete|| --- Comment #113 from Josef Moravec --- Created attachment 88667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88667=edit Bug 8995: (follow-up) Adapt to current codebase Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86602|0 |1 is obsolete|| --- Comment #111 from Josef Moravec --- Created attachment 88665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88665=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec changed: What|Removed |Added Attachment #86603|0 |1 is obsolete|| --- Comment #112 from Josef Moravec --- Created attachment 88666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88666=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21651] Force insert of notices related tables during the install process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 --- Comment #6 from Jonathan Druart --- Hum yes, indeed. I have no idea why I added that to the commit message. Do you think we should disable the checkboxes? If we do, we certainly we want to disable all the mandatory ones. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 --- Comment #18 from Katrin Fischer --- Created attachment 88664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88664=edit Bug 21502: (QA follow-up) Rephrase warning slightly Test plan: Follow first test plan, look at warning, decide if you like it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com QA Contact||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 --- Comment #16 from Josef Moravec --- Created attachment 88663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88663=edit Bug 10300: (QA follow-up) Make database update idempotent Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 --- Comment #15 from Josef Moravec --- Created attachment 88662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88662=edit Bug 10300: (follow-up) add controls on transfers page This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl. It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected. Additions to test plan : 1) 1.1) Enable CircSidebar 1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link 1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link 2) 2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox 3) 3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl 3.2) You are redirected to page 403 unless you are superlibarian Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Josef Moravec changed: What|Removed |Added Attachment #86521|0 |1 is obsolete|| Attachment #86522|0 |1 is obsolete|| --- Comment #14 from Josef Moravec --- Created attachment 88661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88661=edit Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Signed-off-by: Maribeth Shafer Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 --- Comment #6 from Jonathan Druart --- Added by bug 5309. See also: commit f8a58d310ee96a4bf272c9ae16dc347bf1d0e4ea Author: Marcel de Rooy Date: Mon Aug 17 13:54:44 2015 +0200 Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) I am fine with removing -r search/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Jonathan Druart changed: What|Removed |Added Attachment #86119|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 88660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88660=edit Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest Almost everywhere we call IsAvailableForItemLevelRequest we already have a Koha::Patron and Koha::Item object. It makes sense to use them to avoid a refetch Test plan: It would be good to test this patch on top of 19300 and 19301 and make sure everything works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer --- > As there has been some controversy about showing this information - could > you consider wrapping a span with a class around the years part? Hi Josef, totally my fault for not being clear :( ... I meant a span around the _whole_ age (number + text). So you can choose not to see it. Guarantor search is ok now (not sure what happened before) - just this little bit left. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22600 Status|Signed Off |Patch doesn't apply CC||josef.mora...@gmail.com --- Comment #39 from Josef Moravec --- Just a note: use Koha::Script -cron; should be added to cronjob script - see bug 22600 Also, this needs a rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17168 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com --- Comment #5 from Katrin Fischer --- Adding Jonathan and Tomas as I can see them in the history for these files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22056] Remove test/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hi Hayley, I think if we decide to remvoe the script, we should also remove the directory test and the README file. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #26 from Josef Moravec --- Created attachment 88659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88659=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 Katrin Fischer changed: What|Removed |Added Attachment #88461|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22757] Use YAML CodeMirror higlighting on YAML preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22757 --- Comment #6 from Katrin Fischer --- Created attachment 88658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88658=edit Bug 22757: Add CodeMirror highlighting on more YAML formatted preferences Test plan: Go to system preferences and ensure the code highlighting is used on these preferences: UpdateNotForLoanStatusOnCheckin BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder ItemsDeniedRenewal Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928
--- Comment #25 from Josef Moravec ---
Comment on attachment 86134
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86134
Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to
circulation_rules
Review of attachment 86134:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18928=86134)
-
::: C4/Circulation.pm
@@ +1706,5 @@
> +
> +# Search for rules!
> +foreach my $rule_name (qw( holdallowed hold_fulfillment_policy
> returnbranch )) {
> +foreach my $params (@params) {
> +my $rule = Koha::CirculationRules->search(
Why do you use ->search instead of get_effective_rule?
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ +720,4 @@
> Return policy
>
>
> +[% FOREACH i IN itemtypeloop %]
There is something strange in displaying hold policy for itemtypes. When I have
set values in Default checkout, hold and return policy section, i see all item
types listed with the same value as set in Default section, even if i set some
itemtypes differently...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Katrin Fischer changed: What|Removed |Added Attachment #88563|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 88656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88656=edit Bug 21502: Add UpdateItemLocationOnCheckin preference to YAML format check Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Katrin Fischer changed: What|Removed |Added Attachment #88564|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 88657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88657=edit Bug 21502: Add ItemsDeniedRenewal system preference to check syntax Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21502] Add checks for YAML formatted system preferences to about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21502 Katrin Fischer changed: What|Removed |Added Attachment #88562|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 88655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88655=edit Bug 21502: Add check for YAML formatted system preferences to about page So far there are these yaml formatted preferences: UpdateNotForLoanStatusOnCheckin OpacHiddenItems BibtexExportAdditionalFields RisExportAdditionalFields UpdateItemWhenLostFromHoldList MarcFieldsToOrder MarcItemFieldsToOrder Test plan: 1) Add some badly formatted YAML into some of preferences listed above 2) Check the System information tab on About page for appropriate warnings Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461
--- Comment #21 from Jonathan Druart
---
Try that:
use Koha::Patrons;
my @columns = Koha::Patrons->columns;
my $xxx = { cardnumber => 1, foo => 2, borrowernumber => 3, bar => 4, opacnote
=> undef };
my $h1 = { map { join(' ',@columns) =~ /$_/ ? ( $_ => $xxx->{$_} ) : () }
keys(%$xxx) } ; # original version
my $h2 = { map { defined( $xxx->{$_} ) ? ( $_ => $xxx->{$_} ) : () } @columns
}; # new version
use Data::Printer colored => 1; warn p $h1;
use Data::Printer colored => 1; warn p $h2;
Note sure if it is relevant however.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88457|0 |1 is obsolete|| --- Comment #146 from Katrin Fischer --- Created attachment 88652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88652=edit Bug 14576: (follow-up) Using item objects, not hashrefs Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88458|0 |1 is obsolete|| --- Comment #147 from Katrin Fischer --- Created attachment 88653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88653=edit Bug 14576: (QA follow-up) Tidy up feature documentation To test: Apply this patch with all of the others run the updatedatabase, it should work install a new Koha, this pref should be installed and look fine in the interface. Check the syspref, make sure the text looks ok and makes sense. Bonus points: for checking to make sure PROC: _PERM_ appears in the new pereference if InProcessingToShelvingCart was set for checking to make sure _ALL_: CART appears in the new preferenec if ReturnToShelvingCart was previously set. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88459|0 |1 is obsolete|| --- Comment #148 from Katrin Fischer --- Created attachment 88654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88654=edit Bug 14576: (follow-up) Add code highlighting to system preference UpdateItemLocationOnCheckin Test plan: 1) Go to system preferences and find preference UpdateItemLocationOnCheckin 2) Ensure the yaml code higlighting is used on textarea when editing this setting Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88456|0 |1 is obsolete|| --- Comment #145 from Katrin Fischer --- Created attachment 88651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88651=edit Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find Test plan: 1) Apply all patches except this one 2) Checkout out an item to a patron 3) Check the item in - note that this will fail 4) Apply this patch, and repeat steps 1-3, noting instead that the the check is instead successful 5) Verify also that reserves act as expected 5) Sign off Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88454|0 |1 is obsolete|| --- Comment #143 from Katrin Fischer --- Created attachment 88649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88649=edit Bug 14576: (follow-up) fix some typos and style Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88455|0 |1 is obsolete|| --- Comment #144 from Katrin Fischer --- Created attachment 88650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88650=edit Bug 14576: Rebase fixes Fix test Rebase code Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88453|0 |1 is obsolete|| --- Comment #142 from Katrin Fischer --- Created attachment 88648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88648=edit Bug 14576: Update to use get_yaml_pref_hash Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88451|0 |1 is obsolete|| --- Comment #140 from Katrin Fischer --- Created attachment 88646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88646=edit Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14576] Allow automatic update of location on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Katrin Fischer changed: What|Removed |Added Attachment #88452|0 |1 is obsolete|| --- Comment #141 from Katrin Fischer --- Created attachment 88647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88647=edit Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461
--- Comment #20 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #12)
> Jonathan isn't around much at the moment so Katrin asked me to check in
> here. I believe Jonathans last followup was somewhat flawed (looks like a
> copy paste issue).
Martin, I tried to reuse the previous code to prevent other regressions.
But it seems I left a 'grep'. The code was:
-my $new_member = { map { join(' ',@columns) =~ /$_/ ? ( $_ => $data{$_} )
: () } keys(%data) } ;
So, I am now wondering: should not you test 'exists' instead of 'defined' in
your code?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #18 from Jonathan Druart --- (In reply to Martin Renvoize from comment #17) > As an aside, do we have any inflators setup with our dbic schemata? Like: Koha/ItemTypes.pm:$Koha::Schema::Result::Itemtype::LANGUAGE = $language; ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #49 from Katrin Fischer --- Hi Andrew, I am very sorry, not sure the last patch is quite right. I think what happens now is that either will make 'all' checkboxes appear, if the item is on hold or not. I think we need to control the checkboxes separately, if that makes sense? Test case: Have at least 2 items checked out, 1 is on hold. AllowRenewalOnHoldOverride AllowRenewalLimitOverride - Restriction override checkbox below table appears - OK - Checking the box, enables the on hold item for renewal - OK - Checking the box also enabled all other items for renewal - not OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on test BorrowerLogs and TrackLastPatronActivity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 --- Comment #2 from Jonathan Druart --- What is the error? Is this a duplicate of bug 22453? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What|Removed |Added Attachment #88596|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 88644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88644=edit Bug 21757: (folow-up) Restore patron brief detail page Test plan 1) Try to create patron with same name/datefobirth to trigger the duplicate patron check 2) Click on "View existing record" link on "Duplicate patron record?" alert message 3) You should see the patron data, but withou toolbar, menu, and so on. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What|Removed |Added Attachment #88595|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 88643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88643=edit Bug 21757: Clenup of moremember.pl and its templates This patch: - removes unused templates - use objects as much as possible - remove many template params Test plan: 1) Apply the patch 2) Play with patron detail page and try to broke it anyhow ;) - messaging preferences - enhanced attributes - guarantors and guarantees - fines - messages - checkouts - overdues - use different date formats, price formats and address formats - ... there is many thinks you could try with this one page ;) Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21757] Patron detail script (moremember.pl) cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21757 Katrin Fischer changed: What|Removed |Added Attachment #88597|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 88645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88645=edit Bug 21757: (follow-up) Fix number of columns in checkouts table footer template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20307] Language overlay for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #15 from Martin Renvoize --- Oh, sorry, I hadn't spotted that this one had come to life.. I'll try hard to find a moment to have a look at it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 --- Comment #5 from Katrin Fischer --- Created attachment 88642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88642=edit Bug 22753: Fix tabs pointed out by QA script Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #17 from Martin Renvoize --- I do sort of agree that 'metadata' feels like a bit a generic term if in reality it's always marc.. As an aside, do we have any inflators setup with our dbic schemata? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer changed: What|Removed |Added Attachment #88555|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 88641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88641=edit Bug 22753: Fix hold priority adjustment, move to top Since the holds table can be split we need to calculate the first priority for each table. However, currently we use the first in the loop, not taking into account the waiting status. This patchset sets the first_priority to the first non-found hold Additionally, some clean-up is done to not display the alter priority arrows for waiting holds. To test: 1 - Place several holds on a title 2 - Confirm one of the holds to be waiting 3 - Attempt to move the last hold to the top 4 - Nothing happens 5 - Apply patch 6 - Note that the waiting hold has no options to move in the list 7 - Attempt to move the last hold to the top 8 - It moves as expected! 9 - Split the holds queue by pickup library 10 - PLace some holds for pickup at another branch 11 - Confirm moving these holds works within their own table 12 - Unsplit the queue 13 - Ensure the holds end where you expect (moving in a split table didn't move above holds form another table) Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591
--- Comment #7 from Jonathan Druart
---
Comment on attachment 88377
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88377
Bug 21591: Additionally check for blank strings in itypes
Review of attachment 88377:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21591=88377)
-
::: C4/Reserves.pm
@@ +330,4 @@
>
> # Check for item on shelves and OnShelfHoldsAllowed
> return { status => 'onShelfHoldsNotAllowed' }
> + unless ( IsAvailableForItemLevelRequest($item->unblessed,$borrower) );
Is that change correct?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #29 from Jonathan Druart --- Just a note: there is bug 20307 that could have handled the translation part. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22753] Move hold to top button doesn't work if waiting holds exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22753 Katrin Fischer changed: What|Removed |Added Version|18.11 |master CC||katrin.fisc...@bsz-bw.de Summary|Move hold to top button |Move hold to top button |doesn't work if waiting |doesn't work if waiting |holds exist.|holds exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22732] Redundant search box on admin-home.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22732 --- Comment #5 from Christopher Brannon --- Can't you just turn the top search filed blue or something? I'm not sure why having it two inches lower makes any difference. It's just wasted space, IMO. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22762] Collection codes not displayed on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Jonathan Druart changed: What|Removed |Added Blocks||22669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart changed: What|Removed |Added Depends on||22762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 [Bug 22762] Collection codes not displayed on receiving -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22669] Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Jonathan Druart --- Hi Liz, thanks for testing. The window closes correctly here, make sure you refreshed the cache. However the data are not updated, because of the "method not covered by tests" error, with the patch from bug 22762 it looks ok. Could you retest with both patches applied? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22762] Collection codes not displayed on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 Jonathan Druart changed: What|Removed |Added Attachment #88587|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #16 from Katrin Fischer --- (In reply to Jonathan Druart from comment #15) > (In reply to Katrin Fischer from comment #14) > > What we had discussed I think was storing data in other formats than MARC - > > so still 1:1 > > No, it would become 1:n then. I meant still only 1 metadata entry - either MARC or Dublincore or... not having both or multiple formats. It would allow to load data without converting to MARC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22700] Make biblio_metadata prefetchable from Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22700 --- Comment #15 from Jonathan Druart --- (In reply to Katrin Fischer from comment #14) > What we had discussed I think was storing data in other formats than MARC - > so still 1:1 No, it would become 1:n then. What about renaming the method in Koha::S::R::Biblio to ->marc_xml_metadata (adding the conditions in it) and Koha::Biblio->metadata to ->marc_xml (make it returns the MARX XML directly)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
