[Koha-bugs] [Bug 22279] Unify patron name display

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||7680
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=7680|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680
[Bug 7680] Create a PatronDefaultView preference to control whether patron
links go to circ or patron details
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||22279
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=22279   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279
[Bug 22279] Unify patron name display
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558

--- Comment #5 from Aleisha Amohia  ---
Created attachment 88997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88997=edit
Bug 8558: Improve confirmation message for importing frameworks

This patch updates the confirmation message from:
"Do you really want to import the framework fields and subfields? This
will overwrite the current configuration. For safety reasons please use
the export option to make a backup"
to:
"Are you sure you want to import the [% loo.frameworkcode | html %]
framework structure? This will overwrite the current configuration. For
safety reasons, it is recommended to use the export option to make a
backup first."

To test:
1) Go to Administration -> MARC bibliographic frameworks
2) Export one of the frameworks
3) Create a new test framework
4) Import the new test framework structure using the exported file
5) Upon clicking Confirm, confirm the message is improved and makes
sense.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7862] Warns when creating a new notice

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7862] Warns when creating a new notice

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862

--- Comment #3 from Aleisha Amohia  ---
Created attachment 88996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88996=edit
Bug 7862: Preventing warns when creating a notice

To reproduce warns:
1) Go to Tools -> Notices & slips
2) Create a new notice of any module

Notice these warns:
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.

CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.

3) Create a new notice of the Circulation module

Notice this additional warn:
Use of uninitialized value $code in pattern match (m//) at
/home/vagrant/kohaclone/tools/letter.pl line 258.

To test:
4) Apply patch and refresh page
5) Run steps 1-3 again and confirm no warns show

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7862] Warns when creating a new notice

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7862

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21892] Robin Sheat is not a typo

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892

--- Comment #16 from Jonathan Druart  
---
This is just complexifying everything for... what exactly? I am ok with "Sheat"
being a typo, really. I am sure Robin will not mind much.

I still think that display 3 lines to explain what's need to update to the new
version is the best and easiest way to go.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

--- Comment #15 from Jonathan Druart  
---
Created attachment 88995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88995=edit
Bug 13420: Sort "Serial enumeration" by published date

So far the sorting on volume information is incorrect. It sorts by the
string displayed in the cell, which may not have any logics.

A better solution would be to use Kyle's suggestion, see comments 7, 8,
but it will need much more work.

This patch suggests to use the publication date to sort this column.
Note: In the code there is a switch depending on the existence of
items.publisheddate, but I do not think it is valid, this valid should
always exist if the item is received (did I miss something?)

Test plan:
You need to have different existing subscription, using different
numbering.
On the detail page of the bibliographic record you should be able to
sort the serials (tab "Holdings") by "Serial enumeration".
The sort will now use the publication dates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun
   |ommunity.org|ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

--- Comment #28 from Jonathan Druart  
---
So, what's next? Waiting something from me?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21122] Make check-url-quick.pl handle utf8 characters in urls gracefuly

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122

--- Comment #11 from Jonathan Druart  
---
(In reply to José-Mario Monteiro-Santos from comment #10)
> I'm not quite sure if I can ask about this here, but I've been having
> problems when urls contain characters such as é or à. I understand that this
> patch makes it so check-url-quick doesn't explode when it encounters such
> characters, but when the http request is sent they're encoded differently
> and are marked as broken links (é turns into é for example). Is this
> related to this bug ?

No, or I do not understand what you meant exactly.

I have tried with 856$u = https://en.wikipedia.org/wiki/Māori, then run the
script with --verbose:
1   https://en.wikipedia.org/wiki/Māori 200 OK

Looks ok for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22800] New: No need to raw filter the mandatory fields var (OPAC suggestions)

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800

Bug ID: 22800
   Summary: No need to raw filter the mandatory fields var (OPAC
suggestions)
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

This is a follow-up for bug 22550, we do not need to use the $raw filter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Blocks||22800

--- Comment #9 from Jonathan Druart  
---
The usage of raw could be avoided here, I have opened bug 22800 to remove it.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800
[Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22799] Batch item modification is case sensitive

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #88991|0   |1
is obsolete||

--- Comment #3 from Aleisha Amohia  ---
Created attachment 88994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88994=edit
Bug 22799: Avoiding batch item modification case sensitivity when entering
barcodes

Note: this fixes the bug that is present right now where batch item
modification barcode matching is case sensitive, but if Koha barcodes
ever do become case sensitive, this patch will need to be removed.

To test:
1) Make/use an item with a barcode with letters in it. For testing
purposes, I'll be using an item with the barcode 'abcde'.
2) Go to Tools -> Batch item modification and enter this barcode in the
barcode list text input field, but change the case of one or some
letters. (i.e. enter the barcode in the field as 'abCDE')
3) Click Continue
4) Notice that the next page shows an error 'the following barcodes were
not found', but the item still shows underneath (was correctly fetched from
database).
5) Create a text file and put the changed-case barcode in it (i.e. put
the barcode 'abCDE' in the text file)
6) Go back to batch item modification and upload the
text file as a barcode file
7) Notice same error as in Step 4
8) Apply patch and refresh page
9) Run through steps 1 to 6. There should no longer be an error and the
barcodes should be found as expected.

Sponsored-by: South Taranaki District Council

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800

--- Comment #1 from Jonathan Druart  
---
Created attachment 88993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88993=edit
Bug 22800: (bug 22550 follow-up) Do not raw filter when not necessary (OPAC
suggestions)

This is a follow-up for bug 22550, we do not need to use the $raw
filter.

Test plan:
Same as bug 22550:
Test plan:
Test plan:
1. OPAC->login->your purchase suggestions->New purchase suggestion
2. Click button "Submit your suggestion" directly without filling in any field.
   Empty suggestion record was added succeffully.
3. Apply the patch.
4. Click button "Submit your suggestion" directly without filling in any field.
   The required fields should be labeled in red.
   (you can change the mandatory fields by preference
   'OPACSuggestionMandatoryFields')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22800] No need to raw filter the mandatory fields var (OPAC suggestions)

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22800

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||22550


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550
[Bug 22550] OPAC suggestion form doesn't require mandatory fields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596

--- Comment #8 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #7)
> IMO it would have been better to encode TT-side (see TT plugin To.json), raw
> must be avoided as much as possible.

This must be addressed, we should not use $raw when can be avoided.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490

--- Comment #19 from Jonathan Druart  
---
From
  commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea
  Bug 19490: Add a 'Holds' column to the items batchmodification tool

This following line:
+$this_row{item_holds}   = Koha::Holds->search( itemnumber =>
$itemnumber )->count;

displays a DBIC warning:
[Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client
192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl:
DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use
search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm line
136: /home/vagrant/kohaclone/tools/batchMod.pl, referer:
http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl

Must be ->search({ itemnumber => $itemnumber })->count

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22642] DB upgrade 18.06.00.005 can fail

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22642

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #10 from Jonathan Druart  
---
Too late for installs that upgraded already?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

--- Comment #9 from Jonathan Druart  
---
This could be a fix (yes, ugly). We could also remove the s.* from the fields
selection, but this will need to know which one is used (how, without making
sure we will not introduce regressions?)

Or we could have 1 query to fetch the reports, then 1 query per report to fetch
the results (O(n), bad)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #87598|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 88992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88992=edit
Bug 22357: Do not duplicate report rows if several reports exist

At the moment every time you run runreport.pl with the --store-results
option another line will appear for your report in the saved
reports table. This is not a data, but a display problem as the
report is still only stored once.

1) Create a report and note the report number
2) Run from command line (replace X by report number) :
misc/cronjobs/runreport.pl X --format=csv --csv-header --store-results
3) Go to saved reports table
4) Look at the table, each run of the cronjob will create a new row
   in the table instead of just updating the saved results column.
5) Apply patch
6) Veriy the table displays correctly again and there are no regressions

QA: Run t/db_dependent/Reports/Guided.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22799] Batch item modification is case sensitive

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22799] Batch item modification is case sensitive

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

--- Comment #1 from Aleisha Amohia  ---
Created attachment 88991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88991=edit
Bug 22799: Avoiding batch item modification case sensitivity when entering
barcodes

Note: this fixes the bug that is present right now where batch item
modification barcode matching is case sensitive, but if Koha barcodes
ever do become case sensitive, this patch will need to be removed.

To test:
1) Make/use an item with a barcode with letters in it. For testing
purposes, I'll be using an item with the barcode 'abcde'.
2) Go to Tools -> Batch item modification and enter this barcode in the
barcode list text input field, but change the case of one or some
letters. (i.e. enter the barcode in the field as 'abCDE')
3) Click Continue
4) Notice that the next page shows an error 'the following barcodes were
not found', but the item still shows underneath (was correctly fetched from
database).
5) Create a text file and put the changed-case barcode in it (i.e. put
the barcode 'abCDE' in the text file)
6) Go back to batch item modification and upload the
text file as a barcode file
7) Notice same error as in Step 4
8) Apply patch and refresh page
9) Run through steps 1 to 6. There should no longer be an error and the
barcodes should be found as expected.

Sponsored-by: TBC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22799] Batch item modification is case sensitive

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

--- Comment #2 from Aleisha Amohia  ---
Sponsored-by line is not final, but this can be tested

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22799] New: Batch item modification is case sensitive

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

Bug ID: 22799
   Summary: Batch item modification is case sensitive
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

The tool is able to search for barcodes in the database fine, but the code then
tries to match barcodes to check if retrieved with barcodes requested. This
part is case sensitive and it looks like the fetch failed if the case in the
search isn't the same as the case in the DB.

To reproduce:
1) Make/use an item with a barcode with letters in it
2) Go to Tools -> Batch item modification and enter this barcode in the barcode
list text input field, but change the case of one or some letters. (i.e. if the
barcode is 'abcde', enter the barcode in the field as 'abCDE')
3) Click Continue
4) Notice that the next page shows an error 'the following barcodes were not
found', but the item still shows underneath (was correctly fetched from
database).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22799] Batch item modification is case sensitive

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

--- Comment #8 from Jonathan Druart  
---
Hi Katrin,

I think this patch fixes the problem you faced. I did not read a test plan as I
have to admit I completely forgot about that code and not sure how the changes
could be completely tested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20340] Ability to use authentication plugin

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

--- Comment #56 from David Cook  ---
(In reply to Martin Renvoize from comment #51)
> (In reply to Fridolin SOMERS from comment #50)
> > > have a granular set of permissions on the server
> > What about adding to koha-conf.xml a boolean to allow or not uploading
> > plugins ?
> > If not allowed only system admin can add plugins.
> > 
> > My 2c
> 
> You can already enable and disable plugins entirely from koha-conf can't
> you.. I was thinking more having classifactions of plugins so you could
> allow a whitelist of supported ones for example.. or say.. all cataloguing
> plugins but not auth plugins.
> 
> I like the idea of a whitelist.

I think Fridolin was talking about leaving plugins enabled, but disabling the
ability to upload via the Web UI. I've thought about doing this myself. 

A whitelist could be interesting. I also liked your mention earlier about
signed plugins. One way of whitelisting could be to only allow plugins signed
by keys you trust. I mean... that's how a lot of software installers already
work, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21027] Totals in statistics tab change when StatisticsFields is changed

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21027

--- Comment #7 from Jonathan Druart  
---
Created attachment 88990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88990=edit
Bug 21027; Fix checkout statistics if 1+ of the fields is not defined

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20340] Ability to use authentication plugin

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

--- Comment #55 from David Cook  ---
(In reply to Martin Renvoize from comment #49)
> This is a manageable risk. I believe we should end up with a repository of
> signed and trusted plugins as per Alex's response (comment #48) and have a
> granular set of permissions on the server as to what types of plugins may be
> installed via the client.  I've been wanting to work towards this for some
> time, along with adding translations to plugins and generally enhancing the
> system as a whole.. but these things all need sponsorship, time and money.
> 

I love the sound of all of that, and I really relate in terms of time and
money. I know I must sound like a troll by leaving lots of comments and not
"doing" anything about them, but it's all I have time for at the moment. 

> Koha is a well established and highly reliable system these days, relied
> upon by countless libraries. I am a firm believer in our quality assurance
> policies and the both the commit logs and release notes serve to prove that
> the software is still moving forward rapidly with enhancements and new
> features continually being integrated.  Yes, we could always do with more
> hands/eyes on the code and people supporting each other by offering SO and
> QA time. That is something I intend to work on if I am elected to be RM over
> the next two cycles, but I think it's very unfair to suggest one has to have
> extensive influence/power to get code into the community. I believe we are a
> very supportive and friendly community in 99% of cases and I would certainly
> support anyone's efforts to get code in.. sometimes it is hard to pick which
> bugs to focus on and I'm always open to suggestions via any means (email,
> irc, bugzilla priorities)
> 

This is very true. I should have chosen my words more carefully. The Koha
community is very supportive and very friendly. I don't think there's an open
source community that is warmer and receptive than this one. I'm reminded of
that every time I look at the photo of my child in a "Future Koha Developer"
onesie that Katrin sent us when bub was born.

It's true that you don't need extensive influence/power to get code into the
community, and I use my first patch as evidence of that:
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b49af1df17c06cb41d168fa154cb2104798c33cf.
I'd been using Koha for less than 2 months at that point, and I didn't really
know anyone in the Koha community.

I think my earlier comment about influence/power relates to particular
frustrations experienced by individuals that can be discussed elsewhere. 

Good luck with the elections, Martin! Koha would be very safe in your hands!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20340] Ability to use authentication plugin

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

--- Comment #54 from David Cook  ---
(In reply to Alex Arnaud from comment #48)
> I do understand this argument. I even agree that plugins (and not only
> authentication ones) could contain security issues. 
> For "our" hosted libraries, we disabled writing permission on plugins
> directory.
> Looks like a tricky solution and we probably need a better one but it means
> that administrators have the final word.
> 

That's really interesting to know. That's probably the most logical way to do
it presently, but I agree that it would be nice to have a more elegant
solution. I think that's the key thing I'd like to see come out of this
discussion really. 

> IMO plugins are useful (even essential) to satisfy specific libraries
> requests and not to avoid community processes.
> i wrote this patch in order to create an authentication plugins that can
> request many LDAP backends and fallback on an other one.
> Seems too specific to be suggested to the community.
> To go further, as discussed above, i think we should consider generally
> LDAP, CAS etc... as specific feature that would become plugins (may be
> another debate).

I totally agree in theory. I would love to see all the authentication methods
structured as plugins that can be added/removed as necessary, although I think
it should be done by administrators rather than librarians. 

> To return to security topic:
> Today, many free plugable systems provide repositories with a large amount
> of plugins that have been reviewed, tested and validated by their community
> as safe. Users can easily download ones from other sources but they know
> it's at their own risk.
> Maybe we should be inspired by that.

I'd argue that "they know it's at their own risk" isn't necessarily true. It's
like how many people sign contracts without reading them, or tick the "Terms
and Conditions" box without reading the Terms and Conditions. People seem to
just assume that nothing bad will ever happen to them. 

However, I like the sound of the plugins being reviewed, tested, and validated
by their community. I recall there being an unwillingness to provide a
repository for fear that it would create an "endorsement" of plugins by being
in the repository, but... I think you're right. People read and trust reviews.
If they had a centralized place for reviewing plugins, I think that could
really build confidence in using them, and provide people without technical
knowledge a source to make more informed decisions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20340] Ability to use authentication plugin

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

--- Comment #53 from David Cook  ---
(In reply to Chris Cormack from comment #46)
> I think what David meant to say was thank you Alex, for testing and
> providing your first patch to Koha to fix a broken test.  Then gone on with
> the discussion of technical merits 
> 
> Rest assured we do value your contribution, and we want Koha to be a
> welcoming place.

(In reply to Chris Cormack from comment #46)
> My apologies Axel, my phone autocorrected your name to Alex

Chris is absolutely right. 

I must admit that my eyes actually autocorrected "axel" to "Alex", and I
thought the latest patches were follow-up from Alex Arnaud, so I didn't think
twice. Looking back, thanks for the contributions, axel! I have no criticism of
them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20340] Ability to use authentication plugin

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340

--- Comment #52 from David Cook  ---
(In reply to Katrin Fischer from comment #45)
> The plugin idea Alex is working on here is not new - see the discussion in
> the first comments. For added security we could discuss different solutions,
> like a separate permission for handling authentication plugins maybe?
> 

I see the logic of adding permissions, but I suppose I'm concerned about small
libraries where a solo librarian might have all the permissions, but might not
make the best choices with those permissions.

> I don't agree with people saying it's too hard to get things in. But I
> definitely think we should not have this discussion on bugzilla. The dev
> meeting today would be a better place.

Yes, perhaps Bugzilla is not the best place to have that discussion. I wasn't
aware of the dev meeting until after it was finished, and it seems that it was
at 5am my time, so I was still (barely) asleep. I think they're usually at 5am
or 12am my time, which makes them difficult to attend.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21073] Improve plugin performance

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073

--- Comment #19 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #18)
> As THE native speaker, it is your responsbility to propose another word :-D

Hehe fair enough, although I'm not sure of the exact context. Why do you want
to rename it from "methods" to something else? Is methods too low-level or
overloaded in terms of meaning?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #191 from Jonathan Druart  
---
And the 2 prefs (AuthorisedValueImages and StaffAuthorisedValueImages) have
been removed by bug 16167, that's why we never call the non-existing routine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

--- Comment #11 from David Cook  ---
(In reply to Jonathan Druart from comment #10)
> (In reply to David Cook from comment #9)
> > (In reply to Katrin Fischer from comment #8)
> > > A human being might still misuse the feature - I think it should be a 
> > > choice
> > > for the library, so they can turn off 'non logged in cart sending'.
> > 
> > Agreed. We actually have this implemented locally as an "anonymous cart"
> > system preference. I think most of our libraries have it turned off (ie
> > require login), but a few want anyone to be able to use the cart.
> 
> Still have the code somewhere?

Yes, although we've customized the cart quite a bit, so it would take time,
which I don't have, to unravel it enough to share. 

Basically, I think you have a system preference, and enable $authnotrequired
where necessary and add Koha.Preference( '' ) where necessary
in the templates.

I could look at this another time, but need to focus on other things atm.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||additional_work_needed

--- Comment #189 from Jonathan Druart  
---
I suspect a wrong resolution conflict here, see
  commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7
  Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories

The following line has been removed for years, and re-added by this patchset:

+$oldbiblio->{'authorised_value_images'}  =
($search_context->{'interface'} eq 'opac' &&
C4::Context->preference('AuthorisedValueImages')) ||
($search_context->{'interface'} eq 'intranet' &&
C4::Context->preference('StaffAuthorisedValueImages')) ?
C4::Items::get_authorised_value_images(
C4::Biblio::get_biblio_authorised_values( $oldbiblio->{'biblionumber'},
$marcrecord ) ) : [];

At first glance I'd say we just need a patch removing the line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22417] Delegate background jobs execution

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417

--- Comment #24 from David Cook  ---
(In reply to Jonathan Druart from comment #23)
> But then the job will be in the DB table, so we will not lose it, right?

If we're worried about losing messages, why not look at RabbitMQ persistence?

https://www.rabbitmq.com/persistence-conf.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8618] Don't copy CCL queries into Z39.50 search form when using button from search results

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8618

David Cook  changed:

   What|Removed |Added

Summary|Don't copy CQL queries into |Don't copy CCL queries into
   |Z39.50 search form when |Z39.50 search form when
   |using button from search|using button from search
   |results |results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #190 from Jonathan Druart  
---
Note: The routine C4::Biblio::get_biblio_authorised_values does not longer
exist!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16167] Remove prefs to drive authorised value images

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16167

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8219

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8219] get_biblio_authorised_values embarrassingly inefficient

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8219

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16167

--- Comment #2 from Jonathan Druart  
---
Well, not really, the method has been removed by
  commit 85e7d186ec2f0a30e479bc924a1023c73eefc28e
  Bug 16167: Remove Authorised value images prefs

But the call has been re-added recently:
  commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7
  Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories

So, this bug is fixed, but we have another one running.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

--- Comment #10 from Jonathan Druart  
---
(In reply to David Cook from comment #9)
> (In reply to Katrin Fischer from comment #8)
> > A human being might still misuse the feature - I think it should be a choice
> > for the library, so they can turn off 'non logged in cart sending'.
> 
> Agreed. We actually have this implemented locally as an "anonymous cart"
> system preference. I think most of our libraries have it turned off (ie
> require login), but a few want anyone to be able to use the cart.

Still have the code somewhere?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8198] Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |minor

--- Comment #4 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #3)
> Is this still valid?

Yes, it could be a code cleaning.

So far we have to test if userenv is defined before accessing a key, for
instance:
  C4/Accounts.pm:my $branchcode = C4::Context->userenv ?
C4::Context->userenv->{'branch'} : undef;

My fix would still be valid, but we still need a test:
  C4/Accounts.pm:my $branchcode = exist C4::Context->userenv->{branch} ?
C4::Context->userenv->{'branch'} : undef;

which actually makes less sense.

A better approach could be to have a ->logged_in_user method, to retrieve a
Koha::Patron object, representing the logged in user. But it is a quite huge
work, and nobody will sign it off, and rebases will be tricky ;)

Lowering severity for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22798] New: Double quote included in Publisher search on tag 264

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22798

Bug ID: 22798
   Summary: Double quote included in Publisher search on tag 264
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbut...@gmail.com
QA Contact: testo...@bugs.koha-community.org
  Target Milestone: ---

Created attachment 88989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88989=edit
Field 264 double-quotes

On the OPAC, if a user clicks on the hyperlinked Publisher value in the
bibliographic record, a double-quote is appended to the search url if the
publication value is catalogued in field 264, thus breaking the search. For
example:

http://library.craigbutosi.ca/cgi-bin/koha/opac-search.pl?q=Provider:Verso%2C%22

instead of 

http://library.craigbutosi.ca/cgi-bin/koha/opac-search.pl?q=Provider:Verso%2C


The double-quote does not appear in records in which publication data is
entered in field 260, thus search succeeds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806

--- Comment #7 from Jonathan Druart  
---
It could be useful to know if production DBs still contain such values (?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234
Bug 9234 depends on bug 5515, which changed state.

Bug 5515 Summary: Leading 'and' in search never returns a result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9233] Use unambiguous boolean operators for searches

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9233

Katrin Fischer  changed:

   What|Removed |Added

 CC||bob-ew...@bobsown.com

--- Comment #2 from Katrin Fischer  ---
*** Bug 5515 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17160] Foreign key constraint for message_transports is too loose

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||5334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] Omnibus: Add explicit foreign key constraints
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||5334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] Omnibus: Add explicit foreign key constraints
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign key constraint

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||5334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] Omnibus: Add explicit foreign key constraints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5666] regexp edits to URL fields in bibliographic edit screens

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5666

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
We do have a batch record modification tool now that supports changing 856$u
using regex.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5561] Help on summary field in authority type editor

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5561

Katrin Fischer  changed:

   What|Removed |Added

Version|rel_3_2 |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add explicit foreign key|Omnibus: Add explicit
   |constraints |foreign key constraints

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5515] Leading 'and' in search never returns a result

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 9233 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680

--- Comment #21 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #20)
> Maybe this could be wrapped into unifying the patron name display? (bug
> 22279)

Agreed, we definitely should fix bug 22279 first, then this feature will be
very easy to implement.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4467] messaging defaults not on add child

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4467

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #5 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 7660 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set when creating a child patron from the adult

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Katrin Fischer  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #2 from Katrin Fischer  ---
*** Bug 4467 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18441] add primary, foreign keys to statistics table

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18441

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||5334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] Omnibus: Add explicit foreign key constraints
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18050] Missing constraint foreign key on table aqbudget

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||5334


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] Omnibus: Add explicit foreign key constraints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||18050, 22658, 22421, 18441,
   ||17160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160
[Bug 17160] Foreign key constraint for message_transports is too loose
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050
[Bug 18050] Missing constraint foreign key on table aqbudget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18441
[Bug 18441] add primary, foreign keys to statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421
[Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658
[Bug 22658] aqbasket.authorisedby is missing a foreign key constraint
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||4166


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166
[Bug 4166] No way to know what keywords to use for Keyword Mapping
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4166] No way to know what keywords to use for Keyword Mapping

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||11529
 CC||katrin.fisc...@bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
[Bug 11529] Add subtitle, medium and part fields to biblio table
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6685] circ rules by groups of items

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||katrin.fisc...@bsz-bw.de

--- Comment #15 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 21946 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4274] Optionally allow sending cart without requiring login

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

Katrin Fischer  changed:

   What|Removed |Added

Summary|Cart now requires login |Optionally allow sending
   |before emailing contents|cart without requiring
   ||login

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||4164


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164
[Bug 4164] Way to Clone Keyword Mapping to other Frameworks
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4164] Way to Clone Keyword Mapping to other Frameworks

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Depends on||11529


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
[Bug 11529] Add subtitle, medium and part fields to biblio table
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6523] Enhancement: Patron Refund Limits & Expirations

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6523

Katrin Fischer  changed:

   What|Removed |Added

  Component|Patrons |Fines and fees
 CC||katrin.fisc...@bsz-bw.de
Version|rel_3_2 |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21946] Group circulation by item type

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Katrin Fischer  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #28 from Katrin Fischer  ---
*** Bug 6685 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6172] Non-French UNIMARC frameworks need to be updated

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #14 from Katrin Fischer  ---
(In reply to Jon Knight from comment #12)
> (In reply to Giuseppe Ciaccio from comment #11)
> > It seems that Koha/unimarc/en is working properly, provided the indexer has
> > started (which does not happen initially, but this is another story; see
> > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20745).
> 
> As the Koha/unimarc/en is working OK, I assume you're happy for this case to
> close?

(In reply to Giuseppe Ciaccio from comment #13)
> Yes I'm indeed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6548] Add karma system to encourage patrons to behave commendably

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6548

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6948] Default hold expiry date

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6948

Katrin Fischer  changed:

   What|Removed |Added

Summary|Default Hold Expiry Date|Default hold expiry date
  Component|Circulation |Hold requests
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6922] staff should be able to have children

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6922

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 12446 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #80 from Katrin Fischer  ---
*** Bug 6922 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973

Katrin Fischer  changed:

   What|Removed |Added

Summary|Allow reply-to on cart  |Allow reply-to on cart
   |emails to go to the sender  |emails to go to the sender
   |of the cart.|of the cart

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

Katrin Fischer  changed:

   What|Removed |Added

  Component|Circulation |Hold requests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7107] 'used in' column on analytics not populating

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7107

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
Is this still valid? It's marked major but has seen no action since 2015.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7170] Remove use of XML::Simple

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|NEW
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7030] Define maximum number of holds on branch level

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
I believe this has been fixed, we have the max number of holds in all 3 tables
on circulation conditions now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7152] Koha should make it easy for librarians to attach covers using Open Library

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7152

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|ro...@catalyst.net.nz   |koha-b...@lists.koha-commun
   ||ity.org
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7062] Titles on labels not truncating

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7062

Katrin Fischer  changed:

   What|Removed |Added

   Severity|major   |normal

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7021] patron category in the statistics table

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||22794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||7021


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021
[Bug 7021] patron category in the statistics table
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7011] Warn the user that they have reached the limit of how many items they can have in their cart

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7011

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||katrin.fisc...@bsz-bw.de
   Assignee|jcam...@cpbibliography.com  |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7010] Select all records from search

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7010

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Still much wanted and asked for often.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7003] Canned report to show patrons and permissions

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003

Katrin Fischer  changed:

   What|Removed |Added

Summary|canned report to show   |Canned report to show
   |patrons and permissions |patrons and permissions

--- Comment #4 from Katrin Fischer  ---
I think this would be really nice, especially if it auto-updated with new
permissions being added. 

If you have a lot of staff fluctuation you might want to check regularly that
all old account have been removed or at least the permissions reset.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7195] end date in the future prevents receiving - without error

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7195

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
I can't reproduce this - the end date should always be in the future?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7206] Improve usability of cancel order links in basket

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7206

Katrin Fischer  changed:

   What|Removed |Added

Summary|delete links in basket  |Improve usability of cancel
   |could use design work   |order links in basket

--- Comment #1 from Katrin Fischer  ---
I agree that this could still be improved. Especially if the record can't be
deleted with the order, there is way too much information displayed. Might work
better as a tooltip or similar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #90 from Katrin Fischer  ---
*** Bug 7260 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7260] User should be able to determine the number of search results per page (OPAC)

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7260

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 14715 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7340] Only send HOLD_PLACED if item is available and hold was patron initiated

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7340

Katrin Fischer  changed:

   What|Removed |Added

Summary|emailLibrarianWhenHoldIsPla |Only send HOLD_PLACED if
   |ced enhancement |item is available and hold
   ||was patron initiated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||7384


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384
[Bug 7384] keyword to marc mapping in emails
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7384] keyword to marc mapping in emails

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||11529

--- Comment #2 from Katrin Fischer  ---
Koha to Keyword mappings will be removed by bug 11529.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
[Bug 11529] Add subtitle, medium and part fields to biblio table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7386] Label batches cannot be batch deleted

2019-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >