[Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What|Removed |Added Depends on||11983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 [Bug 11983] Code to select patrons to purge needs to be centralized -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Blocks||16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22908] Modsuggestion will generate a notice even if the modification failed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22908 --- Comment #6 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > Works when you run prove on the test, but not with perl [other sql mode]? > New test fails then. Shouldnt DBIx always raise a warning if you want to > pollute a date field? DBI will not explode and so the notice will be generated. I have no idea how to fix that, I'd say we should require that tests are ran using prove or with the strict_sql_modes flag in the config. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > You are not explaining in the test description what is really expected. We > do not want the update to affect any rows because privacy is set to 0, right? Actually it returns > 0 because of previous tests, so it should be adjusted (ideally tests must be independent from each others). I think this test must be removed as it is not testing anything useful: the previous statement will explode if something went wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22944] avoid AnonymousPatron in search_patrons_to_anonymise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22944 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- You are not explaining in the test description what is really expected. We do not want the update to affect any rows because privacy is set to 0, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22736] Search field on "New order > from suggestion" search for borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 Jonathan Druart changed: What|Removed |Added Severity|normal |minor --- Comment #8 from Jonathan Druart --- I do not think displaying the borrowernumber will be consistent with other views. I am sorry but I do not have anything simple to suggest. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22964] Remove the word "product" from the bugzilla bug report page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22964 Jonathan Druart changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|NEW |In Discussion --- Comment #1 from Jonathan Druart --- Hello Donna, It's a bugzilla wording. As we host it we could fix it, but it will need we are forking. CCing Chris to get his opinion on this and let us know if it is worth the effort. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308
--- Comment #78 from Jonathan Druart
---
1. Only one occurrence of passwordlengthhint
koha-tmpl/intranet-tmpl/prog/css/installer.css:#passwordlengthhint
2. Do we really need the warning when adding/editing a patron?
BTW, $warning is not needed, memberentry.pl
177 my $warning = 1;
178 $template->param("passwordwarning"=>$warning);
3. Just a though, next time we add a "step" we will need to rethink the
template. The shift is terrible. And hard to see the real changes.
Not passing QA for 2, waiting for another QA point of view.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #20 from Agustín Moyano --- Created attachment 90094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90094=edit Bug 20691: Add ability to turn feature on and off This patch adds two preferences 1. AllowPatronToSetFinesVisibilityForGuarantor: Allow/Don't allow patrons to choose their own privacy settings for showing the patron's fines to the patron's guarantor 2. AllowStaffToSetFinesVisibilityForGuarantor: Allow/Don't allow staff to set the ability for a patron's fines to be viewed by linked patrons in the OPAC Also adds a tinyint, non nullable, default to 0 column in borrower and deletedborrower named privacy_guarantor_fines. 1. privacy_guarantor_fines = 0 => don't allow guarantor to see guarantee's fines 2. privacy_guarantor_fines = 1 => allow guarantor to see guarantee's fines To test: 1) git reset --hard master 2) apply patches (including dependencies) 3) perl installer/data/mysql/updatedatabase.pl 4) dbic 5) restart_all 6) in intranet search for AllowPatronToSetFinesVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor preferences SUCCESS => both preferences should be present 7) search for a patron with guarantor SUCCESS => in details tab, in "Library use" section you should see a row labeled "Show fines to guarantor" 8) edit CHECK => in Guarantor information there is no "Show fines to guarantor" select 9) set AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow" 10) return to patron with guarantor and edit SUCCESS => in Guarantor information section there is a "Show fines to guarantor" select 11) change "Show fines to guarantor" select to "Yes" and save SUCCESS => Value is saved 12) go to details tab SUCCESS => in "Library use" section you see a row labeled "Show fines to guarantor" with value "Yes" 13) set OPACPrivacy preference to "Allow" 14) open 2 opacs, one with a patron that has a guarantor and another that hasn't and go to "your privacy" tab. CHECK => in both opacs you should not see a "Allow your guarantor to view your current fines?" select 15) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow" 16) refresh both opacs SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view your current fines?" select => in Patron without guarantor you don't see a "Allow your guarantor to view your current fines?" select 17) in Patron with guarantor change value of select and save SUCCESS => Value is saved 18) in intranet set OPACPrivacy preference to "Don't allow" and AllowPatronToSetFinesVisibilityForGuarantor to "Don't allow" 19) got to "your personal details" in both opacs CHECK => in both opacs you should not see no Privacy section with a "Allow your guarantor to view your current fines?" select 20) in intranet set AllowPatronToSetFinesVisibilityForGuarantor to "Allow" 21) refresh both opacs SUCCESS => in Patron that has guarantor you see a "Allow your guarantor to view your current fines?" select in a Privacy section => in Patron without guarantor there is no Privacy section 22) in Patron with guarantor change value of select and update SUCCESS => Value is saved 23) Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #19 from Agustín Moyano --- Created attachment 90093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90093=edit Bug 20691: Database update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agustín Moyano changed: What|Removed |Added Attachment #89992|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #22 from Agustín Moyano --- Created attachment 90096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90096=edit Bug 20691: (follow-up) Fix qa fails -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 --- Comment #21 from Agustín Moyano --- Created attachment 90095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90095=edit Bug 20691: Implement fines view This patch implements the logic to show guarantee's fines with guarantor user. To test: 1) Apply (if not already done) steps 1 to 5 of previous patch 2) Apply this patch 3) Set OPACFinesTab and AllowStaffToSetFinesVisibilityForGuarantor preference to "Allow" 4) Find a guarantee and in accounting create a manual invoice 5) Enter OPAC with guarantor user CHECK => In summary there is no "Relatives fines" tab 6) On intranet edit guarantee and set "Show fines to guarantors" to "Yes" and save 7) Reload guarantor's OPAC SUCCESS => You see a "Relatives fines" tab with guarantee's fines information 8) Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agustín Moyano changed: What|Removed |Added Attachment #89990|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agustín Moyano changed: What|Removed |Added Attachment #89991|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agustín Moyano changed: What|Removed |Added Attachment #89993|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #4 from Jonathan Druart --- I was talking about "prior to bug 11473", so 3.16.x. No access old logs vs access the wrong logs? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7663] batch add barcodes to a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 --- Comment #14 from Jonathan Druart --- (In reply to Nitesh Kumar Verma from comment #13) > I Cant able to find file "a/virtualshelves/shelves.pl" > > KOHA version: 16.05.19.000 > OS version: UBUNTU 16.04 LTS 32 BIT > Perl version: 5.022001 It's "virtualshelves/shelves.pl" You should either upgrade to a more recent version of Koha to get this change, or apply the patches using the command 'patch' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 --- Comment #12 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #7) I do not understand what you are trying to show. > 10. You should see in the all lib policy that the "Maximum total holds > allowed (count)" field is not empty > - Is that expected??? Yes of course, what do you expect? I contain the value you filled in before. > 11. Refill all the fields Which ones? For "all" they are already filled. > 12. Then you should see that for both policies, "Maximum total holds allowed > (count)" stays empty Nope, I see what I just entered. All good for me, please retest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 --- Comment #11 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #7) I do not understand what you is trying to show. > 10. You should see in the all lib policy that the "Maximum total holds > allowed (count)" field is not empty > - Is that expected??? Yes of course, what do you expect? I contain the value you filled in before. > 11. Refill all the fields Which ones? For "all" they are already filled. > 12. Then you should see that for both policies, "Maximum total holds allowed > (count)" stays empty Nope, I see what I just entered. All good for me, please retest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #39 from Jonathan Druart --- (In reply to Jonathan Druart from comment #29) > Just for reference: https://gitlab.com/joubu/Koha/commits/bug_18936 > > It is not supposed to be tested, I am not expecting it to work correctly. Remote branch rebased. Previous comment still applies, please focus on dependencies first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22679] circulation_rules are not deleted when accompanying issuingrules are deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22679 --- Comment #8 from Jonathan Druart --- We should delete in a transaction and handle the returned value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #24 from Jonathan Druart --- Comment on attachment 89404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89404 Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find parameters in smart-rules.pl We should not need this patch. If the rule_name param is needed to make it works, something else is broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18930 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14048 --- Comment #23 from Jonathan Druart --- Yes Victor, you can also test that the behavior is correct. You will find the test plan of the feature on bug 14048. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22952] Markup error in OPAC suggestions template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Maryse Simard changed: What|Removed |Added Attachment #89946|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 90092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90092=edit Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450
--- Comment #15 from Jonathan Druart
---
Nick, the Copyright of the tests need to be updated before push.
Also I think that $h->{"$a$b"} is more readable than $h->{$a.$b}, but it can be
debatable I guess :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22955] Markup error in OPAC lists template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Maryse Simard changed: What|Removed |Added Attachment #89949|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 90091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90091=edit Bug 22955: Markup error in OPAC lists template This patch makes a minor correction to the template for OPAC lists. This correction fixes an error returned by the HTML validator by adding an empty "alt" attribute to an image tag. To reproduce the problem you should have at least one list available in the OPAC with one or more items on it. View the contents of that list in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "An img element must have an alt attribute, except under certain conditions." To test, apply the patch and try again to reproduce the validation error. The error should no longer be present. There should be no visible change to the page. Click "Download list." A modal window should appear with a "Loading" message, followed by a form for selecting a download format. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22955] Markup error in OPAC lists template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22955 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450 --- Comment #13 from Jonathan Druart --- Created attachment 90089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90089=edit Bug 21450: Cache authorities search using term and auth_type This is a simple fix to prevent incorrect caching of results when using link_bibs_to_authorities To test: 1 - Find or create a record with the same term in a subject and genre heading 2 - Find or create authority records for the term as a subject and genre type 3 - Run link bibs to authorities 4 - Verify both tags in the record are linked to the subject heading 5 - Aply patch 6 - Unlink the record and re-run the script (or just re-run) 7 - Each tag should be linked to correct authority Signed-off-by: Frank Hansen Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450 --- Comment #14 from Jonathan Druart --- Created attachment 90090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90090=edit Bug 21450: (QA follow-up) remove a couple of unused variables to make QA script happy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450 Jonathan Druart changed: What|Removed |Added Attachment #90076|0 |1 is obsolete|| Attachment #90077|0 |1 is obsolete|| Attachment #90078|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 90088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90088=edit Bug 21450: Unit tests To test: 1 - Apply just this patch 2 - prove -v t/db_dependent/Linker_Default.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/Linker_Default.t 6 - It passes Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22947] Markup error in OPAC preferences file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22947] Markup error in OPAC preferences file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22947 Maryse Simard changed: What|Removed |Added Attachment #89941|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 90087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90087=edit Bug 22947: Markup error in OPAC preferences file This patch corrects a markup error in the OPAC .pref file which can cause display problems. The patch also corrects a validator warning by changing at to a . To reproduce the problem, go to Administration -> Global system preferences -> OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Unclosed element code." - "The tt element is obsolete. Use CSS instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the display. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Jonathan Druart changed: What|Removed |Added Attachment #90085|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 90086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90086=edit Bug 20537: Added checks to remove warning from overdue_notices.pl When executing overdue_notices.pl on borrowers that lack a surname, we see this error: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 575. This patch fixes this issue by setting the $borr variable based on the information that has been defined. To test: 1) Create a borrower and set its surname to null 2) Checkout an item to the borrower and set it to be overdue 3) Navigate to kohaclone/misc/cronjobs and enter a koha-shell 4) Run the script: ./overdue_notices.pl 5) Observe the error appears 6) Apply the patch 7) Repeat steps 3-4 8) Observe the error is gone 9) Sign off! Sponsored-by: Catalyst IT Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15221] SIP server always sets the alert flag when item not returned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #11 from Jonathan Druart --- Tests are failing. t/db_dependent/SIP/Message.t .. 2/4 # Failed test 'Alert flag is set' # at t/db_dependent/SIP/Message.t line 361. # got: 'N' # expected: 'Y' # Failed test 'Checkin without CV triggers alert flag when cv_triggers_alert is off' # at t/db_dependent/SIP/Message.t line 388. # got: 'N' # expected: 'Y' # Looks like you failed 2 tests of 27. t/db_dependent/SIP/Message.t .. 3/4 # Failed test 'Checkin V2' # at t/db_dependent/SIP/Message.t line 74. # Looks like you failed 1 test of 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #5 from Michal Denar --- Hi, in kohadevbox? Did you aplly restart_all after patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #151 from Liz Rea --- That's messed up - possibly I had a chicken and egg thing going. I'll try it again - and if I don't get to it soon it's probably fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Liz Rea changed: What|Removed |Added Attachment #89368|0 |1 is obsolete|| --- Comment #9 from Liz Rea --- Created attachment 90085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90085=edit Bug 20537: Added checks to remove warning from overdue_notices.pl When executing overdue_notices.pl on borrowers that lack a surname, we see this error: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 575. This patch fixes this issue by setting the $borr variable based on the information that has been defined. To test: 1) Create a borrower and set its surname to null 2) Checkout an item to the borrower and set it to be overdue 3) Navigate to kohaclone/misc/cronjobs and enter a koha-shell 4) Run the script: ./overdue_notices.pl 5) Observe the error appears 6) Apply the patch 7) Repeat steps 3-4 8) Observe the error is gone 9) Sign off! Sponsored-by: Catalyst IT Signed-off-by: Liz Rea patch wouldn't apply on current master, so I fixed that. Work is the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||maryse.sim...@inlibro.com --- Comment #46 from Maryse Simard --- Patch doesn't apply Applying: Bug 14242: Use ISBN-field to automaticly fill out purchase suggestions Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref M koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 14242: Use ISBN-field to automaticly fill out purchase suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22888] Use DataTables for Koha news table filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22888] Use DataTables for Koha news table filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22888 Maryse Simard changed: What|Removed |Added Attachment #89658|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 90084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90084=edit Bug 22888: Use DataTables for Koha news table filtering This patch modifies the Koha news page so that filtering the table of news is done using DataTables' built-in search functionality. This allows for the table to be filtered without requiring a reload of the page. The patch also moves the table filter into a sidebar form and adds a keyword field. A minor change has been made to the global CSS to improve the display of the form in the sidebar. To test, apply the patch and rebuild the staff client CSS. - Go to Tools -> News. - Test the various table filter options: keyword, display location, and library. Confirm that all work as expected. - Changes to the keyword search text should be reflected in the search field at the top of the table, and vice versa. - Changes to the sidebar filter should trigger the correct state of the "Clear filter" button at the top of the news table (enabled or disabled). Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Liz Rea changed: What|Removed |Added Status|REOPENED|Needs Signoff --- Comment #8 from Liz Rea --- Actually, I was wrong and we do see this - I didn't have a rule defined for overdue notices for the borrower I was looking at. Bum. So, having another look. :) Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Liz Rea changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com Status|Needs Signoff |RESOLVED Resolution|--- |WORKSFORME --- Comment #7 from Liz Rea --- Hayley is right, the behaviour doesn't seem to appear in current master, even though that code is the same. I think we can call this one fixed? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Bouzid Fergani changed: What|Removed |Added CC||bouzid.ferg...@inlibro.com --- Comment #4 from Bouzid Fergani --- Hi, I have problem when applying this patch. Without the patch, when i search "a", i have results but with this patch nothing. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 --- Comment #5 from Janusz Kaczmarek --- Forgot to say: I have checked the fonts downloaded from google-webfonts-helper.herokuapp.com -- seems to be OK (tested for Latin extended). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 --- Comment #4 from Janusz Kaczmarek --- (In reply to Owen Leonard from comment #3) > My goal will be to figure out how to solve the problem without pulling the > data directly from Google. Doing so opens us up to Google data-collection. https://google-webfonts-helper.herokuapp.com/fonts/noto-sans?subsets=latin-ext,latin ? But how other alphabets? Greek, cyrillic and others? Loading everything would not be create performance issues? One could also download and insert to Koha the Google versions and use their css (after modifying URLs) (to be consulted here: https://fonts.googleapis.com/css?family=Noto+Sans). Fonts can be downloaded, but I succeeded only with woff2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22932] GetLatestSerials should not return formatted date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22932] GetLatestSerials should not return formatted date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22932 Maryse Simard changed: What|Removed |Added Attachment #89901|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 90083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90083=edit Bug 22932: GetLatestSerials should not return formatted date This patch updates GetLatestSerials in Serials.pm to remove date formatting. Formatting of dates should be done in the template using $KohaDates. To test, apply the patch and locate a bibliographic record in the staff client which has a subscription with issues. - On the bibliographic detail page for that record, view the "Subscriptions" tab. Dates in the table of recent issues should be formatted correctly. - View the details for the subscription in the Serials module. Create or edit a routing list for that serial. In the "Issue" dropdown the issue dates should be formatted correctly. - View the bibliographic detail page for the record in the OPAC. Open the "Subscriptions" tab. In the table of recent issues publication date and received date should be formatted correctly. The table should sort correctly on these dates. Note: Although opac-ISBDdetail.pl calls GetLatestSerials, as far as I can tell there is no serial-related output to update. The code appears to be unused. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22760] catalogue search yields no results if queryparser is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22760 Bin Wen changed: What|Removed |Added CC||bin@inlibro.com --- Comment #5 from Bin Wen --- Test plan: 1. Set system preferences QueryParser to Try and set defaultsortorder/defaultsortfield to relevance,dsc. 2. Search the catalog with a keyword that will return more than 1 page of results. 3. Go to page 2, page 1,page 2, page 1,Alternate between the page results a few times, the page will return no results. 4. Apply patch. 5. Do steps 2-3 and verify that it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22760] catalogue search yields no results if queryparser is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22760 Bin Wen changed: What|Removed |Added Attachment #89968|0 |1 is obsolete|| --- Comment #4 from Bin Wen --- Created attachment 90082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90082=edit Bug 22760: Correct parseQuery regex to match full words when QueryParser is on Signed-off-by: Liz Rea Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983 --- Comment #3 from Owen Leonard --- (In reply to Janusz Kaczmarek from comment #2) > = using the Google API version, the rendering is OK (also with no 'local' > part in declaration). My goal will be to figure out how to solve the problem without pulling the data directly from Google. Doing so opens us up to Google data-collection. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22983] The Koha copy of NotoSans font (in the new OPAC) lacks glyphs for (some) Roman letters with diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22983
--- Comment #2 from Janusz Kaczmarek ---
Thank you, Owen, for checking this. I can confirm: the rendering of the fonts
is (almost) OK in FF 67.0 (almost = in my case the non-bold paragraphs show the
problem mentioned).
After having investigated more deeply: it seems that FF and Edge use some local
copy of the font: Removing the part "local("Noto Sans *")," from each
@font-face definition (e.g. with the developer tool of FF) causes the problem
occur in FF and in Edge for every variant (regular and bold) as it is in
Chrome.
I have also used the following html file to test the issue fully locally (and
had the Koha version of the font locally downloaded):
Zażółć gęślą jaźń
@charset "UTF-8";
@font-face {
font-family:NotoSans;
font-style:normal;
font-weight:400;
src:local("Noto Sans Regular"),
url(NotoSans-Regular-webfont.woff2) format("woff2"),
url(NotoSans-Regular-webfont.woff) format("woff")
}
@font-face {
font-family:NotoSans;
font-style:bold;
font-weight:700;
src:local("Noto Sans Bold"),
url(NotoSans-Bold-webfont.woff2) format("woff2"),
url(NotoSans-Bold-webfont.woff) format("woff")
}
body {
font-family:"NotoSans";
}
Zażółć gęślą jaźń
Zażółć gęślą jaźń
Zażółć gęślą jaźń
Zażółć gęślą jaźń
Zażółć gęślą jaźń
BTW, after inserting the line:
@import url('https://fonts.googleapis.com/css?family=Noto+Sans=swap');
in
[Koha-bugs] [Bug 15749] Add library menu to OPAC header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15749 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 Liz Rea changed: What|Removed |Added Attachment #89528|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 90081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90081=edit Bug 22128: Use DROP USER IF EXISTS instead of GRANT USAGE before DROP USAGE MySQL 5.7 is old, and the latest versions fail on "GRANT USAGE" if the user does not exist. "DROP USER IF EXISTS" has been with us since 5.7, so all users should have it by now. This patch fixes the issue. To test: Try to koha_remove a site, and if it works with no errors, all good! Note: I reformatted this patch to community guidelines, and did not test it. I took the intent of the patch, and made it so that it would work. The work is Rudolf's and I have attributed it as such. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22974] Patron password update validation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Bin Wen changed: What|Removed |Added Attachment #90043|0 |1 is obsolete|| --- Comment #3 from Bin Wen --- Created attachment 90080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90080=edit Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above." Signed-off-by: Liz Rea Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Liz Rea changed: What|Removed |Added Attachment #88840|0 |1 is obsolete|| --- Comment #77 from Liz Rea --- Created attachment 90079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90079=edit Bug 18308: Removed warns and moved password length warning to template Sponsored-by: Catalyst IT Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450 --- Comment #11 from Liz Rea --- Created attachment 90078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90078=edit Bug 21450: (QA follow-up) remove a couple of unused variables to make QA script happy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450 --- Comment #10 from Liz Rea --- Created attachment 90077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90077=edit Bug 21450: Cache authorities search using term and auth_type This is a simple fix to prevent incorrect caching of results when using link_bibs_to_authorities To test: 1 - Find or create a record with the same term in a subject and genre heading 2 - Find or create authority records for the term as a subject and genre type 3 - Run link bibs to authorities 4 - Verify both tags in the record are linked to the subject heading 5 - Aply patch 6 - Unlink the record and re-run the script (or just re-run) 7 - Each tag should be linked to correct authority Signed-off-by: Frank Hansen Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21450] link_bibs_to_authorities.pl is caching searches without the auth type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21450 Liz Rea changed: What|Removed |Added Attachment #84340|0 |1 is obsolete|| Attachment #89732|0 |1 is obsolete|| --- Comment #9 from Liz Rea --- Created attachment 90076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90076=edit Bug 21450: Unit tests To test: 1 - Apply just this patch 2 - prove -v t/db_dependent/Linker_Default.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/Linker_Default.t 6 - It passes Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22950] Markup error in OPAC recent comment template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22950] Markup error in OPAC recent comment template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22950 Maryse Simard changed: What|Removed |Added Attachment #89945|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 90075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90075=edit Bug 22950: Markup error in OPAC recent comment template This patch makes minor corrections to the template for the OPAC's recent comments view. These corrections fix errors returned by the HTML validator. The patch moves some inline CSS into a class in the global OPAC CSS. Some minor reindentation has also been done, so use diff with the '-w' flag. To reproduce the problem you should have the 'reviewson' system preference turned on, and your system should have one or more approved comments. View the "Recent comments" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "CSS: font-color: Property font-color doesn't exist." To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22808] Move Cache.t to db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #150 from Kyle M Hall --- Liz, you are referring to t/db_dependent/Koha/Account.t right? I just tried it pre and post patch with the database update and it passes in both cases! This was with a fresh koha-testing-docker instance. (In reply to Liz Rea from comment #149) > Happened to notice also, after applying the updates supplied with this > patch, that the Account.t test fails due to a lack of guarantorid. There may > be other tests that will fail as well. > > Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on instance creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Bouzid Fergani changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on instance creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465 Bouzid Fergani changed: What|Removed |Added Attachment #80749|0 |1 is obsolete|| --- Comment #9 from Bouzid Fergani --- Created attachment 90074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90074=edit Bug 19465: Document koha-create --elasticsearch-server option switch Signed-off-by: Tomas Cohen Arazi Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22420] Tag cloud feature broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- missing dependencies, wont backport to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22953] Markup warning in OPAC user summary template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22953 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22010] RecordedBooks and OverDrive should check preferences over passing variables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #9 from Lucas Gass --- missing dependencies, wont backport to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22953] Markup warning in OPAC user summary template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22953 Maryse Simard changed: What|Removed |Added Attachment #89947|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 90073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90073=edit Bug 22953: Markup warning in OPAC user summary template This patch makes a minor markup change to the OPAC user summary template (opac-user.tt) in order to quiet warnings from the HTML validator. The obsolete name attribute on two links is removed in favor of class names. The JavaScript has been modified accordingly. To reproduce the problem you should have the AllowCheckoutNotes system preference enabled. Log in to the OPAC as a user who has checkouts and view the "your summary" page. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses this warning: - "The name attribute is obsolete. Consider putting an id attribute on the nearest container instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the process of adding or editing an note on a checkout. It should work correctly. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #17 from Lucas Gass --- missing dependencies, wont backport to 18.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22925] AuthenticatePatron should fail if patron has lost card
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22925 Liz Rea changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||wizzy...@gmail.com --- Comment #2 from Liz Rea --- Hi Arthur, Can you explain a bit more about the use case here? Since this is ILS-DI only, and not across all of the Koha OPAC, I assume your use case has to do with connectivity to a service like Overdrive or Bolinda (or your local eBook vendor). Is that right? The reason I ask is because not every library uses the cardnumber as the login username. A person who loses their card may still have a legitimate reason to log into Koha (or an attached 3rd party service) - why should they be additionally punished for losing their card by not being able to access library resources? People lose things all the time and it's really annoying to replace all those lost things. Let's not make it harder for people. The information on the majority of library cards is basically considered public - things like your name, and your card number. They aren't secret. The password though, is. And since (I sure hope...) normally the password isn't on the library card, even if someone bad has the card, they still don't have the password and so can't get in anyway. Taking it a step further, even if the bad person went to the OPAC to change the password (presuming the library has that enabled), they would still need the username (that could be the card number, yes, but it often isn't) and/or the e-mail address associated with the account, and access to that email account, to change the password. Yes, they could then get in to the 3rd party service, but they have worked really hard to get there and compromised much more than just Koha, and likely broken a few laws in the mean time. If we are going to implement this feature, I feel like it must be optional, and definitely should be off by default. Please, if anybody thinks any of this is wrong, I'm happy to consider that point of view - I am sure I haven't thought through to every possibility and there could be a very good use case for this feature. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Bin Wen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22960] Typo found in circulation.pref in UpdateItemLocationOnCheckin preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22960 Bin Wen changed: What|Removed |Added Attachment #89955|0 |1 is obsolete|| --- Comment #2 from Bin Wen --- Created attachment 90072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90072=edit Bug 22960: Typo found in circulation.pref in UpdateItemLocationOnCheckin preference This patch corrects a typo in circulation.pref in the description of the UpdateItemLocationOnCheckin preference. To see the problem, go to Administration -> System preferences -> Circulation and look at the description for the UpdateItemLocationOnCheckin preference: "The special term _BLANK_ may be used on either side of a value pair to update or remove the location from items with no locaiton assigned." Note the misspelling "locaiton." To test, apply the patch and refresh the circulation preferences page. The typo should be fixed. Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22621] Filters on subscription result list search the wrong column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #14 from Liz Rea --- Please note that I do not verify the correctness of any translation, but I do confirm that we can get through the installer and the onboarding with the sample data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #12 from Liz Rea --- Created attachment 90070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90070=edit Bug 22471: Optional Finnish installer values Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #13 from Liz Rea --- Created attachment 90071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90071=edit Bug 22471: Add system preferences for Finnish installer To test: 1. Apply all patches in this Bug 2. Create an empty database. Make sure database user has permissions to it and $KOHA_CONF is pointing to the correct database. 3. Add Finnish translation, for help, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client 4. Run web installer and select fi-FI as installer language 5. Select all mandatory and optional default values 6. Finish installation and make sure you get no SQL errors Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #11 from Liz Rea --- Created attachment 90069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90069=edit Bug 22471: Mandatory Finnish installer values Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22471] Default Finnish values for web installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Liz Rea changed: What|Removed |Added Attachment #86766|0 |1 is obsolete|| Attachment #86767|0 |1 is obsolete|| Attachment #86768|0 |1 is obsolete|| Attachment #86769|0 |1 is obsolete|| --- Comment #10 from Liz Rea --- Created attachment 90068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90068=edit Bug 22471: Add installer/data/mysql/fi-FI This patch adds a direct copy of installer/data/mysql/en. No translations provided in this patch! Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21589] Series link formed from 830 field is incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21589 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #29 from Lucas Gass --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||wizzy...@gmail.com --- Comment #38 from Liz Rea --- I think these errors will put this on a failed QA state (Sorry Jonathan...) Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20208] Custom file upload paths
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Liz Rea --- Failed QA for now, as some discussion of the spec needs to take place. The problem we are trying to solve for the librarians here is the one of having a user moderated web space that is manageable from within Koha, with friendly URL's such as http://model.akohasite.org/uploads/a/b/c/file.pdf. This dev gets about halfway to this goal, as it includes a nice interface for the staff client and staff can upload files into a specific upload path. The problem comes when we go to try and access those files from the OPAC - it can't currently be done, and even if it worked we still don't display the URL the library would use to access the file anywhere. These features are a core part of this development. There are a few ways we might go about getting this to work, happy to chat about those at anytime (Tomas and Kyle both have ideas about how this could go - please feel free to ask them). Please do ask if you have any questions at all. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20692] koha-plack doesn't check for Include *-plack.conf line in /etc/apache2/sites-available/$INSTANCE.conf
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20692 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #16 from Lucas Gass --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15522] New interface for revamped circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #21 from Victor Grousset/tuxayo --- Ok, I got confused by the previous message, I should have noticed that it was in "BLOCKED" and not in "Need Signoff" So, I think I did all I could in bug 18930 and bug 18936. I there something else doable in the dependencies of this bug? Maybe trying to get one of my colleagues to QA Bug 18928 ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #89831|0 |1 is obsolete|| --- Comment #8 from Andrew Isherwood --- Created attachment 90063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90063=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #89832|0 |1 is obsolete|| --- Comment #9 from Andrew Isherwood --- Created attachment 90064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90064=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #89833|0 |1 is obsolete|| --- Comment #10 from Andrew Isherwood --- Created attachment 90065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90065=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What|Removed |Added
Attachment #89834|0 |1
is obsolete||
--- Comment #11 from Andrew Isherwood ---
Created attachment 90066
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90066=edit
Bug 22818: Add MessageAttribut{e,es}.pm
We need to be able to access individual message attributes in tests, so
adding accessors for them
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22818] ILL should be able to send notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood changed: What|Removed |Added Attachment #89835|0 |1 is obsolete|| --- Comment #12 from Andrew Isherwood --- Created attachment 90067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90067=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Liz Rea changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Liz Rea --- Hi, I was ready to sign this off but we have a test failure: # Failed test 'Item ccode should be set back to empty' # at t/db_dependent/CourseReserves/CourseItems.t line 167. # got: 'DVD' # expected: '' Have a look? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- not backporting ES bugs/fixes to 18.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
