[Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff client includes 1/2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff client includes 1/2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Katrin Fischer changed: What|Removed |Added Attachment #91337|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 91382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91382&action=edit Bug 22957: Remove type attribute from script tags: Staff client includes 1/2 This patch removes the "type" attribute from
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer changed: What|Removed |Added Attachment #91366|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 91381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91381&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett Signed-off-by: Nadine Pierre Signed-off-by: frederik chenier Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer changed: What|Removed |Added Attachment #91365|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 91380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91380&action=edit Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett Signed-off-by: frederik chenier Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr |ity.org | CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Agustín Moyano changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #4 from Agustín Moyano --- Created attachment 91377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91377&action=edit Bug 15497: Add itemtypes_branches table and atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #5 from Agustín Moyano --- Created attachment 91378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91378&action=edit Bug 15497: Modify schemas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15497] Limit Item Types by Branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 --- Comment #6 from Agustín Moyano --- Created attachment 91379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91379&action=edit Bug 15497: Limit itemtypes by branch in additem.pl This patch adds a select multiple when you add/edit an itemtype, creates functions to return itemtypes by library, and filters the options of itemtype select in additem To test: 1) Apply this patch set 2) perl installer/data/mysql/updatedatabase.pl 3) In koha administration => item types, edit "Books" itemtype CHECK => there is now a select multiple whith libraries at the bottom 4) select centerville and save 5) set centerville as current libary 6) search for any biblio in the catalog 7) click on "edit items" CHECK => book item type is present 8) set any other libary as current library SUCCESS => book item type is not present 9) Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6815] Capture member photo via webcam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 --- Comment #31 from M. Tompsett --- (In reply to M. Tompsett from comment #30) > Created attachment 91335 [details] [review] > Bug 6815: Detect Webcam to show or not button > > It's hard to test on a laptop with a webcam built it. sudo apt install v4l-utils sudo modprobe -r uvcvideo # removes sudo v4l2-ctl --list-devices sudo modprobe uvcvideo # re-adds sudo v4l2-ctl --list-devices Tested with: - Chrome Version 75.0.3770.100 (Official Build) (64-bit) - FireFox Quantum 67.0.4 (64-bit) - Chromium Version 75.0.3770.90 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit) - Opera Version:62.0.3331.43 They all worked! YAY! I was testing on Ubuntu 18.04.2 LTS with the default desktop manager, which I believe is Gnome. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23197] Add more batch operation options to SQL report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23197 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23197] Add more batch operation options to SQL report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23197 Maryse Simard changed: What|Removed |Added Attachment #91000|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 91376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91376&action=edit Bug 23197: Add more batch operation options to SQL report results This patch extends the feature which allows the user to send item numbers from a page of report results to batch item modification. For biblionumbers: Batch record modification, batch record deletion, and add to list are now available. For item numbers: batch item deletion is added. A new menu button is added for these options at the top of report results, removing the button from the item number column header. Corresponding CSS has been removed. To test, apply the patch and create a report which includes both biblionumber and itemnumber columns in the results. - Run the report and confirm that a new "Batch operations" button appears at the top of the results. Test each option: - Batch record modification - Batch record deletion - Add to list - Batch item modification - Batch item deletion In each case the correct set of parameters should be passed to the batch operations. Test with reports which return only biblionumbers, only itemnumbers, and neither. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23094] Use Bootstrap-style pagination on staged MARC records page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23094 Maryse Simard changed: What|Removed |Added Attachment #91027|0 |1 is obsolete|| --- Comment #5 from Maryse Simard --- Created attachment 91375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91375&action=edit Bug 23094: Use Bootstrap-style pagination on staged MARC records page This patch makes markup changes in order to make the pagination links on the staged MARC records page consistent with the links on the catalog search results page. To test properly you should have enough staged marc record batches that there are multiple pages to list. Go to Tools -> Manage staged MARC records. Test that the pagination links look consistent with the catalog search results page and that they work correctly. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23273] New: Downloading from overdues.pl doesn't use set filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23273 Bug ID: 23273 Summary: Downloading from overdues.pl doesn't use set filters Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To Test: - go to overdues.pl - construct a search limiting by date due and library - note number of overdues in results - click "Download file of displayed overdues" - note that downloaded file contains all overdues, not just those in your search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 --- Comment #16 from Nick Clemens --- *** Bug 22903 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22903] Elasticsearch, dynamic display when you refine your search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |RESOLVED CC||n...@bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #7 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 14419 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Nick Clemens changed: What|Removed |Added CC||axel.amg...@biblibre.com --- Comment #15 from Nick Clemens --- *** Bug 22924 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22903] Elasticsearch, dynamic display when you refine your search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22903 Bug 22903 depends on bug 22924, which changed state. Bug 22924 Summary: Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 What|Removed |Added Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Nick Clemens changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #12 from Nick Clemens --- Bug 14419 adds the size parameter to all facets. Expanded facet is removed so this one is no longer needed *** This bug has been marked as a duplicate of bug 14419 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Maryse Simard --- Patch doesn't apply Applying: Bug 23228: Add option to automatically display payment receipt for printing after making a payment Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M members/paycollect.pl Falling back to patching base and 3-way merge... Auto-merging members/paycollect.pl CONFLICT (content): Merge conflict in members/paycollect.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref error: Failed to merge in the changes. Patch failed at 0001 Bug 23228: Add option to automatically display payment receipt for printing after making a payment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Maryse Simard changed: What|Removed |Added Attachment #91128|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 91374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91374&action=edit Bug 23237 Plugin allow [% INCLUDE %] from template >From a plugin template it is useful to be able to include other templates with [% INCLUDE %] directives. But TT module is used by Koha with absolute paths. Relative paths are forbidden for security reasons. A new param [% PLUGIN_DIR %] allow plugin templates to know where to find plugin home directory. How to test: 1. Install kitchen-sink plugin. 2. Find tool-step1.tt file, and add this at the begining of the file: [% INCLUDE "$PLUGIN_DIR/header.tt" %] It ask to include a template header.tt which doesn't exit. 3. Run kitchen-sink plugin tool. You must have this error message: Template process failed: file error - _path to plugin directory_/Koha/Plugin/Com/ByWaterSolutions/KitchenSink/header.tt: not found quod erat demonstrandum Signed-off-by: Maryse Simard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 Michal Denar changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #11 from Michal Denar --- Can anybody rebase on master? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22924] Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22924 --- Comment #10 from Bouzid Fergani --- HI, The patch of tests is not apply correctly. Bug 22924 - Elasticsearch, SysPref FacetMaxCount don't show more than 10 facets 90665 - Bug 22924: Make elasticsearch honour FacetMaxCount system preference 90903 - Bug 22924: Unit tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22924: Make elasticsearch honour FacetMaxCount system preference Applying: Bug 22924: Unit tests Using index info to reconstruct a base tree... M t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t error: Failed to merge in the changes. Patch failed at 0001 Bug 22924: Unit tests The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22924-Unit-tests-N6uhfY.patch Bouzid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613 --- Comment #17 from Michal Denar --- Hi Johanna, can you verese this patch on top of master? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16825] Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Michal Denar changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16825] Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 --- Comment #45 from Michal Denar --- Johanna, can You rebase it on master? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23218] Batch patron modification empty attribute causes improper handling of values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23218] Batch patron modification empty attribute causes improper handling of values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Maryse Simard changed: What|Removed |Added Attachment #91130|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 91373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91373&action=edit Bug 23218: Fix shift in patron's attributes in batch patron modification When the "new" button is clicked without selecting a patron's attribute, the update will have unexpected behaviors. There is indeed a difference in the number of patron's attributes and the number of values. Test plan: Go to the batch patron modification Enter a cardnumber At the bottom of the page, click "new" without selecting an attribute On the second line select one, and a value (different than an empty string) Save => The attribute will be updated with an empty string Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721 Bouzid Fergani changed: What|Removed |Added Attachment #91283|0 |1 is obsolete|| --- Comment #7 from Bouzid Fergani --- Created attachment 91372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91372&action=edit Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls Test plan: Run tests, at least: t/db_dependent/Biblio.t t/db_dependent/Biblio/TransformHtmlToMarc.t t/db_dependent/Charset.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Filter_MARC_ViewPolicy.t t/db_dependent/ImportBatch.t t/db_dependent/Items.t t/db_dependent/Items/AutomaticItemModificationByAge.t t/db_dependent/Items/GetItemsForInventory.t t/db_dependent/Koha/Filter/EmbedItemsAvailability.t t/db_dependent/Serials.t t/db_dependent/XISBN.t t/db_dependent/FrameworkPlugin.t Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #6 from Frédérik Chénier --- Created attachment 91370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91370&action=edit Bug 23194: Allow HTML in item public notes to be processed on OPAC details Signed-off-by: Claire Gravely Signed-off-by: frederik chenier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 --- Comment #7 from Frédérik Chénier --- Created attachment 91371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91371&action=edit Bug 23194: Fix other occurences Throughout staff client and course reserves we also show the field with HTML filter, maybe we shouldn't? The items lost report also included the note as a title element on title and barcode links, I removed this as the note displays in that table To test: 1 - Add a link to publicnotes for an item Cats! 2 - View opac details, confirm the note is a link 3 - Same for staff side 4 - Add item to a course reserve UseCourseReserves preference must be set to 'Use' From the course reserves module you will need to add a course (and possibly a department first) Adding should be intuitive 5 - Confirm note is a link in course details on staff and opac 6 - Perform a batch checkout, confirm the itemnote shows as a link You will need to enable the system preference: BatchCheckouts and add a patron category to: BatchCheckoutsValidCategories Then a link should be available from checkout for a patron in that category 7 - Mark the item as lost 8 - Go to Reports->Items lost 9 - Confirm the note is a URL and that title and barcode links don't show the note 10 - Click the barcode to go to moredetails for the item - in this case note should display as editable text, not a link Signed-off-by: Claire Gravely Signed-off-by: frederik chenier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22722] Deleting a library leaves the letters and shows them belonging to "All libraries"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22722 Rogan Hamby changed: What|Removed |Added CC||rogan.ha...@gmail.com --- Comment #2 from Rogan Hamby --- There is definitely a missing foreign key. Right now with the sample data that is loaded if you have a test system letter entries have an empty space to get around the NOT NULL constraint. It's fairly straight forward to add the FK but (and I ask this as someone new to looking to contribute more to Koha) how does the community view adding this? It would break the sample data and obviously need to be taken into account for upgrade scripts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 91369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91369&action=edit Bug 23272: Adapt controller and tests This patch adapts the controller script for handling authorised values, and the tests to reflect the method names changes. To test: - Verify you can add/delete/edit authorised values with/without branch limitations, as usual => SUCCESS: All works as usual! - Run: $ kshell k$ prove t/db_dependent/AuthorisedValues.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 91368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91368&action=edit Bug 23272: Make Koha::AuthorisedValue use Koha::Object::Limit::Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 Maryse Simard changed: What|Removed |Added Attachment #91140|0 |1 is obsolete|| --- Comment #12 from Maryse Simard --- Created attachment 91367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91367&action=edit Bug 13597: Make staff client amazon no image results match opac Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16825] Add API route for getting an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Bouzid Fergani changed: What|Removed |Added CC||bouzid.ferg...@inlibro.com --- Comment #44 from Bouzid Fergani --- Hi, Thanks to rebase this patch. Bug 16825 - Add API route for getting an item 91124 - Bug 16825: Add API route for getting an item Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16825: Add API route for getting an item Using index info to reconstruct a base tree... M api/v1/swagger/definitions.json M api/v1/swagger/paths.json Falling back to patching base and 3-way merge... Auto-merging api/v1/swagger/paths.json CONFLICT (content): Merge conflict in api/v1/swagger/paths.json Auto-merging api/v1/swagger/definitions.json error: Failed to merge in the changes. Patch failed at 0001 Bug 16825: Add API route for getting an item The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16825-Add-API-route-for-getting-an-item-uUF0c9.patch Bouzid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613
Bouzid Fergani changed:
What|Removed |Added
CC||bouzid.ferg...@inlibro.com
Status|Signed Off |Patch doesn't apply
--- Comment #16 from Bouzid Fergani ---
Hi Josef,
When applying the patch, I have sha1.
Bug 22613 - Add /patrons/patron_id/checkouts endpoints
88450 - Bug 22613: Add /patrons/{patron_id}/checkouts endpoint to REST API
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 22613: Add /patrons/{patron_id}/checkouts endpoint to REST API
fatal: sha1 information is lacking or useless (api/v1/swagger/paths.json).
error: could not build fake ancestor
Patch failed at 0001 Bug 22613: Add /patrons/{patron_id}/checkouts endpoint to
REST API
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-22613-Add-patronspatronidcheckouts-endpoint-to-SKP48A.patch
Thanks.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #31 from Maryse Simard --- Applying: Bug 22630: Allow to change homebranch in course reserves Using index info to reconstruct a base tree... M C4/CourseReserves.pm M t/db_dependent/CourseReserves/CourseItems.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/CourseReserves/CourseItems.t CONFLICT (content): Merge conflict in t/db_dependent/CourseReserves/CourseItems.t Auto-merging C4/CourseReserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 22630: Allow to change homebranch in course reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Frédérik Chénier changed: What|Removed |Added Attachment #91360|0 |1 is obsolete|| --- Comment #7 from Frédérik Chénier --- Created attachment 91366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91366&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett Signed-off-by: Nadine Pierre Signed-off-by: frederik chenier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Frédérik Chénier changed: What|Removed |Added Attachment #91295|0 |1 is obsolete|| --- Comment #6 from Frédérik Chénier --- Created attachment 91365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91365&action=edit Bug 22951: Markup error in OPAC holds template This patch makes minor markup changes to the OPAC holds template in order to fix validation errors. To test, apply the patch and go through the process of placing a hold in the OPAC. Test various aspects of the process, including cases where the hold is blocked and an error message is displayed (for instance, when there are no items to be placed on hold). The page should work correctly and validating the source should return no relevant errors. Signed-off-by: Mark Tompsett Signed-off-by: frederik chenier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #20 from Bouzid Fergani --- Created attachment 91363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91363&action=edit Bug 22540: Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a -p -su -sp -l --patron --item -m hold 2) Note the hold was placed in Koha Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=22330 Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #21 from Bouzid Fergani --- Created attachment 91364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91364&action=edit Bug 22540: (QA follow-up) fixes borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is via hashref Add ability to specify the pickup location using a command line parameter Signed-off-by: Liz Rea https://bugs.koha-community.org/show_bug.cgi?id=22330 Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246
Maryse Simard changed:
What|Removed |Added
Attachment #91155|0 |1
is obsolete||
--- Comment #6 from Maryse Simard ---
Created attachment 91362
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91362&action=edit
Bug 23246: (follow-up) Hardcoding tab position is not enough
There are many conditions that determine the tab number for 'media'.
Translated into variables that hold the tabs count on each condition, it
is clear that '3' was not good enough:
[%- holdings = (SeparateHoldings) ? 2 : 1
notes = (MARCNOTES || notes) ? 1 : 0
acq = (Koha.Preference('AcquisitionDetails')) ? 1 : 0
frbr = (FRBRizeEditions && XISBNS) ? 1 : 0
local_covers = (LocalCoverImages && (localimages ||
CAN_user_tools_upload_local_cover_images)) ? 1 : 0
media_tab = holdings + notes + acq + frbr + local_covers
-%]
This patch gets rid of the hardcoded value, adds an id to the 'media'
tab (i.e. 'media_tab') and uses JS to get the right index.
To test:
- Play with the different options governing those variables
=> FAIL: 3 is not always the 'media' tab
- Apply this patch
- Repeat your tests
=> SUCCESS: It always picks the 'media' tab
- Sign off :-D
Sponsored-by: American Numismatics Society
Signed-off-by: Maryse Simard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Maryse Simard changed: What|Removed |Added Attachment #91154|0 |1 is obsolete|| --- Comment #5 from Maryse Simard --- Created attachment 91361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91361&action=edit Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set to This patch makes jumping into the third tab happen only if HTML5MediaEnabled is set to 'both' or 'staff'. To test: - Have HTML5MediaEnabled set to 'opac' or 'not at all' - Open the detail page of a record with no holdings => FAIL: The 'images' tab is selected - Apply this patch - Reload => SUCCESS: The 'holdings' tab is selected as it should be. - Sign off :-D Sponsored-by: America Numismatic Society Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271 Tomás Cohen Arazi changed: What|Removed |Added Depends on||17755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22951] Markup error in OPAC holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22951 Nadine Pierre changed: What|Removed |Added Attachment #91296|0 |1 is obsolete|| --- Comment #5 from Nadine Pierre --- Created attachment 91360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91360&action=edit Bug 22951: (follow-up) Fix indentation This patch fixes indentation related to the markup corrections in the previous patch. It contains no textual changes. Signed-off-by: Mark Tompsett Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271 [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 Tomás Cohen Arazi changed: What|Removed |Added Blocks||23272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 Tomás Cohen Arazi changed: What|Removed |Added Depends on||17755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23272] New: Koha::AuthorisedValue should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272 Bug ID: 23272 Summary: Koha::AuthorisedValue should use Koha::Object::Limit::Library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Koha::Patron::Attribute::Type should be used as example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23271] New: Koha::Patron::Category should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271 Bug ID: 23271 Summary: Koha::Patron::Category should use Koha::Object::Limit::Library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Koha::Patron::Attribute::Type should be used as example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Bouzid Fergani changed: What|Removed |Added Attachment #91354|0 |1 is obsolete|| --- Comment #19 from Bouzid Fergani --- Created attachment 91358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91358&action=edit Bug 21824: Add tests Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23192] Cancelling holds over returning to wrong tab on waitingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23192 Maryse Simard changed: What|Removed |Added Attachment #90942|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 91359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91359&action=edit Bug 23192: Correct tab input on waiting_holds.inc To test: 1 - Place 2 holds 2 - Confirm the holds 3 - In the db change the expiration date: UPDATE reserves SET expirationdate = '2019-01-01'; 4 - Go to Home->Circulation->Holds awaiting pickup 5 - View your holds on the 'Holds waiting over' tab 6 - Inspect the cancel button for one of the holds, note tab = "holdswaiting" 7 - Apply patch 8 - Refresh the page 9 - Inspect the buttton, note tab = "holdsover" 10 - Cancel the hold 11 - Note you return to the holds over tab Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #18 from Bouzid Fergani --- Created attachment 91357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91357&action=edit Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatted dates in TT variable Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Bouzid Fergani changed: What|Removed |Added Attachment #91355|0 |1 is obsolete|| --- Comment #17 from Bouzid Fergani --- Created attachment 91356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91356&action=edit Bug 21824: Add ability to format dates in various formats in templates This patch adds the ability to set a date format for the Template Toolkit filter KohaDates Test plan: 1) Apply this patch 2) In a template, use the filter param "dateformat => 'iso'" 3) Note the output is in ISO format Signed-off-by: Owen Leonard Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #16 from Bouzid Fergani --- Created attachment 91355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91355&action=edit Bug 21824: Add ability to format dates in various formats in templates This patch adds the ability to set a date format for the Template Toolkit filter KohaDates Test plan: 1) Apply this patch 2) In a template, use the filter param "dateformat => 'iso'" 3) Note the output is in ISO format Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 --- Comment #19 from Katrin Fischer --- Started a wiki page too... content to be added ;) https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Bouzid Fergani changed: What|Removed |Added Attachment #82879|0 |1 is obsolete|| Attachment #82880|0 |1 is obsolete|| Attachment #83188|0 |1 is obsolete|| --- Comment #15 from Bouzid Fergani --- Created attachment 91354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91354&action=edit Bug 21824: Add tests Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23214] OPAC add ability to pay guarantees fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 --- Comment #3 from Tomás Cohen Arazi --- Maybe because of bug 23115 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23214] OPAC add ability to pay guarantees fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Arthur Bousquet changed: What|Removed |Added CC||arthur.bousq...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Arthur Bousquet --- I got these errors when trying to apply the patch fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 23214: Modify account-table.inc to enable payment of guarantees fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23227] Remove type attribute from script tags: Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Frédérik Chénier changed: What|Removed |Added Attachment #91352|0 |1 is obsolete|| --- Comment #4 from Frédérik Chénier --- Created attachment 91353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91353&action=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from
[Koha-bugs] [Bug 23227] Remove type attribute from script tags: Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23227 Bin Wen changed: What|Removed |Added Attachment #91299|0 |1 is obsolete|| --- Comment #3 from Bin Wen --- Created attachment 91352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91352&action=edit Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from
[Koha-bugs] [Bug 23219] Prevent patron delete if holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23219 Arthur Bousquet changed: What|Removed |Added Attachment #91333|0 |1 is obsolete|| --- Comment #9 from Arthur Bousquet --- Created attachment 91351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91351&action=edit Bug 23219: Cancel patrons holds when patron delete Currently deleting a patron deletes all their holds and leaves no record to the "old_reserves" table. Steps to reproduce: - Create a patron - Add holds for patron - Holds are recorded to "reserves" table - Delete patron - Confirm delete =>Patron and all holds are deleted and no record of holds is left in "old_reserves" table This patch displays alert text notifying user that deleting patron cancels all their holds. Holds are cancelled instead of deleting them. This patch also writes stringified datetime to holds cancel log instead of whole datetime object. To test: - Apply this patch - Create a patron - Add holds for patron - Holds are recorded to "reserves" table - Delete patron - Alert text of holds is displayed - Confirm patron delete => Patron is deleted, their holds are cancelled and moved to "old_reserves" table Signed-off-by: Owen Leonard Signed-off-by: Nadine Pierre Signed-off-by: Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 Bouzid Fergani changed: What|Removed |Added CC||bouzid.ferg...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 Bouzid Fergani changed: What|Removed |Added Attachment #90999|0 |1 is obsolete|| --- Comment #2 from Bouzid Fergani --- Created attachment 91350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91350&action=edit Bug 23204 - script for exporting Elasticsearch mappings Test plan: - launch perl misc/search_tools/export_elasticsearch_mappings.pl > /path/to/my_mappings.yaml - set koha-conf.elasticsearch_index_mappings to /path/to/my_mappings.yaml, - go to admin -> Search engine configuration, - click on "Reset mappins", - check that your search fields and mappings are as expected Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #84 from Tomás Cohen Arazi --- Rebased on top of master, and added minor follow-ups for the failing tests. All of them because of the L -> LOST change. Solid work, Martin. Congrats! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23078] Use Koha.Preference in OPAC global header include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23078 Nadine Pierre changed: What|Removed |Added Attachment #90936|0 |1 is obsolete|| --- Comment #8 from Nadine Pierre --- Created attachment 91349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91349&action=edit Bug 23078: Use Koha.Preference in OPAC global header include This patch updates the OPAC's doc-head-close.inc so that it uses 'Koha.Preference' syntax to output system preference data. The patch removes handling of two preferences from Auth.pm which which are covered by this template change. This patch also makes some minor changes to consolidate multiple template checks for "bidi" To test, apply the patch and test the affected OPAC system preferences: - OpacFavicon - opaclayoutstylesheet - OPACUserCSS - OPACBaseURL Confirm that changes made to these preferences are reflected in the OPAC. Signed-off-by: frederik Signed-off-by: Nadine Pierre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #83 from Tomás Cohen Arazi --- Created attachment 91348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91348&action=edit Bug 22563: (follow-up) Fix tests in Koha/Account.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #82 from Tomás Cohen Arazi --- Created attachment 91347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91347&action=edit Bug 22563: Typo in query (manualinvoice) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #81 from Tomás Cohen Arazi --- Created attachment 91346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91346&action=edit Bug 22563: (QA follow-up) Correction to DB update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #73 from Tomás Cohen Arazi --- Created attachment 91338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91338&action=edit Bug 22563: Be more descriptive with accountypes Convert 'L' to 'LOST' to become more descriptive in it's use. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #78 from Tomás Cohen Arazi --- Created attachment 91343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91343&action=edit Bug 22563: (follow-up) Clean up remaing L, LR and CR cases in the database Test plan: 1) Confirm that after the DB update there are no L, LR or CR accountlines present. 2) Read the db update and confirm is makes sense. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #75 from Tomás Cohen Arazi --- Created attachment 91340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91340&action=edit Bug 22563: (follow-up) Corrections for tests Updates to unit tests to reflect the accounttype changes and introduction of status usage. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #79 from Tomás Cohen Arazi --- Created attachment 91344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91344&action=edit Bug 22563: (QA follow-up) Use issue_id in chargelostitem C4::Accounts::chargelostitem contained a FIXME which asked if an item should be charged for it lost, returned and then lost again. We add handling for that case here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #77 from Tomás Cohen Arazi --- Created attachment 91342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91342&action=edit Bug 22563: (follow-up) Corrections for overdue tests Updates to unit tests to reflect the accounttype changes and introduction of status usage for _FixOverduesOnReturn. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #80 from Tomás Cohen Arazi --- Created attachment 91345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91345&action=edit Bug 22563: (QA follow-up) Catch LOST maninvoice cases One could add a manual invoice of type LOST but we would not associate it with an issue_id. This patch tries to catch such cases and extrapolate an issue_id to add to the accountline. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #76 from Tomás Cohen Arazi --- Created attachment 91341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91341&action=edit Bug 22563: (follow-up) Items LOST should not be RETURNED Up until now we marked lost items as returned in the accountlines, now we have the oportunity to mark these distinctly with an appropriate status we should. Test Plan 1) Find an overdue with fines 2) Ensure you are not forgiving fines when an item is marked as lost 3) Mark the item as lost 4) Confirm the Fine is given a status of 'Lost' Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #74 from Tomás Cohen Arazi --- Created attachment 91339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91339&action=edit Bug 22563: Update lost handling to use accountline.status Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90330|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff client includes 1/2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Nadine Pierre changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||nadine.pie...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90333|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90332|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90335|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90334|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90632|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90331|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90637|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90667|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22957] Remove type attribute from script tags: Staff client includes 1/2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 Nadine Pierre changed: What|Removed |Added Attachment #89950|0 |1 is obsolete|| --- Comment #4 from Nadine Pierre --- Created attachment 91337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91337&action=edit Bug 22957: Remove type attribute from script tags: Staff client includes 1/2 This patch removes the "type" attribute from
