[Koha-bugs] [Bug 22820] Display 830 series information when there is no 490 tag (MARC21)

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22820

--- Comment #11 from Katrin Fischer  ---
(In reply to David Cook from comment #9)
> I'm looking at series at the moment as well, and thinking that
> 800/810/811/830 shouldn't be dependent on the 490. 
> 
> The current way we do it is problematic anyway. The 490 is a repeatable
> field, but we're testing if there is any 490 with a first indicator of 1.
> That doesn't really make sense.

I guess we could turn the logic... still show 490 dependent on indicator, but
always show the 8xx?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22820] Display 830 series information when there is no 490 tag (MARC21)

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22820

--- Comment #10 from Katrin Fischer  ---
The current logic follows this (if I am not completely mistaken), which is
based on the data I was working with and how I understand the standard:

If it's a traced series (1st indicator =1), there will be a 490 + 8xx couple of
fields. In this case we display the information from 8xx. One main reason being
that the $w subfield used to link to a traced series record is only present in
8xx.

If the series is not traced (1st ind = 0), there is no corresponding 8xx, so we
display the information in 490.

If we changed this to display always 490 independent of the indicator
(traced/untraced) a lot of information would show doubled up, once linked by
phrase search and once by record control-number (if it exists like in our
case).

The solution would be to make sure if there is a corresponding 8xx for a 490
and make the decision based on that. One record can have multiple traced and
untraced 490 entries in whatever sequence. I am really not sure how to make
this work with XSLT means. Looking at the LOC page, $a don't have to match and
there is even an example with one 490 and 2 corresponding 8xx.

-- 

http://www.loc.gov/marc/bibliographic/bd490.html
0 - Series not traced
No series added entry is desired for the series. 

1 - Series traced
When value 1 is used, the appropriate field 800-830 is included in the
bibliographic record to provide the series added entry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23172] Issuingrules not checked when returning item and allocating to bib-level holds

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172

Alex Buckley  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4850] CheckReserves does not respect holds circulation policies

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

--- Comment #10 from Alex Buckley  ---
Hi all, 

I have written a related fix to what Ian wrote on this bug report. Mine is
slightly different in that it checks the issuingrules database table to check
the reservesallowed, holds_per_record, holds_per_day for a specific patron
category/itemtype combination. 

This addresses Hugh's point as in my fix the return of an item now checks and
respects the more granular hold rule on different patron category/item type
combinations.

Ian's patch will be great for checking blanket branch/itemtype combinations as
it calls/checks C4::Circulation::GetBranchItemRule but it will not
check/respect patron category/item type combination rules defined in the
issuingrules table. 

If you could take a look at and if possible test Bug 23172 (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 ) that would be
wonderful and much appreciated.

Many thanks, 
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23218] Batch patron modification empty attribute causes improper handling of values

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218

--- Comment #5 from David Cook  ---
(In reply to Katrin Fischer from comment #4)
> value="poeut" ?

That does look pretty weird...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12991] XSLT displaying the 490, rather than the 830

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12991

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
This is an old one, but it does look like the links for series are error-prone. 

I think that this is more to do with issues around indexing and searching,
which I'm investigating at the moment, and asking for help from Indexdata about
how Zebra's internals function exactly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22820] Display 830 series information when there is no 490 tag (MARC21)

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22820

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #9 from David Cook  ---
I'm looking at series at the moment as well, and thinking that 800/810/811/830
shouldn't be dependent on the 490. 

The current way we do it is problematic anyway. The 490 is a repeatable field,
but we're testing if there is any 490 with a first indicator of 1. That doesn't
really make sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22098] Update stocknumberAV cataloguing plugin

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22098

--- Comment #2 from M. Tompsett  ---
Created attachment 91421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91421=edit
Bug 22098: (follow-up) fix grammar/formating Perldoc

- nubers => numbers
- some vertical spacing
- !}fmt -w65
- "contains of letters" => "containing letters"

TEST PLAN
-
perldoc cataloguing/value_builder/stocknumberAV.pl
apply patch
perldoc cataloguing/value_builder/stocknumberAV.pl
-- after the patch is more readable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23283] cannot view/edit additional attributes in 18.11.x

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283

--- Comment #2 from M. Tompsett  ---
Created attachment 91420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91420=edit
Bug 23283: Counter patch modifying the template

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23283] cannot view/edit additional attributes in 18.11.x

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283

--- Comment #1 from Lucas Gass  ---
Created attachment 91419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91419=edit
Bug 23283: cannot view/edit additional attributes in 18.11.x

TEST PLAN:
1. setup some additional patron attributes.
2. go to the patron details and add/edit "Additional attributes and
identifiers"
3. see that no additional attributes show
4. apply patch
5. go to the patron details and add/edit "Additional attributes and
identifiers"
6. additional attributes should show now

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23283] cannot view/edit additional attributes in 18.11.x

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22910] Unique attributes should not be copied when duplicating a patron

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910

Lucas Gass  changed:

   What|Removed |Added

 Blocks||23283


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283
[Bug 23283] cannot view/edit additional attributes in 18.11.x
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23283] cannot view/edit additional attributes in 18.11.x

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283

Lucas Gass  changed:

   What|Removed |Added

 Depends on||22910


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22910
[Bug 22910] Unique attributes should not be copied when duplicating a patron
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23283] New: cannot view/edit additional attributes in 18.11.x

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23283

Bug ID: 23283
   Summary: cannot view/edit additional attributes in 18.11.x
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

TO TEST:

1. setup some additional patron attributes.
2. go to the patron details and add/edit "Additional attributes and
identifiers"
3. see that no additional attributes show

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification and Batch Item Deletion

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282

--- Comment #1 from Kelly McElligott  ---
I can say that if one has a batch of 100 barcodes and 1 item has a value in the
Source of Acquisitions, then this column will appear and the items that don't
have a value in them, the column will still appear.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23282] New: Show all columns in Batch Item Modification and Batch Item Deletion

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282

Bug ID: 23282
   Summary: Show all columns in Batch Item Modification and Batch
Item Deletion
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Currently when using either the Batch Item Modification or Batch Item Deletion,
columns will only appear if there is in fact data in these fields.  IF there is
no value in the Source of Acquisition (for example) field, then the column does
not appear with a blank value in it.  Libraries may want to see all columns
with blank data for double checking purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20864] Only set bibs_selected cookie when BrowseResultSelection is activated

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20864

--- Comment #11 from Owen Leonard  ---
Anyone have an opinion on whether I should work on backporting this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842

Martin Renvoize  changed:

   What|Removed |Added

   Target Milestone|Oldversions |---

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #15 from Owen Leonard  ---
I cannot recreate this problem in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246

--- Comment #13 from Tomás Cohen Arazi  ---
This report tries to deal with:
- The template not respecting whether the HTML5MediaEnabled syspref is set to
display the 'Media' tab, and makes the third tab to get selected

This was intended to work like this:
- You have HTML5MediaEnabled set to display the media tab
- The record has no items, then jump to the third tab

This is wrong because there are many situations that would yield to wrong tabs
being selected, see #c2. Most of them are not trivial to reproduce, probably.
But the most basic, having HTML5MediaEnabled disbaled, clearly fails.

So the patches attached:
- Check if we really have HTML5MediaEnabled set to display in the staff
interface
- Assing an identifiable ID to the 'media' tab, so instead of a hardcoded tab
index, it 'does the right thing'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22209] Move stock rotation stage and item forms into modals

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209

--- Comment #1 from Owen Leonard  ---
Created attachment 91418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91418=edit
Bug 22209: Move stock rotation stage and item forms into modals

This patch makes a number of interface changes to the Stock Rotation
management interface:

 - "Add stage" and "Add items" forms are now triggered by clicking new
   buttons in the toolbar.
 - "Manage stages" and "Manage items" menu items have been added to a
   sidebar menu to be displayed when stages or items are being managed.
 - JavaScript has been added to move focus to the first form field in
   the modal when it is displayed. The "autofocus" attribute is not
   sufficent here because the modal is hidden by default.
 - Add messages to be shown when there are no items or stages to be
   displayed.
 - Correct "selected" attributes to use XHTML-style: selected="selected"
  (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates)

To test, apply the patch and go to Tools -> Stock rotation.

 - Create a rota if you don't already have one.
   - Manage stages for your rota.
 - If your rota has no stages you should see a message along with an
   "Add stage" button. The button should trigger the "Add stage"
   modal.
 - Test the "Add stage" button in the toolbar. It should trigger a
   modal dialog containing the form for adding a new stage. The
   cursor focus should automatically be on the "library" field.
 - Submitting the form should correctly add the stage.
 - Verify that there is a new menu in the sidebar, "Manage stages"
   and "Manage items."
   - Manage items for your rota.
 - If your rota has no items you should see a message along with an
   "Add items" button. The button should trigger the "Add items"
   modal.
 - Test the "Add items" button in the toolbar. It should trigger a
   modal dialog containing the form for adding new items. The cursor
   focus should automatically be on the "barcode" field.
 - Submitting either a barcode or a file of barcodes should work
   correctly.
 - Verify that the new menu items are shown in the sidebar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22209] Move stock rotation stage and item forms into modals

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22209

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #12 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #10)
> It appears to work for me without the follow-up.
You need to have more than 3 tabs to highlight the bug.

1) Enable 'localcover', have 'HTML5MediaEnabled' and 'HTML5MediaYouTube'
disabled
2) Search for 'a' on the staff interface
3) Pick a record with no items
=> FAIL: The detail page jumps to the 'Images' tab.
4) Apply this patches
5) Run (same command in kohadevbox and koha-testing-docker):
  $ restart_all
6) Reload the detail page
=> SUCCESS: The 'Holdings' tab is selected
7) On a separate staff interface tab, enable HTML5MediaEnabled and
HTML5MediaYouTube (for the staff interface) <- I used YouTube so it is easier
8) Edit the MARC record, put a valid Youtube link on the 856$u field. Save.
=> SUCCESS: The detail page has the 'Media' tab picked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||23281


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281
[Bug 23281] Add Koha::Objects::Limit::Library
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com
 Blocks||23272, 23271

--- Comment #4 from Tomás Cohen Arazi  ---
Note to testers: Koha::Patron::Attribute::Tyes->search is not actually used in
the code. It should be used for getting rid of C4::AttributeTypes. Once we have
a clear idea about this patchset, this tasks could be done easily during this
release cycle.

I have already filed bug 23272 and bug 23271, that would benefit from this dev.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23271
[Bug 23271] Koha::Patron::Category should use Koha::Object::Limit::Library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272
[Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||23281


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281
[Bug 23281] Add Koha::Objects::Limit::Library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 91415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91415=edit
Bug 23281: Add Koha::Objects::Limit::Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 91417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91417=edit
Bug 23281: Cleanup Koha::Patron::Attribute::Types->search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 91416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91416=edit
Bug 23281: Implement ->search_with_library_limits in
Koha::Patron::Attribute::Types

This patch makes Koha::Patron::Attribute::Types inherit from
Koha::Objects::Limit::Library so it now has the
->search_with_library_limits method.

Tests are adjusted so it is clear that there is no behaviour change
compared to the (previsouly) called ->search

To test:
- Run:
 k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests still pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254

--- Comment #10 from M. Tompsett  ---
Created attachment 91414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91414=edit
Bug 20254: Add tests for transport ingest

Add test framework for Koha::Edifact::Transport
Add specific test that ingest does not duplicate
an existing filename

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254

--- Comment #9 from M. Tompsett  ---
Created attachment 91413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91413=edit
Bug 20254: Set correct member in working_directory

Koha::Edifact::Transport working_directory was setting the
wrong member name correct that
method is only used in testing

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254

M. Tompsett  changed:

   What|Removed |Added

  Attachment #83013|0   |1
is obsolete||
  Attachment #83014|0   |1
is obsolete||
  Attachment #83015|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 91412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91412=edit
Bug 20254: Do not ingest files with duplicate filenames

If the supplier delivers the same file twice we are
unable to rename it on the second occurence causing us to download
and process it infinitely.

Check that downloaded filenames are unique against those
on file and reject processing if a duplicate.

This patch delays this check to the ingest stage so that the
same code is processed irrespective of transport

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20254] Forbid the download of duplicate EDI messages

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20254

--- Comment #7 from M. Tompsett  ---
Comment on attachment 83014
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83014
Patch working_directory method

Review of attachment 83014:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20254=83014)
-

technically beyond scope of this bug, I think, but hey, valid fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s)

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23281


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281
[Bug 23281] Add Koha::Objects::Limit::Library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||17755
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755
[Bug 17755] Introduce Koha::Patron::Attribute::Type(s)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23281] New: Add Koha::Objects::Limit::Library

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Bug ID: 23281
   Summary: Add Koha::Objects::Limit::Library
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Add a generic class that can be used to add ->search_with_library_limits method
to classes that already rely on Koha::Object::Limit::Library, but handle
searching with limits manually.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23280] Warning in t/db_dependent/selenium/patrons_search.t

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23280

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23280] Warning in t/db_dependent/selenium/patrons_search.t

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23280

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23280] Warning in t/db_dependent/selenium/patrons_search.t

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23280

--- Comment #1 from Martin Renvoize  ---
Created attachment 91411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91411=edit
Bug 23280: Silence warning

Corrects a typo in t/db_dependent/selenium/patrons_search.t introduced
by bug 22781.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23280] Warning in t/db_dependent/selenium/patrons_search.t

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23280

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from Martin Renvoize  ---
Trivial typo caught whilst working through Jenkins failures.. going straight
for a push on this one..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23280] New: Warning in t/db_dependent/selenium/patrons_search.t

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23280

Bug ID: 23280
   Summary: Warning in t/db_dependent/selenium/patrons_search.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

There's a warning thrown when running t/db_dependent/selenium/patrons_search.t
which should not be thrown (Clear Typo introduced with bug 22781

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21206] C4::Items - Remove GetItem

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Martin Renvoize  changed:

   What|Removed |Added

   Target Milestone|19.05   |---
 Blocks||22877


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877
[Bug 22877] Returning a lost item not marked as returned can generate
additional overdue fines
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22877] Returning a lost item not marked as returned can generate additional overdue fines

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22877

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||21206


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
[Bug 21206] C4::Items - Remove GetItem
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23279] In news management interface, sort news by publication date descending

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23279

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23279] In news management interface, sort news by publication date descending

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23279

--- Comment #1 from Owen Leonard  ---
Created attachment 91410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91410=edit
Bug 23279: In news management interface, sort news by publication date
descending

This patch makes a few changes to the configuration of the DataTable
showing news items in the staff client. It adds a default sort on
"Publication date," descending; It updates the way non-sortable columns
are configured; It modifies sorting on the title and content columns so
that articles are ignored.

To test, apply the patch and go to Tools -> News.

 - When the page loads the table of news items should sort by default on
   publication date, descending.
 - There should be no sorting indicator on the first and last columns.
 - When sorting the "Title" or "News" columns, articles "A," "An," and
   "The" should be ignored.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177

--- Comment #8 from M. Tompsett  ---
Comment on attachment 77574
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77574
Bug 21177: Use koha-conf.xml in misc/devel/update_dbix_class_files.pl

Review of attachment 77574:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=21177=77574)
-

::: misc/devel/update_dbix_class_files.pl
@@ +61,5 @@
> +print STDERR "Error: KOHA_CONF is not defined\n";
> +exit(1);
> +}
> +
> +$koha_conf ||= $ENV{KOHA_CONF};

I think comment #6 was about putting this kind of line above line 59, and then
perhaps just check if ($koha_conf) in 59.
This way $koha_conf can default to the environment variable if koha-conf isn't
explicitly stated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23279] New: In news management interface, sort news by publication date descending

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23279

Bug ID: 23279
   Summary: In news management interface, sort news by publication
date descending
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Right now in Tools -> News the table of news items is sorting by default on the
first column because no specific column is configured in the DataTable
initialization. Rather than sorting on the first column (a column of
checkboxes) I think it should sort on publication date descending.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

--- Comment #16 from Victor Grousset/tuxayo  ---
(In reply to Séverine Queune from comment #15)
> Unfortunately, I’m really bad at regular expressions (but this feature is to
> good motivation to learn !), do you have some examples or reference pages to
> test further ?

Thanks for your interest in this :)

You can try the following regex «s/foo/bar/g»
In the content of the subfield, it will replace every occurrences of «foo» by
«bar»

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22449] Improve Elastic search facet setting UI

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449

Martin Renvoize  changed:

   What|Removed |Added

   Target Milestone|19.05   |---

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514

--- Comment #7 from Owen Leonard  ---
Created attachment 91409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91409=edit
Bug 11514: Untranslatable "Uncertain" text in acq

This patch modifies two pages so that the "Uncertain price" information
is shown by the template rather than the Perl script, making the text
translatable.

To test, apply the patch and go to Acquisitions.

 - Locate or create an order in a basket which has an uncertain price.
 - When viewing the contents of that basket the order which was marked
   as having an uncertain price should be labeled "Uncertain."
 - The same should be true for the invoice page. If you don't have an
   existing invoice with an "uncertain" order,
   - Go to "Receive shipments" for the vendor your "uncertain" order is
 with.
   - Create a new invoice.
   - Receive one or more orders which has an uncertain price.
   - Press the "finish receiving" button.
   - In the "Invoice details" section of the invoice page you should
 see the "Uncertain" label on the correct order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23141] The Debian scripts do not use the myql portnumber

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23141

Andreas Jonsson  changed:

   What|Removed |Added

  Attachment #91300|0   |1
is obsolete||

--- Comment #14 from Andreas Jonsson  ---
Created attachment 91408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91408=edit
Bug 23141: Add option to select db credentials source when populating db.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23278] Reopen last panel upon "Save and continue" in notices

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23278

--- Comment #1 from Owen Leonard  ---
Created attachment 91407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91407=edit
Bug 23278: Reopen last panel upon "Save and continue" in notices

This patch modifies the Notices edit process so that if the user chooses
the "Save and continue" option the page reloads with the same panel open
which they were previously editing in.

To test, apply the patch and go to Tools -> Notices and Slips.

 - Open a notice for editing.
 - Expand one of the sections.
 - Choose "Save and continue" from the button menu in the toolbar.
   - When the page reloads, the section you expanded should be open
 again.
 - Test each section and test with no sections expanded.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23278] Reopen last panel upon "Save and continue" in notices

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23278

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23278] New: Reopen last panel upon "Save and continue" in notices

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23278

Bug ID: 23278
   Summary: Reopen last panel upon "Save and continue" in notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Depends on: 18847

In notices, when using the "Save and continue" option, the user should be
redirected back to the editing page with the same panel open which they were
previously editing.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847
[Bug 18847] Add "Save and continue" option to notice editing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18847] Add "Save and continue" option to notice editing

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847

Owen Leonard  changed:

   What|Removed |Added

 Blocks||23278


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23278
[Bug 23278] Reopen last panel upon "Save and continue" in notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17004] REST API: add route to authenticate patron (Single Sign On - SSO)

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Johanna Räisä  changed:

   What|Removed |Added

 CC||johanna.ra...@koha-suomi.fi

--- Comment #29 from Johanna Räisä  ---
(In reply to Martin Renvoize from comment #23)
> I was actually suggesting Koha act as an OAuth/OpenID Connect provider
> rather than just a consumer.
> 
> There's  pretty solid Mojolicious Plugin we could use that gives us a chunk
> of this out of the box:
> https://metacpan.org/pod/Mojolicious::Plugin::OAuth2::Server
> 
> It's using something like this that I'm advocating ;)  So, when logging in
> the user would get directed to a Koha login page and then redirected back to
> whatever SSO consumer they came from.  It's clearer to the user what login
> they should be using and who the original party is that's storing their
> authentication credentials.
> 
> OAuth is of course the 'Authorization' side of the story, we'd still need to
> work out the OpenID Connect side of the story to bring this back down to
> simple 'user identification'.

This would be great for clarity. How about if some service would authenticate
on background like SIP does?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #20 from Josef Moravec  ---
Rebased on master. Thanks for testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613

--- Comment #19 from Josef Moravec  ---
Created attachment 91406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91406=edit
Bug 22613: Add /patrons/{patron_id}/checkouts endpoint to REST API

Test plan:
1) Apply the patch
2) Restart plack
3) Access GET to /patrons/{patron_id}/checkouts
It should have the same abilities as /checkouts?patron_id={patron_id}
4) prove t/db_dependent/api/v1/checkouts.t

Signed-off-by: Michal Denar 
Signed-off-by: Johanna Raisa 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #145 from Cori Lynn Arnold  ---
Alex, I looked at bug 16232.

The left hand box with the targets doesn't exist until this patch, so the issue
is caused by this patch, not that one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23277] Tagging with emoticons wonky in some browsers

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23277

--- Comment #2 from Katrin Fischer  ---
Created attachment 91405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91405=edit
Chrome - colorless, small relaxed, overlapping heart

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23277] Tagging with emoticons wonky in some browsers

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23277

--- Comment #1 from Katrin Fischer  ---
Created attachment 91404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91404=edit
Firefox - small overlapping hearts, colorless relaxed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23277] New: Tagging with emoticons wonky in some browsers

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23277

Bug ID: 23277
   Summary: Tagging with emoticons wonky in some browsers
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When testing the tagging feature, I had some issues adding tags with emojis. 
This seems to be browser specific in part. 2 problem cases:

With Firefox Quantum ESR 60.7.1esr:
- Make sure Tagging is enabled
- Log into OPAC
- Go to a detail page in the OPAC
- Add tag and click on the smiley at the end 
- Choose "heart"
- Verify it doesn't show up in the input field
- Try any of the other emojis - they show up immediately
- Enter heart again - doesn't show up
- Enter 2 spaces after - it shows up but overlaps smiley before and is too
small

With Chrome Version 73.0.3683.103 
- Same as above
- Verify the emoticons are not in color
- Verify some of the emoticons like the heart show up smaller than the others
(also true for one of the smileys: relaxed )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #78 from Arthur Suzuki  ---
Created attachment 91403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91403=edit
Bug 11999: QA follow-up [18.11]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Arthur Suzuki  changed:

   What|Removed |Added

  Attachment #91046|0   |1
is obsolete||

--- Comment #77 from Arthur Suzuki  ---
Created attachment 91402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91402=edit
Bug 11999: QA follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23276] New: Don't show tags on tag cloud when tagging is disabled

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276

Bug ID: 23276
   Summary: Don't show tags on tag cloud when tagging is disabled
 Change sponsored?: ---
   Product: Koha
   Version: 18.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When tagging is disabled, Koha still lets you acces the tags cloud page. It
displays a message that tagging is disabled, but at the same time tags in the
system are displayed:

.../cgi-bin/koha/opac-tags.pl

I think we should handle this like other pages and not have this page
accessible when the feature is diabled. But at least we shoudl not show tags,
that might have been added for testing the feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2635] Allow validation of item fields (price, dates)

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2635

--- Comment #7 from Katrin Fischer  ---
For now I suggest always using the format: 12.00 and avoid commas when entering
monetary information in any spot in Koha. Long term I'd like us to support
different formats, like we do for dates for example. There are 2 different
opinions discussed here: one is an apporach to allow to enter in different
formats and have Koha parse what it means. The other is have the input format
follow the display format. 

And yes, validation would be nice. I was just saying that entering data ,
should be avoided for now to avoid bad behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] Add API route for getting an item

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Michal Denar  changed:

   What|Removed |Added

  Attachment #91399|0   |1
is obsolete||

--- Comment #47 from Michal Denar  ---
Created attachment 91401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91401=edit
Bug 16825: Add API route for getting an item

GET /api/v1/items/{item_id} Gets one Item

This patch adds route to get one item from koha.items table.

To test:
1. Apply patch
2. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
3. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
4. Make sure the returned data is correct.
5. Run unit tests in t/db_dependent/api/v1/items.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Josef Moravec 
Signed-off-by: Johanna Raisa 
Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] Add API route for getting an item

2019-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/