[Koha-bugs] [Bug 23338] Cannot specify replacement price when ordering from file if not using fields to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23338 Katrin Fischer changed: What|Removed |Added Attachment #91672|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 92333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92333&action=edit Bug 23338: Allow specifying order level replacement price when adding to basket from file To test: 0 - Clear MarcFieldsToOrder and MarcItemFieldsToOrder preferences 1 - Have a budget/fund/vendor in acquisitions 2 - Create or find a basket for vendor 3 - Add to basket from a file or staged batch (can use any record) 4 - Note there is no option for replacement price 5 - Add the order 6 - Replacement price is 0 - you must modify order or set upon receiving 7 - Apply patch 8 - Repeat 9 - Disable matchign check during add to basket 10 - Note you can specify a replacement price 11 - Do so 12 - Note it is saved in order Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23338] Cannot specify replacement price when ordering from file if not using fields to order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23338 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23332] Debian package koha-common 18.05.14-1 has a dependency on libperl5.24 which is not available for Ubuntu Bionic 18.04
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23332 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Ian, if you haven't figured out a solution yet I'd suggest asking on the mailing list - many more people reading there and it might give this some more attention. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23457 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 Katrin Fischer changed: What|Removed |Added Summary|Placing holds on multiple |Can't pick the items when |items in a bib record |placing multiple holds on a ||record CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- This currently only works in staff, but if you allow multiple holds via the circulation conditions on the same record, there is a 'Holds to place (count)' counter that you can set to pick the number of items. I am not sure why the radio buttons don't change to checkboxes - maybe because much more logic would need to be implemented to give proper feedback on impossible choices? There is a patch for the OPAC pending too, that implements the checkboxes(!) Bug 15565 - Place multiple holds at once for the same record in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15565 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20380] Email consent patron opt-in tracking for anti-spam legislation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20380 Katrin Fischer changed: What|Removed |Added Version|17.11 |master CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #3) > What about regular use of chars like < and & in a note. > Alice & Bob e.g. becomes now Alice $ Bob > > This might need a bit more thought? I've done some testing too, these were my 500$a: http://www.koha-community.org";>koha http://www.koha-community.org Alice & Bob They all display nicely, with the second already being displayed as a link without the patch(!). So I don't see the breakage Marcel points out. But what breaks is: Berlin With the browser hiding the part . We often see this in older data as it used to be a common cataloguing practice. There are also other use cases for <> like mathematic formulas that we could break display with this change. Note: this also only changes the OPAC, but not the staff display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23466] In some catalogs it does not show the "holding"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23466 --- Comment #3 from Katrin Fischer --- You could note the biblionumber of the record you are looking at and do: select * from items where biblionumber = ... If that gives you results, I'd check next if you are hiding them from display: OpacHiddenItems is a good candidate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 Katrin Fischer changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 --- Comment #2 from Katrin Fischer --- Updating to a bug for now, because if it is a regression, that would be quite bad. Still should be confirmed with further testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23458] Clean up holds template in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Katrin Fischer changed: What|Removed |Added Attachment #92295|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 92331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92331&action=edit Bug 23458: Clean up holds template in the staff client This patch reindents reserve/request.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm no diffctator. Test the process of placing a hold in the staff client: A single hold, multiple holds, etc. Everything should work correctly. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23458] Clean up holds template in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Katrin Fischer changed: What|Removed |Added Attachment #92296|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 92332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92332&action=edit Bug 23458: (follow-up) Add comments to markup This patch adds a few comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16690] Improve security of remote database installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 Katrin Fischer changed: What|Removed |Added Blocks|23470 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23458] Clean up holds template in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16660] Elasticsearch broken if OpacSuppression is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660 Katrin Fischer changed: What|Removed |Added Blocks||23470 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Depends on||16690 --- Comment #1 from Katrin Fischer --- Linking this to a bug that seems to have implemented the correct behaviour, looks like this might be a regression. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 [Bug 16690] Improve security of remote database installations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 Katrin Fischer changed: What|Removed |Added Depends on|16690 |16660 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660 [Bug 16660] Elasticsearch broken if OpacSuppression is activated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 [Bug 16690] Improve security of remote database installations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16690] Improve security of remote database installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 Katrin Fischer changed: What|Removed |Added Blocks||23470 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17057] Remove event attributes from holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Katrin Fischer changed: What|Removed |Added Attachment #92294|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 92330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92330&action=edit Bug 17057: (follow-up) Replace onsubmit attributes This patch removes the "onsubmit" attribute from the place hold form. To test, apply the patch and test placing a hold: Begin the process of placing a hold on a single title. On the place hold screen, uncheck the "Hold next available item" checkbox and click the "Place hold" button. You should be get an alert saying "Please select an item to place a hold." Select an item and click the "Place hold" button again. The hold should be placed. This patch affects the form validation for placing multiple holds, but I don't think the JavaScript ever has a chance to run: The template blocks the user from placing multiple holds if one of the titles has no items. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17057] Remove event attributes from holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Katrin Fischer changed: What|Removed |Added Attachment #92293|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 92329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92329&action=edit Bug 17057: Remove event attributes from holds template My orginal patch for this bug contained a lot of changes made obsolete by Bug 19469, which created holds_table.inc. This new version makes one minor change only to request.tt, adding a class name and removing an onclick attribute. To test, apply the patch and place an item-level hold on a title. Start the process of placing another hold on that item. On the "place hold" screen, in the table of items, you should see a "Cancel hold" link for the item you previously placed on hold. - Click the "Cancel hold" link - Clicking "Cancel" in the confirmation dialog should cancel the operation. - Clicking "OK" should cancel the hold. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17057] Remove event attributes from holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 --- Comment #9 from Katrin Fischer --- Thx Lucas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 --- Comment #4 from Katrin Fischer --- Hi Hemantha, we have tried to look into this, but I am not sure about those 2: 3) Item is renewed, 4) During above step fine amount getting over written on previous overdue of the same item irrespective of dates. When the item is renewed.. is the fine set to 0? Or is it the second renewal? The second time the user has checked out the item? Sorry, but can you maybe add a more complete test plan, I feel like we are missing something :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 --- Comment #3 from Hemantha Rao KR --- (In reply to Katrin Fischer from comment #1) > To clarify, is this the scenario? > > 1) User checks out item > 2) Item goes overdue and accrues fines > 3) Item is renewed, fine is left unpaid > 4) Item goes overdue again - accrues new fines > > In 4) the new fine overwrites the old fine, so that only the new overdue > fine is visible? Please let me know if any more details required. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8778] Add Keyword phrase search to OPAC search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Lucas Gass changed: What|Removed |Added Attachment #92140|0 |1 is obsolete|| --- Comment #8 from Lucas Gass --- Created attachment 92328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92328&action=edit Bug 8778: Add Keyword phrase to OPAC advanced search Adds a new search index to the advanced search in OPAC: Keyword phrase The new search option displays when the "More options" are selected. To test: - Apply patch - Go to Advanced search in OPAC - Look at the search pull downs - Verify everything looks correct - Click "More options" - Verify the Keyword phrase search option shows - Test if it works correctly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14862] Upgrade jQuery from 1.7 to 3.4.1 in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- Is there any test plan for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23448] Clean up subscription detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23448 Maryse Simard changed: What|Removed |Added Attachment #92156|0 |1 is obsolete|| --- Comment #4 from Maryse Simard --- Created attachment 92327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92327&action=edit Bug 23448: (follow-up) Add comments on markup structure This patch adds comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23448] Clean up subscription detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23448 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23448] Clean up subscription detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23448 Maryse Simard changed: What|Removed |Added Attachment #92155|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 92326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92326&action=edit Bug 23448: Clean up subscription detail template This patch makes a number of corrections to the subscription detail page: Re-indented consistently with four spaces. Removed invalid attributes. Added missing . To test, apply the patch and go to Serials. Search for a subscription and view the details page. The page should look correct. Validating the source should return no errors. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #230 from Tomás Cohen Arazi --- Created attachment 92324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92324&action=edit Bug 14570: (QA follow-up) Consistency displaying the list of guarantors Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #229 from Tomás Cohen Arazi --- Created attachment 92323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92323&action=edit Bug 14570: Remove wrong parameter in add_guarantor call This patch just removes an unused parameter. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #231 from Tomás Cohen Arazi --- Created attachment 92325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92325&action=edit Bug 14570: (QA follow-up) Fix tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #228 from Tomás Cohen Arazi --- Created attachment 92322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92322&action=edit Bug 14570: Add error handling to Koha::Patron::Relationship->store This patch adds checks on the values for the 'relationship'. This is done to avoid future problems when migrating relationships from the plain text syspref into (why not) a proper table. And to preserve consistency. There's also catching on possible broken constraints and throwing a new exception Tests are added for both the new exceptions and the changes to Koha::Patron::Relationship. To test: - Apply this patches - Run: $ kshell k$ prove t/Koha/Exceptions.t \ t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Patron/Relationship.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #227 from Tomás Cohen Arazi --- Created attachment 92321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92321&action=edit Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #226 from Tomás Cohen Arazi --- Created attachment 92320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92320&action=edit Bug 14570: (QA follow-up) Fix issues in Guarantor context Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #225 from Tomás Cohen Arazi --- Created attachment 92319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92319&action=edit Bug 14570: (QA follow-up) Fix issues in Guarantee context Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #224 from Tomás Cohen Arazi --- Created attachment 92318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92318&action=edit Bug 14570: Update schema files [Do Not Push] Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #222 from Tomás Cohen Arazi --- Created attachment 92316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92316&action=edit Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid) Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #223 from Tomás Cohen Arazi --- Created attachment 92317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92317&action=edit Bug 14570: (follow-up) Fix patron type when "add child" button is pressed Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #220 from Tomás Cohen Arazi --- Created attachment 92314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92314&action=edit Bug 14570: (follow-up) fix qa FAIL tests Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #221 from Tomás Cohen Arazi --- Created attachment 92315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92315&action=edit Bug 14570: (follow-up) Fix tests Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #219 from Tomás Cohen Arazi --- Created attachment 92313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92313&action=edit Bug 14570: (follow-up) fix table name in j2a.pl Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #218 from Tomás Cohen Arazi --- Created attachment 92312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92312&action=edit Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92311|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92310|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92309|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92308|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92306|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92307|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92301|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92302|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92303|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92304|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92305|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92300|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92299|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23458] Clean up holds template in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Attachment #92298|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23470] New: Elasticsearch - OpacSuppression not implemented in search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 Bug ID: 23470 Summary: Elasticsearch - OpacSuppression not implemented in search result Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-v...@collecto.ca Hi, Records suppressed with OpacSuppression are always displayed in search result with ElasticSearch. If I try to consult the record in detailed view, the blocking message appears however. I read here https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660#c1 : NB: OPAC suppression is not implemented for Elasticsearch Anyone work on it? Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23464] Update the process of quick spine label printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23464 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||maryse.sim...@inlibro.com --- Comment #2 from Maryse Simard --- For me, even with SpineLabelAutoPrint enabled, the print dialog doesn't show automatically. It seems to be because the test for the syspref is inside an [% IF ( IntranetUserJS ) %] block. As a matter of fact, when I try putting some code in IntranetUserJS, the SpineLabelAutoPrint syspref then works as expected. Also, when I search for a barcode that doesn't exist, the pop-up tells me the barcode is not found with a link to go back to the previous page. I think it would be nicer and make more sense if the link would be replaced by a close button (or even removed altogether) since we don't want to go back to the page in the popup window. Maybe a close button looking just like the one for printing when the barcode is found? (I like that button, I think it looks really good) Everything else works perfectly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #217 from Liz Rea --- Created attachment 92311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92311&action=edit Bug 14570: (QA follow-up) Fix tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #216 from Liz Rea --- Created attachment 92310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92310&action=edit Bug 14570: (QA follow-up) Consistency displaying the list of guarantors Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #215 from Liz Rea --- Created attachment 92309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92309&action=edit Bug 14570: Remove wrong parameter in add_guarantor call This patch just removes an unused parameter. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #212 from Liz Rea --- Created attachment 92306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92306&action=edit Bug 14570: (QA follow-up) Fix issues in Guarantor context Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #213 from Liz Rea --- Created attachment 92307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92307&action=edit Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #211 from Liz Rea --- Created attachment 92305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92305&action=edit Bug 14570: (QA follow-up) Fix issues in Guarantee context Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #214 from Liz Rea --- Created attachment 92308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92308&action=edit Bug 14570: Add error handling to Koha::Patron::Relationship->store This patch adds checks on the values for the 'relationship'. This is done to avoid future problems when migrating relationships from the plain text syspref into (why not) a proper table. And to preserve consistency. There's also catching on possible broken constraints and throwing a new exception Tests are added for both the new exceptions and the changes to Koha::Patron::Relationship. To test: - Apply this patches - Run: $ kshell k$ prove t/Koha/Exceptions.t \ t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Patron/Relationship.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #208 from Liz Rea --- Created attachment 92302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92302&action=edit Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid) Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #210 from Liz Rea --- Created attachment 92304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92304&action=edit Bug 14570: Update schema files [Do Not Push] Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #207 from Liz Rea --- Created attachment 92301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92301&action=edit Bug 14570: (follow-up) Fix tests Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #209 from Liz Rea --- Created attachment 92303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92303&action=edit Bug 14570: (follow-up) Fix patron type when "add child" button is pressed Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #206 from Liz Rea --- Created attachment 92300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92300&action=edit Bug 14570: (follow-up) fix qa FAIL tests Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #205 from Liz Rea --- Created attachment 92299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92299&action=edit Bug 14570: (follow-up) fix table name in j2a.pl Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Liz Rea changed: What|Removed |Added Attachment #92279|0 |1 is obsolete|| Attachment #92280|0 |1 is obsolete|| Attachment #92281|0 |1 is obsolete|| Attachment #92282|0 |1 is obsolete|| Attachment #92283|0 |1 is obsolete|| Attachment #92284|0 |1 is obsolete|| Attachment #92285|0 |1 is obsolete|| Attachment #92286|0 |1 is obsolete|| Attachment #92287|0 |1 is obsolete|| Attachment #92288|0 |1 is obsolete|| Attachment #92289|0 |1 is obsolete|| Attachment #92290|0 |1 is obsolete|| Attachment #92291|0 |1 is obsolete|| Attachment #92292|0 |1 is obsolete|| --- Comment #204 from Liz Rea --- Created attachment 92298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92298&action=edit Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23469] Update of fr-CA default MARC21 framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23469 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23469] New: Update of fr-CA default MARC21 framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23469 Bug ID: 23469 Summary: Update of fr-CA default MARC21 framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org Some labeling has changed according to www.marc21.ca. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23353] ACQ framework makes fr-CA web installer explode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23353 --- Comment #8 from Caroline Cyr La Rose --- Created attachment 92297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92297&action=edit Bug 23353: ACQ framework makes fr-CA web installer explode This patch removes the standalone ACQ framework SQL file in the fr-CA directory and adds the ACQ framework creation SQL in the default framework file, as it is in other languages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23353] ACQ framework makes fr-CA web installer explode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23353 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|tomasco...@gmail.com|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23458] Clean up holds template in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Maryse Simard changed: What|Removed |Added Attachment #92243|0 |1 is obsolete|| --- Comment #4 from Maryse Simard --- Created attachment 92296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92296&action=edit Bug 23458: (follow-up) Add comments to markup This patch adds a few comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23458] Clean up holds template in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Maryse Simard changed: What|Removed |Added Attachment #92242|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 92295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92295&action=edit Bug 23458: Clean up holds template in the staff client This patch reindents reserve/request.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm no diffctator. Test the process of placing a hold in the staff client: A single hold, multiple holds, etc. Everything should work correctly. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20847] Add more fields to the Batch Patron Modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847 Katrin Fischer changed: What|Removed |Added Version|17.05 |master CC||katrin.fisc...@bsz-bw.de Summary|Add the fields to the Batch |Add more fields to the |Patron Modification tool|Batch Patron Modification ||tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17057] Remove event attributes from holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Maryse Simard changed: What|Removed |Added Attachment #92179|0 |1 is obsolete|| --- Comment #7 from Maryse Simard --- Created attachment 92294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92294&action=edit Bug 17057: (follow-up) Replace onsubmit attributes This patch removes the "onsubmit" attribute from the place hold form. To test, apply the patch and test placing a hold: Begin the process of placing a hold on a single title. On the place hold screen, uncheck the "Hold next available item" checkbox and click the "Place hold" button. You should be get an alert saying "Please select an item to place a hold." Select an item and click the "Place hold" button again. The hold should be placed. This patch affects the form validation for placing multiple holds, but I don't think the JavaScript ever has a chance to run: The template blocks the user from placing multiple holds if one of the titles has no items. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agustín Moyano changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17057] Remove event attributes from holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17057] Remove event attributes from holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Maryse Simard changed: What|Removed |Added Attachment #92178|0 |1 is obsolete|| --- Comment #6 from Maryse Simard --- Created attachment 92293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92293&action=edit Bug 17057: Remove event attributes from holds template My orginal patch for this bug contained a lot of changes made obsolete by Bug 19469, which created holds_table.inc. This new version makes one minor change only to request.tt, adding a class name and removing an onclick attribute. To test, apply the patch and place an item-level hold on a title. Start the process of placing another hold on that item. On the "place hold" screen, in the table of items, you should see a "Cancel hold" link for the item you previously placed on hold. - Click the "Cancel hold" link - Clicking "Cancel" in the confirmation dialog should cancel the operation. - Clicking "OK" should cancel the hold. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 Agustín Moyano changed: What|Removed |Added Status|BLOCKED |Needs Signoff --- Comment #30 from Agustín Moyano --- Moving this to NOS, for dependency is no longer in ASSIGNED status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Agustín Moyano changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #203 from Agustín Moyano --- Created attachment 92292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92292&action=edit Bug 14570: (QA follow-up) Fix tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #200 from Agustín Moyano --- Created attachment 92289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92289&action=edit Bug 14570: Add error handling to Koha::Patron::Relationship->store This patch adds checks on the values for the 'relationship'. This is done to avoid future problems when migrating relationships from the plain text syspref into (why not) a proper table. And to preserve consistency. There's also catching on possible broken constraints and throwing a new exception Tests are added for both the new exceptions and the changes to Koha::Patron::Relationship. To test: - Apply this patches - Run: $ kshell k$ prove t/Koha/Exceptions.t \ t/db_dependent/Koha/Patron.t \ t/db_dependent/Koha/Patron/Relationship.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #199 from Agustín Moyano --- Created attachment 92288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92288&action=edit Bug 14570: Add a UNIQUE constraint on guarantor_id+guarantee_id Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #202 from Agustín Moyano --- Created attachment 92291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92291&action=edit Bug 14570: (QA follow-up) Consistency displaying the list of guarantors Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #201 from Agustín Moyano --- Created attachment 92290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92290&action=edit Bug 14570: Remove wrong parameter in add_guarantor call This patch just removes an unused parameter. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #198 from Agustín Moyano --- Created attachment 92287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92287&action=edit Bug 14570: (QA follow-up) Fix issues in Guarantor context Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #197 from Agustín Moyano --- Created attachment 92286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92286&action=edit Bug 14570: (QA follow-up) Fix issues in Guarantee context Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
