[Koha-bugs] [Bug 16111] RSS feed for OPAC search results has wrong content type

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #46 from Katrin Fischer  ---
Is html for OpacBaseUrl correct?

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt
   FAIL   filters
missing_filter at line 100 (   )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21058] Missing class for results_summary spans

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #92052|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 92340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92340&action=edit
Bug 21058: Added HTML classes in MARC21slim2_Detail.xsl

This is a very small patch. I've simply added the following classes to
their respective spans in the detail XSLs for both interfaces.

- in_note (773$n)
- preceeding_entry_note (780$n)
- succeeding_entry_note (785$n)

To test:

1. Apply patch
2. Open details page of notice with a 773$n, 780$n or 785$n field
3. Inspect element. The class should be visible.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21058] Missing class for results_summary spans

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #92053|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 92341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92341&action=edit
Bug 21058: Added HTML class to showRDAtag264

Adds the HTML class "rda264" to the span generated by the XSLT function
showRDAtag264.

To test, same as previous, using a notice with a 264 tag. Both patches
only apply to MARC21.

I was unsure how to name the class, so I've chose the simplest, most
explicit name.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21058] Missing class for results_summary spans

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21058

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23435] Add multiple copies of an item when receiving in serials

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23435

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Katrin Fischer  ---
Hi Maryse, I see your sign-off line here - switching to 'signed off'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15497] Limit Item Types by Branch

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||23281
 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Katrin Fischer  ---
I think this shoudl depend on bug 23281?

+use base qw(Koha::Object Koha::Object::Limit::Library);


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281
[Bug 23281] Add Koha::Objects::Limit::Library
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||15497


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497
[Bug 15497] Limit Item Types by Branch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23272] Koha::AuthorisedValue should use Koha::Object::Limit::Library

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #5 from Katrin Fischer  ---
Hi Tomas,

can you please check this one?

 FAIL   Koha/AuthorisedValue.pm
   FAIL   valid
Inconsistent hierarchy during C3 merge of class
'Koha::AuthorisedValue':
current merge results [
Koha::AuthorisedValue,
]
merging failed on 'Koha::Object'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91461|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 92339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92339&action=edit
Bug 23281: Cleanup Koha::Patron::Attribute::Types->search

Signed-off-by: Kyle M Hall 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91459|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 92337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92337&action=edit
Bug 23281: Add Koha::Objects::Limit::Library

Signed-off-by: Kyle M Hall 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91460|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 92338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92338&action=edit
Bug 23281: Implement ->search_with_library_limits in
Koha::Patron::Attribute::Types

This patch makes Koha::Patron::Attribute::Types inherit from
Koha::Objects::Limit::Library so it now has the
->search_with_library_limits method.

Tests are adjusted so it is clear that there is no behaviour change
compared to the (previsouly) called ->search

To test:
- Run:
 k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests still pass!
- Sign off :-D

Signed-off-by: Kyle M Hall 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23281] Add Koha::Objects::Limit::Library

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23281

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23448] Clean up subscription detail template

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23448

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #92327|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 92336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92336&action=edit
Bug 23448: (follow-up) Add comments on markup structure

This patch adds comments to the markup in order to highlight the
structure of the page.

Signed-off-by: Maryse Simard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23448] Clean up subscription detail template

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23448

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #92326|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 92335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92335&action=edit
Bug 23448: Clean up subscription detail template

This patch makes a number of corrections to the subscription detail
page: Re-indented consistently with four spaces. Removed invalid
attributes. Added missing .

To test, apply the patch and go to Serials. Search for a subscription
and view the details page.

The page should look correct. Validating the source should return no
errors.

Signed-off-by: Maryse Simard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23448] Clean up subscription detail template

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23448

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454

--- Comment #6 from Hemantha Rao KR  ---
(In reply to Katrin Fischer from comment #4)
> Hi Hemantha, we have tried to look into this, but I am not sure about those
> 2:
> 
> 3) Item is renewed, 
> 4) During above step fine amount getting over written on previous overdue of
> the same item irrespective of dates.
> 
> When the item is renewed.. is the fine set to 0? 
> Or is it the second renewal? The second time the user has checked out the
> item?
> 
> Sorry, but can you maybe add a more complete test plan, I feel like we are
> missing something :)

Hi Fischer,
Thank you for your prompt response, I have attached screen shot of example for
your reference. The same transactions done in 2 versions of koha viz Koha
3.22.5 & 18.11. You can make out the difference by seeing screen shots.

Hope this will clarify your doubts. Kindly feel free to revert me if any more
details required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one

2019-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454

Hemantha Rao KR  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |hemantharao...@gmail.com
   |ity.org |
 Status|NEW |In Discussion
 CC||hemantharao...@gmail.com

--- Comment #5 from Hemantha Rao KR  ---
Created attachment 92334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92334&action=edit
Test case: Example of Error & correct transaction

Hi,
Uploaded screen shot of error for the reference, hope this will clear doubts.
Please do the needful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/