[Koha-bugs] [Bug 23627] Koha::Biblio->get_coins too noisy if no 245$b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23627 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23627] Koha::Biblio->get_coins too noisy if no 245$b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23627 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23627] Koha::Biblio->get_coins too noisy if no 245$b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23627 Marcel de Rooy changed: What|Removed |Added Attachment #93060|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 93178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93178=edit Bug 23627: Reduce Koha::Biblio->get_coins noise if no 245 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Maryse Simard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9230] Selectively delete reading history entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9230 Michael Spagnuolo changed: What|Removed |Added CC||mspagnu...@nrhtx.com --- Comment #4 from Michael Spagnuolo --- Recently had a patron ask for this. Selective deletion would be a nice improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 Lucas Gass changed: What|Removed |Added Attachment #93167|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 93177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93177=edit Bug 23292: Use TransferSlip when transfering item which is on hold Combining hold and transfer slips might get confusing for patrons. Those represent quite different things. Hold slip could be used on self-service pickup for patrons and transfer slip has information for librarians. There can also be data protection issue if same slip is used in both cases. Test plan: - Apply the patch - Create hold for a record, define pickup branch different than your current branch. - Check in an item from your branch. - Click 'Print slip, transfer, and confirm' - See that the slip is TRANSFERSLIP - Change your branch same as hold's pickup branch - Check in the item again. - Click 'Print slip and confirm' - See that the slip is now HOLD_SLIP Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- I tested this with the latest Firefox and Google Chrome browsers on Ubuntu 18.04. With pop ups allowed for both browsers: - On Firefox the behaviour identified didn't occur, that is: the window opened fine in a new tab (both before and after the patch) - On Google Chrome the behaviour identified occurred and the patch fixed it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 David Nind changed: What|Removed |Added Attachment #93166|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 93176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93176=edit Bug 23680: Incorrect conversion of Perl boolean to js A Perl boolean value is on the server side converted to a JS string (resulting in the values '0' or '1). Since the string '0' is a truthy value in JS this incorrectly triggers window.close() on the client in many instances, for example when adding a new item. To test: 1. Go to a bibliographic record in the staff client. 2. Expand the "New" menu and open "New item" in new tab. 3. The new tab will immediately close. 4. Apply the patch. 5. Perform steps 1-2 again. 6. The tab should now remain open. Sponsored-by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23677] Add route to get a bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #5 from Tomás Cohen Arazi --- I submit this work to gather opinions. I've already thought about extending this with plugins for handling special serialization formats and schemas. This is just the start -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23677] Add route to get a bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 93172
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93172=edit
Bug 23677: OpenAPI spec for GET /biblios/{biblio_id}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23677] Add route to get a bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 93173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93173=edit Bug 23677: Schema fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23677] Add route to get a bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677
--- Comment #4 from Tomás Cohen Arazi ---
Created attachment 93175
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93175=edit
Bug 23677: Unit tests
This patch introduces tests for the GET /biblios/{biblio_id} endpoint.
It tries to cover all the use cases.
To test:
- Apply this patchset
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass!
- Use Postman (or your favourite tool) to test the API
=> SUCCESS: Works as expected!
- Sign off :-D
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23677] Add route to get a bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 93174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93174=edit Bug 23677: Controller method and dependencies tweak -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23677] Add route to get a bibliographic record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17371 CC||josef.mora...@gmail.com, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17371] Add routes for biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23677 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used in a chart when viewing report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Paul Hoffman changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23685 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23624] Count rows in report without (potentially) consuming all memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Paul Hoffman changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23685 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23685] New: Exporting report may consume unlimited memory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23685
Bug ID: 23685
Summary: Exporting report may consume unlimited memory
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Reports
Assignee: koha-bugs@lists.koha-community.org
Reporter: p...@flo.org
QA Contact: testo...@bugs.koha-community.org
In guided_reports.pl, when exporting report results ($phase eq 'Export') all
rows of data are fetched and then converted to the desired format. This may
consume an unlimited amount of memory; when report results are particularly
large, it may consume all available memory, leading to timed-out HTTP requests,
crashes, and potentially data loss. (We have experienced Zebra index
corruption as a result.)
In master, reports/guided_reports.pl supports three export types --
tab-delimited, CSV, or *.ods. In each case, all data are loaded into memory
and held there before any output is produced:
891 $sql = get_prepped_report( $sql, \@param_names, \@sql_params );
892 my ($sth, $q_errors) = execute_query($sql);
...
895 if ($format eq 'tab') {
896 $type = 'application/octet-stream';
897 $content .= join("\t", header_cell_values($sth)) . "\n";
898 $content = Encode::decode('UTF-8', $content);
899 while (my $row = $sth->fetchrow_arrayref()) {
900 $content .= join("\t", @$row) . "\n";
901 }
902 } else {
903 my $delimiter = C4::Context->preference('delimiter') ||
',';
904 if ( $format eq 'csv' ) {
...
914 while (my $row = $sth->fetchrow_arrayref()) {
915 if ($csv->combine(@$row)) {
916 $content .= $csv->string() . "\n";
917 } else {
918 push @$q_errors, { combine =>
$csv->error_diag() } ;
919 }
920 }
921 }
922 elsif ( $format eq 'ods' ) {
...
932 # Other line in Unicode
933 my $sql_rows = $sth->fetchall_arrayref();
934 foreach my $sql_row ( @$sql_rows ) {
935 my @content_row;
936 foreach my $sql_cell ( @$sql_row ) {
937 push @content_row, Encode::encode( 'UTF8',
$sql_cell );
938 }
939 push @$ods_content, \@content_row;
940 }
941
942 # Process
943 generate_ods($ods_filepath, $ods_content);
944
945 # Output
946 binmode(STDOUT);
947 open $ods_fh, '<', $ods_filepath;
948 $content .= $_ while <$ods_fh>;
949 unlink $ods_filepath;
950 }
The *.ods case is particularly problematic, because before any data is sent
back to the user's browser, *three* copies of the full results are sitting in
memory simultaneously -- @$sql_row, @$ods_content, and $content.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Kyle M Hall changed: What|Removed |Added Attachment #93170|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 93171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93171=edit Bug 23682 - Add ability to manually import EDI invoices as an alternative to automatic importing on download Some library would like to delay the importing of invoices until a time of their choosing. The invoices should be imported into the database as they do now, but the invoice processing should be skipped. Instead, any invoice file with a status of 'new' should have an 'Import' button to process the invoice. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref EdifactInvoiceImport 4) Run the edi cronjob to import a new invoice file 5) View EDI messages table at /acqui/edifactmsgs.pl 6) Note the invoice files is not processes, and retains the status of 'new' 7) Use the 'import' button to process the invoice 8) Note the invoice is now marked 'received' and the 'import' button is gone 9) Verify the invoice was actually processes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #1 from ByWater Sandboxes --- Created attachment 93170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93170=edit Bug 23682 - Add ability to manually import EDI invoices as an alternative to automatic importing on download Some library would like to delay the importing of invoices until a time of their choosing. The invoices should be imported into the database as they do now, but the invoice processing should be skipped. Instead, any invoice file with a status of 'new' should have an 'Import' button to process the invoice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 ByWater Sandboxes changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 ByWater Sandboxes changed: What|Removed |Added Attachment #93168|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 93169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93169=edit Bug 23683: Course reserves public notes on specific items should allow for HTML Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23684] New: Import items only with merging rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23684 Bug ID: 23684 Summary: Import items only with merging rule Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: viliam.polo...@snk.sk QA Contact: testo...@bugs.koha-community.org When I try to import items only with record merging rule and with settings Action if matching record found: Ignore incoming record (its items may still be processed) Action if no match found: Ignore incoming record (its items may still be processed) Item processing: Add items only if matching bib was found Matching bib was found but no items was imported. I know that in older version this worked fine so I try 18.05 version items importing is fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #27 from Séverine Queune --- Sorry Jonathan, I tried with : - title only - title + author - title + author + isbn (and other informations) but I never get a warning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 --- Comment #1 from Lucas Gass --- Created attachment 93168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93168=edit Bug 23683: Course reserves public notes on specific items should allow for HTML TEST PLAN: 1. Create A Course Reserve 2. Add an item to that course and include some HTML in the public note feild. 3. Go to the Course details page in the OPAC and Staff Client and observe the table which includes your reserve item. 4. Notice that it displays HTML literally. 5. Apply Patch and restart_all 6. Visit both the course details page again (staff and OPAC) and notice that the HTML renders. 7. Rejoice! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23683] New: Course reserves public notes on specific items should allow for HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 Bug ID: 23683 Summary: Course reserves public notes on specific items should allow for HTML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org BZ22501 allowed librarians to add public notes in HTML to each course but did not allow for the public note on each item in course-items-table to include HTML. Some librarians would like these to also allow for HTML so the can build links. A $raw filter should be used on both the OPAC (#course-items-table) AND the staff client (#course_reserves_table). These notes can only be entered from the staff client so this should be allowable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Kyle M Hall changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] New: Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Bug ID: 23682 Summary: Add ability to manually import EDI invoices as an alternative to automatic importing on download Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Some library would like to delay the importing of invoices until a time of their choosing. The invoices should be imported into the database as they do now, but the invoice processing should be skipped. Instead, any invoice file with a status of 'new' should have an 'Import' button to process the invoice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] New: Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Bug ID: 23681 Summary: Patron restrictions should be user definable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently the patron restrictions are hard coded as enums in borrower_debarments.type, the available values are 'SUSPENSION','OVERDUES','MANUAL','DISCHARGE'. We (PTFS Europe) have a customer requirement to: - Provide a select box when adding a patron restriction containing user defined values for restriction types, the user defined values should be defined as authorised values - Ensure a default value if no restriction type is selected - Allow the name of the default value to be modifiable - Ensure that if a restriction type authorised value is removed, any restrictions that use it should revert to the default value - Make the selection of restriction type optional via a syspref Currently, at the DB level, the default value is 'MANUAL'. The plan is to: DB MIGRATION - Add authorised_value_categories row for 'PATRON_RESTRICTIONS' - Add authorised_values.core, default value 0 - Implies AV cannot be deleted and authorised_values.authorised_value cannot be changed - Add new borrower_debarments.debarment_type column - Select distinct values from borrower_debarments.type - For each $value: - Create AV rows: - authorised_values.authorised_value = $value - authorised_values.lib = $value - authorised_values.core = 1 - ** Note id of each new row, associated with $value - update borrower_debarments.debarment_type to be appropriate AV id - Remove borrower_debarments.type OTHER STUFF --- - AV UI (and anything else that can bring about AV modification), should respect "core" - Modify Patron::Debarments appropriate functions to abstract underlying changes i.e. we maintain backward compatibility with the way they currently work, we just obfuscate the fact that the "type" comes from a different table - Overload AuthorisedValue::delete to allow us to call optional functions after delete - in a sane world this would be a trigger. This will allow us to set appropriate patron_debarments.debarment_type rows to default value upon AV deletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #5 from Fridolin SOMERS --- Maybe hidden items should be removed directly in C4::Items::GetItemsInfo, called by opac-reserve.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23605] Terminology: Branches limitations should be libraries limitations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23605 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|19.11.00|19.11.00,19.05.05 released in|| Status|Pushed to master|Pushed to stable --- Comment #5 from Fridolin SOMERS --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 David Gustafsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23292] Use TransferSlip when transfering item which is on hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23292 Johanna Räisä changed: What|Removed |Added Attachment #91438|0 |1 is obsolete|| --- Comment #3 from Johanna Räisä --- Created attachment 93167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93167=edit Bug 23292: Use TransferSlip when transfering item which is on hold Now the patch should apply to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23566] Continue on device - with QR codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23566 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 --- Comment #2 from David Gustafsson --- I think this bug was introduced in Bug 21091. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23680] Perl string '0' evaluated as javascript boolean triggers window.close() when should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 --- Comment #1 from David Gustafsson --- Created attachment 93166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93166=edit Bug 23680: Incorrect conversion of Perl boolean to js A Perl boolean value is on the server side converted to a JS string (resulting in the values '0' or '1). Since the string '0' is a truthy value in JS this incorrectly triggers window.close() on the client in many instances, for example when adding a new item. To test: 1. Go to a bibliographic record in the staff client. 2. Expand the "New" menu and open "New item" in new tab. 3. The new tab will immediately close. 4. Apply the patch. 5. Perform steps 1-2 again. 6. The tab should now remain open. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23680] New: Perl string '0' evaluated as javascript boolean triggers window.close() when should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680
Bug ID: 23680
Summary: Perl string '0' evaluated as javascript boolean
triggers window.close() when should not
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs@lists.koha-community.org
Reporter: glask...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
In cataloging_additem.inc the javascript variable "popup" is generated as:
var popup = '[% popup | html %]';
So popup will be either '0' or '1'. '0' is a truthy value in javascript, so
popup will always be evaluated as true making this condition:
if( popup && op != 'saveitem' ){
window.close();
}
in cataloging_additem.js (incorrectly) true for every operation except
saveitem.
A windows can only be closed by javascript in certain conditions (don't know if
all browsers behave exactly the same), but for window.close() to actually close
the window it needs to be opened in new window/tab. So to reproduce this bug go
to a bibliographic record, expand the "New" menu, and open "New item" in new
tab. It should immediately close, which this patch should fix.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2354] OPACItemsResultsDisplay - "itemdetails" option fails with XSLTResultsDisplay ON
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2354 Holly changed: What|Removed |Added CC||h...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #1 from Fridolin SOMERS --- Created attachment 93164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93164=edit Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 --- Comment #2 from Fridolin SOMERS --- Created attachment 93165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93165=edit Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23679] New: Software error when trying to transfer an unknown barcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Bug ID: 23679 Summary: Software error when trying to transfer an unknown barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
