[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 --- Comment #11 from Katrin Fischer --- Passing QA on this as agreed with RM - both parties heavily using EDIFACT have been involved in the QA process. Tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 --- Comment #10 from Katrin Fischer --- Created attachment 93947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93947=edit Bug 20780: (follow-up) Use Koha::Object Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Katrin Fischer changed: What|Removed |Added Attachment #93672|0 |1 is obsolete|| Attachment #93673|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 93946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93946=edit Bug 20780: Add handling for AcqItemSetSubfieldsWhenRecieved in EDI Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Katrin Fischer changed: What|Removed |Added Text to go in the|Edifact reciepting of items |EDIFACT receipting of items release notes|should now respect the |should now respect the |AcqItemSetSubfieldsWhenRece |AcqItemSetSubfieldsWhenRece |ived systempreference |ived systempreference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #9 from Katrin Fischer --- Passing QA on this as agreed with RM - both parties heavily using EDIFACT have been involved in the QA process. Tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer changed: What|Removed |Added Attachment #93674|0 |1 is obsolete|| Attachment #93675|0 |1 is obsolete|| Attachment #93943|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 93944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93944=edit Bug 21580: Add test for message buyer_ean method Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #8 from Katrin Fischer --- Created attachment 93945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93945=edit Bug 21580: Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #6 from Katrin Fischer --- Created attachment 93943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93943=edit Bug 21580: Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21580] Order creation for EDIFACT vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23792] Send borrowernumbers from report to batch modify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23792 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Andrew, it works with cardnumber - but I agree borrowernumber would be nice, especially since I think we allow empty cardnumbers now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23792] New: Send borrowernumbers from report to batch modify
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23792 Bug ID: 23792 Summary: Send borrowernumbers from report to batch modify Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Apologies if this bug is a dupe, I really thought I'd seen this one before and now can't find it. It'd be great to be able to run a report listing patrons and send them straight to batch patron modification, as we can now do with items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #198 from David Cook --- (In reply to Ere Maijala from comment #193) > Got the docker stuff running. It seems that there are at least some > differences between YAZ versions. I've tested with YAZ 5, but the testing > box has YAZ 4. Looks like v4 can't find the pqf.properties file with a > relative path in t/db_dependent/Koha/Z3950Responder/config.xml. Upgrading > YAZ helps a bit, but there are still failing tests I need to check. Would it > be possible to upgrade the container to use YAZ 5? Do you have to use a relative path? Could the solution be to use an absolute path? (I'm asking without looking at the patches at all. Just an idea.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 --- Comment #10 from David Cook --- (In reply to Katrin Fischer from comment #9) > (In reply to Katrin Fischer from comment #8) > > That said, I guess David's patch would have to be reworked for the Koha > > namespace? > > Another issue: Printing routing lists. I think Nick's patch only fixes the > view, not the print. Looks like I wrote my patch back in 2012 and I think I had it applied locally in 3.8, but didn't bother to apply it locally after that. Seems that I haven't had any complaints about it since 2012 either, so not really a priority for me at the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16446] Allow librarians to add borrowers to lists by borrowernumber or cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- Giving this a bump. I'm training a library that wants to batch modify patrons who lack cardnumbers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23791] New: Allow granular control of social networks enabled by SocialNetworks syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23791 Bug ID: 23791 Summary: Allow granular control of social networks enabled by SocialNetworks syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Librarians would like to be able to turn social networks (and email) on and off individually, rather than as a group. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #17 from Caroline Cyr La Rose --- Your file also comes up as ISO 8859-1 on my computer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #16 from Katrin Fischer --- I downloaded Anke's sample file, but my editor (Geany) and LibreOffice both recognize it as "Western ISO-8859-1". So I think something might have gone wrong with encoding conversion, hoping Bugzilla is not to blame here. Could you please try this: - Open the file in Notepad++ - Check the setting it displays under 'Encoding' - If it displays as something other than ANSI, change it to ANSI - Use Encoding > Convert to UTF-8 (without BOM) in the lower half of the menu - Verify if your Umlauts look correct and that the encoding setting displays right as UTF-8 - Save I could only check the menu options in the Notepad++ Linux version, so they might be named slightly different in the German/Windows version. Caroline's file behaves well and displays as UTF-8 in all my programs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #15 from Caroline Cyr La Rose --- Created attachment 93942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93942=edit User import file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #14 from Caroline Cyr La Rose --- I was able to reproduce the problem mentionned by Mirko, i.e. that the error summary has encoding problems. The user's name was Chloé and it came out as Chloé BUT once imported, that user's file was fine. So I can't reproduce Anke's problem. For reference, I'm including a one-line file with the name and other information changed, but I kept the same firstname. You can try to import it as is and the error will be that the branchcode and categorycodes don't exist. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23779] Importing authority records should look for $1xx field matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 --- Comment #5 from Cori Lynn Arnold --- Created attachment 93941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93941=edit Example of a 1xx Rule Attached is an example of a working 1xx Matching Rule for Authorities -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23779] Importing authority records should look for $1xx field matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 --- Comment #4 from Katrin Fischer --- (In reply to Cori Lynn Arnold from comment #3) > Let me rephrase then, Koha should come out of the box with a sample matching > record for 1xx fields for loading Authority Records. Yes, I think that would make a lot of sense. It's just a bit more difficult than the standard rules. I think we would want something like: Score: 50 points Then 3 matchpoints for each 100 = 50 points 110 = 50 points 111 = 50 points So that each of those would make it reach the score needed to match. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23779] Importing authority records should look for $1xx field matches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 --- Comment #3 from Cori Lynn Arnold --- Let me rephrase then, Koha should come out of the box with a sample matching record for 1xx fields for loading Authority Records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 93940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93940=edit Bug 23790: fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices This patch provides the fr-CA translation of the ACCOUNT_DEBIT and ACCOUNT_CREDIT notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23790] New: fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790 Bug ID: 23790 Summary: fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Both ACCOUNT_DEBIT and ACCOUNT_CREDIT notices are in English in the fr-CA installation file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23072] Certificate invalid for lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23072 David Nind changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #5 from David Nind --- Looks like this is fixed and valid certificates are now in place. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23789] fr-CA translation of AUTO_RENEWALS notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789 Caroline Cyr La Rose changed: What|Removed |Added Attachment #93938|0 |1 is obsolete|| --- Comment #2 from Caroline Cyr La Rose --- Created attachment 93939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93939=edit Bug 23789: fr-CA translation of AUTO_RENEWALS notice This patch provides the fr-CA translation of the AUTO_RENEWALS notice (fixes typo). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23789] fr-CA translation of AUTO_RENEWALS notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23789] fr-CA translation of AUTO_RENEWALS notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 93938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93938=edit Bug 23789: fr-CA translation of AUTO_RENEWALS notice This patch provides the fr-CA translation of the AUTO_RENEWALS notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Caroline Cyr La Rose changed: What|Removed |Added Blocks||23789 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789 [Bug 23789] fr-CA translation of AUTO_RENEWALS notice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23789] fr-CA translation of AUTO_RENEWALS notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com Depends on||23787 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23789] New: fr-CA translation of AUTO_RENEWALS notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789 Bug ID: 23789 Summary: fr-CA translation of AUTO_RENEWALS notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com --- Comment #2 from Caroline Cyr La Rose --- I simply copied the INSERT query into all the files. I hope that's okay. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 93937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93937=edit Bug 23787: Add AUTO_RENEWALS in sample_notices.sql This patch adds the AUTO_RENEWALS notice SQL insert query that was only available in the updatedatabase script into all the language-specific sample_notices.sql files in the installer (de-DE, en, es-ES, fr-CA, fr-FR, nb-NO, pl-PL, ru-RU, uk-UA). To test, make a fresh install in a language listed above, do NOT run updatedatabase, make sure the AUTO_RENEWALS is in the available notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Caroline Cyr La Rose changed: What|Removed |Added Summary|AUTO_RENEWALS is not in |Add AUTO_RENEWALS in |sample_notices.sql |sample_notices.sql -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23523] unitprice tax column values are not populated if entered upon ordering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #3 from Nick Clemens --- (In reply to David Nind from comment #2) > Works for me for new items added after the patch was applied. > > However, I couldn't seem to modify existing items that are part of the > basket - they reverted to original price. Hi David, I tested again, it seems to work for both new and old orders for. Note that you won't see any change in the basket with bug 23522 - this only affects the DB. I broke them into two as I thought it made things easier to read and test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Kyle M Hall changed: What|Removed |Added Attachment #93935|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 93936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93936=edit Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Kyle M Hall changed: What|Removed |Added Attachment #93934|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 93935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93935=edit Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 --- Comment #3 from Kyle M Hall --- Created attachment 93934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93934=edit Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 --- Comment #2 from Kyle M Hall --- Created attachment 93933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93933=edit Bug 23788: Rename $select_lines to $selected_lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 --- Comment #1 from Kyle M Hall --- Created attachment 93932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93932=edit Bug 23788: Rename $select to $selected_accts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Kyle M Hall changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Kyle M Hall changed: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] New: Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Bug ID: 23788 Summary: Writing off multiple fees allows 'overpayment' of those fees Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- I've seen this happening as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #26 from Katrin Fischer --- (In reply to Nick Clemens from comment #25) > Discussed with Martin, checkout calculations are coming up short This sounds like a scary bug - any news here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permissions for Holds History Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #1 from AspenCat Team --- Been getting a lot of feedback from our libraries that they would like to see this permission problem fixed so they can view holds history without the problems that are created by allowing all of our libraries to view and edit patrons from other libraries. - Bob Bennhoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permissions for Holds History Tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19237] PERSO_NAME authority file ignores first indicator value of new headings saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237 Michael Spagnuolo changed: What|Removed |Added CC||mspagnu...@nrhtx.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What|Removed |Added Attachment #67813|0 |1 is obsolete|| --- Comment #28 from Lari Taskula --- Created attachment 93931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93931=edit Bug 14620: Patron contact validation script Goes through patron database and validates their email and phonenumber fields. Only reports issues, does not modify anything. Usage: ./misc/maintenance/validate_patron_contact_data.pl --help Example output: === === BorrowernumberField Value === === 29 phone 1NV4L1D 30 smsalertnumber lol 30 phone 1NV4L1D 39 smsalertnumber lol 39 phone 1NV4L1D 40 smsalertnumber lol 40 phone 1NV4L1D 41 smsalertnumber lol 41 phone 1NV4L1D 42 smsalertnumber lol === === BorrowernumberField Value === === -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620
Lari Taskula changed:
What|Removed |Added
Attachment #67812|0 |1
is obsolete||
--- Comment #27 from Lari Taskula ---
Created attachment 93930
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93930=edit
Bug 14620: Contact information validations
This patch adds a phone number validation by regex and centralizes
different validation methods into Koha::Validation class.
Introduces a new system preference, ValidatePhoneNumber, that takes a
regular expression and uses it to validate phone numbers both client
and server side.
Unit tests to test:
1. prove t/db_dependent/Koha/Validation.t
To test:
1. Apply the patches and run updatedatabase.pl to install the new
system preference
2. Set system preference ValidatePhoneNumber to any regex you like
(there is an example in the description of the preference)
3. Navigate to edit user contact informations in Staff client and OPAC.
4. Insert invalid email (e.g. "invalid") and invalid phone number
("+123invalid")
and send the form.
5. Confirm that form will not be submitted and errors will be given.
6. Disable JavaScript and test that these errors will also be provided by the
server.
Sponsored-by: Koha-Suomi Oy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23787] New: AUTO_RENEWALS is not in sample_notices.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Bug ID: 23787 Summary: AUTO_RENEWALS is not in sample_notices.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org I wanted to translate the AUTO_RENEWALS notice, but it's not in the sample_notices.sql. It is only in the updatedatabase.pl Martin confirmed on IRC that it should be in both. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #25 from Kyle M Hall --- I've added a few more examples. I the moment I can't find the actual use-case that made me write this patch :\ (In reply to Katrin Fischer from comment #24) > I think some more complex examples would be nice that show why this patch is > needed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 Cass changed: What|Removed |Added CC||brokenfr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15985] Include transacting library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19066 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Martin Renvoize changed: What|Removed |Added Target Milestone|19.05 |--- Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15985 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23786] New: Advanced Editor: Make font configurations stick for a user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23786 Bug ID: 23786 Summary: Advanced Editor: Make font configurations stick for a user Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: carn...@dgiinc.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl At the beginning of the day the cataloger has to reset their font type and sizes each day. Please make this configuration stick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #25 from Andrew Isherwood --- Hi Nick Thanks for taking a look at this. >Tests need a minor rebase to pass. Fixed >You duplicate the code in Account->pay and Line->apply [..] Indeed. I've now refactored the duplicated code into a couple of helper functions in Koha::Account. >I don't like the lack of feedback for the renewal/failure [..] This is a very tricky issue, and one I side-stepped during dev. Firstly, any feedback would only be available in the UI. Since there is more than one way of paying off fines that don't involve the Koha UI (e.g. SIP), those methods would not receive the feedback. Also, since the renewal is happening as a side effect of paying off a fine, anything that was saying "pay off the fine on this item" will have to be expecting something entirely unrelated, i.e. "this item couldn't renew" back, which feels wrong. I do agree that no feedback at all is bad though. I'll have a think and see if I can come up with. >In the case where a renewal doesn't make the book current [..] Same as the previous one really. I'll do some pondering... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #13 from Anke --- Created attachment 93929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93929=edit Patron details -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #12 from Anke --- Created attachment 93928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93928=edit Patron list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #11 from Anke --- Created attachment 93927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93927=edit Import summary -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #10 from Anke --- OK, I imported some fantasy users into my Koha; I used a comma separated .csv file See attached .csv as well as a screenshot of the import summary (where the umlauts and accents look good) and two more screenshots of the list of patrons and a detailed patron information showing that here, the umlauts and accents aren't displayed correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17359] Patron import results use wrong encoding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #9 from Anke --- Created attachment 93926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93926=edit Input file in UTF8 without BOM format Patron import .csv file with fantasy names -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #24 from Andrew Isherwood --- Created attachment 93925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93925=edit Bug 23051: (follow-up) Refactor renewal code As per Nick's first point in comment #20, the code that tests for renewability and renews items has been refactored into it's own function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood changed: What|Removed |Added Attachment #92689|0 |1 is obsolete|| --- Comment #23 from Andrew Isherwood --- Created attachment 93924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93924=edit Bug 23051: Renew items when fines paid off When the RenewAccruingItemWhenPaid syspref is enabled and all the fines on an item that is accruing fines are paid, we automatically renew that item to prevent it from starting to accrue fines again. This patch adds an additional argument to C4::Circulation::AddRenewal which allows us to skip the calculation of fines upon renewal, which we don't want to do if the fines on that item have just been paid. Existing calls to AddRenewal have not been amended because there seems to be a convention of only passing undef when adding arguments that require their positioning to be maintained. Since the new argument is the last one, this is not the case with any existing call. Signed-off-by: Lucy Harrison Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood changed: What|Removed |Added Attachment #92688|0 |1 is obsolete|| --- Comment #22 from Andrew Isherwood --- Created attachment 93923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93923=edit Bug 23051: Add unit tests This patch adds unit tests for all modules affected by this bug Signed-off-by: Lucy Harrison Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood changed: What|Removed |Added Attachment #92687|0 |1 is obsolete|| --- Comment #21 from Andrew Isherwood --- Created attachment 93922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93922=edit Bug 23051: Add RenewAccruingItemWhenPaid syspref This patch adds the new syspref "RenewAccruingItemWhenPaid" Signed-off-by: Lucy Harrison Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #56 from Julian Maurice --- Created attachment 93921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93921=edit Bug 15219: Fix typo 'escapeHtm' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23785] New: Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Bug ID: 23785 Summary: Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: dalagior...@sch.gr QA Contact: testo...@bugs.koha-community.org After creating an instance, and without adding any records to the library, trying to search for anything on OPAC, produces the following error: Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Fridolin SOMERS changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #55 from Fridolin SOMERS --- Typo in : Bug 15219: Fix date sorting when server-side processing is disabled : -title += " - " + oObj.itemnotes.escapeHtml() + ""; +title += " - " + row.itemnotes.escapeHtm() + ""; escapeHtm() instead of escapeHtml() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Stefan Berndtsson changed: What|Removed |Added CC||stefan.berndts...@ub.gu.se --- Comment #23 from Stefan Berndtsson --- This issue has hit us as well. We calculate fines during weekends regardless of whether or not we're closed, but if the book was returned on saturday and sunday or monday was the first fined day, making the user pay for the book can't be correct, right? In AddReturn, there are a few conditions for recalculating fines. They used to be: "(syspref_is_set AND is_overdue) OR explicit_return_date". This has now been changed to: "(syspref_is_set AND was_overdue_on_return_date AND is_not_lost)" Why does it check if there should be a recalculation based on the backdated date (was_overdue_on_return_date)? The fine will still be calculated based on the backdated date, but the condition whether or not to recalculate shouldn't depend on the overdue status at that date. This line in AddReturn(): $is_overdue = $issue->is_overdue( $return_date ); ...used to be: $is_overdue = $issue->is_overdue; To me, the logical condition should be: 1. Syspref CalculateFinesOnReturn is set 2. Book is overdue right now 3. Book is not lost -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 --- Comment #12 from Andreas Hedström Mace --- Also, this bug sounds kind of similar to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 But there fines where forgiven during return (not renewal). Could it be the case here as well, that this was in effect for the renewal/return? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #26 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23778] Regression: Guarantor entry section no longer has a unique id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778 --- Comment #3 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23778] Regression: Guarantor entry section no longer has a unique id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 --- Comment #5 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 --- Comment #48 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22927] Item improperly marked returned when changing damaged or withdrawn status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 --- Comment #18 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23668] Manual on patron import: Information on syntax for patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23668 --- Comment #1 from Anke --- Meanwhile I saw that the help page in the Koha staff client describes it differently and probably correctly (probably as I didn't test all the varieties described). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #22 from Andrew Isherwood --- Hi Kyle Thanks for taking a look at this. >Can Koha::RestrictionType(s) be moved to Koha::Patron::RestrictionType(s) That's actually how I had it originally. However I moved it since, as far as I could see, everything in Koha::Patron::* was related to a singular patron and represented properties of that patron, which was not the case of RestrictionTypes, which represents the canonical list of restriction types, or a restriction type, not at all related to a patron. I'm happy to move it back if you feel it would be better there, but wanted to explain the rationale. >Can the table debarment_types be renamed to patron_restriction_types so our >internal and external terminology match? Again, there is a rationale behind this. I named the table "debarment_types" because it was related to a pre-existing table "borrower_debarments" and I felt it would be confusing to name it "restriction_types". I realise that there is a move towards "restriction" rather than "debarment", and I have used the new term in the parts of this bug that are truly new, but where I'm interacting with stuff that's referring to debarments, it felt less confusing to use the same terminology for my bits. Hopefully, at some point, a full sweep of "debarment" => "restriction" will be done, so I felt this was a reasonable interim balance. Again, if you'd rather it be changed, I can do so. Many thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 --- Comment #17 from Martin Renvoize --- Thanks Nick, All looks good here (and it looks like I would have got the rebase right.. woopie) Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #21 from Kyle M Hall --- A couple things: * Can Koha::RestrictionType(s) be moved to Koha::Patron::RestrictionType(s) * Can the table debarment_types be renamed to patron_restriction_types so our internal and external terminology match? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
Martin Renvoize changed:
What|Removed |Added
Attachment #93917|0 |1
is obsolete||
--- Comment #15 from Martin Renvoize ---
Created attachment 93919
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93919=edit
Bug 22997: Searching gives no results in auth_finder.pl
During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
Search main heading ($a only)
Search main heading
Default operator beeing 'contains'.
Actually with Elasticsearch those search give no results.
Example with heading :
200
$a Casaubon
$b Isaac
$f 1559-1614
Call to Elasticsearch :
"query" : {
"bool" : {
"must" : [
{
"query_string" : {
"query" : "Casaubon*",
"default_field" : "heading-main",
}
},
{
"query_string" : {
"query" : "(Isaac*) AND (1559-1614*)",
"default_field" : "heading"
}
}
]
}
},
"sort" : [
{
"heading__sort.phrase" : "asc"
}
]
}
Patch adds to "query_string" :
analyze_wildcard : true.
Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl
Signed-off-by: Kyle M Hall
Signed-off-by: Nick Clemens
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Martin Renvoize changed: What|Removed |Added Attachment #93918|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 93920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93920=edit Bug 22997: Unit test Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Nick Clemens changed: What|Removed |Added Attachment #93378|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 93918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93918=edit Bug 22997: Unit test Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997
Nick Clemens changed:
What|Removed |Added
Attachment #93377|0 |1
is obsolete||
--- Comment #13 from Nick Clemens ---
Created attachment 93917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93917=edit
Bug 22997: Searching gives no results in auth_finder.pl
During cataloguing of an existing biblio, on an heading field,
the use of tag editor fills authorities finder with existing value :
Search main heading ($a only)
Search main heading
Default operator beeing 'contains'.
Actually with Elasticsearch those search give no results.
Example with heading :
200
$a Casaubon
$b Isaac
$f 1559-1614
Call to Elasticsearch :
"query" : {
"bool" : {
"must" : [
{
"query_string" : {
"query" : "Casaubon*",
"default_field" : "heading-main",
}
},
{
"query_string" : {
"query" : "(Isaac*) AND (1559-1614*)",
"default_field" : "heading"
}
}
]
}
},
"sort" : [
{
"heading__sort.phrase" : "asc"
}
]
}
Patch adds to "query_string" :
analyze_wildcard : true.
Test plan :
1) Use Elasticsearch
2) Edit an existing biblio record
3) Use tag editor on a heading
4) Click search => You get correct results
5) Check also search in authorities-home.pl
Signed-off-by: Kyle M Hall
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
