[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #38 from Tomás Cohen Arazi --- All the tests passed when I tested, expect from the API ones for which I submitted a fix. I think doing it outside bugzilla (branch on github and pull request) might have leaded to confusion? The branch contained more than one bug/patchset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 Ere Maijala changed: What|Removed |Added Attachment #94771|0 |1 is obsolete|| --- Comment #9 from Ere Maijala --- Created attachment 94799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94799=edit Bug 23521: Put parentheses arround limit terms Test plan: - Use Elasticsearch 6 (you'll need Bug 18969), - create a biblio (#1) with "Dillinger Girl" in author and what you want in title, - create another biblio (#2) with the word "girl" in the title and "Dillinger Escaplan" as author - reindex - search * and refine on "Dillinger Girl" - Ko => Biblio #1 and #2 appear - Apply this patch, - search * and refine on "Dillinger Girl" - Ok => anly biblio #1 appears - use Elasticsearch 5 again - check for no search regression Signed-off-by: Séverine QUEUNE Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 Ere Maijala changed: What|Removed |Added Attachment #94772|0 |1 is obsolete|| --- Comment #10 from Ere Maijala --- Created attachment 94800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94800=edit Bug 23521: (follow-up) Add quotes Not only should terms from facets/limits be grouped, but order should probably matter We build a different facet for "Dillinger Girl" or "Girl Dillinger" The parens are possibly overkill now, but I think it makes it very clear and does not hurt To test: 1 - Follow original plan 2 - Create a new record with 'Girl Dillinger' as author 3 - Search for 'Dill*' 4 - You get all three records (and maybe others that match) 5 - Limit by 'Girl Dillinger' - you get two records 6 - Same for 'Dillinger Girl' 7 - Apply patch 8 - Limits/facets for 'Dillinger Girl' and 'Girl Dillinger' now match a isngle record Signed-off-by: Ere Maijala -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23904] New: Chrome 74 update does not allow use of window.open()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23904 Bug ID: 23904 Summary: Chrome 74 update does not allow use of window.open() Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com According to developers.google.com the following is true in Chrome: Don't allow popups during page unload Pages may no longer use window.open() to open a new page during unload. The Chrome popup blocker already prohibited this, but now it is prohibited whether or not the popup blocker is enabled. Koha uses windows.open() to open print dialogues for Print Slip and Print Quick Slip. These no longer open as members-menu.js uses windows.open(). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23904] Chrome update does not allow use of window.open()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23904 Lucas Gass changed: What|Removed |Added Summary|Chrome 74 update does not |Chrome update does not |allow use of window.open() |allow use of window.open() -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23805] Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23904] Chrome 74 update does not allow use of window.open()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23904 Liz Rea changed: What|Removed |Added Priority|P5 - low|P1 - high CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 --- Comment #11 from Ere Maijala --- Makes sense to me. I don't particularly like the slightly ambiguous syntax used with limits (I'd interpret 'author:Something Other' as 'author:(Something) AND Other', but since it works with Zebra, we need to support that. A helper function for splitting a string to field and term would be nice since we do the same regexp now in at least two places, but it's still clear enough that it works for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903 --- Comment #1 from Owen Leonard --- I still need to write up a proper test plan and commit message, but if anyone is interested in looking: https://gitlab.com/koha-dev/koha-dev/commits/ip-opac-fa-icons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858 Nick Clemens changed: What|Removed |Added Attachment #94536|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 94798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94798=edit Bug 23858: (follow-up) Return code fix Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858 Nick Clemens changed: What|Removed |Added Attachment #94535|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 94797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94797=edit Bug 23858: Make POST add the Location header on vendors endpoint According to the coding guidelines, this endpoint should be adding the Location header on POST actions. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_vendors.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat (1) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23858] Vendors endpoint not setting the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23858 Nick Clemens changed: What|Removed |Added Attachment #94534|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 94796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94796=edit Bug 23858: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 Nick Clemens changed: What|Removed |Added Attachment #94108|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 94795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94795=edit Bug 22114: Untranslatable "Patron note:" in checkout.js This patch modifies JavaScript used in circulation, replacing an untranslatable English string in the script with a variable defined in strings.inc which can be translated. To test you should have the AllowCheckoutNotes system preference enabled. - Apply the patch and log in to the OPAC as a user who has two or more items checked out. - From the list of checkouts on the "Your summary" page, add a note to two or more checked-out items. - Log in to the staff client and open the checkout page for that user. - In the table of checkouts, check the "Check in" checkbox next to one of the titles you added a note to. - Click "Renew or check in selected items." - A message should appear in that table row showing your note, prefixed with the text "Patron note:" To test translation, update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Ausleihe (Circulation) and check out to the same patron. - In the table of checkouts, check the checkbox in the "Rückgabe" column next to another title you added a note to. - Click the "Markierte Exemplare zurückgeben oder verlängern" button. - A message should appear in that table row showing your note prefixed with the text "Benutzernotizen:" Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22114] Untranslatable "Patron note:" in checkout.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22114 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23903] New: Replace OPAC icons with Font Awesome
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903 Bug ID: 23903 Summary: Replace OPAC icons with Font Awesome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org We can eliminate use of the sprite image for icons and use Font Awesome instead. This will be simpler and more customization-friendly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23310] Noisy Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23310 hannah...@northwestu.edu changed: What|Removed |Added CC||hannah...@northwestu.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #64 from Nick Clemens --- Created attachment 94794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94794=edit Bug 17168: (QA follow-up) Only remove guarantor relationship if not Child AND not Professional Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Nick Clemens changed: What|Removed |Added Attachment #94790|0 |1 is obsolete|| --- Comment #63 from Nick Clemens --- Created attachment 94793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94793=edit Bug 17168: (RM follow-up) Update for bug 14570 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23902] New: Cataloging Search: Add control number to preview
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23902 Bug ID: 23902 Summary: Cataloging Search: Add control number to preview Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: carn...@dgiinc.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl We would like to see the Control Number (001 field) when we do a cataloging search on page /cgi-bin/koha/cataloguing/addbooks.pl https://paste.pics/658e5727b28b75aea510b908c27faf9a -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #99 from Martin Renvoize --- This will need to update the cleanup routine introduced in bug 17168. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Martin Renvoize changed: What|Removed |Added CC||je...@bywatersolutions.com --- Comment #15 from Martin Renvoize --- *** Bug 15143 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15143] Removing a Guarantee from a Guarantors account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15143 Martin Renvoize changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 12949 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #14 from Martin Renvoize --- I believe this is at least partially resolved as part of bug 17168, see the RM follow-up there that shift the logic into Koha::Patron such that any change of categorycode from guarantee-able to non-guarantee-able will result in the relationship being deleted as part of the action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 --- Comment #5 from Nick Clemens --- Created attachment 94792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94792=edit Bug 22874: Use false instaed of 0 value for limiting on availability Test plan - Set up a elasticsearch 6 instance to work with Koha, - you may need to make koha works with ES 6 (see bug 20589), - make a search and limit it to available items only, => no result - Apply this patch, - make a search and limit it to available items only, - you should get some results - Do the same with ES 5.x Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22874] Limit to available items doesn't work with elasticsearch 6.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22874 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #4 from Lucas Gass --- Created attachment 94791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94791=edit Bug 22381: Change wording on Calendar-related system preferences TEST PLAN: 1. Apply Patch 2. Look at the 4 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #62 from Martin Renvoize --- Created attachment 94790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94790=edit Bug 17168: (RM follow-up) Update for bug 14570 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens --- Unit tests please -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 --- Comment #13 from Kyle M Hall --- Created attachment 94789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94789=edit Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Kyle M Hall changed: What|Removed |Added Attachment #94786|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall --- Created attachment 94787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94787=edit Bug 23788: Rename $select to $selected_accts Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 --- Comment #12 from Kyle M Hall --- Created attachment 94788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94788=edit Bug 23788: Rename $select_lines to $selected_lines Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Kyle M Hall changed: What|Removed |Added Attachment #94276|0 |1 is obsolete|| Attachment #94277|0 |1 is obsolete|| Attachment #94278|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 94786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94786=edit Bug 23788: Rename $select to $selected_accts Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #61 from Martin Renvoize --- :(. I missed a lot here... this patchset needs updating for bug 14570 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12949] changing child to adult doesn't remove link to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12949 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17168 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12949 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22269] Pay amount - modal confirmation of amount to return to patron should be suppressed if attempting to pay (not collect) more than owed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 --- Comment #2 from Caroline Cyr La Rose --- I'm not sure if this is the same bug as the one I'm experiencing. I'm trying to understand the new "change to give" feature. If I try to pay a 19,33$ charge with a 20$ bill, I get a notification saying I owe 0,67$ to the user, I confirm, and then the payment fails because "You must pay a value less than or equal to 19.33". I attached a gif showing what I mean. To recreate: 1 - Add a fine or find a patron owing money 2 - Go to pay fines, pay amount 3 - Set amount collected higher than amount paid 4 - Note you get a confirmation modal, confirm 5 - payment fails -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22269] Pay amount - modal confirmation of amount to return to patron should be suppressed if attempting to pay (not collect) more than owed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #1 from Caroline Cyr La Rose --- Created attachment 94785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94785=edit Payment fails if amount collected is higher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94766|0 |1 is obsolete|| --- Comment #73 from Nick Clemens --- Created attachment 94784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94784=edit Bug 23382: Use floating time zone to prevent tests to fail because of DST Today Friday Oct 25th, DST next Sunday => Date math are wrong, 96 hours diff becomes 95. To avoid that we use the floating timezone Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94765|0 |1 is obsolete|| --- Comment #72 from Nick Clemens --- Created attachment 94783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94783=edit Bug 23382: (follow-up) Ensure closed day is inside charge window We're testing with an hourly loan of 96 hours to catch a closed day. However, our closed day was hard coded to be a Wednesday so if you ran the tests on a Friday the 96 hour loan would not catch a Wednesday. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94764|0 |1 is obsolete|| --- Comment #71 from Nick Clemens --- Created attachment 94782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94782=edit Bug 23382: hours_between should match the logic of days_between The loops for subtraction holiday dates in hours_between and days_between differed and as such their handling of start and end boundaries for days also differed. This patch makes them handle the boundary days consistently. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94763|0 |1 is obsolete|| --- Comment #70 from Nick Clemens --- Created attachment 94781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94781=edit Bug 23382: Truncate dates to minutes for comparison. It's somewhat of a mess in C4::Circulation as to when dates are truncated and when they are not and as such Koha::Charges::Fees could not reliably assume that the dates passed in were consistent with each other. As such, we take the approach of always truncating to the greatest minute smaller than the passed in dates so we are comparing like for like. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94762|0 |1 is obsolete|| --- Comment #69 from Nick Clemens --- Created attachment 94780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94780=edit Bug 23382: (follow-up) Further improve test coverage Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94758|0 |1 is obsolete|| --- Comment #65 from Nick Clemens --- Created attachment 94776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94776=edit Bug 23382: Add hourly tests for Circulation Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94756|0 |1 is obsolete|| --- Comment #63 from Nick Clemens --- Created attachment 94774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94774=edit Bug 23382: Improve test coverage Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94761|0 |1 is obsolete|| --- Comment #68 from Nick Clemens --- Created attachment 94779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94779=edit Bug 23382: (follow-up) Ensure tests pass on Wednesdays Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94759|0 |1 is obsolete|| --- Comment #66 from Nick Clemens --- Created attachment 94777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94777=edit Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued It looks like over progressive rebases of bug 20912 a clause was lost within CanBookBeIssued such that a fatal error may be triggered if an item with no corresponding itemtype was passed into the routine. Additionally the we were passing a Koha::Library object to CalcDateDue rather than a branchcode which resulted in a different duedate being used in 'CanBookBeIssued' when compared to 'AddIssue'. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94760|0 |1 is obsolete|| --- Comment #67 from Nick Clemens --- Created attachment 94778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94778=edit Bug 23382: (follow-up) Clarify variable names This patch updates the variable name '$branch' to '$branchcode' in a number of places to make it clearer what the variable contains. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Attachment #94757|0 |1 is obsolete|| --- Comment #64 from Nick Clemens --- Created attachment 94775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94775=edit Bug 23382: Add tests for hourly calculations Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Jessie Zairo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Jessie Zairo --- Works as described. Screencast available at: https://drive.google.com/file/d/14y5GfGtpt4IUClkKmlnhkFPaSCfyMr2s/view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 ByWater Sandboxes changed: What|Removed |Added Attachment #91233|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 94773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94773=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #62 from Martin Renvoize --- Thanks dude :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 Nick Clemens changed: What|Removed |Added CC||ere.maij...@helsinki.fi --- Comment #8 from Nick Clemens --- Alex, your patches work well, but I took things a bit further, can you check my work? Added Ere to CC for another opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 Nick Clemens changed: What|Removed |Added Attachment #93741|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 94771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94771=edit Bug 23521: Put parentheses arround limit terms Test plan: - Use Elasticsearch 6 (you'll need Bug 18969), - create a biblio (#1) with "Dillinger Girl" in author and what you want in title, - create another biblio (#2) with the word "girl" in the title and "Dillinger Escaplan" as author - reindex - search * and refine on "Dillinger Girl" - Ko => Biblio #1 and #2 appear - Apply this patch, - search * and refine on "Dillinger Girl" - Ok => anly biblio #1 appears - use Elasticsearch 5 again - check for no search regression Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23521] ES 6 - limit terms with many words can make the search inaccurate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23521 --- Comment #7 from Nick Clemens --- Created attachment 94772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94772=edit Bug 23521: (follow-up) Add quotes Not only should terms from facets/limits be grouped, but order should probably matter We build a different facet for "Dillinger Girl" or "Girl Dillinger" The parens are possibly overkill now, but I think it makes it very clear and does not hurt To test: 1 - Follow original plan 2 - Create a new record with 'Girl Dillinger' as author 3 - Search for 'Dill*' 4 - You get all three records (and maybe others that match) 5 - Limit by 'Girl Dillinger' - you get two records 6 - Same for 'Dillinger Girl' 7 - Apply patch 8 - Limits/facets for 'Dillinger Girl' and 'Girl Dillinger' now match a isngle record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23895 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13897 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Lari Taskula changed: What|Removed |Added Attachment #94767|0 |1 is obsolete|| --- Comment #3 from Lari Taskula --- Created attachment 94769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94769=edit Bug 23901: Fix sms_input is null in opac-messaging.tt When sms messaging is disabled, JavaScript breaks in opac-messaging.tt. Bug introduced in Bug 22862. To test: 1. Enable EnhancedMessagingPreferences system preference 2. Disable sms messaging by unsetting SMSSendDriver system preference 3. Go to OPAC -> your messaging 4. Observe JavaScript error "sms_input is null" in your browser console 5. Apply patch 6. Refresh page and observe the error is gone Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Lari Taskula changed: What|Removed |Added Attachment #94768|0 |1 is obsolete|| --- Comment #4 from Lari Taskula --- Created attachment 94770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94770=edit Bug 23901: Fix indentation This patch only fixes the indentation of code inside the if-block. To test: 1. Apply patch 2. Run: git diff -w HEAD~1 and observe no result Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Lari Taskula changed: What|Removed |Added Assignee|oleon...@myacpl.org |lari.task...@hypernova.fi Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #40 from Jonathan Druart --- (In reply to Séverine Queune from comment #39) > (In reply to Jonathan Druart from comment #38) > > Séverine, this is how FindDuplicate works so far. If we want to improve its > > behavior we should done it on a separate bug report. It is out of the scope > > of this one. > > Thank you Jonathan for the information. > Except that point, the other behaviours were good, so ok to keep the "Signed > off" status. > About the opening of a new bug, can you do it ? I'm not sure I can correctly > describe the problem. It already exists actually :) See bug 15248. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 --- Comment #1 from Lari Taskula --- Created attachment 94767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94767=edit Bug 23901: Fix sms_input is null in opac-messaging.tt When sms messaging is disabled, JavaScript breaks on opac-messaging.tt. Bug introduced in Bug 22862. To test: 1. Enable EnhancedMessagingPreferences system preference 2. Disable sms messaging by unsetting SMSSendDriver system preference 3. Go to OPAC -> your messaging 4. Observe JavaScript error "sms_input is null" in your browser console 5. Apply patch 6. Refresh page and observe the error is gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 --- Comment #2 from Lari Taskula --- Created attachment 94768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94768=edit Bug 23901: Fix indentation This patch only fixes the indentation of code inside the if-block. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22862] It should be possible to paste formatted phone numbers into the SMS messaging number field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862 Lari Taskula changed: What|Removed |Added Blocks||23901 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 [Bug 23901] Fix js error sms_input is null in opac-messaging.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Lari Taskula changed: What|Removed |Added Status|NEW |Needs Signoff Depends on||22862 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22862 [Bug 22862] It should be possible to paste formatted phone numbers into the SMS messaging number field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23901] New: Fix js error sms_input is null in opac-messaging.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Bug ID: 23901 Summary: Fix js error sms_input is null in opac-messaging.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lari.task...@hypernova.fi QA Contact: testo...@bugs.koha-community.org Follow-up of Bug 22862 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94755|0 |1 is obsolete|| --- Comment #61 from Jonathan Druart --- Created attachment 94766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94766=edit Bug 23382: Use floating time zone to prevent tests to fail because of DST Today Friday Oct 25th, DST next Sunday => Date math are wrong, 96 hours diff becomes 95. To avoid that we use the floating timezone Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94743|0 |1 is obsolete|| --- Comment #60 from Jonathan Druart --- Created attachment 94765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94765=edit Bug 23382: (follow-up) Ensure closed day is inside charge window We're testing with an hourly loan of 96 hours to catch a closed day. However, our closed day was hard coded to be a Wednesday so if you ran the tests on a Friday the 96 hour loan would not catch a Wednesday. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94731|0 |1 is obsolete|| --- Comment #59 from Jonathan Druart --- Created attachment 94764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94764=edit Bug 23382: hours_between should match the logic of days_between The loops for subtraction holiday dates in hours_between and days_between differed and as such their handling of start and end boundaries for days also differed. This patch makes them handle the boundary days consistently. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94728|0 |1 is obsolete|| --- Comment #56 from Jonathan Druart --- Created attachment 94761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94761=edit Bug 23382: (follow-up) Ensure tests pass on Wednesdays Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94726|0 |1 is obsolete|| --- Comment #54 from Jonathan Druart --- Created attachment 94759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94759=edit Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued It looks like over progressive rebases of bug 20912 a clause was lost within CanBookBeIssued such that a fatal error may be triggered if an item with no corresponding itemtype was passed into the routine. Additionally the we were passing a Koha::Library object to CalcDateDue rather than a branchcode which resulted in a different duedate being used in 'CanBookBeIssued' when compared to 'AddIssue'. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94729|0 |1 is obsolete|| --- Comment #57 from Jonathan Druart --- Created attachment 94762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94762=edit Bug 23382: (follow-up) Further improve test coverage Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14620 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94727|0 |1 is obsolete|| --- Comment #55 from Jonathan Druart --- Created attachment 94760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94760=edit Bug 23382: (follow-up) Clarify variable names This patch updates the variable name '$branch' to '$branchcode' in a number of places to make it clearer what the variable contains. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94723|0 |1 is obsolete|| --- Comment #51 from Jonathan Druart --- Created attachment 94756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94756=edit Bug 23382: Improve test coverage Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94730|0 |1 is obsolete|| --- Comment #58 from Jonathan Druart --- Created attachment 94763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94763=edit Bug 23382: Truncate dates to minutes for comparison. It's somewhat of a mess in C4::Circulation as to when dates are truncated and when they are not and as such Koha::Charges::Fees could not reliably assume that the dates passed in were consistent with each other. As such, we take the approach of always truncating to the greatest minute smaller than the passed in dates so we are comparing like for like. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94724|0 |1 is obsolete|| --- Comment #52 from Jonathan Druart --- Created attachment 94757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94757=edit Bug 23382: Add tests for hourly calculations Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Attachment #94725|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 94758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94758=edit Bug 23382: Add hourly tests for Circulation Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #50 from Jonathan Druart --- Created attachment 94755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94755=edit Bug 23382: Use floating time zone to prevent tests to fail because of DST Today Friday Oct 25th, DST next Sunday => Date math are wrong, 96 hours diff becomes 95. To avoid that we use the floating timezone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22594 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23900] New: Label maker cannot concatenate database fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 Bug ID: 23900 Summary: Label maker cannot concatenate database fields Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The manual explains that one can use double quotes when listing fields for one's label layout to make two or more values concatenate onto a single line in one's label. From https://koha-community.org/manual//18.11/en/html/tools.html#layouts: "You can also enclose a whitespace-separated list of fields to concatenate on one line in double quotes, for example “099a 099b” or “itemcallnumber barcode”. Testing this on both 18.11 and 19.05, this works for MARC fields but not for database fields. To test: - define a label layout with this field list: "100a 245s","enumchron copynumber" - find or create a record with values for all of those fields - generate a label for that record - the 100a and 245s successfully display on one line - the enumchron and copynumber do not display at all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23897] Hea - share *js, *css and "blocks" sysprefs existence
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23897 Jonathan Druart changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23849 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23898] New data to share on HEA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23849 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23897] Hea - share *js, *css and "blocks" sysprefs existence
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23897 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 23898 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23849] Update the list of sysprefs to share with Hea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23849 Jonathan Druart changed: What|Removed |Added See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=23897 |?id=23898 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23898] New data to share on HEA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23898 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- *** Bug 23897 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21586] Add generic OpenIDConnect client implementation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586 Stefan Berndtsson changed: What|Removed |Added CC||stefan.berndts...@ub.gu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #93908|0 |1 is obsolete|| --- Comment #72 from Lari Taskula --- Created attachment 94754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94754=edit Bug 18595: Validate days_in_advance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Lari Taskula changed: What|Removed |Added Attachment #93880|0 |1 is obsolete|| --- Comment #71 from Lari Taskula --- Created attachment 94753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94753=edit Bug 18595: Disable digest checkbox when forced on To test: 1. Force a digest on via message_transports table (delete rows where message_attribute is 1 and is_digest is 0) SQL: delete from message_transports where message_attribute_id=1 and is_digest=0; 2. Go to either OPAC or staff client messaging preferences 3. Observe digest checkbox is disabled for message attribute 1 (normally Item due row) Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806 Lari Taskula changed: What|Removed |Added Attachment #94750|0 |1 is obsolete|| --- Comment #10 from Lari Taskula --- Created attachment 94752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94752=edit Bug 14806 - (follow-up) Action Log for Modifying message_transport_types Introducing improvements: - Centralizing code into new Koha::Patron::Message::Preference(s) objects - Addings tests To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t 2. Follow test plan of previous patch Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23849] Update the list of sysprefs to share with Hea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23849 --- Comment #16 from Paul Poulain --- see bug 23898 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23899] New: Cannot change size of Show SQL Code box on run report page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23899 Bug ID: 23899 Summary: Cannot change size of Show SQL Code box on run report page Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To test: - run a report - click "Show SQL Code" - try to use the little tab at the bottom right of the code box to resize the box - the little tab doesn't work! This is a pretty minor annoyance, but the box does default to being pretty large. I see that the div CodeMirror-Scroll has its height set to 100%. If I change that in the inspector to something defined in pixels then the little tab works to change the size in the page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
