[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #15 from Katrin Fischer --- I am not sure if XML is really easier to read here, but enabling translation would be great. :) I'd vote against 'compiling at release time'. If we still need to create SQL files and store them, we should do so continously like we do for CSS etc. as this needs to be testable with current data all the time. Please keep in mind when changing the web installer, that it's currently possible to add additional SQL files to the installer that will be picked up - it would be nice to keep that feature. There is also the option to have a syspref.sql for some additional settings (see de-DE installer) that not all languages have made use of. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23839] Several dead links on community web site
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23839 Katrin Fischer changed: What|Removed |Added CC||andreas.hedstrom.mace@sub.s ||u.se, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #12 from Katrin Fischer --- Thx Lucas and Hayley :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #14 from David Cook --- While we're on this topic, perhaps it's worthwhile talking about something like this: https://metacpan.org/pod/DBIx::Class::Schema::Versioned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #13 from David Cook --- (In reply to David Cook from comment #12) > We could use YAML as a declarative format for the database data, and then > the Release Manager/Release Maintainer could run a tool to compile it into a > SQL script. > This could also be used to add support for different databases, especially in terms of optimizing bulk data loading. https://dev.mysql.com/doc/refman/5.6/en/optimizing-innodb-bulk-data-loading.html https://www.postgresql.org/docs/9.1/ecpg-sql-set-autocommit.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #12 from David Cook --- (In reply to Bernardo Gonzalez Kriegel from comment #11) > Do you think the sequence > a) Read YAML > Write $tmp/out.sql > > DBIx_::RunSQL->run_sql_file($tmp/out.sql) > is a valid approach, or > b) Read YAML > Insert into DB somehow > it's better? > I suppose b) is slower. > Since this is installer data, I don't think it necessarily has to be fast? I figure the most important part is to make it easy to read and update? Actually, I don't know if we necessarily need to change C4/Installer.pm? We could use YAML as a declarative format for the database data, and then the Release Manager/Release Maintainer could run a tool to compile it into a SQL script. If we only do that compilation at release time, it would also be easier to audit and find bugs in the final result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00|19.11.00, 18.11.12 released in|| --- Comment #10 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Hayley Mapley changed: What|Removed |Added Version(s)|19.11.00|19.11.00, 18.11.12 released in|| CC||hayleymap...@catalyst.net.n ||z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Hayley Mapley --- Backported 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23954] Format notes in suggestion management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Hayley Mapley changed: What|Removed |Added Version(s)|19.11.00|19.11.00, 18.11.12 released in|| Status|Pushed to oldstable |Pushed to oldoldstable CC||hayleymap...@catalyst.net.n ||z --- Comment #6 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23952] Fix body id on OPAC course details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Version(s)|19.11.00|19.11.00, 18.11.12 released in|| Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #6 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24250] New: SIP2 returns debarred comment twice in patron screen message AF field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24250 Bug ID: 24250 Summary: SIP2 returns debarred comment twice in patron screen message AF field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com To recreate: 1 - Setup SIP in your testing environment https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 2 - Set a patron to have a restriction 3 - Send a patron status request or patron information command via the SIP cli emulator (see link above) 4 - Note the comment on the restriction is sent twice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Sally from comment #7) > I've just seen: > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 - do those > changes resolve this bug? That one only deals with priority. Question: what permissions would you require for changing the pickup location? Don't think in terms of the current UI, maybe we can add modify_holds_pickup_location for example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Hayley Mapley changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00|19.11.00, 18.11.12 released in|| CC||hayleymap...@catalyst.net.n ||z --- Comment #11 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #7 from Nick Clemens --- Created attachment 96357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96357=edit Bug 23261: (follow-up) Use logged_in_user and move test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Nick Clemens changed: What|Removed |Added Attachment #96038|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 96356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96356=edit Bug 23261: Add notice for login/registering to RBdigital results To test: 1 - You will need a valid library RBDigital account 2 - Fill in the RecordedBooks system preferences 3 - Open the catalog, perform a search with RBDigtal resuls, 'love' often works 4 - Click to the results 5 - Note if not logged you don't see availability 6 - Log in with a patron with no email, note you do not see any notice that you must register your email with RBDigital 7 - Apply patch 8 - Reload results, you now see a notice to register with rbdigital, do so unless you already have an account 9 - Add your associated email to the koha account 10 - Reload results, note you see availability 11 - Log out, reload results 12 - Note you see a promp to login to see availability Signed-off-by: Jessica Zairo Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21939] Permission for holds history tab is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Hayley Mapley changed: What|Removed |Added Version(s)|19.11.00|19.11.00, 18.11.12 released in|| CC||hayleymap...@catalyst.net.n ||z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 --- Comment #18 from Nick Clemens --- Created attachment 96355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96355=edit Bug 14419: [19.05.x] (squashed) Expanding facets (Show more) performs a new search This patch removes the constraint of only passing 5 facets to the template unless the list is expanded, in fact, it removes the 'expanded' attribute from Search.pm Now that all facets are passed to page it adds a 'show more' link at the bottom of lists and allows user to expand or collapse any facet set without reloading page. Updated tests included. To test: 1 - Perform an OPAC search that returns more than 5 of any given facet type 2 - Click the "Show more" link on the facets and see that the search is reloaded 3 - Apply patch 4 - Repeat search 5 - Note that you can click "Show more" without reloading page 6 - Test that page load is not greatly affected 7 - Ensure that all facet links function normally 8 - Ensure that facets are the same a prior to patch 9 - Repeat for staff client 10 - Prove t/Search.t NOTE: This patch makes it much easier to see that there is an existing issue with marking the "active" facet. Ending punctuation seems to confuse the matcher. Signed-off-by: Michal Denar Signed-off-by: Josef Moravec Bug 14419: (QA follow-up) Restore the link styling Test plan: Look at Show more/less links in facets, in opac and staff client --> without this patch they are pure text, no styling, no hand cursor --> with this patch it is link, but continues to work as before Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Hayley Mapley changed: What|Removed |Added Version(s)|19.11.00|19.11.00, 18.11.12 released in|| Status|Pushed to oldstable |Pushed to oldoldstable CC||hayleymap...@catalyst.net.n ||z --- Comment #11 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Hayley Mapley changed: What|Removed |Added CC||hayleymap...@catalyst.net.n ||z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00|19.11.00, 18.11.12 released in|| --- Comment #10 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked ->param
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145 Hayley Mapley changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable CC||hayleymap...@catalyst.net.n ||z Version(s)|20.05.00, 19.11.01 |20.05.00, 19.11.01, released in||18.11.12 --- Comment #7 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Hayley Mapley changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable CC||hayleymap...@catalyst.net.n ||z Version(s)|20.05.00, 19.11.01 |20.05.00, 19.11.01, released in||18.11.12 --- Comment #6 from Hayley Mapley --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23806] FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23806 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED CC||lu...@bywatersolutions.com Status|Pushed to master|RESOLVED --- Comment #5 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23427] Better sorting of previous checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23427] Better sorting of previous checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.01 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #4 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185
Andrew Nugged changed:
What|Removed |Added
Attachment #96151|0 |1
is obsolete||
--- Comment #5 from Andrew Nugged ---
Created attachment 96354
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96354=edit
Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all
unavailable'
When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items + patron, it goes slow.
It happens because in subloop there is checking if all items available so it is
O(n^2) and it re-checks each time the same info for each item with repeating
DB/data requests.
Fix:
The inner loop 1:1 picked out from another loop and put before that items
processing loop,
'items_any_available' variable precalculated,
this variable passed to IsAvailableForItemLevelRequest to be used inside as the
precalculated result.
On tests it gave a drastic improvement in execution time.
Also "$can_item_be_reserved->{status} eq 'OK'" moved in "&&" before
IsAvailableForItemLevelRequest call to cut away if it false before calling to
subroutine.
How to reproduce:
1) on freshly installed kohadevbox create/import one book,
remember that biblionumber for later use it in down below,
2) add 100 items for that book for some library,
3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,
4) check for the rule or set up a single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
that rule should match above book items/library/patron,
check that rule to have a non-zero number of holds (total, daily, count)
allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).
5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create a direct link by yourself, for example, in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4=23529000686353
6) it should be pretty long page generation time on old code, densely
increasing for every hundred items added. In the case of this solution, it's
fast, and time increases a little only, linear.
I tested on my computer in VirtualBox for page generation times,
did 3-5 runs for same case to check if results are stable, and got such values:
(old code):
100 items:38 seconds
200 items: 2.5 minutes
300 items: 5.4 minutes
(version with fix):
100 items: 3.7 seconds
200 items: 6.4 seconds
300 items: 8.7 seconds
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24085] Double submission of forms on returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24085] Double submission of forms on returns.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.01 released in|| CC||j...@bywatersolutions.com --- Comment #27 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #96306|0 |1 is obsolete|| --- Comment #21 from Bernardo Gonzalez Kriegel --- Created attachment 96353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96353=edit Bug 24137: Same fixes for *_local.sql files Signed-off-by: Bernardo Gonzalez Kriegel tested using $ export L=uk-UA (and ru-RU) $ for o in mandatory optional; do for a in installer/data/mysql/$L/marcflavour/marc21/$o/*.sql; do mysql kohatest < $a; done; done -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23705] Add a syspref to enable record locking, so that when one record is opened to be edited, it's read only for other users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23705 Cori Lynn Arnold changed: What|Removed |Added CC||carn...@dgiinc.com --- Comment #2 from Cori Lynn Arnold --- +1 this feature. Having a lot of issues on a time-sensitive cataloging job where multiple catalogers are trying to update the same record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #11 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #9) > Hola Bernado, > I like the idea, but not XML, neither the MySQL only limitation. Salut Jonathan, I don't like XML either, nor the MySQL only. Just remember that I was thinking in translations, and xml support it's included right now. But yaml can be handled. > Why not write our own stuff, yml-based? No problem, I'll write a POC patch, but have a question: Do you think the sequence a) Read YAML > Write $tmp/out.sql > DBIx_::RunSQL->run_sql_file($tmp/out.sql) is a valid approach, or b) Read YAML > Insert into DB somehow it's better? I suppose b) is slower. (In reply to Martin Renvoize from comment #10) > This looks good. My only slight concern is whether it ties us more strictly > to MySQL or in particular a particular MySQL version. (I'm not sure how > widely supported the MySQL XML dump format is.. do they change the format > when new feature are introduced for example and does MariaDB support it > natively too). > > Perhaps we could use the well supported and maintained SQL::Translator to > produce something similar in XML, YAML or JSON as our middle format ? Hi Martin, SQL::Translator documentation states: "Presently only the definition parts of SQL are handled (CREATE, ALTER), not the manipulation of data (INSERT, UPDATE, DELETE)." And this files normally do INSERTs, don't know if it's useful in this case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #55 from Owen Leonard --- I've added a minor follow-up even though this isn't working correctly for me (comment 53). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #54 from Owen Leonard --- Created attachment 96352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96352=edit Bug 7882: (follow-up) Update sorting interaction This follow-up modifies the CSS for the sortable fields so that a different icon is used. Elsewhere in Koha (stock rotation stage sorting) we use the "bars" icon to indicate a sortable element. I think it would be good to continue to use this. The cursor is now styled as a "Move" cursor. The configuration of the sortable function in the script has been updated in two ways: 1. The movement of the element is constrained along the y-axis, and 2. The movement of the element is contstrained to the container within which it can be moved (for the tag, the tab, and for the subfield, the tag). To test, apply the patch and edit a MARC record in the basic cataloging editor. Confirm that the new icon is used, and that the "Move" cursor shows when you hover over the icon. Confirm that a tag can be dragged up and down within the constraints of the visible section. A subfield should be only movable within its parent tag. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Owen Leonard changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #53 from Owen Leonard --- When I test this I am able to drag a tag but when I drop it it returns to its original position. Dragging subfields works to re-order them, but after I save the record the order is back to where it was before. Tested in Firefox and Chrome on Windows 10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 --- Comment #1 from Owen Leonard --- Created attachment 96351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96351=edit Bug 24247: Button fixes for OPAC lists pages This patch makes minor markup changes to the OPAC lists page so that link and form controls are styled consistently. To test you should have virtualshelves and OpacAllowSharingPrivateLists enabled. - Apply the patch and log in to the OPAC. - Create a new private list. - When you view the list of your private lists, the "Share" link should have a Font Awesome icon. - View the contents of your list. The "Share" link in the list toolbar should have the same icon. The "New list" link should have a + icon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24226] Advanced editor - drops subfields/punctuation when manually linking authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24226 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #7 from Jonathan Druart --- There will be a warning on the detail page of the problematic record anyway (from bug 23846) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Owen Leonard changed: What|Removed |Added Blocks||24247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 [Bug 24247] Button fixes for OPAC lists pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 Owen Leonard changed: What|Removed |Added Depends on||24249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 [Bug 24249] OPAC lists page should require login for login-dependent operations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 --- Comment #1 from Owen Leonard --- Created attachment 96350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96350=edit Bug 24249: OPAC lists page should require login for login-dependent operations This patch modifies opac-shelves.pl so that login is required if the requested operation is anything but "view" and "list." To test, apply the patch and go to the lists page in the OPAC while not logged in. - Click the "Log in to create a new list" link. - Log in. - You should be taken to the "Create a new list" form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 ByWater Sandboxes changed: What|Removed |Added Attachment #96348|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 96349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96349=edit Bug 24234: fix css in staff search results Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 ByWater Sandboxes changed: What|Removed |Added Attachment #96290|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 96348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96348=edit Bug 24234: fix css in staff search results Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.01 released in|| --- Comment #6 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24249] New: OPAC lists page should require login for login-dependent operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Bug ID: 24249 Summary: OPAC lists page should require login for login-dependent operations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Currently the OPAC lists page doesn't require a login to access pages like the list-creation form. It would be a more seamless process for users if they were prompted to log in before reaching those forms. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.01 released in|| --- Comment #8 from Joy Nelson --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24234] Spacing of availability note in intranet search results unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24234 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2 from Andrew Fuerste-Henry --- Had to install yarn to get it to work on a sandbox, but otherwise looks good! Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #8 from Agustín Moyano --- Fixed atomic update file. I missed in line 6 when it checked if column exists it said 'time_sent' instead of 'time_status_changed' as it should. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #7 from Agustín Moyano --- Created attachment 96347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96347=edit Bug 23673: Add "Time status changed" column to patron's notices This patch adds "Time status changed" column to patron's notices tab. It also adds logic to C4::Letters to update time_status_changed column when status is changed, and leaves time_queued with message creation time. To test: 1. Apply patches. 2. Restart plack. 3. Choose a patron and add a purchase suggestion. 4. Change suggestion status. 5. Open patron's notifications. CHECK => Messages table has now "Time status changed" and "Time created" columns, and "Time" column is gone. SUCCESS => There is a message with status pending, with a "time created" and no "time status changed" 6. Execute in the shell in Koha directory $ ./misc/cronjobs/process_message_queue.pl 7. Open patron's notifications one more time. SUCCESS => The message changed status. Time created remained the same, and now "time status changed" has the current timestamp. 8. Resend the message and repeat sep 6. SUCCESS => Every time you change the status, time created remains the same and time status changed updates. 9. prove t/db_dependant/Letters.t 10. Sign off Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Agustín Moyano changed: What|Removed |Added Attachment #94503|0 |1 is obsolete|| Attachment #96232|0 |1 is obsolete|| --- Comment #6 from Agustín Moyano --- Created attachment 96346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96346=edit Bug 23673: change db structure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream, and fudge flavors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com --- Comment #6 from Jessie Zairo --- Chocolate and Peanut Butter Chip Cookies 3/4 cup HERSHEY'S Cocoa REESE'S Peanut Butter Chips (10-oz. pkg.) 2 1/2 sticks butter, softened 2 eggs 2 cups sugar 2 teaspoons vanilla extract 2 cups all-purpose flour 1 teaspoon baking soda 1/2 teaspoon salt Directions Heat oven to 350°F. Stir together flour, cocoa, baking soda, and salt; set aside. Beat butter and sugar in large bowl with mixer until fluffy. Add eggs and vanilla; beat well. Gradually add flour mixture, beating well. Stir in peanut butter chips. Use a scooper and roll dough in hands to form a ball and place on cookie sheet. Bake 8 to 9 minutes. Cool and move from cookie sheet to wire rack. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #6 from Liz Rea --- From a troubleshooting point of view, that would be nice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23838] Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #31 from Tomás Cohen Arazi --- Andrew, I think we will need to adapt this one to the new idea of putting the mapping on the Koha::Object level. We can chat about it whenever you want/need to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613
--- Comment #26 from Tomás Cohen Arazi ---
(In reply to Joonas Kylmälä from comment #25)
> Also, would we be able to do this without having to duplicate the endpoint
> definition by using the existing definition for /checkouts endpoint by
> replacing
>
> > "$ref": "paths/checkouts.json#/~1patrons~1{patron_id}~1checkouts"
>
> with
>
> > $ref": "paths/checkouts.json#/~1checkouts~1{patron_id}
As-is, the patch looks correct and what Martin and I have been saying. I
haven't tried or run the tests to verify it is functional, but it looks exactly
as what we would've expected when saying 'alias'.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #88398|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #88399|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #88400|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #88396|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #88395|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #88394|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #94467|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #94465|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #94466|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #88397|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #88394|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #94468|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #94464|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen changed: What|Removed |Added Attachment #94463|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #36 from Jonathan Druart --- Created attachment 96345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96345=edit Bug 23233: Fix UsageStats.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2124] Change sequence of MARC fields when cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2124 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |RESOLVED --- Comment #5 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 7882 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What|Removed |Added CC||neng...@gmail.com --- Comment #52 from Jonathan Druart --- *** Bug 2124 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What|Removed |Added Attachment #94837|0 |1 is obsolete|| --- Comment #51 from Jonathan Druart --- Created attachment 96344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96344=edit Bug 7882: Add ability to move and reorder fields in MARC editor Use jQueryUI sortable to make fields and subfields moveable in the MARC editor for both records and authorities. This patch convert items from div's to ul's and consequently alter css and js to match. It also replace the up arrow with a more adapted icon (from font awesome). Primary authorship by Elliott Davis. To Test: 1. Add or edit a record in cataloguing module. 2. You should be able to move the fields and subfields around. - You can click on any part of the element to drag it, the move icon to the left of the item is a good place to do it. => You can only change the order of fields of the same tag. 3. Make sure all of the javascript driven fonctionnality still work : - Duplicate fields/subfields - Remove fields/subfields - Using the tag editor for control fields or to link authorities - etc 4. Reorder some fields/subfields and save the record. 5. Edit the record again. 6. The order in the editor should match the changes which were saved. - Empty subfields should appear after the ones with content. 7. Repeat steps 1-6 with the authority editor. Signed-off-by: Séverine QUEUNE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24243] Bad characters in MARC cause internal server error when searching catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #5 from Jonathan Druart --- (In reply to Nick Clemens from comment #4) > Shouldn't we log the error? There is a check in search_for_data_inconsistencies.pl, so I'd say it's not needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22613] Add /patrons/patron_id/checkouts endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22613
--- Comment #25 from Joonas Kylmälä ---
Also, would we be able to do this without having to duplicate the endpoint
definition by using the existing definition for /checkouts endpoint by
replacing
> "$ref": "paths/checkouts.json#/~1patrons~1{patron_id}~1checkouts"
with
> $ref": "paths/checkouts.json#/~1checkouts~1{patron_id}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #50 from Jonathan Druart --- (In reply to Jonathan Druart from comment #49) > This is working great! > > 2 smalls things: > - required fields (the subfield's lib) are red > https://snipboard.io/CMuDYp.jpg > Is that expected? Sorry, that is coming from bug 24090. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #49 from Jonathan Druart --- This is working great! 2 smalls things: - required fields (the subfield's lib) are red https://snipboard.io/CMuDYp.jpg Is that expected? - Do we really need the sort icon for each subfield? And, not blocker for this bug report (regarding its age), but we could remove the "sortable" option for fields that cannot be duplicated for instance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #38 from Nick Clemens --- (In reply to Jonathan Druart from comment #34) > (In reply to Nick Clemens from comment #22) > > (In reply to Jonathan Druart from comment #19) > > > + [% NEXT IF display_name.length == 5 %] > > > > > > Hum?? > > Ah, the indents in the file were adding 5 spaces - I didn't know where they > > had come from but found that solution. Improved now. > > > +[% NEXT IF display_name.length == 5 %] > > Still there? > > Also there are debug statements in the last patch. Looks like something happened in a rebase, patches restored and cleaned up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 --- Comment #37 from Nick Clemens --- Created attachment 96343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96343=edit Bug 17374: (follow-up) Unit tests and remove warns Signed-off-by: Maxime Dufresne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Nick Clemens changed: What|Removed |Added Attachment #74828|0 |1 is obsolete|| Attachment #94891|0 |1 is obsolete|| Attachment #94892|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 96341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96341=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly Signed-off-by: Maxime Dufresne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
