[Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Marcel de Rooy changed: What|Removed |Added Attachment #97437|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Marcel de Rooy changed: What|Removed |Added Attachment #97435|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 97475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97475=edit Bug 24423: Add biblionumber to modify items link To test: - Find/create a bib with at least one item - From detail.pl, use the checkboxes in the holdings table to select one or more items - click the "Modify Selected Items" link just above the holdings table to take your item(s) to batch modification - Change something and click save - Observe that the Return to the Record link points to a url without a biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber=" - Apply patch - Repeat - The link now works! Signed-off-by: Nick Clemens Signed-off-by: David Nind Bug 24423: Fix for deletion - cleanup accidental debug inclusiopm To test: Repeat prior test plan with 'Delete selected' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24423] Broken link to return to record after batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #7 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24442] New: Setup Database fails: Cannot delete or update parent row: foreign key constraint fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24442 Bug ID: 24442 Summary: Setup Database fails: Cannot delete or update parent row: foreign key constraint fails Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: seemaal...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com I have the SQL server on Google Cloud which is a remote DB. The setup succeeded and I got the web installer running. In the web installer, the setup of database fails. On checking the db, there are some 52 tables that are created in the database. The setup fails because ISAM engine is disabled. Found that Cloud SQL has disabled ISAM and only uses InnoDB. Is there a workaround to setup Koha on Google Cloud? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Marcel de Rooy changed: What|Removed |Added Attachment #97473|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 97474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97474=edit Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15265] Add Instagram and Pinterest to social media links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265 --- Comment #7 from Katrin Fischer --- (In reply to Owen Leonard from comment #6) > Instagram doesn't have sharing tools as far as I can tell. I'm not sure how > that would even work. > > Pinterest is so image-oriented that I'm not sure how useful it would be in > cases where there weren't a cover image Hm, I wonder if we should close this WONTFIX for now - I am not sure if there could be a legal problem using the cover images even? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart --- Martin, I asked you when I wrote bug 23991 and I think we agreed it was suggester, not suggestor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 --- Comment #6 from Katrin Fischer --- Thx Caroline and David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24436] Record if a transfer was triggered by a 'hold'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 Katrin Fischer changed: What|Removed |Added Summary|Record if a transfer was|Record if a transfer was |triggered by a 'reserve'|triggered by a 'hold' CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in apache-shared-intranet.conf
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=0 --- Comment #5 from Marcel de Rooy --- (In reply to Nick Clemens from comment #4) > Worked beautifully, once i figured out how to test in a gitified install ;-) > > Hint: Copy the changed line to: > /etc/koha/apache-shared-intranet-git.conf Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15265] Add Instagram and Pinterest to social media links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265 --- Comment #6 from Owen Leonard --- Instagram doesn't have sharing tools as far as I can tell. I'm not sure how that would even work. Pinterest is so image-oriented that I'm not sure how useful it would be in cases where there weren't a cover image -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395 Caroline Cyr La Rose changed: What|Removed |Added Attachment #97432|0 |1 is obsolete|| --- Comment #5 from Caroline Cyr La Rose --- Created attachment 97473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97473=edit Bug 24395: Show initial float using the Price TT plugin on summary page For displaying monetary amounts, we should be using the Price TT plugin everywhere. This adds it to the cash register summary page. To test: - Create a cash register - Check the cash register table for "Initial float" - Verify the amount shows with more than 2 decimals - Edit cash register - verify the same display there - Apply patch - Check again - it should display now with only 2 decimals Signed-off-by: David Nind Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #9 from Jonathan Druart --- Created attachment 97471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97471=edit Bug 24161: Remove GetLateOrders Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 --- Comment #10 from Jonathan Druart --- Created attachment 97472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97472=edit Bug 24161: Add tests Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart changed: What|Removed |Added Attachment #97117|0 |1 is obsolete|| Attachment #97118|0 |1 is obsolete|| Attachment #97119|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 97470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97470=edit Bug 24161: Keep tracks of late orders claims So far we only record the number of claims and the date of the last claim, in the aqorders table. To keep track of the different claim dates, this patchset is going to make the following DB changes: * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on) * Remove the two columns from the aqorders table: claims_count and claimed_date This will allow to display the different claim dates where needed: on the late orders page, and the basket page. To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders has been moved to Koha::Acquisition::Orders->filter_by_late That way we are going to add consistency, robustness, and cover the feature with new tests. Test plan: 0/ Create a bunch of new orders. Make sure they are from different vendor (with different delivery time). 1/ Go to the late orders page and claim some orders 2/ Reclaim some of those orders 3/ Confirm that you can see the different claim dates for a given orders (the history of the late orders claims is kept and displayed) 4/ Bonus point: Regression tests: a. Modify the closedate of the basket in the database. That will allow you to make sure the patch set did not introduce regressions. It would be good to test the different filters on the late orders page: * delay * Estimated delivery date from/to * Vendor b. Confirm that the subtotal and the total values from the late orders page is correct. c. Test the update database entry: do not apply these patches, claims some orders against master. Apply the patch, execute the update DB entry then confirm that the number of claims is correct (note that the dates will not as it is not possible to guess them). QA note: the branchcode parameter has been removed from filter_by_late. At first glance it seems that it was not used. Sponsored-by: Cork Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24161] Late orders improvements - keeping track of claims
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24441] Error when checking in an item with BranchTansferLimitsType set to itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 --- Comment #1 from Kyle M Hall --- Created attachment 97469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97469=edit Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24441] Error when checking in an item with BranchTansferLimitsType set to itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24441] Error when checking in an item with BranchTansferLimitsType set to itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24441] Error when checking in an item with BranchTansferLimitsType set to itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24441] New: Error when checking in an item with BranchTansferLimitsType set to itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 Bug ID: 24441 Summary: Error when checking in an item with BranchTansferLimitsType set to itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||k...@bywatersolutions.com, ||l...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 97468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97468=edit Bug 24440: Add ->holds and ->holds_count to Koha::Acquisition::Order This patch introduces a method to fetch the holds associated with the items associated to an order line. It also adds a method to get that holds count, which will be handy on the API for embedding such information on request. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Order.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 97467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97467=edit Bug 24440: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com, ||l...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Tomás Cohen Arazi changed: What|Removed |Added Blocks||20212 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Depends on||24440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 [Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24440] New: Add ->holds and ->holds_count to Koha::Acquisition::Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 Bug ID: 24440 Summary: Add ->holds and ->holds_count to Koha::Acquisition::Order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org We need such accessors -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Depends on||24435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 [Bug 24435] Add Koha::Biblio->items_count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Blocks||20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24439] New: Bulkmarcimport.pl Update documentation for -match option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24439 Bug ID: 24439 Summary: Bulkmarcimport.pl Update documentation for -match option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: carn...@dgiinc.com QA Contact: testo...@bugs.koha-community.org The -match option for bulkmarcimport says: -match= FIELD matchindex,fieldtomatch matchpoint to use to deduplicate fieldtomatch can be either 001 to 999 or field and list of subfields as such 100abcde This seems to indicate that you put a number in the FIELD parameter, but really you are putting the "Koha Search Index" text a comma and then the MARC field: -match= or -match=Control-number,001 I was only able to figure this out because someone else was confused: http://koha.1045719.n5.nabble.com/bulkmarcimport-pl-AND-match-fails-when-trying-to-import-bibliographic-records-td5969334.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24438] index can fail on timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24438 Nick Clemens changed: What|Removed |Added CC||alex.arn...@biblibre.com, ||ere.maij...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24438] New: index can fail on timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24438
Bug ID: 24438
Summary: index can fail on timeout
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Searching - Elasticsearch
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
We have seen occasional timeouts when indexing elasticsearch, these cause the
indexing to stop and fail.
We should handle the response as the code indicates:
102 sub update_index {
103 my ($self, $biblionums, $records) = @_;
104
105 my $conf = $self->get_elasticsearch_params();
106 my $elasticsearch = $self->get_elasticsearch();
107 my $documents = $self->marc_records_to_documents($records);
108 my @body;
109
110 for (my $i=0; $i < scalar @$biblionums; $i++) {
111 my $id = $biblionums->[$i];
112 my $document = $documents->[$i];
113 push @body, {
114 index => {
115 _id => $id
116 }
117 };
118 push @body, $document;
119 }
120 if (@body) {
121 my $response = $elasticsearch->bulk(
122 index => $conf->{index_name},
123 type => 'data', # is just hard coded in Indexer.pm?
124 body => \@body
125 );
126 }
127 # TODO: handle response
128 return 1;
129 }
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24437] Circulation Rules are not Respecting Correct Rule if Library is Using Hard Due Dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24437 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23382 --- Comment #1 from Nick Clemens --- Issue here is fixed in bug 23382 - either it shoudl eb backported or we should cherry pick from commit f8e2c489cb668aab9e7484c2dd67c1c05f37b2a5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24437 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Owen Leonard changed: What|Removed |Added Attachment #96899|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 97466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97466=edit Bug 24363: Datepicker calendar is not sexy on additem.pl This patch is essentially an alternative to Bug 24181. Instead of trying to make the datepicker inputs match default fields, it defines a default style for text inputs, selects, and textareas. This new default style borrows some from Bootstrap's input styling and some from the Select2 plugin's style. This makes forms like the one on the add item page have unified styling for all fields. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test as many pages as you can to look for consistent styling of form fields: Patron entry, cataloging (basic and advanced), reports, batch item modification, system preferences, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24436] Record if a transfer was triggered by a 'reserve'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 Martin Renvoize changed: What|Removed |Added Blocks|4234, 23092 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What|Removed |Added Depends on|24436 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 [Bug 24436] Record if a transfer was triggered by a 'reserve' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize changed: What|Removed |Added Depends on|24436 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 [Bug 24436] Record if a transfer was triggered by a 'reserve' -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 Martin Renvoize changed: What|Removed |Added Blocks|24297 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 [Bug 24297] Record if a transfer was triggered 'manually' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24297] Record if a transfer was triggered 'manually'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 Martin Renvoize changed: What|Removed |Added Depends on|24299 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 [Bug 24299] Record if a transfer was triggered by 'rotating collections' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24297] Record if a transfer was triggered 'manually'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 Martin Renvoize changed: What|Removed |Added Blocks|24436 | Depends on||24436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 [Bug 24436] Record if a transfer was triggered by a 'reserve' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24436] Record if a transfer was triggered by a 'reserve'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 Martin Renvoize changed: What|Removed |Added Depends on|24297 | Blocks||24297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 [Bug 24297] Record if a transfer was triggered 'manually' -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What|Removed |Added Depends on||24436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 [Bug 24436] Record if a transfer was triggered by a 'reserve' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize changed: What|Removed |Added Depends on||24436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 [Bug 24436] Record if a transfer was triggered by a 'reserve' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24437] New: Circulation Rules are not Respecting Correct Rule if Library is Using Hard Due Dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24437 Bug ID: 24437 Summary: Circulation Rules are not Respecting Correct Rule if Library is Using Hard Due Dates Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: n...@bywatersolutions.com Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If a library has a circulation rule specific to their library and contains a Hard Due Date and also a circulation rule with a hard due date (set in the past) in the "Standard" set of rules, Koha is calling the standard rule first and then when prompted with a Yellow Box to enter a due date, if hit "Yes", Koha will then call the right rule (library-specific rule). Test: 1. Have a rule set up in a library-specific branch set with Hard Due Before Date in Future 2. Have the same rule set up in the standard set of rules with a Hard Due date set in the past. 3. Check out a book in the library that there is a library-specific rule. 4. Koha will call the standard set of rules, will be unable to assign a due date since it is in the past and present a library with a yellow box to enter a date. 5. If library hits YES without setting a date, Koha will call the due date using the correct (library-specific rules). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 Martin Renvoize changed: What|Removed |Added Blocks||24436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 [Bug 24436] Record if a transfer was triggered by a 'reserve' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24297] Record if a transfer was triggered 'manually'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 Martin Renvoize changed: What|Removed |Added Blocks||24436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 [Bug 24436] Record if a transfer was triggered by a 'reserve' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24436] New: Record if a transfer was triggered by a 'reserve'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436 Bug ID: 24436 Summary: Record if a transfer was triggered by a 'reserve' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, koha-bugs@lists.koha-community.org, kyle.m.h...@gmail.com, testo...@bugs.koha-community.org Depends on: 24297, 24299 Blocks: 4234, 23092 Using the new 'trigger' field in branchtransfers to record if a transfer was added by a reserve. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 [Bug 24297] Record if a transfer was triggered 'manually' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 [Bug 24299] Record if a transfer was triggered by 'rotating collections' -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24297] Record if a transfer was triggered 'manually'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 Martin Renvoize changed: What|Removed |Added Blocks|22569 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What|Removed |Added Depends on||24297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 [Bug 24297] Record if a transfer was triggered 'manually' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Depends on|24297 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 [Bug 24297] Record if a transfer was triggered 'manually' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24297] Record if a transfer was triggered 'manually'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297 Martin Renvoize changed: What|Removed |Added Blocks||23092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 --- Comment #2 from Martin Renvoize --- Created attachment 97465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97465=edit Bug 24299: Record 'RotatingCollection' as a transfer trigger -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24299] Record if a transfer was triggered by 'rotating collections'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299 --- Comment #1 from Martin Renvoize --- Created attachment 97464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97464=edit Bug 24299: Add 'RotatingCollection' branchtransfer trigger -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 97463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97463=edit
Bug 24435: Add Koha::Biblio->items_count
This patch introduces a handy shortcut to get the items count for a
biblio. So instead of calling:
$count = $biblio->items->count;
you can call:
$count = $biblio->items_count;
The use case for this, is when we want to embed information on objects
to be sent as API responses. In that case, calling ->items->count needs
to be done manually on the controller script, with interesting added
complexity. With this kind of method, we can just require it to be
embedded automagically by calling the following on the API:
$biblio->to_api({ embed => { items_count => {} } });
If there are several nested layers of objects, doing manually can get
really tricky and error prone.
To test:
1. Apply this patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 97462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97462=edit Bug 24435: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24435] New: Add Koha::Biblio->items_count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 Bug ID: 24435 Summary: Add Koha::Biblio->items_count Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org This simple method can be used in several places. For example for embedding counts on related API objects. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Maryse Simard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #40 from Maryse Simard --- I've reattached the commits with corrected message titles. I also added a new patch to correct the popup message, it should now show "1 batch to export" when exporting a barcode range. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #39 from Maryse Simard --- Created attachment 97461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97461=edit Bug 7468: fix the export labels popup header When exporting a barcode range, the export popup should display "1 batch to export" instead of "0 batches to export". In this context, it can be considered a label batch and should be counted as such. To test: When clicking the "Print range" button, the popup should show "1 batch to export". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Maryse Simard changed: What|Removed |Added Attachment #91569|0 |1 is obsolete|| --- Comment #37 from Maryse Simard --- Created attachment 97459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97459=edit Bug 7468: (follow-up) fix label-edit-range template Edit the labels/label-edit-range.tt template to follow current standards : - Use footer javascript - Use bootstrap grid - Use jQuery Validation plugin for validation Also fixes breadcrumbs to be more specific. To test: Make sure the page looks correct and still works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #36 from Maryse Simard --- Created attachment 97458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97458=edit Bug 7468: (follow-up) Make sure only integers are accepted as from/to values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #35 from Maryse Simard --- Created attachment 97457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97457=edit Bug 7468: Showing the error message according to the community interface patterns, fixing a javascript condition TEST PLAN++ 1) Apply all the patches 2) Connect to the intranet with an account with permissions to visit the "Tools" page 3) Go to /cgi-bin/koha/labels/label-home.pl . Either by entering the URL directly . OR, from the front page, by clicking "Tools", followed by the hyperlink "Label creator" under the "Catalog" section 4) Under the "+ New" button, a new option should be available: "Barcode range" 5) Fill the "From:" and the "To:" fields of the "Print barcode range" form . Keeping both fields at "0" should trigger a warning beside the first field: "*Cannot be smaller than 1" . If the value "From:" is greater the "To:" value, a warning should appear beside the second field: "*Cannot be smaller than the starting value" . Make sure the form doesn't let you enter non-numerical values . For a casual test, use "From: 1000" and "To: 1100" 6) After pressing the "Print Range" button, choose a template, a layout, and a starting position . The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of 0pt, don't use it . All the default layouts should look alike, since we're only printing a barcode over a number, and not bibliographic information . Using a layout not defined as 'Barcode' will show a warning message 7) Clicking the "Export" button should lead to a second dialog window with a "Download as PDF" hyperlink. Clicking the link should prop up a download dialog box 8) Save the PDF locally, or simply open it, and make sure the options you used were taken into account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Maryse Simard changed: What|Removed |Added Attachment #91570|0 |1 is obsolete|| --- Comment #38 from Maryse Simard --- Created attachment 97460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97460=edit Bug 7468: (follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #32 from Maryse Simard --- Created attachment 97454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97454=edit Bug 7468: Print barcodes by range Adds an option to the label creator to print a range of barcodes. Only allows printing to PDF. C4/Label.pm had to get minor changes to override database-based barcode generation. Same with labels/label-create-pdf.pl. By default, the barcode is fetched from the database using the itemnumber, but when printing ranges, you might not have a corresponding database entry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #34 from Maryse Simard --- Created attachment 97456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97456=edit Bug 7468: Add warning when range has non-existent barcodes + Added a warning when the user selects a range with some non-existent barcodes, and a layout without barcodes. This allows the user to print barcodes of items not in the database if he so desires, but will warn him if he tries to print only biblios (which results in missing entries or a blank page). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7468] Add label to batch by barcode range
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #33 from Maryse Simard --- Created attachment 97455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97455=edit Bug 7468: Fix 'false' message on Firefox It seems I was using an href to a javascript function in the 'Print Range' button, which Chrome didn't mind, but Firefox did understand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377
ByWater Sandboxes changed:
What|Removed |Added
Attachment #97442|0 |1
is obsolete||
--- Comment #6 from ByWater Sandboxes ---
Created attachment 97453
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97453=edit
Bug 24377: Record passed branch if renewing via cron
To test:
1 - Checkout an item with auto renewal set and eligible for auto renew
2 - Set no renewal before in the circ rules to 99 (something greater than the
checkout period)
3 - perl misc/cronjobs/automatic_renewals.pl
4 - Check the statistics table, note the branch for renewal is null
SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL'
5 - Apply patch
6 - Repeat 1-4
7 - Note the branch is set to the issuing branch
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Ed Veal
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24273] Add IIIF compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24273 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in apache-shared-intranet.conf
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=0 --- Comment #4 from Nick Clemens --- Worked beautifully, once i figured out how to test in a gitified install ;-) Hint: Copy the changed line to: /etc/koha/apache-shared-intranet-git.conf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in apache-shared-intranet.conf
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=0 Nick Clemens changed: What|Removed |Added Attachment #97444|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 97452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97452=edit Bug 0: Fix bib Apache rewrite rule for intranet Trivial change. Speaks for itself. Since koha/detail.pl does not exist, we cannot break things ;) Test plan: [1] Copy the change in apache-shared-intranet.conf to your actual apache configuration. Probably in /etc/koha/. [2] Restart Apache. [3] Try a biblionumber say 123 on intranet with [your_staff_client]/bib/123. Does the detail page come up? Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in apache-shared-intranet.conf
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=0 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #1 from Martin Renvoize --- Created attachment 97450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97450=edit Bug 24298: Add return enums to branchstransfer triggers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 --- Comment #2 from Martin Renvoize --- Created attachment 97451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97451=edit Bug 24298: Record transfer triggers for returns This patch adds handling to catch transfers that may have been triggered on item return. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #1 from Martin Renvoize --- Created attachment 97449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97449=edit Bug 24434: Remove updateWrongTransfer This patch simply removes the unused updateWrongTransfer method from C4::Circulation. Test plan: Read code and varify that the method would never actually be triggered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 97446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97446=edit Bug 24430: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 97448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97448=edit Bug 24430: Remove CountBiblioInOrders and its traces This patch replaces the only uses of CountBiblioInOrders and makes that code use $biblio->orders->count instead. Test nothing breaks in basket.pl and parcel.pl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97415|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 97447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97447=edit Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio This patch introduces an accessor to the related orders, and a method that returns the active orders count. The target usage for the count is the API. In the rest of the codebase, we would just call: $biblio->orders->count To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97414|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added Attachment #97443|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24298] Record if a transfer was triggered by 'return to homebranch'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 Martin Renvoize changed: What|Removed |Added Depends on||24434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added Blocks||24298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 [Bug 24298] Record if a transfer was triggered by 'return to homebranch' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] New: C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Bug ID: 24434 Summary: C4::Circulation::updateWrongTransfer is never called and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org As far as I can tell, the only place that used to call updateWrongTransfer was circ/returns.pl, but the corresponding template no longer passes the parameter used to trigger the call ever. I think we can safely remove the call and corresponding method. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
