[Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This fix updates the help
  release notes||links for 09x, 59x, and 69x
   ||fields in the basic and
   ||advanced MARC21 editor. The
   ||links now go to the correct
   ||Library of Congress
   ||documentation pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

--- Comment #1 from Agustín Moyano  ---
Created attachment 98612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98612=edit
Bug 24561: Datatables api wrapper also filter and order embedded columns

This patch adds the ability to filter and order by embedded columns.

To use it you must in JS:

$('datatable_selector').api({datatables_options})

where datatables_options are all datatables options plus:

1. embed: [list of embeddable tables]
   This option adds x-koha-embed header to request.

2. header_filter: true|false
   This option if true sets x-koha-query header with stringyfied json of
filters

Oderable and searchable columns must define data option as string, otherwise
filter and order won't be possible.
If you must custom the output, use the render function.

For example:

* Don't

> $('.table_selector').api({
>   columns: [
> {
>   data: function(row, type, val, meta) {
> return ''+row.holds.patron.firstname+'';
>   },
>   orderable: true,
>   searchable: true
> }
>   ]
> });

* Do

> $('.table_selector').api({
>   columns: [
> {
>   data: 'holds.patron.firstname',
>   render: function(row, type, val, meta) {
> return ''+row.holds.patron.firstname+'';
>   },
>   orderable: true,
>   searchable: true
> }
>   ]
> });

To test you must implement and test bug 20936, where it will be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

Agustín Moyano  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24561] Add embedded column order by and filter features to datatables api wrapper

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

Agustín Moyano  changed:

   What|Removed |Added

Summary|Add embedded column filter  |Add embedded column order
   |feature to datatables api   |by and filter features to
   |wrapper |datatables api wrapper

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24615] REST API order by prefetched columns

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615

Agustín Moyano  changed:

   What|Removed |Added

 Blocks||24561


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561
[Bug 24561] Add embedded column filter feature to datatables api wrapper
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24561] Add embedded column filter feature to datatables api wrapper

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561

Agustín Moyano  changed:

   What|Removed |Added

 Depends on||24615


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24615
[Bug 24615] REST API order by prefetched columns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24585] Add 'Managed on' and 'Suggested on' columns to pat_purchase_suggestions.tt

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24585

Hasina  changed:

   What|Removed |Added

 CC||shum...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14620] Contact information validations

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #29 from David Nind  ---
Patch no longer applies 8-(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562

Jawad Makki  changed:

   What|Removed |Added

   Severity|major   |critical
   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Agustín Moyano  changed:

   What|Removed |Added

  Attachment #98606|0   |1
is obsolete||

--- Comment #18 from Agustín Moyano  ---
Created attachment 98611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98611=edit
Bug 24502: (follow-up) Add all 3 query parameters in api definition

This patch adds api definition for body, query or header parameters.

To use them include:

* "$ref": "../parameters.json#/q_body" for body parameter.
* "$ref": "../parameters.json#/q_param" for query parameter.
* "$ref": "../parameters.json#/q_header" for header parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11887] Add script for collections agency reports

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #14 from David Nind  ---
(In reply to Katrin Fischer from comment #13)
> Hm, have you run it from koha-shell? But it could also be caused by all the
> changes to the Accounts code.

I did - other scripts ran okay. Changing status to Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

--- Comment #29 from Agustín Moyano  ---
(In reply to Catherine E. Ingram from comment #28)
> (In reply to Agustín Moyano from comment #27)
> > (In reply to Catherine E. Ingram from comment #21)
> > > We were playing around with it this morning and wondered about roll out. 
> > > The way it looked in the sandbox was that it would default to all existing
> > > patrons getting NO notices (with both email and digest un-checked). Did
> > > anyone else encounter this?  
> > > ~Catherine
> > 
> > Hi Catherine, you were right.. I believed that if I didn't add that
> > preference on patrons that already had preferences setted, Koha would break,
> > but it didn't happen at the end.
> > 
> > Thanks for spotting that out.
> > 
> > Can you please try it out again?
> > 
> > Thanks.
> 
> Hi Agustín,
> 
> We have tested the latest patch you have submitted.
> 
> After applying the patch, we notice that all patrons will have Auto Renewals
> UNCHECKED for both Email and Digest.  This means NO Auto Renewal
> communication after we apply the patch.
> 
> This is a problem, because patrons will suddenly stop receiving all Auto
> Renewal communication unless they re-configure their preferences
> individually.
> 
> Can we request that the patch updates ALL patrons to have both Email and
> Digest CHECKED for the Auto Renewal function?
> 
> Thank you!
> Catherine

Hi Catherine, I'm afraid that setting email and digest checked for all patrons
would break the rule of keeping behavior as it is when upgrading..

Current behavior would match by making email checked and digest unchecked, but
if I set that in every patron's preference that would mean that to get digest
messages every patron should set that up individually.

So, what I propose is not to set any preference in patron, but set email
checked and digest unchecked for every patron category. 

That way, I believe behavior whould be the same after update, and if a library
wants digest messages for there patrons, they only have to set that once in
patrons categories.

What do you think?

Regards
Agustín.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #15 from Katrin Fischer  ---
Awesome to see the old and bad moving - thx guys!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11887] Add script for collections agency reports

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887

--- Comment #13 from Katrin Fischer  ---
Hm, have you run it from koha-shell? But it could also be caused by all the
changes to the Accounts code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24608] Allow modification of checkout due date

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
*** Bug 22064 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22064] Allow to change due date of an item without requiring checkin or renewal

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22064

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer  ---
Choosing the newer bug in this case as it's assigned (hopefully to be worked
on)

*** This bug has been marked as a duplicate of bug 24608 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18231] Add the missing id-column to koha.issuingrules-table for DBIC fixtures

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|Failed QA   |RESOLVED

--- Comment #28 from Katrin Fischer  ---
issuingrules is gone - so this turns into "INVALID".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24607] XSLT output should be listed in MARC tag order

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24607

--- Comment #4 from Katrin Fischer  ---
I wonder if this is a librarian vs users thing. As a user, I would expect the
first author and other authors to be be displayed together - having to scroll
way back down for the second author would not make sense to me, as the whole
first/second thing is a bit of an artificial librarian thing.

It's also very based on how MARC is structured - in Germany we used to have our
own format (MAB) and also a big part of cataloguing is still not done in MARC,
but based on the internal format of our union catalogs.

I'd argue we should always try to keep things in an order, that makes sense
from the content. MARC lends to that, but not totally.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them

2020-02-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #28 from David Nind  ---
For whatever reason I can't seem to get the 'onpayment' option to show up for
MarkLostItemsAsReturned. (Applied patch, ran database update, restart_all).

For the tests I get this fail:
root@50d5e409ced0:koha(bz24474)$ prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 30/47 
#   Failed test 'Should have a single 10 days overdue fine and lost
charge'
#   at t/db_dependent/Circulation.t line 2344.
#  got: '27'
# expected: '17'
# Looks like you failed 1 test of 3.

#   Failed test 'bug 22877'
#   at t/db_dependent/Circulation.t line 2347.
# Looks like you failed 1 test of 5.
t/db_dependent/Circulation.t .. 31/47 
#   Failed test 'AddReturn | is_overdue'
#   at t/db_dependent/Circulation.t line 2347.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO
`account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with
ParamValues: 0=-99, 1='25', 2='Lost Item Found'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO
`account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with
ParamValues: 0=-99, 1='28', 2='Lost Item Found'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO
`account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with
ParamValues: 0=-74, 1='33', 2='Lost Item Found'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO
`account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with
ParamValues: 0=-100, 1='37', 2='Lost Item Found'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
t/db_dependent/Circulation.t .. 45/47 # Looks like you planned 2 tests but
ran 1.
t/db_dependent/Circulation.t .. 47/47 
#   Failed test 'Do not return on renewal (LOST charge)'
#   at t/db_dependent/Circulation.t line 3689.
# Looks like you failed 2 tests of 47.
t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/47 subtests 

Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 512 Tests: 47 Failed: 2)
  Failed tests:  31, 47
  Non-zero exit status: 2
Files=1, Tests=47, 29 wallclock secs ( 0.09 usr  0.00 sys + 23.87 cusr  2.77
csys = 26.73 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/