[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 David Nind changed: What|Removed |Added CC||da...@davidnind.com Attachment #99425|0 |1 is obsolete|| --- Comment #3 from David Nind --- Comment on attachment 99425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99425 Attachment to Bug 24707 - Remove AMICUS from default fr-CA z39.50 servers Not sure what I did incorrectly again. Obsoleting patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 --- Comment #2 from David Nind --- Created attachment 99458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99458=edit Bug 24707: Remove AMICUS from default fr-CA z39.50 servers In installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql, there is an entry for AMICUS, the old catalogue of Library and Archives Canada. Unfortunately, LAC decided to go with OCLC and discontinued AMICUS. This patch removes that entry in the installation files since it is useless. To test: 1) Apply patch 2) Make a fresh fr-CA install 3) Make sure there are no errors 4) In Administration > Z39.50/SRU servers, make sure AMICUS is not there Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 David Nind changed: What|Removed |Added Attachment #99453|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 99457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99457=edit Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24680] Hold modification endpoints don't always work properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24680
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Comment #6 from David Nind ---
The first patch no longer applies:
Bug 24680 - Hold modification endpoints don't always work properly
99241 - Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority is
not provided
99242 - Bug 24680: Fix end_date returned from api/v1/holds/{hold_id}/suspension
endpoint
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also when priority
is not provided
error: sha1 information is lacking or useless (t/db_dependent/api/v1/holds.t).
error: could not build fake ancestor
Patch failed at 0001 Bug 24680: Fix PUT api/v1/holds/{hold_id} to work also
when priority is not provided
The second patch works as per the test plan.
(For my information - Figured out how to test: installed Insomnia REST client,
enabled RESTPublicAPI and RESTBasicAuth system preferences. This is all new to
me, so any suggestions on the appropriate tools to use would be appreciated.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24421] Generated authorities are missing subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 --- Comment #1 from AspenCat Team --- If sort by publication date is not working, it should probably not be an option. It is a nice option so it would be good to have fixed. When results return more records than are easily reviewed it is nice to be able to sort either alphabetical by title (which is also not working) or publication date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24559] Elasticsearch - add support for 'date' fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Nightly Build Bot changed: What|Removed |Added Attachment #98799|0 |1 is obsolete|| --- Comment #50 from Nightly Build Bot --- Created attachment 99456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99456=edit Bug 17084- Automatic debian/control updates (unstable/master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23567] Printable QR links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23567 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24686] Capturing circulation statistics per number of pieces in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24686 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #2 from Lisette Scheer --- I definitely think this should be configurable by item type, possibly by library as well. I can see the reason for wanting to do it for your example, but might not want to count as multiple items for say, a kit that includes a sewing machine and a power cord listed as different materials on the record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account credit types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Lisette Scheer changed: What|Removed |Added Attachment #99322|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account credit types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Lisette Scheer changed: What|Removed |Added Attachment #99454|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account credit types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #34 from Lisette Scheer --- Apologies for the incorrect patch attachment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lisette Scheer changed: What|Removed |Added Attachment #99445|0 |1 is obsolete|| --- Comment #2 from Lisette Scheer --- Created attachment 99455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99455=edit Bug 24701: Add column config to course_items_table This patch adds course_items_table to the column config tool TEST PLAN: 1. Have some course reserves 2. Add some items to that course reserve and browse to opac-course-details 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > opac-course-details 5. Try hiding each column and make sure the correct column is hidden on opac-course-details.pl Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account credit types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Lisette Scheer changed: What|Removed |Added Attachment #99322|0 |1 is obsolete|| --- Comment #33 from Lisette Scheer --- Created attachment 99454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99454=edit Bug 17702: (RM follow-up) Remove use of I18N tt This patch removes the use of the I18N TT plugin in introduced for all strings in the new template. We're not yet ready to use this plugin for all strings as we need to further investigate performance for such a move and perhaps add template compilation. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Nick Clemens changed: What|Removed |Added Assignee|oleon...@myacpl.org |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 --- Comment #1 from Nick Clemens --- Created attachment 99453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99453=edit Bug 24711: Don't add logout input to login form To test: 1 - Set OpacPublic syspref to 'Disable' 2 - Log in to OPAC 3 - Log out 4 - Try to log in again 5 - No error, but you get the login form again 6 - Apply patch 7 - Repeat 8 - This time you can log in again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Maryse Simard changed: What|Removed |Added Attachment #99361|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 99452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99452=edit Bug 24682: Make UsageStatsGeolocation readonly (and redirect to the config page) To prevent invalid values in this pref (and so on the server), we should make this input readonly on the syspref page. The sysprefs related to Hea should be edited from the dedicated page, so also adding a note about that. Test plan: Search syspref with "UsageStats" Notice the note about the admin page Notice the UsageStatsGeolocation input is now readonly (and resized, to display the whole value when filled) Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||maryse.sim...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710
Maryse Simard changed:
What|Removed |Added
Attachment #99428|0 |1
is obsolete||
--- Comment #3 from Maryse Simard ---
Created attachment 99451
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99451=edit
Bug 24710: Add span classes to patron first/other/sur names
This patch adds some elements with classes to patron-title.inc
TEST PLAN:
1. Have a patron with a firstname, surname, and othername
2. Apply patch
3. There should be no visible changes but if you inscept each element you
should see seperate elements with clases.
4. Add each of these to IntranetUserCSS to make sure it hides that element
(this effects patroninfo section AND breadcrumbs)
.firstname {display: none;}
.othernames {display:none};
.surname{display:none}
5. Sign-off
Signed-off-by: Maryse Simard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What|Removed |Added Attachment #95875|0 |1 is obsolete|| --- Comment #17 from Bouzid Fergani --- Created attachment 99449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99449=edit Bug 24114: (follow-up) Resolve warning on non-numeric subtraction Argument "" isn't numeric in subtraction (-) at /usr/share/koha/Koha/Patrons.pm line 290. Coming from an empty or undefined FailedLoginAttempts. Test plan: Verify that Koha/Patrons.t still passes. Signed-off-by: Marcel de Rooy Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What|Removed |Added Attachment #99447|0 |1 is obsolete|| --- Comment #16 from Bouzid Fergani --- Created attachment 99448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99448=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What|Removed |Added Attachment #95876|0 |1 is obsolete|| --- Comment #18 from Bouzid Fergani --- Created attachment 99450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99450=edit Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete Since these operations impact on the resultset, the counts should be saved before. Signed-off-by: Marcel de Rooy Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What|Removed |Added Attachment #99446|0 |1 is obsolete|| --- Comment #15 from Bouzid Fergani --- Created attachment 99447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99447=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bouzid Fergani changed: What|Removed |Added Attachment #95874|0 |1 is obsolete|| --- Comment #14 from Bouzid Fergani --- Created attachment 99446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99446=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 --- Comment #1 from Lucas Gass --- Created attachment 99445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99445=edit Bug 24701: Add column config to course_items_table This patch adds course_items_table to the column config tool TEST PLAN: 1. Have some course reserves 2. Add some items to that course reserve and browse to opac-course-details 2. See all the unconfigurable columns 3. Apply patch 4. Browse to column config > OPAC > opac-course-details 5. Try hiding each column and make sure the correct column is hidden on opac-course-details.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24701] Add column configuration to course_items_table in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24701 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 David Nind changed: What|Removed |Added Attachment #99429|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 99444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99444=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. 1) Go to Cataloging -> Advanced editor. 2) On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. 3) Remove the extra space and confirm that the highlight disappears. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Bouzid Fergani changed: What|Removed |Added Attachment #99442|0 |1 is obsolete|| --- Comment #4 from Bouzid Fergani --- Created attachment 99443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99443=edit Bug 23966 - Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes Right now the branch transfer limits editor works fine if an instance has a small number of libraries and ccodes/itemtypes, but for large consortia who may have over 100 branches and ccodes/itemtypes, the editor page can take literal minutes to load ( we have partners where the page load time is 7-8 minutes ). This is because we run a separate database query for each limit. We should use a single query to find all the limits for this page. Test Plan: 1) Enable BranchTransferLimits 2) Create some limits, test adding and removing limits 3) Apply this patch 4) Restart all the things! 5) Reload the page, you should see the same limits in place as before 6) Test adding and removing limits, everything should behave the same as it did before the patch was applied! Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Bouzid Fergani changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Bouzid Fergani changed: What|Removed |Added Attachment #95024|0 |1 is obsolete|| --- Comment #3 from Bouzid Fergani --- Created attachment 99442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99442=edit Bug 23966 - Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes Right now the branch transfer limits editor works fine if an instance has a small number of libraries and ccodes/itemtypes, but for large consortia who may have over 100 branches and ccodes/itemtypes, the editor page can take literal minutes to load ( we have partners where the page load time is 7-8 minutes ). This is because we run a separate database query for each limit. We should use a single query to find all the limits for this page. Test Plan: 1) Enable BranchTransferLimits 2) Create some limits, test adding and removing limits 3) Apply this patch 4) Restart all the things! 5) Reload the page, you should see the same limits in place as before 6) Test adding and removing limits, everything should behave the same as it did before the patch was applied! Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23547] Add column configuration to course reserves table in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23547 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What|Removed |Added Attachment #81900|0 |1 is obsolete|| --- Comment #47 from Bouzid Fergani --- Created attachment 99441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99441=edit Bug 19821: Require database_test != database To prevent developpers to drop their database. Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What|Removed |Added Attachment #81898|0 |1 is obsolete|| --- Comment #45 from Bouzid Fergani --- Created attachment 99439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99439=edit Bug 19821: Do not modify KOHA_CONF, use new database_test entry instead I have tried to use the original idea of this patch for bug 19185, but it cannot work as it. ENV is not shared between processus and KOHA_CONF will not be read by webserver (used for selenium tests). Moreover on bug 19185 we are testing the installation process and we do not want the database to be populated with sample data, we just need a new and clean DB. Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What|Removed |Added Attachment #81899|0 |1 is obsolete|| --- Comment #46 from Bouzid Fergani --- Created attachment 99440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99440=edit Bug 19821: Use database_test entry if exists If the database_test entry exists in the config file we are going to use it. This will be a trick for developers and CI Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What|Removed |Added Attachment #81894|0 |1 is obsolete|| --- Comment #41 from Bouzid Fergani --- Created attachment 99435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99435=edit Bug 19821: Run tests on a separate database Running the tests on the same database as the one used for dev has some drawbacks: - Everybody has different data, so we cannot make any assumptions about data in tests and it can make tests fail for non-obvious reasons. - Tests have to clean up every change to the database using SQL transactions, so we cannot write testable code that use transactions (AFAIK) - Transactions in tests happen to be committed sometimes, resulting in garbage data added to the dev database This patch provides a .proverc file that will load t/lib/Bootstrap.pm before the tests are run. t/lib/Bootstrap.pm is responsible for recreating a fresh database and telling the test scripts to use it. To use it, just run prove normally from the root directory of Koha. By default, the database is 'koha_test' and it's created using MARC21 SQL files, it can be changed by running: prove --norc \ --Mt::lib::Bootstrap=database,koha_test,marcflavour,UNIMARC Test plan: 1. mysql> GRANT ALL PRIVILEGES ON koha_test.* TO @localhost 2. cd /path/to/koha 3. prove t/db_dependent/.t 4. Verify that it created the database koha_test and that the one you use usually was untouched (you can edit the test file and comment the lines related to a transaction (txn_begin, txn_rollback)) Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What|Removed |Added Attachment #81897|0 |1 is obsolete|| --- Comment #44 from Bouzid Fergani --- Created attachment 99438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99438=edit Bug 19821: Ignore .proverc and .proverc.dist in Makefile.t Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What|Removed |Added Attachment #81895|0 |1 is obsolete|| --- Comment #42 from Bouzid Fergani --- Created attachment 99436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99436=edit Bug 19821: Close filehandle after writing Signed-off-by: Jon Knight Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Bouzid Fergani changed: What|Removed |Added Attachment #81896|0 |1 is obsolete|| --- Comment #43 from Bouzid Fergani --- Created attachment 99437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99437=edit Bug 19821: Install sample data, ES mappings and Version syspref Also move .proverc to .proverc.dist, so it cannot be used by accident. Different ways to use it: 1/ prove --rc .proverc.dist Use defaults 2/ cp .proverc.dist .proverc && prove Allows to configure db name, marcflavour, and prove options Signed-off-by: Martin Renvoize Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Maryse Simard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #126 from Maryse Simard --- Created attachment 99434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99434=edit Bug 17674: Handling of special cases This patch adds handling for those 2 particular cases: 1. Deleting the expected issue 2. Deleting a serial and it's item, but one item cannot be deleted To test: 1.1 Create a subscription that creates items 1.2 Receive two issues 1.3 Use the new button to delete the 'Expected' issue 1.4 The issue is correctly deleted, but the new expected issue created to replace the one which has been deleted don't have a published or received date and is show in it's own tab. 1.5 Apply patch 1.6 Repeat steps 1.1 through 1.4 => The new expected issue is created correctly 2.1 Use the same serial as in 1 or repeat step 1.1 and 1.2 2.2 Check out one of the items 2.3 Delete the corresponding serial and check box to delete items 2.4 The serial is deleted, but not the item. => No feedback is show to the user 2.5 Apply patch 2.6 Repeat step 2.1 through 2.4 => As before, the serial is deleted, but not the item => This time, an error is shown to inform the user -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 David Nind changed: What|Removed |Added CC||da...@davidnind.com Attachment #99426|0 |1 is obsolete|| --- Comment #3 from David Nind --- Comment on attachment 99426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99426 Attachment to Bug 24708 - Update Z39.50 server attribute in fr-CA installation file Not sure what I did here, obsoleting so only one patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Bouzid Fergani changed: What|Removed |Added Attachment #94995|0 |1 is obsolete|| --- Comment #52 from Bouzid Fergani --- Created attachment 99431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99431=edit Bug 20116: Prepare the ground Just refactoring to make the next patch more readable Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Bouzid Fergani changed: What|Removed |Added Attachment #94996|0 |1 is obsolete|| --- Comment #53 from Bouzid Fergani --- Created attachment 99432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99432=edit Bug 20116: Flush the caches When languages are added or removed when need to flush the caches to keep the interface consistent Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20116] Cache language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Bouzid Fergani changed: What|Removed |Added Attachment #94997|0 |1 is obsolete|| --- Comment #54 from Bouzid Fergani --- Created attachment 99433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99433=edit Bug 20116: Cache language list Signed-off-by: Liz Rea Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 --- Comment #2 from David Nind --- Created attachment 99430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99430=edit Bug 24708: Update Z39.50 server attribute in fr-CA installation file Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com --- Comment #2 from Sarah Cornell --- Here's our use case: We want to display the "other name" value at the end of the patron name because we use it for both additional patron names and for nicknames. Current display: Jo (Joy Harjo, Sharon Olds, Gertrude Stein, Mary Oliver) Tech (24518000721715) Ideal display: Jo Tech (Joy Harjo, Sharon Olds, Gertrude Stein, Mary Oliver) (24518000721715) I'd test Lucas' patch myself but I'm not good at the IntranetUserCSS syspref yet. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |carn...@dgiinc.com |ity.org | --- Comment #2 from Cori Lynn Arnold --- Assigning to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 --- Comment #1 from Cori Lynn Arnold --- Created attachment 99429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99429=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. - Remove the extra space and confirm that the highlight disappears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710
--- Comment #1 from Lucas Gass ---
Created attachment 99428
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99428=edit
Bug 24710: Add span classes to patron first/other/sur names
This patch adds some elements with classes to patron-title.inc
TEST PLAN:
1. Have a patron with a firstname, surname, and othername
2. Apply patch
3. There should be no visible changes but if you inscept each element you
should see seperate elements with clases.
4. Add each of these to IntranetUserCSS to make sure it hides that element
(this effects patroninfo section AND breadcrumbs)
.firstname {display: none;}
.othernames {display:none};
.surname{display:none}
5. Sign-off
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Kyle M Hall changed: What|Removed |Added Attachment #99386|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 99427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99427=edit Bug 24705: Holds placed via SIP will be given first priority The SIP server does not calculate and pass a priority to AddReserve, which causes the hold to be given priority 1. Test Plan: 1) Place a hold via SIP for a record with existing holds 2) Note the new hold is top priority 3) Apply this patch 4) Restart SIP 5) Repeat step 1 6) New hold should be last priority Signed-off-by: Christofer Zorn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] New: patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 Bug ID: 24710 Summary: patron-title.inc should have seperate span classes for firstname, othername, surname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Some libraries would prefer to be able to customize how the name is displayed in the patron details. If these included classes we could easily move/hide/reorder bits we don;t want. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24709] New: Advanced editor - show space after delimiter visually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Bug ID: 24709 Summary: Advanced editor - show space after delimiter visually Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: carn...@dgiinc.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Catalogers would like to visually see if there is a space after the delimiter in the Advanced editor, much like what was done for Bug 24452 - Advanced editor - show multiple spaces visually -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Depends on||11297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Caroline Cyr La Rose changed: What|Removed |Added Blocks||24708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 [Bug 24708] Update Z39.50 server attribute in fr-CA installation file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 99426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99426=edit Attachment to Bug 24708 - Update Z39.50 server attribute in fr-CA installation file Bug 24708: Update Z39.50 server attribute in fr-CA installation file Now that bug 11297 has been pushed to master, I'd like to amend the installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql file to add the attribute necessary for one of the servers to work. This patch adds the attribute in the fr-CA sample_z3950_servers.sql file. To test : 1) Apply patch 2) Go to the database and delete all Z39.50 servers (delete from z3950servers;) 3) Apply the sample_z3950_servers.sql found in installer/data/mysql/fr-CA/facultatif/ 4) In Koha, go to Cataloging and choose to add a record from Z39.50 5) Check BANQ and make a search, you should get results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24708] Update Z39.50 server attribute in fr-CA installation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24708] New: Update Z39.50 server attribute in fr-CA installation file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 Bug ID: 24708 Summary: Update Z39.50 server attribute in fr-CA installation file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Now that bug 11297 has been pushed to master, I'd like to amend the installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql file to add the attribute necessary for one of the servers to work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Caroline Cyr La Rose changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 99425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99425=edit Attachment to Bug 24707 - Remove AMICUS from default fr-CA z39.50 servers Bug 24707: Remove AMICUS from default fr-CA z39.50 servers In installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql, there is an entry for AMICUS, the old catalogue of Library and Archives Canada. Unfortunately, LAC decided to go with OCLC and discontinued AMICUS. This patch removes that entry in the installation files since it is useless. To test: 1) Apply patch 2) Make a fresh fr-CA install 3) Make sure there are no errors 4) In Administration > Z39.50/SRU servers, make sure AMICUS is not there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24707] Remove AMICUS from default fr-CA z39.50 servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Caroline Cyr La Rose changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24707] New: Remove AMICUS from default fr-CA z39.50 servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24707 Bug ID: 24707 Summary: Remove AMICUS from default fr-CA z39.50 servers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr In installer/data/mysql/fr-CA/facultatif/sample_z3950_servers.sql, there is an entry for AMICUS, the old catalogue of Library and Archives Canada. Unfortunately, LAC decided to go with OCLC and discontinued AMICUS. I propose to remove that entry in the installation files since it is useless. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #101 from Nick Clemens --- (In reply to Nick Clemens from comment #91) > (In reply to Jonathan Druart from comment #90) > > Looks like this dev will conflict with bug 15522. > > Agreed, but I don't think that should be a blocker here. 15522 needs some > work, we are gathering notes to post on that bug. > > This is a much desired feature and should be allowed to proceed Rebased and squashed some patches. In terms of 15522 this only affects dropdowns to select itemtype and ordering of display, otherwise rules are set per itemtype as they have always been, TooMany handles the logic of which to apply when. I don't think this will require large changes there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #96 from Nick Clemens --- Created attachment 99420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99420=edit Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes To test: 1 - prove -v t/db_dependent/Circulation/TooMany.t Signed-off-by: Liz Rea Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #99 from Nick Clemens --- Created attachment 99423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99423=edit Bug 21946: Update unit tests to pass under ES -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #100 from Nick Clemens --- Created attachment 99424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99424=edit Bug 21946: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #98 from Nick Clemens --- Created attachment 99422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99422=edit Bug 21946: Display parent-child relationship on smart-rules.pl To test: 1 - Set some itemtypes to have a parent 2 - Browse to Administration -> Circulation and fines rules 3 - Note new description of parent/child relationships at top of page 4 - Note that itemtype dropdown for circ rules shows child types under parents 5 - Set a rule for a child type 6 - Note it displays as Parent->Child 7 - Have three child types under a parent 8 - Set the parent 'Current checkouts allowed' to 3 9 - Set the children 'Current checkouts allowed' to: type1 = 2 type2 = 1 type3 = 1 10 - Create some items of the type above 11 - Note you can checkout 2 of type 1, and not 3 12 - Note you can checkout 1 of type 2, but not 2 13 - Note that you now cannot checkout any of type3 14 - Note you cannot checkout any of the parent type 15 - Return one of the other items and note you can now checkout an item of type3 16 - Return another item and note you can checkout an item of the parent type 17 - Return all 18 - Set the parent type to 1 19 - Now note you can only checkout 1 of any of the children 20 - Set the parent to 0 21 - Note you cannot checkout any of the child types Signed-off-by: Liz Rea Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 --- Comment #97 from Nick Clemens --- Created attachment 99421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99421=edit Bug 21946: Update Administration->Item types to allow for defining parent types To test: 1 - Browse to Administration -> Item types 2 - Not a new colum for prent type 3 - Edit an existing type and not you can select any type (except the current) as a parent 4 - Select one 5 - Edit the type you selected as parent 6 - Note it cannot have a parent defined 7 - Edit a new type, note you can select a parent Signed-off-by: Liz Rea Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21946] Group circulation by item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946 Nick Clemens changed: What|Removed |Added Attachment #96977|0 |1 is obsolete|| Attachment #96978|0 |1 is obsolete|| Attachment #96979|0 |1 is obsolete|| Attachment #96980|0 |1 is obsolete|| Attachment #96981|0 |1 is obsolete|| Attachment #96982|0 |1 is obsolete|| Attachment #96983|0 |1 is obsolete|| Attachment #96984|0 |1 is obsolete|| Attachment #96985|0 |1 is obsolete|| Attachment #96986|0 |1 is obsolete|| Attachment #96987|0 |1 is obsolete|| --- Comment #95 from Nick Clemens --- Created attachment 99419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99419=edit Bug 21946: Database updates Signed-off-by: Liz Rea Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21800] TransformKohaToMarc should respect non-repeatability of item subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21800 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #12 from Marcel de Rooy --- (In reply to Ere Maijala from comment #10) > Why isn't the default framework also authoritative for repeatability? We only consider it authoritative for the Koha to MARC mapping. The interface allows you to set repeatability per framework. Which is good. Since we changed mappings, it does no longer look at the other frameworks. So this is the crux of the change. > If not, at least the framework information should be fetched e.g. with > GetMarcSubfieldStructure so that it's cached to avoid a performance penalty, > right? I did experiment a bit with caching but didnt submit that portion. The existing cached structures are based on entry by kohafield, not MARC tags. Makes it a bit less handy. Performance penalty is a big word here. We use this for items. The item editor needs 2 or 3 ms more to open one record (in my benchmarking). Batch item modification depends on the number of items, but is a staff action, probably not executed continuously. Rebuild zebra should not be a problem too. Considering that, I feel that caching is no requirement here. And we can always add it on its own report. Back to NSO. Hoping for a SO ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Martin Renvoize changed: What|Removed |Added Attachment #98496|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 99418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99418=edit Bug 24593: Rewrite marc21_simple_bib_frameworks to YAML YAML version of marc21_simple_bib_frameworks To test: 1) Same test plan of first patch NOTE: Same problem as first patch with qa tools Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Works well.. Signing off. Side note.. we should really standardise on a single YAML module for our parsing :(. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Martin Renvoize changed: What|Removed |Added Attachment #98495|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 99417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99417=edit Bug 24593: Rewrite marc21_sample_fastadd_framework to YAML YAML version of marc21_sample_fastadd_framework To test: 1) Same test plan of first patch NOTE: Same problem as first patch with qa tools Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593
Martin Renvoize changed:
What|Removed |Added
Attachment #98494|0 |1
is obsolete||
--- Comment #4 from Martin Renvoize ---
Created attachment 99416
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99416=edit
Bug 24593: Rewrite marc21_default_matching_rules to YAML
YAML version of marc21 optional marc21_default_matching_rules.
To test:
1) Do a clean install with optional data,
dump table marc_matchers, reserve.
2) Apply this patch and it's dependencies
3) Do a clean install, dump again and compare
No major differences expected
4) Try translation
a) Go to misc/translator
b) create files for a new language
./translate create xx-YY
c) Check new file po/xx-YY-instaler-MARC21.po
Verify strings from this file.
d) Install new language
./translate install xx-YY
e) Try clean install with new files
NOTE: This patch fails with qa tools!
Reason is that qa tools use YAML.pm module to
check files, but Installer.pm or LangInstaller.pm
are using YAML::Syck, using that module gives
no error, check for example:
perl -e 'use YAML::Syck qw( LoadFile ); $y =
LoadFile("marc21_default_matching_rules.yml");'
No error!
perl -e 'use YAML qw( LoadFile ); $y =
LoadFile("marc21_default_matching_rules.yml");'
Error!
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #31 from Martin Renvoize --- Works well for me.. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98477|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 99415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99415=edit Bug 24584: Rewrite optional/sample_z3950_servers to YAML YAML version of optional sample_z3950_servers To test: 1) Same test plan of first patch, only check table z3950servers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98476|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 99414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99414=edit Bug 24584: Rewrite optional/sample_quotes to YAML YAML version of optional sample_quotes To test: 1) Same test plan of first patch, only check table quotes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98475|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 99413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99413=edit Bug 24584: Rewrite optional/sample_patrons to YAML YAML version of optional sample_patrons To test: 1) Same test plan of first patch, only check table borrowers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98474|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 99412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99412=edit Bug 24584: Rewrite optional/sample_news to YAML YAML version of optional sample_news To test: 1) Same test plan of first patch, only check table opac_news Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98473|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 99411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99411=edit Bug 24584: Rewrite optional/sample_libraries_holidays to YAML YAML version of optional sample_libraries_holidays To test: 1) Same test plan of first patch, only check table repeatable_holidays Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98472|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 99410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99410=edit Bug 24584: Rewrite optional/sample_libraries to YAML YAML version of optional sample_libraries To test: 1) Same test plan of first patch, only check table branches Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98471|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 99409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99409=edit Bug 24584: Rewrite optional/sample_itemtypes to YAML YAML version of optional sample_itemtypes To test: 1) Same test plan of first patch, only check table itemtypes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98469|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 99407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99407=edit Bug 24584: Rewrite optional/patron_categories to YAML YAML version of optional patron_categories To test: 1) Same test plan of first patch, only check table categories Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98468|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 99406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99406=edit Bug 24584: Rewrite optional/patron_atributes to YAML YAML version of optional patron_atributes To test: 1) Same test plan of first patch, only check table borrower_attribute_types Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24584] Rewrite optional installation files to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 Martin Renvoize changed: What|Removed |Added Attachment #98470|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 99408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99408=edit Bug 24584: Rewrite optional/sample_creator_data to YAML YAML version of optional sample_creator_data To test: 1) Same test plan of first patch, only check tables creator_layouts, creator_templates and printers_profile Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
