[Koha-bugs] [Bug 24784] New: Duplicated code in checkouts.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24784 Bug ID: 24784 Summary: Duplicated code in checkouts.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: pasi.kalli...@koha-suomi.fi QA Contact: testo...@bugs.koha-community.org in LoadIssuesTable(), the issues-table and relatives-issues-table have couple near-identical functions that should be unified. The major one is the mDataProp function for showing the item title and author (column 5 for issues-table, column 3 for relatives-issues-table) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4985] Edit a calendar entry for all branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4985 --- Comment #13 from Emmi Takkinen --- I filed a separate bug report (bug 24782) regarding edit only applying to first day. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24783] New: Untranslatable strings in checkouts.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24783 Bug ID: 24783 Summary: Untranslatable strings in checkouts.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@koha-suomi.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Untranslatable strings in checkouts.js: - title += ' by ' + oObj.author; - title="Double click to edit" - "on" in line desc = '' + oObj.resolution_data.lib + ' on ' + oObj.resolved_on + ''; - Delete - Resolve - ' Actions - Edit notes - Update - href="#">Cancel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24782] New: Calendar edit only applies to first day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Bug ID: 24782 Summary: Calendar edit only applies to first day Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takki...@outlook.com QA Contact: testo...@bugs.koha-community.org When editing holidays edit only applies to first day (from date). To test: 1. Add holidays on range e.g from 04/03 to 06/03 2. Try edit these holidays so that from date is 04/03 and to date is set to 06/03 3. Save => Only 04/03 is changed There should be option to edit holidays on range. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24781] Parse and build query strings more reliably
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24781 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | --- Comment #1 from David Cook --- As a side note, I actually thought of this while creating a new "Peer-Reviewed" facet for the search results, which imitates that "Availability" facet to a degree. I didn't like the way limit=available was being handled, so I wrote an alternative. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24781] New: Parse and build query strings more reliably
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24781 Bug ID: 24781 Summary: Parse and build query strings more reliably Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Throughout the code, you'll see a lot of string mangling to manipulate query strings. Examples from opac-search.pl: $query_cgi = "tag=" . uri_escape_utf8( $tag ) . "&" . $query_cgi; $pasarParams .= 'query=' . uri_escape_utf8($query); $pasarParams .= 'count=' . uri_escape_utf8($results_per_page); $pasarParams .= 'simple_query=' . uri_escape_utf8($simple_query); $limit_cgi_not_availablity =~ s/=available//g if defined $limit_cgi_not_availablity; It would be good to have a more reliable unit-tested way of creating and editing query strings. I have a module called Koha::Util::URL which should be able to help. I'm hoping to put together a patch tomorrow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 99975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99975=edit Bug 23975: (QA follow-up) Add missing TT filters Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 99972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99972=edit Bug 23975: (follow-up) Don't rely on save_to being present The `save_to` shortcut method was introduced to Mojolicious in version 8.02 but we still support 7.21 as our minimum dependancy and as such we cannot yet use it. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 99973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99973=edit Bug 23975: (QA follow-up) Fix stylingof install buttons Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 99974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99974=edit Bug 23975: (QA follow-up) Search button style and functionality This patch makes the search form button match the other buttons style, and also adds the submit() action on click. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 99971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99971=edit Bug 23975: Add 'Install' support for github results Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi changed: What|Removed |Added Attachment #98815|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 99970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99970=edit Bug 23975: Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi changed: What|Removed |Added Attachment #98813|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi changed: What|Removed |Added Attachment #98814|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi changed: What|Removed |Added Attachment #99958|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #73 from Aleisha Amohia --- We keep getting stuck on the lack of GUI. I understand. I'll write the GUI for this now so it can all go through in one go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #5 from Myka Kennedy Stephens --- I would also like to add that as I was doing my base-line testing for this bug, I found something interesting. When clicking on a record in the result list, then clicking on the button to return to the results, the search re-executes and applies weights. If a user had performed a search using advanced search where weights are not applied, then used the button to return to the results list, they would find that the results were in a different order. The work-around is to just use the browser's back button to return to the advanced search results list. If we're giving people the option to apply weights to the advanced search, however, this inconsistency will continue to happen unless there's a way to specify the return to results link to go back to the previous results instead of launching a new search. I did notice that there is a search_id value in the URL when the search re-executes that is not there in the URL for the advanced search: http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1=kw=computer=and=kw=program*=and=kw_by=relevance vs. http://localhost:8081/cgi-bin/koha/catalogue/search.pl?idx=kw=computer=and=kw=program*=and=kw=scs_1583197470738=0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 Myka Kennedy Stephens changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Myka Kennedy Stephens --- Patch failed to apply: Applying: Bug 24155: Make wieghting an option on advanced search Using index info to reconstruct a base tree... M cataloguing/addbooks.pl M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Auto-merging cataloguing/addbooks.pl CONFLICT (content): Merge conflict in cataloguing/addbooks.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 24155: Make wieghting an option on advanced search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24780] New: 952$i stocknumber does not display in batch item modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24780 Bug ID: 24780 Summary: 952$i stocknumber does not display in batch item modification Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When trying to edit items via batch item modification, the subfield i does not display. To recreate, add a value to 952$i, then add that barcode to the batch item modification function. You will see the value display in the item summary across the top of the screen, but the $i does not show in the edit section below. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24770] Show age of patron on circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770 --- Comment #1 from Radek Šiman (R-Bit Technology, s.r.o.) --- Created attachment 99969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99969=edit Bug 24770: Show age of patron on circulation page This patch only adds new line containing age to the patron info 1) Navigate to a patron checkout page 2) No age is visible above "category" in patron's info above circ menu 3) Apply the patch 4) Reload this patron 5) Age is here and always visible regardless the active tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24770] Show age of patron on circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770 Radek Šiman (R-Bit Technology, s.r.o.) changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest versions of YAML or YAML::Syck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest versions of YAML or YAML::Syck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760 Michal Denar changed: What|Removed |Added Attachment #99756|0 |1 is obsolete|| --- Comment #2 from Michal Denar --- Created attachment 99968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99968=edit Bug 24760: Use C4::BackgroundJob->fetch in tests Starting with YAML 1.30 and YAML::Syck 1.32, these modules don't bless loaded objects by default. This is not a problem as C4::BackgroundJob->fetch bless them anyway. So, instead of testing what's in the session, test the result of C4::BackgroundJob->fetch, which is what's used everywhere else Test plan: 1. Install latest version of YAML::Syck (or YAML if YAML::Syck is not installed) 2. prove t/db_dependent/BackgroundJob.t => should FAIL 3. Apply patch 4. prove t/db_dependent/BackgroundJob.t => should PASS 5. Verify that background jobs are still working (for instance, tools/batchMod.pl) Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #101 from Michal Denar --- Created attachment 99965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99965=edit Bug 20388: QA fixe : delete line who add elements in biblios and authorities in the same time Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #100 from Michal Denar --- Created attachment 99964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99964=edit Bug 20388: QA fixes: - pass search field objects in template instead of unblessed ones - disable drag n drop Signed-off-by: Julian Maurice Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #102 from Michal Denar --- Created attachment 99966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99966=edit Bug 20388: add of types in the new entries dropdown of searchfiels Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #103 from Michal Denar --- Created attachment 99967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99967=edit Bug 20388: QA fixe : add searchfield only if it doesn't exist To test: Without the fix: - in search field configuration -> search field - add the search field "uri" at the bottom of the tab - you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg Then apply the fix - try to add the search field uri - this time an alert should appear with the message : " SearchField uri already exist " Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #99 from Michal Denar --- Created attachment 99963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99963=edit Bug 20388: Use live handler for deleting elements Signed-off-by: Björn Nylén Signed-off-by: Julian Maurice Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #97 from Michal Denar --- Created attachment 99961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99961=edit Bug 20388: Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand Signed-off-by: Björn Nylén Signed-off-by: Julian Maurice Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #98 from Michal Denar --- Created attachment 99962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99962=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Björn Nylén Signed-off-by: Julian Maurice Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Michal Denar changed: What|Removed |Added Attachment #98011|0 |1 is obsolete|| Attachment #98012|0 |1 is obsolete|| Attachment #98013|0 |1 is obsolete|| Attachment #98014|0 |1 is obsolete|| Attachment #98015|0 |1 is obsolete|| Attachment #98016|0 |1 is obsolete|| Attachment #98017|0 |1 is obsolete|| Attachment #98018|0 |1 is obsolete|| --- Comment #96 from Michal Denar --- Created attachment 99960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99960=edit Bug 20388: Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand Signed-off-by: Séverine QUEUNE Signed-off-by: Nick Clemens Signed-off-by: Björn Nylén Signed-off-by: Julian Maurice Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24770] Show age of patron on circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24770 Michal Denar changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |r...@rbit.cz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19310] Warning on UpdateTotalIssuesOnCirc should be revisited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19310 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Michal Denar changed: What|Removed |Added Attachment #98769|0 |1 is obsolete|| --- Comment #5 from Michal Denar --- Created attachment 99959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99959=edit Bug 24573: Add missing dependencies to cpanfile Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation Signed-off-by: Michal Denar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24573] Catmandu::Store::ElasticSearch and Catmandu::MARC are missing from cpanfile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24779] New: Shibboleth login url double encodes "=" in query
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24779 Bug ID: 24779 Summary: Shibboleth login url double encodes "=" in query Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: hannah...@northwestu.edu QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org login_shib_url and logout_shib use _get_return to process a url and parameters. I am seeing urls come through with the "=" between the parameter name and the query encoded to "%3D". I think this is because url encoding is done on line 214 to the whole parameter string after assembly. 214return $uri_base_part . URI::Escape::uri_escape_utf8($uri_params_part); I believe only the query part of the parameter should be uri escaped, on line 209: 209$uri_params_part .= $uriPiece; My installation with shibboleth login works with lines 209 and 214 changed as follows: 209$uri_params_part .= URI::Escape::uri_escape_utf8($uriPiece); 214return $uri_base_part . $uri_params_part; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #24 from Martin Renvoize --- Created attachment 99958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99958=edit Bug 23975: (QA follow-up) Fix stylingof install buttons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15377] Allow removal of 'checked out' items from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377 David Nind changed: What|Removed |Added Text to go in the||This enhancement allows the release notes||removal of items that are ||listed on a course reserve ||and are checked out. ||Previously, checked out ||items could not be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS, HTML, and YAML system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds release notes||CodeMirror plugins for ||linting system preferences ||that include JS, CSS, HTML, ||and YAML. When invalid data ||is entered in a linted ||CodeMirror editor an icon ||is displayed in the ||editor's "gutter." Hovering ||over the icon displays the ||error message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Kyle M Hall changed: What|Removed |Added Attachment #96234|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 99957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99957=edit Bug 23223: Add AllowItemsOnHoldCheckoutSIP preference This patch adds a new systempreference for behavior for AllowItemsOnHoldCheckout may difer between intranet, SCO and SIP To test: 1. apply this patch 2. perl installer/data/mysql/updatedatabase.pl SUCCESS => There is a new syspref called AllowItemsOnHoldCheckoutSIP 3. configure and start SIPServer 4. with misc/sip_cli_emulator.pl try to checkout an item with a hold CHECK => checkout is not allowed 5. set AllowItemsOnHoldCheckoutSIP to Allow 6. restart SIPServer 7. repeat step 4 SUCCESS => checkout is allowed 8. Sign off Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23223] Allow requested items to be checked out via SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23223 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #23 from Kyle M Hall --- > Once we have those I think we pretty much have what you are suggesting.. we > can update the default config we ship to only include a pointer to the > community gitlab and as we as a community deem a plugin to have reached a > level of maturity we are happy with we can suggest an adoption of it into > our gitlab and thus sign subsequent releases. +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24778] New: Move from Memcached to Redis to solve L1 caching issues?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24778 Bug ID: 24778 Summary: Move from Memcached to Redis to solve L1 caching issues? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Would it be worthwhile to switch from Memcache to Redis? Redis has pub/sub which in theory would allow all processes to listen for syspref changes and update their L1 caches if necessary. What made me think of this is bug 23640 I have no idea if this is worth the time and effort, but it seems like it would solve the major issue we have with memcached. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall --- When testing I get the following error in the console in FireFox on the OPAC on the holds history page: TypeError: $(...).api is not a function opac-holdsrecord.pl:793:36 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 --- Comment #6 from Nick Clemens --- Created attachment 99956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99956=edit Bug 23695: Alter transferbook to take a hash of params and specify from_branch To test: 1 - Go to Circulation->Transfer 2 - Find an item from your branch and create a transfer to branch B 3 - Note you can specify the origin and default is 'Item's holding library' 4 - Confirm the item is marked as held at your current branch and is being transferred to B 5 - Find an item from a third branch, branch C 6 - Transfer that item to branch B from branch D 7 - Confirm the item is held at branch D and is being transferred to B 8 - prove -v t/db_dependent/Circulation.t 9 - prove -v t/db_dependent/Koha/Items.t 10 - prove -v t/db_dependent/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Nick Clemens changed: What|Removed |Added Attachment #93231|0 |1 is obsolete|| Attachment #98942|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 99955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99955=edit Bug 23695: Set holding branch to transferring branch when manually initiating a transfer To test: 1 - Go to Circulation->Transfer 2 - Note your signed in branch 3 - Find an item from your branch and create a transfer to branch B 4 - Confirm the item is marked as held at your current branch and is being transferred to B 5 - Find an item from a third branch, branch C 6 - Transfer that item to brnach B 7 - Confirm the item is held at your current branch and is being transferred to B 8 - prove -v t/db_dependent/Circulation.t 9 - prove -v t/db_dependent/Koha/Items.t 10 - prove -v t/db_dependent/RotatingCollections.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479 --- Comment #4 from Martin Renvoize --- Test plan 1) Change the Currency format preference 2) enter an amount equal to or less than the amount owed into the collected field in the point of sale page and note that on leaving the field it will be formatted as per the system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24775] Payment submit button on POS page should have an ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #99904|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 99954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99954=edit Bug 24775: Add ID to POS submit payment button This patch simply adds an ID to the submit button to make it easier to overide styling and functionality. Test Plan: 0/ Inspect the element on page and note there is no id 1/ Apply patch 2/ Refresh page 3/ Inspect the element on page and note there is now an id Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24775] Payment submit button on POS page should have an ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24775 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a Koha::Item method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759 --- Comment #8 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > renewalbranch is not a correct name. renewal_branchcode is more appropriate > here to avoid confusion. > Even better, for consistency, I would prefer renewal_library and make it > returns a Koha::Library object (if if you need an additional fetch). Renamed to renewal_branchcode - returning a library object doesn't work so well because we can have "" or "OPACRenew" as values, they won't have Library objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24759] OpacRenewalBranch code should be a Koha::Item method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24759 --- Comment #7 from Nick Clemens --- Created attachment 99953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99953=edit Bug 24759: Rename renewalbranch to renewal_branchcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||Before this development, release notes||the koha-shell script would ||always return a successful ||error code, making it hard ||for the callers to notice ||there was a problem with ||the command being run ||inside the instance's ||shell. || ||This development ||makes koha-shell propagate ||the running scripts' error ||code so the caller can take ||the required actions. || ||Note: this implies a ||behaviour change (for good) ||but a warning should be ||added to the release notes. || ||Right now it always ||returns -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540 Martin Renvoize changed: What|Removed |Added Attachment #99951|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 99952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99952=edit Bug 24540: Prevent add button being triggered on enter This patch prevents the add button being triggered by hitting return from inside the collected from patron form input. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540 --- Comment #1 from Martin Renvoize --- Created attachment 99951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99951=edit Bug 24540: Prevent add button being triggered on enter This patch prevents the add button being triggered by hitting return from inside the collected from patron form input. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #25 from Nick Clemens --- Created attachment 99950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99950=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Attachment #97403|0 |1 is obsolete|| --- Comment #24 from Nick Clemens --- Created attachment 99949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99949=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 --- Comment #1 from Martin Renvoize --- Created attachment 99948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99948=edit Bug 24519: Match paycollect form validation for change collection This patch adds form validation to the Point Of Sale payment page such that one cannot submit the form with a 'collected' value that is less than the 'owed' amount. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 --- Comment #34 from Kyle M Hall --- Created attachment 99947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99947=edit Bug 24502: (follow-up) Add all 3 query parameters in api definition This patch adds api definition for body, query or header parameters. To use them include: * "$ref": "../parameters.json#/q_body" for body parameter. * "$ref": "../parameters.json#/q_param" for query parameter. * "$ref": "../parameters.json#/q_header" for header parameter. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24502] Add a query language and param (q=) to the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 Kyle M Hall changed: What|Removed |Added Attachment #99351|0 |1 is obsolete|| Attachment #99352|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall --- Created attachment 99946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99946=edit Bug 24502: object.search also filter by prefetched columns This patch adds the possibility to object.search helper, to also filter by prefetched columns. In order to dynamically add filter parameters, they must be coded as json and placed in the body of the request, coded as string in 'q' query parameter or as string in 'x-koha-query' header. The coded json, is in fact dbix syntax. To test: 1. apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t 3. Sign off Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What|Removed |Added Depends on||24540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540 [Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540 Martin Renvoize changed: What|Removed |Added Blocks||13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Koha Team University Lyon 3 changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #129 from Koha Team University Lyon 3 --- I've followed the test plan and everything looks Ok for me. 1. The next expected issue is correctly created when we delete the current expected issue. 2. If an item is checked out, you can't delete this item when you delete the serial issue. There's an alert to tell you that you can't delete the item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 ByWater Sandboxes changed: What|Removed |Added Attachment #99434|0 |1 is obsolete|| --- Comment #128 from ByWater Sandboxes --- Created attachment 99945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99945=edit Bug 17674: Handling of special cases This patch adds handling for those 2 particular cases: 1. Deleting the expected issue 2. Deleting a serial and it's item, but one item cannot be deleted To test: 1.1 Create a subscription that creates items 1.2 Receive two issues 1.3 Use the new button to delete the 'Expected' issue 1.4 The issue is correctly deleted, but the new expected issue created to replace the one which has been deleted don't have a published or received date and is show in it's own tab. 1.5 Apply patch 1.6 Repeat steps 1.1 through 1.4 => The new expected issue is created correctly 2.1 Use the same serial as in 1 or repeat step 1.1 and 1.2 2.2 Check out one of the items 2.3 Delete the corresponding serial and check box to delete items 2.4 The serial is deleted, but not the item. => No feedback is show to the user 2.5 Apply patch 2.6 Repeat step 2.1 through 2.4 => As before, the serial is deleted, but not the item => This time, an error is shown to inform the user Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 ByWater Sandboxes changed: What|Removed |Added Attachment #95474|0 |1 is obsolete|| --- Comment #127 from ByWater Sandboxes --- Created attachment 99944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99944=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Test plan : - Apply patch. - Create at least four serials with items. - Notice that new items have a numbering pattern and a date in the enumchron field. - Use the button Delete selected issues for the following steps. - Delete a serial and its associated item. - Confirm the serial and item are gone. - Delete a serial and not its item. - Confirm the serial is gone. - Confirm the item is still there and the date part in the enumchron field is gone. - Delete the two lasts serials. - Confirm they are gone. Sponsored by : CCSR Signed-off-by: Michal Denar Signed-off-by: sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #191 from David Gustafsson --- Ok, thanks! A regression seems to been introduced in https://github.com/Koha-Community/Koha/commit/abb51797d8d5ebb274856e912e207a921ace478b causing this bug. Very difficult to debug since "delete" is somehow called without appearing in the code, and a stack trace points out a line (where delete is called) that does not exist. But I'm looking into it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532
Martin Renvoize changed:
What|Removed |Added
Attachment #99918|0 |1
is obsolete||
--- Comment #12 from Martin Renvoize ---
Created attachment 99943
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99943=edit
Bug 17532: Make koha-shell propagate the error code
Context: I am trying to make koha-misc4dev stop when something wrong happens.
Basically we do not want the process to continue of the DB has not been
populated correctly.
It will make the errors easier to catch.
The issue: Say a script that will return an error (die in perl for an easy
example),
koha-shell will not return the 255 error code, but 0 instead.
The caller cannot know something wrong happened
The solution is to propagate the error and make koha-shell return the same
error code
as the command it executed
An example:
=== t.pl ===
die('something wrong');
% perl t.pl;echo $?
something wrong at t.pl line 1.
255
% sudo koha-shell kohadev -p -c 'perl xxx.pl' ; echo $?
something wrong at xxx.pl line 1.
0
Signed-off-by: Tomas Cohen Arazi
Tested it with
$ sudo debian/scripts/koha-shell kohadev -c 'exit 8'
$ echo $?
8
The unpatched version returns 0 (forgets about the error code).
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #98 from Arthur Suzuki --- (In reply to David Nind from comment #94) > Similar to Bug 17229 you get an error on the patron's page when following > the test plan (step 2 before patch), but before trying to apply the patch: > > 1) For the patron, the holds tab heading shows that there is a hold (1). > > 2) When you click on the patron's holds tab a message pops up with > "DataTables warning: table id=holds-table - Ajax error. For more information > about this error, please see http://datatables.net/tn/7; > > 3) The bibliographic record shows that there is a hold. > > I'm assuming that is because the DataTables feature for displaying results > is a more recent addition to Koha. > > (Test URL I used for ILS_DI was > http://127.0.0.1:8080/cgi-bin/koha/ilsdi. > pl?service=HoldTitle_id=19_id=15_location='127.0.0.1' > using koha-testing-docker) Hi David, Thanks again for testing, I've posted new patches with conflicts fixed + tests green + qa tools green. I cannot reproduce the issue you've seen with DataTable. Kr, Arthur -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #72 from Martin Renvoize --- I'm reasonably happy with the followups here.. it feels like this was written with a GUI and a process in mind but without submitting the GUI half and as such the code is a little confusing.. why not just send emails and skip the table element entirely ;) Still.. I like the feature and at this point, the code seems to work reasonably well.. I'd love to see a GUI including a process for moving reports through various states added this cycle if possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #71 from Martin Renvoize --- Created attachment 99942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99942=edit Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #69 from Martin Renvoize --- Created attachment 99940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99940=edit Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #70 from Martin Renvoize --- Created attachment 99941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99941=edit Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99639|0 |1 is obsolete|| --- Comment #68 from Martin Renvoize --- Created attachment 99939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99939=edit Bug 4461: Better error handling Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99638|0 |1 is obsolete|| --- Comment #67 from Martin Renvoize --- Created attachment 99938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99938=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99637|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize --- Created attachment 99937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99937=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99603|0 |1 is obsolete|| --- Comment #62 from Martin Renvoize --- Created attachment 99933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99933=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99636|0 |1 is obsolete|| --- Comment #65 from Martin Renvoize --- Created attachment 99936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99936=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99602|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 99932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99932=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99601|0 |1 is obsolete|| --- Comment #60 from Martin Renvoize --- Created attachment 99931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99931=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99635|0 |1 is obsolete|| --- Comment #64 from Martin Renvoize --- Created attachment 99935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99935=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99633|0 |1 is obsolete|| --- Comment #63 from Martin Renvoize --- Created attachment 99934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99934=edit Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99600|0 |1 is obsolete|| --- Comment #59 from Martin Renvoize --- Created attachment 99930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99930=edit Bug 4461: Problem Report Koha objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Attachment #99599|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 99929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99929=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What|Removed |Added Attachment #91593|0 |1 is obsolete|| --- Comment #97 from Arthur Suzuki --- Created attachment 99928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99928=edit Bug 11999: Test improvements improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
