[Koha-bugs] [Bug 24672] Error on receiving orders when there is an order with a deleted record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | --- Comment #6 from Tomás Cohen Arazi --- I was about to submit the same patch and found you filed it, Katrin. Thanks for the patch Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24672] Error on receiving orders when there is an order with a deleted record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 101502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101502=edit Bug 24672: (bug 24430 follow-up) Do not get active orders on deleted biblio record On bug 24430 we replaced the call to CountBiblioInOrders with Koha::Biblio->active_orders In case the bibliographic record is deleted, the count must be set to 0. This prevent the app to crash with: Can't call method "active_orders" on an undefined value at /home/vagrant/kohaclone/acqui/parcel.pl line 244 Test plan: Create 2+ orders Receive one, delete it, delete the bibliographic record Receive the order one => Without this patch, on the parcel page you should get the error => With this patch applied you must be allowed to finish the receive Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24672] Error on receiving orders when there is an order with a deleted record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 Tomás Cohen Arazi changed: What|Removed |Added Attachment #99090|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24672] Error on receiving orders when there is an order with a deleted record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24672 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #7 from Alex Buckley --- Sorry I had missed in my test plan that the new PrefillGuaranteeField syspref has the default value of phone|email|streetnumber|address|city|state|zipcode|country Which was suggested as defaults in the description of this bug report. All ready to test :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #6 from Alex Buckley --- Created attachment 101501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101501=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what fields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship')) select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 6. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 7. Observe this syspref containing the following: phone|email|streetnumber|address|city|state|zipcode|country 8. Repeat step 1 and observe the following fields are prefilled from guarantor: streetnumber address city state zipcode/postal code country Primary phone Primary email 9. Add the following content into PrefillGuaranteeField syspref and save: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone 10. Repeat step 1 and observe all fields in 'Main address', 'Alternate contact', and (except 'Guarantor surname', 'Guarantor first name', and 'relationship') in 'Contact' are pre-filled from guarantor 11. Change a few of the prefilled field values and 'Save' and observe your changes have been saved as have the values you haven't altered 12. Amend PrefillGuaranteeField syspref to be: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|drfregfre|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added a invalid column field 'drfregfre') 13. Repeat step 1 and observe no internal server errors and all fields listed in step 10 are still pre-filled 14. Amend PrefillGuarantee field syspref to be: phone|phonepro|mobile|email|contactfirstname|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added contactfirstname which is what the 'Guarantor first name' field in 'Contact' section of member entry form is) 15. Repeat step 1 and observe all fields defined in step 10 are filled and 'Guarantor first name' is not filled even though it was listed in PrefillGuarantorField because contactfirstname (along with contactsurname and relationship are meant for non Koha patrons and so should not pre-fill from a Koha patron) 16. Run tests: sudo koha-shell prove xt prove t Sponsored-by: Waitaki Distict Council, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley changed: What|Removed |Added Attachment #101499|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24960] New: 8080
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24960 Bug ID: 24960 Summary: 8080 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: e77699...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Created attachment 101500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101500=edit Join Join -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22534 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Change sponsored?|--- |Sponsored See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23808 --- Comment #5 from Alex Buckley --- Hi all, Patch finished. Please test when you are able to and let me know what you think :) Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #4 from Alex Buckley --- Created attachment 101499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101499=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what fields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship')) select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 6. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 7. Observe this syspref is empty 8. Repeat step 1 and observe none of the fields in 'Main address' , 'Contact' or 'Alternate address' are prefilled from guarantor 9. Add the following content into PrefillGuaranteeField syspref and save: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone 10. Repeat step 1 and observe all fields in 'Main address', 'Alternate contact', and (except 'Guarantor surname', 'Guarantor first name', and 'relationship') in 'Contact' are pre-filled from guarantor 11. Change a few of the prefilled field values and 'Save' and observe your changes have been saved as have the values you haven't altered 12. Amend PrefillGuaranteeField syspref to be: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|drfregfre|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added a invalid column field 'drfregfre') 13. Repeat step 1 and observe no internal server errors and all fields listed in step 10 are still pre-filled 14. Amend PrefillGuarantee field syspref to be: phone|phonepro|mobile|email|contactfirstname|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added contactfirstname which is what the 'Guarantor first name' field in 'Contact' section of member entry form is) 15. Repeat step 1 and observe all fields defined in step 10 are filled and 'Guarantor first name' is not filled even though it was listed in PrefillGuarantorField because contactfirstname (along with contactsurname and relationship are meant for non Koha patrons and so should not pre-fill from a Koha patron) 16. Run tests: sudo koha-shell prove xt prove t Sponsored-by: Waitaki Distict Council, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #23 from Joy Nelson --- Pushing to 19.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Lucas Gass changed: What|Removed |Added Attachment #101493|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 101498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101498=edit Bug 24886: Reindent reports template This patch reindents the template for saved reports, replacing tabs with spaces and making indentation consistent. Some lines have been split up. To test, apply the patch and go to Reports -> Use saved. - Test adding, editing, viewing, and running reports - Test filtering by group and subgroup - Test the process of adding a guided report Everything should work as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not your dad. The only changes you see should be split lines. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Lucas Gass changed: What|Removed |Added Attachment #101494|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Attachment #101497|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Lucas Gass changed: What|Removed |Added Attachment #101493|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Lucas Gass changed: What|Removed |Added Attachment #101493|0 |1 is obsolete|| Attachment #101494|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 101497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101497=edit Bug 24886: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 --- Comment #25 from Katrin Fischer --- Created attachment 101496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101496=edit Bug 24874: Printing is broken on opac-results.pl page to test: - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 Signed-off-by: Lucas Gass Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24425] Remove utf8 as an export option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24425 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om Assignee|koha-b...@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24850] Koha::DateUtils ignored offsets in RFC3339 datetimes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #21 from Bernardo Gonzalez Kriegel --- Martin, t/DateUtils.t fails always. An special setup is needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 --- Comment #1 from Owen Leonard --- Created attachment 101495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101495=edit Bug 24959: Fix id/label pairs in saved reports table This patch adds a unique id attribute to each checkbox in the table of saved reports. Also updated is the corresponding 's "for" attribute so that clicking the report id will toggle the checkbox. To reproduce, go to Reports -> Use saved and click a number in the ID column. Nothing happens. After applying the patch clicking the number should check or uncheck the corresponding checkbox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24959] Fix id/label pairs in saved reports table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Owen Leonard changed: What|Removed |Added Attachment #101491|0 |1 is obsolete|| Attachment #101492|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 101493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101493=edit Bug 24886: Reindent reports template This patch reindents the template for saved reports, replacing tabs with spaces and making indentation consistent. Some lines have been split up. To test, apply the patch and go to Reports -> Use saved. - Test adding, editing, viewing, and running reports - Test filtering by group and subgroup - Test the process of adding a guided report Everything should work as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not your dad. The only changes you see should be split lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 --- Comment #4 from Owen Leonard --- Created attachment 101494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101494=edit Bug 24886: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Owen Leonard changed: What|Removed |Added Blocks||24959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 [Bug 24959] Fix id/label pairs in saved reports table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24959] New: Fix id/label pairs in saved reports table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Bug ID: 24959 Summary: Fix id/label pairs in saved reports table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 24886 In the table of saved reports the number in the 'ID' column is wrapped in a tag, but clicking it doesn't check the corresponding checkbox because the "for" attribute doesn't match the ID of the checkbox. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 [Bug 24886] Reindent reports template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 --- Comment #2 from Owen Leonard --- Created attachment 101492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101492=edit Bug 24886: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24886] Reindent reports template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 --- Comment #1 from Owen Leonard --- Created attachment 101491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101491=edit Bug 24886: Reindent reports template This patch reindents the template for saved reports, replacing tabs with spaces and making indentation consistent. Some lines have been split up. To test, apply the patch and go to Reports -> Use saved. - Test adding, editing, viewing, and running reports - Test filtering by group and subgroup - Test the process of adding a guided report Everything should work as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm not your dad. The only changes you see should be split lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does not update last seen date for check-ins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #6 from Magnus Enger --- Looking at signing off this. Tempted to set it to "in discussion" because of comment 5, but I think Martin sort of answered it in comment 3? Then I see there are no tests for ProcessOfflineReturn, and not for ProcessOfflineIssue or ProcessOfflinePayment either. But asking for that might be a bit too much on this bug? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] OpenLibrarySearch doesnt return result correctly on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #1 from Heather --- This search in our 19.05 catalog shows several items with the text "Open Library: " where OpenLibrary actually has the item: https://keys.bywatersolutions.com/cgi-bin/koha/opac-search.pl?q=cachalot E.g., also, these records: https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=13955_desc=cachalot https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=13954_desc=fiction From those records in our catalog you can select "More searches," and the "Open Library..." search, you are taken to the Open Library where there are copies to borrow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] New: Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Bug ID: 24958 Summary: Remember last selected tab in SQL reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org I think it would be useful for the saved reports page to remember which tab the user last suggested. I propose to set a cookie to store the information. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24876] Fix capitalization on patron search for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876 Nick Clemens changed: What|Removed |Added Attachment #101354|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 101490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101490=edit Bug 24876: Fix capitalization on patron search for holds When placing a hold in the staff interface, the heading on the search box reads: Search Patrons or clubs The patch changes it to be Search patrons... instead. Also changes club id to club ID. To test: - Place a hold in the staff interface - Verify the capitalization error - Switch tabs to Clubs, see: club id - Apply patch - Verify it's all good now Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24876] Fix capitalization on patron search for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24876 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24854] Remove IDreamBooks integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24854] Remove IDreamBooks integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Nick Clemens changed: What|Removed |Added Attachment #101338|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 101489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101489=edit Bug 24854: Remove IDreamBooks integration The IDreamBooks service has not seen updates in a long time, so we should remove the service from Koha as it's no longer operational. To test: - Apply patch and run the database update - Verify that the IDreamBooks related system preferences are gone - Verify that opac detail pages and result lists still work as expected - Run t/db_dependent/UsageStats.t Signed-off-by: Lucas Gass Signed-off-by: Bernardo Gonzalez Kriegel Prefs gone. Fixed missing 'r' in atomic update message. Test pass, no errors. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24854] Remove IDreamBooks integration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24820] The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] New: OpenLibrarySearch doesnt return result correctly on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 Bug ID: 24957 Summary: OpenLibrarySearch doesnt return result correctly on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If you turn on OpenLibrarySearch results are often not returned and only the text "Open Library:" displays. Firstly, if there is nothing to return we should display nothing. Secondly, it does look like any of these records do return data but the API has changed, I think. Koha checks to see if "items: []" has length and returns false if this is true. But I am finding many records where the data seems to be present: (https://openlibrary.org/api/volumes/brief/json/id:0;isbn:067002662X;lccn:__2012035454) but items contains nothing. I don't know anything about the OpenLibrary API, but perhaps it has changed. TO RECREATE: 1. turn on OpenLibrarySearch 2. go to the opac results page and opac details page and see many records that just display "Open Library: " and nothing else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24956] New: Add ability to define emergency/override circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24956 Bug ID: 24956 Summary: Add ability to define emergency/override circ rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When there are library closings or adjustments due to unforeseen circumstances it would be nice to have a way to 'override' current circ rules, without needing to adjust individual circ rules and to preserve regular behaviour while allowing for large scale changes Idea would be like: 1 - Add new checkbox for 'Activate Emergency rules" 2 - Checking this box would make visible a new row in the circ table (colored red? bold?) 3 - The rules in the row would have _emergency appended to name (or be upper case, something to mark them as different 4 - These rules (if set and active) would override all other branch rules 5 - Code would be adjusted to pick these rules first if the branch is set to 'emergency' mode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #66 from Kyle M Hall --- Created attachment 101486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101486=edit Bug 22844: (QA follow-up) Build items.json for UniqueItemFields Adding items.json, built from latest kohastructure.sql. Control UniqueItemFields with this source file. And add StatisticsFields. Test plan: Go to Preferences, play with UniqueItemFields. Adjust StatisticsFields and look at patron record, statistics tab. Moved-from: Bug 22867 Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #68 from Kyle M Hall --- Created attachment 101488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101488=edit Bug 22844: Add is_boolean flag for new 'mandatory' column Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #64 from Kyle M Hall --- Created attachment 101484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101484=edit Bug 22844: Add the new entry to the patron attr types form Will conflict with bug 20443 \o/ Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #65 from Kyle M Hall --- Created attachment 101485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101485=edit Bug 22844: Make the attribute mandatory when editing a patron Note: I am not confident with this patch, I think it's not polished. I will not have time to improve it to make it ready for 19.05.00 1. Conflict with bug 20443 (which would have make this change way much easier!) 2. It does not work :) You will be able to submit the memberentry form even if the patron attribute is marked as mandatory (??) 3. What about the OPAC? 4. What about repeatable fields? We certainly will need JS code here 5. What about the "Quick add" feature? (I had trouble in the past to not introduce regression when we played with this template...) Do not forget to run updatedatabase.pl and regenerate DBIC schema if you want to play with this patchset. Signed-off-by: David Nind Bug 22844: (follow-up) Make the attribute mandatory when editing a patron Previous patch forgot the most important, adding the required attribute to the select/textarea Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #67 from Kyle M Hall --- Created attachment 101487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101487=edit Bug 22844: DBIC Schema changes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Kyle M Hall changed: What|Removed |Added Attachment #101480|0 |1 is obsolete|| --- Comment #61 from Kyle M Hall --- Created attachment 101481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101481=edit Bug 22844: Simplify the process of selecting database columns for system preferences This patch introduces a new way for users to select database columns for system preferences like BorrowerMandatoryField, which currently require hand-typing of database names. This new system uses a JSON file containing label:column pairs for database columns which are relevant to preferences which reference borrower table columns. My intention was to have user-friendly values as the labels, but embedding English strings in JSON would make them untranslatable. The following preferences are affected: - BorrowerMandatoryField - BorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test, apply the patch and regenerate the staff client CSS. restart_all to make sure the updated .pref file is used. - Go to Administration -> System preferences, and search for "PatronSelf" - The input fields for PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerMandatoryField, and PatronSelfRegistrationBorrowerUnwantedField should appear as "locked" (read-only) inputs. - Clicking the input field should trigger a modal window with checkboxes for each available column from the borrowers table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function (this eliminates the need to click a save button again after closing the modal). - Test this process by making modifications to all three different preferences, confirming that the right data is preselected each time the modal is shown and the right data is saved to the right field each time. Signed-off-by: Hayley Mapley Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #63 from Kyle M Hall --- Created attachment 101483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101483=edit Bug 22844: Add the new DB column borrower_attribute_types.mandatory Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #62 from Kyle M Hall --- Created attachment 101482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101482=edit Bug 22844: (QA follow-up) Add pref PatronQuickAddFields too Description slightly adjusted. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Kyle M Hall changed: What|Removed |Added Attachment #101302|0 |1 is obsolete|| --- Comment #60 from Kyle M Hall --- Created attachment 101480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101480=edit Bug 22844: Simplify the process of selecting database columns for system preferences This patch introduces a new way for users to select database columns for system preferences like BorrowerMandatoryField, which currently require hand-typing of database names. This new system uses a JSON file containing label:column pairs for database columns which are relevant to preferences which reference borrower table columns. My intention was to have user-friendly values as the labels, but embedding English strings in JSON would make them untranslatable. The following preferences are affected: - BorrowerMandatoryField - BorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField To test, apply the patch and regenerate the staff client CSS. restart_all to make sure the updated .pref file is used. - Go to Administration -> System preferences, and search for "PatronSelf" - The input fields for PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerMandatoryField, and PatronSelfRegistrationBorrowerUnwantedField should appear as "locked" (read-only) inputs. - Clicking the input field should trigger a modal window with checkboxes for each available column from the borrowers table. - Test that the "select all" and "clear all" links work correctly. - Test that the "cancel" link closes the modal without saving your selections. - Test that the "Save" button closes the modal, copies your selections to the form field, and triggers the preference-saving function (this eliminates the need to click a save button again after closing the modal). - Test this process by making modifications to all three different preferences, confirming that the right data is preselected each time the modal is shown and the right data is saved to the right field each time. Signed-off-by: Hayley Mapley Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Owen Leonard changed: What|Removed |Added Attachment #101065|0 |1 is obsolete|| --- Comment #42 from Owen Leonard --- Created attachment 101479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101479=edit Bug 13881: Add desk management Add a desk and linked it to a library (branch). That's it. In the future it'll have super features like being able to link waiting reserve to a specific desk. Test plan: 1. go to the administration page and notice there isn't any mention of desk whatsoever 2. apply patches 3. ./installer/data/mysql/updatedatabase.pl 4. prove t/db_dependent/Koha/Desks.t 5. you now have desks links in admin-home and admin-menu 6. click the link 7. add a desk 8. add another one 9. delete one 10. you should have a fair list of all current desks defined 11. Done Signed-off-by: Séverine QUEUNE Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24738] Online registration confirmation/clarification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24738 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24951] Payout modal confirm button should have an ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951 Lucas Gass changed: What|Removed |Added Attachment #101440|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 101478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101478=edit Bug 24951: Add id to payout modal confirm button This patch adds an ID to the payout confirmation modal on the borrower account details page. Test plan: 1/ Apply patch 2/ Attempt to issue a payout to a patron 3/ Inspect the page and note the presence of an ID for the confirm button 4/ Signoff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24951] Payout modal confirm button should have an ID
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24951 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 --- Comment #24 from Owen Leonard --- I'm adding my signoff because I can reproduce the problem in both 19.11.x and master in both Firefox and Chrome (OSX), and the patch fixes it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Owen Leonard changed: What|Removed |Added Attachment #101063|0 |1 is obsolete|| --- Comment #23 from Owen Leonard --- Created attachment 101477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101477=edit Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 Signed-off-by: Lucas Gass Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #158 from Jonathan Druart --- Created attachment 101476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101476=edit Bug 23463: (follow-up 3) Fix timestamp default value This is the only situation I found where: * t/db_dependent/Koha/Item.t is passing * t/db_dependent/Koha/Object.t is passing * MySQL 8 is happy (and not fail with "Column 'timestamp' cannot be null"), which is certainly what I missed in the previous follow-up I think we should remove the lines from the overloaded ->store method (Item and Patron), but then we need Object.t to be adjusted. I do not understand why we would need to set updated_on, maybe the test is wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #31 from Nick Clemens --- Created attachment 101475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101475=edit Bug 16787: DO NOT PUSH - Shcema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #30 from Nick Clemens --- Created attachment 101474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101474=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Attachment #99949|0 |1 is obsolete|| Attachment #99950|0 |1 is obsolete|| Attachment #100951|0 |1 is obsolete|| --- Comment #29 from Nick Clemens --- Created attachment 101473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101473=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #87 from Jonathan Druart --- Created attachment 101472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101472=edit Bug 20443: Add missing use statement This is a follow-up for commit 836e950d25148ca04ed0561c487772e3b0f7f8ee Bug 20443: Remove SearchIdMatchingAttribute We removed the use of C4::Members::Attributes, that was using Text::CSV -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 --- Comment #22 from Lucas Gass --- Without patch: If I set IDreamBooksReadometer, IDreamBooksResults, IDreamBooksReviews to ADD: all looks well. If I set them to DON'T ADD: My printed results look bad. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 --- Comment #21 from Jonathan Druart --- Created attachment 101471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101471=edit After (master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 --- Comment #20 from Jonathan Druart --- Created attachment 101470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101470=edit Before (master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24874] Printing is broken on opac-results.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24874 --- Comment #19 from Katrin Fischer --- Could the custom CSS be interfering? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #101462|0 |1 is obsolete|| --- Comment #30 from Katrin Fischer --- Created attachment 101468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101468=edit Bug 21443: Mark new columns as boolean in schema file Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #101463|0 |1 is obsolete|| --- Comment #31 from Katrin Fischer --- Created attachment 101469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101469=edit Bug 21443: Remove the dependency on finesCalendar Considering that the the use of finesCalendar for this calculation is already a binary choice, it makes sense to remove the use of finesCalendar here. It is an uneccessary complication that could introduce confusion. Allowing this new setting to directly control the behavior makes it clear and obvious what is going on. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #101459|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 101465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101465=edit Bug 21443: Update Schema [DO NOT PUSH] Signed-off-by: Kyle M Hall Signed-off-by: Marti Fuerst Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #101461|0 |1 is obsolete|| --- Comment #29 from Katrin Fischer --- Created attachment 101467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101467=edit Bug 21443: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Marti Fuerst Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #101460|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 101466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101466=edit Bug 21443: Add ability to exclude holidays when calculating rentals fees by time period Signed-off-by: Kyle M Hall Signed-off-by: Marti Fuerst Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #101458|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 101464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101464=edit Bug 21443: Update database Signed-off-by: Kyle M Hall Signed-off-by: Marti Fuerst Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #100747|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 101460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101460=edit Bug 21443: Add ability to exclude holidays when calculating rentals fees by time period Signed-off-by: Kyle M Hall Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #101431|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 101463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101463=edit Bug 21443: Remove the dependency on finesCalendar Considering that the the use of finesCalendar for this calculation is already a binary choice, it makes sense to remove the use of finesCalendar here. It is an uneccessary complication that could introduce confusion. Allowing this new setting to directly control the behavior makes it clear and obvious what is going on. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #100745|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 101458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101458=edit Bug 21443: Update database Signed-off-by: Kyle M Hall Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #100748|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 101461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101461=edit Bug 21443: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #101430|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 101462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101462=edit Bug 21443: Mark new columns as boolean in schema file Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Attachment #100746|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 101459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101459=edit Bug 21443: Update Schema [DO NOT PUSH] Signed-off-by: Kyle M Hall Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837 Jonathan Druart changed: What|Removed |Added Attachment #101371|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 101457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101457=edit Bug 24837: Rename selectbranchprinter.pl to set-library.pl This renames the selectbranchprinter.pl file to the more fitting set-library.pl. To test: - Change the library with "Set library" from - The menu in the top navigation bar - The circulation start page - Verify the help link on page leads to the correct section in the manual - Read the code... and verify all occurences have been caught Signed-off-by: Bernardo Gonzalez Kriegel Works ok, fixed tab char in circ/branchtransfers.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24837] selectbranchprinter needs to be renamed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24837 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19036] Number payment receipts / payment slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #18 from Julian Maurice --- (In reply to Julian Maurice from comment #17) > I will add the "Auto generate credit number" parameter In fact, it's not that simple. "system" credit types cannot be modified :/ Should I add the possibility to edit them but only allow this parameter to be modifiable ? Or should I find another way (another syspref for example) ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24953] Minor corrections to hold ratios report sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- Treating this as a follow-up for bug 24907 - thx Owen! Btw... the filters on the funds page look a bit ill-formatted too ;) http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 --- Comment #15 from Jonathan Druart --- There is still one test missing, I do not manage to fix it. Could I get some help? t/db_dependent/SIP/Message.t .. 1/4 # Failed test 'Check screen msg' # at t/db_dependent/SIP/Message.t line 507. # got: 'Item not checked out' # expected: 'Checkin failed' # Looks like you failed 1 test of 29. t/db_dependent/SIP/Message.t .. 3/4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 --- Comment #14 from Jonathan Druart --- Created attachment 101456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101456=edit Bug 23403: List borrowernumber in the ILS::Patron fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24953] Minor corrections to hold ratios report sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24953] Minor corrections to hold ratios report sidebar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24953 Katrin Fischer changed: What|Removed |Added Attachment #101435|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 101455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101455=edit Bug 24953: Minor corrections to hold ratios report sidebar This patch makes some minor corrections to the sidebar form on the hold ratios report page: - Correct markup errors - Change the text of labels from "included" to "include" - Move checkboxes to the left of labels To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Go to Circulation -> Hold ratios - In the sidebar, confirm that the labels "Include ordered" and "Include suspended" appear to the right of their associated checkboxes. - Validate the source of the page. There should be no errors. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20307] Language overlay for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #103 from Julian Maurice --- (In reply to Katrin Fischer from comment #102) > It sounds unlikely as our categories should be unique enough, aren't they? But users can create their own categories. I agree that it is unlikely, but it is still possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24754] UserEnv not set for ISLDI requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24754 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #29 from Tomás Cohen Arazi --- I agree ILSDI should set its own userenv as it is really not dependent on the current cookie. This is a nasty side effect of our coding practices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #18 from Paul Thornton --- Hello Jonathan I touched base with Simon and he says the best thing would be if PTFS can re-send the link to the sandbox for this bug and he can retest. Can you organise that please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24955] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24955 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Bro |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20307] Language overlay for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #102 from Katrin Fischer --- (In reply to Jonathan Druart from comment #98) > Created attachment 101070 [details] [review] > Bug 20307: Replace separator with # > > To avoid colision we replace the separator with something that is > supposed to be less used than underscore > > The problematic case was explaing by Julian on comment 96: > """ > The value stored in localization.code is a concatenation of the AV > category code, a '_', and the AV code. Which means that if we have a > category A with a value B_C, and a category A_B with a value C, they will > share their translations. > """ It sounds unlikely as our categories should be unique enough, aren't they? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24955] New: Bro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24955 Bug ID: 24955 Summary: Bro Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: fikriazm...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101454=edit Hacked by:./Tn.Dew4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24954] New: Bro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24954 Bug ID: 24954 Summary: Bro Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: fikriazm...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 101453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101453=edit Hacked by:./Tn.Dew4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24954] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24954 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Bro |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
