[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #37 from Aleisha Amohia --- Created attachment 102336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102336=edit Bug 20844: (follow-up) Get working with transfers Test: 1) Change branch to Branch B 2) Place a biblio-level hold at Branch B 3) Change branch to Branch A 4) Check in item at Branch A and set waiting and trigger transfer 5) Go to edit item and set item as lost 6) Check borrower's notices tab and confirm the lost_waiting_hold notice was enqueued 7) Follow test plan again with item-level hold Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #36 from Aleisha Amohia --- Created attachment 102335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102335=edit Bug 20844: (follow-up) SendLostHoldNotices This patch adds a new syspref SendLostHoldNotices Test: 1) Update database and restart memcached 2) Enable the SendLostHoldNotices system preference 3) Place a hold on an item 4) Check in the item and set the hold to waiting 5) Go to edit the item and set an item lost status 6) Check the borrower's notices and confirm the notice has been enqueued 7) Confirm the notice is not sent twice when reverting or cancelling the hold 8) Confirm notice enqueues as expected for a bib-level hold Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Aleisha Amohia changed: What|Removed |Added Attachment #81710|0 |1 is obsolete|| Attachment #81711|0 |1 is obsolete|| Attachment #81712|0 |1 is obsolete|| --- Comment #35 from Aleisha Amohia --- Created attachment 102334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102334=edit Bug 20844: Revert or cancel lost holds This patch introduces the RevertLostBibLevelHolds syspref. When an item is marked as lost, if there is a bib-level hold on it waiting, the hold is reverted. If there is an item-level hold on it waiting, there is an alert box asking if the library would like to revert the hold or cancel it. Test: 1) Update database and restart memcached/plack 2) Place a hold on Biblio A 3) Check in Item A from Biblio A and set the hold as waiting 4) Edit Item A and give it a lost status (952$1, you may need to edit your MARC frameworks to have this visible in the Editor) 5) Look at your hold. Notice it is still waiting. 6) Go to Administration -> System preferences. Find the RevertLostBibLevelHolds system preference and enable it. 7) Cancel your hold and remove Item A's lost status. Place another biblio-level hold on the same biblio 8) Check in Item A from Biblio A and set the hold as waiting 9) Go to the Items tab for Biblio A (catalogue/moredetail.pl) 10) Edit Item A and give it a lost status 11) Once the page reloads, go to view your hold. It should no longer be waiting and have no item allocated. 12) Cancel your hold and remove Item A's lost status. Place an item-level hold on Item A 13) Check in Item A and set the hold as waiting 14) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and click 'Edit' for Item A (end up on cataloguing/additem.pl) 15) Give Item A a lost status and save changes 16) Once the page reloads, confirm there is an alert box asking you to revert or cancel the hold. Click Revert 17) Confirm your hold is no longer waiting, but the item is still allocated 18) Remove Item A's lost status 19) Check in Item A and set the hold as waiting 20) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and click 'Edit' for Item A (end up on cataloguing/additem.pl) 21) Give Item A a lost status and save changes 22) Once the page reloads, confirm there is an alert box asking you to revert or cancel the hold. Click Cancel 23) Confirm the hold is now cancelled 24) Remove Item A's lost status 25) Place an item-level hold on Item A 26) Check in Item A and set the hold as waiting 27) Go to the Items tab for Biblio A (catalogue/moredetail.pl) 28) Give Item A a lost status and save changes 29) Once the page reloads, confirm there is an alert box asking you to revert or cancel the hold. Click Revert 30) Confirm your hold is no longer waiting, but the item is still allocated 31) Remove Item A's lost status 32) Check in Item A and set the hold as waiting 33) Go to the Items tab for Biblio A (catalogue/moredetail.pl) 34) Give Item A a lost status and save changes 35) Once the page reloads, confirm there is an alert box asking you to revert or cancel the hold. Click Cancel 36) Confirm the hold is now cancelled 37) Remove Item A's lost status 38) Place an item-level hold on Item A. Check in Item A and set the hold as waiting 39) Place an item-level hold on Item B (same biblio) for another borrower. Check in Item B and set the hold as waiting. 40) Give both Items A and B lost statuses. 41) Confirm that both Items are included in the alert box on page when editing items (cataloguing/additem.pl) 42) Confirm that both Items have individual alert boxes on the Items tab (catalogue/moredetail.pl) 43) Confirm tests pass t/db_dependent/Reserves.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25048] Successful resource deletion should return 204
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 102333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102333=edit Bug 25048: Make successful resource deletion return 204 This patch adapts the spec and the controllers so existing routes return 204 and an empty response body when a successful deletion happens. Right now we have a coding guideline but haven't adapted the existing routes. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/*.t => FAIL: Some tests fail 3. Apply this patch 4. Repeat 2. => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25048] Successful resource deletion should return 204
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 102332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102332=edit Bug 25048: Regression tests This patch adds regression tests for the response bodies and statuses on DELETE actions against existing API routes. This is just enforcing the existing (voted) Coding guidelines for the API (tm). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/*.t => FAIL: Several routes have problems -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 [Bug 25048] Successful resource deletion should return 204 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25048] Successful resource deletion should return 204
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 Tomás Cohen Arazi changed: What|Removed |Added Depends on||25032 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25048] Successful resource deletion should return 204
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com URL||https://wiki.koha-community ||.org/wiki/Coding_Guidelines ||_-_API#SWAGGER3.2.4_DELETE Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24839] branchtransfers does not deal with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24839 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.05 released in|| --- Comment #12 from Joy Nelson --- Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24777] Use patron.is_debarred instead of patron.debarred in return.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24777 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.05 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #5 from Joy Nelson --- Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23268] "Suspend all holds" calendar allows to select past date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23268 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.05 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Joy Nelson --- Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25001] 'News' should be renamed now we are migrating other content blocks to it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25001 --- Comment #2 from David Roberts --- How about renaming it to "OPAC Customisation"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23926] In EDI Order limit GIR segment to five pieces of information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23926 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #8 from Joy Nelson --- I get a Fail on qa when applying this patch FAIL Koha/Edifact/Order.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage FAIL spelling dont ==> don't dont ==> don't dont ==> don't dont ==> don't OK valid not backporting to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream, and fudge flavors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #13 from Lisette Scheer --- Grandma's Ginger Cookies Test plan: 1. Blend 1 1/2 cups butter with 2 cups granulated sugar. 2. Beat in 2 eggs. 3. Add 1/2 cup of molasses 4. Add 4 cups flour, 2 teaspoons baking soda, 2 teaspoons ground cinnamon, 2 teaspoons ground cloves, and 2 teaspoons ground ginger. 5. Mix Well 6. Roll into 1" balls. 7. Dip in granulated sugar. 8. Bake at 375 fir 9-12 minutes. 9. Enjoy -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22373] Stock Rotation duration test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22373 Lisette Scheer changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18127] Add batch modified records to an existing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #18 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #172 from David Nind --- Note: Bug 25040 needs to be applied first for this to work correctly (see comment 146). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102281|0 |1 is obsolete|| --- Comment #171 from David Nind --- Created attachment 102331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102331=edit Bug 4461: Fix OPAC link from staff QA: We have a security issue here, we should not make this link clickable from the staff side. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102211|0 |1 is obsolete|| --- Comment #169 from David Nind --- Created attachment 102329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102329=edit Bug 4461: Fix status and borrowernumber fields in problem_reports and more status varchar(6) with readable statuses borrowernumber not null default 0 hide form if message successfully sent fixing hide viewed and hide closed filters adding recipient column Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102210|0 |1 is obsolete|| --- Comment #168 from David Nind --- Created attachment 102328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102328=edit Bug 4461: DBIC Schema Files Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102279|0 |1 is obsolete|| --- Comment #170 from David Nind --- Created attachment 102330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102330=edit Bug 4461: get_effective_email has been renamed inbound_email_address On commit 027051c938924a33a64014794705526ab68351af Bug 22823: Rename method with ->inbound_email_address Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102206|0 |1 is obsolete|| --- Comment #164 from David Nind --- Created attachment 102324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102324=edit Bug 4461: Manage problem reports on the staff client Test plan: - Update database and upgrade schema files (if you haven't already). Restart memcached - Check your user's permissions and ensure the 'problem_reports' permission is ticked. Confirm the OPACReportProblem syspref is enabled - Log into the OPAC and submit a problem report - Log into the staff client - You should see a box at the bottom of the main page showing your pending problem report - Click the link and confirm it takes you to the new page for managing problem reports - Go to Administration - Confirm you can see a link to 'OPAC problem reports' under the 'Additional parameters' heading - Click 'OPAC problem reports' - Confirm your problem report is showing in the table - Open the OPAC in another tab and submit at least two more problem reports (so you should have at least three in the table after refreshing) - Try the different buttons - selecting multiple problem reports and using the big 'mark viewed', 'mark closed', 'mark new' buttons. Confirm there are no failures and that the number of selected problem reports is correct - select all, clear all, hide viewed, hide closed, hide new, show all - individual 'mark viewed', 'mark closed', 'mark new' buttons for each problem report. Confirm the status shows and the correct button is disabled while others are enabled - Confirm the problem page link works as expected Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102209|0 |1 is obsolete|| --- Comment #167 from David Nind --- Created attachment 102327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102327=edit Bug 4461: Checks on library email before enqueuing letter Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102208|0 |1 is obsolete|| --- Comment #166 from David Nind --- Created attachment 102326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102326=edit Bug 4461: Update license statements Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102207|0 |1 is obsolete|| --- Comment #165 from David Nind --- Created attachment 102325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102325=edit Bug 4461: (follow-up) Add missing relationship accessor I think this was a simple case of Aliesha missing a file when commiting. So I could proceed with testing I just quickly re-implimented the patron relationship accessor. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102205|0 |1 is obsolete|| --- Comment #163 from David Nind --- Created attachment 102323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102323=edit Bug 4461: Add problem reports link to mainpage and admin home Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102203|0 |1 is obsolete|| --- Comment #161 from David Nind --- Created attachment 102321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102321=edit Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102201|0 |1 is obsolete|| --- Comment #159 from David Nind --- Created attachment 102319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102319=edit Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102200|0 |1 is obsolete|| --- Comment #158 from David Nind --- Created attachment 102318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102318=edit Bug 4461: Better error handling Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102204|0 |1 is obsolete|| --- Comment #162 from David Nind --- Created attachment 102322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102322=edit Bug 4461: Adding user flags for managing OPAC problem reports Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102202|0 |1 is obsolete|| --- Comment #160 from David Nind --- Created attachment 102320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102320=edit Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102198|0 |1 is obsolete|| --- Comment #157 from David Nind --- Created attachment 102317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102317=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102196|0 |1 is obsolete|| --- Comment #156 from David Nind --- Created attachment 102316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102316=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102195|0 |1 is obsolete|| --- Comment #155 from David Nind --- Created attachment 102315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102315=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #50 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102193|0 |1 is obsolete|| --- Comment #153 from David Nind --- Created attachment 102313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102313=edit Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102194|0 |1 is obsolete|| --- Comment #154 from David Nind --- Created attachment 102314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102314=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24965] Koha::Object->to_api should handle undef counts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102192|0 |1 is obsolete|| --- Comment #152 from David Nind --- Created attachment 102312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102312=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102191|0 |1 is obsolete|| --- Comment #151 from David Nind --- Created attachment 102311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102311=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102190|0 |1 is obsolete|| --- Comment #150 from David Nind --- Created attachment 102310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102310=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102189|0 |1 is obsolete|| --- Comment #149 from David Nind --- Created attachment 102309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102309=edit Bug 4461: Problem Report Koha objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102188|0 |1 is obsolete|| --- Comment #148 from David Nind --- Created attachment 102308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102308=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17845] Remove printer related code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #27 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17421] Missing dependency on CGI::Emulate::PSGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17421 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer --- (In reply to David Cook from comment #5) > Given the age of this bug, I think it's probably safe to close it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 --- Comment #8 from Tomás Cohen Arazi --- Ok, I have submitted a a testable patch set. I added changes to all controller methods so they just use the new helper. A simple diff shows we needed this :-D - The only logic change in the controllers is (in a small number of cases) just wrapping the code in a try/catch construct having $c->unhandled_exception($_); in the catch block. - There's a change in the Password.pm controller removing an exception throwing to simplifly it a bit and making it similar to the other method. - I haven't touched Auth.pm (yet), if I do I would like to do it on a separate bug, being it a sensible part of the API codebase. - There are several endpoints already! Having the chance to review them all, I found several inconsistencies I will try to deal with on separate bugs for clarity (for example bug 25048). If this approach is palatable to you, please SO and QA fast so we can add this to the guidelines and people start coding using this. The API has the advantage we've enforced full coverage, and this patches change untestable conditions, i.e. some catch-all code we added just in case, so all tests should pass with or without the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 102307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102307=edit Bug 25032: Make existing controllers use unhandled_exception This simple patch removes 'just in case' handling of specific exceptions and makes the current routes controllers use the unhandled_exception helper. Most possible exceptions are already catch by our tools (Koha::Object, etc) and the existing code is not looking for known possible exceptions but has just been copied and pasted since our beginings. Anytime a situation in which an unhandled exception is caught, we (the devs) should report it and specific exception handling discussed and solved. But this has just been useless scaffolding so far. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/*.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1. => SUCCESS: Tests still pass 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032
--- Comment #6 from Tomás Cohen Arazi ---
Created attachment 102306
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102306=edit
Bug 25032: Generic unhandled exception handling on API [WIP]
This patch adds Koha::Logger as the default logger for the API, and
introduces a new helper plugin that takes care of handling the unhandled
exceptions. Basically, with this we would write something like this in
our controller methods:
try {
...
}
catch {
if ( know_exception ) {
handle_known_exception($_);
}
$c->unhandled_exception($_);
}
Without this, we end up adding more and more handling 'just in case'.
This is WIP, to test:
1. Edit the Koha/REST/V1/Cities.pm 'list' method adding
die("Nada"); before the render step.
2. Restart plack and try the endpoint
=> FAIL: A generic error is displayed, and no traces of the original
problem are found on the logs.
3. Apply this patches, make sure your instance's log4perl has the
introduced lines for API with the right path.
4. Repeat 2
=> SUCCESS: The message is still generic, but you see something is
logged in /var/log/koha/kohadev/api-error.log
5. Discuss the approach on the bug, with special attention on:
- Can Koha::Logger be used in Mojo like that? It seems so
- How the heck can we write tests for the change in V1.pm?
- Do you really like what I put in the log? Should we change that?
That was just the first thing that crossed my mind so ideas are
welcome.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 102305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102305=edit Bug 25032: Add 'api' target to log4perl.conf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 Tomás Cohen Arazi changed: What|Removed |Added Attachment #102161|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 Tomás Cohen Arazi changed: What|Removed |Added Attachment #102160|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 --- Comment #4 from David Nind --- (In reply to David Nind from comment #2) > I did note that if there is no image available, then there is a visible > border but with nothing inside of it. This is now fixed. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23112] Circulation of ILL items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #87 from Joy Nelson --- new feature not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24594] Rewrite MARC21 mandatory data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #14 from Joy Nelson --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24593] Rewrite MARC21 optional data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24593 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #14 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Joy Nelson changed: What|Removed |Added Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Joy Nelson changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.05 released in|| Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Joy Nelson changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Bug 24152 depends on bug 19008, which changed state. Bug 19008 Summary: More database cleanups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19008] More database cleanups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Joy Nelson changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #52 from Joy Nelson --- Requested this be pushed to 19.11.x for GDPR. Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Bug 18081 depends on bug 19008, which changed state. Bug 19008 Summary: More database cleanups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25046] C4::Utils::DataTables::Members does not SELECT othernames from borrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25046 Andreas Roussos changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25046] C4::Utils::DataTables::Members does not SELECT othernames from borrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25046 --- Comment #1 from Andreas Roussos --- Created attachment 102304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102304=edit Bug 25046: Include borrowers.othernames in SELECT statement In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches patron data from the database does not include borrowers.othernames in the field list. As a consequence, when the output is in the form of a DataTable, the Template Toolkit files that refer to .othernames (such as the patron-title.inc include) won't display the information from the 'Other name' input field if that field has been filled in. This patch fixes that. Test plan: 0) Have a few patrons with some data in the 'Other name' field. 1) Perform a generic search in Home > Patrons to ensure you will get a DataTable with results. 2) Observe that the 'Name' column does not include 'Other name' info. 3) Apply the patch, and restart Plack if necessary. 4) Repeat your search: this time you should see the information from the 'Other name' field, it will be next to the patron's First name and within parentheses. Sponsored-by: Eugenides Foundation Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25048] Successful resource deletion should return 204
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 --- Comment #1 from Tomás Cohen Arazi --- References for people reviewing this: - RESTful DELETE: https://restfulapi.net/http-methods/#delete - OpenAPI handling on 204: https://swagger.io/docs/specification/2-0/describing-responses/ In the latter search for 'Empty Response Body'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25048] Successful resource deletion should return 204
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25048] Successful resource deletion should return 204
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25048] New: Successful resource deletion should return 204
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25048 Bug ID: 25048 Summary: Successful resource deletion should return 204 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com As stated in our coding guidelines for the API [1], when deleting a resource, the API should return a 204 instead of the 200 some do now. [1] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER3.2.4_DELETE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25047] New: Tutorial for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25047 Bug ID: 25047 Summary: Tutorial for OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org Has anyone considered working on a guided tutorial through the OPAC for new users? I'm talking about the OPAC guiding a new user through the different things they can do, with balloons that point out different things. At any point it could be skipped, or restarted. It would be great if there were an admin option panel for what pieces of the tutorial, and in what order, they would like patrons guided through (in case there are some elements that the library don't use). And it would be great if each section of the tutorial could be linked, so if someone asked about how to do something, we could like them to the specific tutorial for what they are asking about. I also see the possibility of being able to customize the tutorials (the balloons), or adding others. IF libraries could create a new tutorial, and tell each balloon what to point at and what to say, that would be great. It probably means that it should give a list of available element IDs for each page that the balloon could point to. Something like that. The tutorials could also track if they have ever been played on that browser (probably through a cookie) and if a new tutorial is added that a user hasn't seen, they can be given the option to go through it or skip it. This system could also be used for for information, similar to news, but for a specific section. For example, during the COVID-19 library closures, we could have used one of these balloons on the hold page to indicate that we are accepting hold requests, but holds are not being filled at this time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032
--- Comment #4 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #3)
> I cannot test this, I get this scary message on /api/v1/app.pl
I don't know why are you pointing your API tool there or if it is related to
this or not. If you want to bypass the rewrite rules we have, the right path to
get to the API is:
GET /api/v1/app.pl/api/v1
You will get the current spec in JSON format. You can request
GET /api/v1/app.pl/api/v1/.html
to get a nicer (?) HTML formatted spec.
That said, WTF? Just use
GET /api/v1/
instead :-D
:-D
> And cities returns "error" (basically).
This is the change I made to try this patch:
diff --git a/Koha/REST/V1/Cities.pm b/Koha/REST/V1/Cities.pm
index 4c49e1a346..8c45a9031e 100644
--- a/Koha/REST/V1/Cities.pm
+++ b/Koha/REST/V1/Cities.pm
@@ -37,17 +37,11 @@ sub list {
return try {
my $cities_set = Koha::Cities->new;
my $cities = $c->objects->search( $cities_set );
+die "Nada";
return $c->render( status => 200, openapi => $cities );
}
catch {
-if ( $_->isa('DBIx::Class::Exception') ) {
-return $c->render( status => 500,
- openapi => { error => $_->{msg} } );
-}
-else {
-return $c->render( status => 500,
-openapi => { error => "Something went wrong, check the logs."}
);
-}
+$c->unhandled_exception($_);
};
}
I will submit a follow-up patch with the changes for the Cities.pm controller
class so we look at the same thing. I will ommit the die "Nada"; line.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24817] Fix timing issues in t/db_dependant/Koha/Cash/Register.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24817 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #15 from Joy Nelson --- 'Does not apply' to 19.11.x branch. not backporting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] REST API public route accessible if OpacPublic is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 --- Comment #2 from Tomás Cohen Arazi --- Hmm, I got the OpacPublic behaviour wrong. This needs to be discussed in a dev meeting I belive. OpacPublic doesn't disable the OPAC as I thought (based on my memories from the 'have an on/off switch for the API' discussion), but only allow interacting with it after there's a valid session. We might need to develop some way to identify public routes that don't require a session. We don't have such routes yet, but worth considering as there are routes like the one for fetching records on the QA queue. We should add that to the agenda. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25046] C4::Utils::DataTables::Members does not SELECT othernames from borrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25046 Andreas Roussos changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |a.rous...@dataly.gr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25046] New: C4::Utils::DataTables::Members does not SELECT othernames from borrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25046 Bug ID: 25046 Summary: C4::Utils::DataTables::Members does not SELECT othernames from borrowers table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: a.rous...@dataly.gr QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches patron data from the database does not include borrowers.othernames in the field list. As a consequence, when the output is in the form of a DataTable, the Template Toolkit files that refer to .othernames (such as the patron-title.inc include) won't display the information from the "Other name" input field if that field has been filled in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24788] Koha::Object->store calls column names as methods, relying on AUTOLOAD, with possibly surprising results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.05 released in|| --- Comment #9 from Joy Nelson --- backported to 19.11.x branch for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24760] BackgroundJob tests fail with latest versions of YAML or YAML::Syck
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24760 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.05 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #7 from Joy Nelson --- Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23384] Calling Koha::Article::Status::* without "use" in Patron.pm can cause breakage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23384 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.05 released in|| Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com --- Comment #14 from Joy Nelson --- Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #7 from Joy Nelson --- I encounter a qa error with this patch FAIL Koha/Patron.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'trim_whitespaces' OK spelling OK valid not backporting to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24219] Elasticsearch needs to remember sort preference when returning to result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24219 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #9 from Joy Nelson --- does not apply to 19.11.x branch. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966 --- Comment #4 from Kyle M Hall --- (In reply to Jonathan Druart from comment #3) > Could you provide a test? I did not manage to write one that fails without > your patch. > I suspect a place where we return () instead of undef Try as I might, I cannot replicate the error outside of production. Instead of this patch, would a patch reordering the parameters by more acceptable? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] REST API public route accessible if OpacPublic is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] REST API public route accessible if OpacPublic is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] REST API public route accessible if OpacPublic is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #1 from Tomás Cohen Arazi --- This was broadly discussed by the time this got implemented. The idea was that one could want the OPACDisabled, but enable the API for, say, using it from an external system, like a discovery tool like VuFind. That said, I think we need to add a clear message on the OPACPublic syspref about the API, and probably an entry warning about !OPACPublic && RESTPublicAPI meaning the API is accessible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25040] Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25040] Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Jonathan Druart changed: What|Removed |Added Severity|major |blocker --- Comment #2 from Jonathan Druart --- Raising severity, we need that ASAP! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 --- Comment #30 from Simon Perry --- Created attachment 102303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102303=edit Sandbox error Hi, I've just tried to complete testing but am getting an error when I try to add a new bib record or item for testing. See attached for details. Thanks, Simon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #12 from Owen Leonard --- Created attachment 102301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102301=edit Bug 25033: Remove CountSuggestion Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #11 from Owen Leonard --- Created attachment 102300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102300=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3" suggestions 8 - Confirm that the links take you to suggestions view of your branch or all libraries respectively 9 - Turn on IndependentBranches 10 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 11 - Sign in as that user 11 - See "Centerville: 1" suggestion on mainpage and on acqui home Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #13 from Owen Leonard --- Created attachment 102302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102302=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Owen Leonard changed: What|Removed |Added Attachment #102282|0 |1 is obsolete|| Attachment #102283|0 |1 is obsolete|| Attachment #102284|0 |1 is obsolete|| Attachment #102285|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 102299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102299=edit Bug 25033: Add filter_by_user_branch to Koha/Suggestions.pm Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032
--- Comment #3 from Jonathan Druart
---
I cannot test this, I get this scary message on /api/v1/app.pl
The application raised the following error:
Can't use an undefined value as an ARRAY reference at template
mojo/debug.html.ep line 311.
306: %= $kv->(Time => scalar localtime(time))
307:
308:
309: tap for more
310:
311: % if (@{app->log->history}) {
312:
313:
314: % for my $msg (@{app->log->history}) {
315:
316:
and the StackTrace middleware couldn't catch its stack trace, possibly because
your application overrides $SIG{__DIE__} by itself, preventing the middleware
from working correctly. Remove the offending code or module that does it: known
examples are CGI::Carp and Carp::Always.
And cities returns "error" (basically).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25045] New: REST API public route accessible if OpacPublic is off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 Bug ID: 25045 Summary: REST API public route accessible if OpacPublic is off Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 22061 There is RESTPublicAPI to deal with that, but both are enabled by default. One could think that turning OpacPublic off will make all the data non-accessible, but that's wrong. Maybe we need a note on OpacPublic to explain the situation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061 [Bug 22061] Add route to change patron's password (public) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22061] Add route to change patron's password (public)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22061 Martin Renvoize changed: What|Removed |Added Target Milestone|19.05 |--- Jonathan Druart changed: What|Removed |Added Blocks||25045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25045 [Bug 25045] REST API public route accessible if OpacPublic is off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 --- Comment #62 from Jonathan Druart --- (In reply to Jonathan Druart from comment #60) > Use of union could be a solution, but I don't think it could be implemented > easily, see bug 25043 for an example using DBIx::Class::ResultSet > > https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations If that does not work (or hard to implement), did you try to create a view? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25043] Use of union in Koha::Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25043 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #4) > But I am afraid we won't be able to use object.search All the pieces used in objects.search can be used, manually, on the controller method, so that's not a problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25043] Use of union in Koha::Objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25043 --- Comment #4 from Jonathan Druart --- But I am afraid we won't be able to use object.search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
