[Koha-bugs] [Bug 10269] Add a way to utilise a specific replyto email address for some notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Martin Renvoize changed: What|Removed |Added Text to go in the|This patchset adds the |This patchset adds the release notes|foundations needed to make |foundations needed to make |use of a reply-to address |use of a reply-to address |if passed when calling |if passed when calling |EnqueeLetter. |EnqueueLetter. || ||Further ||bugs will be used to add ||interfaces for adding such ||addresses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10269] Add a way to utilise a specific replyto email address for some notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Martin Renvoize changed: What|Removed |Added Text to go in the||This patchset adds the release notes||foundations needed to make ||use of a reply-to address ||if passed when calling ||EnqueeLetter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10269] Add a way to utilise a specific replyto email address for some notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Martin Renvoize changed: What|Removed |Added Summary|Add a way to define a |Add a way to utilise a |specific replyto email |specific replyto email |address for some notice |address for some notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- This is something that we've implemented locally for clients. I have other priorities at the moment, but I could look at upstreaming that code when I have a chance. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | CC||alexbuck...@catalyst.net.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Customize destination for OPAC self registration vertification email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25090 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] Customize destination for OPAC self registration vertification email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23538 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25090] New: Customize destination for OPAC self registration vertification email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090 Bug ID: 25090 Summary: Customize destination for OPAC self registration vertification email Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuck...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently libraries can use the PatronSelfRegistrationVerifyByEmail syspref to restrict self registering users from being able to access the OPAC after registering until they have acknowledged the email sent by Koha. If that syspref is disabled then self registering users will be able to login to the OPAC straight after filling in the self registration form. It would be good if libraries had further control over what users can login to the OPAC. Why? Many online resources (e.g. 3rd party database access) require only OPAC login to be able to be accessed. Special libraries may want to limit OPAC login access only to those users within their organisation as these online resources do charge the libraries on a usage basis. How can further control over what users trying to self register can access the OPAC be achieved whilst keeping the default, current Koha behaviour? 1. Ensure 'PatronSelfRegistrationVerifyByEmail' syspref is set to 'Require' 2. Add a new syspref 'PatronSelfRegistrationVerificationRecipient'(This dropdown syspref would allow libraries to choose): * email address of branch * KohaAdminEmailAddress * Requesting user If email address of branch or KohaAdminEmailAddress then the verification email generated after the user has submitted the registration form will go to the library. The email will contain some details entered by the patron, so the library can confirm if they are happy that the registering user is able to login to the OPAC then they will acknowledge the email (click on the opac-registration-verify.pl link) which will actually make the patron account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17464] Order deny, allow / Deny from all was deprecated in Apache 2.4 and is now a hard error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23488] Line wrapping doesn't always respect word order in Patron card creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 Status|Pushed to stable|Pushed to oldstable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23753] Add missing humanMsg library to pages using background job JavaScript
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24747] Library Transfer Limit page incorrectly describes its behavior
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24747 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 Status|Pushed to stable|Pushed to oldstable --- Comment #9 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #39 from Katrin Fischer --- Hi Lari, I really like the idea of circulation types - I think I actually suggested something like that when on-site was introduced at the time, because I know other systems use this concept. I have 2 comments for discussion/consideration. 1) "This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "OS" (on-site) and "C" (normal checkout)." I feel this is not necessary and would vote for hard-coding the circulation types and their descriptions. It will make it translatable and keep people from 'messing' with it. Unless you plan to really allow people to add a lot more of those? I'd also use more speakign abbreviations, maybe 'ONSITE' and CHECKOUT - no need to make things more cryptical than necessary. It would help doing reports etc. too. 2) On the mailing list it was suggested to have 'normal' 'on-site' and 'all'. I am not sure about the 'all'. I feel it might be complicating things more than necessary. If all was to preserve current behaviour, I don't think that would work as on-site currently is 1 day by default, independent of the normal loan period. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24733] Cannot search for duplicate orders using 'Basket created by' field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24733 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21879] Code cleaning in printinvoice.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24705] Holds placed via SIP will be given first priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24705 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- test do not clean apply in 19.05.x, tried the rebased test for 19.11, also don't work. No backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Text to go in the||This patch adds the ability release notes||to set a custom framework ||as the default to be ||applied when importing ||records or editing records ||with no framework mapped. Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 --- Comment #18 from Aleisha Amohia --- Created attachment 102603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102603=edit Bug 23111: (follow-up) Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Attachment #91791|0 |1 is obsolete|| Attachment #92184|0 |1 is obsolete|| --- Comment #17 from Aleisha Amohia --- Created attachment 102602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102602=edit Bug 23111: Set a custom framework as the default when importing records or editing records with no framework mapped. To test: 1) Go to edit a biblio with no framework mapped 2) Click the Settings dropdown, notice that the 'Default' framework is selected 3) Go to the Cataloguing home page. Click the main 'New from Z39.50/SRU' button and notice the selected framework in the URL is 'Default' 4) Go to Tools -> Stage MARC records for import. Stage a bibliographic record. Go to Staged MARC management for your newly imported batch. Notice that the frameworks dropdown (above the 'Import this batch into the catalog' button) has the 'Default' framework selected 5) Apply this patch and update the database. Apply the schema changes patch or update your schema files. Restart memcached and plack. 6) Go to Administration -> MARC bibliographic frameworks. Edit one of your custom frameworks. Set it as default by checking the checkbox and saving. 7) Edit a different custom framework and set this one as the default now. Confirm that the previous framework has been unset (the checkbox is no longer checked) as the default. 8) Repeat steps 1-4 and confirm that the selected framework is your newly set default framework, instead of the provided 'Default' framework. 9) Go back to Administration -> MARC bibliographic frameworks. Edit your default framework and unset it as default (uncheck the checkbox). Save. 10) Repeat steps 1-4 and confirm that the selected framework is the provided 'Default' framework again, so we can have no default custom framework if chosen. 11) Confirm the tests pass: t/db_dependent/Koha/BiblioFrameworks.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25088] The tool to bulk edit due dates proxy error times out with large data sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25088 --- Comment #1 from Katrin Fischer --- By linking to the initial bug this will be a little easier to spot! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24846] Add a tool to bulk edit due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846 Katrin Fischer changed: What|Removed |Added Blocks||25088 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25088 [Bug 25088] The tool to bulk edit due dates proxy error times out with large data sets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25088] The tool to bulk edit due dates proxy error times out with large data sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25088 Katrin Fischer changed: What|Removed |Added Version|19.05 |master Depends on||24846 CC||katrin.fisc...@bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24846 [Bug 24846] Add a tool to bulk edit due dates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25087] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25087 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Veno|SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24103] Add option to dump built search query to templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #16 from Lucas Gass --- not backporting enhancement to 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Blocks||25089 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 [Bug 25089] Add checkout_type to circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 Lari Taskula changed: What|Removed |Added Depends on||25089 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 [Bug 25089] Add checkout_type to circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Depends on||25037 Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi |ity.org | Blocks||24101 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 [Bug 25037] Add support for multiple checkout types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] New: Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Bug ID: 25089 Summary: Add checkout_type to circulation rules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lari.task...@hypernova.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com This is a follow-up to Bug 25037. In that Bug we enabled issues to contain data on its checkout type. In this Bug we will add support for defining circulation rules for those types. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24732] Make DumpTemplateVars more readable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24732 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 --- Comment #15 from Katrin Fischer --- Jonathan, why do you think the latest patch will break for the no_html flag? The latest patch looks good to me on first glance and the OPAC file is not used for a title tag as far as I can tell and is much simpler. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 --- Comment #14 from Katrin Fischer --- (In reply to Lucas Gass from comment #13) > Not sure how I should proceed here, should I go back to something more > simple like in the first patch I provided where I simply added > classes to the include? The first version doesn't work - it will definitely create problems with the no_html flag. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #18 from Katrin Fischer --- (In reply to Kyle M Hall from comment #17) > Created attachment 102577 [details] [review] > Bug 24380: Add syspref CalculateFinesOnBackdate Thank you Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Text to go in the||This new features lets release notes||patrons report problems ||using the OPAC. || ||The ||feature is enabled using ||the new OPACReportProblem ||system preference. This: ||- ||adds a link to each page of ||the OPAC to a form so that ||patrons can report ||problems, and ||- adds a ||problem reporting section ||to the staff interface for ||managing problem reports ||(Koha administration > ||Additional parameters > ||OPAC problem reports). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25088] New: The tool to bulk edit due dates proxy error times out with large data sets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25088 Bug ID: 25088 Summary: The tool to bulk edit due dates proxy error times out with large data sets Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: marga...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The libraries we support are really appreciative of the new Bug 24846 - "Add a tool to bulk edit due dates", but if a library has 20,000, 30,000, 50,000 issues that they need to use the tool on the user will encounter a proxy error and the page will time out. We've tested this problem trying to even load the second page that shows you a preview of the record to be updated if pushing forward the due date by a number of days is the chosen option. We've gotten the page to load with a hard due date chosen; it squeaked under the apache time out at 8 minutes 46 seconds to load. It would be great if the tool had a better way of handling large batches of data to be updated, because the current errors aren't inspiring much confidence. Libraries can break their batches into smaller groups, to a point, but we're finding that it's still easier for them to have the support team do a bulk due date update for them. I know other tools encounter this issue with large datasets, but at this point we don't have an approximate number of issues that is it 'safe' to update at one time. And if they've got 10,000 items at a branch, all checked out by the same category, they might not be able to make that grouping small enough to get the tool to work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23601] Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 David Nind changed: What|Removed |Added Text to go in the||This fixes an issue in release notes||Firefox where ||middle-clicking or ||CTRL-clicking a title in ||the results screen of the ||staff client opens two new ||tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #22 from David Nind --- Things move too fast 8-) - patch no longer applies: root@5e1d1195a414:koha(bz15986)$ git bz apply 15986 Bug 15986 - Add a script for sending hold waiting reminder notices 99919 - Bug 15986: Add a script for sending hold waiting reminder notices Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15986: Add a script for sending hold waiting reminder notices Using index info to reconstruct a base tree... M C4/Letters.pm M Koha/Patron.pm M t/db_dependent/Koha/Patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patrons.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patrons.t Auto-merging Koha/Patron.pm CONFLICT (content): Merge conflict in Koha/Patron.pm Auto-merging C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15986: Add a script for sending hold waiting reminder notices Also noticed that there is a holds subfolder in misc/cronjobs - should the script go in that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24980] Date formatting from JS - use timezone only with dates with offset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980 --- Comment #24 from Agustín Moyano --- (In reply to Jonathan Druart from comment #23) > (In reply to Jonathan Druart from comment #22) > > (In reply to Agustín Moyano from comment #20) > > > (In reply to Jonathan Druart from comment #18) > > > > How do I test the timezone handling in real life? ie. without using the > > > > console. > > > > > > Actually there is no place (even bug 20936) that brings timestamp or > > > datetime. If you want to try to see if it works with koha's configured > > > timezone you should use the console without the tz option, then format a > > > datetime with timezone. Later change koha's timezone, restart plack and > > > reload the page and try to format the same datetime, it should change > > > according to the new timestamp > > > > > > If it works in the console, it should work on real life (it's the same > > > function) > > > > Do we need it then? > > Changing status as we are waiting for an answer. Yes, I think we do.. I'm sure at some point there's going to be a datatable that brings a datetime or timestamp from the database. If you'd like to test without console, you can locally modify the table in bug 20936 and display the timestamp column, that it's a timestamp as it's name suggests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25087] New: Veno
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25087 Bug ID: 25087 Summary: Veno Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kunsas...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 102601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102601=edit Veno_Ryan Veno Ryan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25086] OPAC Self Registration - Field 'changed_fields' doesn't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25086] OPAC Self Registration - Field 'changed_fields' doesn't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #1 from Agustín Moyano --- Created attachment 102600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102600=edit Bug 25086: set changed_fields column if not defined This patch sets changed_fields column to '' if not defined To test: 1. Do not apply this patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and restart_all 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23579] error during web install: 'changed_fields' can't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 Agustín Moyano changed: What|Removed |Added Blocks||25086 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 [Bug 25086] OPAC Self Registration - Field 'changed_fields' doesn't have a default value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25086] New: OPAC Self Registration - Field 'changed_fields' doesn't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Bug ID: 25086 Summary: OPAC Self Registration - Field 'changed_fields' doesn't have a default value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: agustinmoy...@theke.io Reporter: agustinmoy...@theke.io QA Contact: testo...@bugs.koha-community.org CC: jonathan.dru...@bugs.koha-community.org, tomasco...@gmail.com Depends on: 23579 In OPAC's self registration, if PatronSelfRegistrationVerifyByEmail is set to Require, OPAC dies with the following error DBD::mysql::st execute failed: Field 'changed_fields' doesn't have a default value [for Statement "INSERT INTO `borrower_modifications` ( `branchcode`, `categorycode`, `date_renewed`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `firstname`, `gdpr_proc_consent`, `password`, `surname`, `timestamp`, `verification_token`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with ParamValues: 0="CPL", 1="S", 2=undef, 3=undef, 4=undef, 5=undef, 6=undef, 7="prue...@algo.com", 8="algo", 9=undef, 10='Ehttps://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 [Bug 23579] error during web install: 'changed_fields' can't have a default value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19192] Update default DUEDGST and PREDUEDGST notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19192 David Roberts changed: What|Removed |Added Status|NEW |ASSIGNED CC||david.roberts@ptfs-europe.c ||om Assignee|koha-b...@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25085] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25085 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 David Nind changed: What|Removed |Added Text to go in the||This Elasticsearch release notes||enhancement strips the ||initial characters from ||search fields in accordance ||with nonfiling character ||indicators. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 David Nind changed: What|Removed |Added Text to go in the||This enhancement changes release notes||the form for the serials ||renewal period for a ||subscription into a drop ||down list - this is ||consistent with the create ||subscription form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102591|0 |1 is obsolete|| --- Comment #37 from Lari Taskula --- Created attachment 102598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102598=edit Bug 25037: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102592|0 |1 is obsolete|| --- Comment #38 from Lari Taskula --- Created attachment 102599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102599=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102589|0 |1 is obsolete|| --- Comment #35 from Lari Taskula --- Created attachment 102596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102596=edit Bug 25037: Schema changes Sponsred-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102590|0 |1 is obsolete|| --- Comment #36 from Lari Taskula --- Created attachment 102597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102597=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102588|0 |1 is obsolete|| --- Comment #34 from Lari Taskula --- Created attachment 102595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102595=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "OS" Else checkout_type becomes "C" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102587|0 |1 is obsolete|| --- Comment #33 from Lari Taskula --- Created attachment 102594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102594=edit Bug 25037: Add authorised values to sample data Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102586|0 |1 is obsolete|| --- Comment #32 from Lari Taskula --- Created attachment 102593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102593=edit Bug 25037: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "OS" (on-site) and "C" (normal checkout). To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102424|0 |1 is obsolete|| --- Comment #30 from Lari Taskula --- Created attachment 102591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102591=edit Bug 25037: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102423|0 |1 is obsolete|| --- Comment #31 from Lari Taskula --- Created attachment 102592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102592=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102421|0 |1 is obsolete|| --- Comment #27 from Lari Taskula --- Created attachment 102588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102588=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "OS" Else checkout_type becomes "C" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102422|0 |1 is obsolete|| --- Comment #28 from Lari Taskula --- Created attachment 102589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102589=edit Bug 25037: Schema changes Sponsred-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102419|0 |1 is obsolete|| --- Comment #25 from Lari Taskula --- Created attachment 102586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102586=edit Bug 25037: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "OS" (on-site) and "C" (normal checkout). To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #29 from Lari Taskula --- Created attachment 102590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102590=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25037] Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What|Removed |Added Attachment #102420|0 |1 is obsolete|| --- Comment #26 from Lari Taskula --- Created attachment 102587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102587=edit Bug 25037: Add authorised values to sample data Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25085] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25085 Owen Leonard changed: What|Removed |Added Attachment #102583|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25085] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25085 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Mr.fuck SC |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966
Kyle M Hall changed:
What|Removed |Added
Attachment #102584|0 |1
is obsolete||
--- Comment #8 from Kyle M Hall ---
Created attachment 102585
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102585=edit
Bug 24966: [Alt] Fix calls to maybe_add where method call does not return a
value
For reasons unknown to me, a call like:
--
$resp .= maybe_add( FID_CALL_NUMBER, $item->call_number, $server );
--
will not work as expected if the item has no callnumber.
One would expect the parameters to the subroutine to be: 'CY', under, and a
SIPServer object.
What is actually received is: 'CY', and a SIPServer object.
We ingest the parameters like so:
--
sub maybe_add {
my ($fid, $value, $server) = @_;
--
So, what happens is $value is populated with the server object!
This can cause bad output like this:
--
OUTPUT MSG: '101YNN20200324063701AOBPL|AB32503201584185|AQBPL|AJCat
/|CK001|CRn|CSJ 636.8
CLU|CYC4::SIP::SIPServer=HASH(0x1ea0e58)|DAC4::SIP::SIPServer=HASH(0x1ea0e58)|'
--
Test Plan:
1) On master, perform a checkin of an item not on hold using the sip cli tester
2) Note some fields contain something like 'C4::SIP::SIPServer=HASH(0x1ea0e58)'
3) Apply this patch
4) Restart the SIP server
5) Perform the SIP checkin again
6) Those fields from step 2 should be gone!
Signed-off-by: Kyle M Hall
Signed-off-by: Barbara Johnson
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21826] Automatic authority record generation improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 --- Comment #49 from Phil Ringnalda --- *** Bug 21224 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21224] Relator term in 100$e should not be used with Authority linker script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21224 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Phil Ringnalda --- Yes, it was fixed by bug 21826 *** This bug has been marked as a duplicate of bug 21826 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966
Kyle M Hall changed:
What|Removed |Added
Attachment #101632|0 |1
is obsolete||
--- Comment #7 from Kyle M Hall ---
Created attachment 102584
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102584=edit
Bug 24966: [Alt] Fix calls to maybe_add where method call does not return a
value
For reasons unknown to me, a call like:
--
$resp .= maybe_add( FID_CALL_NUMBER, $item->call_number, $server );
--
will not work as expected if the item has no callnumber.
One would expect the parameters to the subroutine to be: 'CY', under, and a
SIPServer object.
What is actually received is: 'CY', and a SIPServer object.
We ingest the parameters like so:
--
sub maybe_add {
my ($fid, $value, $server) = @_;
--
So, what happens is $value is populated with the server object!
This can cause bad output like this:
--
OUTPUT MSG: '101YNN20200324063701AOBPL|AB32503201584185|AQBPL|AJCat
/|CK001|CRn|CSJ 636.8
CLU|CYC4::SIP::SIPServer=HASH(0x1ea0e58)|DAC4::SIP::SIPServer=HASH(0x1ea0e58)|'
--
Test Plan:
1) On master, perform a checkin of an item not on hold using the sip cli tester
2) Note some fields contain something like 'C4::SIP::SIPServer=HASH(0x1ea0e58)'
3) Apply this patch
4) Restart the SIP server
5) Perform the SIP checkin again
6) Those fields from step 2 should be gone!
Signed-off-by: Kyle M Hall
Signed-off-by: Barbara Johnson
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25085] New: Mr.fuck SC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25085 Bug ID: 25085 Summary: Mr.fuck SC Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: biskuttige...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 102583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102583=edit By : Mr.fuck SC Website kamu serang ada di genggaman tangan saya Jika kamu ingib website kamu kembali carilah saya temui saya saya tunggu kedatangan kamu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966 --- Comment #6 from Kyle M Hall --- (In reply to Jonathan Druart from comment #5) > I am not sure I understand, how would you do that? > > My fair is that the real bug is hidden somewhere else, and fixing it here > will keep it hidden. I agree, bug for the life of me I cannot even understand how this is possible. I think we might be even getting into perl internals finding the bug! I will write a version of the alternate I proposed. It's a more 'correct' fix anyway imo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21648] Patron Merge needs more flexibility and transparency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25084] New: Adding a tip to First Issue Publication Date in Serials Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25084 Bug ID: 25084 Summary: Adding a tip to First Issue Publication Date in Serials Module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com When creating a serial prediction pattern, one mandatory field is called "First issue publication date"- this title could be misleading to users of Koha thinking that date needs to be the first-ever publication date versus the first publication date of the serial that is being added to Koha. The manual describes this field as: In ‘First issue publication date’ you want to enter the date of the issue you have in your hand, the date from which the prediction pattern will start. It would be nice to add a helper tool here with maybe a question mark (like Koha does in the Messaging Preferences by Digest) to let the user know what is really needed here. Another option would be to change the language for this field completely. Either way would be good! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work with default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Andrew Fuerste-Henry --- The second patch (Do not remove the restrictions from AddReturn) does not apply for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24605] Series link from 830 is not uri encoded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24605 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 Status|Pushed to stable|Pushed to oldstable --- Comment #11 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809 --- Comment #17 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24809] OAI PMH can fail on fetching deleted records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24809 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #16 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Kyle M Hall changed: What|Removed |Added Attachment #102426|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 102581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102581=edit Bug 22778: Suggestions with no "suggester" can cause errors If one tries to modify a suggestion that has no suggester you will get the following error: Can't call method "lang" on an undefined value at /usr/share/koha/lib/C4/Suggestions.pm line 506 Koha assumes that every suggestion has a borrowernumber in suggestedby Test Plan: 1) Create a suggestion with an unpopulated suggestedby 2) Attempt to modify that suggestion 3) Note the error 4) Apply this patch 5) Restart all teh things 6) Attempt to modify that suggestion 7) No error! Signed-off-by: David Roberts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 --- Comment #11 from Kyle M Hall --- Created attachment 102582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102582=edit Bug 22778: Add unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #25 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #43 from Jonathan Druart --- Created attachment 102580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102580=edit Bug 24027: Add POD about the new parameter in Koha::Item->store Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #42 from Jonathan Druart --- Created attachment 102579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102579=edit Bug 24027: (QA follow-up) Fix POD warning Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027
Jonathan Druart changed:
What|Removed |Added
Attachment #102567|0 |1
is obsolete||
Attachment #102568|0 |1
is obsolete||
Attachment #102572|0 |1
is obsolete||
--- Comment #41 from Jonathan Druart
---
Created attachment 102578
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102578=edit
Bug 24027: Call ModZebra once after all items added/deleted in a batch
Issue description:
- call to ModZebra was unconditional inside 'store' method for Koha::Item,
so it was after each item added, or deleted.
- ModZebra called with param biblionumber, so it is the same parameter
across calls for each items with same biblionumber, especially when we
adding/removing in a batch.
- with ElasticSearch enabled this makes even more significant load
and it is also progressively grows when more items already in DB
Solution:
- to add extra parameter 'skip_modzebra_update' and propagate it down to
'store' method call to prevent call of ModZebra,
- but to call ModZebra once after the whole batch loop in the upper layer
Test plan / how to replicate:
- make sure that you have in the admin settings "SearchEngine" set to
"Elasticsearch" and your ES is configured and working
( /cgi-bin/koha/admin/preferences.pl?op=search=SearchEngine )
- select one of biblioitems without items
( /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXX )
- press button "add multiple copies of this item",
- enter 200 items, start measuring time and submit the page/form...
On my test machine when adding 200 items 3 times in a row (so 600 in
total, but to show that time grows with every next batch gradually):
WHEN ElasticSearch DISABLED (only Zebra queue):
- 9s, 12s, 13s
WHEN ElasticSearch ENABLED:
- 1.3m, 3.2m, 4.8m
WITH PATCH WHEN ElasticSearch ENABLED:
- 10s, 13s, 15s
Same slowness (because also same call to ModZebra) happens when you try
to delete all items ("op=delallitems"). And same fix.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
Amended commit message: the fix does not include the batch item
deletion.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027
--- Comment #44 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #40)
> From the commit message:
> """
> Same slowness (because also same call to ModZebra) happens when you try to
> delete items in a batch or delete all items ("op=delallitems"). And same fix.
> """
>
> What do you mean by "delete items in a batch"?
Confirmed by Andrew (pm), I amended the commit message.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24682] Clarify UsageStatsGeolocation syspref description and behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24682 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119 --- Comment #6 from Heather --- I agree completely with Katrin--there should be no square brackets. MARC21 documentation is in accordance with cataloging rules that reserve square brackets to indicate information supplied in the cataloging record that is NOT from the prescribed source of information, e.g., a title supplied by the cataloger, information from publisher's descriptions, etc. So having square brackets around the 246 $i information is confusing and nonsensical--the information in the 246 $i is a label describing the data from the item in the 246 $a, so the data in 246 $i should never be enclosed in square brackets. Likewise, there should be no square brackets in the display of the 730 $i. Could the square brackets please be removed? I'm so sorry that I didn't think to request that the square brackets in the display be removed in the first place--I realize now that it would have saved time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #16 from Kyle M Hall --- Created attachment 102576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102576=edit Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Attachment #102574|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall --- Created attachment 102575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102575=edit Bug 24380 - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Attachment #99537|0 |1 is obsolete|| Attachment #99538|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 102574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102574=edit Bug 24380 - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #17 from Kyle M Hall --- Created attachment 102577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102577=edit Bug 24380: Add syspref CalculateFinesOnBackdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem with multiple items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24711] Can't log in to OPAC after logout if OpacPublic disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24711 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in||19.05.10 CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24957] OpenLibrarySearch doesnt return result correctly on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24957 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #52 from Lucas Gass --- this is missing a dependency for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027
--- Comment #40 from Jonathan Druart
---
From the commit message:
"""
Same slowness (because also same call to ModZebra) happens when you try to
delete items in a batch or delete all items ("op=delallitems"). And same fix.
"""
What do you mean by "delete items in a batch"?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #102571|0 |1 is obsolete|| --- Comment #14 from Andrew Fuerste-Henry --- Created attachment 102573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102573=edit Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1= Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #39 from Jonathan Druart --- Created attachment 102572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102572=edit Bug 24027: Add POD about the new parameter in Koha::Item->store -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24710] patron-title.inc should have seperate span classes for firstname, othername, surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24710 --- Comment #13 from Lucas Gass --- Not sure how I should proceed here, should I go back to something more simple like in the first patch I provided where I simply added classes to the include? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
