[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #8 from Julian Maurice --- (In reply to Kyle M Hall from comment #6) > (In reply to Julian Maurice from comment #5) > > Hi Kyle, > > > > Can you comment on why you chose to name the file META.yml ? Is it related > > to https://metacpan.org/pod/CPAN::Meta::Spec ? > > You are essentially correct. The file name is inspired by CPAN's > META.yml/META.json file. Won't that be a problem if people want to publish their plugins on CPAN ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #27 from Victor Grousset/tuxayo --- Tried to test this as related to bug 19821 What does this mean?↓ > # Edit $KOHA_CONF, add a database_test entry identical to database (then > restart_all): -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19821] Run tests on a separate database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #50 from Victor Grousset/tuxayo --- Thanks for the explanations. The DB is not being created, here is what I did (on koha_testing_docker) Patches applied reset_all > root@13b368ace1d6:/# mysql -u root --password=password [...] > MariaDB [(none)]> GRANT ALL PRIVILEGES ON koha_test.* TO koha_kohadev; > kohadev-koha@76c874795df6:/kohadevbox/koha$ prove t/db_dependent/Holds.t > MariaDB [(none)]> show databases; No koha_test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193
David Nind changed:
What|Removed |Added
Attachment #103318|0 |1
is obsolete||
--- Comment #5 from David Nind ---
Created attachment 103322
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103322=edit
Bug 25193: Add AllowRenewalIfOtherItemsAvailableLocation syspref
This syspref works in conjunction with AllowRenewalIfOtherItemsAvailable
syspref. It has two options - allow renewal if other items are available
to fill holds at any branch, or only at the hold's pickup branch.
To test:
1) Apply patch, update database, restart services
2) Go to Administration -> system preferences. Search for
AllowRenewalIfOtherItemsAvailable. Notice the two sysprefs exist in the
same row. By default they should be set to "Don't allow" and "at any
branch".
3) Set up a biblio with two items. Have both items held at Branch A.
4) Check out Item A to Borrower A.
5) Place a biblio-level reserve for Borrower B with pickup branch at
Branch A.
6) View Borrower A's checkouts. Confirm you cannot renew Item A ('On
hold' message).
7) Edit Item B, set the current location to Branch B. The items should
now have different locations.
8) Enable the AllowRenewalIfOtherItemsAvailable syspref. Leave the
AllowRenewalIfOtherItemsAvailableLocation syspref set to "at any branch".
9) View Borrower A's checkouts. Confirm you CAN renew Item A (because
Item B can fill Borrower B's reserve).
10) Set the AllowRenewalIfOtherItemsAvailableLocation syspref to "at the
hold's pickup branch". Keep AllowRenewalIfOtherItemsAvailable syspref
enabled.
11) View Borrower A's checkouts. Confirm you CANNOT renew Item A
(because Item B cannot fill Borrower B's reserve due to being at a
different branch).
12) Edit Item B, set the current location to Branch A. The items should
have the same location now.
13) View Borrower A's checkouts. Confirm you CAN renew Item A.
Sponsored-by: Chartered Accountants Australia & New Zealand
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 --- Comment #7 from Victor Grousset/tuxayo --- Thanks for the clarifications. > 4) Apply patch > 5) Repeat 1, verify installer files are updated > see last modification time Actually I missed 4) and the files are still updated. Does it mean that the test plan is missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193 Aleisha Amohia changed: What|Removed |Added Summary|Add option for |Add syspref to control |AllowRenewalIfOtherItemsAva |location for use of |ilable at reserve patron's |AllowRenewalIfOtherItemsAva |branch |ilable Text to go in the||This patch adds a new release notes||system preference ||AllowRenewalIfOtherItemsAva ||ilableLocation which works ||in conjunction with the ||AllowRenewalIfOtherItemsAva ||ilable ||system preference. ||It has two options - allow ||renewal if other items are ||available to fill holds at ||any branch, or only at the ||hold's pickup branch. This ||way, if items cannot be ||shared between branches, ||the ||AllowRenewalIfOtherItemsAva ||ilable system preference ||will consider this when ||deciding if renewal is ||allowed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5614] Add sections/headings to Patron system preferences tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5614 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- (In reply to Katrin Fischer from comment #4) > A really old bug - worked out a first suggestion. Comments welcome! This is so much easier to browse and read, rather than such a long list of system preferences! I'm sure others may have some suggestions and refinements for the system preferences left under general, but I think it is a great improvement as is. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5614] Add sections/headings to Patron system preferences tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5614 David Nind changed: What|Removed |Added Attachment #102798|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 103321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103321=edit Bug 5614: Organize 'patron' system preferences Until now, there was only "General" and "Privacy". This patch breaks the "General" prefs up into multiple sections. To test: - Go to Administration > Patrons - Verify the current state of things - Apply patch - Reload patch - Verify headings make sense and groups make sense as well Signed-off-by: David Nind -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5614] Add sections/headings to Patron system preferences tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5614 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25223] Ordered.pl can have poor performance on large databases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25223 David Nind changed: What|Removed |Added Attachment #103312|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 103320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103320=edit Bug 25223: Make join of aqbasket and aqorders explicit This is simply a SQL change that makes things a bit easier to read and also prevents too much data being returned in a large system To test: 1 - Have some orders in your system in the ordered status 2 - Click the 'Ordered' amount for your budget from Acquisitions home 3 - Note the view of orders, possibly screen shot 4 - Apply patch 5 - Restart all the things 6 - Reload the ordered page 7 - Confirm nothing has changed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25223] Ordered.pl can have poor performance on large databases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25223 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 --- Comment #6 from Bernardo Gonzalez Kriegel --- Hi Victor, sorry if the test plan was not clear (In reply to Victor Grousset/tuxayo from comment #4) > > 1) Update your preferred language > > You mean with this? > koha-translate --update XX No, that command updates installed translations. The meaning was to do: cd misc/translator; ./translate update XX > > > 2) Check missing *installer*po files > > What does this mean? It means that there are no XX-*-installer.po after an update of an existing language- Updates process does not create missing files, only updates existing ones. The only way to 'create' the files is using 'create' option of translate command, but that fails if some of the files are present. The purpose of this patch is to add those files > > > cd /misc/translation > > You mean misc/translator/ right? Yes, of course, my bad. > > > 5) Repeat 1, verify installer files are updated >see last modification time > > Does it means checking the files there? > /koha-tmpl/intranet-tmpl/prog/XX/modules/installer No, just run "./translate update XX" and verify that all XX-*.po are updated > > Sorry for the basic questions. No problem, thank you :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22335] Comment on column suggestions.STATUS is not complete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22335 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #2 from David Nind --- The patch no longer applies (if that is required): Applying: Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 22335: Fix comment on suggestions.STATUS in kohastructure.sql Happy to sign-off otherwise. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20501] Unhighlight in search results when the search terms contain the same word twice removes the word
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20501] Unhighlight in search results when the search terms contain the same word twice removes the word
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103210|0 |1 is obsolete|| --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 103319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103319=edit Bug 20501: Don't cut strings when unhighlighting in intranet search results When you click Unhighlight on the search results of a search in the staff client when the search terms contain the same word twice, like "ma ma", the highlighted words disappear, and don't reappear if you click Highlight. This patch makes the same change to the intranet copy of jquery.highlight-3.js that bug 5844 made to the OPAC copy. Test plan: 1) Without this patch, search in the intranet for ma ma and verify you have at least two matching records. 2) Notice that the Ma in Material type: Book is highlighted. 3) Click Unhighlight, and notice that it has become terial type: Book 4) Apply this patch, repeat the search with a shift+reload to reload the .js 5) Click Unhighlight, and verify that Material type: Book remains Material Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24098] Standardize Fines/Fees & Charges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24098 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Hi Katrin. A couple of other places text may need changing, or can be a separate bug: - Most of the messages changed also have 'fine balance' after, as part of the same message. Perhaps change to 'Checkouts are BLOCKED because their balance is OVER THE LIMIT.' - Where there are are no charges due on the accounting page, the message under the make a payment tab says '..has no outstanding fines.'. Change to '..has no outstanding charges.'. (Accounting > Make a payment tab) David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393
--- Comment #17 from Victor Grousset/tuxayo ---
Conflict part:
(if that helps: with a third section thanks to git option merge.conflictStyle
set to diff3)
<<< HEAD
if ($add eq 'save and pay') {
print $input->redirect(
"/cgi-bin/koha/members/pay.pl?borrowernumber=$borrowernumber"
);
} else {
print $input->redirect(
"/cgi-bin/koha/members/boraccount.pl?borrowernumber=$borrowernumber"
);
}
exit;
}
}
else {
||| constructed merge base
print $input->redirect(
"/cgi-bin/koha/members/boraccount.pl?borrowernumber=$borrowernumber"
);
exit;
}
}
else {
===
if ( C4::Context->preference('AccountAutoReconcile') ) {
$patron->account->reconcile_balance;
}
>>> Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||vic...@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo --- Doesn't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice Using index info to reconstruct a base tree... M members/maninvoice.pl Falling back to patching base and 3-way merge... Auto-merging members/maninvoice.pl CONFLICT (content): Merge conflict in members/maninvoice.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22393-Remove-last-remaining-use-of-C4Accountsm-8xPypt.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 --- Comment #5 from Victor Grousset/tuxayo --- Question about koha-testing-docker: (and maybe KohaDevBox) does anyone know from which user to run the translation commands? like koha-translate --install XX from the user kohadev-koha it lacks a permission mkdir /usr/share/koha/misc/translator/po/eo: Permission denied at /usr/share/koha/misc/translator/LangInstaller.pm line 708. from root, it doesn't find /usr/share/koha/misc/bin/clear_cache.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- > 3) Browse to plugins home, note that nothing appears to have changed Except my screen turned orange :o (first time installing a plugin, and kitchen sink, that was a surprise ^^") More seriously: Is that actually expected to have the background changed to orange when the plugin is disabled? > 5) Reload the plugins home page, note your changes to META.yml appear in the > plugins table! I don't see changes. Is the correct file to edit this one? /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink/META.yml I'm using koha-testing-docker, I even ran restart_all what could be missing? (git log from the container shows that HEAD is bug 24631) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo --- > 1) Update your preferred language You mean with this? koha-translate --update XX > 2) Check missing *installer*po files What does this mean? > cd /misc/translation You mean misc/translator/ right? > 5) Repeat 1, verify installer files are updated see last modification time Does it means checking the files there? /koha-tmpl/intranet-tmpl/prog/XX/modules/installer Sorry for the basic questions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #51 from Victor Grousset/tuxayo --- Does anyone manages to import a staged record? The progress bar stays to 0% Even with plack stopped (in case it blocks something), the behviour is the same. ## Logs (plack stopped) ### confirm staging [Mon Apr 20 23:39:54 2020] [debug] POST "/cgi-bin/koha/tools/stage-marc-import.pl" [Mon Apr 20 23:39:54 2020] [debug] Routing to a callback Subroutine staging_progress_callback redefined at /kohadevbox/koha/tools/stage-marc-import.pl line 234. Subroutine matching_progress_callback redefined at /kohadevbox/koha/tools/stage-marc-import.pl line 243. Use of uninitialized value in string eq at /kohadevbox/koha/bin/../Koha/App/Plugin/CGIBinKoha.pm line 88. Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 397, <__ANONIO__> chunk 2. [Mon Apr 20 23:39:54 2020] [debug] 200 OK (0.098054s, 10.198/s) seek() on closed filehandle _GEN_4 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 34. [Mon Apr 20 23:39:54 2020] [error] Can't seek stdout handle: Bad file descriptor at /kohadevbox/koha/bin/../Koha/App/Plugin/CGIBinKoha.pm line 56. [Mon Apr 20 23:39:54 2020] [debug] Template "exception.development.html.ep" not found [Mon Apr 20 23:39:54 2020] [debug] Template "exception.html.ep" not found [Mon Apr 20 23:39:54 2020] [debug] Rendering template "mojo/debug.html.ep" [Mon Apr 20 23:39:54 2020] [debug] Rendering template "mojo/menubar.html.ep" [Mon Apr 20 23:39:54 2020] [debug] Your secret passphrase needs to be changed [Mon Apr 20 23:39:54 2020] [debug] 500 Internal Server Error (0.258607s, 3.867/s) [Mon Apr 20 23:39:55 2020] [debug] GET "/cgi-bin/koha/tools/background-job-progress.pl" [Mon Apr 20 23:39:55 2020] [debug] Routing to a callback Use of uninitialized value in string eq at /kohadevbox/koha/bin/../Koha/App/Plugin/CGIBinKoha.pm line 88. [Mon Apr 20 23:39:55 2020] [debug] 200 OK (0.028605s, 34.959/s) [Mon Apr 20 23:39:55 2020] [debug] POST "/cgi-bin/koha/tools/stage-marc-import.pl" [Mon Apr 20 23:39:55 2020] [debug] Routing to a callback Subroutine staging_progress_callback redefined at /kohadevbox/koha/tools/stage-marc-import.pl line 234. Subroutine matching_progress_callback redefined at /kohadevbox/koha/tools/stage-marc-import.pl line 243. Use of uninitialized value in string eq at /kohadevbox/koha/bin/../Koha/App/Plugin/CGIBinKoha.pm line 88. [Mon Apr 20 23:39:55 2020] [debug] 200 OK (0.099609s, 10.039/s) ### confirm import [Mon Apr 20 23:40:53 2020] [debug] POST "/cgi-bin/koha/tools/manage-marc-import.pl" [Mon Apr 20 23:40:53 2020] [debug] Routing to a callback Subroutine redo_matching redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 140. Subroutine create_labelbatch_from_importbatch redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 184. Subroutine import_batches_list redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 204. Subroutine commit_batch redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 232. Subroutine revert_batch redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 271. Subroutine put_in_background redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 309. Subroutine progress_callback redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 344. Subroutine add_results_to_template redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 354. Subroutine add_saved_job_results_to_template redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 360. Subroutine import_records_list redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 368. Subroutine batch_info redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 390. Subroutine add_matcher_list redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 422. Subroutine add_page_numbers redefined at /kohadevbox/koha/tools/manage-marc-import.pl line 435. Use of uninitialized value in string eq at /kohadevbox/koha/bin/../Koha/App/Plugin/CGIBinKoha.pm line 88. DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1588. [Mon Apr 20 23:40:53 2020] [debug] 200 OK (0.094207s, 10.615/s) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch Remove Reserve Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What|Removed |Added CC||j...@flo.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12941] batch enable/disable courses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12941 Joe Sikowitz changed: What|Removed |Added CC||j...@flo.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25127] Fines with an amountoutstanding of 0 can be created due to maxFine but cannot be forgiven
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25127 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #19 from Bernardo Gonzalez Kriegel --- Hi, what is the test plan? patch 3 and 4 are exclusive, seems to me that 4 is preferred. On top of 25123 and patches 1, 2 and 4, the test pass. Is anything more to test? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add option for AllowRenewalIfOtherItemsAvailable at reserve patron's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193 --- Comment #4 from Aleisha Amohia --- Also: confirm tests pass t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add option for AllowRenewalIfOtherItemsAvailable at reserve patron's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add option for AllowRenewalIfOtherItemsAvailable at reserve patron's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add option for AllowRenewalIfOtherItemsAvailable at reserve patron's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193
--- Comment #3 from Aleisha Amohia ---
Created attachment 103318
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103318=edit
Bug 25193: Add AllowRenewalIfOtherItemsAvailableLocation syspref
This syspref works in conjunction with AllowRenewalIfOtherItemsAvailable
syspref. It has two options - allow renewal if other items are available
to fill holds at any branch, or only at the hold's pickup branch.
To test:
1) Apply patch, update database, restart services
2) Go to Administration -> system preferences. Search for
AllowRenewalIfOtherItemsAvailable. Notice the two sysprefs exist in the
same row. By default they should be set to "Don't allow" and "at any
branch".
3) Set up a biblio with two items. Have both items held at Branch A.
4) Check out Item A to Borrower A.
5) Place a biblio-level reserve for Borrower B with pickup branch at
Branch A.
6) View Borrower A's checkouts. Confirm you cannot renew Item A ('On
hold' message).
7) Edit Item B, set the current location to Branch B. The items should
now have different locations.
8) Enable the AllowRenewalIfOtherItemsAvailable syspref. Leave the
AllowRenewalIfOtherItemsAvailableLocation syspref set to "at any branch".
9) View Borrower A's checkouts. Confirm you CAN renew Item A (because
Item B can fill Borrower B's reserve).
10) Set the AllowRenewalIfOtherItemsAvailableLocation syspref to "at the
hold's pickup branch". Keep AllowRenewalIfOtherItemsAvailable syspref
enabled.
11) View Borrower A's checkouts. Confirm you CANNOT renew Item A
(because Item B cannot fill Borrower B's reserve due to being at a
different branch).
12) Edit Item B, set the current location to Branch A. The items should
have the same location now.
13) View Borrower A's checkouts. Confirm you CAN renew Item A.
Sponsored-by: Chartered Accountants Australia & New Zealand
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25193] Add option for AllowRenewalIfOtherItemsAvailable at reserve patron's branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193 --- Comment #2 from Aleisha Amohia --- Please ignore all earlier comments, they are a mess! Patch and test plan coming that will explain this feature better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 --- Comment #25 from Phil Ringnalda --- I can reproduce Victor's results, but I don't believe they are this bug at all. Starting state is: A. authid 329, the genre Film adaptations, linked to 6 bibs but the $9329 is on a 710 for the Library of Congress Copyright Collection B. authid 35, the uniform title Colecç~ao "O Campo da palavra", linked to 9 bibs but the $935 is on a 650 for Perl C. any mislinked 1-bib will do, I used a topic Abuduction--Drama, with the one linked bib having the authid in subfield 9 of a 700 name-title field for Flaubert's Madame Bovary The problem comes right at the start, the C->B merge. Because C is under the limit, the merge processes it immediately while saving B to do later. But after the merge, B still says it only has 9 linked bibs, not 10 like it should after a live merge, and indeed the Madame Bovary bib field is untouched. Then after the run of the cronjob, we have 15 bibs linked to A: the 6 originals which still have their 710 for the LC falsely claiming to be linked to a Film adaptations authority, and the 9 that had a Perl subject, which now do not have a Perl subject and do have a Film adaptations genre. I think it's probably a bug that "in a live merge of a mislinked authority to another mislinked authority, neither the one being merged nor the one being retained have their linked bibs altered, but in a deferred merge the one being merged has its linked bibs altered, while again the one being retained does not," but luckily that's nothing to do with this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25224] Add "Large Print" from 008 position 23 to default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25224 Andrew Fuerste-Henry changed: What|Removed |Added CC||bwsdo...@gmail.com, ||j...@bywatersolutions.com, ||ke...@bywatersolutions.com, ||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25224] New: Add "Large Print" from 008 position 23 to default XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25224
Bug ID: 25224
Summary: Add "Large Print" from 008 position 23 to default XSLT
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs@lists.koha-community.org
Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
The defualt results and details XSLT stylesheets contain a smattering of
information from the 008, but don't show Large Print when 008 position 23
("Form of item") is set to d.
008/23 is used for Form of item in the Books options, which are used when
Leader/06 (Type of record) contains code a (Language material) or t (Manuscript
language material) and Leader/07 (Bibliographic level) contains code a
(Monographic component part), c (Collection), d (Subunit), or m (Monograph).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki changed: What|Removed |Added Attachment #103311|0 |1 is obsolete|| --- Comment #2 from Arthur Suzuki --- Created attachment 103317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103317=edit Bug 25222: Add ability to let plugins live in individual subdirectories From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to." This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! Signed-off-by: Arthur Suzuki -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 --- Comment #24 from Victor Grousset/tuxayo --- Thanks Marcel for clarifications. (In reply to Marcel de Rooy from comment #20) > (In reply to Victor Grousset/tuxayo from comment #17) > > > Verify that the linkcount to A is the former total of ABC. > > 6+9+1 != 15 record(s) > > Noo [...] > > 6+9+1= 16 If you got 15, then it could be that one of the records formerly > linked to B or C already contained a link to A too. [...] > > > - Given the above notes, was there a mistake in the execution of the test > > plan? > The only thing I am thinking of, is that you might have missed that one > record was already linked to A. Which would explain the difference between > 15 and 16. I forgot to write that I checked that there was no overlap between the linked biblios of ABC (in my case). Is it worth it to retry? With more coherent data or with the same data but doing another check to find why the total mismatches (I don't have a lead on that) Or is this patch enough tested and the test data issue isn't a big deal? (compared to other pending stuff) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103055|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 103316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103316=edit Bug 25166: Add "aria-hidden = true" to Font Awesome icons in the OPAC Font Awesome's accessibility guidelines (https://fontawesome.com/v4.7.0/accessibility/) suggest that we include 'aria-hidden="true"' in the icon markup. This prevents screen readers from trying to read the icon. This patch adds the attribute. To test apply the patch and browse the OPAC looking for any problems with icons: On search results, bibliographic details page, the cart, lists, etc. Check the source and verify that Font Awesome icons have the "aria-hidden" attribute. Signed-off-by: Bernardo Gonzalez Kriegel Attribute present, all looks good. The 'aria-label' attribute is not translatable, but it's another problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25166] Add "aria-hidden = true" to Font Awesome icons in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25166 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- About: bug 18974 bug 19182 bug 19183 bug 19184 bug 19189 > The tests need to be rewritten completely. What would be needed to be rewritten? The test business logic or the usage of the test stack? Is there an existing test that I could use as a model for the current good practices? Then I'll try to implement one of the above tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25211] Missing share icon on OPAC lists page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25211] Missing share icon on OPAC lists page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25211 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103280|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 103315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103315=edit Bug 25211: Add missing share icon to OPAC lists page This patch adds a Font Awesome icon to the "Share" links on the list of lists in the OPAC. To test, apply the patch and log in to the OPAC as a user who has one or more private lists. - Go to Lists -> Your lists - In the table of your lists, each list should have a "Share" link with an icon. Signed-off-by: Bernardo Gonzalez Kriegel Don't forget to enable OpacAllowSharingPrivateLists Works ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973 --- Comment #23 from Martin Renvoize --- Bug 3280 appears to have done the reply-to side of this already... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=6973 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=3280 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25183] cleanup-database.pl --del-exp-selfreg fully deletes borrowers - should go into deleted-borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25183 --- Comment #3 from Liz Rea --- That's fine by me, making it an option. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17232] When creating a new framework from an old one, several fields are not copies (important, link, default value, max length, is URL)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17232 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103207|0 |1 is obsolete|| --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 103314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103314=edit Bug 17232: Make sure all fields are copies when creating a new framework from another Some digging revealed that when you create a new framework and use an old framework as the base, some information would not be copied to the new framework as they were missing from the SQL command used here. - Tag: Important - Subfield: - Important - Default value - Max length - Is a URL - Link To test: - Pick one of the existing frameworks and change the fields listed above. Take note of what you changed. - Create a new framework - Go to "Marc structure" of the new framework - You are offered the option to copy an existing framework - Use your prepared framework - Verify the fields weren't copied - your config was lost - Apply patch - Create another new framework - Repeat the duplication and tests - Verify that now all fields have been copied correctly Signed-off-by: Bernardo Gonzalez Kriegel Good test plan, problem verified and fixed. Used ACQ fw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17232] When creating a new framework from an old one, several fields are not copies (important, link, default value, max length, is URL)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17232 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25118] Return claims has some translation issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25118 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103281|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 103313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103313=edit Bug 25118: Return claims has some translation issues This patch adds the right function calls to checkouts.js so that English strings can be picked up by the translator. The resolution message has been reformatted so that it can be clear without including "on" and "by" in the middle of the string. To test you should have a patron with at least one return claim. Open the checkout page for that patron and open the "Claims" tab. Test the process of editing, deleting, and resolving claims. TESTING TRANSLATABILITY - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the staff client: misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from checkouts.js for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:920 msgid "Double click to edit" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR Switch to the udpated translation and test the functionality under the "Claims" tab again to confirm that your translated strings appear. Note that "untranslatable string" failures reported by the QA script are false positives. Signed-off-by: Bernardo Gonzalez Kriegel Works ok, 7 new strings, after translation and install translated strings found on koha-tmpl/intranet-tmpl/prog/xx-YY/js/locale_data.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25118] Return claims has some translation issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25118 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25223] Ordered.pl can have poor performance on large databases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25223 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25223] Ordered.pl can have poor performance on large databases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25223 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25223] Ordered.pl can have poor performance on large databases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25223 --- Comment #1 from Nick Clemens --- Created attachment 103312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103312=edit Bug 25223: Make join of aqbasket and aqorders explicit This is simply a SQL change that makes things a bit easier to read and also prevents too much data being returned in a large system To test: 1 - Have some orders in your system in the ordered status 2 - Click the 'Ordered' amount for your budget from Acquisitions home 3 - Note the view of orders, possibly screen shot 4 - Apply patch 5 - Restart all the things 6 - Reload the ordered page 7 - Confirm nothing has changed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25223] New: Ordered.pl can have poor performance on large databases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25223 Bug ID: 25223 Summary: Ordered.pl can have poor performance on large databases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Ordered.pl has an implied join, this seems to sometimes cause issues on large databases -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17687] Rename column subscriptionhistory.recievedlist to receivedlist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17687 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #1 from Caroline Cyr La Rose --- This is still valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #1 from Kyle M Hall --- Created attachment 103311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103311=edit Bug 25222: Add ability to let plugins live in individual subdirectories From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to." This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25174 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25174] Plugins that fail to load should still display in the plugins table, but with an error indicator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25174 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25222 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] New: Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Bug ID: 25222 Summary: Add ability to let plugins live in individual subdirectories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to." This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25174] Plugins that fail to load should still display in the plugins table, but with an error indicator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25174 --- Comment #2 from Kyle M Hall --- (In reply to Tomás Cohen Arazi from comment #1) > I tried to implement this, but the fact it relies on a successful ->new > prevents us from succeeding. Yes, that's why I made it dependent on the metadata bug. Once we have that, we should be able to quickly know which plugins are installed, eval them, and know if they aren't loading. > We really need to put each plugin in its own > subdirectory (to identify them individually) and have a metadata file we can > refer to. That's a great idea! I'm going to file a bug for that and submit a patch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25221] Imported records are not checked for accuracy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25221 --- Comment #2 from Christopher Brannon --- (In reply to Martin Renvoize from comment #1) > I like the idea of a check for accuracy and clear reporting, but a hard > quarantine would need to be optional in my opinion. I think optional is a good idea. > I know of catalogues where they import hundreds, if not thousands of > records, for electronic holdings regularly and requiring a manual > intervention step for each record could prove detrimental. Also, how would > Union Catalogues work? I am unfamiliar with the term of Union Catalog. If this refers to a shared catalog with many libraries, such as we do with our consortium, then I suppose if we went with an optional setting, the setting could be for specific libraries, all libraries, or none. Quarantine for import could also have an option for an authorized override, but if an override is in place, what's the point of having a quarantine at all? Perhaps the quarantine could have options. A more sophisticated quarantine system could allow you to quarantine certain types of issues, and only flag others. Quarantine the issues that can cause issues or errors, and flag the record for any others that have not been reviewed? Then have an alert on the home page of bibs that need to be reviewed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25221] Imported records are not checked for accuracy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25221 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Martin Renvoize --- I like the idea of a check for accuracy and clear reporting, but a hard quarantine would need to be optional in my opinion. I know of catalogues where they import hundreds, if not thousands of records, for electronic holdings regularly and requiring a manual intervention step for each record could prove detrimental. Also, how would Union Catalogues work? It would certainly need to act like a filter rather than a hard requirement for all. I do like the idea though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #6 from Kyle M Hall --- (In reply to Julian Maurice from comment #5) > Hi Kyle, > > Can you comment on why you chose to name the file META.yml ? Is it related > to https://metacpan.org/pod/CPAN::Meta::Spec ? You are essentially correct. The file name is inspired by CPAN's META.yml/META.json file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 --- Comment #18 from Kyle M Hall --- Created attachment 103310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103310=edit Bug 25172: Add missing filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25220] maxoutstanding syspref should be disabled by a null value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 --- Comment #1 from Andrew Fuerste-Henry --- To Test: 1) Set maxoutstanding to blank 2) give yourself $0.50 in fines 3) go to opac, confirm you're blocked from placing holds 4) set maxoutstanding=1 5) confirm you are no longer blocked from placing holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #17 from Kyle M Hall --- I love everything about this patch set, but I'm getting one unit test failure: root@6b3a1a3db7b8:koha(bug25172-qa)$ prove t/Logger.t t/Logger.t .. # Failed test 'Logger did not init correctly without permission' # at t/Logger.t line 52. # Looks like you failed 1 test of 6. t/Logger.t .. 1/1 # Failed test 'Test01 -- Simple tests for Koha::Logger' # at t/Logger.t line 63. # Looks like you failed 1 test of 1. t/Logger.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report --- t/Logger.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.36 cusr 0.06 csys = 0.44 CPU) Result: FAIL Jonathan, does this test fail for you as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25221] New: Imported records are not checked for accuracy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25221 Bug ID: 25221 Summary: Imported records are not checked for accuracy Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When you create a new bib record, Koha checks if certain fields are filled out. When you import a bib record, Koha does not check if that record has those fields filled out. I would suggest that when a record is imported, it either needs to be taken immediately into editing so that Koha can catch issues, or it needs to be put into a quarantine state, and unusable anywhere in the system until it is edited and saved. When importing a bib for an order, since you are dealing with a single record, I could see how going straight into editing after importing could work. However, if you are importing bibs through an batch import tool, if the process isn't already checking for issues or missing fields, these items should be set in quarantine and require the cataloger to edit the record to remove it from quarantine. This process would address problems elsewhere in Koha where incomplete or compromised records cause an error in Koha or in a process that can't complete due to a faulty record. I'm not a cataloger, but this seems like a reasonable workflow for bringing outside records into your own system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25123] MaxFines does not count the current updating fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25123 --- Comment #15 from Katrin Fischer --- (In reply to Martin Renvoize from comment #14) > (In reply to Nick Clemens from comment #10) > > (In reply to Jonathan Druart from comment #9) > > > What about the FIXME a couple of lines above? > > > > That behaviour doesn't change, and is still a valid question, how did we get > > two fines on one issue and how should we resolve? But these patches fix the > > other case so I don't think we need to address here > I know at least Katrin has her own fines code so I didn't remove it 'just in > case', but would like to clean it up at some point. Guilty, but it's not a super bad hack... only a little bit bad. We just do the fine calculation differently, but use the standard methods for triggering and placing the fine (might have to make that work again with all the changes to accounts in last versions? :) I will see when it comes to it) > how did we get two fines on one issue and how should we resolve? Do you mean 2 accrueing fines? Or just fines? In some older DB we didn't do the FU > F change cleanly, so bad data could be an issue. Generally: Checkout Gets overdue + fines Renew Gets overdue + fines again Renew... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #30 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #29)
> Comment on attachment 102926 [details] [review]
> Bug 15986: Add a script for sending hold waiting reminder notices
>
> Review of attachment 102926 [details] [review]:
> -
>
> ::: Koha/Patron.pm
> @@ +1695,4 @@
> > };
> > }
> >
> > +=head3 send_notice
>
> Hmm, feels like this should be 'queue_notice' rather than 'send_notice'..
> that paves the way for a later 'send_notice' which sends immediately vs
> waiting in the queue.
We already have a way to send directly without waiting through the queue - it's
used by the self registration and password reset emails: bug 21390
+my $num_letters_attempted = C4::Letters::SendQueuedMessages( {
+letter_code => 'OPAC_REG_VERIFY'
+} );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 --- Comment #16 from Kyle M Hall --- (In reply to Martin Renvoize from comment #15) > This all appears to work as expected for me.. and offers a genuine > improvement.. I didn't like that we just carried on regardless either.. I'm > sure Kyle has also done similar changes in a SIP bug at some point? The SIP logging bug uses Koha::Logger so its' behavior should be fixed by this as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14369] Only show 'Create labels' link on staged records import when status is 'Imported'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369 Katrin Fischer changed: What|Removed |Added Attachment #103293|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 103309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103309=edit Bug 14369: Only show 'Create labels' link on staged records import when status is imported The label creator won't be able to add a batch for items, if they are not imported into the database (missing itemnumber). This patch hides the link, when the status is not imported, to avoid the error situation. To test: - Export a record with items from your Koha installation - Delete items and record from Koha - Stage the record with the items - the "Create labels" link should be showing - Try to create the labels - note error - Apply patch - Retry - the link should no longer show - Import the records - the link should show now - Create labels again - a new batch should have been created - Verify the link on the batch # leads to the batch in the labels module Bonus: Moves the message from the .pl file to the template to make it translatable. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25219] Include note in fines-related system preferences which can be disabled by leaving them blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25219 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||25220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 [Bug 25220] maxoutstanding syspref should be disabled by a null value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25220] New: maxoutstanding syspref should be disabled by a null value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Bug ID: 25220 Summary: maxoutstanding syspref should be disabled by a null value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Several fines-related system preferences (OPACFineNoRenewals, noissuescharge, etc) can be disabled by leaving them blank. But maxoutstanding treats a blank as a zero, blocking OPAC holds for *any* fine balance. I'd like this to change to match the functionality of the other sysprefs. If nothing else, we should add some language to say a blank is treated as a zero. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25220] maxoutstanding syspref should be disabled by a null value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||25219 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25219 [Bug 25219] Include note in fines-related system preferences which can be disabled by leaving them blank -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25219] Include note in fines-related system preferences which can be disabled by leaving them blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25219 --- Comment #1 from Andrew Fuerste-Henry --- Amending that, MaxOutstanding is *not* disabled by leaving the syspref blank. In that case, a blank is treated as a zero, meaning any fines at all will be enough to block holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25219] Include note in fines-related system preferences which can be disabled by leaving them blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25219 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25219] New: Include note in fines-related system preferences which can be disabled by leaving them blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25219 Bug ID: 25219 Summary: Include note in fines-related system preferences which can be disabled by leaving them blank Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The syspref OPACFineNoRenewals includes the note "(leave blank to disable)." The sysprefs maxoutstanding, noissuescharge, NoIssuesChargeGuarantees, and MaxFine can all be disabled by leaving them blank, as well. It'd be helpful to include that same "(leave blank to disable)" message to make it clear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25187] Instructor search only display first ten results which may not be enough for common names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25187 robbi...@middlesex.mass.edu changed: What|Removed |Added CC||robbi...@middlesex.mass.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25189] Make AutoCreateAuthorities less of a footgun with LinkerModule: Default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 --- Comment #2 from Phil Ringnalda --- Yeah, I was too focused on my half million duplicates that actually are duplicates resulting from this bug, and forgot that "duplicates" which only look like duplicates to the linker exist since it doesn't map indicators and possibly subfield 2 to 008/11 and 040$f in the authority to tell apart "650 _ 1 ‡aFantasy" a kids work of fantasy fiction and "650 _ 0 ‡aFantasy" an adult work about daydreaming. So forcing FirstMatch, which can only work correctly in certain limited circumstances, wouldn't be right. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 --- Comment #15 from Martin Renvoize --- This all appears to work as expected for me.. and offers a genuine improvement.. I didn't like that we just carried on regardless either.. I'm sure Kyle has also done similar changes in a SIP bug at some point? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24913] Self registration: Ask users to enter email address twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24913 Katrin Fischer changed: What|Removed |Added Attachment #103273|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 103308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103308=edit Bug 24913: Add PatronSelfRegistrationConfirmEmail syspref To test: 1) update database, restart memcached/plack 2) Go to Administration -> System preferences -> OPAC tab. Enable the new PatronSelfRegistrationConfirmEmail system preference. Enable other required self registration sysprefs. 3) Go to the OPAC home page. (You may need to log out). Click the 'Register' link so you are redirected to the member entry form. 4) Notice the 'Confirm primary email' field after the 'primary email' field. Put 'a...@a.com' in primary email, and 'b...@b.com' in the confirm field. Scroll to the end of the form and Submit. 5) Confirm the form is not successfully submitted, and an error message is shown to indicate the email addresses do not match. 6) Confirm you cannot cut, copy or paste in either the primary email or confirm primary email fields. Confirm the right click menu doesn't work in these fields. 7) Disable javascript in your browser. 8) Repeat steps 3 and 4. 9) Confirm there is an error message to indicate the email addresses do not match. 10) Re-enable javascript. Fill in the form correctly with matching email addresses and confirm it successfully submits. 11) Disable the PatronSelfRegistrationConfirmEmail syspref. 12) Attempt to register an account on the OPAC again. Confirm the 'confirm email address' field is gone and form works as expected. 13) Re-enable the PatronSelfRegistrationConfirmEmail syspref. 14) Log in to the OPAC and go to your personal details 15) Edit the primary email field 16) Confirm you are able to submit your changes (you should not see an error about emails not matching). Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: holly Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24913] Self registration: Ask users to enter email address twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24913 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Owen Leonard changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Owen Leonard --- (In reply to Owen Leonard from comment #10) > Certainly possible, but it requires that we add each session-only > localStorage item to a function which runs at logout. ...which we'll have to do anyway for cookies which need to be cleared on logout (instead of when the browser is closed). So never mind, don't listen to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25218] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25218 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Test|SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18498] Staff can place next available holds when rule is set to forced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18498 --- Comment #6 from Christopher Brannon --- (In reply to Katrin Fischer from comment #5) > I think there are different use cases at play here. I'd like it better if we > could keep staff and OPAC separate in defining the behaviour. > > An example would be 'only allow record level holds' - if staff needs a > specific item because it's the oldest, damaged or the one with the extra > material, they can place item level holds from staff side for internal use. Katrin, your example is confusing me. This would not block item level holds on staff side. It would block the record level (next available) holds on the staff side. It would mean they would ALWAYS have to pick a specific item. Right now they can do both. Can you present a case for why staff would ever need to bypass a block to a next available item when they would always have the choice to pick a specific item? And, if they did have a scenario where they would need to bypass and do a next available hold, why a warning would be better than overriding? > It's not true there is no visible indication in staff, for example, for OPAC > item level holds = Forced, Koha shows a note for each item on the place hold > screen: > > Item level hold forced from OPAC > > Maybe if this stood out a bit more? Obviously this isn't obvious enough. Regardless, staff have a habit of blowing through such messages when they are working quickly and not taking the time to read messages. At the very least, it needs to be an override. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 Martin Renvoize changed: What|Removed |Added Attachment #103302|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 103306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103306=edit Bug 25172: Adjust tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 Martin Renvoize changed: What|Removed |Added Attachment #103303|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 103307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103307=edit Bug 25172: Identify and display possible problems on the about page Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 Martin Renvoize changed: What|Removed |Added Attachment #103301|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 103305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103305=edit Bug 25172: Remove _recheck_logfile I don't understand how that could be useful. We do not want to test if the logfile is writable every time we log something! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 Martin Renvoize changed: What|Removed |Added Attachment #103300|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 103304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103304=edit Bug 25172: Make Koha::Logger explode if init went wrong We do not want to fail silently for the logger. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25172] Koha::Logger init is failing silently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 --- Comment #10 from Martin Renvoize --- Patches apply now, taking a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25123] MaxFines does not count the current updating fine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25123 --- Comment #14 from Martin Renvoize --- (In reply to Nick Clemens from comment #10) > (In reply to Jonathan Druart from comment #9) > > What about the FIXME a couple of lines above? > > That behaviour doesn't change, and is still a valid question, how did we get > two fines on one issue and how should we resolve? But these patches fix the > other case so I don't think we need to address here Agreed.. when I last dug into this I believe I reached the conclusion that in automated fines code you cannot reach such a state.. but if people are using custom fines or adding things manually we can end up in all sorts of a mess... I know at least Katrin has her own fines code so I didn't remove it 'just in case', but would like to clean it up at some point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
