[Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks staff_client/opac fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325 --- Comment #1 from Frédéric Demians --- Created attachment 104004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104004=edit Bug 25325 ElasticSearch mapping export lacks staff_client/opac fields Add to export_elasticsearch_mappings.pl two missing fields: staff_client and opac. Test plan: 1. Run export_elasticsearch_mappings.pl script. Write the result in mappings.yaml (the one defined in koha-conf.xml). 2. In Admin > Search engine configuration, click on Reset Mappings 3. Confirm that in Search fields tab, the Searchable column hasn't changed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks staff_client/opac fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325 Frédéric Demians changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||23204 Severity|enhancement |minor Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 [Bug 23204] Script for exporting Elasticsearch mappings to YAML -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 Frédéric Demians changed: What|Removed |Added Blocks||25325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325 [Bug 25325] ElasticSearch mapping export lacks staff_client/opac fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25325] New: ElasticSearch mapping export lacks staff_client/opac fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325 Bug ID: 25325 Summary: ElasticSearch mapping export lacks staff_client/opac fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: frede...@tamil.fr export_elasticsearch_mappings.pl doesn't export staff_client and opac fields. Its means that when reimporting (Reset mapping in Search engine configuration) indexing rules, the searchability (staff/opac) of fields will be lost. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #40 from Frédéric Demians --- Note : Since bug 20589, two fields have been added to 'search_field' table: staff_client and opac. Those fields are lacking in mappings.yaml. Its means that if this script is used to export and import (Reset mapping in Search engine configuration) indexing rules, the searchability (staff/opac) of fields will be lost. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24632] Plugins should support simple signing for security/varifiability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 --- Comment #5 from David Cook --- I'm thinking something along these lines: https://ubuntu.com/tutorials/tutorial-how-to-verify-ubuntu Verify a metadata file or checksum file using a provider's public key (using one of the modules I've suggested). Then verify the plugin using a checksum in the metadata file or in the checksum file. I'm thinking signing the checksum file is probably the better way to go. And if we create a system preference to manage this, we can have it turned off by default (for backwards compatibility), but then more cautious parties (like vendors) can enable it. Essentially you'd need to verify a plugin during the installation process. -- I have many competing projects during my quarantine time, but I'm going to try and look at this tonight. It really shouldn't be that difficult, and I think it would be a huge benefit for the plugin system and Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19558] Link 130 uniform title authority record to 240 tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19558 verolencinas changed: What|Removed |Added CC||verolenci...@yahoo.com.ar --- Comment #2 from verolencinas --- Uniform titles in MARC21 field 240 are used if there is a primary access point present. For examples laws use the following combination: 110 $a Canada 240 $a Laws, etc. 245 $a Or in literary works: 100 $a Cervantes Saavedra, Miguel de 240 $a Don Quijote de la Mancha 245 $a The corresponding authority records should not link to the 240 field directly, but to the 110/240 or 110/240 combination. For the first example the authority record should be: 110 $a Canada $t Laws, etc. and for the second example: 100 $a Cervantes Saavedra, Miguel de $t Don Quijote de la Mancha This means Koha should be able to use one authority field to link to two fields in the bibliographic record. Koha should not use 130 Uniform title authority records to link to 240 fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #42 from Victor Grousset/tuxayo --- It works :) @Kyle: Is there another way to test than modifying the archive? (so the test plan can be fixed) It's easy on Linux with file-roller, the GUI for archives that most people have. Also, bad news, without the patch I can install and uninstall a plugin. But with the patch, I can install but not uninstall. > Can't locate .pm in @INC >92: require $plugin_path; # Require the plugin to have it's path > listed in INC So $plugin_path is undef? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #41 from Victor Grousset/tuxayo --- > So you're storing metadata in PLUGIN.yml *and* in plugin_data depending on > the scenario? That seems suboptimal. I just edited the two sources of data that for debugging. > and then treat the database as the source of truth. Oh wait that's also in the DB?! Good, nothing supernatural then ^^" Confirmed! select * from plugin_data \G > For new plugins, you use PLUGIN.yml at install/upgrade time (after which it > becomes irrelevant) Step 4 of test plan show that it's meant to be read every time. So from what I understand, code is working now (before the DB caching was not) but it's the test plan that is wrong. I'll edit PLUGIN.yml and ../KitchenSink.pm in the kpz to confirm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #40 from David Cook --- I'm a bit confused. So you're storing metadata in PLUGIN.yml *and* in plugin_data depending on the scenario? That seems suboptimal. Why not just use the plugin_data? You could read PLUGIN.yml into plugin_data at install/upgrade time, and then treat the database as the source of truth. I suppose plugin_data is really more of a key-value data store, so maybe it would be better to have a `plugins` table that stores 1 row per plugin for standard plugin metadata. Then you use that for all plugin management purposes. Doing it that way you would have 1 source of truth and you wouldn't have any arbitrary code execution. For new plugins, you use PLUGIN.yml at install/upgrade time (after which it becomes irrelevant). For old plugins, you use the insecure method of extracting metadata from the plugin code. Then you eventually deprecate the insecure method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25324] New: After editing an authority record with CatalogModuleRelink on, relinking appears to happen before the edited record is saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25324 Bug ID: 25324 Summary: After editing an authority record with CatalogModuleRelink on, relinking appears to happen before the edited record is saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: p...@chetcolibrary.org QA Contact: testo...@bugs.koha-community.org The actual behavior these contrived steps imitate is using AutoCreateAuthorities and CatalogModuleRelink, using LinkerModule: First Match so that in case of duplicate authorities the linker will choose the first, oldest, lowest authid, and then buying one book by an author before he dies, cataloged with Name, Birthyear-, and then buying another after he dies, cataloged with Name, Birthyear-Deathyear. 1. Set AutoCreateAuthorities, BiblioAddsAuthorities, CatalogModuleRelink, and LinkerModule: First Match 2. Create a personal name authority record with 100 1# $aBrzezinski, Zbigniew,$d1928- (imitating one you imported before 2017) 3. In any existing bib record, add a 700 linked to that authority record, just so it has a linked bib 3. Cataloging, new from Z39.50, search for Brzezinski, Zbigniew as author, import and save any record with the 100 field having his $d as 1928-2017. 4. Since your report of newly created authority records shows Brzezinski, Zbigniew, 1928-2017 when you know you already owned something he wrote, go to Authorities and search for Brzezinski. You need to update your previously imported record (well, the fake of one you created), so Edit the one without a 2017, Replace record via Z39.50, find the 1928-2017 record and import and save it. 5. Search again for Brzezinski. Expected results: Because you created the one that was originally 1928- first, before the one autocreated as 1928-2017 from your imported bib record, and you set First Match as your LinkerModule, you should expect that when you edit the first record in a way that causes the two records to become duplicates, that relinking would link both bib records to the first match. Actual results: Both bib records are linked to the second match, the autocreated one, rather than to the original, looking very much like the bib record without -2017 was updated and both bib records were relinked before the authority record you turned into a match actually was a match. As a result, rather than just being able to delete a now-unused autocreated record, you have to merge it to your newly edited record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #39 from Victor Grousset/tuxayo --- - change PLUGIN.yml and ../KitchenSink.pm in different ways - checkout to b50d891c099d0f21f2528c5a6d5bbb586cf1612e (master at that time) - apply the old patch with git am - restart_all - changes from PLUGIN.yml are visible :D - checkout to current master - apply this bug - restart_all - the original version of PLUGIN.yml is visible ?!?!?!?!?!?! Even though PLUGIN.yml and ../KitchenSink.pm are changed I still **again** the original version. This is very confusing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #23 from Tomás Cohen Arazi --- @RM: there you have a fix. I still think we should revamp the plugins system. The difficulty to properly write clean tests for this is evidence some changes are required in our architecture. Anyway, I love our plugins :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 104003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104003=edit Bug 25131: Make sure plugin data is fresh Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #38 from Victor Grousset/tuxayo --- For some reason I'm not getting any change. Whether from PLUGIN.yml or KitchenSink.pm On a fresh koha-testing-docker after restart_all and flush_memcached The previous version of the patch (when I signed it off) works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #103901|0 |1 is obsolete|| --- Comment #371 from Aleisha Amohia --- Created attachment 104002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104002=edit Bug 19532: Recalls objects and tests Getter and setter methods and other object methods for Koha Recalls, plus tests for these -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #370 from Aleisha Amohia --- Created attachment 104001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104001=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #103899|0 |1 is obsolete|| --- Comment #368 from Aleisha Amohia --- Created attachment 103999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103999=edit Bug 19532: Database and installer stuff - recalls table - circulation rules: recalls allowed (total), recalls per record (count), on shelf recalls allowed, recall due date interval (day), recall overdue fine, recall shelf time/pickup period (day) - sysprefs: useRecalls, RecallsMaxPickUpDelay, RecallsLog - email notices: RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM, RECALL_REQUESTER_DET - user permission: recalls, manage_recalls - Recall and CancelRecall reasons for branch transfers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #103900|0 |1 is obsolete|| --- Comment #369 from Aleisha Amohia --- Created attachment 104000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104000=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Tomás Cohen Arazi --- @RM, the follow-up fixes the failing tests in master. It might be relevant to document the behaviour change, whlst I think it was just a bad construction of the test in this case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 103998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103998=edit Bug 25303: (QA follow-up) Fix test construction The test called ->delete on the resultset directly, which is not the same when we already called ->next and the Koha::Hold->delete won't be called as there's no ->next hold. I took the oportunity to wrap the subtest in its own transaction and build its own data to avoid interference between tests... Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25314] Make OPAC facets collapse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 --- Comment #5 from Lucas Gass --- Owen, Would this be a system preference where libraries could define which facets should be expanded by default? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #2 from David Roberts --- (In reply to Andrew Fuerste-Henry from comment #1) > It looks like it doesn't default to "father" specifically. It defaults to > whatever the first value in the syspref borrowerRelationship is. In the > default data, that's "father|mother." When I change it to "|father|mother," > so the first possible value is nothing, then it saves with no relationship. That makes sense - I didn't notice that. However, on my system this is exactly as delivered from the install, so I think that most people will probably find that father is first. Either way, I think it is still incorrect behaviour. Perhaps a sensible workaround might be to make the field required, so that you can't leave it blank? I can't immediately think of a scenario where you wouldn't want to specify what the relationship is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24718] Introduce hour-based holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Aleisha Amohia changed: What|Removed |Added Blocks|20453 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 [Bug 20453] Send notification when hold is cancelled by librarian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff Text to go in the||This patch adds a new release notes||notice, HOLD_MANUAL_CANCEL, ||that can be sent to a ||borrower when a library ||cancels their hold request. ||The sending of this notice ||can be configured using ||messaging preferences. Depends on|24718 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 [Bug 24718] Introduce hour-based holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25314] Make OPAC facets collapse
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25314 Lucas Gass changed: What|Removed |Added Attachment #103958|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 103997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103997=edit Bug 25314: Make OPAC facets collapse TO TEST: 1. Apply patch 2. Regenerate CSS (yarn build --view opac) 3. DO a search and look at the facets. They should be collapsed. 4. Try mousing over a facet heading and click, that list should appear. 5. Try clicking the heading again to make th facet disappear. 6. Play around with different limiters and make sure eveything works. 7. Check aria labels look correct and you can tab through facets without a keyboard. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Attachment #102957|0 |1 is obsolete|| --- Comment #14 from Aleisha Amohia --- Created attachment 103995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103995=edit Bug 20453: Send notice when cancelling a hold from intranet To test: 1) Apply patch 2) Place a reserve for Borrower A 3) Cancel the reserve from reserve/request.pl 4) Go to Borrower A's account page and look at Notices tab 5) Confirm the HOLD_MANUAL_CANCEL notice is pending 6) Place a reserve for Borrower A again 7) Go to Circulation -> Holds to pull 8) Cancel the hold 9) Repeat steps 4 and 5 10) Place a reserve for Borrower A again 11) Go to Borrower A's account page and look at the Holds table (under Check out tab or Details tab) 12) Cancel hold using 'Cancel marked holds' button 13) Repeat steps 4 and 5 Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Attachment #102958|0 |1 is obsolete|| --- Comment #15 from Aleisha Amohia --- Created attachment 103996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103996=edit Bug 20453: Manage sending of HOLD_MANUAL_CANCEL notice with patron messaging preferences To test: 1) Apply this patch and run database updates 2) Confirm the 'Hold manually cancelled' option shows on the patron messaging preferences table on both the staff client and the OPAC. It should be unchecked (NOT enabled). 3) Follow the test plan from the second patch "Send notice when cancelling a hold from intranet" 4) Confirm that after completing the test plan, Borrower A has not been sent any notices (Check Notices tab) 5) Check the 'Hold manually cancelled' option in the patron messaging preferences (enable). 6) Go through the previous test plan again. 7) Refresh the Notices tab each time you cancel a hold. Confirm a new notice is pending with each refresh. Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Aleisha Amohia changed: What|Removed |Added Attachment #102956|0 |1 is obsolete|| --- Comment #13 from Aleisha Amohia --- Created attachment 103994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103994=edit Bug 20453: Adding notice to be sent when cancelling holds Sponsored-by: Waikato Institute of Technology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #11 from Agustín Moyano --- Created attachment 103993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103993=edit Bug 25260: Adapt all the things This patch adapts many pm and test files to work with unified holds table. To test: 1. Remove all previous holds in reserves and old_reserves tables. 2. Create 6 holds. Cancel 2 of them, fulfill one, set one in waiting and another in transit. CHECK => "select reserve_id, found from reserves" query in mysql should return 3 rows, where in found column should find 'W', 'T' and another with null values. => "select reserve_id, found from old_reserves" query in mysql should return 3 rows, where in found column you should find 2 with 'C', and one with 'F' values. 3. in mysql change reserve_id to the value of a hold in reserve table. 4. apply patches 5. updatedatabase SUCCESS => you should get the following warning "There were 1 old reserves that could not be moved, please check '_old_reserves'" => "select id, status, completed from holds" query in mysql should return 5 rows. => The hold that had null value in found column, now should have 'placed' status and 0 in completed. => The one that had 'W' in found column, now should have 'waiting' status and 0 in completed. => The one that had 'T' in found column, now should have 'in_transit' status and 0 in completed. => The one that had 'F' in found column, now should have 'fulfilled' status and 1 in completed. => The unmodified cancelled hold, now should have 'cancelled' status and 1 in completed. => "select * from _old_reserves" should give you one row with the modified hold. 6. in staff interface create, cancel, modify priorities, etc and everything should work exactly as before. # Run every test that has reserve and hold word wihtin # check that you are in main koha directory # check you have correctly setted KOHA_INTRANET_URL and KOHA_OPAC_URL environment variables # check plack is up and running.. tests will use selenium # prepare yourself a mug of coffe/te or take a nap.. this will take a while 7. prove $(grep -ilr -e reserve -e hold t|grep "\.t$") # finally 8. Sign off Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #10 from Agustín Moyano --- Created attachment 103992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103992=edit Bug 25260: Schema updates [DO NOT PUSH] Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #9 from Agustín Moyano --- Created attachment 103991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103991=edit Bug 25260: Atomic update Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Agustín Moyano changed: What|Removed |Added Attachment #103984|0 |1 is obsolete|| Attachment #103985|0 |1 is obsolete|| Attachment #103986|0 |1 is obsolete|| Attachment #103987|0 |1 is obsolete|| Attachment #103988|0 |1 is obsolete|| --- Comment #7 from Agustín Moyano --- Created attachment 103989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103989=edit Bug 25260: Add a 'holds' table Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #8 from Agustín Moyano --- Created attachment 103990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103990=edit Bug 25260: Adapt Koha::Hold(s) Sponsored-by: ByWater Solutions Sponsored-by: Theke Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- It looks like it doesn't default to "father" specifically. It defaults to whatever the first value in the syspref borrowerRelationship is. In the default data, that's "father|mother." When I change it to "|father|mother," so the first possible value is nothing, then it saves with no relationship. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Large patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #3 from Agustín Moyano --- Created attachment 103985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103985=edit Bug 25260: Adapt Koha::Hold(s) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #6 from Agustín Moyano --- Created attachment 103988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103988=edit Bug 25260: Adapt all the things This patch adapts many pm and test files to work with unified holds table. To test: 1. Remove all previous holds in reserves and old_reserves tables. 2. Create 6 holds. Cancel 2 of them, fulfill one, set one in waiting and another in transit. CHECK => "select reserve_id, found from reserves" query in mysql should return 3 rows, where in found column should find 'W', 'T' and another with null values. => "select reserve_id, found from old_reserves" query in mysql should return 3 rows, where in found column you should find 2 with 'C', and one with 'F' values. 3. in mysql change reserve_id to the value of a hold in reserve table. 4. apply patches 5. updatedatabase SUCCESS => you should get the following warning "There were 1 old reserves that could not be moved, please check '_old_reserves'" => "select id, status, completed from holds" query in mysql should return 5 rows. => The hold that had null value in found column, now should have 'placed' status and 0 in completed. => The one that had 'W' in found column, now should have 'waiting' status and 0 in completed. => The one that had 'T' in found column, now should have 'in_transit' status and 0 in completed. => The one that had 'F' in found column, now should have 'fulfilled' status and 1 in completed. => The unmodified cancelled hold, now should have 'cancelled' status and 1 in completed. => "select * from _old_reserves" should give you one row with the modified hold. 6. in staff interface create, cancel, modify priorities, etc and everything should work exactly as before. # Run every test that has reserve and hold word wihtin # check that you are in main koha directory # check you have correctly setted KOHA_INTRANET_URL and KOHA_OPAC_URL environment variables # check plack is up and running.. tests will use selenium # prepare yourself a mug of coffe/te or take a nap.. this will take a while 7. prove $(grep -ilr -e reserve -e hold t|grep "\.t$") -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #5 from Agustín Moyano --- Created attachment 103987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103987=edit Bug 25260: Schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #4 from Agustín Moyano --- Created attachment 103986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103986=edit Bug 25260: Atomic update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #2 from Agustín Moyano --- Created attachment 103984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103984=edit Bug 25260: Add a 'holds' table Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24604] Add 'Pay' button under Transactions tab in patron accounting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24604 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #6 from Joy Nelson --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20754] Db revision to remove double accepted list shares
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #8 from Joy Nelson --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00,19.11.06 released in|| CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #10 from Joy Nelson --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25188] Circulation notes only displays on checkouts tab, but not on details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 David Roberts changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21388] Add ability to hide Non-public Notes from Circulation Page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21388 David Roberts changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #203 from Joy Nelson --- feature not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #53 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12156] Merging staged records with no 942c with records created in acquisitions loses data from both
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12156 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25010] Fix typo in debit type description: rewewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #8 from Joy Nelson --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25323] New: Patrons can act as their own guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25323 Bug ID: 25323 Summary: Patrons can act as their own guarantor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When searching for a patron to act as a guarantor, if the guarantee's record is returned it can be selected, therefore becoming his/her's own guarantor. This makes no sense. To reproduce: 1) Create two users, a parent and a child both with the same surname (for example Parent Smith and Child Smith) 2) Edit the child record and under the Guarantor information, use the "Search to add" button to search for a guarantor. 3) Search for Smith. Both Parent Smith and Child Smith will be listed in the results. 4) Select Child Smith and save the user record. Child Smith is now the guarantor for Child Smith. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 --- Comment #12 from Katrin Fischer --- We are not an OCLC library, but our workflow is tied to 001 being the ID from our union catlalog, so in a similar situation. At the moment it seems not easy to match well on 035 or at least more error prone with a lot of different prefixes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] New: Adding a guarantor with no relationship defaults to father
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Bug ID: 25322 Summary: Adding a guarantor with no relationship defaults to father Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If you create a patron guarantor on members/memberentry.pl, but fail to enter a relationship, the relationship defaults to father. If no relationship is specified, then it ought not to be populated. To reproduce: 1) Create a new user or modify an existing one. 2) Under Guarantor Information, click on "Search to add" button 3) Perform your search, and select user to act as a guarantor 4) Do not use the dropdown menu to select a relationship. 5) Save the record The guarantor just added will be listed as the guarantees father. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10846] Add preference for naming OverDrive collection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10846 --- Comment #5 from Katrin Fischer --- (In reply to Owen Leonard from comment #4) > Perhaps this is a job for translatable authorized values (Bug 20307) or > database translations (Bug 24975)? Yes, I'd say so. We are just not quite there yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24303] Guarantor name and relationship should show in patron info panel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24303 David Roberts changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #103982|0 |1 is obsolete|| --- Comment #37 from Kyle M Hall --- Created attachment 103983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103983=edit Bug 24631: Plugin metadata should be outside the main class Currently, plugin metadata is stored within the main plugin class file but this means one has to load the class to read it. We should pull this data out into a manifest/metadata file in a standard format (JSON/YAML) to allow simpler external parsing. Test Plan: 1) Apply this patch 2) Install the latest Kitchen Sink plugin: https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.39/koha-plugin-kitchen-sink-v2.1.39.kpz 3) Browse to plugins home, note that nothing appears to have changed 4) Browse to your pluginsdir, find the PLUGIN.yml file for the Kitchen Sink plugin, edit some of the metadata 5) Reload the plugins home page, note your changes to PLUGIN.yml appear in the plugins table! Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23601] Middle clicking a title from search results creates two tabs or a new tab and a new window in Firefox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23601 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #14 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296
--- Comment #21 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #19)
> I am wondering if we should not force ->empty to be called only as a class
> method.
>
> my $patrons = Koha::Patrons->search;
> $patrons->empty; # Does not really make sense to me.
It would be:
my $patrons_rs = Koha::Patrons->new->empty;
but I get the point.
In the context of bug 25297, it really looks like an unnecessary extra line.
I still feel uncomfortable with the magic instantiation that happens in
->search (and now in ->empty).
my $rs = Koha::Things->new;
$rs->search( $condition_1 ) if $condition_1;
$rs->search( $condition_2 ) if $condition_2;
while ( my $res = $rs->next ) {...}
it is easier to understand (conceptually, for me) than
my $rs = Koha::Things->search( $condition_1 );
$rs->search( $condition_2 ) if $condition_2;
while ( my $res = $rs->next ) {...}
even if you save one line of code (or a ->new on the same line even)...
In this case I opted to not be rigid on my POV and implemented both behaviours,
but I think it is worth discussing in a broader place, if you think some
guideline needs to be generally adopted.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Attachment #103722|0 |1 is obsolete|| --- Comment #36 from Kyle M Hall --- Created attachment 103982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103982=edit Bug 24631: Plugin metadata should be outside the main class Currently, plugin metadata is stored within the main plugin class file but this means one has to load the class to read it. We should pull this data out into a manifest/metadata file in a standard format (JSON/YAML) to allow simpler external parsing. Test Plan: 1) Apply this patch 2) Install the latest Kitchen Sink plugin: https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.39/koha-plugin-kitchen-sink-v2.1.39.kpz 3) Browse to plugins home, note that nothing appears to have changed 4) Browse to your pluginsdir, find the PLUGIN.yml file for the Kitchen Sink plugin, edit some of the metadata 5) Reload the plugins home page, note your changes to PLUGIN.yml appear in the plugins table! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25316] Koha::Plugin::Base should automatically find plugin metadata and store it in the database for retreival
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25316 Kyle M Hall changed: What|Removed |Added Resolution|--- |MOVED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25024] OPAC incorrectly marks branch as invalid pickup location when similarly named branch is blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25024 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Joy Nelson --- rebased (thanks nick) and backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25316] Koha::Plugin::Base should automatically find plugin metadata and store it in the database for retreival
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25316 --- Comment #1 from Kyle M Hall --- Created attachment 103981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103981=edit Bug 25316: Koha::Plugin::Base should automatically find plugin metadata and store it in the database for retreival -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 --- Comment #35 from Kyle M Hall --- I think I've changed my mind about making this a followup bug. The new code for based on Marcel's thoughts is much more elegant. I'm going to post the change there for posterity, then close the bug and merge the changes in here as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772 --- Comment #10 from Victor Grousset/tuxayo --- original location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25321] New: Move translatable strings out of strings.inc into merge-record.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 Bug ID: 25321 Summary: Move translatable strings out of strings.inc into merge-record.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 21156 Strings which were put in strings.inc for translation purposes can now be wrapped in the new translation function and put in the various JavaScript files where they're used. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||25321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25321 [Bug 25321] Move translatable strings out of strings.inc into merge-record.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||25320 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 [Bug 25320] Move translatable strings out of merge-record-strings.inc into merge-record.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25320] New: Move translatable strings out of merge-record-strings.inc into merge-record.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Bug ID: 25320 Summary: Move translatable strings out of merge-record-strings.inc into merge-record.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Depends on: 21156 Strings which were put in merge-record-strings.inc for translation purposes can now be wrapped in the new translation function and put in merge-record.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||25318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 [Bug 25318] Convert authorities_js.inc to JavaScript file with translatable strings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25318] Convert authorities_js.inc to JavaScript file with translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Owen Leonard changed: What|Removed |Added Depends on||21156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||25317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 [Bug 25317] Move translatable strings out of additem.js.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25317] Move translatable strings out of additem.js.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 Owen Leonard changed: What|Removed |Added Depends on||21156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21156] Internationalization: plural forms, context, and more for JS files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 Owen Leonard changed: What|Removed |Added Blocks||25319 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25319 [Bug 25319] Move translatable strings out of ill-list-table-strings.inc into ill-list-table.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25319] New: Move translatable strings out of ill-list-table-strings.inc into ill-list-table.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25319 Bug ID: 25319 Summary: Move translatable strings out of ill-list-table-strings.inc into ill-list-table.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 21156 Strings which were put in ill-list-table-strings.inc for translation purposes can now be wrapped in the new translation function and put in ill-list-table.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25318] New: Convert authorities_js.inc to JavaScript file with translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25318 Bug ID: 25318 Summary: Convert authorities_js.inc to JavaScript file with translatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Now that we can translate strings in JavaScript we can convert authorities_js.inc into a JavaScript file with language strings updated with the new JS translation function. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25317] New: Move translatable strings out of additem.js.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25317 Bug ID: 25317 Summary: Move translatable strings out of additem.js.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Now that we can translate strings in JavaScript we can eliminate files like additem.js.inc which we only needed for translatability. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts/empties Course Reserve Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772 --- Comment #9 from Hannah Olsen --- > > 4) Deleted course > > See that Shelving Location has changed back to what was picked during > > adding it to the Course. > > In my case it got changed to nothing. Is it expected? > Should the test plan be amended? > > > 6) Repeat steps 1-4, note the shelvig location is not lost! > > Indeed it works :D Does it keep it as the original location (previous to the Course) or does it change it back to what was picked during adding to Course? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Andrew Fuerste-Henry --- This patch isn't applying for me. It's mad because installer/data/mysql/es-ES/mandatory/sample_notices.sql gone, due to bug 24897. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21565] SCO checkout confirm should be modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 Lucas Gass changed: What|Removed |Added Attachment #103980|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- BTW, bug 20453 is nearly a duplicate of this one. It adds a notice for when a hold is cancelled, but only when it's cancelled manually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21565] SCO checkout confirm should be modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21565] SCO checkout confirm should be modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 --- Comment #9 from Lucas Gass --- Created attachment 103980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103980=edit Bug 21565: (follow-up) Make confirmation buttons more detailed This patch updates the confirmation buttons to be more specific about what each one does. My concern was that it wasn't clear that "No" meant "No receipt" and not "Cancel logging out." The patch also updates the modal confirmation code so that the modal body is removed if no message is passed for it. To test, apply the patch and repeat the previous test plan. When you click "Finish" you should have the options "Print receipt and end session" and "End session." Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 --- Comment #20 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25271] Add floating toolbar to OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25271] Add floating toolbar to OPAC cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25271 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19313] Typo in UNIMARC field 130 plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19313] Typo in UNIMARC field 130 plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16371] Quote of the Day (QOTD) for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371 David Nind changed: What|Removed |Added Attachment #103732|0 |1 is obsolete|| --- Comment #26 from David Nind --- Created attachment 103979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103979=edit Bug 16371: Fix tests Tests failed due ids already existing in 'quotes' table. This patch removes hardcoded ids from tests. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
