[Koha-bugs] [Bug 24289] Deleting branch will not delete entry in special or repeatable holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289 Pablo AB changed: What|Removed |Added CC||pablo.bian...@gmail.com --- Comment #14 from Pablo AB --- On December I installed an instance based on koha stable without any issue. Today I get this error on web installer, while adding sample data. Seems related to this bug: sample_libraries_holidays.sql [Wed May 13 19:24:37 2020] install.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_mylibrary`.`repeatable_holidays`, CONSTRAINT `repeatable_holidays_ibfk_1` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE) at /usr/share/perl5/DBIx/RunSQL.pm line 273. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104821|0 |1 is obsolete|| --- Comment #464 from Aleisha Amohia --- Created attachment 104870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104870=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, check in and set waiting, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, check in and set waiting, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, check in and set waiting, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, check in and set waiting, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, check in and set waiting, revert waiting status, mark overdue - log viewer and the general circulation of recalls -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104820|0 |1 is obsolete|| --- Comment #463 from Aleisha Amohia --- Created attachment 104869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104869=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104819|0 |1 is obsolete|| --- Comment #462 from Aleisha Amohia --- Created attachment 104868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104868=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104818|0 |1 is obsolete|| --- Comment #461 from Aleisha Amohia --- Created attachment 104867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104867=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104816|0 |1 is obsolete|| --- Comment #459 from Aleisha Amohia --- Created attachment 104865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104865=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104817|0 |1 is obsolete|| --- Comment #460 from Aleisha Amohia --- Created attachment 104866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104866=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104814|0 |1 is obsolete|| --- Comment #457 from Aleisha Amohia --- Created attachment 104863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104863=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #104815|0 |1 is obsolete|| --- Comment #458 from Aleisha Amohia --- Created attachment 104864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104864=edit Bug 19532: Updated schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25498 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Cannot change owner of list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=11889 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #39 from David Cook --- (In reply to kholt from comment #4) > It would be great to be able to keep public lists. We had this problem when > the staff person who maintained our Newbery Awards list retired and her > staff account was deleted. A system administrator should be able to > transfer ownership of a list so that it can continue to be added to. I 100% agree. We've had someone retire and we need to change the owner of the list. As a vendor, usually I would just do a backend database update to do this, but I don't have remote access to this Koha, so that's a problem. I've opened an issue specifically about this topic: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 I'm not planning on working on this right now, but maybe someone else will. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] New: Cannot change owner of list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Bug ID: 25498 Summary: Cannot change owner of list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Once someone owns a list, there is no way to change the owner. This problem often arises when a library staff member uses an individual account to create a public list, and then they leave their job. A superlibrarian (or otherwise privileged user) should be able to change the owner of a list on demand. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25476] Uploaded files can't be easily browsed via upload.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25476] Uploaded files can't be easily browsed via upload.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476 --- Comment #1 from David Cook --- Created attachment 104862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104862=edit Bug 25476: Add ability to browse file uploads by category This patch adds the ability to search/browse files by category. (Note it doesn't include temporary uploads since they don't have a "category" per se.) Test Plan: 0) Apply patch 1) Go to /cgi-bin/koha/admin/authorised_values.pl 2) Create "UPLOAD" authorized value category 3) Create "test" authorized value in "UPLOAD" category 4) Go to /cgi-bin/koha/tools/upload.pl 5) Note "Search uploads by category" fieldset 6) Upload new file to "test" category 7) Click "Back" 8) Choose "test" category in "Search uploads by category" 9) Click "Search" 10) Note that your file upload is displayed in result list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25476] Uploaded files can't be easily browsed via upload.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476 David Cook changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #22 from Victor Grousset/tuxayo --- It works! Test plan from here has been copied in the patch and completed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #104843|0 |1 is obsolete|| --- Comment #19 from Victor Grousset/tuxayo --- Created attachment 104859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104859=edit Bug 24413: Apply AutoRemoveOverduesRestrictions for lost items It's quite hard to know where this need to be fixed. it can be either MarkIssueReturned or LostItem, depending on the different cases we want to handle. This patch picked MarkIssueReturned, but maybe the similar code in AddReturn needs to be removed then. == Test plan == 1. Set MarkLostItemsAsReturned to 'from items tab of the catalog module' 2. Set AutoRemoveOverduesRestrictions to 'Do' 3. Set up an overdues restriction in the notice triggers 4. Check out an item and let the overdues process restrict the account 5. Navigate to the moredetail.pl page (items tab) for the overdue item 6. Mark the item lost 7. Return to the account in question - notice the item has been returned, but the restriction remains 8. Clean state: remove restriction + remove item lost status 9. Apply patch 10. Redo the test but this time in addition to the item being returned, the restriction will be lifted. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #104845|0 |1 is obsolete|| --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 104861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104861=edit Bug 24413: Add tests Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #104844|0 |1 is obsolete|| --- Comment #20 from Victor Grousset/tuxayo --- Created attachment 104860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104860=edit Bug 24413: Do not remove the restrictions from AddReturn As we are now removing them from MarkIssueReturned they should not be removed from AddReturn as well. Also I think this will fix a regression, if $doreturn is not set (in case the item is withdrawn and BlockReturnOfWithdrawnItems or the item is lost and BlockReturnOfLostItems, and other specific cases). Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25497] New: Software error:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25497
Bug ID: 25497
Summary: Software error:
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: supp...@ccs.edu.au
Unable to access Koha via https://library.ccs.edu.au/
Throws this error below
Software error:
DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Can't connect
to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such
file or directory") at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1520. at
/usr/share/koha/lib/Koha/Database.pm line 107
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 --- Comment #10 from Victor Grousset/tuxayo --- Message from Jonathan on IRC > about 24469 - the important bit is to use the "Add" link, not the "Save" > button I'm not even a that part yet. It's A/ on first phase (bug reproduction) I'm not even hitting the actual bug. > A/ Create a new order from a stage file. > Use the "Save" button at the bottom of the "Add orders from" page > Then note the matched_biblionumber value. It should be populated correctly No matched_biblionumber. Tried with - Debian 10 & MariaDB - Debian 9 & MySQL 5.5 in case that was some compat issue. But no :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #1 from David Cook --- Created attachment 104858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104858=edit Bug 25475: add "Copy link" button to upload.pl This patch adds a "Copy link" button to /cgi-bin/koha/tools/upload.pl. It will create a modal that displays a URL like the following: http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-retrieve-file.pl? id=beb928969032f980056ea8269bc816fe Users can then copy the URL from that modal. If the browser supports the Clipboard API, the URL is also written to the browser's clipboard, making manually copying from the modal redundant. Test plan: 0) Apply patch 1) Go to http://localhost:8081/cgi-bin/koha/tools/upload.pl 2) Upload a file with the "Allow public downloads" box checked 3) Note the "Copy link" button in the "Actions" column 4) Click "Copy link" 5) Note that a modal is created with contents like the following: http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-retrieve-file.pl? id=beb928969032f980056ea8269bc816fe 5b) If you're using a modern browser, try Ctrl+V somewhere and note that the URL has already been copied to your clipboard 6) Manually highlight the text in the modal and Ctrl+C 7) Click outside the modal 8) Paste the URL somewhere useful like a system preference or News item 9) Profit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10337] Add a script to insert all sample data automatically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #16 from David Cook --- Should this script be removed now that we use misc4dev? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25496] New: IDreamBooksResults rating results breaks OPAC page JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25496 Bug ID: 25496 Summary: IDreamBooksResults rating results breaks OPAC page JS Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: tgoat...@gmail.com QA Contact: testo...@bugs.koha-community.org There some buggy JavaScript in iDreamLibraries / iDreamBooks that you get by turning on the iDreamBooksResults rating results. Having this on breaks all JS on the OPAC results page. Relevance sorting is being impacted and even stuff like "did you mean" won't work. TypeError: $.browser is undefined opac-search.pl line 6340 position 17 (edited) you get it by turning on IDreamBooksResults -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] Wrong permissions in spec break Plack on Debian 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Tomás Cohen Arazi changed: What|Removed |Added Assignee|tomasco...@gmail.com|n...@bywatersolutions.com --- Comment #6 from Tomás Cohen Arazi --- Nick, please check what's going on with the failing test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] Wrong permissions in spec break Plack on Debian 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 104857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104857=edit Bug 25482: Fix tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25053] PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is unclear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25053 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 Status|Pushed to stable|Pushed to oldstable --- Comment #6 from Lucas Gass --- backported to 19.05.x. for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24547] Add more action logs for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24547] Add more action logs for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 CC||lu...@bywatersolutions.com --- Comment #7 from Lucas Gass --- Simple and useful enhancement, backporting to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25027] Result browser should not overload onclick event
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20370] Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20370 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25494] Warnings in advanced editor macros routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_20_05_candidate Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] Wrong permissions in spec break Plack on Debian 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482
--- Comment #4 from Tomás Cohen Arazi ---
(In reply to Tomás Cohen Arazi from comment #1)
> Found the issue. It took me a while
>
> The thing is, the JSON::Validator/openAPI plugin combination we have in D9
> is very loose, and doesn't catch a problem in the Advanced editor macros
> routes spec. Basically, there are routes that have:
>
> x-koha-permission: {
> editcatalogue => 'advanced_editor',
> editcatalogue => 'delete_shared_macros',
> }
>
> which is basically invalid, as you shouldn't be able to define a hash with
> two values for the same key.
>
> My first attempt was to just to the expected thing:
>
> x-koha-permission: {
> "editcatalogue" => [
> 'advanced_editor',
> 'delete_shared_macros'
> ]
> }
>
> This should work, but it doesn't really.
That syntax is wrong, the attached patch puts the right one.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] Wrong permissions in spec break Plack on Debian 10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Tomás Cohen Arazi changed: What|Removed |Added Summary|koha-plack not working |Wrong permissions in spec |under D10 |break Plack on Debian 10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 104856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104856=edit Bug 25482: Wrong permissions specification for adv editor macros The current permissions are defined as a hash, with a duplicate key. This is generally invalid, but Debian 9's Mojolicious::Plugin::OpenAPI lets it go through, even though the results are, random? This patch sets the required permissions right, and following the haspermissions() syntax correctly. Tests for searching macros are not passing. Still trying to figure. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24993] koha-sip --restart is too fast, doesn't always start SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24993 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #24 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25008] Koha::RecordProcessor->options doesn't refresh the filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25008 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #23 from Lucas Gass --- Same pod error for me but I backported regardless. Backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 --- Comment #2 from Tomás Cohen Arazi --- Oh, they are, on a separate file :-D t/db_dependent/Auth/haspermission.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Tomás Cohen Arazi changed: What|Removed |Added CC|ro...@catalyst.net.nz |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482
Tomás Cohen Arazi changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
|ity.org |
--- Comment #1 from Tomás Cohen Arazi ---
Found the issue. It took me a while
The thing is, the JSON::Validator/openAPI plugin combination we have in D9 is
very loose, and doesn't catch a problem in the Advanced editor macros routes
spec. Basically, there are routes that have:
x-koha-permission: {
editcatalogue => 'advanced_editor',
editcatalogue => 'delete_shared_macros',
}
which is basically invalid, as you shouldn't be able to define a hash with two
values for the same key.
My first attempt was to just to the expected thing:
x-koha-permission: {
"editcatalogue" => [
'advanced_editor',
'delete_shared_macros'
]
}
This should work, but it doesn't really. Plack would be back to work, but
C4::Auth::haspermission validates the permissions when it shouldn't. At least
that's what running
$ prove t/db_dependent/api/v1/advanced_editor_macros.t
tells.
I will review the tests tomorrow (too tired today). It is possible that the
permissions assignment taking place in the tests is incorrect.
I was about to write a regression test for C4::Auth for this case, and see
what's going on, but... to my dismay... couldn't find tests...
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25495] New: members-home.pl should allow search for exact borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25495 Bug ID: 25495 Summary: members-home.pl should allow search for exact borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When searching by borrowernumber in the patrons module, the only search type options are "contains" and "starts with," both of which can be unhelpful when searching by borrowernumber, especially when trying to find a relatively low-numbered patron in a large system. It'd be great to be able to perform an exact match search so "10" wouldn't find 100, 101, 1001, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 Status|Pushed to stable|Pushed to oldstable --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24903] Special characters like parentheses in numbering pattern cause duplication in recievedlist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24903 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25038] OPAC reading history checkouts and on-site tabs not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25038 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #9 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24966] Fix calls to maybe_add where method call does not return a value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24966 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 --- Comment #22 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25494] Warnings in advanced editor macros routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 104855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104855=edit Bug 25494: Remove warnings in advanced editor macros routes There's a couple leftover 'warn's in the controller code. This patch removes that. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/advanced_editor_macros.t => FAIL: Two numbers are warned 2. Apply this patch and repeat 1 => SUCCESS: No more warns 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25494] Warnings in advanced editor macros routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25040] Problematic current_timestamp syntax generated by DBIx::Class::Schema::Loader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25040 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #24 from Lucas Gass --- Not to sure about backporting this one to 19.05.x. When I run the QA tool I get: FAIL Koha/Schema/Loader/mysql.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid Leaving it out of 19.05.x for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25050] Elasticsearch - authority indexing depends on mapping order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25050 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- doesnt apply clean to 19.05.x, if needed please rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24266] Noisy error in reconcile_balances.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24266 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com --- Comment #22 from Lucas Gass --- backported to 19.05.x. for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25095] Remove warn left in FeePayment.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25095 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22778] Suggestions with no "suggester" can cause errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22778 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 CC||lu...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable --- Comment #16 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25494] New: Warnings in advanced editor macros routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Bug ID: 25494 Summary: Warnings in advanced editor macros routes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com To reproduce: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/advanced_editor_macros.t => FAIL: Two numbers are warned -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25468] Preserve line breaks in hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Lucas Gass changed: What|Removed |Added Attachment #104792|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 104854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104854=edit Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25468] Preserve line breaks in hold notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25468 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25471] Add DataTables to MARC subfield structure admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25471 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25471] Add DataTables to MARC subfield structure admin page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25471 Lucas Gass changed: What|Removed |Added Attachment #104802|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 104853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104853=edit Bug 25471: Add DataTables to MARC subfield structure admin page This patch adds DataTables sorting and filtering to the table of subfields shown on the MARC subfield structure administration page. To test, apply the patch and go to Administration -> MARC bibliographic framework. - From the 'Actions' menu, select 'MARC structure.' - From the 'Actions' menu, select the 'View subfields' link for a tag with multiple subfields. - On the page showing all the subfields for the tag, confirm that the table is sorted by default by subfield and that sorting works correctly. - Confirm that the search form at the top of the table works. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25032] Generic unhandled exception handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What|Removed |Added Depends on||25032 Keywords||rel_20_05_candidate Severity|major |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25032 [Bug 25032] Generic unhandled exception handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 104852
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104852=edit
Bug 25493: Make ->unhandled_exception use Koha::Logger
To test:
1. Edit the Koha/REST/V1/Cities.pm 'list' method adding
die("Nada"); before the render step.
2. Restart plack and try the endpoint
=> SUCCESS: The message is generic, but you see something is
logged in /var/log/koha/kohadev/api-error.log
3. Change die("Nada"); for a real exception like:
use Koha::Exceptions;
Koha::Exceptions::DuplicateObject->throw("Nada");
4. Repeat 2.
=> SUCCESS: The message is generic, but a meaningful text is added to
the logs.
5. Point your browser to the /api/v1/hola route from your dev
environment
=> FAIL: Wow, such a weird error
6. Apply this patch
7. Restart plack and repeat 2, 3 and 4
=> SUCCESS: No behaviour change
8. Repeat 5
=> SUCCESS: The regular Mojolicious 404 weird page
9. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25493] Koha::Logger is not suitable for using as Mojo::Log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493 Tomás Cohen Arazi changed: What|Removed |Added Summary|Unhandled exceptions cause |Koha::Logger is not |an exception|suitable for using as ||Mojo::Log -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25493] New: Unhandled exceptions cause an exception
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25493
Bug ID: 25493
Summary: Unhandled exceptions cause an exception
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: REST API
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomasco...@gmail.com
We rushed into using Koha::Logger as a Mojo::Log implementation, but there are
some differences that need to be addressed before that can actually happen.
This is not *that* problematic for production sites, but some things like
hitting an undefined route will raise weird errors we need to avoid:
GET http://kohadev.myDNSname.org:8081/api/v1/hola
The application raised the following error:
Can't use an undefined value as an ARRAY reference at template
mojo/debug.html.ep line 311.
306: %= $kv->(Time => scalar localtime(time))
307:
308:
309: tap for more
310:
311: % if (@{app->log->history}) {
312:
313:
314: % for my $msg (@{app->log->history}) {
315:
316:
and the StackTrace middleware couldn't catch its stack trace, possibly because
your application overrides $SIG{__DIE__} by itself, preventing the middleware
from working correctly. Remove the offending code or module that does it: known
examples are CGI::Carp and Carp::Always.
<
We need to move back to using plain Koha::Logger, and rethink the proposal from
bug 18205 to use MojoX::Log::Log4perl. That certainly belongs to another bug.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25492] New: Your Account Menu button does nothing on mobile devices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Bug ID: 25492 Summary: Your Account Menu button does nothing on mobile devices Change sponsored?: --- Product: Koha Version: 19.11 Hardware: Other OS: Other Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: jyo...@equinoxinitiative.org QA Contact: testo...@bugs.koha-community.org Replicated with Koha 19.11.04 and 19.11.05 Steps to reproduce: 1) Bring up the OPAC on a mobile device with a smaller screen (e.g. cell phone) or using an emulator 2) Log into an account 3) Find the button labeled "Your account menu" 4) Click it. 5) Nothing happens. ** I didn't see any errors in the browser console or in the Koha logs. I tested this with 18.11.05 and clicking the button expands the menu as you'd expect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25409] Required dropdown missing "required" class near label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25409 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #19 from Joy Nelson --- pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25417] Backdating returns and forgiving fines causes and internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25417 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com --- Comment #37 from Joy Nelson --- Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25418] Backdated check out date loses time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25418] Backdated check out date loses time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25418 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #12 from Joy Nelson --- pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #101 from Joy Nelson --- missing dependencies-not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13547] Item field 'Materials specified' would be useful to see in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 --- Comment #28 from Joy Nelson --- enhancement not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24823] Drop Catmandu dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #27 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22970] Allow to change homebranch in batch add course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22970 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #9 from Joy Nelson --- enhancement not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25279] Make the cities list use the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #47 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24561] Add a datatables API wrapper
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #20 from Joy Nelson --- missing dependencies - not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25188] Make circulation notes more prominent on the patron details tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25188 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #16 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25478] Inconsistent naming of account_credit_type for lost and returned items [19.11 Version]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25478 Joy Nelson changed: What|Removed |Added Status|Passed QA |Pushed to stable CC||j...@bywatersolutions.com --- Comment #5 from Joy Nelson --- Thanks Martin! Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24488 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22431 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Slava Shishkin changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491
--- Comment #1 from Slava Shishkin ---
Created attachment 104851
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104851=edit
Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm
This warning was thrown:
Use of uninitialized value $info{"invalid_username_or_password"}
in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm
line 387.
There is the case when hash key can be undefined in numeric comparison.
Fixed by adding additional precheck for
$info{"invalid_username_or_password"} being Perl's "true".
To test:
1) Go to the first page of the web-installer where it asks to login.
2) Observe the warning in the log file.
3) Apply patch.
4) Repeat step 1.
7) Check that previous warning suppressed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] New: Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491
Bug ID: 25491
Summary: Perl warning at the login page of installer
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: Installation and upgrade (web-based installer)
Assignee: slavashish...@gmail.com
Reporter: stalkern...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
I encountered this warning at the login page of installer
/cgi-bin/koha/installer/install.pl:
Use of uninitialized value $info{"invalid_username_or_password"}
in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm
line 387.
This requires a simple fix to check for undef before numeric comparison.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25490] Syspref OpacMoreSearches not in manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25490 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24220 Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25490 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25490] New: Syspref OpacMoreSearches not in manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25490 Bug ID: 25490 Summary: Syspref OpacMoreSearches not in manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org OpacMoreSearches is not in the 19.11 or previous manuals. I was looking specifically for the syntax to add the title to the search link (if at all possible) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25489] Add ability to delete without sending to clipboard in advanced catalog editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25489 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25489] New: Add ability to delete without sending to clipboard in advanced catalog editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25489 Bug ID: 25489 Summary: Add ability to delete without sending to clipboard in advanced catalog editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Bug 17179 changed existing behavior so that any field deleted with the ctrl-X shortcut is sent to the clipboard. It would be good to be able to delete a field without sending it to the clipboard. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25488] Add method to clear clipboard in advanced catalog editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25488 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25488] New: Add method to clear clipboard in advanced catalog editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25488 Bug ID: 25488 Summary: Add method to clear clipboard in advanced catalog editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Bug 17179 introduces a copy/paste function within rancor. The clipboard maintains a list of every cut/copied string, clearing it out when one leaves the record. It would be good to be able to clear the clipboard manually while staying in a record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339 David Roberts changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||david.roberts@ptfs-europe.c ||om --- Comment #5 from David Roberts --- Signed off, although I couldn't see the string in /cgi-bin/koha/opac-review.pl?biblionumber=1'-alert(1)-'abcdefghi=1= even before the patch was applied. The first URL is certainly fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25339] Validate biblionumber on opac-basket.pl and opac-review.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25339 David Roberts changed: What|Removed |Added Attachment #104064|0 |1 is obsolete|| --- Comment #4 from David Roberts --- Created attachment 104850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104850=edit Bug 25339: Validate biblionumber on opac-basket.pl and opac-review.pl This patch runs biblionumber through the int() function before using it in the application. Test Plan: 1) Apply patch 2) Go to /cgi-bin/koha/opac-basket.pl?bib_list=1/abcdefghi'-alert(1)-'j=1 3) Note that you can't find abcdefghi in the HTML. You only see biblionumber 1. 4) Go to /cgi-bin/koha/opac-review.pl?biblionumber=1'-alert(1)-'abcdefghi=1= 5) Note that you can't find abcdefghi in the HTML. You only see biblionumber 1. Signed-off-by: David Roberts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25342] Scripts not running under plack can cause duplication of ES records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25342 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com --- Comment #14 from Joy Nelson --- Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #47 from Joy Nelson --- Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25301] Category code is blank when renewing or editing expired/expiring patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Joy Nelson changed: What|Removed |Added Version(s)|20.05.00|20.05.00, 19.11.06 released in|| Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com --- Comment #13 from Joy Nelson --- Pushed to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
