[Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726

--- Comment #4 from Andrew Fuerste-Henry  ---
Me, too! We've only seen a couple examples and haven't yet tracked down how
they got in that state. In both cases the hold had a reserves.found value of T,
but was not actually in transit. In one of those cases, the patron had 2 holds
on the same record, which suggests maybe bug 18958 is involved? But, yes, for
sure, there is a larger issue of where this bad data came from, my patch is
just alleviating the major symptom caused by the data's existence.

(In reply to Katrin Fischer from comment #3)
> Hi Andrew,
> 
> I am a bit worried about the cause of these strange holds. You say
> reserves.found is not null - what was the found value for these strange
> holds?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

--- Comment #9 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #1)
> How it looks like:
> https://snipboard.io/FYuAay.jpg
> https://snipboard.io/CL7vTo.jpg
> https://snipboard.io/B5aJ7m.jpg
> https://snipboard.io/HL9lfO.jpg

Pretty!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151

--- Comment #47 from Katrin Fischer  ---
(In reply to Christopher Brannon from comment #46)
> This bug seems to be back in 19.11!

Can you please file a new bug with a link to this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726

--- Comment #3 from Katrin Fischer  ---
Hi Andrew,

I am a bit worried about the cause of these strange holds. You say
reserves.found is not null - what was the found value for these strange holds?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25743] Fail to show complete search result after switching search engine

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25743

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Katrin Fischer  ---
If Plack is set up without Memcached sometimes prefs don't take effect
immediately. That's why i suggested the restarts. If you can make it
reproducable changing the pref, that would be interesting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25743] Fail to show complete search result after switching search engine

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25743

--- Comment #2 from yycyyc15...@gmail.com ---
(In reply to Katrin Fischer from comment #1)
> I've never heard about any effect like this. The Zebra index and the
> templates should not change from switching the pref. Did you change anything
> else?
> 
> I'll recommend bringing up this question on the mailing list first. Also I'd
> try to restart Plack, Memcache and if that doesn't help do a Zebra reindex.
> (test after each)

Thanks for your reply. I didn't change anything else apart from the search
engine.
Somehow I changed OpacItemLocation to location and seems like it triggered
something and it became normal again. So now, I just hide the location by
jquery and everything seems fine

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24201] Attach desk to intranet session

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #42 from Katrin Fischer  ---
Hi Nicolas,  is this ready again for testing? (Needs signoff) or is there still
a question that needs to be resolved?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25704] With ICU chains on, searching by callnumbers does not produce accurate results

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704

--- Comment #6 from Katrin Fischer  ---
Hi Kelly, 

could you add a search example? I'd like to test and see if I have an idea.

Another thing that comes to mind, could the *NumbersPreferPhrase make a
difference? We usually see bad search results with word list, but much better
results with phrase searches.

Are you using the call number search from advanced search and simple search or
are there any differences there?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25744

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25744] Replace tags with AND tags with in the staff interface

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22672
Summary|a11y: Replace  tags with |Replace  tags with 
   | AND  tags with  |AND  tags with 
   | everywhere |in the staff interface

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25744] a11y: Replace tags with AND tags with everywhere

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25744] New: a11y: Replace tags with AND tags with everywhere

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25744

Bug ID: 25744
   Summary: a11y: Replace  tags with  AND  tags with
 everywhere
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vic...@tuxayo.net
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

bug 22672 is for the OPAC, this is for the rest.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672#c0
Lucas Gass:
> Since screen readers typically ignore  and  tags. Instead we should
> use  and  tags which look the same visually but are more
> meaningful from an accessibility standpoint.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672

--- Comment #13 from Victor Grousset/tuxayo  ---
(In reply to Timothy Alexis Vass from comment #12)
> It's definitely fine to replace  and  in both OPAC and STAFF.

This can totally cause the whole thing to stop due to lack of time. Even if the
OPAC part is almost done. Because the staff interface adds much more work and
there are not the same strong requirements of accessibility as for the OPAC.

So I'll split this ticket so the OPAC has a chance to move on.

> Is this ready to be implemented?

Anyone that have some time for this can update the current patch add the
missing case. I'll see if in the mess I've found there is something related to
the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25584] When a 'return claim' is added, the button disappears, but the claim date doesn't show up

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25584

Katrin Fischer  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #1 from Katrin Fischer  ---
*** Bug 25734 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25734] Issues-table on circulation.pl and moremember.pl when claims returned is claimed.

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25734

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 25584 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25739] Add guarantee doesn't link to parent account

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25739

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from Katrin Fischer  ---
Hi, I think this might be a misunderstanding between guarantor and garantee?

guarantee replaces the formerly used term "child" and it always linked to an
empty patron form and not to a search.

Almost empty: The guarantor information is preset correctly.

I've verified this in an 17.11 and in a master installation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25161] Can not edit relationship or guarantee of guarantor from the guarantee form

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25161

Katrin Fischer  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #2 from Katrin Fischer  ---
*** Bug 25740 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25740] Can't fix guarantor type once it is set

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25740

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 25161 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25742] Non-member guarantor fields show in non minor accounts

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25742

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

--- Comment #15 from Katrin Fischer  ---
Hi, I also hope we can move on this quickly and find some good solution, added
to the next Dev meeting agenda:
https://wiki.koha-community.org/wiki/Development_IRC_meeting_17_June_2020#Agenda

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25743] Fail to show complete search result after switching search engine

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25743

--- Comment #1 from Katrin Fischer  ---
I've never heard about any effect like this. The Zebra index and the templates
should not change from switching the pref. Did you change anything else?

I'll recommend bringing up this question on the mailing list first. Also I'd
try to restart Plack, Memcache and if that doesn't help do a Zebra reindex.
(test after each)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25727] Update the Select2 JS lib

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #6 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #2)

Thanks Owen!

> I see some issues with this when I compare the behavior in master to the
> behavior when this patch is applied:
> 
>  - In master when there are no entries in the dropdown it shows a message in
> the dropdown, "No matches found." With the new version there is no message.

Indeed.
There was a translation issue I have "fixed" now, however the behaviour is
still the same. I think it is the expected one, but I have not looked at
Select2 code.

https://select2.org/upgrading/migrating-from-35#renamed-translation-options

See the last patch.
I found the list there:
https://github.com/select2/select2/blob/develop/dist/js/i18n/en.js

I think it's better to continue handling the translation on our side.

>  - Looking at the basic MARC editor, testing a required subfield (in my
> test, 952c). Submitting the form causes the HTML  to appear above
> the Select2 control

Fixed. 

>  - The old version let the user select an empty option by clicking an "x" in
> the control. The new version includes an empty option just like an HTML
> select would. I think both are reasonable but I wonder if this is something
> we want to intentionally change.

Restored in the patch "Fix default values"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25727] Update the Select2 JS lib

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727

--- Comment #3 from Jonathan Druart  
---
Created attachment 105853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105853=edit
Bug 25727: Adjust translations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25727] Update the Select2 JS lib

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727

--- Comment #4 from Jonathan Druart  
---
Created attachment 105854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105854=edit
Bug 25727: Fix default values

The way we defined the default values does not longer work (?)
Using
  $.fn.select2.defaults.set
instead of
  jQuery.extend($.fn.select2.defaults, {
fixes the problem.

It restores the allowClear setting.

There is a change in the behavior here, the selection opens when the
clear button is clicked. That is coming from a change in Select2
apparently. We may want to hack something to restore the precedent
behaviour.

This patch also removes the redefinition of the width. It seems that the
issue that this code was trying to correct is now fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25727] Update the Select2 JS lib

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727

--- Comment #5 from Jonathan Druart  
---
Created attachment 105855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105855=edit
Bug 25727: Fix highlight of a missing field

In the previous version of Select2 we had only 1 'a' tag that was
visible, next to the invisible select.

Now we have a 3 nested span elt, the last one (with a role=combobox
attribute) is the one we want to style.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128

--- Comment #12 from Mason James  ---
(In reply to David Cook from comment #11)
> (In reply to Jonathan Druart from comment #10)
> > What is needed here?
> 
> I imagine Mason probably just needs to remove libcryptx-perl from
> http://debian.koha-community.org/koha/pool/main/libc/libcryptx-perl/

i've updated the libcryptx-perl package for 20.05, built for deb9
 20.05|main|amd64: libcryptx-perl 0.063-1~bpo9+1

the libcryptx-perl package for 19.11 is still built for deb8
 19.11|main|amd64: libcryptx-perl 0.059-1~koha2 

i have not updated the 19.11 libcryptx-perl package yet, as i dont want to
break 19.11/deb8 support for those who are still running this combination

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #12)
> > f. POST /authorised_value_categories/:authorised_value_category_id/values
> 
> This route reads wrong to me.
> How is that different than adding a patron with a given category?

Fair enough.

> Or with funds, the route is GET /acquisitions/funds, should not it be
> /acquisitions/budgets/:budget_id:/funds in that case?

I belive it really depends on how you're gonna use it and what granularity you
want for requiring permissions or limitations on the route.
What I was pointing is the same that happened to the hold history bug: instead
of a single search you need to fetch all results and deal with limitations on
each of them, so I warned you about the 'global' route for fetching authorised
values: it looks simple, but in the end only superlibrarians should be able to
use it.

As for POST you can safely use your code (and the global route) as I belive you
can make any required checks in a really compact code in the controller. My aim
was not to block you but suggest you constraint your target to what you really
need instead of a whole complete API for authorised values so you don't get
frustrated.

So you can strip the more complex and debatable use cases and already have the
route you need. Go ahead!

> Also note that there is no "authorised_value_category_id", but category_name
> is the PK of the authorised_value_categories table. Should we add one or you
> meant category_name?

We reached and agreement that ID's are appended _id for consistency. So I
invented the name to make a point following the guidelines. That's why the RFC
needs to be voted.

We can sort this out easily with a conversation with Martin and a dev meeting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #13 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #11)
> I wanted to implement bug 25728 correctly by using a new REST API endpoint.
> I followed the approved RFC and what was done for cities but apparently that
> was not enough and the whole RFC must be rethink. I don't know how many of
> wrong RFC are on the wiki, but it would be good to remove or adjust them if
> they do not longer match what we want.

Those RFC were marked as WIP by the author (Josef?) And I only added my two
cents.
My opinions are just opinions, Jonathan. What I highlighted is the fact that
for some uses we'd better find another approach than the global route.

> I may be back on this one later, but at the moment I don't have more time to
> dedicate to this.

I'm sorry to read that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

--- Comment #12 from Jonathan Druart  
---
> f. POST /authorised_value_categories/:authorised_value_category_id/values

This route reads wrong to me.
How is that different than adding a patron with a given category?

Or with funds, the route is GET /acquisitions/funds, should not it be
/acquisitions/budgets/:budget_id:/funds in that case?

Also note that there is no "authorised_value_category_id", but category_name is
the PK of the authorised_value_categories table. Should we add one or you meant
category_name?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun
   |ommunity.org|ity.org

--- Comment #11 from Jonathan Druart  
---
I wanted to implement bug 25728 correctly by using a new REST API endpoint.
I followed the approved RFC and what was done for cities but apparently that
was not enough and the whole RFC must be rethink. I don't know how many of
wrong RFC are on the wiki, but it would be good to remove or adjust them if
they do not longer match what we want.

I may be back on this one later, but at the moment I don't have more time to
dedicate to this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|17390   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390
[Bug 17390] Add REST API endpoint for Authorised Values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|25728   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728
[Bug 25728] Add the ability to create a new authorised value within the
cataloguing module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728

--- Comment #8 from Jonathan Druart  
---
Created attachment 105852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105852=edit
Bug 25728: Use a svc script instead of the REST API endpoint

The try to implement correctly the REST API endpoint for authorised
values failed.
This patch uses an easy to implement svc script for the POST route.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25743] New: Fail to show complete search result after switching search engine

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25743

Bug ID: 25743
   Summary: Fail to show complete search result after switching
search engine
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: PC
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: yycyyc15...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I switched to ElasticSearch in Search Engine Admin preference. I didnt install
ElasticSearch so the page is blank.
I just switched it back to Zebra. But then, the book detail like the author,
publisher info under the title are gone. The search result book title is weird
as well. There is missing word in the title. For example, if I searched for
Secret, then the book secret garden just shows up with garden only.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21086] Wrong mock of DateTime->now in tests

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086
Bug 21086 depends on bug 19705, which changed state.

Bug 19705 Summary: DecreaseLoanHighHolds.t is still failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #11 from Jonathan Druart  
---
Victor, bug reports marked as pushed to a version that has been released
already should not be reopened. Please open a new bug report instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly

2020-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
Bug 25551 depends on bug 19705, which changed state.

Bug 19705 Summary: DecreaseLoanHighHolds.t is still failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/