[Koha-bugs] [Bug 25880] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25880 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Awokaowk|SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25838] Sort facets values by number of occurrences (Zebra)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #8 from Katrin Fischer --- We can't yet. Elasticsearch is not widely used yet and won't be for quite a while (maybe some will never use it because of its requirements) and the Zebra facets are too slow. We tried, search times were horrible. We had to switch back. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25881] Alternate address and Alternative contact appear in Details even when fields hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25881 --- Comment #1 from David Cook --- A quick hack workaround is just to hide those fields using CSS, but that's not really optimal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25881] New: Alternate address and Alternative contact appear in Details even when fields hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25881 Bug ID: 25881 Summary: Alternate address and Alternative contact appear in Details even when fields hidden Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com "Alternate address" and "Alternative contact" appear on /cgi-bin/koha/members/moremember.pl?borrowernumber=1 even when the fields used for them are hidden by BorrowerUnwantedField. If you try to click "Edit" or "Add", you'll be taken to an editor screen with no fields - just "Save" and "Cancel" buttons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #64 from David Cook --- I've been thinking that a standalone Mojolicious-based OPAC would be great, but that would involve a huge amount of work (even if there are < 100 OPAC .pl scripts), so maybe it's more feasible to slowly move from CGI scripts to Mojolicious routes here... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25838] Sort facets values by number of occurrences (Zebra)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25838 --- Comment #7 from David Cook --- (In reply to Katrin Fischer from comment #6) > I believe it works, the question is about presentation in the OPAC - sorting > alphabetic or by occurrence. As we only look for occurrences on the first > page the numbers are inaccurate (with no Zebra facets). So I was saying I > prefer alphabetic because it does maybe give less of a false impression. > > Comparing to Elastic facets doesn't work here I think as they work very > differently and results should be much more trustable. That's true, although maybe that's all the more reason to get rid of non-Zebra facets, and to more fully embrace Elasticsearch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #104 from David Cook --- (In reply to Jonathan Druart from comment #103) > As I said previously it could be reused for other features. I don't think it > should be tight to the "anonymization" feature. I suppose. If other features wanted to deviate, then the onus could be on them to create a new setting. Yeah, ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #56 from David Cook --- Created attachment 106313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106313=edit Bug 16357: [Alternative] Use separate Log4Perl logger for each Plack app This patch creates separate timestamped Log4Perl loggers for each Plack app, so that the Intranet, OPAC, and API are logged to separate files. To Test: 0) apt-get install libplack-middleware-logwarn-perl 1) Apply "Alternative" patches 2) Copy PLACK block from etc/log4perl.conf to /etc/koha/sites/kohadev/log4perl.conf and replace __LOG_DIR__ appropriately 3) Copy debian/templates/plack.psgi to /etc/koha/sites/kohadev/plack.psgi 4) Temporarily add 'warn "TEST"' to opac-main.pl and mainpage.pl 5) koha-plack --restart kohadev 6) Go to /cgi-bin/koha/mainpage.pl and /cgi-bin/koha/opac-main.pl 7) Open /var/log/koha/kohadev/plack-opac-error.log and /var/log/koha/kohadev/plack-intranet-error.log 7) Observe a log line like the following: [2020/06/22 03:51:23] [WARN] TEST at
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #55 from David Cook --- (In reply to Tomás Cohen Arazi from comment #37) > Question: shouldn't we take the oportunity to actually split the logs for > each interace? Agreed and achieved. Patch to follow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #63 from David Cook --- It would be great to see this move forward now that we're at the start of a new release cycle. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #54 from David Cook --- Forgot that I'd updated my log4perl.conf and plack.psgi in koha-testing-docker and now I have this fix when troubleshooting other issues. Awesome. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25880] Awokaowk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25880 contol012 changed: What|Removed |Added CC||gilangrian...@gmail.com --- Comment #1 from contol012 --- Comment on attachment 106312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106312 Awokawokawok Njay -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25880] New: Awokaowk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25880 Bug ID: 25880 Summary: Awokaowk Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: contribs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: gilangrian...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 106312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106312=edit Awokawokawok Awokawokawok -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25811] authentication.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811
--- Comment #4 from Victor Grousset/tuxayo ---
> Victor, can you try to call $driver->get_page_source(); and share the content?
Okay!
Did 113 run recreating it >_< disabled the additional logging to see if that
was the cause.
After 20 runs, got this error. it's not related right?
t/db_dependent/selenium/authentication.t .. 1/2
STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch
{...}
/usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:353 in
Try::Tiny::try
(eval 444):1 in Selenium::Remote::Driver::__ANON__
(eval 446):2 in Selenium::Remote::Driver::__ANON__
/usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1330 in
Selenium::Remote::Driver::_execute_command
/usr/local/share/perl/5.28.1/Selenium/Remote/Driver.pm:1330 in (eval)
t/db_dependent/selenium/authentication.t:99 in
Selenium::Remote::Driver::find_element
/usr/share/perl/5.28/Test/Builder.pm:339 in main::__ANON__
/usr/share/perl/5.28/Test/Builder.pm:339 in (eval)
/usr/share/perl/5.28/Test/More.pm:807 in Test::Builder::subtest
t/db_dependent/selenium/authentication.t:133 in Test::More::subtest
# Looks like you planned 6 tests but ran 3.
t/db_dependent/selenium/authentication.t .. 2/2
# Failed test 'OPAC interface authentication'
# at t/db_dependent/selenium/authentication.t line 133.
malformed JSON string, neither tag, array, object, number, string or atom, at
character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line
190.
# Looks like your test exited with 255 just after 2.
t/db_dependent/selenium/authentication.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
I'm retrying with the logging added and hoping the original issue to happen.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #3 from Lisette Scheer --- +1 it seems like the non-patron Guarantor should be with patron Guarantors -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #2 from Caroline Cyr La Rose --- +1 I agree that the non-patron Guarantor information should go in the 'Guarantor information' section rather than the 'Contact' section. We could hide it behind a button. I would put a button next to the 'Search to add' button that says something like 'Guarantor is not a patron'. Or have it like pre-19.11 where the non-patron fields are always showing and you can click on 'Search to add' to fill them, but I admit that I didn't find that it was very intuitive... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo --- This bug is marked as only affecting version 19.05.x, but it seem to affect 20.05 (as likely master) also, right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25879] New: Border for guarantor is larger than the container
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879 Bug ID: 25879 Summary: Border for guarantor is larger than the container Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org Created attachment 106311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106311=edit Screenshot showing the guarantor section of the patron add form I noticed that the soft blue border that surrounds a guarantor's information in the patron form is slightly larger than the containing box. To reproduce: 1- Add a patron 2- In guarantor information, search for and add a guarantor 3- Notice that the border surrounding the guarantor is larger than the box for guarantor information -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | --- Comment #3 from Tomás Cohen Arazi --- Taking this one. I will add a 'deny_list' for fields that cannot be hidden by configuration, probably just 999 for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 Katrin Fischer changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 Katrin Fischer changed: What|Removed |Added Status|REOPENED|NEW Depends on||24458 Version|19.11 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 Katrin Fischer changed: What|Removed |Added Blocks||25826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25826 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 Katrin Fischer changed: What|Removed |Added Resolution|DUPLICATE |--- Summary|All results link to 404 in |Hiding biblionumber in the |staff and intranet |frameworks breaks links in |(SOMETIMES) |result list Status|RESOLVED|REOPENED See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25686 --- Comment #2 from Katrin Fischer --- The other related bug is closed - reopening this one for a fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25809] Make claims returned claims visible in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25809 Hasina changed: What|Removed |Added CC||shum...@gmail.com --- Comment #4 from Hasina --- I agree with Donna. It would be nice if Library has this choice. Now it makes patron confused. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25864] Case sensitivity breaks searching of some fields in ES5
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25864 --- Comment #4 from Heather --- Replying to myself to note that my confusion is cleared up--was able to follow test plan through step 6. Still working on it... (In reply to Heather from comment #3) > Hi! > > I was unable to recreate the problem in my sandbox. In my sandbox (which > Nick made sure satisfied step 1--thank you, Nick!) I followed step 2, > changing those two sysprefs from "Don't" to "Do," but then when trying step > 3 with 'Search entire record' selected for the search term: > fiction > I do get results. I also get authority record results with all four > authority record search options when searching: > rowling > > Am I doing something wrong to recreate the problem? > > Thanks! Cheerio! > h2 > > (In reply to Nick Clemens from comment #2) > > Created attachment 106247 [details] [review] [review] > > Bug 25864 - Lower case fields for searching > > > > To recreate: > > 1 - Have Koha using ES5 and Elasticsearch as search engine > > 2 - Enable DumpTemplateVarsIntranet and DumpSearchQueryTemplate > > 3 - Do a search in authorities using 'Search entire record' (abduction if > > using sample db) > > 4 - Note no results > > 5 - View the page source and find 'search_query' > > 6 - Note the uppercased fields > > 7 - curl 'es:9200/koha_kohadev_authorities/data/417?pretty' > > 8 - Note all fields lower-cased > > 9 - Apply patch > > 10 - Repeat search > > 11 - It works! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 ByWater Sandboxes changed: What|Removed |Added Attachment #106292|0 |1 is obsolete|| --- Comment #4 from ByWater Sandboxes --- Created attachment 106310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106310=edit Bug 25877: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. Test Plan: 1) Log in to Koha 2) Set your logged in branch to not be a pickup location 3) Attempt to place a hold 4) Note the error message 5) Apply this patch 6) Restart plack 7) Reload the page 8) Note the error is gone! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25878] New: Schema incorrectly describes course_items fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25878 Bug ID: 25878 Summary: Schema incorrectly describes course_items fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org On the schema page for the course_items table we include this comment on course_items.itype: "new itemtype for the item to have while on reserve (optional)" We have comparable notes for ccode, holdingbranch, and location. That comment is not strictly correct. While a course is active, these fields in course_items will hold the items original values. If the course is marked inactive and the item's original values are returned to the items table, then the fields in course_items will hold the values that this item had while on reserve. At this time I do not have alternate wording that explains this succinctly enough to put into the schema comment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25874] Explicit return of undef in C4/CourseReserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25874 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25874] Explicit return of undef in C4/CourseReserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25874 --- Comment #1 from Kyle M Hall --- Created attachment 106309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106309=edit Bug 25874: Explicit return of undef in C4/CourseReserves.pm "return" statement with explicit "undef" at line 87, column 5. See page 199 of PBP. (Severity: 5) Test Plan: 1) perlcritic C4/CourseReserves.pm "return" statement with explicit "undef" at line 87, column 5. See page 199 of PBP. (Severity: 5) 2) Apply this patch 3) perlcritic C4/CourseReserves.pm C4/CourseReserves.pm source OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25874] Explicit return of undef in C4/CourseReserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25874 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491
Slava Shishkin changed:
What|Removed |Added
Attachment #106306|0 |1
is obsolete||
--- Comment #6 from Slava Shishkin ---
Created attachment 106308
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106308=edit
Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm
This warning was thrown:
Use of uninitialized value $info{"invalid_username_or_password"}
in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm
line 387.
There is the case when hash key can be undefined in numeric comparison.
Fixed by adding additional precheck for
$info{"invalid_username_or_password"} being Perl's "true".
To test:
1) Go to the first page of the web-installer where it asks to login.
2) Observe the warning in the log file.
3) Apply patch.
4) Repeat step 1.
7) Check that previous warning suppressed.
Mentored-by: Andrew Nugged
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #77 from Josef Moravec --- (In reply to Jonathan Druart from comment #75) > Are you willing to fix the alignment issue, Josef? Yes, it it done now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #76 from Josef Moravec --- Created attachment 106307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106307=edit Bug 15400: (follow-up) Remove unnecessary class Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25533] Perl "not numeric" warning on the "Holds" page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25533 --- Comment #5 from Andrew Nugged --- Yes, we will re-investigate and analyze/argue or re-create the fix, few days please :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25533] Perl "not numeric" warning on the "Holds" page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25533
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europe
||.com
--- Comment #4 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #3)
> Thanks for your patch !
> You remove the warning, but are you interpreting the value correctly?
>
> -my $holds_per_record = $rule ? $rule->{holds_per_record} : 0;
> +my $holds_per_record = $rule ? $rule->{holds_per_record} || 0 : 0;
> $max = $holds_per_record if $holds_per_record > $max;
>
> If space or empty string means Unlimited and we replace it by 0, would our
> compares be correct ?
> Note that perl now does the same thing but removing the warn will only hide
> the problem you found in this code !
> I see that code is calculating the number of remaining holds:
>
> my $remaining_holds_for_record = $max_holds_for_record - $holds->count();
>
> If max is 0 but should mean Unlimited, this definitely goes wrong ?
Good catch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- Well reasoned in the autovivication case.. I agree with your conclusion. Works as expected, passes qa scripts. I'm going straight for QA here... Final note.. was there perhaps some Mentoring going on with this patch.. does it warrant a 'Mentored-by' git trailer ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25491] Perl warning at the login page of installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25491
Martin Renvoize changed:
What|Removed |Added
Attachment #104851|0 |1
is obsolete||
--- Comment #4 from Martin Renvoize ---
Created attachment 106306
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106306=edit
Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm
This warning was thrown:
Use of uninitialized value $info{"invalid_username_or_password"}
in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm
line 387.
There is the case when hash key can be undefined in numeric comparison.
Fixed by adding additional precheck for
$info{"invalid_username_or_password"} being Perl's "true".
To test:
1) Go to the first page of the web-installer where it asks to login.
2) Observe the warning in the log file.
3) Apply patch.
4) Repeat step 1.
7) Check that previous warning suppressed.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #26 from Martin Renvoize --- Trivial fixes, clear code. All works as expected and qa scripts pass. Going straight for a QA here :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize changed: What|Removed |Added Attachment #105985|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 106305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106305=edit Bug 25440: Fixed list of 'show_rule' forming variables in the template In smart-rules.tt we have `SET show_rule = ...` section which filled with 'all used in the loop' variables. Because if historical reasons it seems that there are some missing, few old, and even doubled ones. This list is fixed now by: - variable names 'article_requests' and 'renewalsallowed' repeated so duplicates are removed; - 'hardduedatebefore' and 'hardduedateexact' not present in the whole site code anywhere anymore; IMPORTANT NOTE: these 'hardduedatebefore/hardduedateexact' also exists as remnants in .po-translation files, a lot. - 'note', 'hardduedatecompare', 'renewalperiod', 'rentaldiscount' template variables were missing from this 'show_rule =' checking code so they are added. Order of fields updated to match with above "SET field = ..." pack. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize changed: What|Removed |Added Attachment #105063|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 106304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106304=edit Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl This warning emitted: Use of uninitialized value $maxsuspensiondays in string eq at /admin/smart-rules.pl line 257. But that not just undef-warning, there is broken logic, these two lines are mutually contradictory and goes one-by-one: $maxsuspensiondays = undef if $maxsuspensiondays eq q||; $maxsuspensiondays = '' if $maxsuspensiondays eq q||; Fix is simple: to make it '' if it comes undef. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440
Martin Renvoize changed:
What|Removed |Added
Attachment #104636|0 |1
is obsolete||
--- Comment #20 from Martin Renvoize ---
Created attachment 106300
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106300=edit
Bug 25440: Extra duplicated call to CGI->param method removed
In code CGI param 'no_auto_renewal_after_hard_limit' assigned to
"$no_auto_renewal_after_hard_limit" var, and then just in the next line
again variable "$no_auto_renewal_after_hard_limit" reassigned with
call to same "$input->param('no_auto_renewal_after_hard_limit')".
Fixed. No logic or results should be changed.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize changed: What|Removed |Added Attachment #105059|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 106303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106303=edit Bug 25440: Fix for "uninitialized value in string eq" in smart-rules.pl This warning emitted: Use of uninitialized value in string eq at /admin/smart-rules.pl line 289. It is solved by one line added to exclude comparison with 'on' string when variable is 'undef'. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440
Martin Renvoize changed:
What|Removed |Added
Attachment #104639|0 |1
is obsolete||
--- Comment #22 from Martin Renvoize ---
Created attachment 106302
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106302=edit
Bug 25440: Fix for "uninitialized value in hash" warning in smart-rules.pl
This warning emitted:
Use of uninitialized value in hash element
at /admin/smart-rules.pl line 569.
that happened because we have NULLs in SQL results for 'categorycode'
and 'itemtype' which later used as 'any' kind of category/item in the
template, so for the template it passed this way:
$rules->{ $r->{categorycode} }->{ $r->{itemtype} }->...
but undef will stringify as "" to become a hash key ("Hashes are
unordered collections of scalar values indexed by their associated
string key" https://perldoc.perl.org/perldata.html),
that's why "undef warning". To prevent warning here is the simple fix:
$rules->{ $r->{categorycode} // '' }->{ $r->{itemtype} // '' }->...
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize changed: What|Removed |Added Attachment #104638|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 106301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106301=edit Bug 25440: Fix for "CGI::param called in list context" in smart-rules.pl This warning emitted: CGI::param called in list context from /admin/smart-rules.pl line 262, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at CGI.pm line 412. Explained here: https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter And because all these params are not multi-params, so simple "scalar .." forcing for CGI->param is the fix. Changes are transparent and same values should be assigned as before, just no more warnings. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #11 from Kyle M Hall --- Created attachment 106299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106299=edit Bug 25662: (follow-up) Add tests for the wrong patron_id added behaviour This patch adds trivial tests for the new error (400) raised when the passed patron_id doesn't exist. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #10 from Kyle M Hall --- Created attachment 106298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106298=edit Bug 25662: Make the route for holds restpect maxreserves This patch fixes the behaviour for the POST /holds route. It assumed maxreserves was checked in CanItemBeReserved which is not the case. Tests are added to check for this behaviour. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Kyle M Hall changed: What|Removed |Added Attachment #106204|0 |1 is obsolete|| Attachment #106205|0 |1 is obsolete|| Attachment #106206|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 106297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106297=edit Bug 25662: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #11 from Martin Renvoize --- Created attachment 106295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106295=edit Bug 21395: (QA follow-up) Remove some introduced issues This patch removes some new error cases introduced during rebase Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Nice work. Rebased slightly and thoroughly tested. It's passing QA tests and makes allot of sense to me. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #12 from Martin Renvoize --- Created attachment 106296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106296=edit Bug 21395: (QA follow-up) POD fixes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 Martin Renvoize changed: What|Removed |Added Attachment #104039|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 106294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106294=edit Bug 21395: Fix QA errors Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 Martin Renvoize changed: What|Removed |Added Attachment #104038|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 106293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106293=edit Bug 21395: Make perlcritic happy This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #38 from Tomás Cohen Arazi --- Ok, this is my attempt. The basic idea is split in two: - Display analytic links for more cases (i.e. not just serial) - If the result for showing the link is considered (today) good enough, just use the same query in the code to make the decision on the .pl+XSLT combination If this approach to 'hiding when unnecessary' is good enough (I think it is) we could file a new but for adding new conditions (like ISBN, etc). Feedback welcome! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #4 from Katrin Fischer --- I think this would still be very useful to have as I see no other option to limit ILL requests for patrons. By patron category should work for most libraries. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Martin Renvoize --- Awesome to see such an effort being undertaken :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #106287|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 106292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106292=edit Bug 25877: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. Test Plan: 1) Log in to Koha 2) Set your logged in branch to not be a pickup location 3) Attempt to place a hold 4) Note the error message 5) Apply this patch 6) Restart plack 7) Reload the page 8) Note the error is gone! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] ILL backends/plugins need hooks into checkin and checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19588] There is no ILL requests history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588 --- Comment #1 from Katrin Fischer --- I am starting to look at ILL things a bit more closely currently at the moment. There is also bug 23391 which makes me think that you can keep your closed or cancelled - so a real delete might make sense to fix mistakes that you really don't want to keep? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger changed: What|Removed |Added Attachment #103689|0 |1 is obsolete|| --- Comment #12 from Magnus Enger --- Created attachment 106291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106291=edit Bug 20517 - Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N2020042212430020200422124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe 2020-06-25: Pass an item to _get_sort_bin, not a checkout. Rebase. https://bugs.koha-community.org/show_bug.cgi?id=20571 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20571] Rancor - Keybinding configuration per users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20571 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20571] Rancor - Keybinding configuration per users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20571 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no Attachment #106290|0 |1 is obsolete|| --- Comment #2 from Magnus Enger --- Comment on attachment 106290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106290 Bug 20517 - Use the "sort bin" field in SIP2 Checkin Response Sorry, wrong bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20571] Rancor - Keybinding configuration per users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20571 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20571] Rancor - Keybinding configuration per users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20571 --- Comment #1 from Magnus Enger --- Created attachment 106290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106290=edit Bug 20517 - Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N2020042212430020200422124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe 2020-06-25: Pass an item to _get_sort_bin, not a checkout. Rebase. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24899] Reindent record matching rules template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24899 --- Comment #2 from Owen Leonard --- Created attachment 106289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106289=edit Bug 24899: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24899] Reindent record matching rules template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24899 --- Comment #1 from Owen Leonard --- Created attachment 106288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106288=edit Bug 24899: Reindent record matching rules template This patch reindents the template the record matching rules template. The only non-whitespace changes where lines were combined or split. The diff using the '-w' flag to ignore whitespace should highlight only moved lines. Test that functionality is unaffected: Administration -> Record matching rules. Test adding, editing, and deleting record matching rules. Test adding, editing, and deleting match points and match checks. Confirm that changes are saved correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24899] Reindent record matching rules template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24899 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #2 from Kyle M Hall --- I should note, this bug does not present in master. I think it was fixed by bug 22284 though I have not proven it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 --- Comment #1 from Kyle M Hall --- Created attachment 106287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106287=edit Bug 25877: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. Test Plan: 1) Log in to Koha 2) Set your logged in branch to not be a pickup location 3) Attempt to place a hold 4) Note the error message 5) Apply this patch 6) Restart plack 7) Reload the page 8) Note the error is gone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] New: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Bug ID: 25877 Summary: Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com On the staff side, if the librarian is logged in as a branch that is not a hold pickup location, that branch is still used as the default pickup location for the rules, resulting in the item not holdable reason libraryNotPickupLocation, while the pulldown shows the first branch that can actually be used as a pickup location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25877] Error libraryNotPickupLocation when placing a hold if logged in branchcode is not a pickup location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25876] New: 'Daily Quotes Test' failing randomly (?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25876
Bug ID: 25876
Summary: 'Daily Quotes Test' failing randomly (?)
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Test Suite
Assignee: ch...@bigballofwax.co.nz
Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Master_U16 #10
12:35:55 koha_1 | # Failed test 'Got a quote based on today's
date.'
12:35:55 koha_1 | # at t/db_dependent/Koha.t line 205.
12:35:55 koha_1 | # Compared $data->{"source"}
12:35:55 koha_1 | #got : 'Richard Nixon'
12:35:55 koha_1 | # expect : 'Abraham Lincoln'
12:35:55 koha_1 | # Be sure to run this test on a clean install of
sample data.
12:35:55 koha_1 | # Looks like you failed 1 test of 4.
12:35:55 koha_1 |
12:35:55 koha_1 | # Failed test 'Daily Quotes Test'
12:35:55 koha_1 | # at t/db_dependent/Koha.t line 213.
12:35:55 koha_1 | # Looks like you failed 1 test of 6.
12:35:55 koha_1 | [10:35:55] t/db_dependent/Koha.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25876] 'Daily Quotes Test' failing randomly (?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25876 Jonathan Druart changed: What|Removed |Added Blocks||25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart changed: What|Removed |Added Depends on||25876 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25876 [Bug 25876] 'Daily Quotes Test' failing randomly (?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 --- Comment #4 from Owen Leonard --- Created attachment 106286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106286=edit Bug 25875: Move check for module_bit and code to the JOIN If we limit the JOIN to rows with the correct subpermission we won't duplicate the returned patrons To test: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results 8 - Apply patch 9 - Restart all the things 10 - Repeat search 11 - Patron appears once Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 Owen Leonard changed: What|Removed |Added Attachment #106283|0 |1 is obsolete|| Attachment #106284|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 106285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106285=edit Bug 25875: Unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 --- Comment #19 from Jonathan Druart --- I confirm the patch works for me. However I am wondering if the flush should not happen in auth.tt instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 --- Comment #1 from Nick Clemens --- Created attachment 106283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106283=edit Bug 25875: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 --- Comment #2 from Nick Clemens --- Created attachment 106284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106284=edit Bug 25875: Move check for module_bit and code to the JOIN If we limit the JOIN to rows with the correct subpermission we won't duplicate the returned patrons To test: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results 8 - Apply patch 9 - Restart all the things 10 - Repeat search 11 - Patron appears once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user seaerch if they have multiple subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] New: Patron displayed multiple times in add user seaerch if they have multiple subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 Bug ID: 25875 Summary: Patron displayed multiple times in add user seaerch if they have multiple subpermissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts happen to be NULL instead of 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Jonathan Druart changed: What|Removed |Added Summary|Borrowers Login Attempts is |Borrowers Login Attempts |NULL|happen to be NULL instead ||of 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered on opac-detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25874] Explicit return of undef in C4/CourseReserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25874 Jonathan Druart changed: What|Removed |Added Depends on||23727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 [Bug 23727] Editing course reserve items is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23727] Editing course reserve items is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Jonathan Druart changed: What|Removed |Added Blocks||25874 --- Comment #60 from Jonathan Druart --- (In reply to Kyle M Hall from comment #58) > (In reply to Aleisha Amohia from comment #57) > > Hey Kyle, can you please take a look at Joy's comment above about qa tests > > so I can backport to 19.11.x? > > I believe you can safely ignore those errors. If we want to get pedantic, we > should probably fix the ProhibitExplicitReturnUndef warning on a new bug > report, as that same code is in master. I have opened bug 25874. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25874 [Bug 25874] Explicit return of undef in C4/CourseReserves.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25874] New: Explicit return of undef in C4/CourseReserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25874 Bug ID: 25874 Summary: Explicit return of undef in C4/CourseReserves.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org "return" statement with explicit "undef" at line 87, column 5. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25858] Borrower permissions are broken by update from bug 22868
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25858 didier changed: What|Removed |Added Attachment #106240|0 |1 is obsolete|| --- Comment #4 from didier --- Created attachment 106282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106282=edit Bug 25858: Don't attempt to set flag if already set Signed-off-by: Didier Gautheron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #75 from Jonathan Druart --- Are you willing to fix the alignment issue, Josef? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25858] Borrower permissions are broken by update from bug 22868
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25858 didier changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25858] Borrower permissions are broken by update from bug 22868
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25858 Nick Clemens changed: What|Removed |Added Priority|P5 - low|P1 - high --- Comment #3 from Nick Clemens --- (In reply to didier from comment #2) > Hi > > Why not use & | and ^ ? > > UPDATE borrowers SET flags = flags | (1<<12) WHERE flags & (1 << 11) > > Regards > Didier That is much more concise, I am not sure if it is clearer, but I am happy to have either solution, we just need to get this fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19036] Number payment receipts / payment slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 Martin Renvoize changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |testo...@bugs.koha-communit |.com|y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] Display patron age in useful places in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #74 from Josef Moravec --- (In reply to Jonathan Druart from comment #73) > There is a misalignment: https://snipboard.io/EqYJmM.jpg > > Why did you use the .label class for "Born"? I do not really remember that so probably we could remove it, if someone want to hide the word "Born" it is possible through the class added in last Katrin's follow-up (thanks for that!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
