[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #227 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #226)
> (In reply to Jonathan Druart from comment #225)
> > Tomas, with your patches we now have:
> >   biblio.deleted_on, biblio.deleted
> > and
> >   items.deleted_on, items.is_current
> > I think it's confusing.
> 
> Yes. I think is_current is an anomaly and shouldn't be the rule. But I
> wouldn't block this for that.

Can you explain? I think if possible we should be consistent, thinking of the
many report writeres out there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25803] Internet Explorer: unable to save patron edits or view patron checkouts

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25803

David Cook  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #6 from David Cook  ---
Ok looking at this again...

Using https://babeljs.io/, it's suggesting the following.

Replace:
$(`.guarantor-details[data-borrowernumber=${borrower.borrowernumber}]`).length;

With:
(".guarantor-details[data-borrowernumber=".concat(borrower.borrowernumber,
"]")).length;

However, I notice ./koha-tmpl/opac-tmpl/lib/kjua/lib/dom.js uses template
literals as well, and there might be other Javascript that does too. 

As Owen said, really there's no reason people should be using computers without
Edge, and Edge supports newer Javascript, so I think the best solution might
actually be to push back on Intranet users and advise that the Koha Intranet
isn't fully compatible with older browsers like IE 11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #68 from David Cook  ---
(In reply to David Cook from comment #67)
> Going to double-check but this might be broken in 19.11...

I must've been mistaken as it looks fine now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #36 from David Cook  ---
I've tested the new package in koha-testing-docker and it looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #35 from David Cook  ---
Mason announced 30 minutes ago on koha-devel that he's updated the
libjson-validator-perl package.

As per his email:

hi Folks
i've updated the 'libjson-validator-perl' package to include the cache dir

to update the package...
$ sudo apt update
$ sudo apt install libjson-validator-perl

run the following command, and confirm the result...
$ apt-cache policy  libjson-validator-perl
libjson-validator-perl:
   Installed: 3.06+dfsg-1+koha1
   Candidate: 3.06+dfsg-1+koha1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #34 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #33)

> Should we actually expect a significant number of instances to have more
> difficulty applying such a simple patch (just this patch, not updating Koha)
> compared to updating the perl deps?
> 
> The question is whether or not packaging libjson-validator-perl during some
> time is worth it. Not sure now.
> 
> Also, if http://swagger.io/v2/schema.json would work again tomorrow that
> would help letting those instances count on that until their next Koha
> update.

I'm curious about this as well. While we felt this in production in Australia,
I'm guessing the rest of the world might not feel it for another few hours.

I don't know where Jonathan is physically located these days, but I'm guessing
that we may have just missed him as well, so the Koha world is in for an
interesting day...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #33 from Victor Grousset/tuxayo  ---
It works! :D


(In reply to Victor Grousset/tuxayo from comment #30)
> Indeed, that way, deployers only have to update the perl-deps, no patch to
> apply.

Should we actually expect a significant number of instances to have more
difficulty applying such a simple patch (just this patch, not updating Koha)
compared to updating the perl deps?

The question is whether or not packaging libjson-validator-perl during some
time is worth it. Not sure now.

Also, if http://swagger.io/v2/schema.json would work again tomorrow that would
help letting those instances count on that until their next Koha update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25898] Prohibit indirect object notation

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
This is great to see, although also impossible to test?

I guess if we can get it into master ASAP though then there's a better chance
of any issues being caught early in this release cycle.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #106444|0   |1
is obsolete||

--- Comment #32 from Victor Grousset/tuxayo  ---
Created attachment 106445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106445=edit
Bug 23653: use local copy of swagger v2 schema

By default, JSON::Validator::OpenAPI tries to fetch the
swagger v2 schema from http://swagger.io/v2/schema.json.

If you've installed from CPAN, JSON::Validator::OpenAPI will
come with a cached copy, so it won't try to fetch it over HTTP.

However, if you've installed from libjson-validator-perl
from Debian/Ubuntu, the Debian package excludes the cached copy,
so JSON::Validator::OpenAPI tries to fetch it over HTTP.

Unfortunately, today and other days in the past, the file at
http://swagger.io/v2/schema.json has been unavailable, and this causes
Koha to crash in a perpetual loop.

This patch includes a copy of the swagger v2 schema, and it loads
it locally rather than fetching over HTTP.

The changes to Koha/REST/Plugin/PluginRoutes.pm are not required,
since the validator isn't currently called there, but I've added
a patch to future proof it.

To Test:
0a) Remove
/usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df
if it exists
0b) Block external access to http://swagger.io/v2/schema.json or
test during an outage when it's unavailable
0c) Do not apply patch
1) koha-plack --restart kohadev
2) Note that it crashes in a loop and is unavailable in web browser
3) Apply patch
4) koha-plack --restart kohadev
5) Note that Koha comes up and there are no errors in the Plack logs

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #26 from David Cook  ---
(In reply to Christopher Brannon from comment #17)
> "Not a priority for us"...who is "US"?

Ah, fair question! I  mean the vendor I work for Prosentient Systems and the
libraries that it supports. None of our libraries are signalling this as a
priority for us, so we're working on other things that are more important for
them. 

I should've been more precise with my language :).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #31 from David Cook  ---
Created attachment 106444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106444=edit
Bug 23653: use local copy of swagger v2 schema

By default, JSON::Validator::OpenAPI tries to fetch the
swagger v2 schema from http://swagger.io/v2/schema.json.

If you've installed from CPAN, JSON::Validator::OpenAPI will
come with a cached copy, so it won't try to fetch it over HTTP.

However, if you've installed from libjson-validator-perl
from Debian/Ubuntu, the Debian package excludes the cached copy,
so JSON::Validator::OpenAPI tries to fetch it over HTTP.

Unfortunately, today and other days in the past, the file at
http://swagger.io/v2/schema.json has been unavailable, and this causes
Koha to crash in a perpetual loop.

This patch includes a copy of the swagger v2 schema, and it loads
it locally rather than fetching over HTTP.

The changes to Koha/REST/Plugin/PluginRoutes.pm are not required,
since the validator isn't currently called there, but I've added
a patch to future proof it.

To Test:
0a) Remove
/usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df
if it exists
0b) Block external access to http://swagger.io/v2/schema.json or
test during an outage when it's unavailable
0c) Do not apply patch
1) koha-plack --restart kohadev
2) Note that it crashes in a loop and is unavailable in web browser
3) Apply patch
4) koha-plack --restart kohadev
5) Note that Koha comes up and there are no errors in the Plack logs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

David Cook  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #30 from Victor Grousset/tuxayo  ---
(In reply to Tomás Cohen Arazi from comment #23)
> We should just package the library with the correct cache

Indeed, that way, deployers only have to update the perl-deps, no patch to
apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #29 from David Cook  ---
Actually, it looks like Koha::REST::Plugin::PluginRoutes doesn't receive the
validator.

It looks like the OpenAPI plugin must be calling a validator and that's where
it's failing...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #27 from David Cook  ---
From what I can see, we're not actually validating the schema in
./Koha/REST/V1.pm when we use bundle(). 

We only validate it in ./Koha/REST/V1.pm when we do the catch{} block.

And we always validate ./Koha/REST/Plugin/PluginRoutes.pm.

Ok... yeah re-packaging libjson-validator-perl to include the "cache" probably
makes the most sense. 

I'm going to post a code-level patch anyway (partially just because I'm already
this far anyway)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #28 from David Cook  ---
(In reply to David Cook from comment #27)
> I'm going to post a code-level patch anyway (partially just because I'm
> already this far anyway)

Plus, if I do that, then we wouldn't have to maintain another custom package
dependency...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #26 from David Cook  ---
Oh wait I'm misunderstanding...

$validator->bundle is just loading the schema... and it doesn't validate it.

Whereas $validator->load_and_validate_schema loads the schema, but then
validates it against the Swagger 2.0 API schema. 

Wow, JSON::Validator really overloads the word "schema" in its code...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #25 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #23)
> (In reply to David Cook from comment #22)
> > I'm about to start on a patch for this. Hopefully will have something very
> > soon.
> 
> We should just package the library with the correct cache

Maybe. I think there is more to this than we think.

Consider ./Koha/REST/V1.pm:

$validator->bundle uses a schema of
$self->home->rel_file("api/v1/swagger/swagger.json"), which is a drastically
reduced schema file.

Calls to $validator->load_and_validate_schema (in ./Koha/REST/V1.pm and
./Koha/REST/Plugin/PluginRoutes.pm) don't use that same schema. They try to
fetch http://swagger.io/v2/schema.json.

The question I have is whether they should all be using
$self->home->rel_file("api/v1/swagger/swagger.json"), or if *some* calls should
use our local swagger.json and others should use the full swagger 2.0 schema.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #24 from David Cook  ---
Note that this should only affect plugin-enabled instances

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #23 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #22)
> I'm about to start on a patch for this. Hopefully will have something very
> soon.

We should just package the library with the correct cache

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #22 from David Cook  ---
I'm about to start on a patch for this. Hopefully will have something very
soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #21 from David Cook  ---
(In reply to Federico Paiz from comment #20)
> The same thing happened to me, I solved it by doing 
> 
> >cpan
> > install Mojolicious::Plugin::OpenAPI

Yeah, the CPAN version of that module comes with the "cache" which the Debian
package excludes, so you'll be fine with that. 

But it's a short-term solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

Federico Paiz  changed:

   What|Removed |Added

 CC||federicoantoniopaiz@gmail.c
   ||om

--- Comment #20 from Federico Paiz  ---
The same thing happened to me, I solved it by doing 

>cpan
> install Mojolicious::Plugin::OpenAPI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #19 from David Cook  ---
A solution to this problem is to provide our own argument "schema" argument to
the load_and_validate_schema() method. 

https://metacpan.org/pod/JSON::Validator#load_and_validate_schema

I've looked through the code and there's a variety of ways of providing the
schema, which we can source from
https://raw.githubusercontent.com/mojolicious/json-validator/3.06/lib/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df

I'd say we should provide it as a local file, so that we're not relying on any
web servers to provide this crucial file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

Hayley Mapley  changed:

   What|Removed |Added

   Severity|major   |blocker
 CC||hayleymap...@catalyst.net.n
   ||z

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #226 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #225)
> Tomas, with your patches we now have:
>   biblio.deleted_on, biblio.deleted
> and
>   items.deleted_on, items.is_current
> I think it's confusing.

Yes. I think is_current is an anomaly and shouldn't be the rule. But I wouldn't
block this for that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665

--- Comment #10 from Cori Lynn Arnold  ---
Hey Heather! I hear your frustration. One thing we did here to help was to
remove the "Control-C" from the default for our Koha installations (we have
over 20). To do that:

1. Go to the Advanced Editor
2. Click on the "Keyboard Shortcuts" button
3. Click on the link for "Refine shortcuts"
4. Either delete or redefine what is in that first box for "Copy current field"

If you don't have permissions to do that, talk to your Koha Admin. That was a
good start for us. Hope that helps.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #18 from Victor Grousset/tuxayo  ---
Issue reported to upstream's upstream:
https://github.com/swagger-api/swagger.io/issues/281

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #225 from Jonathan Druart  
---
Tomas, with your patches we now have:
  biblio.deleted_on, biblio.deleted
and
  items.deleted_on, items.is_current
I think it's confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17593] Extend circulation rules to include shelving location

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17593

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com,
   ||slavashish...@gmail.com,
   ||stalkern...@gmail.com
   Assignee|koha-b...@lists.koha-commun |nug...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25673] Access logging of borrower's personal information

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673

Andrew Nugged  changed:

   What|Removed |Added

 CC||nug...@gmail.com,
   ||slavashish...@gmail.com,
   ||stalkern...@gmail.com
   Assignee|koha-b...@lists.koha-commun |nug...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665

--- Comment #8 from Victor Grousset/tuxayo  ---
I don't manage to use Time::Fake ...

IIUC I should just replace this line:
https://gitlab.com/koha-community/Koha/-/blob/19.05.x/t/db_dependent/Circulation.t#L3100

By one of the following to decide the outcome of the test:
my $dt = dt_from_string("2020-06-02 19:05"); # should fail
my $dt = dt_from_string("2020-06-03 19:05"); # should work

But it has no effect, I can still only decide the outcome of the test using
system's time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690

Andrew Nugged  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |nug...@gmail.com
   |ity.org |
 CC||nug...@gmail.com,
   ||slavashish...@gmail.com,
   ||stalkern...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #25 from Victor Grousset/tuxayo  ---
Please double check, as a non-native speaker, misunderstandings are bound to
happen someday :)

(In reply to David Cook from comment #2)
> I noticed recently that "lastseen" updates for "Patron logs into OPAC" and
> "Patron is authenticated via SIP2" and that's it. I've had libraries
> interested in the field being updated for the other activities Nicole
> mentioned as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #24 from Victor Grousset/tuxayo  ---
(In reply to Christopher Brannon from comment #23)
> I must be missing something here.  Where is the information on patron logins
> to OPAC or authentication via SIP2 that isn't in a log?

borrowers.lastseen IIUC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665

--- Comment #9 from Heather  ---
I've run into another very typical example (especially lately) of when I want
to highlight & copy a portion of text while in the Advanced Biblio Editor--it's
for an online resource, and in the middle of editing the record I discover
something else that might need fixing/changing, so I want to look at the online
item, but I can't just highlight then copy just the link text under 19.11--I
can ctrl-shift-c to copy the entire subfield, but this only copies it into the
Koha clipboard (not the OS clipboard) unavailable for pasting into the OS
clipboard--plus it has a delimiter-u at the front of the URL.

I have to, e.g., use the mouse to select "View" to open the record in a new
browser tab, then use the mouse to select the "Online resources" link to open
the resource in yet another browser tab.

It would be faster for me to be able to go back to highlighting the URL while
in the record that I'm editing, ctrl-c (to copy to the OS clipboard), ctrl-t
for a new tab, ctrl-v to paste the URL from the OS clipboard and see the
resource.

So it's not just highlighting a subfield & bringing the subfield value that's a
problem--it's the ability that interacting with the OS clipboard has been
eliminated that's a big problem.  A cataloger in the Advanced Bib Editor needs
the ability to send *exactly what they want to* to the Koha clipboard and/or
the OS clipboard.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

ian.gor...@strath.ac.uk changed:

   What|Removed |Added

 CC||ian.gor...@strath.ac.uk

--- Comment #17 from ian.gor...@strath.ac.uk ---
Hi,

At about 21:00UTC today we also started to have this problem.

We're running 19.05.12 on Ubuntu 18.04.

The solution in comment 11 seems to work for now.

% pmvers JSON::Validator
1.08
% pmvers Mojolicious
7.59
% pmvers Mojolicious::Plugin::OpenAPI
1.15

Error message in plack-error.log is:

Error while loading /etc/koha/plack.psgi: Can't load application from file
"/usr/share/koha/api/v1/app.pl": [JSON::Validator] GET
http://swagger.io/v2/schema.json == Connect timeout at
/usr/share/perl5/JSON/Validator.pm line 274.
Compilation failed in require at (eval 389) line 1.

Regards,

Ian Gordon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25904] New: Enhancing patron attributes

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25904

Bug ID: 25904
   Summary: Enhancing patron attributes
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It would be great, if we could enhance patron attributes so that you could
record a piece of data for each patron, based on events.  For example, what if
you decide you want a timestamp for that last SIP login?  Or maybe you want to
know when they last logged into the OPAC.  It would also be great if there were
counters that could be associated with an event.  How many times has the patron
renewed their account, or how many times have they logged into SIP or the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #23 from Christopher Brannon  ---
I must be missing something here.  Where is the information on patron logins to
OPAC or authentication via SIP2 that isn't in a log?  I'm not sure what tables
I should be looking at for this information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #22 from Victor Grousset/tuxayo  ---
(In reply to Christopher Brannon from comment #21)
> (In reply to Victor Grousset/tuxayo from comment #20)
>  
> > (assuming SQL report are not enough?)
> 
> As was mentioned, pulling stuff from activity logs is hit or miss. 

I missed that part.
What do you mean by activity logs? The issues and old_issues tables?

Because if I understand correctly, the following data is in the above tables +
borrowers.lastseen

> Patron checks out item
> Patron renews an item
> Patron returns an item
> Patron is authenticated via SIP2
> Patron logs into OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24862] Wrong behaviour on anonymous sessions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24862

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable
 CC||vic...@tuxayo.net
 Version(s)|20.05.00, 19.11.07  |20.05.00, 19.11.07,
released in||19.05.13

--- Comment #10 from Victor Grousset/tuxayo  ---
Backported to 19.05.x branch for 19.05.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25902] Export MARC records for all titles in a virtual shelf

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25902

--- Comment #4 from Andrew Fuerste-Henry  ---
Adding lists to our export options at the command line would also be an added
functionality, though I don't have an immediate use case.
There's also value in standardizing functionality across the various tools,
just from a user perspective. I might not be the only person to look at the
export screen and erroneously conclude that Koha can't do what I'm looking for.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #21 from Christopher Brannon  ---
(In reply to Victor Grousset/tuxayo from comment #20)

> (assuming SQL report are not enough?)

As was mentioned, pulling stuff from activity logs is hit or miss.  Depending
on how often information is purged, you won't get very accurate results.  This
is data that is best recorded in the patron record or related table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #20 from Victor Grousset/tuxayo  ---
(In reply to Christopher Brannon from comment #17)
> The link to dev list is a dead link.

http://devs.bywatersolutions.com/projects/track-patrons-last-activity/ isn't
the dev list. It was a page ByWater Solutions had on this topic.


The mailing lists are here:

https://koha-community.org/support/koha-mailing-lists/

«General List» and «Koha Developers List» seems to me the good ones to seek
organizations to cosponsor or/and to contract to work on this.

(assuming SQL report are not enough?)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Christopher Brannon  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #19 from Christopher Brannon  ---
Test passes, and everything works according to the test.  Let's discuss the
following issues before I sign off, since we are funding this project:

* When you update priority in the item (yes/no), there is nothing that
indicates that it is done or set.  It would be helpful if there was something
that appeared to indicate that it took.  Maybe (SET/UNSET) next to the dropbox?

* The patron exclusion seems to be in an uncommon place.  Technically, it makes
sense to have this in the patron category, but usually these kinds of
conditions are setup in the preferences.pl.  I state this, because if we do
some forward thinking here, if we want to do other exclusions in the future, it
might be better to set this as a textbox pref, where you would set this
exclusion with a patroncategory: PT, and then in the future we could exclude by
itemtype, collectioncode, or other ways.  It just makes sense to keep the
exclusions all in one place rather than spread out everywhere.  And if you do
this, could biblio or barcode/itemnumber be set here as well, rather than in
the item record itself?

* A couple of the criteria we had asked for in the exclusions was item types
and formats.  Those were not addressed in these patches.  I would be willing to
forget about formats at this point, but would like to see item types.  I am
kicking myself for not including biblio in possible exclusions.  As is, we have
to exclude individual items.  If that can be added easily, great.  If not, at
least the item types needs to be, since it was in the original request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25903] Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25903

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25903] Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25903

--- Comment #1 from Kyle M Hall  ---
Created attachment 106443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106443=edit
Bug 25903: Sending a SIP patron information request with a summary field flag
in indexes 6-9 will crash server

The 'summary' field in the patron information request specifies if detail
information should be send for holds, overdues, fines, etc. The field is 10
characters in length (0-9). However, the SIP2 spec only defines indexes 0
though 5, leave 6 though 9 undefined. Some ILSs specify behavior for these
undefined indexes. Apparently the 7th field is often used to request 'Fees', as
opposed to 'Fines' in some ILS. Some software that integrate via SIP try both
the 5th and 7th indexes to ensure they get all fines and fees.

The problem is that Koha's SIP server crashes if any 'summary' index beyond 5
is flagged. We should simply ignore flags beyond 5 and act as if no flags were
sent.

Test Plan:
1) Enable SIP for your instance
2) Send a patron information request with a summary flag in any index beyond 5.
   i.e.: 6300120200617124846  Y   AOMIDAY|AA21030050054321
3) Note the SIP server just closes the connection without a response
4) Apply this patch
5) Restart the SIP server
6) Send the same request
7) Note you get back the patron information response!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #106438|0   |1
is obsolete||

--- Comment #18 from ByWater Sandboxes  ---
Created attachment 106442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106442=edit
Bug 19889: Make it possible to exclude items and categories from local holds
priority

This patch adds the ability to exclude patrons (by category) from local
holds, and items, by editing the item itself or by batch item
modification tool.

To test:
1. apply patches
2. updatedatabase
3. Enable LocalHoldsPriority preference, and leave
   LocalHoldsPriorityPatronControl in pickup library, and
LocalHoldsPriorityItemControl in holding library.
4. Search for a biblio with one item.
5. Place a hold with a patron (patron1) and set pickup location to a different
   library of the item's home library
6. Place another hold with another patron (patron2) and set pickup location to
be
   the same as the item's home library
7. ./misc/cronjobs/holds/build_holds_queue.pl
8. Go to circulation -> holds queue
9. Search by the item's home library
CHECK => only the hold for patron2 (with the pickup location the same as the
item's home library) appears in the table
10. Go back to the biblio details page and click on "Items" tab
CHECK => There is a new section in the item's details between "Statuses"
and "History" called "Priority"
11. Set exclude to "Yes" and update
12. repeat steps 7 to 9
SUCCESS => only the hold for patron1 now appears, even the other hold had local
hold priority
13. Repeat step 10 and 11 but this time set exclude to "No"
14. repeat steps 7 to 9
CHECK => the hold for patron2 is back
15. Edit patron2's category and set exclude from local holds priority to
"Yes"
16. Repeat steps 7 to 9
SUCCESS => the hold for patron1 is back
17. Go to tools -> Batch item modification and in barcode list place
several (existing) barcodes and press continue
CHECK => There is a new section in the bottom called "Priority"
18. Set exclude to "Yes" and save
SUCCESS => all items in the list now have exclude setted to "Yes"
19. Try to checkout the first item to a patron3
SUCCESS => Alert message appears saying that patron1 has a hold on that
item
20. Click on Yes and then checkin that item
SUCCESS => There is a modal window saying that a hold was found for
patron1
21. prove t/db_dependent/HoldsQueue.t t/db_dependent/Holds/LocalHoldsPriority.t
22. Sign off

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #106435|0   |1
is obsolete||

--- Comment #15 from ByWater Sandboxes  ---
Created attachment 106439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106439=edit
Bug 19889: Add exclude_from_local_holds_priority columns to item, deleteditems
and categories tables

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #106437|0   |1
is obsolete||

--- Comment #17 from ByWater Sandboxes  ---
Created attachment 106441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106441=edit
Bug 19889: Add tests

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #106436|0   |1
is obsolete||

--- Comment #16 from ByWater Sandboxes  ---
Created attachment 106440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106440=edit
Bug 19889: set exclude_from_local_holds_priority columns as boolean in schema

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25903] New: Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25903

Bug ID: 25903
   Summary: Sending a SIP patron information request with a
summary field flag in indexes 6-9 will crash server
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

The 'summary' field in the patron information request specifies if detail
information should be send for holds, overdues, fines, etc. The field is 10
characters in length (0-9). However, the SIP2 spec only defines indexes 0
though 5, leave 6 though 9 undefined. Some ILSs specify behavior for these
undefined indexes. Apparently the 7th field is often used to request 'Fees', as
opposed to 'Fines' in some ILS. Some software that integrate via SIP try both
the 5th and 7th indexes to ensure they get all fines and fees.

The problem is that Koha's SIP server crashes if any 'summary' index beyond 5
is flagged. We should simply ignore flags beyond 5 and act as if no flags were
sent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25903] Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25903

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23390] Add placeholder syntax for column names

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390

--- Comment #19 from Katrin Fischer  ---
*** Bug 22167 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22167] Allow itemnumber column to be labelled differently when using batch item edit feature

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22167

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #1)
> duplicate of 23390?

I believe you are correct :) I just showed this feature to the coworkers btw -
we like it!

*** This bug has been marked as a duplicate of bug 23390 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25902] Export MARC records for all titles in a virtual shelf

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25902

--- Comment #3 from Katrin Fischer  ---
I think the export tool provides some more functionality like being able to
remove fields from the export. So that's what got me wondering.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to Fridolin SOMERS from comment #4)
> Looks like its related to Bug 19261
> 
> > I will add a 'deny_list'
> where ? in DB ?

On ViewPolicy.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25902] Export MARC records for all titles in a virtual shelf

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25902

--- Comment #2 from Andrew Fuerste-Henry  ---
Uhoh. Honestly, because I didn't think of the download option from the list
interface. I'll have to poke at that and see if there's any functional
difference between the two.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #14 from Agustín Moyano  ---
(In reply to Christopher Brannon from comment #9)
> Agustin, Kidclamp had to rebase a minor conflict.  I don't know the details.
> 
> After that, this is what I found:
> 
> Everything works except the Batch Item Modification.  It did not change the
> setting for the items specified.  Might be because of the rebase.  Please
> check.
> 
> Also, the description on the patron category is confusing.  It should read
> "If Yes, holds placed by patrons of this category will not be given
> priority."
> 
> I am also unable to prove the test, step 21.  I am testing from a sandbox.

Hello Christopher, I just updated and rebased this patches.

About the description you're right.. at first I understood patron's category
exclusion backwards (as if you would exclude the patron that couldn't get the
item because of localholdspriority), but later coded things right, and that
description remained wrong.

Please test again.

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #12 from Agustín Moyano  ---
Created attachment 106437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106437=edit
Bug 19889: Add tests

Sponsored-by: Cooperative Information Network (CIN)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #13 from Agustín Moyano  ---
Created attachment 106438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106438=edit
Bug 19889: Make it possible to exclude items and categories from local holds
priority

This patch adds the ability to exclude patrons (by category) from local
holds, and items, by editing the item itself or by batch item
modification tool.

To test:
1. apply patches
2. updatedatabase
3. Enable LocalHoldsPriority preference, and leave
   LocalHoldsPriorityPatronControl in pickup library, and
LocalHoldsPriorityItemControl in holding library.
4. Search for a biblio with one item.
5. Place a hold with a patron (patron1) and set pickup location to a different
   library of the item's home library
6. Place another hold with another patron (patron2) and set pickup location to
be
   the same as the item's home library
7. ./misc/cronjobs/holds/build_holds_queue.pl
8. Go to circulation -> holds queue
9. Search by the item's home library
CHECK => only the hold for patron2 (with the pickup location the same as the
item's home library) appears in the table
10. Go back to the biblio details page and click on "Items" tab
CHECK => There is a new section in the item's details between "Statuses"
and "History" called "Priority"
11. Set exclude to "Yes" and update
12. repeat steps 7 to 9
SUCCESS => only the hold for patron1 now appears, even the other hold had local
hold priority
13. Repeat step 10 and 11 but this time set exclude to "No"
14. repeat steps 7 to 9
CHECK => the hold for patron2 is back
15. Edit patron2's category and set exclude from local holds priority to
"Yes"
16. Repeat steps 7 to 9
SUCCESS => the hold for patron1 is back
17. Go to tools -> Batch item modification and in barcode list place
several (existing) barcodes and press continue
CHECK => There is a new section in the bottom called "Priority"
18. Set exclude to "Yes" and save
SUCCESS => all items in the list now have exclude setted to "Yes"
19. Try to checkout the first item to a patron3
SUCCESS => Alert message appears saying that patron1 has a hold on that
item
20. Click on Yes and then checkin that item
SUCCESS => There is a modal window saying that a hold was found for
patron1
21. prove t/db_dependent/HoldsQueue.t t/db_dependent/Holds/LocalHoldsPriority.t
22. Sign off

Sponsored-by: Cooperative Information Network (CIN)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #11 from Agustín Moyano  ---
Created attachment 106436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106436=edit
Bug 19889: set exclude_from_local_holds_priority columns as boolean in schema

Sponsored-by: Cooperative Information Network (CIN)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #105715|0   |1
is obsolete||
 Attachment #105716|0   |1
is obsolete||
 Attachment #105717|0   |1
is obsolete||
 Attachment #105718|0   |1
is obsolete||

--- Comment #10 from Agustín Moyano  ---
Created attachment 106435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106435=edit
Bug 19889: Add exclude_from_local_holds_priority columns to item, deleteditems
and categories tables

Sponsored-by: Cooperative Information Network (CIN)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25902] Export MARC records for all titles in a virtual shelf

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25902

--- Comment #1 from Katrin Fischer  ---
Hi Andrew, this sounds interesting. Can you explain why the export tool instead
of the download option? Wondering about the use case as always :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25898] Prohibit indirect object notation

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898

--- Comment #2 from Katrin Fischer  ---
Would it make sense to create a Perl 7 Omnibus bug we can use for these?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24001] Cannot edit card template

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001

Blou  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24001] Cannot edit card template

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001

Blou  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com
  Attachment #95981|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24001] Cannot edit card template

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001

Blou  changed:

   What|Removed |Added

  Attachment #99164|0   |1
is obsolete||

--- Comment #38 from Blou  ---
Created attachment 106434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106434=edit
Bug 24001: Fix patron card template edition

Error when saving Patron card Template:
Can't bless non-reference value at
/home/vagrant/kohaclone/C4/Creators/Profile.pm line 89

This is caused by the profile dropdown offering invalid choices and is
fixed by adding a filter to limit options to creator = 'Patroncards'.
The UI already handles the case where no valid profile is avaiable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

Martin Renvoize  changed:

   What|Removed |Added

Version|19.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25902] New: Export MARC records for all titles in a virtual shelf

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25902

Bug ID: 25902
   Summary: Export MARC records for all titles in a virtual shelf
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

We let user-defined lists / virtual shelves be used to select bibs for record
deletion and modification. It would be nice to be able to use a list to export
records, too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #19 from Agnes Rivers-Moore  ---
(In reply to Martha Fuerst from comment #18)
> Chiming in again.
> 
> This is ESPECIALLY important for us now, with COVID-19 and social distancing
> procedures, we have more people using 100% online resources - and people who
> have gotten cards using online registration, verified via email, to use
> those resources.
> 
> Tracking last patron activity via SIP2/OPAC login is definitely a priority
> for US at Huntsville-Madison County.
> 
> Best,
> 
> -Marti Fuerst

+1 - COVID-19 has certainly increased the urgency on this!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #18 from Martha Fuerst  ---
Chiming in again.

This is ESPECIALLY important for us now, with COVID-19 and social distancing
procedures, we have more people using 100% online resources - and people who
have gotten cards using online registration, verified via email, to use those
resources.

Tracking last patron activity via SIP2/OPAC login is definitely a priority for
US at Huntsville-Madison County.

Best,

-Marti Fuerst

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #1 from Lisette Scheer  ---
Yes, we would like this as well!
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #224 from Tomás Cohen Arazi  ---
I submitted my work to the mentioned branch [1]

What I tested was:
- Do a reset_all on master
- Run updatedatabase on that branch
- Tested adding biblios/items and deleting them works without changes.
- Rebuilding zebra
- Tests need to pass

I fixed the API so it acknowledges the new deleted_on and deleted fields.
Fetching items should keep the current behaviour (no deleted items retrieved by
default, we could add the feature later if we wanted to be able to retrieve
them).

I noticed we merge the tables and now have a WHERE condition all over the
place, that has an impact on performance, unless we have an index for the
compared columns. As we are not making real use of the date the record was
deleted, I made sure the index is created against a boolean (size, probably
speed) so I changed all item-related queries to do

items.is_current=1 instead of items.deleted_on IS NULL
items.is_current=0 instead of items.deleted_on IS NOT NULL

and for biblios:

biblio.deleted=0 instead of biblio.deleted_on IS NULL
biblio.deleted=1 instead of biblio.deleted_on IS NOT NULL

I put my signature on this patchset as-is, but am still checking the atomic
update edge cases.

[1] https://gitlab.com/thekesolutions/Koha/-/commits/qa_20271

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25827] Add floating toolbar to the holds summary page in staff interface

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827

--- Comment #5 from Christopher Brannon  ---
(In reply to Owen Leonard from comment #4)
> Looks like it works in Firefox bug not Chrome.

I can confirm I did my test in Chrome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15504] Track Patron's Last Activity

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #17 from Christopher Brannon  ---
(In reply to David Cook from comment #15)
> (In reply to Christopher Brannon from comment #13)
> > Folks, this is a rather important issue.  Would love to see this progress
> > beyond 4 years of rare discussion.  :D
> 
> I agree that it's important, but it's not a priority for us at this time.
> 
> I notice this issue is marked as "Seeking cosponsors". It might be
> worthwhile to send an email to the koha-devel list to see if someone wants
> to work on it, or if you have funds - look to hire someone to do the work.

The link to dev list is a dead link.

"Not a priority for us"...who is "US"?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #106415|0   |1
is obsolete||

--- Comment #2 from Andrew Fuerste-Henry  ---
Created attachment 106433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106433=edit
Bug 25893: Use wildcards when searching logs

The restores the wildcards that were used in the past

I also clean up a few warns and unused param

To test:
 0 - Ensure cataloguing logs and issues logs are enabled
 1 - Edit an item
 2 - Circulate that same item
 3 - Browse to tools-> log viewer
 4 - Put the itemnumber in the 'info' box
 5 - You see only the circulation
 6 - Put the itemnumber in the object box
 7 - You see only the cataloging modification
 8 - Apply patch
 9 - Put itemnumber in info box
10 - you see both actions
11 - Put the itemnumber in the object box
12 - You see only the catalogiong modification

Signed-off-by: Jason Robb 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25733

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25901] New: Add option for ClaimsReturnedWarningThreshold to count only unresolved claims

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901

Bug ID: 25901
   Summary: Add option for ClaimsReturnedWarningThreshold to count
only unresolved claims
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Coming out of conversation on bug 25733, some libraries would like this
threshold to only count claims that have not been resolved. I think this will
need to be another syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25733] Return claims attention can't be cleared

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25901

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 106432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106432=edit
Bug 25900: trim spaces in search with Zebra and QueryWeightFields

Search with Zebra and system preference QueryWeightFields on builds a query
with surrounding double quotes : q=tree => q="tree". Therefore existing double
quotes are replaced by a space : q="tree" => q=" tree ".
Looks like the leading space breaks the search, 0 results.
Experimented on Ubuntu Xenial and Bionic with Indexdata repository so Zebra
version is 2.1.4. It might be specific to this version.

Patch corrects by adding trim on operand after transforming quotes into spaces.

Test plan :
1) Use Zebra searchengine and enable system preference QueryWeightFields
2) Go to advanced search
3) Search on title two words you know exists in title surrounded by double
quotes, like "Order of the Phoenix"
4) With patch you get results, no results without patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25827] Add floating toolbar to the holds summary page in staff interface

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827

--- Comment #4 from Owen Leonard  ---
Looks like it works in Firefox bug not Chrome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #498 from Owen Leonard  ---
I ran into a problem at step 70, checking in a recalled item which requires a
transfer and clicking "confirm recall and transfer." The dialog disappears as
expected but then I'm shown another modal, the regular transfer dialog which is
shown when an item is checked in at the wrong branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22167] Allow itemnumber column to be labelled differently when using batch item edit feature

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22167

--- Comment #1 from Nick Clemens  ---
duplicate of 23390?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25900] New: Double quotes breaks search with Zebra and QueryWeightFields

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900

Bug ID: 25900
   Summary: Double quotes breaks search with Zebra and
QueryWeightFields
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Zebra
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com

Search with Zebra and system preference QueryWeightFields on builds a query
with surrounding double quotes : q=tree => q="tree". Therefore existing double
quotes are replaced by a space : q="tree" => q=" tree ".
Looks like the leading space breaks the search, 0 results.
Experimented on Ubuntu Xenial and Bionic with Indexdata repository so Zebra
version is 2.1.4. It might be specific to this version.

You can reproduce with direct CCL query (regardless QueryWeightFields) :
https://demo.biblibre.com/cgi-bin/koha/opac-search.pl?idx==ccl%3Dti%2Cphr%3D%22centre+arch%C3%A9ologique%22
https://demo.biblibre.com/cgi-bin/koha/opac-search.pl?idx==ccl%3Dti%2Cphr%3D%22+centre+arch%C3%A9ologique%22

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #106324|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 106431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106431=edit
Bug 25851: (bug 18928 follow-up) Remove holdallowed rule is value is an empty
string

On the interface, if "Hold policy" is "Not set", the rule does not exist
in the table. We should reflect that during the update DB process.

Test plan:
1. Set "Hold policy" to "Not set"
2. Confirm that you can place holds
3. Confirm that the rule does not exist in the DB table
4. Set the value to an empty string (manually)
5. Confirm that you cannot longer place holds
6. Go to the circulation rules page and confirm that the value of "Hold
policy" is "Not set"
7. Execute the update DB entry
8. Confirm that you can place holds
9. Confirm that the rule does not exist in the DB table

Signed-off-by: Martin Renvoize 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24006] Switching on QueryWeightFields (relevance ranking) breaks search

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24006

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #2 from Fridolin SOMERS  ---
(In reply to Bernard from comment #0)
> eg/ using simple search in OPAC
> 
> QueryWeightFields (enabled)
> 
> flute AND oboe = 701
> flute OR oboe = 115
> flute NOT oboe = 10
> 
> QueryWeightFields (disabled)
> 
> flute AND oboe = 1038
> flute OR oboe = 3983
> flute NOT oboe = 2121
> 
> The results from the "disabled" look correct but of course there is no
> longer any relevance ranking.

With QueryWeightFields on, boolean are considered like string, on purpose.
The search terms are around quotes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #223 from Tomás Cohen Arazi  ---
I'm working on a performance improvement. Gimme one hour or so to submit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25799] Edition information to Holds queue report

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #5 from Katrin Fischer  ---
(In reply to Peter Vashchuk from comment #4)
> (In reply to Katrin Fischer from comment #1)
> > 
> > *** This bug has been marked as a duplicate of bug 25699 ***
> 
> Katrin, please review your decision - this is definitely not a duplicate,
> it's about same information to be displayed but in different report page.
> 
> Can I change the status of this ticket to "need signoff"?

Hi Andrew amd Peter, I am human, I make mistakes - in this case, I read to
quickly and missed the difference in wording. It's completely ok to correct me!
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

--- Comment #5 from Katrin Fischer  ---
(In reply to Magnus Enger from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > I wonder, if you are still around for this Magnus?
> 
> I am on holiday now, so I will probably not be able to look at it before
> August.

That's a little late for us :(

Would you mind me tinkering with that a bit?

I've been wondering about taking a different approach here and adding the
itemnumber to the illrequest table as linking by biblionumber and
borrowernumber seems not ideal. Would this work for you?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25899] Sorting by date

2020-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25899

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---
This sounds like a support request rather than a bug.

Questions about Koha should be asked on the Koha mailing list
(http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC
channel (http://koha-community.org/get-involved/irc/).

Hopefully you've already seen the Koha documentation:
http://koha-community.org/documentation/

You can also find options for paid support here:
https://koha-community.org/support/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >