date:20200707

[Koha-bugs] [Bug 25949] Date and time displaying AM when it should show PM

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25949

David Cook  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25949] Date and time displaying AM when it should show PM

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25949

--- Comment #2 from David Cook  ---
I tried to reproduce this in koha-testing-docker but I couldn't...

I'm just noticing it on normal 19.11 instances...

From a code perspective, they look the same. I have no idea why this is only
happening on Debian Stretch with 19.11 and OpenSuse with 19.11. 

But I guess for now I'll just close it

Test Plan:

1. Set TimeFormat to "12 hour format"
2. Set timezone in koha-conf.xml to a timezone that should be currently in the
PM
3. restart_all (in koha-testing-docker)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25949] Date and time displaying AM when it should show PM

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25949

--- Comment #1 from David Cook  ---
Note so far I've only tested this with an undefined timezone but I doubt it's
relevant

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25949] Date and time displaying AM when it should show PM

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25949

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25949] New: Date and time displaying AM when it should show PM

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25949

Bug ID: 25949
   Summary: Date and time displaying AM when it should show PM
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: About
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

When TimeFormat is 12 hours, 07/08/2020 03:23 AM is being shown instead of
07/08/2020 03:23 PM.

At a glance, it's because we use output_pref both in about.pl and about.tt and
it's getting confused.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions.

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25712] Add plugin hooks to transform patron and item barcodes

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25947] Improve locked account message

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
I don't 100% understand these comments. 

I think that I agree that the Staff Client could be more descriptive about why
the account is locked.

As for the OPAC, we shouldn't indicate that the account has been locked, as
that indicates to an attacker that the account exists, which is not a good idea
from a security perspective.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6815] Capture member photo via webcam

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #42 from M. Tompsett  ---
I see the attempt to javascript the picture up, but it is failing, because the
click() hijacks and returns, never to run the ajaxiness. I have an idea...
perhaps I'll play with it a bit this week. It would be nice to solve a 4 digit
bugzilla. Sorry I have been distracted with other projects lately. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25948] Clean up apache protocols and ciphers

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25948

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
It's great to see some updates here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25948] Clean up apache protocols and ciphers

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25948

--- Comment #2 from David Cook  ---
Comment on attachment 106645
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106645
Bug 25948: Clean up apache-site-https a little

Review of attachment 106645:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=25948=106645)
-

::: debian/templates/apache-site-https.conf.in
@@ +12,4 @@
>  # OPAC
>   #https
>  #  SSLEngine on
> +#  SSLProtocol -all +TLSv1.2 +TLSv1.1

TLSv1.1 is deprecated now too

Should include +TLSv1.3

@@ +39,4 @@
>  # Intranet
>   #https
>  #  SSLEngine on
> +#  SSLProtocol -all +TLSv1.2 +TLSv1.1

TLSv1.1 is deprecated now too

Should include +TLSv1.3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #58 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #57)
> Ticket opened upstream (Debian) to have the cache (not really cache) files
> included in the package.
> As upstream's(Debian) upstream's(json-validator) upstream (OpenAPI/Swagger)
> confirmed the license of these files.
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964496

Nice one, Victor!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #17 from David Cook  ---
(In reply to Marcel de Rooy from comment #15)
> What is the right moment for a biblio record to receive a persistent
> identifier btw? Thinking about local procedures around acquisition etc.
> 
> The choice in this patch set is still influenced by the partial/meta
> resolving (see former comments). A replace by Z3950/SRU might result in two
> PIDs in the authoritative table and one local copy (the newest) in Koha.

That's an interesting question. In my mind, a biblionumber represents a
conceptual metadata entity. While the actual metadata can change, that entity
is tied to the point in time that the biblionumber is created. While we use the
MySQL/MariaDB autonumber for that at the moment, in theory we could use a UUID
or some other generated number (like we do for the item barcode rather than the
item number).

For me, the MARCXML isn't the bibliographic record, but rather a view of it. In
the future, that bibliographic record might have a RDF/XML view as well.
They're both describing the same bibliographic entity, and that entity is the
thing that should have the PID. After all, HTML, MARCXML, RDF/XML, they're just
different content types available via content negotiation, right?

The replacement by Z3950/SRU is interesting. If we had versioned records, it
might make sense to have a PID per version I suppose...

It could be interesting to see how DSpace manages this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #16 from David Cook  ---
(In reply to Marcel de Rooy from comment #13)
> See also comment9. I chose here to not add stuff directly to core Koha
> routines. But work my way thru the data with a cron job. Surely this would
> be a next step. Problem with a cataloguing plugin is that you just know the
> record number only after saving  it. Although a PID generator might
> theoretically not need it, many implementations, including my own, do use it.
> 

I could see the utility of that cronjob for you, but maybe not for all Koha
users?

That's a good point about the PID generator. 

> Not sure how much you saw from the patches, but this patch set provides an
> interface via plugins to an external PID service.
> 

I skimmed through that code, but found it a bit difficult to read.

> No Koha should not mint its own PIDs. 

Ok excellent.

> Formally the PID generator
> may have its own PID lookup table. We do not really care here. (My local
> generator does not, since it is based on a Koha identifier. Its result can
> be found with a Standard-identifier index in Koha or even another future
> ILS. In that way actually turning my ES or Zebra index into a PID lookup
> table..)

I'm not sure that I understand this part. 

So you use the Koha identifier to mint a PID with a local non-Koha generator,
then you store that in the Koha record and index it. 

Your organisation resolver then forward to a local non-Koha resolver which then
queries Zebra/ES to get the record that matches... I assume not a full URL but
a partial path?

> But even with a full resolver having its own table, I would still argue to
> save a copy of the PID in the MARC record too for optimization, while
> respecting the lookup table as authoritative.
> As a side note: Could you give me another example of vital data on biblio
> level that we do not store in MARC? Not meaning optimization or calculated
> aggregates etc.

I don't know what you mean by "vital data" in this case, but some standouts are
biblio.frameworkcode, biblio.datecreated (debateable), biblio_metadata.format,
biblio_metadata.schema. 

To be honest, I think that I see where you're coming from. In the past, I
wanted to store OAI-PMH identifiers in the 024 field for imported MARC
bibliographic records and then look them up with a Zebra index search, but then
I realized was problematic for me. While those MARC fields exist, the data in
those fields aren't descriptive metadata about the record. They're metadata
about the metadata record. In my case, I ended up putting the OAI-PMH
identifier in the relational database, as it was much more robust than putting
it in the MARC record and indexing it into Zebra (especially since there can be
a lag for index updates).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #20 from David Cook  ---
(In reply to Marcel de Rooy from comment #19)
> Yes, the landing page of the item persistent identifier (URL) is not that
> important, but I do want to be able to dereference it. Including an HTML
> representation when that would be the result of content negotiation. But
> surely the main thing is a unique resource identifier in the form of a URL. 
> 

Cool. That sounds good to me.

> We will be using something like https://id.rijksmuseum.nl/3012345
> Our institutional PID resolver knows (as a partial or meta resolver) how to
> pass library PIDs to the library PID resolver. Which would use opac-detail
> for HTML in case of a biblio or item.

Could you explain this part a bit more? Is the idea that you'll mint
institution level PIDs (like https://id.rijksmuseum.nl/3012345) and those will
resolve to Koha PIDs/URLs?

That would be cool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25934] RequireStrongPassword should be more complex (password policy complexity)

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25934

--- Comment #5 from David Cook  ---
(In reply to Katrin Fischer from comment #3)
> I think a stronger default for new installations should be agreeable, but we
> can't change behaviour for existing ones.

That's a good point, although it would be good to force users to change their
passwords after policy changes. So libraries with knowledgeable administrators
could update their existing installations to more secure settings. 

(In reply to George Williams (NEKLS) from comment #4)

Those are interesting points. 

From my perspective as a vendor/sysadmin, I'd prefer to mandate strong security
across the board to give the library the best protection. But from the library
perspective, I can understand wanting flexibility. 

From the vendor perspective, so long as there isn't a bug that can compromise
the underlying server, then I suppose the onus is on the library to manage
their own application security settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6815] Capture member photo via webcam

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

--- Comment #41 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #40)
> It does not work for me/my webcam:
> * Firefox:
> I see "Take", but then the modal displays with "No permission to use camera"
> in an alert. If I close it, I see the "Take the patron's picture" button in
> the modal, but it generates a black picture.
> 
> * Chromium: No "Take"
> 
> 
> The browsers does not ask me if I want to allow the webcam for this page.
> 
> The webcam seems to work with cheese and hangout.

Greetings.

I ran in Chrome (Version 83.0.4103.116 (Official Build) (64-bit) on Ubuntu
20.04 LTS vagrant up'd to stretch and accessed by localhost:8081), and it
worked just fine.
I then run in Chromium (Version 81.0.4044.138 (Official Build) Built on Ubuntu
, running on Ubuntu 20.04 (64-bit) same localhost:8081), without closing the
Chrome, and it gave me the error you got in Firefox. Once I closed Chrome, and
retried in Chromium, it worked.

It worked for me in Opera (69.0.3686.49) too.

I even tried firefox (78.0.1 (64-bit)). And while it was much noisier (Are you
sure you want permissions for this? Really? What about this?), it worked for me
too.

Did you have cheese and hangout open when you tested this? I think there may be
some "Give me exclusive control!" type issues between the various programs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653

--- Comment #57 from Victor Grousset/tuxayo  ---
Ticket opened upstream (Debian) to have the cache (not really cache) files
included in the package.
As upstream's(Debian) upstream's(json-validator) upstream (OpenAPI/Swagger)
confirmed the license of these files.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964496

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946

--- Comment #2 from Owen Leonard  ---
(In reply to David Roberts from comment #1)
> I can't think of a reason why you would want to leave this empty

It's not unreasonable to think that a library might not want to or care about
storing the relationship information.

But the bottom line is that the system preference can be empty so we should
expect that it might be empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946

--- Comment #1 from David Roberts  ---
I can't think of a reason why you would want to leave this empty - if the
patron has a guarantor then they automatically must have some sort of
relationship with the guarantee, even if it isn't a familial one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #241 from Victor Grousset/tuxayo  ---
with koha-testing-docker (images up to date, including DB and ES)


Debian 9 with MariaDB 10.1
Debian 10 with MariaDB 10.3 (and ES 6 in case that matters)

prove t/db_dependent/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25948] Clean up apache protocols and ciphers

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25948

M. Tompsett  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com
   |ity.org |
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25948] Clean up apache protocols and ciphers

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25948

--- Comment #1 from M. Tompsett  ---
Created attachment 106645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106645=edit
Bug 25948: Clean up apache-site-https a little

- removed ECDHE-RSA-AES256-SHA384, as it downgrades to CBC use
  https://ciphersuite.info/cs/TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384/
- added DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256
- added ECDHE-ECDSA-AES256-SHA384
- removed cut-off ECDHE-RSA-SA- and ECDHE-RSA-AES
- made OPAC and Intranet sections match
- removed TLSv1
https://tools.ietf.org/id/draft-ietf-tls-oldversions-deprecate-02.html
   
https://blogs.windows.com/msedgedev/2020/03/31/tls-1-0-tls-1-1-schedule-update-edge-ie11/
https://www.entrustdatacard.com/blog/2018/november/deprecating-tls
- did not remove TLSv1.1 as this would break support for older browsers
probably still in use.
- did not add TLSv1.3 as it depends on OS used and version of openSSL if
it is supported or not.

This may break support for some things, but nothing semi-current. I
don't care about ie 11 on windows 8.1 phones, or safari 6-8.

Also, people using letsencrypt.org should look into using a DNS CAA record
for their opac site URL, issued by letsencrypt.org with flags set to 0.

This affects the installation using:
sudo koha-create --letsencrypt --create-db instance

BEFORE using this command recently, I needed to disable the
000-default site, and had to create a directory
/usr/share/koha/intranet/htdocs/.well-known/acme-challenge
which I also softlinked from
/usr/share/koha/opac/htdocs/.well-known/acme-challenge to
the intranet one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25948] New: Clean up apache protocols and ciphers

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25948

Bug ID: 25948
   Summary: Clean up apache protocols and ciphers
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

SSLCipherSuite was truncated and different between the OPAC and Intranet
sections. While cleaning that up, removed TLSv1 as it is supposed to be
deprecated already.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25945] Description of AuthoritySeparator is misleading

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25945

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 106644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106644=edit
Attachment to Bug 25945 - Description of AuthoritySeparator is misleading

Bug 25945: Description of AuthoritySeparator is misleading

This patch changes the description of the AuthoritySeparator system preference

To test: 
1. Apply patch
2. Go to Administration > Global system preferences > Cataloging and locate the 
AuthoritySeparator preference
3. Read the description and make sure it makes sense and that there are no
typos 
or grammatical errors

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25945] Description of AuthoritySeparator is misleading

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25945

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25945] Description of AuthoritySeparator is misleading

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25945

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25947] Improve locked account message

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947

--- Comment #1 from Caroline Cyr La Rose  ---
Again, this might be outside the scope, but I also think the OPAC message could
be improved.

Right now, it says

'You entered an incorrect username or password. Please try again! But note that
passwords are case sensitive and that your account will be locked out after a
fixed number of failed login attempts. Please contact a library staff member if
you continue to have problems.'

I would add the number of failed attempts rather than 'after a fixed number of
failed login attempts'

And I would also change the message once the account is blocked. Right now,
even if FailedLoginAttempts is at 2, you can try to log in 10 times and it will
never tell you that your account is now blocked.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448

--- Comment #12 from Christopher Brannon  ---
(In reply to Chris Kirby from comment #11)
> I would like to add another vote to seeing this bug fixed.

+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25947] New: Improve locked account message

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947

Bug ID: 25947
   Summary: Improve locked account message
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 106643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106643=edit
Warning messages in the patron details

When using FailedLoginAttempts, a patron's account is blocked after X many
failed login attempts on the OPAC. When that happens, a message 'Account has
been locked.' appears on the patron account details page.

This message does not indicate why or how it was blocked.

I suggest we change it to 'Account has been locked due to too many failed login
attempts'.

Furthermore, the font is dark red whereas the font for other warnings (such as
wrong category or unpaid fines) is bright red and bold.

To test:
1. Change FailedLoginAttempts to a small number, like 2
2. Go to a patron's account and copy their username (while you're there, change
the password and add some fines, too)
3. In the OPAC, try to log in with the username and a wrong password several
times
4. Go back to the patron's account in the staff interface
5. Note that there is no indication as to why the patron's account is locked
and that the font color and weight does not match the other warnings.

Also, there is no button to change the password next to the warning. When a
patron has unpaid fines or is in the wrong category, there is a button to
either pay/writeoff the fines or change the category next to the warning. I
would add a button that says 'Change password' next to the locked account
warning. This might be outside the scope of this bug, but I think it would
improve usability.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846

--- Comment #1 from Owen Leonard  ---
Created attachment 106642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106642=edit
Bug 25846: Improve handling of multiple covers on catalog search results in the
staff client

This patch modifies the template, JS, and CSS for the staff
interface catalog search results in order to gracefully handle multiple
cover images.

The changed version loops through any cover images which might be
embedded and checks that they are successfully loaded. Only
successfully-loaded images are shown. Only the first image is shown, and
the others can be "paged through" using generated navigation controls.

To test, apply the page and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Enable multiple cover image services. The patch was developed with these
services available:

 - Amazon
 - Local cover images (including multiple local cover images)
 - Coce (serving up Amazon, Google, and OpenLibrary images)
 - Images from the CustomCoverImages preference

Perform a variet of searches and confirm that cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available for each.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25846] Improve handling of multiple covers on catalog search results in the staff client

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448

Chris Kirby  changed:

   What|Removed |Added

 CC||chris.kirby@ilsleypubliclib
   ||rary.org

--- Comment #11 from Chris Kirby  ---
I would like to add another vote to seeing this bug fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

--- Comment #10 from Owen Leonard  ---
Created attachment 106640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106640=edit
Bug 23797: (follow-up) Increase the size of opac_news.lang

This patch adds a database update to increase the size of the
opac_news.lang column in order to accommodate longer values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106326|0   |1
is obsolete||
 Attachment #106396|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 106639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106639=edit
Bug 23797: Convert OpacLoginInstructions system preference to news block

This patch builds on Bug 22318 to move the OpacLoginInstructions system
preference into the Koha news system, making it possible to have
language- and library-specific content.

To test you should have some content in the OpacLoginInstructions system
preference. Apply the patch and run the database update process.

 - Go to the OPAC and click the login link.
 - In the login modal, confirm that the content which was previously in
   the OpacLoginInstructions system preference displays correctly
   below the login form.
 - While not logged in to the OPAC, navigate directly to
   /cgi-bin/koha/opac-user.pl. The OpacLoginInstructions content should
   display correctly here as well.
 - In the staff client, go to Tools -> News and verify that the content
   from OpacLoginInstructions is now stored in news items. There
   should be one entry for each of the enabled translations in your
   system, for instance 'OpacLoginInstructions_en',
   'OpacLoginInstructions_fr-FR', 'OpacLoginInstructions_cs-CZ'
 - Go to Administration -> System preferences and confirm that the
   OpacLoginInstructions preference has been removed.
 - To test the correct selection of language-specific content you must
   run the translation update/install process for the languages you're
   updating.

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

--- Comment #11 from Owen Leonard  ---
Created attachment 106641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106641=edit
Bug 23797: (follow-up) Enable OpacLoginInstructions in header

The OpacLoginInstructions information should be available in the login
modal which is displayed when the login link in the header menu is
clicked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25879] Improve display of guarantor information in the patron entry form

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25879] Improve display of guarantor information in the patron entry form

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879

--- Comment #1 from Owen Leonard  ---
Created attachment 106638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106638=edit
Bug 25879: Improve display of guarantor information in the patron entry form

This patch makes some changes to the patron entry template to improve
the display of guarantor information.

To test, apply the patch and locate a patron with a "Child" type
category.

 - Edit the patron's record
 - Under "Guarantor information," click the "Search to add" button.
 - Search for and select a patron.
 - The guarantor information should be added to the patron edit
   form. The information should be correct and well formatted.
 - Click the "Remove" link. The guarantor information should be
   removed.
 - Search for an select a guarantor again and save the record.
 - Edit the patron record again. The saved guarantor information should
   look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25879] Improve display of guarantor information in the patron entry form

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879

Owen Leonard  changed:

   What|Removed |Added

Summary|Border for guarantor is |Improve display of
   |larger than the container   |guarantor information in
   ||the patron entry form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322

Owen Leonard  changed:

   What|Removed |Added

 Blocks||25946


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946
[Bug 25946] borrowerRelationship can no longer be empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25946] New: borrowerRelationship can no longer be empty

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946

Bug ID: 25946
   Summary: borrowerRelationship can no longer be empty
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: alex.arn...@biblibre.com, and...@bywatersolutions.com,
david.robe...@ptfs-europe.com, gmcha...@gmail.com,
h...@interleaf.ie,
jonathan.dru...@bugs.koha-community.org,
kyle.m.h...@gmail.com,
martin.renvo...@ptfs-europe.com, nug...@gmail.com,
stalkern...@gmail.com
Depends on: 25322

Since Bug 25322 it is not possible to have an empty borrowerRelationship system
preference. The empty relationship dropdown is treated as mandatory.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322
[Bug 25322] Adding a guarantor with no relationship defaults to first available
relationship name
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22827] Automatic item modifications by age: add age depencency on other field(s) than dateaccessioned

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22827

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #3 from Andrew Fuerste-Henry  ---
+1, we definitely have libraries that would make use of this if it could key
off of dates other than dateaccessioned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

--- Comment #11 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #9)
> 1) Your regex always removes the first occurence, but we need the last.
> 2) . is not removed as it's not escaped in the regex (I think).
> 2) In case of "Date, C. J." we don't want the last, when it's preceded by a
> capital letter (very likely to be an initial).

1 - I had two different regexes, one was wrong
2 - period does not need to be escaped
3 - Done

I added eliminating spaces on either side of punctuation as well

Tested and played here to find cases:
https://regex101.com/

This is the base right now:
\s*(?https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68897|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 106637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106637=edit
Bug 17661 - Ending punctuation causes duplicate facets

To test:
1 - Do search and pull up some records
2 - Edit some of the records to have authors like:
Date, C.J.
Date, C.j.
Date, C.J .
3 - Edit the records to have some series statments like:
830 $aDate, C.J. ;$v5
830 $aDate, C.J. ; $v5
830 $aDate, C.J.; $v5
4 - Search again and note you have 3 facets each for authr and series
5 - Apply patch
6 - Repeat
7 - Now you get 2 facets for author, period not removed when following Upper
case immediately, is otherwise
8 - Now you should have a single series facet
9 - Switch search engine to ES (index before applying patch)
10 - Note facets are separate again
11 - Reset mappings and reindex
   perl misc/search_tools/rebuild_elasticsearch -v -r
12 - Repeat search, facets combined as above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25945] New: Description of AuthoritySeparator is misleading

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25945

Bug ID: 25945
   Summary: Description of AuthoritySeparator is misleading
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The current description of AuthoritySeparator is 
'Separate multiple displayed authors, series or subjects with'

But it is not used to separate multiple authors, series or subjects, it is used
to separate the main entry and its subdivisions for subjects and contributors
only. Not authors nor series.

It should also be specified that it is used only in non-XSLT views.

To test:
1. Change the value in AuthoritySeparator for something crazy (ex. -a-a- )
2. Change the value of OPACXSLTDetailsDisplay to empty
3. Add or modify a record and enter 
- an author in 1XX (with multiple subfields)
- several series in 440 (with multiple subfields each)
- several contributors in 7XX (with multiple subfields each)
- several subject headings in 6XX (with multiple subfields each)
4. Add the record to the cart
5. Open the cart and click on 'More details'
6. Note that only subjects use your crazy separator and not in between each
subject but between main headings and subdivisions.
7. Open the record in the OPAC
8. Note that only subjects and contributors use your crazy separator, again not
in between each entry but between main entries and subfields.

It seems to be used differently across modules. I think that should be a
discussion, but right now, I suggest we change the description to 
'Separate main entry and subdivisions with ___ (non-XSLT view only)'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25499] Fund code column is empty when closing a budget

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499

Abbey Holt  changed:

   What|Removed |Added

 CC||ah...@dubuque.lib.ia.us
 Status|Needs Signoff   |Signed Off

--- Comment #8 from Abbey Holt  ---
It worked great!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25879] Border for guarantor is larger than the container

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25879

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22728] Manual for BorrowerMandatoryField should include note on extended attributes

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22728

--- Comment #17 from Christopher Brannon  ---
I'm not seeing this point here, so I will just add to the mix.  It DOES seem
like it is currently a side-effect.  The one problem with implementing this is
that it is based off field names, and those names vary, depending on whether
some of the patron attributes are used for all libraries.  This can cause
problems with those libraries that don't use a certain attribute, as it offsets
the attribute names.

I haven't tested, but this could also be complicated by those attributes that
allow more than one instance of the field.

Seems like a mandatory setting that can stick to the specific field would be
better than trying to make it mandatory through the field name.

I would suggest that the mandatory option be unavailable to those fields that
can be duplicated, or only make the first instance mandatory?  Just some
thoughts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14648] Batch remove reserve items

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648

--- Comment #18 from Joe Sikowitz  ---
Hi Nick,

These patches keep things simple and work as expected.

Blocker:
1 - If I enter barcodes that are not in any courses I report successful
deletion from all courses - I don't think that's right

I'm going to fix this one and readd the patch.

Couple questions:
1 - Why not a bulk option to remove from a single course?

I've already submitted this patch and it has been signed off as bug 25606.

2 - Could the results report which courses the items were deleted from, at the
very least maybe the number of courses it was removed from?

This sounds reasonable. I'll look into adding it.

3 - I would rather see this use Objects, but CourseReserves could use a
refactor as a whole

I'm not sure what Objects you are referring to. Any information you can provide
would be great.

Thanks,
Joe

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #51 from Julian Maurice  ---
(In reply to Owen Leonard from comment #50)
> I think it would be better to have some patches on this bug which are
> proof-of-concept rather than trying to update everything at once.

I was thinking maybe one template at a time in separate bugs ? Easier to test
and QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25499] Fund code column is empty when closing a budget

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499

--- Comment #7 from Katrin Fischer  ---
Thanks a lot, Abbey!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25499] Fund code column is empty when closing a budget

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25499

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #105294|0   |1
is obsolete||

--- Comment #6 from ByWater Sandboxes  ---
Created attachment 106636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106636=edit
Bug 25499: Fix fund code column when closing a budget

When closing a budget the fund code column in the table is
always empty. This is due to a TT variable not being correct.

To test:
- Create a budget and fund
- Order anything, leave basket open or not, but don't receive
- Duplicate your existing budget
- Close the first budget in order to move the pending orders
- Verify the fund code is not showing in the table
- Apply patch and reload the patch
- Verify fund codes are now showing correctly

Bonus: Changes the column heading Fund id to Fund ID.

Signed-off-by: Abbey Holt 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #50 from Owen Leonard  ---
I think it would be better to have some patches on this bug which are
proof-of-concept rather than trying to update everything at once.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25376] Use LANG authorised values for language facet

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25376

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25541] Add ability to prevent checkin via SIP of items with holds

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25629] Fix capitalization in sample notices

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25629

Owen Leonard  changed:

   What|Removed |Added

 Attachment #105442|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 106635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106635=edit
Bug 25629: Fix capitalization in sample notices

This fixes the capitalization in sample notices files to
follow coding-guidelines. Only applies to English, translations
remain unchanged.

Additional fixes:
- Overdues slip added the letter code as subject instead of the description
- Opac changed to OPAC for self-registration verification emails

German (de-DE) file was not changed, as there is a pending translation
bug that will take care of these (bug 25129).

To test:
- Verify changes by running the web installer for the changed
  files and verify sample notices install without error
- Verify subjects and notice descriptions are correct
- Run tests in t/db_dependent/Letters*

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25629] Fix capitalization in sample notices

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25629

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25293] Don't call escapeHtml on null

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25293] Don't call escapeHtml on null

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293

Owen Leonard  changed:

   What|Removed |Added

 Attachment #103862|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 106634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106634=edit
Bug 25293: Don't call escapeHtml on null

Test Plan:

1) Create two Checkouts
2) view patron's checkout list
   cgi-bin/koha/members/moremember.pl?borrowernumber=pp 
3) in mysql shell delete a checkout home branch: update items set
   homebranch = null where itemnumber = xx;
4) view patron's checkout list, again

Without this patch the list is empty.

Same if biblio title is null (update biblio set title = null where
biblionumber = yy;).
Javascript error:
TypeError: oObj.title is null

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #17 from Nick Clemens  ---
This works for me in Firefox, but fails in both Chrome and Chromium - it works
for surname, but cardnumber ends up under the save bar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106354|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 106633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106633=edit
Bug 25798: Add copyright year to "Holds to pull" report

Display copyright year (publication year) of book
together with title in "Holds to pull" report.

Copyright year is fetched from biblio -table as "copyrightyear"
and displayed when the preferred marc is set to MARC21.
Publication year is fetched from biblioitems -table as "publicationyear"
and displayed when the preferred marc is set to UNIMARC.

1. Place a hold on book with known copyright year.
2. Go to /cgi-bin/koha/circ/pendingreserves.pl and check the "title"
table of that book that you placed hold on.
3. Observe that there's no information about publication year in that
field.
4. Apply patch.
5. Repeat step 2.
6. Observe that copyright year (publication year) of book appeared
in the title table after book's title and author.

Mentored-by: Andrew Nugged 

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25798] Copyright year to Holds to pull report

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25798

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Owen Leonard  changed:

   What|Removed |Added

 Attachment #106625|0   |1
is obsolete||

--- Comment #13 from Owen Leonard  ---
Created attachment 106632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106632=edit
Bug 25709: Rename systempreference to NotesToHide

To test:
1 - Apply patch and updatedatabase
2 - git grep NotesBlacklist
3 - Note all remaining occurrences are translations, db updates, and release
notes
4 - Add a field (e.g. '520' ) to the NotesToHide systempreference
5 - View a record with a 520 field on the opac
6 - Confirm the field does not show in the 'Title notes' tab

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22843] Finer control of who receives purchase suggestion notifications

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22843

Martin Renvoize  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=22823   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 22823] Koha::Library needs a method for obtaining the inbound email address

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22823

Martin Renvoize  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=22843   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #15 from Marcel de Rooy  ---
Adding a local comment in our discussion basket ;)

What is the right moment for a biblio record to receive a persistent identifier
btw? Thinking about local procedures around acquisition etc.

The choice in this patch set is still influenced by the partial/meta resolving
(see former comments). A replace by Z3950/SRU might result in two PIDs in the
authoritative table and one local copy (the newest) in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14648] Batch remove reserve items

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #17 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #16)
> QA team ... I signed off, can one of you take over here please?

These patches keep things simple and work as expected.

Blocker:
1 - If I enter barcodes that are not in any courses I report successful
deletion from all courses - I don't think that's right

Couple questions:
1 - Why not a bulk option to remove from a single course?
2 - Could the results report which courses the items were deleted from, at the
very least maybe the number of courses it was removed from?
3 - I would rather see this use Objects, but CourseReserves could use a
refactor as a whole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

Martin Renvoize  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

Martin Renvoize  changed:

   What|Removed |Added

 CC||a...@komputilo.eu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

Martin Renvoize  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

Martin Renvoize  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

--- Comment #1 from Martin Renvoize  ---
Created attachment 106631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106631=edit
Bug 25944: Schema fix for illrequests route

The illrequests path was missing the `comments` and `status_alias`
embedable relations in the path specification.

Test plan:
1/ Ensure you have the latest Mojolicious + OpenAPI modules installed.
2/ Navigate to the ill requests page and note that the table is empty.
3/ Note that under the networking tab in your browsers developer tools
that the api call fails with a 400 error.
4/ Apply the patch
5/ Refresh the page
6/ The table should now load and the api route should return a proper
200 response.
7/ Signoff

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #14 from Marcel de Rooy  ---
(In reply to David Cook from comment #12)
> And if we do want to store the PID at the record level, I think it would be
> best to put that into the relational database (we could export it into the
> MARC at indexing/exporting time).

See ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 24544] Add a script for inserting persistent identifiers to MARC records

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #13 from Marcel de Rooy  ---
(In reply to David Cook from comment #11)
Thanks for your feedback.

> Personally, I think that it would be better to add a plugin to the
> authority/biblio/item records and allow you to mint PIDs while cataloguing.
> That's how most systems I've used have worked.

See also comment9. I chose here to not add stuff directly to core Koha
routines. But work my way thru the data with a cron job. Surely this would be a
next step. Problem with a cataloguing plugin is that you just know the record
number only after saving  it. Although a PID generator might theoretically not
need it, many implementations, including my own, do use it.

> That said, sometimes you want to batch mint PIDs, but I think that would be
> up to the entity doing the batch work. I don't see why we'd need anything
> special for that in Koha.

Not sure how much you saw from the patches, but this patch set provides an
interface via plugins to an external PID service.

> Or are you trying to create a local Koha PID minting service? If that's the
> case, I think storing the data in MARC fields is not a wise direction. It
> would be better to have a Koha PID lookup table mapping the PID to the
> record, so that PID resolution could be handled that way.

See before. No Koha should not mint its own PIDs. Formally the PID generator
may have its own PID lookup table. We do not really care here. (My local
generator does not, since it is based on a Koha identifier. Its result can be
found with a Standard-identifier index in Koha or even another future ILS. In
that way actually turning my ES or Zebra index into a PID lookup table..)
But even with a full resolver having its own table, I would still argue to save
a copy of the PID in the MARC record too for optimization, while respecting the
lookup table as authoritative.
As a side note: Could you give me another example of vital data on biblio level
that we do not store in MARC? Not meaning optimization or calculated aggregates
etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25944] New: Bug in ill_requests patch schema

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944

Bug ID: 25944
   Summary: Bug in ill_requests patch schema
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com

Updating Mojo + OpenAPI dependencies has improved the strictness of the
validator and highlighted some missing fields on the 'embed' enum.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

--- Comment #18 from Nick Clemens  ---
Created attachment 106630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106630=edit
Bug 25850: (QA follow-up) use dt_from_string

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

Nick Clemens  changed:

   What|Removed |Added

 Attachment #106383|0   |1
is obsolete||

--- Comment #16 from Nick Clemens  ---
Created attachment 106628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106628=edit
Bug 25850: Adapt day of week in Koha::Calendar::get_push_amt to 0..6 with 0
being Sunday.

1. Go to tools -> calendar and make sure Sundays are holidays by adding
   a holiday on a Sunday and selecting "Holiday repeated every same day
   of the week" and "Copy to all libraries" and save.
2. Go to administration -> system preferences and select "Use the
   calendar to push the due date to the next open matching weekday
   for weekly loan periods, or the next open day otherwise" for the
   system preference "useDaysMode" and save the system preferences.
3. Put the below code in a file name test.pl and execute it using
   the command "sudo koha-shell -c 'perl test.pl' kohadev"

   use Koha::Calendar;

   my $calendar = Koha::Calendar->new( branchcode => 'CPL' );
   $dt = DateTime->new(
   year   => 2020,
   month  => 06,
   day=> 21
   );

   print "This is a sunday: " .
   $dt->day_of_week . "\n";

   my $ndt = $calendar->next_open_days($dt, 0);

   print "This is a monday: " .
   $ndt->day_of_week . "\n";

4. Without the patch applied, this script
   will freeze after printing "This is a
   sunday ...".  Abort using ctrl-c.
5. Apply patch and run the script again.
   The test script will now complete.

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

Nick Clemens  changed:

   What|Removed |Added

 Attachment #106384|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 106629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106629=edit
Bug 25850: (QA follow-up) Match logic in is_holiday

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

Nick Clemens  changed:

   What|Removed |Added

 Attachment #106382|0   |1
is obsolete||

--- Comment #15 from Nick Clemens  ---
Created attachment 106627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106627=edit
Bug 25850: Regression Test

This patch adds a unit test to test for an infinite loop as highlighted
by the bug.

Test plan
1/ Run the test before applying the fix
2/ The test should fail for 'Sundays'
3/ Apply the subsquent patch
4/ Re-run the test
5/ It should now pass

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850

Nick Clemens  changed:

   What|Removed |Added

 Attachment #106381|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 106626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106626=edit
Bug 25850: Add tests for weekday holidays

Signed-off-by: Martin Renvoize 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801

--- Comment #19 from Marcel de Rooy  ---
(In reply to David Cook from comment #18)
> RDF subjects was my first thought, although reading more about RPC and REST
> APIs and thinking that having a canonical item URL (or PID) could be useful
> for a REST API (better to return a URL rather than an itemnumber for
> instance).
> I was wondering if you had a particular use case that you plan to use this
> for in the short term is all. Like is the HTML representation important in
> your use case? Or is it just to uniquely identify the resource (say for a
> RDF subject or REST API)?

Yes, the landing page of the item persistent identifier (URL) is not that
important, but I do want to be able to dereference it. Including an HTML
representation when that would be the result of content negotiation. But surely
the main thing is a unique resource identifier in the form of a URL. 

We will be using something like https://id.rijksmuseum.nl/3012345
Our institutional PID resolver knows (as a partial or meta resolver) how to
pass library PIDs to the library PID resolver. Which would use opac-detail for
HTML in case of a biblio or item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25709] Rename systempreference from NotesBlacklist to NotesDenylist

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709

Nick Clemens  changed:

   What|Removed |Added

 Attachment #106601|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 106625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106625=edit
Bug 25709: Rename systempreference to NotesToHide

To test:
1 - Apply patch and updatedatabase
2 - git grep NotesBlacklist
3 - Note all remaining occurrences are translations, db updates, and release
notes
4 - Add a field (e.g. '520' ) to the NotesToHide systempreference
5 - View a record with a 520 field on the opac
6 - Confirm the field does not show in the 'Title notes' tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240

Henry Bolshaw  changed:

   What|Removed |Added

 CC||bolsh...@parliament.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25242] Accessibility: The 'Holdings' table partially obscures navigation links at 200% zoom

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25242

Henry Bolshaw  changed:

   What|Removed |Added

 CC||bolsh...@parliament.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25113] Make CirculationRules.t flexible for new scope combinations

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25113

--- Comment #4 from Lari Taskula  ---
(In reply to Joonas Kylmälä from comment #3)
> In the patch you mention
> 
> > This also obsoletes the "Get effective issuing rule in correct order"
> > test in t/db_dependent/Koha/IssuingRules.t
> 
> why is it obsole(In reply to Joonas Kylmälä from comment #3)
> In the patch you mention
> 
> > This also obsoletes the "Get effective issuing rule in correct order"
> > test in t/db_dependent/Koha/IssuingRules.t
> 
> why is it obsoleted?

It is the test I refer to in the original post of this Bug.

> We used to test rule scopes by explicitly defining each combination.
> When adding new scopes, it is much easier if these tests are auto-
> generated for you so that you don't have to repeat similar code.
> Remove those "duplicates" ...

Manually adding 2^n tests, where n is the number of scopes, is no longer needed
because wiith this patch we are autogenerating those test cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #28 from Emmi Takkinen  ---
Created attachment 106624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106624=edit
Bug 13961: Check that borrowernumber isn't a reference

Some SendAlerts() tests in Letters.t failed due SQL::Abstract errors,
caused by HASH sometimes set as borrowernumber.

Added code to check if borrowernumber is defined and it isn't a reference.
To test prove t/db_dependent/Letters.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #27 from Emmi Takkinen  ---
Created attachment 106623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106623=edit
Bug 13961: Fix QA issues

This patch fixes following QA issues:

 FAIL   C4/Letters.pm
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).

 FAIL   t/db_dependent/Letters.t
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 25792] Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11

2020-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25792

--- Comment #10 from Mason James  ---

> > when the unrequired ttf-dejavu package's symlinks are removed (eg: apt
> > autoremove) the paths will need to be manually corrected
> > keeping the ttf-dejavu reference in debian/control would postpone this
> > problem until the system is upgraded to deb11/bullseye (which is probably a
> > good thing?)
> > 
> >
good news, i tested my theory and found it to be incorrect :)
there does not seem to be any problem when upgrading on bullseye.

bullseye will allow both packages to be installed together

'apt autoremove' does not remove the ttf-dejavu* packages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 104 matches

Mail list logo