[Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to oldoldstable CC||vic...@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 --- Comment #9 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25789] New expiration date on placing a hold in staff interface can be set to a date in the past
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25789 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Can't backport to 19.05.x, the code doesn't seems to have that part here (a datepicker). Maybe the feature wasn't here, maybe it moved from another file If interested, feel free to investigate further. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25756] Empty HTML table row after OPAC "Appearance" preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25756 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 Status|Pushed to oldstable |Pushed to oldoldstable CC||vic...@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26055] Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26055 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26055] Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26055
--- Comment #2 from David Cook ---
Relevant code:
./koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
'new': {
titleForRecord: _("Editing new record"),
get: function( id, callback ) {
record = new MARC.Record();
KohaBackend.FillRecord( '', record );
callback( record );
},
},
"koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js"
FillRecord: function( frameworkcode, record, allTags ) {
$.each( _frameworks[frameworkcode], function( undef, tag ) {
var tagnum = tag[0], taginfo = tag[1];
if ( taginfo.mandatory != "1" && !allTags ) return;
var fields = record.fields(tagnum);
if ( fields.length == 0 ) {
var newField = new MARC.Field( tagnum, ' ', ' ', [] );
fields.push( newField );
record.addFieldGrouped( newField );
if ( tagnum < '010' ) {
newField.addSubfield( [ '@', (taginfo.subfields[0] ?
taginfo.subfields[0][1].defaultvalue : null ) || '' ] );
return;
}
}
$.each( taginfo.subfields, function( undef, subfield ) {
var subfieldcode = subfield[0], subfieldinfo = subfield[1];
if ( subfieldinfo.mandatory != "1" &&
!subfieldinfo.defaultvalue && !allTags ) return;
$.each( fields, function( undef, field ) {
if ( !field.hasSubfield(subfieldcode) ) {
field.addSubfieldGrouped( [ subfieldcode,
subfieldinfo.defaultvalue || '' ] );
} else if ( subfieldinfo.defaultvalue &&
field.subfield( subfieldcode ) === '' ) {
field.subfield( subfieldcode,
subfieldinfo.defaultvalue );
}
} );
} );
} );
},
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26055] Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26055 --- Comment #1 from David Cook --- I could work on this one, but I wonder about the best way to handle this. In Koha, we typically do not change existing behaviour, so we add system preferences. I'm undecided whether the current behaviour is a "bug" or if it's just a system design with which I disagree. Perhaps the solution is to create a new option in the editor and use a syspref to change the button. Note the following: 1) /cgi-bin/koha/cataloguing/editor.pl#new/ This only shows fields that are marked as "Mandatory" 2) /cgi-bin/koha/cataloguing/editor.pl#new-full/ This shows all fields in the framework regardless of "Mandatory" or "visibility" states -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25962] In Advanced Editor mandatory subfields are not enforced if tag is not mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25962 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26055 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26055] Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26055 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25962 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26055] New: Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26055 Bug ID: 26055 Summary: Advanced Editor Rancor should use "visibility" and not "mandatory" for drawing new records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl The Advanced Editor (Rancor) uses a tag's mandatory flag to decide whether to show in the UI when showing an editor for a new record. This doesn't make 100% sense, since often a cataloguer will also want to see optional fields (like 500) by default to serve as a prompt. In systems like Horizon, one refers to these as "templates". You have a separate set of typical fields for books, journals, DVDs, etc. You don't have to fill in all those fields, but they're the typical fields that you would use for them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25962] In Advanced Editor mandatory subfields are not enforced if tag is not mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25962 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- Agreed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25611] Changing the vendor when creating the basket does not keep that new vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 --- Comment #10 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #30 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24352] Wrong labels displaying in result list with OpacItemLocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 --- Comment #19 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/19.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Nightly Build Bot changed: What|Removed |Added Attachment #98514|0 |1 is obsolete|| --- Comment #21 from Nightly Build Bot --- Created attachment 107273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107273=edit Bug 17108- Automatic debian/control updates (stable/19.05.x) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25509] Remove useless libjs-jquery dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25509 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 --- Comment #10 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #36 from Aleisha Amohia --- (In reply to Michal Denar from comment #35) > Hi, > sorry Aleisha and Jonathan. But patch don't work for me. If you change > priority of holds, name on List to Pull is still same as befere change. It's > not on test plan, I know. But I should work too. Maybe someone test it too. > Katrin? > https://recordit.co/RA8bCjXekD Hi Michal, I don't think it's about priority, it's about the earliest place hold. As far as I know the Holds to Pull shows the 'first patron' as based on date, I don't think it ever considered priority. But I may have that wrong, perhaps Jonathan or Katrin can confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25570] Listing requests should be paginated by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25570 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 --- Comment #18 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26054] New: Reflect irregularities in numbering pattern test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26054 Bug ID: 26054 Summary: Reflect irregularities in numbering pattern test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com When setting up a subscription, if you select "Keep issue number" for irregular issues and then mark some issues as "Not published" when testing the prediction pattern, Koha will remember to account for that when generating new issues around those unpublished issues. However, there's no way to make the pattern test show you how that will actually play out. Unpublished issues are never reflected in the numbering pattern test. It'd be great to have a way to re-generate the predicted numbering pattern with the Not Published issues reflected. Maybe a little "Update" button under the predicted pattern that one could click after checking the relevant boxes? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #35 from Michal Denar --- Hi, sorry Aleisha and Jonathan. But patch don't work for me. If you change priority of holds, name on List to Pull is still same as befere change. It's not on test plan, I know. But I should work too. Maybe someone test it too. Katrin? https://recordit.co/RA8bCjXekD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26037] openlibrary.org is hit on every Koha requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26037 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25553] Edit item date sort does not sort correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25553 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 Status|Pushed to oldstable |Pushed to oldoldstable CC||vic...@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25447] Terminology: Fix button text "Edit biblio"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25447 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08|19.11.08, 19.05.14 --- Comment #12 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack fails when http://swagger.io/v2/schema.json is unavailable and schema cache missing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #62 from Victor Grousset/tuxayo --- Upstream answer https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964496#10 > Indeed, the OpenAPI schema files are Apache2-licensed [3], > thus at least them could be retained. > However, copies of these schema files are already around in Debian [4], > thus I would suggest packaging OpenAPI schema files in a separate > Debian package, and symlinking them to JSON::Validator cache location. Help welcome to try to find arguments to stop removing the schema files. The duplication concern is fair but I don't think someone here has the resources to push towards a common schema Debian package. Or maybe I'm wrong and it's not much work? h ^^" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #233 from Victor Grousset/tuxayo --- Formatting test > Amet voluptatibus hic facere quia enim alias. Exercitationem deserunt iusto > totam. Eum quos ducimus magnam aut. Assumenda impedit recusandae commodi eos > placeat consectetur ut. Impedit id id quam eveniet rerum. Sed ab officia > provident non cupiditate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25944] Bug in ill_requests patch schema
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25944 --- Comment #6 from Tomás Cohen Arazi --- Please backport to 20.05 and 19.11. ILL is broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 --- Comment #16 from Owen Leonard --- Created attachment 107272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107272=edit Bug 25031: (QA follow-up) Avoid displaying extra navigation This patch reworks the construction of the navigation links in such a way that they are built during a loop over an updated jQuery object. Previously the stored variable might not reflect that some elements had been removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 Owen Leonard changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #17 from Martin Renvoize --- (In reply to Jonathan Druart from comment #15) > We cannot upload but uninstall, is that ok? Good catch, we should probably disallow that too here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #16 from Martin Renvoize --- (In reply to David Cook from comment #14) > (In reply to Martin Renvoize from comment #13) > > Oops. forgot to attach my QA follow-up first time around.. it just hides the > > install button if you happen to have your system configured for no uploads > > but still allow searching for plugins via the UI. > > Firstly, thanks so much for QAing this, Martin! Really appreciated! > > Secondly, that's an interesting follow-up! > > I actually intended to let people install plugins from configured Git repos > but just disable plugin file upload via their local browser. Ah, if that was your intentention, I don't believe it worked. I'm sure I tested it during QA and as expected, it failed at the plugin upload stage so I disabled the button as a follow-up. Hmm, maybe this needs a minor revisit then to clarify the case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26033] framapic is closing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26033 Victor Grousset/tuxayo changed: What|Removed |Added Severity|normal |major Patch complexity|--- |Trivial patch --- Comment #4 from Victor Grousset/tuxayo --- Upping (if appropriate) the severity to major since it's important for this to be backported. Because Framapic doesn't accept new uploads anymore. I though initially that it would be for latter but no. So the feature of the UI tests to take a screenshot in case of failure is currently not working. Hence the need of backporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26033] framapic is closing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26033 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #3 from Victor Grousset/tuxayo --- It work! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26033] framapic is closing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26033 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #107143|0 |1 is obsolete|| --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 107271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107271=edit Bug 26033: Use pic.infini.fr instead of framapic https://framapic.org/ is closing """ Framapic will be closing its doors on Tuesday, January 12, 2021. You will find a similar service on this page. Uploading images is now disabled, but you can still retrieve your images on the My images page. """ https://framablog.org/2019/09/26/lets-de-frama-tify-the-internet/ https://framablog.org/2020/03/03/10-bonnes-raisons-de-fermer-certains-services-framasoft-la-5e-est-un-peu-bizarre/ (French) We can still use another service. However we may think about hosting the service ourself! Test plan: Modify a selenium script to make it fail (for instance modify the path for a find_element call) Run it Confirm that the screenshot has been uploaded correctly and that the link works Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 --- Comment #16 from Owen Leonard --- Created attachment 107270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107270=edit Bug 22660: (follow-up) Re-word system preference description This patch rewords the system preference description to focus on the generic description of the editor rather than the name of the plugin: tinymce: "a WYSIWYG editor (TinyMCE)" codemirror: "a text editor (CodeMirror)" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Owen Leonard changed: What|Removed |Added Attachment #107268|0 |1 is obsolete|| --- Comment #15 from Owen Leonard --- Created attachment 107269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107269=edit Bug 22660: (follow-up) Improve asset handling, add linting This patch makes some changes to the way assets are included based on the value of the system preferece in order to minimize unnecessary JavaScript includes. The patch also adds HTML syntax-highlighting and linting like we have in the system preferences editor. Removed are two JS files which were not required. To test, apply the patch and set the NewsToolEditor preference to "CodeMirror." - Edit a news item and confirm that the contents of the editor show HTML syntax highlighting. - Test HTML linting by adding some malformed HTML (missing closing tag, for instance). The error should be highlighted. - Set the NewsToolEditor to "TinyMCE" and confirm that WYSIWYG editing still works correctly. https://bugs.koha-community.org/show_bug.cgi?id=22600 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Owen Leonard changed: What|Removed |Added Attachment #105158|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 107267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107267=edit Bug 22660: Add system pref to allow switching of editors in News Tool This patch adds a system preference called 'NewsToolEditor' which allows for the choice between TinyMCE and CodeMirror in the News Feature. TEST PLAN: 1. Apply patch and run updatedatabase 2. Go to Tools > News and make a new entry or edit an existing News item. 3. When you initially load you should gte the TinyMCE editor (WYSIWYG) 4. Search for the NewsToolEditor system preference and switch to CodeMirror. 5. Reload your News item and now you should see the CodeMirror editor. 6. Try saving content with both and maki sure it works. 7. Try adding some different HTML tags in CodeMirror mode, saving, and making sure it looks right when you switch back to TinyMCE Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 --- Comment #14 from Owen Leonard --- Created attachment 107268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107268=edit Bug 22660: (follow-up) Improve asset handling, add linting This patch makes some changes to the way assets are included based on the value of the system preferece in order to minimize unnecessary JavaScript includes. The patch also adds HTML syntax-highlighting and linting like we have in the system preferences editor. Removed are two JS files which were not required. To test, apply the patch and set the NewsToolEditor preference to "CodeMirror." - Edit a news item and confirm that the contents of the editor show HTML syntax highlighting. - Test HTML linting by adding some malformed HTML (missing closing tag, for instance). The error should be highlighted. - Set the NewsToolEditor to "TinyMCE" and confirm that WYSIWYG editing still works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26053] New: Adding more details to the manual about Patron Restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Bug ID: 26053 Summary: Adding more details to the manual about Patron Restrictions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com A library can add a manual restriction to a patrons account with a date. This is the date the restriction will be lifted. It would be nice to add to the manual that this is controlled by a cron and would need to be activated for this process to work. --restrictions DAYS purge patrons restrictions expired since more than DAYS days. Defaults to 30 days if no days specified. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #28 from Andrew Fuerste-Henry --- This doesn't seem to be working in all cases when picking a specific library rather than a group. - Have an item with homebranch A and holdingbranch B - Set SearchLimitLibrary to home library - search for your barcode, limited to branch A - no results I get the same on the staff client and the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26052] New: In "Hold policy by item type, " allow individual rules to be "Not set"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26052 Bug ID: 26052 Summary: In "Hold policy by item type," allow individual rules to be "Not set" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In the circ rules, the Holds policy by item type table controls Hold Policy, Hold pickup library match, and Return policy. Saving a value for one of these three rules requires that one also save a value for the other two. In contrast, the Default checkout, hold and return policy interface allows one to save a value for one of these three rules and leave the others set to "Not set." Leaving a rule as "Not set" allows Koha to move on to the next most general rule, looking for something that applies to the hold or checkin at hand. By forcing the rules in Holds policy by item type to all have saved values, we require more rules to be set and managed, rather than simply falling back to default rules whenever possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26007] Warning/ reminder for changes to Koha to MARC mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26007 --- Comment #4 from Cab Vinton --- Above my pay grade as well, David, but easy enough to at least modify the text on that page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #19 from Tomás Cohen Arazi --- In order to test this, because of the DB structure changes, you need to either: - Have a master DB, checkout this branch and upgrade - Perform the webinstaller steps This is because the sample data in misc4dev is not adapted to this changes, so the handy reset_all command won't work (most probably). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Add a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What|Removed |Added URL||https://gitlab.com/thekesol ||utions/Koha/-/tree/bug_2526 ||0_holds_table --- Comment #18 from Tomás Cohen Arazi --- I've added a remote branch on the URL field on this bug. That's where I'll keep a rebased patchset up-to-date. Please test and let me know if I should add your signature to the patchset. https://gitlab.com/thekesolutions/Koha/-/tree/bug_25260_holds_table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21631] No warning when placing a hold with current location/pick-up location combination forbidden by Transport cost matrix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21631 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +1 on this If the transport cost matrix makes a hold unfillable, we should only allow staff to place it with an override and should block patrons from placing it at all on the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 107265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107265=edit Bug 21468: (QA follow-up) Enhance tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 107264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107264=edit Bug 21468: Add 'checkin' action for _after_circ_actions Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 107263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107263=edit Bug 21468: Unit tests for AddReturn Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 107266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107266=edit Bug 21468: (QA follow-up) SImplify payload This patch simplifies the payload as suggested on bug 25855. It also keeps some specific params that cannot be deduced from the passed checkout object, (e.g. if it is an onsite checkout). Tests are cleared and added for this special exceptions. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106887|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 107261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107261=edit Bug 21468: Unit tests for AddIssue This patch adds a unit test for the addition of a call to the _after_circ_action hook in AddIssue. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 107262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107262=edit Bug 21468: Add 'checkout' action for _after_circ_actions This patch adds a call to _after_circ_actions into AddIssue and passes an appropriate payload for plugins to utilise after issuing items. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106885|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106886|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106883|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] Plugins need hooks for checkin and checkout actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106884|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757 Martin Renvoize changed: What|Removed |Added Blocks||25753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Deprecate C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767 Martin Renvoize changed: What|Removed |Added Blocks|25753 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Deprecate C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25753] Deprecate C4::Circulation::transferbook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Martin Renvoize changed: What|Removed |Added Depends on|25767 |25757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757 [Bug 25757] Add a Koha::Item::Transfer->transit method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767 [Bug 25767] Add Koha::Item::Transfer->receipt method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #28 from Martin Renvoize --- Created attachment 107260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107260=edit Bug 22569: Refine GetTransfersFromTo to filter out unsent transfers GetTransfersFromTo is used solely by the transferstorecieve page which assumes items have already been sent. With the introduction of daterequested we allow for a state where a transfer has been scheduled but not yet sent (See stockrotation for such a case) and so we need to filter these transfers out from the transferstorecieve report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #97392|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 107258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107258=edit Bug 22569: Add a 'Transfers to send' report This patch adds a 'Transfers to send' report to the circulation page which displays items which have been triggered for transfer by the stock rotation subsystem. Caveats: 1) It is currently limited to transfers prompted by stockrotation 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. (but we do filter out transfers that have been marked as received) 3) Both 'Advance' and 'Repatriate' actions will be listed and the 'Advance' listings should have the option to set the item as 'In demand' at the current branch and thus cancel the transfer and make the item wait an additional stage period before being automatically set to transfer again. I believe we should enhance the transfers system as a whole to allow this report to be more meaningful and include transfer initiated via other means (along with appropriate actions to be taken upon them) Test plan 1) Setup a rotation plan and add some items to it as per the manual 2) Run the stockrotation cronjob with the --execute flag 3) Check that the expected items appears in the new 'Transfers to send' page. It does not yet catch items that are due for transfer by any other means as at this time we do not store that sort of detail for other mechanisms. See bug 23092 for one proposed resolution to that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What|Removed |Added Attachment #97393|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 107259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107259=edit Bug 22569: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible for "Reservation not needed after:" input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 --- Comment #6 from Owen Leonard --- I think this new code should be in calendar.inc instead of a separate file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #27 from Tomás Cohen Arazi --- I decided to keep the 'payload' parameter so if bug 25938 adds more information we don't change the API. I hope it fulfils your requirement, Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107251|0 |1 is obsolete|| --- Comment #26 from Tomás Cohen Arazi --- Created attachment 107257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107257=edit Bug 25855: (QA follow-up) Simplify payload This patch makes the hook be passed the Koha::Checkout object instead of a hand-crafted list of attributes. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26049] Replace li with span class results_summary in UNIMARC intranet XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26049 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107249|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 107255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107255=edit Bug 24446: Add Koha::Item::Transfer->in_transit method This method returns a boolean representing the in_transit state of the transfer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107250|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 107256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107256=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107247|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 107253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107253=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107248|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 107254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107254=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107246|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 107252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107252=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 107251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107251=edit Bug 25855: (QA follow-up) Simplify payload This patch makes the hook be passed the Koha::Checkout object instead of a hand-crafted list of attributes. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26047] moredetail.pl needs consistency in showing changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26047 Owen Leonard changed: What|Removed |Added Component|Cataloging |Templates Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #8 from Martin Renvoize --- Created attachment 107250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107250=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26047] moredetail.pl needs consistency in showing changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26047 --- Comment #1 from Owen Leonard --- (In reply to Christopher Brannon from comment #0) > When you make a change to statuses and click update, you get feedback with a > message next to the status header. I wouldn't consider that a status update, it's a summary of the values in lost/damaged/withdrawn. The information appears whether or not you've just updated those values. The distinction is only important because it wouldn't make sense to display the value of notes in the same place. That said, I think it makes good sense to display a message box informing the user that a change has been made. The information could be displayed immediately below the heading. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #105945|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 107248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107248=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #7 from Martin Renvoize --- Created attachment 107249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107249=edit Bug 24446: Add Koha::Item::Transfer->in_transit method This method returns a boolean representing the in_transit state of the transfer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #105944|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 107247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107247=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #5 from Martin Renvoize --- Test plan 1/ Run the included unit tests and verify they pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #105943|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 107246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107246=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767 Martin Renvoize changed: What|Removed |Added Attachment #105905|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 107244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107244=edit Bug 25767: Add Koha::Item::Transfer->receipt method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767 Martin Renvoize changed: What|Removed |Added Attachment #105906|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 107245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107245=edit Bug 25767: Add unit tests for Koha::Item::Transfer->receipt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757 Martin Renvoize changed: What|Removed |Added Attachment #105901|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 107242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107242=edit Bug 25757: Add Koha::Item::Transfer->transit method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757 Martin Renvoize changed: What|Removed |Added Attachment #105900|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 107241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107241=edit Bug 25757: Add item relation to Koha::Item::Transfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #7 from Martin Renvoize --- Test plan 1/ Run the included unit tests and verify they pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25757] Add a Koha::Item::Transfer->transit method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757 Martin Renvoize changed: What|Removed |Added Attachment #105902|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 107243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107243=edit Bug 25757: Add unit tests for item relation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755 Martin Renvoize changed: What|Removed |Added Attachment #105887|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 107240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107240=edit Bug 25755: Add Koha::Item->request_transfer method This patch adds the request_transfer method to the Koha::Item object. The new method requires `to` and `reason` parameters and will throw an exception if an active transfer request is found on the item. Test plan 1/ Run the included updated tests in t/db_dependent/Koha/Item.t 2/ Verify the tests pass 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25755] Add a Koha::Item->request_transfer method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25755 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 --- Comment #21 from Martin Renvoize --- (In reply to Jonathan Druart from comment #17) > Should not it be named "requested_on" instead? I'd like to maintain table consistency and handle updating all the filed to be `_on` in another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What|Removed |Added Attachment #106610|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 107239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107239=edit Bug 23092: Add unit tests Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Martin Renvoize changed: What|Removed |Added Attachment #106609|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 107238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107238=edit Bug 23092: Add 'daterequested' to branchtransfers table Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible for "Reservation not needed after:" input
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041 --- Comment #5 from Martin Renvoize --- (In reply to Katrin Fischer from comment #4) > We have removed the readonly in the past on feedback of a blind staff user > we had for a while. Maybe we could do both? I know she had preferred being > able to enter the date directly as it was much quicker and didn't require > getting the calendar read out. I did wonder about that myself.. my only fear there is that we get the date entered correctly.. we would need to take locale into account I believe and perhaps use an input mask to validate it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26051] Elasticsearch field local-classification must be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 --- Comment #1 from Fridolin SOMERS --- Created attachment 107237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107237=edit Bug 26051: Elasticsearch field local-classification sort=1 in mapping.yaml With Elasticsearch the search field use for sorting by callnumber is "local-classification" (from Koha::SearchEngine::Elasticsearch::QueryBuilder::_convert_sort_fields). So this search field must be sortable in default mappings.yaml. If not you see this error in logs : No mapping found for [local-classification__sort] Test plan : 1) Install Koha with Elasticsearch with mappings.yaml from sources (admin/searchengine/elasticsearch/mappings.yaml) 2) Reset mappings 3) Rebuild indexes 4) Perform a search 5) Check sorting by callnumber is OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26051] Elasticsearch field local-classification must be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26051] Elasticsearch field local-classification must be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 Fridolin SOMERS changed: What|Removed |Added CC||alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26051] New: Elasticsearch field local-classification must be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 Bug ID: 26051 Summary: Elasticsearch field local-classification must be sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com With Elasticsearch the search field use for sorting by callnumber is "local-classification" (from Koha::SearchEngine::Elasticsearch::QueryBuilder::_convert_sort_fields). So this search field must be sortable in default mappings.yaml. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26051] Elasticsearch field local-classification must be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 Fridolin SOMERS changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20469] Add item status to staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20469 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #31 from Marcel de Rooy --- Back to SO queue The patch has been simplified. And actually no longer part of the former discussion.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
