[Koha-bugs] [Bug 26095] New: [20.05] OPAC catalogue search not working on another language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26095 Bug ID: 26095 Summary: [20.05] OPAC catalogue search not working on another language Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: ctw2...@protonmail.com QA Contact: testo...@bugs.koha-community.org filter doesn't work when I click some Chinese Author name on the side bar for instance, I click some Chinese Author on the side bar, the result shows almost all the books, but I try to click some English Author, the result shows like normal, I also try to rebuild the zebra, nothing changed, the problem still remain, what should I do? Is this a BUG or my zebra setting problem? If it's my zebra setting, what should I do? I didn't find any doc for zebra language setting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3
--- Comment #20 from David Cook ---
Consider the following code:
#!/usr/bin/perl
use strict;
use warnings;
use URI::Escape;
use Template;
my $one = uri_unescape('https://www.google.com/url?q=https://buttercup.pw;');
my $two =
uri_unescape('https://www.google.com/url?q=https%3A%2F%2Fbuttercup.pw%22');
my $template = Template->new();
my $output;
$template->process( \*DATA, { one => $one, two => $two }, \$output );
warn $output;
__DATA__
[% one | url %]
[% two | url %]
Consider the output:
https://www.google.com/url?q=https://buttercup.pw%22
https://www.google.com/url?q=https://buttercup.pw%22
Actually... while that *looks* good... that's not necessarily correct, because
the "correct" URL is actually
https://www.google.com/url?q=https%3A%2F%2Fbuttercup.pw%22
That said... the end-target will uri_unescape the value of the "q" key anyway,
so it shouldn't matter. Plus the URI standard says you may choose not to
percent encode the query component due to usability concerns...
But our test cases might also be overly simplistic. I wonder if I have any
real-life complex URLs for digital resources laying around...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26079] Use 008 positions 14-16 as authoritative authority entry type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26079 --- Comment #5 from Alex Buckley --- Created attachment 107559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107559=edit Bug 26079: If syspref is enabled display 008 positions 14-16 as auth type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26079] Use 008 positions 14-16 as authoritative authority entry type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26079 Alex Buckley changed: What|Removed |Added Attachment #107536|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #19 from David Cook --- Actually, after re-reading those specifications, I think maybe we *should* keep the "url" filter in the Template Toolkit template. If we consider the staff interface to be the "URI producer", then technically the problem is with storing URLs that contain encoded information. That said, maybe we would be better off storing encoded URLs in MARC 856$u, and then either passing those through to the interface with $raw, or decoding on the backend and then re-encoding using Template Toolkit. Technically, https://www.loc.gov/marc/bibliographic/bd856.html doesn't say anything about percent encoding, although all the examples contain percent encoded examples. That goes back to the URI standard that says a URI is always "encoded". Maybe we should be decoding it prior to putting it through the filter. Let me have a think about that... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #18 from David Cook --- Template Toolkit uses RFC 2396 (from 1998) for the url filter. Looking at RFC 2396 https://tools.ietf.org/html/rfc2396#section-2.4.2: "Data must be escaped if it does not have a representation using an unreserved character" However, it also says the following: "A URI is always in an "escaped" form, since escaping or unescaping a completed URI might change its semantics. Normally, the only time escape encodings can safely be made is when the URI is being created from its component parts; each component may have its own set of characters that are reserved, so only the mechanism responsible for generating or interpreting that component can determine whether or not escaping a character will change its semantics. Likewise, a URI must be separated into its components before the escaped characters within those components can be safely decoded." Note also the following: "Because the percent "%" character always has the reserved purpose of being the escape indicator, it must be escaped as "%25" in order to be used as data within a URI. Implementers should be careful not to escape or unescape the same string more than once, since unescaping an already unescaped string might lead to misinterpreting a percent data character as another escaped character, or vice versa in the case of escaping an already escaped string." Template Toolkit have changed the behaviour of the "uri" and "url" filters over time (http://www.template-toolkit.org/docs/manual/Filters.html#section_url). I think they also haven't interpreted RFC3986 correctly in regards to the double quote character... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #17 from David Cook --- Consider the following excerpt from the URI standard https://tools.ietf.org/html/std66#section-3.4: "However, as query components are often used to carry identifying information in the form of "key=value" pairs and one frequently used value is a reference to another URI, it is sometimes better for usability to avoid percent-encoding those characters." It seems like the standard itself (from 2005) mentions that URI encoding query components indiscriminately can be problematic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #16 from David Cook --- I think removing the "url" filter seems like the more reasonable solution to me. In this case, the ITEM_RESULT.uri is coming from a stored record in the staff interface, so we don't really need to filter unauthenticated untrusted user input. That said, an authenticated user with cataloguing privileges could put in malicious Javascript into a 856$u subfield. (Then again, an authenticated user with admin privileges could put malicious Javascript into OpacUserJS, so an authenticated staff interface user is always a bit of a risk.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 --- Comment #15 from David Cook --- (In reply to Lucas Gass from comment #14) > I ran into this problem today with double encoded URL parameters if > OPACURLOpenInNewWindow is turned on. Not sure why this is In Discussion, I > tested Jonathan's patch (which needs rebased) and it seems to work. I think Jonathan probably put it as "In Discussion" as it was a POC to him. Looking at the code... I don't really like this patch as it's trying to undo double-encoding (rather than just not double-encoding in the first place). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Add ID to installed plugins table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 --- Comment #10 from Katrin Fischer --- A small patch - using my QA powers here... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Add ID to installed plugins table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Add ID to installed plugins table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25953] Add ID to installed plugins table to ease styling and DOM mods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25953 Katrin Fischer changed: What|Removed |Added Attachment #107473|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 107558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107558=edit Bug 25953: Add ID to installed plugins table on plugins-home.pl This patch adds a "installed_plugins" ID to the table of installed plugins. The idea is that it will ease styling and DOM mods through Javascript. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #83 from Katrin Fischer --- I am sorry, but in initial testing, this makes the existing circulation related unit tests fail: Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 256 Tests: 49 Failed: 1) Failed test: 22 Non-zero exit status: 1 not ok 22 - CanBookBeIssued & AllowReturnToBranch At this point we also really need unit tests for the fixed behaviour in order to move on with these patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 --- Comment #25 from Katrin Fischer --- I think the CodeMirror option is much needed as we move more OPAC prefs, so really happy to see these patches. I think a nice improvement could be to have a "both" option - making both available and allow to choose, depending on what you are editing (former pref or news entry) While I and my coworkers will probably prefer HTML for editing the OPAC related bits, the libraries we support will more likely prefer the WYSIWYG for adding/editing news. Maybe by having 2 different Edit buttons/options or a split button, defaulting to the editor from the pref? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Katrin Fischer changed: What|Removed |Added Attachment #107363|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 107556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107556=edit Bug 22660: (follow-up) Re-word system preference description This patch rewords the system preference description to focus on the generic description of the editor rather than the name of the plugin: tinymce: "a WYSIWYG editor (TinyMCE)" codemirror: "a text editor (CodeMirror)" Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 --- Comment #24 from Katrin Fischer --- Created attachment 107557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107557=edit Bug 22660: (QA follow-up) Fix capitalization in system preference Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Katrin Fischer changed: What|Removed |Added Attachment #107361|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 107554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107554=edit Bug 22660: Add system pref to allow switching of editors in News Tool This patch adds a system preference called 'NewsToolEditor' which allows for the choice between TinyMCE and CodeMirror in the News Feature. TEST PLAN: 1. Apply patch and run updatedatabase 2. Go to Tools > News and make a new entry or edit an existing News item. 3. When you initially load you should gte the TinyMCE editor (WYSIWYG) 4. Search for the NewsToolEditor system preference and switch to CodeMirror. 5. Reload your News item and now you should see the CodeMirror editor. 6. Try saving content with both and maki sure it works. 7. Try adding some different HTML tags in CodeMirror mode, saving, and making sure it looks right when you switch back to TinyMCE Signed-off-by: Owen Leonard Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22660] Allow use of CodeMirror for editing HTML in the news editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22660 Katrin Fischer changed: What|Removed |Added Attachment #107362|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 107555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107555=edit Bug 22660: (follow-up) Improve asset handling, add linting This patch makes some changes to the way assets are included based on the value of the system preferece in order to minimize unnecessary JavaScript includes. The patch also adds HTML syntax-highlighting and linting like we have in the system preferences editor. Removed are two JS files which were not required. To test, apply the patch and set the NewsToolEditor preference to "CodeMirror." - Edit a news item and confirm that the contents of the editor show HTML syntax highlighting. - Test HTML linting by adding some malformed HTML (missing closing tag, for instance). The error should be highlighted. - Set the NewsToolEditor to "TinyMCE" and confirm that WYSIWYG editing still works correctly. https://bugs.koha-community.org/show_bug.cgi?id=22600 Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26070] Google Transliterate API has been deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26070 Katrin Fischer changed: What|Removed |Added Text to go in the||The Google Transliterate release notes||API has been deprecated by ||Google in 2011. This ||removes the remaining code ||and ||GoogleIndicTransliteration ||system preference from Koha ||as this is no longer ||functional. Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26070] Google Transliterate API has been deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26070 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26070] Google Transliterate API has been deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26070 --- Comment #4 from Katrin Fischer --- Created attachment 107553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107553=edit Bug 26070: Remove GoogleIndicTransliteration system preference The Google Transliterate API was deprecated on May 26, 2011. This patch removes the feature and associated system preference. To test, apply the patch and run the database update process. - Go to Administration -> System preferences and search for 'GoogleIndicTransliteration.' There should be no results. - Search the Koha codebase for references to 'GoogleIndicTransliteration.' There should be no current references.. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default and add column configuration options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default and add column configuration options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968 --- Comment #5 from Katrin Fischer --- Extended the bug description a bit and it looks like this also fixed the date sorting for different formats? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default and add column configuration options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968 Katrin Fischer changed: What|Removed |Added Attachment #106967|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 107552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107552=edit Bug 25968: Make logs sort by date descending as a default This patch adds DataTables with columns configuration to the log viewer. The table of log entries is now sorted by default by date descending. To test, apply the patch and go to Administration -> Table settings. - Expand the "Tools" section and confirm that there is a section for "logviewer." - Go to Tools -> Log viewer. - Perform a search which will return multiple results. - Confirm that the results are sorted by date descending. - Test that the table controls work correctly: Paging, columns, export. - Return to the Table settings administration page and test that changes to those settings are correctly reflected in the log viewer table. Signed-off-by: barbara Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25968] Make logs sort by date descending as a default and add column configuration options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968 Katrin Fischer changed: What|Removed |Added Summary|Make logs sort by date |Make logs sort by date |descending as a default |descending as a default and ||add column configuration ||options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25694] Add ability to delete a Marc Modification Template when viewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25694 Katrin Fischer changed: What|Removed |Added Attachment #107468|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 107551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107551=edit Bug 25694: Add ability to delete a Marc Modification Template when viewing This patch adds a "delete template" button to the MARC modification templates "Edit actions" view. To test, apply the patch and go to Tools -> MARC modification templates. - On the main MARC modification templates page the toolbar should have only one button: "New template." - Click the "Edit actions" button for an existing template. - On the "Actions for..." view there should be three buttons, "New template," "New action," and "Delete template." - Test that the "Delete template" button works correctly. Signed-off-by: Kelly McElligott Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25694] Add ability to delete a Marc Modification Template when viewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25694 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25694] Add ability to delete a MARC modification template when viewing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25694 Katrin Fischer changed: What|Removed |Added Status|Passed QA |BLOCKED Summary|Add ability to delete a |Add ability to delete a |Marc Modification Template |MARC modification template |when viewing|when viewing --- Comment #5 from Katrin Fischer --- Hi Kelly, if you could sign off on the dependent bug 26055 too, it would be great and help to get this moving faster. I'll PQA but set it to BLOCKED until the dependency is PQA as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26065] Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Katrin Fischer changed: What|Removed |Added Attachment #107430|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 107550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107550=edit Bug 26065: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js This patch removes the
[Koha-bugs] [Bug 26065] Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26065 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #51 from Katrin Fischer --- Hi Jonathan, you were right - the last patch was not needed. I had forgotten to do a yarn build before when testing :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107427|0 |1 is obsolete|| --- Comment #50 from Katrin Fischer --- Created attachment 107549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107549=edit Bug 22087: Add missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107424|0 |1 is obsolete|| --- Comment #48 from Katrin Fischer --- Created attachment 107547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107547=edit Bug 22087: Remove padding on li's Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107425|0 |1 is obsolete|| --- Comment #49 from Katrin Fischer --- Created attachment 107548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107548=edit Bug 22087: Move the email into the list Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107421|0 |1 is obsolete|| --- Comment #45 from Katrin Fischer --- Created attachment 107544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107544=edit Bug 22087: Add space between zipcode and country Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107422|0 |1 is obsolete|| --- Comment #46 from Katrin Fischer --- Created attachment 107545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107545=edit Bug 22087: Add a no_line_break parameter to prevent new lines Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107423|0 |1 is obsolete|| --- Comment #47 from Katrin Fischer --- Created attachment 107546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107546=edit Bug 22087: Prevent variable names colision We should not use PROCESS: http://www.template-toolkit.org/docs/manual/Directives.html " The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template. " The 'patron' variable is reused by patron-title.inc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] Show city and state in patron search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What|Removed |Added Attachment #107420|0 |1 is obsolete|| Attachment #107428|0 |1 is obsolete|| --- Comment #44 from Katrin Fischer --- Created attachment 107543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107543=edit Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25853] update_patrons_category.pl has incorrect permissions in repo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25853 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26060] Replace staff interface table sort icons with SVG
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26060 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26060] Replace staff interface table sort icons with SVG
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26060 --- Comment #4 from Katrin Fischer --- Could we have this for the OPAC as well, please? (thinking of the item table especially) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26060] Replace staff interface table sort icons with SVG
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26060 Katrin Fischer changed: What|Removed |Added Attachment #107432|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 107542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107542=edit Bug 26060: Replace staff interface table sort icons with SVG This patch modifies the staff interface CSS to convert table sorting icons from PNG to SVG. These icons are added via background-image data-urls, so only the SCSS file is modified. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). - Clear your browser cache if necessary - View any DataTable in the staff interface, for instance when checking out to a patron with existing checkouts, the catalog detail page for a title with holdings, the table of saved reports. - Confirm that the sorting icons in the table headers look correct in each state: Sorted ascending, sorted descending, and unsorted. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26061] Improve style of sidebar datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 --- Comment #4 from Katrin Fischer --- I think this is a good improvement, but I wonder if those date fields wouldn't look a little nicer if they were even a little shorter - at the moment they are very wide compared to date fields in other places (patron record for example). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26061] Improve style of sidebar datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26061] Improve style of sidebar datepickers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26061 Katrin Fischer changed: What|Removed |Added Attachment #107426|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 107541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107541=edit Bug 26061: Improve style of sidebar datepickers This patch makes a small change to the staff interface CSS so that datepicker form fields in sidebar forms don't force the datepicker icon onto a second line. The change uses the CSS calc() function to specify that form fields with a .hasDatepicker class (dynamically added by jqueryUI) have a width of 100% minus 20 pixels, leaving room for the datepicker icon. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). - View a page in the staff interface which has a datepicker field in a sidebar form and confirm that the icon stays on the same line as the firm field at varying browser widths. Examples: - Reports -> Saved SQL reports - Circulation -> Overdues - Acquisitions -> Late orders Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 Katrin Fischer changed: What|Removed |Added Attachment #107521|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 107540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107540=edit Bug 26083: Item editor defaults to lost When editing an item via additem.pl, koha defaults to the first available lost status, rather than defaulting to not-lost. Test Plan: 1) Ensure you do not have a value ClaimReturnedLostValue 2) Edit an existing item that is not lost 3) Note the lost value is set even though it is not lost 4) Apply this patch 5) Edit a different item that is not lost 6) Note the lost value is not set! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- I ran into this problem today with double encoded URL parameters if OPACURLOpenInNewWindow is turned on. Not sure why this is In Discussion, I tested Jonathan's patch (which needs rebased) and it seems to work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25982] OPAC shelves RSS link output is HTML not XML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25982 Katrin Fischer changed: What|Removed |Added Summary|OPAC shelves RSS link |OPAC shelves RSS link |output is html not xml |output is HTML not XML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25958] Allow LongOverdue cron to exclude specified lost values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25958 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #107461|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 107538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107538=edit Bug 25958: Allow LongOverdue cron to exclude specified lost values When lost items are not marked as returned, they are still subject to the long overdue cron, so an item that has already been marked Lost may automatically roll to Long Overdue. In some cases, a library may not want that lost value to change. This becomes especially important with the introduction of Claims Returned, which uses a variety of lost. Test Plan: 1) Set up a long overdue item that would be moved to lost by longoverdue.pl 2) Run the cronjob with the new --skip-lost-value option 3) Note the item is not altered 4) Include that value in the new system preference DefaultLongOverdueSkipLostStatuses 5) Run the cronjob *without* the new option 6) Note the item is not altered 7) Run the cronjob again with the new command line option, but set it to a different value so the item will be affected 8) Note the item is altered as it would have been before this patch was applied Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25982] OPAC shelves RSS link output is html not xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25982 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25982] OPAC shelves RSS link output is html not xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25982 Katrin Fischer changed: What|Removed |Added Attachment #107441|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 107539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107539=edit Bug 25982: OPAC shelves RSS link output is xml Output rss feed as text/xml Test plan: 1) have books entered 2) log in create a list 3) add books to list 4) display list in OPAC 5) click the RSS link button. -- output is displayed as html text 6) apply patch 7) repeat steps 4&5 -- output is displayed as xml tree Signed-off-by: Sally Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Katrin Fischer changed: What|Removed |Added Attachment #107170|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 107537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107537=edit Bug 25351: Move cart-related strings out of opac-bottom.inc and into basket.js This patch adds the necessary JavaScript includes to the OPAC to enable translation of strings in JavaScript. It also updates the translation of cart-related strings by removing the strings from opac-bottom.inc and putting them in basket.js where they are used. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from bootstrap/js/basket.js for translation, e.g.: #: koha-tmpl/opac-tmpl/bootstrap/js/basket.js:89 msgid "Your cart is currently empty" msgstr "" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR In the OPAC, switch to the language you're testing. Confirm that your translated string appears. In the above example, by clicking the "Cart" icon in the header when there are no items in the cart. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26079] Use 008 positions 14-16 as authoritative authority entry type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26079 --- Comment #4 from Alex Buckley --- Created attachment 107536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107536=edit Bug 26079: If syspref is enabled display 008 positions 14-16 as auth type -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26079] Use 008 positions 14-16 as authoritative authority entry type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26079 --- Comment #3 from Alex Buckley --- Created attachment 107535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107535=edit Bug 26079: Import all authority records into default auth type if syspref enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23824] Add a ‘Save and run’ button to reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Jeff Gaines changed: What|Removed |Added CC||jga...@arlingtonva.us --- Comment #3 from Jeff Gaines --- I would like to see this, too. Saving one click does not seem like a lot, but it adds up over time, especially when writing and testing new queries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25698] Curbside Pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 Galen Charlton changed: What|Removed |Added Change sponsored?|--- |Seeking cosponsors --- Comment #6 from Galen Charlton --- Equinox proposes to add support for curbside pickup functionality along similar lines to what we wrote for Evergreen. The specifications we propose to follow can be found at: https://yeti.equinoxinitiative.org/dev/public/techspecs/curbside_koha.pdf The workflow that this feature would support is diagrammed here: https://yeti.equinoxinitiative.org/dev/public/techspecs/curbside_koha_flowchart.pdf As noted in the specs, we are planning to initially write this as a plugin for the sake of development, but we'll code it in such a way that it could be submitted as a core Koha feature if there turns out to be a long-term need for curbside pickup management. We are seeking cosponsors to help fund the work; if you might be interested in helping out, please Andrea Neiman at abnei...@equinoxinitiative.org. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Owen Leonard changed: What|Removed |Added Attachment #107534|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 --- Comment #1 from Owen Leonard --- Created attachment 107534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107534=edit Bug 26093: Markup error after Bug 24279 creates formatting problem This patch makes a few minor changes to the markup of the item detail page in order for everything to be valid and styled correctly: - Remove unnecessary and invalid - Move heading inside container so that floats clear correctly - Change tag back to to enable the correct style. To test, apply the patch and view the item details page for a title with multiple items. - Each section starting with "Barcode" should be bordered above by a two-pixel gray line - The "statuses" section should be styled like the areas above and below, not as an ordered list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #76 from Lari Taskula --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26029] Can't charge shipping to a fund with $0 allocated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26029 --- Comment #2 from Andrew Fuerste-Henry --- Confirmed! Good catch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #75 from Lari Taskula --- Created attachment 107533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107533=edit Bug 25089: (OLD GUI) Indent and add checkout type to all_rules hash No other changes in this patch. To test: 1. git diff --word-diff=color --ignore-all-space HEAD~1 -- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt 2. Observe only $ct has been added Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103545|0 |1
is obsolete||
--- Comment #73 from Lari Taskula ---
Created attachment 107531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107531=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #104274|0 |1 is obsolete|| --- Comment #74 from Lari Taskula --- Created attachment 107532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107532=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. First apply all the patches tagged with (OLD GUI) prefix in commit title 2. Go to Circulation rules page in Koha 3. Observe checkout type column in the rule matrix 4. Test circulation rules matrix by setting, modifying and deleting rules. 5. Test default checkout, hold and return policy settings. 6. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103542|0 |1
is obsolete||
--- Comment #70 from Lari Taskula ---
Created attachment 107528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107528=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103544|0 |1
is obsolete||
--- Comment #72 from Lari Taskula ---
Created attachment 107530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107530=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103543|0 |1
is obsolete||
--- Comment #71 from Lari Taskula ---
Created attachment 107529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107529=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103541|0 |1 is obsolete|| --- Comment #69 from Lari Taskula --- Created attachment 107527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107527=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103540|0 |1 is obsolete|| --- Comment #68 from Lari Taskula --- Created attachment 107526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107526=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103539|0 |1 is obsolete|| --- Comment #67 from Lari Taskula --- Created attachment 107525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107525=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103537|0 |1 is obsolete|| --- Comment #65 from Lari Taskula --- Created attachment 107523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107523=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103538|0 |1 is obsolete|| --- Comment #66 from Lari Taskula --- Created attachment 107524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107524=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26035] AutoMemberNum fails on very large cardnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26035] AutoMemberNum fails on very large cardnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035 --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 107522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107522=edit Bug 26035: AutoMemberNum should support cardnumbers up to 32 characters To test: 1- create a patron with cardnumber 12345678901234567890123456789012 (or any 32 character number) 2- turn on AutoMemberNum 3- create a new patron, save without a cardnumber 4- confirm that new patron has a cardnumber one more than the number from step 1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21811] Add warning when order receive form is saved without entering 'quantity received'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26081 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26081] 0 items in an order cannot be received do to invalid date handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26081 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21811 --- Comment #5 from Katrin Fischer --- I actually filed a bug for that, because I forgot to fill in quantity received a lot: Bug 21811 - Add warning when order receive form is saved without entering 'quantity received' I think a Javascript check or simply marking the field required (as in has to be greater 1 for saving)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26053] Adding more details to the manual about Patron Restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #7 from Katrin Fischer --- Hm, maybe it could be greyed out or striked through? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20813] Revamp user permissions system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #14 from Lari Taskula --- This would be really really really useful. The permission bits are one big headache because features introducing new ones will conflict with one another. And what about Koha plugins? Can they currently even add custom permission modules without eventually conflicting the bit value? +1 to this Bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #33 from hannah...@northwestu.edu --- Moved my comment to a new bug - bug 26094 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26094] New: "Suggest for Purchase" button missing unique CSS class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26094
Bug ID: 26094
Summary: "Suggest for Purchase" button missing unique CSS class
Change sponsored?: ---
Product: Koha
Version: 20.05
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: hannah...@northwestu.edu
QA Contact: testo...@bugs.koha-community.org
"Suggest for purchase" has no class for CSS manipulation. The other
opac-detail-sidebar.inc buttons each have a class on the link element
("reserve" or "print-large") so they can be hidden or appearance changed using
CSS.
I don't think adding/changing system preferences is necessary, just adding a
class to the link in
Koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
(currently on line 37)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #12 from Marcel de Rooy --- (In reply to Owen Leonard from comment #11) > Can you explain more about how the URL field is supposed to be used? Where > do the URLs come from? Good question. I leave some room for customization here too. (We use the AR slip and OCR to tag scanned files with the article request number. And then use opac/svc/requests (see bug 20570 follow-up) to add a Dropbox link to the request.) But bug 20570 also contains complete_article_requests.pl to match uploaded files in Koha with article requests. Apart from bug 20570, this development here allows you to manually add links (without saying how they were created indeed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #107520|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 107521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107521=edit Bug 26083: Item editor defaults to lost When editing an item via additem.pl, koha defaults to the first available lost status, rather than defaulting to not-lost. Test Plan: 1) Ensure you do not have a value ClaimReturnedLostValue 2) Edit an existing item that is not lost 3) Note the lost value is set even though it is not lost 4) Apply this patch 5) Edit a different item that is not lost 6) Note the lost value is not set! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- Initial impressions: In the navbar when there are no added lists and the user is NOT logged in the text breaks ‘Log in to create your own lists’. (https://snipboard.io/YZdXTv.jpg) This seems to look fine once you have a list, even if the list name is long: (https://snipboard.io/9CAMFl.jpg) On the item details page the More Searches dropdown (inside #ulactioncontainer) is not a dropdown. Maybe its missing a div container with the dropdown-menu class? (https://snipboard.io/jcB4Mf.jpg) There are many inputs that get a Koha green border when focused that now also get the Bootstrap blue border, they look odd when paired: (https://snipboard.io/6KajBs.jpg) When you view your cart (basket ) the remove, add to list, place hold buttons are blue when disabled and blue when enabled so its hard to tell the difference. They used to be grey when disabled. (https://snipboard.io/uE7zwb.jpg) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Owen Leonard changed: What|Removed |Added Blocks||26093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 [Bug 26093] Markup error after Bug 24279 creates formatting problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26093] New: Markup error after Bug 24279 creates formatting problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093 Bug ID: 26093 Summary: Markup error after Bug 24279 creates formatting problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: and...@bywatersolutions.com, bwsdo...@gmail.com, gmcha...@gmail.com, jonathan.dru...@bugs.koha-community.org, katrin.fisc...@bsz-bw.de, ke...@bywatersolutions.com, kyle.m.h...@gmail.com, k...@bywatersolutions.com, m.de.r...@rijksmuseum.nl, martin.renvo...@ptfs-europe.com Depends on: 24279 After Bug 24279 the "Statuses" section on the item detail page (moredetail.pl) isn't formatted correctly. The ordered list no longer has the correct CSS applied because the container changed from to Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20472] Add digital scan as optional format to Article Requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20472 --- Comment #11 from Owen Leonard --- Can you explain more about how the URL field is supposed to be used? Where do the URLs come from? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Kyle M Hall changed: What|Removed |Added Blocks||26083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 [Bug 26083] Item editor defaults to lost -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 --- Comment #1 from Kyle M Hall --- Created attachment 107520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107520=edit Bug 26083: Item editor defaults to lost When editing an item via additem.pl, koha defaults to the first available lost status, rather than defaulting to not-lost. Test Plan: 1) Ensure you do not have a value ClaimReturnedLostValue 2) Edit an existing item that is not lost 3) Note the lost value is set even though it is not lost 4) Apply this patch 5) Edit a different item that is not lost 6) Note the lost value is not set! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 Kyle M Hall changed: What|Removed |Added Depends on||24279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26083] Item editor defaults to lost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26091] Add column configuration and export options to catalog statistics report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26091 --- Comment #1 from Owen Leonard --- Created attachment 107519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107519=edit Bug 26091: Add column configuration and export options to catalog statistics report This patch makes the catalog statistics report output a DataTable with on-the-fly column configuration and export options. Because the report can generate results with an arbitrary set of table headers, the columns set to be passed to DataTables is built on the fly along with the table. There is no global table setting. Since the "grand total" cell might reflect a total which includes hidden columns, the table footer label now indicates "all results." To test, apply the patch and go to Reports. - Submit a query to the "catalog" statistics wizard which will return multiple results. - On the results page, confirm that the DataTable displays correctly and that all controls work as expected, including column configuration and export options. - Submit other queries which will return a different set of columns in the result. Confirm that everything continues to work as expected. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
