[Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886 --- Comment #9 from Mason James --- (In reply to Mason James from comment #8) > (In reply to Phantom from comment #7) > > Same error when tried the instructions as was pointed out. > > > > In addition, I also brought down Ubuntu 18.04 and tried to install Koha and > > got the same error. you can quickly verify that the install procedure works, using docker... $ docker -v Docker version 19.03.12, build 48a66213fe $ docker run -ti ubuntu:18.04 bash root@23e24cb24a95:/# apt-get update root@23e24cb24a95:/# apt-get -y install wget gnupg2 root@23e24cb24a95:/# wget -q -O- http://debian.koha-community.org/koha/gpg.asc | apt-key add - root@23e24cb24a95:/# echo 'deb http://debian.koha-community.org/koha stable main bionic' | tee /etc/apt/sources.list.d/koha.list root@23e24cb24a95:/# apt-get update root@23e24cb24a95:/# apt-get -y install koha-common root@23e24cb24a95:/# apt-cache policy koha-common koha-common: Installed: 20.05.02-1 << Candidate: 20.05.02-1 Version table: *** 20.05.02-1 500 500 http://debian.koha-community.org/koha stable/main amd64 Packages 100 /var/lib/dpkg/status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26140] .tt template files should be deployed separately from static assets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26140 --- Comment #10 from David Cook --- Maybe... it is too hard to change the ageing monolith. I guess at a bare minimum maybe we should just stop serving .tt pages through the web server... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26140] .tt template files should be deployed separately from static assets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26140 --- Comment #9 from David Cook --- (In reply to Marcel de Rooy from comment #2) > What about adding one line in Apache to stop it instead of moving hundreds > of files in git ? In hindsight, I didn't actually say we should move the files in git, but your question got me thinking that was what we were talking about. Originally, I was actually talking about the "deployment" path rather than the "source" path. We could change the Makefile.PL to put the static assets somewhere different. That would be the most minimal change. Although we'd still need to update templates and potentially other files to point to the new paths. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26140] .tt template files should be deployed separately from static assets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26140 David Cook changed: What|Removed |Added Summary|.tt template files should |.tt template files should |be stored separately from |be deployed separately from |static assets |static assets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26140] .tt template files should be stored separately from static assets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26140 David Cook changed: What|Removed |Added Summary|Move .tt files to a tt/ |.tt template files should |template root directory |be stored separately from ||static assets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26140] Move .tt files to a tt/ template root directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26140 --- Comment #8 from David Cook --- Actually, I should've realized before, but the smarter thing would be not moving the template files, but rather moving the static assets, and then changing Apache's DocumentRoot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26140] Move .tt files to a tt/ template root directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26140 --- Comment #7 from David Cook --- Maybe a more feasible path forward would be to start putting "new" templates into a "new" filesystem path. C4::Template::_get_template_file() could look in both locations. Looking at it now, I see that has consequences for translations though... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26140] Move .tt files to a tt/ template root directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26140 --- Comment #6 from David Cook --- (In reply to Marcel de Rooy from comment #5) > Git should be able to apply a commit referring to the old location. > With history, you need to remember to add the --follow flag to see the old > commits for the former location. Humans tend to remember badly ;) That's true. I figured that's probably what you meant, but figured I'd ask anyway. I know that re-structures are really hard to do with a project of this size and age, but I think that they're still worth doing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25361] Support X-Forwarded-* headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25361 David Cook changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25361] Support X-Forwarded-* headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25361
--- Comment #6 from David Cook ---
(In reply to Marcel de Rooy from comment #5)
> I do not understand what this report is about. We already have support for
> X-Forwarded headers. So what is the point ?
It's been a while since I reported this one, so I'm not 100% sure of my
original intent. I didn't word it very well.
However, in Koha, we actually only use X-Forwarded-For and X-Forwarded-Proto.
Bug 23068 explicitly uses X-Forwarded-For, while X-Forwarded-Proto is used by
Plack::Middleware::ReverseProxy to set $ENV->{HTTPS} to true.
Apache's mod_proxy_http automatically sets X-Forwarded-For, X-Forwarded-Host,
and X-Forwarded-Server, I believe, but doesn't do others like X-Forwarded-Proto
(which is why Tomas added it in Bug 21267).
AWS load balancers pass X-Forwarded-For, X-Forwarded-Proto, and
X-Forwarded-Port.
I mostly see utility for X-Forwarded-For and X-Forwarded-Proto. Not really sure
why a person would care about X-Forwarded-Port
I think I'll close this one for now.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26155] SPAM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26155 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Hacked by in sanz |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26019] Koha should set SameSite attribute on cookies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 --- Comment #3 from David Cook --- (In reply to Marcel de Rooy from comment #2) > Why wouldnt we add a preference like SameSiteCookie to include cookie names > that do not want to default to Lax ? Why should we let librarians determine cookie settings? It seems to me that we as developers are best suited to making those choices? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26155] New: Hacked by in sanz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26155 Bug ID: 26155 Summary: Hacked by in sanz Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: ganssa...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 107862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107862=edit Yuy Wlawkawka -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26147] Add script to recalculate due dates after changes to the calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26147 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #39 from Aleisha Amohia --- So to confirm, this patch will not only fix the group_by error but we also want to fix the Holds to Pull to show the highest priority hold instead of the earliest placed hold? Because currently it shows the earliest placed hold. Happy to make this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25961] Add hooks for plugins to inject variables to XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25961 --- Comment #22 from Aleisha Amohia --- (In reply to Tomás Cohen Arazi from comment #21) > (In reply to Aleisha Amohia from comment #20) > > enhancement, not backported to 19.11.x > > This is a handy one :-) It may be handy but it's still very much an enhancement and not fixing any bugs. I did discuss with Hayley and Chris and they agree that enhancements like these are just worth upgrading for. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26145] Add the ability to attach a cover image at item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16748] Batch checkout needs set due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Henry Bolshaw changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #14 from Henry Bolshaw --- The patch doesn't add a due date picker to batch checkout. Instead it adds one to the batch renew page. Is this a copy and paste issue from the very similar patch for for bug 16112? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11469] Publication date range assumes that years must always be 4 digits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11469 --- Comment #4 from Katrin Fischer --- > The adv search did not allow publication years prior to 1000 > We are now ready for year 1 We might be - but MARC definitely is not :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26125] In 'Patron search' tab link should lead to patron details instead of checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26125 Katrin Fischer changed: What|Removed |Added Attachment #107684|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 107861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107861=edit Bug 26125: (bug 23697 follow-up) open patron's details in autocompletion search Test plan: 1 - Enable PatronAutoComplete syspref 2 - Go to "Patrons" (members/members-home.pl) 3 - Enter a patron first letters in "Search Patron" tab 4 - Select a patron 5 - You're wrongly redirected in koha/circ/circulation.pl 6 - Apply patch 7 - Repeat 3, 4 8 - You're correctly redirected in koha/members/moremember.pl 9 - double check "Check out" redirect hasn't changed Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26125] In 'Patron search' tab link should lead to patron details instead of checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26125 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25791] SCO print dialog pops up twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25791 ByWater Sandboxes changed: What|Removed |Added Attachment #106941|0 |1 is obsolete|| --- Comment #6 from ByWater Sandboxes --- Created attachment 107860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107860=edit Bug 25791: Remove win.print() Test plan: 1) Turn on system preference SelfCheckReceiptPrompt 2) Check out item via /cgi-bin/koha/sco/sco-main.pl 3) Click "Finish" 4) Click 'Print receipt and end session' 5) Notice two print dialog boxes right on top of each other 6) Apply patch 7) Repeat steps 1 - 4 8) Should only get a single print dialog. 9) Test in FF/Chrome and make sure behavior is consistent Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6725] Make patron duplicate matching flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6725 ByWater Sandboxes changed: What|Removed |Added Attachment #107846|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 107859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107859=edit Bug 6725: Make patron duplicate matching flexible This patch adds a new system preference PatronDuplicateMatchingAddFields to list the patron's attributes to use for deduplication. The default value is surname, firstname and dateofbirth to keep existing behaviour. Test plan: 0. Apply the patch and execute the update DB entry 1. Create a new patron with surname, firstname 2. Create another patron with the same surname, firstname values => Confirm you get the duplicate warning 3. Modify the syspref to edit the list of attributes used to dedup 4. Repeat 1 and 2 with different values and confirm that you get the behaviours you expect Note: This is only impacting the add patron form from the UI, not the import patrons tool. Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26154] Remove the use of jquery.checkboxes plugin from batch item deletion and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 --- Comment #1 from Owen Leonard --- Created attachment 107858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107858=edit Bug 26154: Remove the use of jquery.checkboxes plugin from batch item deletion and modification This patch removes the use of the jquery.checkboxes plugin from the batch item modification and batch item deletion pages. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes. - On the results page, test the "Select all" and "Clear all" controls at the top of the page. These should work correctly on the checkboxes in the table of results. - Test that the "Clear on loan" control still works to uncheck checkboxes corresponding to items which are checked out. - Test the "Show all columns" and "Hide all columns" checkboxes in the "Show/hide columns" section. These should work correctly on the checkboxes for showing and hiding columns in the table. - Go to Tools -> Batch item deletion. - Submit a batch of barcodes. - Repeat the same testing steps above (except the "Clear on loan" step). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26154] Remove the use of jquery.checkboxes plugin from batch item deletion and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26154] New: Remove the use of jquery.checkboxes plugin from batch item deletion and modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 Bug ID: 26154 Summary: Remove the use of jquery.checkboxes plugin from batch item deletion and modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the batch item deletion and batch item modification pages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26154 [Bug 26154] Remove the use of jquery.checkboxes plugin from batch item deletion and modification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26153] Remove the use of jquery.checkboxes plugin from items lost report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26153 --- Comment #1 from Owen Leonard --- Created attachment 107857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107857=edit Bug 26153: Remove the use of jquery.checkboxes plugin from items lost report This patch removes the use of the jquery.checkboxes plugin from the lost items report page and replaces it with custom JS. To test, apply the patch and go to Reports -> Lost items. - Run the report with parameters which will return multiple results. - On the results page test the "Select all" and "Clear all" links at the top of the results. The controls should work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26153] Remove the use of jquery.checkboxes plugin from items lost report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26153 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26153 [Bug 26153] Remove the use of jquery.checkboxes plugin from items lost report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26153] New: Remove the use of jquery.checkboxes plugin from items lost report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26153 Bug ID: 26153 Summary: Remove the use of jquery.checkboxes plugin from items lost report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the items lost report results page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26152] Remove the use of jquery.checkboxes plugin from serial collection page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26152 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26152] Remove the use of jquery.checkboxes plugin from serial collection page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26152 --- Comment #1 from Owen Leonard --- Created attachment 107856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107856=edit Bug 26152: Remove the use of jquery.checkboxes plugin from serial collection page This patch removes the use of the jquery.checkboxes plugin from the serial collection page and replaces it with custom JS. To test, apply the patch and go to Serials. - Locate a subscription which has multiple issues. - View the details for that subscription. - In the sidebar menu click the "Serial collection" link. - On the serial collection page test the "Select all" and "Clear all" links at the top of each table of issues. The controls should work correctly and only affect the table on that tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Nick Clemens changed: What|Removed |Added Attachment #107832|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 107855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107855=edit Bug 25265: Prevent double reindex of the same item in batchmod When batch editing, 2 reindex calls are sent to ES/Zebra. We can easily avoid that reusing the skip_modzebra_update Additionally we should only send one request for biblio, and we should only do it if we succeed As the hwole batch mod is in a transaction it is possible to fail in which case Zebra queue is reset, but ES indexes have already been set In addition to the skip param this patchset makes ModZebra take lists of biblionumbers or records so that multiple records can be passed in one call Test plan: 1 - Have a bib with several items, none marked 'not for loan' 2 - Do a staff search that returns this biblio 3 - Items show as available 4 - Click on title to go to details page 5 - Edit->Item in a batch 6 - Set the not for loan status for all items 7 - Repeat your search 8 - Items show as not for loan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26152] New: Remove the use of jquery.checkboxes plugin from serial collection page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26152 Bug ID: 26152 Summary: Remove the use of jquery.checkboxes plugin from serial collection page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the serial collection page in the staff interface. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26152 [Bug 26152] Remove the use of jquery.checkboxes plugin from serial collection page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26151] Remove the use of jquery.checkboxes plugin from suggestions management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151
--- Comment #1 from Owen Leonard ---
Created attachment 107854
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107854=edit
Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions
management page
This patch removes the use of the jquery.checkboxes plugin from the
suggestions management page and replaces it with custom JS.
To test, apply the patch and go to Acquisitions -> Suggestions
Under each tab ("Accepted," "Pending," etc.), test that the "Check all"
and "Uncheck all" controls work correctly and only affect the table on
that tab.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26151] Remove the use of jquery.checkboxes plugin from suggestions management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26151] New: Remove the use of jquery.checkboxes plugin from suggestions management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Bug ID: 26151 Summary: Remove the use of jquery.checkboxes plugin from suggestions management page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the suggestions management page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 [Bug 26151] Remove the use of jquery.checkboxes plugin from suggestions management page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150 --- Comment #1 from Owen Leonard --- Created attachment 107853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107853=edit Bug 26150: Remove the use of jquery.checkboxes plugin from inventory page This patch removes the use of the jquery.checkboxes plugin from the inventory page and replaces it with custom JS. To test, apply the patch and go to Tools -> Inventory. - Submit the form with some selections which will return results on the following page. I filtered by library. - On the page showing results, test that the "Select all" and "Clear all" links work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150 [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26150] New: Remove the use of jquery.checkboxes plugin from inventory page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150 Bug ID: 26150 Summary: Remove the use of jquery.checkboxes plugin from inventory page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the inventory page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #105704|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #20 from Martin Renvoize --- Works as expected, no regressions found, passes qa scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #17 from Martin Renvoize --- Created attachment 107850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107850=edit Bug 25683: Patron with no accountlines should have 0 outstanding (not NULL) Test plan: - Have a patron with nothing in accountlines - run update_patron_categories to find patrons with fines under $5 (-fu=5) - Your patron is not found - Give your patron a manual charge of $1 - rerun the cron, your patron is found - pay off your patron's fine, putting their balance at $0 - rerun the cron, your patron is found Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Martin Renvoize changed: What|Removed |Added Attachment #107792|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 107852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107852=edit Bug 25683: (follow-up) Use COALESCE instead of IFNULL Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Martin Renvoize changed: What|Removed |Added Attachment #105705|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 107851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107851=edit Bug 25683: Fix grouping of results DBIX doesn't seem to work as I expected - if trying to group by we can only get the columns we grouped by, otherwise the queries are much more complicated and come out wrong This patch removes the 'amountoutstanding' from the query. Note that we do return patron object, however, to access all the columns we must discard_changes (or refetch) Also fixes a typo 'verbosse' To test: 1 - charge a $1 fine to a patron 2 - pay off the fine 3 - perl misc/cronjobs/update_patrons_category.pl -f J -t J -fu=5 -v 4 - Note the patron is returned twice 5 - export DBIC_TRACE=1 6 - repeat 3 - view the SQL query and see how odd it is 7 - Apply this patch 8 - repeat 3 - simpler query 9 - patron returned only once Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11469] Publication date range assumes that years must always be 4 digits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11469 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26149] Remove jquery.checkboxes plugin from problem reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 --- Comment #1 from Owen Leonard --- Created attachment 107849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107849=edit Bug 26149: Remove jquery.checkboxes plugin from problem reports page This patch removes the inclusion of the jquery.checkboxes plugin from the problem reports template in the staff interface. To test, apply the patch and make sure the OPACReportProblem system preference is enabled. - Submit a few OPAC problem reports if necessary - Go to Tools -> OPAC problem reports - Test that the "Select all" and "Clear all" controls at the top of the table work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26149] Remove jquery.checkboxes plugin from problem reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11469] Publication date range assumes that years must always be 4 digits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11469 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Simple patch that works as expected.. must admit I was expecting us to be doing something 'clever' like catching double-digit dates adding a prefix to make it up to four digits.. but as we're not doing anything like that already this patch seems perfect. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11469] Publication date range assumes that years must always be 4 digits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11469 Martin Renvoize changed: What|Removed |Added Attachment #107628|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 107848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107848=edit Bug 11469: Allow search by publication years with number of digits != 4 The adv search did not allow publication years prior to 1000 We are now ready for year 1 Test plan: Having some book with a publication year=123 (3 digits) Search this book by publication year => Search result must return it Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26098] JS error on the fund list view if no fund displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26098] JS error on the fund list view if no fund displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26098 Katrin Fischer changed: What|Removed |Added Attachment #107657|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 107847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107847=edit Bug 26098: Fix JS error on the fund list view when no fund displayed TypeError: this.data(...) is undefined in jquery.treetable.js Test plan: Go to the fund list view Select a filter that will return no result => With this patch applied there is no JS error in the console Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6725] Make patron duplicate matching flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6725 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- A nice enhancement that works well.. the code is clear and makes sense and we're passing the qa scripts.. Signing off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6725] Make patron duplicate matching flexible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6725 Martin Renvoize changed: What|Removed |Added Attachment #107824|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 107846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107846=edit Bug 6725: Make patron duplicate matching flexible This patch adds a new system preference PatronDuplicateMatchingAddFields to list the patron's attributes to use for deduplication. The default value is surname, firstname and dateofbirth to keep existing behaviour. Test plan: 0. Apply the patch and execute the update DB entry 1. Create a new patron with surname, firstname 2. Create another patron with the same surname, firstname values => Confirm you get the duplicate warning 3. Modify the syspref to edit the list of attributes used to dedup 4. Repeat 1 and 2 with different values and confirm that you get the behaviours you expect Note: This is only impacting the add patron form from the UI, not the import patrons tool. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26121] When using CodeMirror in News Tool DatePicker is hard to see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121 Katrin Fischer changed: What|Removed |Added Attachment #107696|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 107845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107845=edit Bug 26121: Add z-index for CodeMirror To test: 1. Make sure the system preference 'NewsToolEditor' is set to CodeMirror 2. Go add or edit some News content. 3. Add some content to the News section 4. Use the datepicker to pick a Publication date/Expiration date 5. Notice its very hard to see your dates overlapping with CodeMirror. 6. Apply patch 7. Much easier to see the dates! Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26121] When using CodeMirror in News Tool DatePicker is hard to see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16748] Batch checkout needs set due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 Henry Bolshaw changed: What|Removed |Added CC||bolsh...@parliament.uk --- Comment #13 from Henry Bolshaw --- I've tried testing this patch using a sandbox but I can't see the due date picker on the batch checkout screen. I'm new to the sandbox so it's possible I've made a mistake applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5428] Back to results after deleting a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- (In reply to Jonathan Druart from comment #5) > - Delete the record > => You are back to the adv search form but we new link "Go back to the > results" is present at the top of the page I'm not seeing the 'Go back to the results' link anywhere on the advanced search page after applying this patch and following the above step. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26146] Patron duplicate matching - fuzzy matching?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26146 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 Owen Leonard changed: What|Removed |Added Depends on||26149 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 [Bug 26149] Remove jquery.checkboxes plugin from problem reports page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26149] New: Remove jquery.checkboxes plugin from problem reports page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26149 Bug ID: 26149 Summary: Remove jquery.checkboxes plugin from problem reports page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: testo...@bugs.koha-community.org Blocks: 26006 The OPAC problem reports page in the staff interface includes the jquery.checkboxes plugin but doesn't use it. It can be removed without any JS code changes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Peter Vashchuk changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
Peter Vashchuk changed:
What|Removed |Added
Attachment #107683|0 |1
is obsolete||
--- Comment #6 from Peter Vashchuk ---
Created attachment 107844
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107844=edit
Bug 25711: add ExpireReservesMaxPickUpDelayCharge to circulation rules
Add a feature that allows to define ExpireReservesMaxPickUpDelayCharge
in circulation rules per specific items/patron categories.
When value not found in circulation rules it uses global
ExpireReservesMaxPickUpDelayCharge, as it was before this smart-rules
feature was introduced.
To check the feature after applying the patch:
1) Go to /cgi-bin/koha/admin/preferences.pl and set
ExpireReservesMaxPickUpDelay to allow.
1) Go to /cgi-bin/koha/admin/smart-rules.pl circulation rules table
and notice the newly added "Expire reserve charge" row.
2) In that row add numerical values to type/patron categories
that you will be using later to test this feature.
3) Prepare an item for our next step, pick a biblio that has item
with the same item type you altered in smart rules and check it out.
3) Place a hold on that item and set the expiration date as the
next day.
4) Check in it after that.
5) Do SQL request to change expiration date manually to "yesterday":
in "reserves" table, find the id of the hold that you placed and
"UPDATE reserves SET `expirationdate`='2020-07-19' WHERE
`reserve_id`=329;"
Or alternatively:
5) Wait for tomorrow, change server time or invent a time machine.
6) Run cancel_expired_holds.pl cron job.
7) Check that patron got charged in "accounting" left tab and
"transactions" upper tab: your patron should have debt of that amount
of fee you assigned in that rule
(/cgi-bin/koha/members/boraccount.pl?borrowernumber=...YourPatronID...)
8) You can repeat this with other rules and different
numbers/biblio/item types to check that different fees apply according
to smart rules.
9) If there's no matching smart rule or smart rule have an empty
string as a fee - global ExpireReservesMaxPickUpDelayCharge variable
value will be used.
10) But in case if matching rule has zero ("0") as a value - that
allows to have no-fee smart-rule results, as a feature.
IMPORTANT:
Smart-rules filters only applied to item-level holds, when item-type
for items is known. If there's biblio-level hold, then again global
ExpireReservesMaxPickUpDelayCharge value will be used (as well global
one can be empty or zero).
Mentored-by: Andrew Nugged
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26124] Console errors on tools_koha-news when editing with TinyMCE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26124 Katrin Fischer changed: What|Removed |Added Attachment #107726|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 107843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107843=edit Bug 26124: Load TinyMCE assets in correct order 1. Make sure NewsToolEditor is set to TinyMCE 2. Go to Home › Tools › News › Add news item 3. Observe console error 4. Apply patch 5. No console error Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26124] Console errors on tools_koha-news when editing with TinyMCE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26124 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26124] Console errors on tools_koha-news when editing with TinyMCE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26124 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26141] Duplicated code in search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26141 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26141] Duplicated code in search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26141 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26138] Errors if enable_plugins is zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26138 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26133] Unneeded calls in detail.pl can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26133 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26138] Errors if enable_plugins is zero
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26138 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26133] Unneeded calls in detail.pl can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26133 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26043] Holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26043 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26043] Holds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26043 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26037] openlibrary.org is hit on every Koha requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26037 Katrin Fischer changed: What|Removed |Added Attachment #107658|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 107842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107842=edit Bug 26037: openlibrary.org is hit on every Koha requests This patch moves the inclusion of Open Library JavaScript from opac-bottom.inc to the three templates where it might be used. In addition, the Open Library JS has been modified to check for the existence of the relevant markup on the page before executing a query. Unrelated: The Open Library label is now hidden when the status returned is "Not found." Previously this information was displayed. To test, apply the patch and enable the OpenLibrarySearch system preference. - Perform a search in the OPAC which will return results from Open Library. Some ISBNs: 0140423826, 0395082552, 0679436405. - On the search result page there should be an Open Library "Read now" button for each result that can be opened for reading in Open Library. - Add these titles to a list and view the list. - The "Read now" button should appear on the list page. - View the details for one of these titles. - The "Read now" button should appear on the page below the holdings. - Watch the browser's developer tools on these and other pages in the OPAC. There should be no errors in the console and no 404 errors in the network tab. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26037] openlibrary.org is hit on every Koha requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26037 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 --- Comment #5 from Jonathan Druart --- Created attachment 107840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107840=edit Bug 26143: Regression tests This patch introduces tests for the per_page=-1 handling use case. From now on per_page=-1 means 'all resources'. On writing this I noticed that we always paginate results no matter what, but there was a weird condition under which on pagination headers were sent back to the API consumer. This is highlighted in the precedent patch, which is not the -1 situation this one tries to tackle. Both pagination and searching are broken with per_page=-1, which is a standard, and we actually didn't explicitly set a way to request all resources. To verify this: 1. Apply the previous tests patch and this one 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Pagination.t \ t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Things are damn broken Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 Jonathan Druart changed: What|Removed |Added Attachment #107836|0 |1 is obsolete|| Attachment #107837|0 |1 is obsolete|| Attachment #107838|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 107839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107839=edit Bug 26143: The API is always paginated Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 --- Comment #6 from Jonathan Druart --- Created attachment 107841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107841=edit Bug 26143: Make the API handle per_page=-1 This patch introduces handling for per_page=-1 and actually adds a missing feature to the API: being able to request all resources on a route. To test this: 1. Visit the libraries admin page 2. On the table, choose to display 'All' rows => FAIL: it doesn't refresh, the browser console displays a 500 error code and so the logs 3. Apply the tests patches 4. Run: $ kshell k$ prove t/Koha/REST/Plugin/Pagination.t \ t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail loudly 5. Apply this patch 6. Restart plack 7. Repeat 2 => SUCCESS: choosing to display all, works 8. Repeat 4 => SUCCESS: Tests pass now! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26148] New: OpenLibrary "Preview" link target is unclear to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26148 Bug ID: 26148 Summary: OpenLibrary "Preview" link target is unclear to patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When you have OpenLibraryCovers turned on, there will be a "Preview" link showing below the cover that leads to the Open Library page of the title. I think we should make clear in the wording that the link is an external link that will lead you outside the library catalog and it should also open in a new tab. To test: - Activate OpenLibraryCovers - Search (in sample data) for: 0140423826 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16112] Specify due date for batch renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Henry Bolshaw changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bolsh...@parliament.uk --- Comment #4 from Henry Bolshaw --- I was able to follow the test plan and select a renewal date for batch renew. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26037] openlibrary.org is hit on every Koha requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26037 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] Cannot see "all" libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 107838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107838=edit Bug 26143: Make the API handle per_page=-1 This patch introduces handling for per_page=-1 and actually adds a missing feature to the API: being able to request all resources on a route. To test this: 1. Visit the libraries admin page 2. On the table, choose to display 'All' rows => FAIL: it doesn't refresh, the browser console displays a 500 error code and so the logs 3. Apply the tests patches 4. Run: $ kshell k$ prove t/Koha/REST/Plugin/Pagination.t \ t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail loudly 5. Apply this patch 6. Restart plack 7. Repeat 2 => SUCCESS: choosing to display all, works 8. Repeat 4 => SUCCESS: Tests pass now! 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] The API does not handle requesting all resources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Summary|Cannot see "all" libraries |The API does not handle ||requesting all resources Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] Cannot see "all" libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 107837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107837=edit Bug 26143: Regression tests This patch introduces tests for the per_page=-1 handling use case. From now on per_page=-1 means 'all resources'. On writing this I noticed that we always paginate results no matter what, but there was a weird condition under which on pagination headers were sent back to the API consumer. This is highlighted in the precedent patch, which is not the -1 situation this one tries to tackle. Both pagination and searching are broken with per_page=-1, which is a standard, and we actually didn't explicitly set a way to request all resources. To verify this: 1. Apply the previous tests patch and this one 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Pagination.t \ t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Things are damn broken Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26143] Cannot see "all" libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 107836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107836=edit Bug 26143: The API is always paginated Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16112] Specify due date for batch renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #107786|0 |1 is obsolete|| --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 107835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107835=edit Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Signed-off-by: Henry Bolshaw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #26 from Martin Renvoize --- (In reply to Bernardo Gonzalez Kriegel from comment #24) > (In reply to Jonathan Druart from comment #22) > > Switching to NSO to get feedback on the POC. > > Uploaded revised patch, now include files for de-DE, it-IT and nb-NO, > taken from their language dirs. > > With something like this de-DE is covered and main dir could be removed. > it-IT needs UNIMARC, more work to do > nb-NO uses NORMARC, this case needs more thinking > > > But any future language can be added there to have the few customizations > deemed essential by its maintainer. > > If this approach is accepted we need to change the Bug description. This looks great to me and seems to achieve what's desired.. but I'm not the target audience so I'm not comfortable doing a QA step.. I suppose doing the SO would politely push it into Katrins pile. One note though.. I don't see the additional languages you suggest you added in the above patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26147] New: Add script to recalculate due dates after changes to the calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26147 Bug ID: 26147 Summary: Add script to recalculate due dates after changes to the calendar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com With the pandemic, we saw a lot of libraries put a lot of near-future closures into their calendars. For libraries where useDaysMode prevents due dates on closed days, this meant a lot of checkouts with due dates that wouldn't have been allowed were the closures in place before the checkout happened. It would be helpful to have a command line script to recalculate due dates based on the current calendar and the useDaysMode syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
