[Koha-bugs] [Bug 19532] Recalls for Koha

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #107922|0   |1
is obsolete||

--- Comment #542 from Aleisha Amohia  ---
Created attachment 108226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108226=edit
Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation

- misc/cronjobs/recalls/expire_recalls.pl
- misc/cronjobs/recalls/overdue_recalls.pl
- tests for overdue fines in t/db_dependent/Circulation/CalcFine.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #107924|0   |1
is obsolete||

--- Comment #544 from Aleisha Amohia  ---
Created attachment 108228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108228=edit
Bug 19532: Recalls on OPAC

- place a biblio-level or item-level recall via the biblio detail page, OPAC
search results, or course reserves
- view or cancel your active recalls from 'your summary' recalls tab
- view all active and inactive (and cancel active) recalls from 'your recall
history'
- stopped from placing a reserve on an item that the patron has already
recalled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #107925|0   |1
is obsolete||

--- Comment #545 from Aleisha Amohia  ---
Created attachment 108229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108229=edit
Bug 19532: Recalls on intranet

See recalls on Intranet
- old recalls (all inactive recalls)
- recalls queue (all active recalls) - cancel, expire, revert waiting status,
multiple cancel, mark overdue
- recalls to pull (available but not yet waiting) - cancel
- recalls awaiting pickup (awaiting pickup, awaiting pickup more than
RecallMaxPickUpDelay days) - expire, revert waiting status
- overdue recalls (overdue to be returned) - cancel, multiple cancel
- biblio recalls tab (all active recalls relevant to this bib) - cancel,
expire, revert waiting status, mark overdue
- patron recalls tab (all active recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- patron recalls history tab (all recalls relevant to this patron) - cancel,
expire, revert waiting status, mark overdue
- log viewer

and the general circulation of recalls

Test plan in Comment 482.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #107923|0   |1
is obsolete||

--- Comment #543 from Aleisha Amohia  ---
Created attachment 108227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108227=edit
Bug 19532: Other objects used in recalls feature

- biblio->recalls
- biblio->can_be_recalled
- item->recall
- item->can_be_recalled
- item->can_set_waiting_recall
- item->check_recalls
- patron->recalls
- Biblio.RecallsCount

and relevant tests
- t/db_dependent/Stats.t
- t/db_dependent/Koha/Item.t
- t/db_dependent/Koha/Biblio.t
- t/db_dependent/Koha/Patron.t
- t/db_dependent/XSLT.t
- t/db_dependent/Search.t
- t/db_dependent/Holds.t
- t/db_dependent/Circulation/transferbook.t
- t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #107920|0   |1
is obsolete||

--- Comment #540 from Aleisha Amohia  ---
Created attachment 108224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108224=edit
Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #107918|0   |1
is obsolete||

--- Comment #538 from Aleisha Amohia  ---
Created attachment 108222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108222=edit
Bug 19532: Database and installer stuff

- Add recalls table
- Add recalls circulation rules - recalls allowed, recalls per record, on shelf
recalls, recall due date interval, recall overdue fine, recall shelf time
- Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog
- Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM)
- Add print notice (RECALL_REQUESTER_DET)
- Add user permission - recalls, manage_recalls
- Add Recall and CancelRecall enum options for branchtransfers reason

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #107919|0   |1
is obsolete||

--- Comment #539 from Aleisha Amohia  ---
Created attachment 108223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108223=edit
Bug 19532: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #107921|0   |1
is obsolete||

--- Comment #541 from Aleisha Amohia  ---
Created attachment 108225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108225=edit
Bug 19532: Recalls objects and tests

Koha/Recall.pm
- biblio
- item
- patron
- library
- checkout
- requested
- waiting
- overdue
- in_transit
- expired
- cancelled
- finished
- calc_expirationdate
- start_transfer
- revert_transfer
- set_waiting
- revert_waiting
- set_overdue
- set_expired
- set_cancelled
- set_finished
- should_be_overdue

Koha/Recalls.pm
- add_recall
- move_recall

and relevant tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #12 from David Cook  ---
It would be good to have someone with debugger knowledge (I think that's you,
Tomas?) to test my patch. I just tested it with --enable, --start, and
--restart

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #11 from David Cook  ---
Created attachment 108221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108221=edit
Bug 25778: [Alternate patch] Fix var scope in koha-plack for PERL5LIB and
KOHA_HOME

Currently, if a koha-plack is given multiple instances, it will create
duplicate $KOHA_HOME/installer and $KOHA_HOME/installer/lib entries
in PERL5LIB as these changes are done at the global rather than local level.

This issue can only be seen in non-dev Koha, since dev Koha installs
rewrite PERL5LIB.

This patch localizes PERL5LIB to each instance.

To test dev installs:
0. cp debian/scripts/koha-plack /usr/sbin/koha-plack
1. koha-plack --restart kohadev
2. Note that nothing breaks

To test non-dev installs:
0. Don't replace /usr/sbin/koha-plack yet
1. Create multiple non-dev installs with plack enabled and running
2. Set up one of these non-dev installs so you can use the web
UI (that is beyong the scope of this test plan)
3. koha-plack --restart test1 test2 test3
4. For test3, go to /cgi-bin/koha/about.pl
5. Note that there are duplicate /usr/share/koha/installer
and /usr/share/koha/lib/installer entries in PERL5LIB
6. cp debian/scripts/koha-plack /usr/sbin/koha-plack
7. koha-plack --restart test1 test2 test3
8. For test3, go to /cgi-bin/koha/about.pl
9. Note that there are no duplicates entries in PERL5LIB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #10 from David Cook  ---
(In reply to David Cook from comment #9)
> I don't have time to write a patch right now, but I reckon we mark PERL5LIB
> as an export above the per-instance loop, move the per-instance logic into a
> function, and localize PERL5LIB within the function.

Ok maybe just one quick patch... but I won't exhaustively test it right now..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26195] Add a way to specify authorised values should be expanded [OAI]

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26195

--- Comment #2 from David Cook  ---
Sounds interesting. I'll add it to my list!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #9 from David Cook  ---
I don't have time to write a patch right now, but I reckon we mark PERL5LIB as
an export above the per-instance loop, move the per-instance logic into a
function, and localize PERL5LIB within the function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #8 from David Cook  ---
Or better yet...

THIS=ONE
export THIS
test_function() {
local THIS=blah
echo `env`
}
test_function
echo $THIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #7 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #6)
> So we need to solve it with right scoping.

Exactly.

The following snippet provides a model that should work:

export THIS
test_function() {
local THIS=blah
echo `env`
}
test_function
echo $THIS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #6 from Tomás Cohen Arazi  ---
So we need to solve it with right scoping.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack puts duplicate entries into PERL5LIB when multiple instances named

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

David Cook  changed:

   What|Removed |Added

Summary|koha-plack --restart causes |koha-plack puts duplicate
   |PERL5LIB to grow with   |entries into PERL5LIB when
   |duplicate entries   |multiple instances named

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack --restart causes PERL5LIB to grow with duplicate entries

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #5 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #3)
> I don't understand why they accumulate.

Oh wait I see it now. It's so obvious in retrospect. Look at the scoping of
PERL5LIB in the following block of code:

if [ $# -gt 0 ]; then
# We have at least one instance name
for name in "$@"; do

if is_instance $name; then

adjust_paths_dev_install $name
export DEV_INSTALL
export KOHA_HOME
PERL5LIB=$PERL5LIB:$KOHA_HOME/installer:$KOHA_HOME/lib/installer

If you're specifying more than 1 instance name to koha-plack, it'll append
"$KOHA_HOME/installer:$KOHA_HOME/lib/installer" to PERL5LIB for each instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack --restart causes PERL5LIB to grow with duplicate entries

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

--- Comment #4 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #3)
> I don't understand why they accumulate.

The more I think about it, the less I understand as well.

I think that I was wrong about it being due to "koha-plack --restart".

I'm looking at a Koha instance where the server was rebooted last night, but it
has 46 pairs of /usr/share/koha/installer and /usr/share/koha/lib/installer.

There is no way that koha-plack was restarted 45 times since last night. 

Interestingly, if I try to cat /proc//environ, I just get a long
blank response with no actual environmental variables inside.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208

mada...@ckls.org changed:

   What|Removed |Added

 CC||mada...@ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23678] Cancel Holds in bulk

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23678] Cancel Holds in bulk

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24359] Remove items from Holds Queue when checked in

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26207] Compare values of system preference log entries

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207

--- Comment #2 from Lucas Gass  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26207] Compare values of system preference log entries

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #72 from Agustín Moyano  ---
Hi Jonathan, fixed most things but.. 

> * 
> -print
> $cgi->redirect("moredetail.
> pl?biblionumber=$biblionumber=$itemnumber#item$itemnumber");
> +print $cgi->redirect("moredetail.pl?" . $alerts .
> "biblionumber=$biblionumber=$itemnumber#item$itemnumber");
> 
> Put $alerts after existing params I'd say

changed name to messages, but this cannot be placed at the end of the string.
It needs to be before #item$itemnumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #71 from Agustín Moyano  ---
Created attachment 108220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108220=edit
Bug 19889: (follow-up) Fix few minor things

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #69 from Agustín Moyano  ---
Created attachment 108218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108218=edit
Bug 19889: (follow-up) Fix overlapping blue box and message in batch item
modification

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #67 from Agustín Moyano  ---
Created attachment 108216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108216=edit
Bug 19889: Make it possible to exclude items and categories from local holds
priority

This patch adds the ability to exclude patrons (by category) from local
holds, and items, by editing the item itself or by batch item
modification tool.

To test:
1. apply patches
2. updatedatabase
3. Enable LocalHoldsPriority preference, and leave
   LocalHoldsPriorityPatronControl in pickup library, and
LocalHoldsPriorityItemControl in holding library.
4. Search for a biblio with one item.
5. Place a hold with a patron (patron1) and set pickup location to a different
   library of the item's home library
6. Place another hold with another patron (patron2) and set pickup location to
be
   the same as the item's home library
7. ./misc/cronjobs/holds/build_holds_queue.pl
8. Go to circulation -> holds queue
9. Search by the item's home library
CHECK => only the hold for patron2 (with the pickup location the same as the
item's home library) appears in the table
10. Go back to the biblio details page and click on "Items" tab
CHECK => There is a new section in the item's details between "Statuses"
and "History" called "Priority"
11. Set exclude to "Yes" and update
12. repeat steps 7 to 9
SUCCESS => only the hold for patron1 now appears, even the other hold had local
hold priority
13. Repeat step 10 and 11 but this time set exclude to "No"
14. repeat steps 7 to 9
CHECK => the hold for patron2 is back
15. Edit patron2's category and set exclude from local holds priority to
"Yes"
16. Repeat steps 7 to 9
SUCCESS => the hold for patron1 is back
17. Go to tools -> Batch item modification and in barcode list place
several (existing) barcodes and press continue
CHECK => There is a new section in the bottom called "Priority"
18. Set exclude to "Yes" and save
SUCCESS => all items in the list now have exclude setted to "Yes"
19. Try to checkout the first item to a patron3
SUCCESS => Alert message appears saying that patron1 has a hold on that
item
20. Click on Yes and then checkin that item
SUCCESS => There is a modal window saying that a hold was found for
patron1
21. prove t/db_dependent/HoldsQueue.t t/db_dependent/Holds/LocalHoldsPriority.t
22. Sign off

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon 

Signed-off-by: Christopher Brannon 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #68 from Agustín Moyano  ---
Created attachment 108217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108217=edit
Bug 19889: Add feedback when exclusion is updated on moredetail.pl

Signed-off-by: Christopher Brannon 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #70 from Agustín Moyano  ---
Created attachment 108219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108219=edit
Bug 19889: (follow-up) Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #66 from Agustín Moyano  ---
Created attachment 108215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108215=edit
Bug 19889: Add tests

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon 

Signed-off-by: Christopher Brannon 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #65 from Agustín Moyano  ---
Created attachment 108214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108214=edit
Bug 19889: set exclude_from_local_holds_priority columns as boolean in schema

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon 

Signed-off-by: Christopher Brannon 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Agustín Moyano  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Agustín Moyano  changed:

   What|Removed |Added

 Attachment #107926|0   |1
is obsolete||
 Attachment #107927|0   |1
is obsolete||
 Attachment #107928|0   |1
is obsolete||
 Attachment #107929|0   |1
is obsolete||
 Attachment #107930|0   |1
is obsolete||
 Attachment #107931|0   |1
is obsolete||
 Attachment #107948|0   |1
is obsolete||

--- Comment #64 from Agustín Moyano  ---
Created attachment 108213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108213=edit
Bug 19889: Add exclude_from_local_holds_priority columns to item, deleteditems
and categories tables

Sponsored-by: Cooperative Information Network (CIN)

Signed-off-by: Christopher Brannon 

Signed-off-by: Christopher Brannon 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26208] New: Overdues restrictions not consistently removed when renewing multiple items at once

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208

Bug ID: 26208
   Summary: Overdues restrictions not consistently removed when
renewing multiple items at once
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:
- have multiple overdue items on one patron
- run overdues.pl with triggers set to generate a restriction
- renew all overdues with the Renew All button
- restriction is not removed even though patron no longer has overdue items

I did not get this error with 5 overdues, but I did get it with 10. Seems like
it's due to some messy sequencing when sending a bunch of renewals at once, so
it may be inconsistent to recreate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25893] Log viewer no longer searches using wildcards

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25893

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #15 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26121] When using CodeMirror in News Tool DatePicker is hard to see

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26121

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26207] Compare values of system preference log entries

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207

--- Comment #1 from Owen Leonard  ---
*It* could be useful. But yes, I could be useful too I guess.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26207] New: Compare values of system preference log entries

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26207

Bug ID: 26207
   Summary: Compare values of system preference log entries
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

I could be useful to offer a diff tool for system preference update entries in
the log viewer. This is especially relevant to preferences like OpacUserCSS or
OpacUserJS where it might be difficult to spot what changes were made.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26124] Console errors on tools_koha-news when editing with TinyMCE

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26124

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26115] Remove leftover Carp::Always

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26115

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #4 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from Lisette Scheer  ---
Worked great!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #108176|0   |1
is obsolete||

--- Comment #4 from ByWater Sandboxes  ---
Created attachment 108211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108211=edit
Bug 25872: Unit tests

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #108177|0   |1
is obsolete||

--- Comment #5 from ByWater Sandboxes  ---
Created attachment 108212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108212=edit
Bug 25872: Fix scoping of $limits

To test:
1 - Enable Elasticsearch
2 - On OPAC perform advanced search, selecting only an itype, ccode, or LOC
limit
3 - Attempt to sort results
4 - You are returned to Advanced search
5 - Apply patch
6 - Repeat
7 - It sorts!

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25871] Add "only library" to OpacItemLocation options

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25871

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
not backporting enhancement to 20.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26162] Prevent Selenium's StaleElementReferenceException

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26162

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #8 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

--- Comment #66 from Katrin Fischer  ---
What is the expected behavior on SIP, SCO and SCI? I think updating the commit
messages for the last 3 patches could be really helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26143] The API does not handle requesting all resources

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26143

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #11 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26133] Unneeded calls in detail.pl can be removed

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26133

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #105927|0   |1
is obsolete||

--- Comment #4 from Andrew Fuerste-Henry  ---
Created attachment 108210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108210=edit
Bug 23682 - Add ability to manually import EDI invoices as an alternative to
automatic importing on download

Some library would like to delay the importing of invoices until a time of
their choosing. The invoices should be imported into the database as they do
now, but the invoice processing should be skipped. Instead, any invoice file
with a status of 'new' should have an 'Import' button to process the invoice.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref EdifactInvoiceImport
4) Run the edi cronjob to import a new invoice file
5) View EDI messages table at /acqui/edifactmsgs.pl
6) Note the invoice files is not processes, and retains the status of 'new'
7) Use the 'import' button to process the invoice
8) Note the invoice is now marked 'received' and the 'import' button is gone
9) Verify the invoice was actually processes

Signed-off-by: Debi Stears 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26141] Duplicated code in search.pl

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26141

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26043] Holds.t is failing randomly

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26043

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26195] Add a way to specify authorised values should be expanded [OAI]

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26195

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||agustinmoy...@theke.io,
   ||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26195] Add a way to specify authorised values should be expanded [OAI]

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26195

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 108209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108209=edit
Bug 26195: - Add a way to specify authorised values should be expanded [OAI]

This patch introduces a new configuration entry for OAI so the resulting
records include authorised value descriptions instead of codes.

This is off by default.

To test:
1. Create a yaml file with the extended OAI configuration
2. Visit http://kohadev.myDNSname.org:8080/cgi-bin/koha/oai.pl
3. Browse some records
=> SUCCESS: The fields tied to AV show codes.
4. Update your configuration with 'expanded_avs: 1' for one  of the
   defined format like in:

  ---
  format:
marc21:
  metadataPrefix: marc21
  metadataNamespace: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim
  schema: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd
  include_items: 0
marcxml:
  metadataPrefix: marcxml
  metadataNamespace: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim
  schema: http://www.loc.gov/MARC21/slim
http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd
  include_items: 1
  expanded_avs: 1
5. restart_all
6. Repead 3
=> SUCCESS: AV descriptions are returned!
7. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26138] Errors if enable_plugins is zero

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26138

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
doesn't apply clean to 20.05.x, will need a rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25762] Typo in linkitem.tt

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25762

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24610] Let user switch between 'Pay' and 'Write off' mode

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24610

--- Comment #13 from Lucas Gass  ---
enhancement will not be backported to 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25762] Typo in linkitem.tt

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25762

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26085] Add the copy, print and export DataTables buttons to lost items report

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26085

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26094] "Suggest for Purchase" button missing unique CSS class

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26094

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25778] koha-plack --restart causes PERL5LIB to grow with duplicate entries

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25778

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #3 from Tomás Cohen Arazi  ---
I don't understand why they accumulate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26004] Remove unused jQuery plugin jquery.hoverIntent.minified.js from the OPAC

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26004

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #6 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26011] Remove unused jQuery plugin jquery.metadata.min.js from the OPAC

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26011

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #6 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

--- Comment #65 from Martin Renvoize  ---
Bumping back to the NQA queue as we had a number of QA followups and I feel
like a final QA run would be a good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25873] Elasticsearch - Records with malformed data are not indexed

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25873

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

--- Comment #62 from Martin Renvoize  ---
Created attachment 108206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108206=edit
Bug 25261: (QA follow-up) Add handling to SCO

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

--- Comment #64 from Martin Renvoize  ---
Created attachment 108208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108208=edit
Bug 25261: (QA follow-up) Add handling to SCI

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

--- Comment #63 from Martin Renvoize  ---
Created attachment 108207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108207=edit
Bug 25261: (QA follow-up) Catch check in SIP Checkin

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107234|0   |1
is obsolete||

--- Comment #57 from Martin Renvoize  ---
Created attachment 108201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108201=edit
Bug 25261: (QA follow-up) Add unit tests

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107285|0   |1
is obsolete||

--- Comment #58 from Martin Renvoize  ---
Created attachment 108202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108202=edit
Bug 25261: (QA follow-up) Simplify tests and conditions

Use build_sample_item in tests
Simplify tests for the confirmation

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107823|0   |1
is obsolete||

--- Comment #60 from Martin Renvoize  ---
Created attachment 108204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108204=edit
Bug 25261: (QA follow-up) Add confirmation to issues table

The issues table allows for checkins and was not appropriately
requireing confirmation for the multi-part confirmation added in this
bug.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

--- Comment #61 from Martin Renvoize  ---
Created attachment 108205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108205=edit
Bug 25261: (QA follow-up) Catch check in SIP Checkout

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107331|0   |1
is obsolete||

--- Comment #59 from Martin Renvoize  ---
Created attachment 108203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108203=edit
Bug 25261: (QA follow-up) Non-confirm on return

This patch updates the confirmation from an alert to a dismissable modal
which allows for optionally not checking the item in

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107231|0   |1
is obsolete||

--- Comment #54 from Martin Renvoize  ---
Created attachment 108198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108198=edit
Bug 25261: Checkout confirmation depending on syspref

With this follow-up patch, the intended confirmation of checkin based on
CircConfirmParts value is effective.

Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/]
Sponsored-by: PTFS Europe [https://ptfs-europe.com/]
Signed-off-by: Frédéric Demians 
Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107232|0   |1
is obsolete||

--- Comment #55 from Martin Renvoize  ---
Created attachment 108199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108199=edit
Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts

This clarifies the preference name to make it clear we are talking about
the 'parts' that make up an 'item'. 'Part' is a well known term in
british english libraries and I think perhaps 'Materials' may be
confused with other terms?

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107233|0   |1
is obsolete||

--- Comment #56 from Martin Renvoize  ---
Created attachment 108200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108200=edit
Bug 25261: (follow-up) item.material may contain non-numerics

Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field,
and thus the item.materials field, may contain arbitrary notes about the
material rather than just numeric values. As such we need to check for
the field being defined as aposed to greater than '0'.

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107230|0   |1
is obsolete||

--- Comment #53 from Martin Renvoize  ---
Created attachment 108197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108197=edit
Bug 25261: Require confirmation of multiple parts items

Test plan
1/ Catalogue an item to contain multiple parts by populating 'Materials
specified (bound volume or other part)'
2/ Enable the new system preference 'CircConfirmParts'
3/ Attempt to checkout the item created in step 1 to a user and note
that confirmation is now required.
4/ Checkout the item
5/ Attempt to checkin the item you have just checked out and note that
confirmation is required.
6/ Signoff

Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/]
Sponsored-by: PTFS Europe [https://ptfs-europe.com/]
Signed-off-by: Frédéric Demians 
Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107229|0   |1
is obsolete||

--- Comment #52 from Martin Renvoize  ---
Created attachment 108196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108196=edit
Bug 25261: Add system preference

Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/]
Sponsored-by: PTFS Europe [https://ptfs-europe.com/]
Signed-off-by: Frédéric Demians 
Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26084] ConsiderOnSiteCheckoutsAsNormalCheckouts description is unclear

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26084

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26111] Serials module does not appear in reports dictionary

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26111

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||

--- Comment #5 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #108170|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart  
---
Comment on attachment 108170
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108170
Bug 18501: (QA follow-up) Add POD for Koha::Item->set_found

Obsoleting as I did not apply it and will conflict with the 2 last patches, but
we should keep the POD from this patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

--- Comment #23 from Jonathan Druart  
---
Last 2 patches attached for discussion/share, not ready for testing. There are
2 FIXMEs in the first patch and a "holdingbranch" coming from... where
actually?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

--- Comment #22 from Jonathan Druart  
---
Created attachment 108195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108195=edit
Bug 18501: but.. what was the meaning of holdingbranch here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #108193|0   |1
is obsolete||

--- Comment #21 from Jonathan Druart  
---
Created attachment 108194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108194=edit
Bug 18501: Add _set_found_trigger

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

--- Comment #20 from Jonathan Druart  
---
Created attachment 108193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108193=edit
Bug 18501: but.. what was the meaning of holdingbranch here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25887] Filtering funds by library resets to empty in library pull down

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25887

Lucas Gass  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26093] Markup error after Bug 24279 creates formatting problem

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26093

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
missing 20.05.x dependency, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25852] If a layout is edited, the layout type will revert to barcode

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25852

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.03
released in||
 CC||lu...@bywatersolutions.com

--- Comment #10 from Lucas Gass  ---
backported to 20.05.x for 20.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

--- Comment #33 from Lucas Gass  ---
after consideringthis bug for 20.05.x I have decided not to backport this
enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26108] Checkins should not require item to have been checked out

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26108

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
Missing dependency for 20.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26083] Item editor defaults to lost

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26083

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #6 from Lucas Gass  ---
missing dependency for 20.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25100] Add ability to add custom text to top of the Self registration Form

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25100

--- Comment #8 from Owen Leonard  ---
I think the error may have been because of a conflict with the patch in the
sandbox. I had to tweak it to get it to apply on master in my test system.

The branch selection question is an interesting one. Seems like you'd have to
require that the news item always be defined as applying to "all libraries,"
but I don't know how you'd enforce it efficiently.

The other option is to output versions of the text from ALL libraries and
switch visibility based on the library the user selects. The KohaNews plugin
wasn't designed to provide this ability.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25100] Add ability to add custom text to top of the Self registration Form

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25100

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26205] News Changes aren't Logged

2020-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >