[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #64 from Marcel de Rooy --- Coming back here soon ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Emmi Takkinen changed: What|Removed |Added Blocks|15156 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Depends on|13906 | --- Comment #11 from Emmi Takkinen --- Removed dependency on bug 13906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Galen Charlton from comment #18) > The patch works for me with the curbside pickup plugin, and I'd be > comfortable treating the kitchen sink plugin as not handling its interior > modules as it should. Consequently, I've attached my signoff and tweaked the > commit message a bit. > > That said... this may not be necessary after all. I've worked out an > approach to have plugins register their own custom DBIx result classes > without requiring that koha-plack munge PERL5LIB in advance. See the pull > request on the plugin here: > > https://github.com/bywatersolutions/koha-plugin-curbside-pickup/pull/7 > > If that pull request holds up, the approach it outlines may well obviate any > need for Koha itself to change. Consequently, I'm setting the bug status to > in discussion for the moment. That's great, Galen. Glad to see you submitting code! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 Galen Charlton changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||gmcha...@gmail.com --- Comment #18 from Galen Charlton --- The patch works for me with the curbside pickup plugin, and I'd be comfortable treating the kitchen sink plugin as not handling its interior modules as it should. Consequently, I've attached my signoff and tweaked the commit message a bit. That said... this may not be necessary after all. I've worked out an approach to have plugins register their own custom DBIx result classes without requiring that koha-plack munge PERL5LIB in advance. See the pull request on the plugin here: https://github.com/bywatersolutions/koha-plugin-curbside-pickup/pull/7 If that pull request holds up, the approach it outlines may well obviate any need for Koha itself to change. Consequently, I'm setting the bug status to in discussion for the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26163] Add plugin directories to PERL5LIB
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163 Galen Charlton changed: What|Removed |Added Attachment #108524|0 |1 is obsolete|| --- Comment #17 from Galen Charlton --- Created attachment 109216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109216=edit Bug 26163: Add plugin directories to PERL5LIB It would be nice if we could create Koha objects and schema files to be used in plugins. The problem is that by the time the Plugin directories are added to @INC only at the point that Koha::Plugins is evaluated. This is too late for loading additional Schema files that may be part of a plugin. In addition, it makes sense to allow plugins to have a 'lib' directory so that any additional object and schema files can be stored inside the plugin assets directory and not pollute the root plugins directory. Without such a 'lib' directory, we would need to place them in the plugins directory such as '/var/lib/koha/instancename/plugins/Koha/MyObject.pm'. This file would not be removed when the plugin is uninstalled. Test Plan: 1) Apply this patch 2) Start koha-testing-docker or Update your plack.psgi file with the changes from the patch ( e.g. /etc/koha/sites/kohadevbox/plack.psgi ) 3) Install the curbside pickup plugin, 1.0.9: https://github.com/bywatersolutions/koha-plugin-curbside-pickup/releases/tag/v1.0.9 4) Restart all the things! 5) Verify that the curbside pickup plugin's config and tools interfaces appear. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26303] [OMNIBUS] Preparing for Perl 7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26303 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 --- Comment #20 from David Cook --- One downside of post-processing facet results is that your facet list length will vary depending on its contents... It could be more reliable to handle this issue at index-time rather than search-time. Since we're using DOM indexing with Zebra, we have a lot of power at index-time (beyond the use of CHR and ICU mechanisms) which could handle whitespace and punctuation for facet purposes. That being said... post-processing is probably easiest to have the most consistent behaviour across 3 different facet providers... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 --- Comment #19 from David Cook --- Ok still using CHR indexing but using the unnormalized 0 register... Previous results used "elements zebra::facet::author:p" These results use "elements zebra::facet::au:0" http://www.indexdata.com/zebra/;> OCarroll, Philip, Berryman, Faye Dale, Rae, Powell, Jonathon, Dale, Rae Shapiro, Lawrence E Reynolds, Kate E., Anderson, Vicki Betts, Dion E. Brennan, Tom Caramagna, Joe Foxx, Richard M Gutstein, Steven E Medlen, Joan E. Guthrie. Renton, N. E. (Nicholas Edwin), 1931 Reynolds, Kate E. Rosemann, Bill Schaefer, Charles E Snell, Martha E. Attwood, Tony I see that duplication now: Dale, Rae, Dale, Rae -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 --- Comment #18 from David Cook --- Ah, that example was using CHR indexing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 --- Comment #17 from David Cook --- Yet, if I look at http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test I'm not seeing data that looks like that facet data I showed before (which was from a different catalogue). I'll dig a bit more... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #16 from David Cook --- This is interesting. I'm not surprised that "_get_facets_data_from_record" works in an undesirable way, but I'm surprised that this would be necessary for "_get_facet_from_result_set" using Zebra facets, since Zebra returns the data in a normalized format. For example: Z> elements zebra::facet::author:p Z> show 1 Sent presentRequest (1+1). Records: 1 Record type: XML http://www.indexdata.com/zebra/;> berryman faye dale rae dale rae 1945 fitzroy programs o carroll philip o carroll philip 1945 powell jonathon powell jonathon illustrator reynolds kate e shapiro lawrence e carter emily caramagna joe schaefer charles e digeronimo theresa foy hughes edward e kazdin alan e reeve christine e renton n e nicholas edwin 1931 snell martha e attwood tony nextResultSetPosition = 2 Elapsed: 0.030227 Now in this case there are some apparent "duplicates" where the author's date is included in some records but not others. I would argue that is an authority data issue though, since "John Smith", "John Smith 1945", and "John Smith 1995" are all different authors. I don't know how Elasticsearch handles its facets, so I can't comment there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #262 from David Cook ---
(In reply to Nick Clemens from comment #261)
> Maybe it is too late to ask this question: Rather than joining items and
> deleteditems, can we join them into a new table and provide views for both
> of the old tables? This would prevent breaking reports across the board.
>
> biblio, deletedbiblios => biblios?
> items,deleteditems => all_items?
>
> This is going to be a big problem for existing users, it is going to be many
> reports, and it is going to cause disruption. Havign views that keep the
> reports working would be a huge boon.
It's an interesting idea. It would be nice to preserve that backwards
compatibility.
I think MySQL supports read/write for views, so in theory it could work...
--
I imagine another issue would be changing the tables used in the DBIC
definitions?
However, I don't think Biblio or Item were extensively used directly...
C4/Circulation.pm:my @itemnumbers =
$schema->resultset('Item')->search(
circ/renew.pl:$item = $schema->resultset("Item")->single( { barcode =>
$barcode } );
Koha/Edifact/Order.pm:my $i_obj = $schema->resultset('Item')->find(
$item->itemnumber );
Koha/EDI.pm:my $item = $schema->resultset('Item')->find(
$ilink->itemnumber );
Koha/EDI.pm:my $rs = $schema->resultset('Item')->search(
Koha/EDI.pm:my $item = $schema->resultset('Item')->find(
$ilink->itemnumber );
Koha/BiblioUtils.pm: $schema->resultset('Biblio')->search(
So then it would just be updating Koha/Item.pm and Koha/Biblio.pm with the new
ResultSet module name.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Attachment #109133|0 |1 is obsolete|| --- Comment #107 from David Cook --- Created attachment 109215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109215=edit Bug 16357: Only use Log4perl middleware if appenders defined This patch checks that the loggers used by the middleware actually have appenders defined. Without this patch, if the loggers don't have appenders defined in the log4perl file, the logs will just be lost. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16357] Plack error logs are not time stamped
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #106 from David Cook --- (In reply to Joonas Kylmälä from comment #105) > but I don't think we should depend on that using Log4perl in the future > either. I have not found any literature what's the best practice here, but > my common sense says that things are just too easy to break if a module > author has to worry about some module using indirectly its imports. I'm inclined to agree here, although one does need to be careful. It's always possible that you explicitly import the module differently to how another module imports it, and that could create problems (in terms of exported symbols and what not). But in this case, I'm happy enough to "use Log::Log4perl" after Koha::Logger as a sort of sanity check. That said, if we did ever remove Log::Log4perl from Koha::Logger, Koha would fail very fast in koha-testing-docker. So it's not the type of problem that would sleep in Koha heh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25898] Prohibit indirect object notation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #2) > Would it make sense to create a Perl 7 Omnibus bug we can use for these? Jonathan has opened one at Bug 26303 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #63 from Katrin Fischer --- (In reply to Nick Clemens from comment #62) > Created attachment 109061 [details] [review] > Bug 18958: DO NOT PUSH - Schema updates I guess you are trying to tell me I should have run dbic? ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Katrin Fischer changed: What|Removed |Added Attachment #109066|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 109213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109213=edit Bug 23682: (QA follow-up) Fix typo in syspref description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #18 from Katrin Fischer --- Created attachment 109214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109214=edit Bug 23682: INSERT IGORE systen preference in database update Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Katrin Fischer changed: What|Removed |Added Attachment #109065|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 109212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109212=edit Bug 23682: Add ability to manually import EDI invoices as an alternative to automatic importing on download Some library would like to delay the importing of invoices until a time of their choosing. The invoices should be imported into the database as they do now, but the invoice processing should be skipped. Instead, any invoice file with a status of 'new' should have an 'Import' button to process the invoice. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref EdifactInvoiceImport 4) Run the edi cronjob to import a new invoice file 5) View EDI messages table at /acqui/edifactmsgs.pl 6) Note the invoice files is not processes, and retains the status of 'new' 7) Use the 'import' button to process the invoice 8) Note the invoice is now marked 'received' and the 'import' button is gone 9) Verify the invoice was actually processes Signed-off-by: Debi Stears Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #15 from Katrin Fischer --- But koha - koha does. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23682] Add ability to manually import EDI invoices as an alternative to automatic importing on download
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23682 --- Comment #14 from Katrin Fischer --- You are mean, the admin admin account doesn't work :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Katrin Fischer changed: What|Removed |Added Attachment #107344|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 109211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109211=edit Bug 19382: Add blocking of ability to checkout on circulation.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Katrin Fischer changed: What|Removed |Added Attachment #106534|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 109210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109210=edit Bug 19382: Add ability to block guarantees based on fees owed by guarantor and other guarantees Some libraries would like to not only block the circulation of a guarantor based on fines owed by guarantees, but would also like to block circulation for all guarantees as well. Basically, if a family as a whole reaches a certain threshold of fines, the entire family will be blocked from checking out items. Test Plan: 1) Apply this patch 2) Set NoIssuesChargeGuarantorsWithGuarantees to $14 3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents guarantee both children 4) Give 3 of the 4 a $5 fine 5) None of them should be able to check out items Signed-off-by: Barbara Johnson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19382] Add ability to block guarantees based on fees owed by guarantor and other guarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26304] New: Better failure message when patrons can't log into the Opac due to self check permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26304 Bug ID: 26304 Summary: Better failure message when patrons can't log into the Opac due to self check permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: marga...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If a staff member is assigned self check permissions and tries to log into the Opac it fails. This is just fine and the permission says so on the label when it is expanded. However we really really should fix the Failure message on the Opac to reflect what the real reason why the patron cannot log in. In Koha 19.11 it says: "You entered an incorrect username or password. Please try again! But note that passwords are case sensitive. Please contact a library staff member if you continue to have problems." When in reality it should say: "Your Self Checkout permission prevents the you from using any other OPAC functionality." This is a bug because (a) the patron's username and password is just fine so we're giving them the wrong error message and (b) every quarter or so I get a support ticket with this issue and that is just enough time to completely forget about the permissions pitfall. Evidently that note on the permission is insufficient warning to staff member themselves or the staff admin doling out permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26304] Better failure message when patrons can't log into the Opac due to self check permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26304 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- This overall looks good, but can you please pretty up the commit message and add an updated test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250 Katrin Fischer changed: What|Removed |Added Attachment #108731|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 109209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109209=edit Bug 26250: StockRotationItems.t and StockRotationStages.t Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250
Katrin Fischer changed:
What|Removed |Added
Attachment #108730|0 |1
is obsolete||
--- Comment #12 from Katrin Fischer ---
Created attachment 109208
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109208=edit
Bug 26250: Fix tests when SearchEngine=Elastic
Most of the time the tests are failing because the item is not created
correctly (missing biblio and/or biblioitem).
The usual error is:
t/db_dependent/selenium/regressions.t . 5/5 Can't call method "leader" on
an undefined value at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line
534.
In this patch we are making sure $builder->build({ source => 'Item' })
is replace with $builder->build_sample_item
Test plan:
Turn on Elastic and confirm that all the tests pass!
Signed-off-by: Nick Clemens
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250
--- Comment #11 from Katrin Fischer ---
I have rerun the tests on a fresh setup and it looks much better now. I have an
issue with the selenium tests in general sadly, so I am passing QA, but ask you
to double check this one.
Maybe you can also see what's going wrong, so posting my error too:
prove t/db_dependent/selenium/regressions.t
t/db_dependent/selenium/regressions.t .. Could not create new session: Unable
to connect to host 127.0.0.1 on port 7055 after 45000 ms. Firefox console
output:
null,"translators":null,"contributors":null,"locales":["sk"]},{"name":"Википедија
(sr)","description":"Претрага Википедије на српском
језику","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["sr"]},{"name":"Wikipedia
(af)","description":"Wikipedia, die vrye
ensiklopedie","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["af"]},{"name":"ویکیپدیا
(fa)","description":"ویکیپدیا، دانشنامهٔ
آزاد","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["fa"]},{"name":"വിക്കിപീഡിയ
(ml)","description":"വിക്കിപീഡിയ, സ്വതന്ത്ര സര്വ്വവിജ്ഞാനകോശം
","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["ml"]},{"name":"Wikipedia
(ms)","description":"Wikipedia, ensiklopedia
bebas","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["ms"]},{"name":"Wikipedia
(ia)","description":"Wikipedia, le encyclopedia
libere","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["ia"]},{"name":"Wikipedia
(no)","description":"Wikipedia, den frie
encyklopedi","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["NO"]},{"name":"Википедия
(ru)","description":"Википедия, свободная
энциклопедия","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["ru"]},{"name":"Wikipedia
(br)","description":"Wikipedia, an holloueziadur
digor","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["br"]},{"name":"Wikipedia
(pl)","description":"Wikipedia, wolna
encyklopedia","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["pl"]},{"name":"Вікіпэдыя
(be-tarask)","description":"Вікіпэдыя, вольная
энцыкляпэдыя","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["be-tarask"]},{"name":"ວິກິພີເດຍ
(lo)","description":"ວິກິພີເດຍ,
ສາລານຸກົມເສລີ","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["lo"]},{"name":"Wikipedia
(sv)","description":"Wikipedia, den fria
encyklopedin","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["sv-SE"]},{"name":"Vikipēdija","description":"Vikipēdija,
brīvā
enciklopēdija","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["lv"]},{"name":"Wikipedija
(sl)","description":"Wikipedija, prosta
enciklopedija","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["sl"]},{"name":"Biquipedia
(an)","description":"A enciclopedia
Libre","creator":null,"developers":null,"translators":null,"contributors":null,"locales":["an"]}],"targetApplications":[{"id":"tool...@mozilla.org","minVersion":null,"maxVersion":null}],"targetPlatforms":[],"seen":true,"dependencies":[],"incognito":"spanning","userPermissions":{"permissions":[],"origins":[]},"icons":{"16":"favicon.ico"},"iconURL":null,"blocklistState":0,"blocklistURL":null,"startupData":null,"hidden":true,"installTelemetryInfo":null,"recommendationState":null,"rootURI":"resource://search-extensions/wikipedia/","location":"app-builtin"}
1598362999817 addons.xpi DEBUG Loading bootstrap scope from
resource://search-extensions/wikipedia/
1598362999817 addons.xpi DEBUG Calling bootstrap method install on
wikipe...@search.mozilla.org version 1.0
1598362999817 addons.xpi DEBUG Calling bootstrap method startup on
wikipe...@search.mozilla.org version 1.0
1598363019143 addons.productaddonsINFOsending request to:
https://aus5.mozilla.org/update/3/GMP/68.11.0/20200720181548/Linux_x86_64-gcc3/null/esr/Linux%204.9.0-13-amd64%20(GTK%203.22.11%2Clibpulse%20not-available)/default/default/update.xml
1598363019578 addons.productaddonsINFOCompleted downloading document
at /home/vagrant/kohaclone/t/lib/Selenium.pm line 58.
Use of uninitialized value $value in string eq at
/home/vagrant/kohaclone/C4/Context.pm line 529.
# Looks like your test exited with 255 before it could output anything.
t/db_dependent/selenium/regressions.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
Failed 5/5 subtests
Test Summary Report
---
t/db_dependent/selenium/regressions.t (Wstat: 65280 Tests: 0 Failed: 0)
Non-zero exit status: 255
Parse errors: Bad plan. You planned 5 tests but ran 0.
--
You are receiving this mail because:
You are watching all bug changes.
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661
--- Comment #15 from Katrin Fischer ---
I found some information here, that is promising:
https://perldoc.perl.org/perlunicode.html
For instance, \p{Uppercase} matches any single character with the Unicode
"Uppercase" property, while \p{L} matches any character with a General_Category
of "L" (letter) property
So maybe we could just switch out [A-Z] for the \p{Uppercase}.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- This is a really great improvement and works really well with our sample data. The only thing that I've been wondering about: seeing the A-Z as part of the regex: What will happen with non-latin and letters with diacritics? At the moment Ж. (Cyrillic) will lose the '.' and not be recognized as an initial. Is there a way we could make this work maybe? Could we check for the characters before being a space followed by a single character maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #12 from Katrin Fischer ---
This appears to break the result list:
Error trace
Can't use string ("") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/C4/Biblio.pm line 1366
I also have another issue: items.booksellerid is not a numerical field in
items, but a text one. I know a lot of libraries not using the acq module use
the field to enter the vendor name (not an id, but as text) there.
I couldn't check what would happen in this case, but I guess it could be a
problem for this use case.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Katrin Fischer changed: What|Removed |Added Attachment #107821|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26281] Add cancellation reason to holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26281 --- Comment #3 from Katrin Fischer --- Created attachment 109207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109207=edit Bug 26281: (QA follow-up) Fix missing filter Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26281] Add cancellation reason to holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26281 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26069] Twitter share button leaks information to Twitter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26069 Katrin Fischer changed: What|Removed |Added Attachment #109121|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 109206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109206=edit Bug 26069: Pass correct URL to twitter We don't provide the url of the detail page so the twitter JS code retrieve the current location, with the search terms. Test plan: Do a search Click on a result Click on the twitter button and confirm that the link only contain biblionumber=x in the parameter Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26069] Twitter share button leaks information to Twitter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26069 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #25 from Katrin Fischer --- Created attachment 109205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109205=edit Bug 22789: (QA follow-up) Some minor formatting changes - Remove the unordered list added to the holds list Details column - Switch div to span to have the hint appear behind the checkbox Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109128|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 109203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109203=edit Bug 22789: Add non priority feature to C4 classes and staff interface This patch implements necesary code to implement non priority feature To test: 1) Apply all patches. 2) Run updatedatabase. 3) Checkout a specific item for patron1. 4) Place a hold on the same item for patron2 (do not check non priority hold checkbox). 5) Try to renew the item for patron1. CHECK => in checkouts table, there is a message that the item could not be renewed because there was a hold. 6) Cleanup all checkouts and holds. 7) repeat steps 3 to 5, but this time check the non priority checkbox. SUCCESS => item was renewed 8) prove t/db_dependent/Holds.t Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109129|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 109204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109204=edit Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold This patch * sets one check for reserves and another for old_reserves in atomic update * Adds a message below the checkbox and adds detail when a hold is non priority * Fixes issue when there are more than one hold, but the first is non priority * Adds test case for this last scenario Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109125|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 109200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109200=edit Bug 22789: Add tests Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109127|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 109202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109202=edit Bug 22789: Set non_priority column as boolean in schema Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109126|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 109201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109201=edit Bug 22789: Add non_priority column to reserves and old_reserves Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26015] Terminology: staff interface should be used everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26015 --- Comment #22 from Katrin Fischer --- Thx for your help, Jonathan. I wanted to sign-off, but the selenium tests are giving me trouble (kohadevbox, freshly provisioned) :( I think this is me... so no reason to fail. kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl t/db_dependent/selenium/authentication.t 1..2 Could not create new session: Unable to connect to host 127.0.0.1 on port 7055 after 45000 ms. Firefox console output: [...] at /home/vagrant/kohaclone/t/lib/Selenium.pm line 58. # Looks like your test exited with 255 before it could output anything. kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ exit exit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16784] Add table configuration for the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784 Katrin Fischer changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om --- Comment #13 from Katrin Fischer --- *** Bug 26294 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26294] Add a print or download button to Purchase Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26294 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- (In reply to Wendy Sharkey from comment #3) > Being able to print this out would be a time saver for me and I assume many > librarians out there. Hi Wendy, as Owen noted we have added the export options available on other tables, like the checkouts table, to these. So you should be able to print this nicely form 20.05 on. *** This bug has been marked as a duplicate of bug 16784 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7694] Syndetics Editions not included
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7694 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Summary|Syndetics Editons not |Syndetics Editions not |included|included Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- Thx for testing, Amit! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Katrin Fischer changed: What|Removed |Added Attachment #109153|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 109197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109197=edit Bug 21066: Update English sample notices Applies to sample notices and sample news. Replace timestamp by publicationdate. Also adjust notice in TemplateToolkit.t. Test plan: Run dbrev and verify if ISSUESLIP refers to opac_news.publicationdate. Run t/db_dependent/Letters/TemplateToolkit.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 --- Comment #30 from Katrin Fischer --- Created attachment 109199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109199=edit Bug 21066: (QA follow-up) Fix publication date display in OPAC The date would no longer show, changed the variable name and removed the hours, as the field in the database is a date and not a datetime. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066
Katrin Fischer changed:
What|Removed |Added
Attachment #109152|0 |1
is obsolete||
--- Comment #27 from Katrin Fischer ---
Created attachment 109196
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109196=edit
Bug 21066: Update NewsChannels.t
Removing the weird '' => 1 from the hash too.
NOTE: The following line in the module seems to be useless:
$data->{$data->{'lang'}} = 1 if defined $data->{lang};
Test plan:
Run t/db_dependent/NewsChannels.t
Run t/db_dependent/Koha/News.t
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Katrin Fischer changed: What|Removed |Added Attachment #109150|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 109194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109194=edit Bug 21066: Code changes needed for replacing opac_news.timestamp Test plan: Perform some CRUD operations on the news page in staff. Verify that news on opac and staff respect publicationdate. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Katrin Fischer changed: What|Removed |Added Attachment #109154|0 |1 is obsolete|| --- Comment #29 from Katrin Fischer --- Created attachment 109198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109198=edit Bug 21066: Update translated news and notices Replace timestamp by publicationdate in translations. Applies to sample notices and sample news. Test plan: Run a new install or pick a sql file and run it on cmdline. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Katrin Fischer changed: What|Removed |Added Attachment #109151|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 109195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109195=edit Bug 21066: Resolve SQL errors in strict mode DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "INSERT INTO opac_news ( content,number,lang,title,branchcode,borrowernumber,expirationdate,publicationdate ) VALUES ( ?,?,?,?,?,?,?,? )" with ParamValues: 0="test", 1="", 2="", 3="test", 4=undef, 5="51", 6='2020-08-11', 7='2020-08-04'] at /usr/share/koha/C4/NewsChannels.pm line 68. DBD::mysql::st execute failed: Incorrect integer value: 'a' for column `koha_master`.`opac_news`.`number` at row 1 [for Statement "UPDATE opac_news SET lang = ?,publicationdate = ?,expirationdate = ?,number = ?,content = ?,branchcode = ?,title = ? WHERE idnew = ?;" with ParamValues: 0="", 1='2020-08-03', 2=undef, 3="a", 4="test", 5=undef, 6="test", 7="9"] at /usr/share/koha/C4/NewsChannels.pm line 107. Test plan: Do not apply this patch. Enable strict mode in koha-conf. Add new record in tools/news leaving 'Appear in position' blank. The record is not added; you have a warn in your plack-error log. Apply patch and try again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Katrin Fischer changed: What|Removed |Added Attachment #109148|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 109192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109192=edit Bug 21066: Database revision Change timestamp to publicationdate, add updated_on as 'real' timestamp. Test plan: Run install or upgrade. Check table opac_news. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Katrin Fischer changed: What|Removed |Added Attachment #109149|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 109193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109193=edit DO_NOT_PUSH: DBIx schema changes https://bugs.koha-community.org/show_bug.cgi?id=21066 Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] Replace opac_news.timestamp by publicationdate and add updated_on as timestamp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Katrin Fischer changed: What|Removed |Added Patch complexity|Small patch |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26300] Error in ISBD view in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26300 --- Comment #1 from Katrin Fischer --- Please make sure that all your items (or records in case of item-level itype = biblio) have an itemtype set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 --- Comment #3 from Katrin Fischer --- Created attachment 109191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109191=edit Bug 26299: Use same SMS number help text in OPAC as staff interface The SMS number help text in the OPAC follows a North American phone number style. It should be more generic. To that end, this patch makes the OPAC use the same help text for SMS numbers as the staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Katrin Fischer changed: What|Removed |Added Attachment #109187|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 109190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109190=edit Bug 26289: Add missing variable definition to templates This patch puts definition of the missing "searchid" variable into an include file to be used by various bibliographic detail pages. The variable is required by several JavaScript functions. To test, apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Perform the same test with the detail view, ISBD view, MARC view, and items view. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Katrin Fischer changed: What|Removed |Added Assignee|oleon...@myacpl.org |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #261 from Nick Clemens --- Maybe it is too late to ask this question: Rather than joining items and deleteditems, can we join them into a new table and provide views for both of the old tables? This would prevent breaking reports across the board. biblio, deletedbiblios => biblios? items,deleteditems => all_items? This is going to be a big problem for existing users, it is going to be many reports, and it is going to cause disruption. Havign views that keep the reports working would be a huge boon. Otherwise: I mostly tested functionality in this pass rather than reading the code, there are some areas that need attention. Acquisitions - Can delete ordered items and recieve them Can edit deleted items by forcing URL in additem.pl Can add to list using deleted barcodes Can add deleted items to label batches and rotating collections Batch record modification: Can load deleted records - then modification fails Can attach images to deleted records Canned reports - I don't think these were checked: grep items /kohadevbox/koha/reports/* -c grep is_current /kohadevbox/koha/reports/* -c -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #33 from Agustín Moyano --- > I'll remove the profile from the top and place them below. I'll also add a > text to clarify that selecting a profile just pre-fill's your form, but > values can be changed. > I ment, I'll remove the profile buttons from the top -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #32 from Agustín Moyano --- Hi Katrin, I'll respond between lines (In reply to Katrin Fischer from comment #29) > This works, but I feel the GUI is not very intuitive. Actually, it took me a > while to figure it out. > > The profile is "started" at the top of the page, but then after making your > settings, you have to make sure to hit "Update profile" for the settings to > be saved. So the workflow is like this to add a profile for it to work: > > 1) Enter a name for a profile, click on add > 2) Make the settings you want > 3) DONT CLICK IMPORT - or your profile will save with the wrong values > 4) Go back up, click "Update profile" > 5) Import > > I got it wrong the first time and was very confused why the "wrong" values > showed up on managing the staged import. > > If a profile was selected, values can be changed. After importing it's not > clear what was used for the import - the values from the profile or those > set (and not saved in the profile) of the form? The profile values will show. > Selecting a profile just pre-fills the form, if you change a value in the form, that's what counts for importing. I thought it good to keep that flexibility, thinking that maybe someone trying to import, might want to use almost all values from a profile, but change just one or two. > I really believe we need to improve this a bit before including it. > > Ideas: > > - Remove the buttons from the profile on top of the form and only show the > list of existing profiles there. > - If a profile is selected, change the values in the form below. > - When one of the settings is changed, show a hint behind the field. > - When importing: > - when profile is used and no field was changed: import > - when no profile was used: import > - when profile was used and values changed: ask if the profile or the > changed values should be used (and possibly if the existing profile should > be updated) > - At the end of the form offer to save the settings as a new profile or > update the existing one. This way, you can start at the top and work your > way down. > I'll remove the profile from the top and place them below. I'll also add a text to clarify that selecting a profile just pre-fill's your form, but values can be changed. > > Alternatively: > - Allow creating, updating and deleting profiles from a different > configuration screen. > - When a profile is selected, disable the other form fields so it's an > "either or" and it's always clear what will be applied for the import. I thought of this, but it would be a configuration screen exactly the same as this one.. it seemed kind of repetitive and less maintainable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7694] Syndetics Editons not included
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7694 --- Comment #2 from Amit Gupta --- We are using Syndetics for one of our client and seems this is available.(In reply to Katrin Fischer from comment #1) > Can someone using Syndetics content confirm this? We are using Syndetics for one of our client and seems this is available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7694] Syndetics Editons not included
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7694 Amit Gupta changed: What|Removed |Added CC||amit.gupta@informaticsgloba ||l.com, ||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26218] Add JavaScript validation to date of birth field in OPAC registration form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26218 Amit Gupta changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26262] Paging on course reserves tables in OPAC is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26262] Paging on course reserves tables in OPAC is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26262 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 109189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109189=edit Bug 26262: Remove wrong dom setting in course reserves (OPAC) The current setting required pagination to be displayed. This was hidden probably as a side effect of styling settings. But the docs are clear on the fact that p and l are intended for displaying pagination controls and table rows lenght information [1] As the course reserves datatable is not paginated, this needs to be fixed properly by removing those controls in the configuration. This patch does so. To test: 1. Have some course reserves 2. See them in the OPAC => FAIL: Some funky, misaligned pagination artifacts are displayed 3. Apply this patch and reload => SUCCESS: Things are back to normal! 4. Sign off :-D [1] https://datatables.net/examples/basic_init/dom.html Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Amit Gupta changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Amit Gupta changed: What|Removed |Added CC||amit.gupta@informaticsgloba ||l.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26289] Deleting biblio in labeled MARC view doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26289 Amit Gupta changed: What|Removed |Added Attachment #109130|0 |1 is obsolete|| CC||amitddng...@gmail.com --- Comment #3 from Amit Gupta --- Created attachment 109187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109187=edit Bug 26289: Add missing variable definition to templates To test Apply the patch and locate or create a record with no items. Open the labeled MARC view and choose Edit -> Delete record. Confirm the deletion. The deletion should complete correctly. Worked perfectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25808] Renewal via the SIP 'checkout' message gives incorrect message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25808 Kyle M Hall changed: What|Removed |Added Attachment #106028|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 109188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109188=edit Bug 25808: Renewal via the SIP 'checkout' message gives incorrect message If a renewal via SIP cannot be made because the patron has reached the maximum number of renewals, the AF screen message should read "Item has reached maximum renewals!", instead we get "Item checked out to another patron". Test Plan: 1) Check out an item to a patron 2) Using the SIP CLI tool, run checkout messages until the checkout has reached the maximum number of renewals 3) Note the incorrect message in the AF field 4) Apply this patch 5) Restart the SIP server 6) Run another SIP checkout message 7) Note the message is now correct! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 --- Comment #6 from Fridolin SOMERS --- This as a huge impact with Elasticsearch with QueryAutoTruncate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Attachment #109185|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 --- Comment #5 from Fridolin SOMERS --- Created attachment 109186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109186=edit Bug 24143: Disable QueryXXX when searching on an authority number Using the ident or identifier-standard index should not involve any of the following features: - QueryAutoTruncate - QueryFuzzy - QueryStemming - QueryWeightFields This is used in autorities search table to display use count. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24143] buildQuery should disable Query* on identifier search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143 --- Comment #4 from Fridolin SOMERS --- Created attachment 109185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109185=edit Bug 24143: Disable QueryXXX when searching on a authority number Using the ident or identifier-standard index should not involve any of the following features: - QueryAutoTruncate - QueryFuzzy - QueryStemming - QueryWeightFields This is used in autorities search table to display use count. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12 from Lucas Gass --- (In reply to Owen Leonard from comment #11) > Would it be possible to combine the count of notes and messages? The > distinction from the patron's point of view is meaningless. > > Notes and messages both displayed together in the same area on the user's > page with no indication that they're different kinds of messages, so two > different counts don't make sense. Owen, I was wondering about that too after I submitted the patch. I will combine them into one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #1 from Marcel de Rooy --- Created attachment 109184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109184=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26302] OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23674] Allowing editable notes when posting Payments/Writeoffs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- Agreed. The Transactions table on boraccount.pl should allow one to add notes and/or edit existing notes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Amit Gupta changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Amit Gupta changed: What|Removed |Added Attachment #109136|0 |1 is obsolete|| --- Comment #2 from Amit Gupta --- Created attachment 109183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109183=edit Bug 26299: Use same SMS number help text in OPAC as staff interface To test: 1) Apply the patch 2) Set "SMSSendDriver" to "Anything" in global system preferences 3) Go to the following link and note the help text by SMS number http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51 4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl 5) Note that the help text in both interfaces uses the same wording Checked and working perfectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26294] Add a print or download button to Purchase Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26294 Wendy Sharkey changed: What|Removed |Added CC||cata...@bfli.org --- Comment #3 from Wendy Sharkey --- Being able to print this out would be a time saver for me and I assume many librarians out there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26299] Help text for OPAC SMS number should be less North American-centric
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26299 Amit Gupta changed: What|Removed |Added CC||amit.gupta@informaticsgloba ||l.com, ||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20125] Add a cron script to claim late orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 Amit Gupta changed: What|Removed |Added CC||amit.gupta@informaticsgloba ||l.com, ||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816
--- Comment #44 from Agustín Moyano ---
(In reply to Jonathan Druart from comment #42)
> (In reply to Jonathan Druart from comment #41)
> > 2. I am not sure we should modify misc/admin/set_password.pl
> > It's an sysop script, and sysops (are supposed to) know what they are doing.
> > It's a behaviour change that is not advertised.
> > (for discussion)
>
> Sorry, I misread. That is for password generation, if none provided.
>
> Where is this '6' coming from? :)
That 6 comes from here
$generator->randregex('[A-Za-z][A-Za-z0-9_]{6}.[A-Za-z][A-Za-z0-9_]{6}\d');
^
The last 6 in the regex means the length it will generate, and in my script I
replaced that part with:
'[A-Za-z][A-Za-z0-9_]{6}.[A-Za-z][A-Za-z0-9_]{'.$n.'}\d'
where $n was the minimum password length for the user's category
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24597] Add ability to add note on all payment screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry --- Marked bug 8776 Resolved WorksForMe, because technically one can add a note. But also giving this bug a bump as the interface could be more clear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8776] When using 'write off all' no note can be added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 Andrew Fuerste-Henry changed: What|Removed |Added Resolution|--- |WORKSFORME CC||and...@bywatersolutions.com Status|NEW |RESOLVED --- Comment #4 from Andrew Fuerste-Henry --- In master currently, one *can* add a note when using Write Off All or the fee-specific writeoff button, but only if one enters the note in the "+note" field *before* clicking the writeoff button. So this works, but the interface could be more clear. I'm going to close this bug and update bug 24597, which is about standardizing interfaces. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21260] Improve the Availability line of OPAC XSLT search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260 --- Comment #14 from Marcel de Rooy --- Created attachment 109182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109182=edit Bug 21260: (follow-up) Fix typo in holdingbranch segment Copy-and-paste error. We need holdingbranch here. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20125] Add a cron script to claim late orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20125 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #14 from Fridolin SOMERS --- It may be missing "=cut" in misc/cronjobs/ordersClaim.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #260 from Nick Clemens --- (In reply to Jonathan Druart from comment #259) > Patches have been rebased against master. Looking here: 1 - Foreign key constraints on items table 'ON DELETE' updates are affected here - for instance a hold is not deleted if an item is deleted (can be done from additem.pl) 2 - Batch mod and batch delete should not allow altering deleted items 3 - CanBookBeReserved should not check deleted items (missing is_current => 1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #20) > Thinking loudly > > What happens if you create an item, place a hold on it, remove the hold, > delete the item. > In current master the old_reserves entry still exist (for stats for instance) That behaviour should be preserved and it would be a bug if it didn't. Both biblio_id and item_id are defined as ON DELETE SET NULL. So I guess this should be ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
