[Koha-bugs] [Bug 26306] Access denied for user 'koha_library'@'localhost'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26306 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25698] Curbside Pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 --- Comment #11 from David Cook --- By the way, if you look at Bug 26163, it looks like the Curbside Pickup plugin may no longer need to depend on a Koha change. Hurray! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #266 from David Cook --- (In reply to Jonathan Druart from comment #264) > (In reply to Nick Clemens from comment #261) > > Maybe it is too late to ask this question: Rather than joining items and > > deleteditems, can we join them into a new table and provide views for both > > of the old tables? This would prevent breaking reports across the board. > > > > biblio, deletedbiblios => biblios? > > items,deleteditems => all_items? > > > > This is going to be a big problem for existing users, it is going to be many > > reports, and it is going to cause disruption. Havign views that keep the > > reports working would be a huge boon. > > Yes Nick, this will be addressed on bug 25921. > However, I don't think it's a good idea to rename the table to have an > inconsistent name. We could rename biblio to biblio, but items is correct. > My opinion is that it should be quite trivial to fix the report in an update > DB. > * \sitems can be replaced with items_legacy > * \sbiblio => biblio_legacy > * and so on That's a good point. I wouldn't trust the report DB update to be 100% effective, but effective enough. Even if someone had to manually update a couple reports here and there with items_legacy or biblio_legacy... having the ability to use those legacy views would be good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25921] Merge biblio* and items table - Update reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25921 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #149 from David Cook --- I'll let Jonathan respond to the notes, but I agree with your comment, Kyle. I figure with that little UI tidy up, it should be pretty much good to go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22269] Pay amount - modal confirmation of amount to return to patron should be suppressed if attempting to pay (not collect) more than owed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22269 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- When I attempt to recreate I get "You must pay a value less than or equal to X", so I think this is no longer a problem? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24597] Add ability to add note on all payment/writeoff screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597 --- Comment #4 from Lucas Gass --- Also, if you 'Write off all' there is no way to add a note. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #37 from Agustín Moyano --- Ok, when I run qa I get this two errors: FAIL Koha/ImportBatch.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 which is weird, since Koha/ImportBatch.pm is created in this patchset FAIL api/v1/swagger/definitions/import-batch-profiles.json FAIL git manipulation The file has been added and deleted in the same patchset I get this error because I created api/v1/swagger/definitions/import-batch-profiles.json in a patch that is now signed off, and I'm trying to rename it to import_batch_profiles.json (Since previous patch is signed off, I don't think it wise to squash with a not signed patch).. because the file has less than 10 lines and file content also changes, git just marks it for delete, and creates the new file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26314] New: "Volumes: show volumes" showing regardless of whether there are volumes linked to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 Bug ID: 26314 Summary: "Volumes: show volumes" showing regardless of whether there are volumes linked to the record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 15851 When cataloguing multi part records with sets and volumes, we currently show a link to "Show volumes" on the set record. The link is always shown on a set record, even if there are no linked volumes. Bug 15851 solves the same issue for analytics. volumes would be a great next step. At the moment Show volumes is only shown on monographs, but we could add the feature for serial records as well. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What|Removed |Added Blocks||26314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26314 [Bug 26314] "Volumes: show volumes" showing regardless of whether there are volumes linked to the record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What|Removed |Added Attachment #108050|0 |1 is obsolete|| --- Comment #69 from Katrin Fischer --- Created attachment 109268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109268=edit Bug 15851: Only display the analytics link when required This patch makes opac-detail.pl query for analytics the same way it would do with the generated link (i.e. based on UseControlNumber) and passes a flag to the XSLT so it displays (or not) the 'Analytics' link. To test: 1. Apply the first patch 2. Have a known record without analytics 3. Open the record in the OPAC => FAIL: It shows the 'Analytics' link 4. Have a record known to have analytics and open in OPAC, on a separate tab => SUCCESS: It shows the 'Analytics' link 5. Apply this patch and restart_all 6. Reload the tabs => SUCCESS: It shows the link where it has to, and hides it where it shouldn't be displayed 7. Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What|Removed |Added Attachment #108051|0 |1 is obsolete|| --- Comment #70 from Katrin Fischer --- Created attachment 109269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109269=edit Bug 15851: (follow-up) Only display the analytics link when required (staff) This patch replicates the introduced behaviour, for the admin interface. To test, follow the test plan from the OPAC, but on the intranet. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What|Removed |Added Attachment #108049|0 |1 is obsolete|| --- Comment #68 from Katrin Fischer --- Created attachment 109267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109267=edit Bug 15851: Display analytics links for more cases The current XSLT displays the link to linked analytics only for serials. This patch makes it show for all the relevant position 7 on the leader values. I left out a and b as recommended by expert librarians on my team, but I can revert that if required. The current implementation adds a new CSS class for each case, so libraries willing to keep the current behaviour or just have more granular control on the cases they want the link to display, just can. This patch makes sense with the follow-up one, which will display the link only if there are really related records. To test: 1. Open a non-serial record, notice there's no link to analytics 2. Apply this patch and reload => SUCCESS: There's an 'Analytics' link 3. Inspect the produced HTML => SUCCESS: A special class with analytic_* value has been added, and thus we now can control its display through CSS 4. Sign off :-D Sponsored-by: Orex Digital Signed-off-by: Hugo Agud Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Agustín Moyano changed: What|Removed |Added Attachment #106555|0 |1 is obsolete|| --- Comment #35 from Agustín Moyano --- Created attachment 109265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109265=edit Bug 23019: (QA follow-up) Fix typo Pre fill Signed-off-by: Agustin Moyano -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #19 from Katrin Fischer --- When I try to add weights, I have: An error occurred when updating Elasticsearch index mappings: Unable to update mappings for index "koha_kohadev_biblios". Reason was: "Can't parse [index] value [] for field [copynumber__sort], expected [true] or [false]". Index needs to be recreated and reindexed. An error occurred when updating Elasticsearch index mappings: Unable to update mappings for index "koha_kohadev_authorities". Reason was: "Can't parse [index] value [] for field [personal-name-heading__sort], expected [true] or [false]". Index needs to be recreated and reindexed. Index '' needs to be recreated. Index '' needs to be recreated. I've tried resetting the mappings, but same errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #36 from Agustín Moyano --- Created attachment 109266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109266=edit Bug 23019: (follow-up) Fix usability issues This patch place profile buttons in the bottom of the page, next to "Stage for import" It removes the "Update profile" button, and changes "Add profile" to "Save profile". Save profile can be used to add and to update a profile. It also adds feedback when a profile was saved or deleted. Last, it also replaces input-batch-profile endpoint name for input_batch_profile, which is more aligned with other endpoint names. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #18 from Katrin Fischer --- Do you have some suggestions for a good weighting configuration to test with? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #17 from Katrin Fischer --- About 1) Staff interface: what about putting it into the floating toolbar? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #16 from Katrin Fischer --- Created attachment 109264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109264=edit OPAC advanced search with weight search option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24155] Weights should be (optionally) applied to Advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24155 --- Comment #15 from Katrin Fischer --- Some first thoughts here: I feel the GUI and maybe wording needs a little work. 1) the checkbox option appears kind of out of context on top of the form. I wonder if it would be better to place it closer to the search button - but that's problematic as we have 2 of those. I have no really good idea yet, but wanted to to get it out there. Attaching a screenshot. 2) The wording is currently: I wonder if "Apply field weightings to search" I wonder if this works for patrons or if there is a better/shorter description we could use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26313 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26313] "Show analytics" link doesn't work with Elasticsearch and UseControlNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15851 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #67 from Katrin Fischer --- I've filed bug 26313. I suspect changes to this will be needed as the same syntax for the search is used here and in the XSLT we will need to fix there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #66 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #65) > (In reply to Tomás Cohen Arazi from comment #64) > > This works, and only highlights UseControlNumber doesn't work correctly in > > ES, which should have it's own bug reported. > > But with this applied the links all disappear for ES users - I think we > should fix the other issue quickly because this will shine a bad light on a > nice feature that we want to boldly advertise in release notes. I agree. Can you file a bug for ES with your findings and make this one dependent on it? They are really unrelated. And ES it's showing non-working links anyway without this patch set -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26313] New: "Show analytics" link doesn't work with Elasticsearch and UseControlNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Bug ID: 26313 Summary: "Show analytics" link doesn't work with Elasticsearch and UseControlNumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de The "Show analytics" links don't work with Elasticsearch and UseControlnumber enabled. To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result What the search tries to do: rcn:11388674 and (bib-level:a or bib-level:b) - find a record with $w 11388674 - that is also a serial or monographic component part (LDR pos 7) rcn: search alone works. bib-level:a alone works Something wrong with the search syntax for Elasticsearch maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 --- Comment #65 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #64) > This works, and only highlights UseControlNumber doesn't work correctly in > ES, which should have it's own bug reported. But with this applied the links all disappear for ES users - I think we should fix the other issue quickly because this will shine a bad light on a nice feature that we want to boldly advertise in release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #64 from Tomás Cohen Arazi --- This works, and only highlights UseControlNumber doesn't work correctly in ES, which should have it's own bug reported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #34 from Agustín Moyano --- (In reply to Katrin Fischer from comment #31) > Oh also: Please write up the addition to the REST API: > https://wiki.koha-community.org/wiki/REST_api_RFCs Hi Katrin, here is the RFC https://wiki.koha-community.org/wiki/Import_batch_profiles_endpoint_RFC Is it ok?.. it's my first RFC.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 --- Comment #25 from Katrin Fischer --- This time around I managed to link the authority and record perfectly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Katrin Fischer changed: What|Removed |Added Attachment #108989|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 109263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109263=edit Bug 25273: (follow-up) Don't die on unknown authtype We are guessing authtype code and inserting the heading built accorindg to C4::Heading If we can't identify the auth type, we can format the heading. There is a record in the koha test data that is missing the heading field so type cannot be idenfitied This prevents us from dying n a record where we cannot identify the type. Note: This code will also be triggered for custom authority types, higlighting that they won't link because of hardcoded mappings in C4::Heading. We must tackle this on a new bug Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Katrin Fischer changed: What|Removed |Added Attachment #107434|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 109262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109262=edit Bug 25273: (follow-up) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Katrin Fischer changed: What|Removed |Added Attachment #105435|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 109261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109261=edit Bug 25273: Make match-heading rely on authority type configuration The match-heading field is a special field used only by the linker, not accessible to staff or patrons via the interface. This field is used to store the constructed 'search form' used for matching bib headings to authority fields. In bug 24269 I attempted to use the mappings defined in the inferface and also inject the search term. This did not work as too many subfields were indexed on their own and leading to false matches. In this bug we remove the mappings for this field, and create it ourselves during the indexing process. The C4::Headings module is still used to generate the correct form, however, the mappings are set based on the authority types in the system. This gives the user the ability to add new typoes, but prevents mapping changes from breaking linker functionality To test: 1 - Start form a sample database with ElasticSearch working 2 - Download via Z39.50 2 authorities, one of which is a narrower heading of the other, e.g.: Waterworks Waterworks - Costs 3 - Place a heading for the broader term in a record. e.g. Waterworks In 650$a, without the cataloguing authority plugin. We don't want the link created now. You need syspref BiblioAddsAuthorities => allow 4 - Make sure linker is set to default 5 - Attempt to link the records misc/link_bibs_to_authorities.pl 6 - Linking fails 7 - Apply patch 8 - refresh index settings (if using a custom file, remove 'match-heading') You can reset mappings in the UI or run this: misc/search_tools/rebuild_elasticsearch.pl -v -d -r 9 - Reindex ES 10 - Try to link again 11 - It succeeds! 12 - Run the tests prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26015] Terminology: staff interface should be used everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26015 --- Comment #23 from Katrin Fischer --- (In reply to Katrin Fischer from comment #22) > Thx for your help, Jonathan. > > I wanted to sign-off, but the selenium tests are giving me trouble > (kohadevbox, freshly provisioned) :( > > I think this is me... so no reason to fail. > > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl > t/db_dependent/selenium/authentication.t > 1..2 > Could not create new session: Unable to connect to host 127.0.0.1 on port > 7055 after 45000 ms. Firefox console output: > [...] > at /home/vagrant/kohaclone/t/lib/Selenium.pm line 58. > # Looks like your test exited with 255 before it could output anything. > kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ exit > exit I've been trying to update and all, but still no luck. Coudl someone else quickly verify the tests passing please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Katrin Fischer changed: What|Removed |Added Attachment #109242|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 109260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109260=edit Bug 17661: (follow-up) Update regex to support Unicode characters Rather than limiting initials to [A-Z] we should test for a broad range of uppercase letters. The ES/Zebra changes are slightly different because of Perl vs Java regex conventions. POerl may support either, but I found 'Uppercase' to be a bit more explicit More info here: https://perldoc.perl.org/perlunicode.html TO test: Same plan as before but use Ж. as the ending initial Confirm the period is preserved and other punctuation removed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Katrin Fischer changed: What|Removed |Added Attachment #109117|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 109259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109259=edit Bug 17661 - Ending punctuation causes duplicate facets The current code for facets doesn't pull strip ending punctuation from facets This causes duplicate facets for terms that should be combined Sometimes series can have different punctuation depending on the field they are in Author initials punctuation should be preserved To test: 1 - Do search and pull up some records 2 - Edit some of the records to have authors like: Date, C.J. Date, C.j. Date, C.J . 3 - Edit the records to have some series statments like: 830 $aDate, C.J. ;$v5 830 $aDate, C.J. ; $v5 830 $aDate, C.J.; $v5 4 - Add some 490s to the record with first indicator 1 and series like: You wouldn't want to-- You wouldn't want to You wouldn't want to.. 5 - Search again and note you have 3 facets each for author and series 6 - Apply patch 7 - Repeat 8 - Now you get 2 facets for author, period not removed when following Upper case immediately, is otherwise 9 - Now you should have a single series facet 10 - Switch search engine to ES (index before applying patch) 11 - Note facets are separate again 12 - Reset mappings and reindex perl misc/search_tools/rebuild_elasticsearch -v -r 13 - Repeat search, facets combined as above Signed-off-by: Sarah Cornell Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26307] misc/cronjobs/update_patrons_category.pl --too_old acts a year too early
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- I don't think this is a bug, or rather, I don't know I see your point, if you have categories: Child Upper Age Limit 17 Adult Minimum Age 18 You don't cross until you are 18, however, you can also read that there is a gap between 17 and 18 The way Koha has always worked you have: Child Upper Age Limit 18 Adult Minimum Age 18 Now there is no gap and you switch at 18 I think changing a long standing behaviour will affect many people, and that makes me nervous. I know that I have helped libraries set this up in the way that works. I think instead we need to clarify the explanation of the 'Limit' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22417] Add a task queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | Status|Signed Off |Failed QA --- Comment #148 from Kyle M Hall --- This looks really great! There are some rough edges that will need polished, but that doesn't necessarily need to happen right now on this bug. A few notes: * Why are koha_worker.pl and new_koha_job.pl in root dir? * Why does new_koha_job.pl use Koha::BackgroundJob::BatchUpdateBiblio but not Koha::BackgroundJob::BatchUpdateAuthority? Is this needed * use Scalar::Util qw( weaken ); not used I think at this point, the focus could be on cleaning up the ui and not refactoring the internals until they need to be refactored. The most glaring issue is this message presented to the user: The job has been enqueued! It will be processed as soon as possible (FIXME - well, it could depend on a config?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25584] When a 'return claim' is added, the button disappears, but the claim date doesn't show up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25584 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 Katrin Fischer changed: What|Removed |Added Attachment #109221|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 109258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109258=edit Bug 25639: Add search query strings as global javascript variables To test: 1 - Search on OPAC for "qwertyuiop" 2 - View the HTML source 3 - Find 'qwertyuiop' in the source, it is not easily accessible via JS 4 - Apply patch 5 - Repeat 6 - Note that now there are global variables with the query strings 7 - Add to OpacUserJs: console.log( query_desc ); console.log( querystring ); console.log( query_cgi ); 8 - Reload page and confirm variables are warned in the JS console (Press F12) 9 - Sign off Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #61 from Katrin Fischer --- Created attachment 109257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109257=edit Bug 23816: (QA follow-up) Use existing form validation to validate min password length The pattern check didn't work for me, but I figured we might want to use the same validation as for the other numeric fields on the form instead (upper age limit, etc.) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #109243|0 |1 is obsolete|| --- Comment #58 from Katrin Fischer --- Created attachment 109254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109254=edit Bug 23816: Set default value in tests We tell TestBuilder to generate the categories with NULL (and rely on the sysprefs) Signed-off-by: Agustin Moyano https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #109245|0 |1 is obsolete|| --- Comment #60 from Katrin Fischer --- Created attachment 109256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109256=edit Bug 23816: (follow-up) Fix many things This patch: * reverts changes on misc/admin/set_password.pl * makes category param mandatory for AuthUtils::is_valid_password and AuthUtils::generate_password * changes onboarding.pl to set category param in AuthUtils::is_valid_password * Completes t/db_dependent/AuthUtils.t and drops t/AuthUtils.t * Removes offending and replaces it by https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #109244|0 |1 is obsolete|| --- Comment #59 from Katrin Fischer --- Created attachment 109255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109255=edit Bug 23816: trivial code simplification Ease readability Signed-off-by: Agustin Moyano https://bugs.koha-community.org/show_bug.cgi?id=23826 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #108556|0 |1 is obsolete|| --- Comment #55 from Katrin Fischer --- Created attachment 109251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109251=edit Bug 23816: (follow-up) Define boolean column in shcema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #108557|0 |1 is obsolete|| --- Comment #56 from Katrin Fischer --- Created attachment 109252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109252=edit Bug 23816: Add tests Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #108558|0 |1 is obsolete|| --- Comment #57 from Katrin Fischer --- Created attachment 109253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109253=edit Bug 23816: Add minimum password length and require strong password overrides by category This patch adds the capability to override minPasswordLenth and RequireStrongPassword settings by category To test: 1. koha-shell kohadev 2. koha-mysql kohadev 3. drop database koha_kohadev; 4. create database koha_kohadev; 5. go to admin page and start webinstaller. There continue the steps until onboarding. 6. reach step 3 of onboarding and create a new administrator patron CHECH => Password control woks as normal (Minimum length 3 and strong required) 7. finish Koha installation and enter admin with your new administrator 8. set minPasswordLength to 3 and RequireStrongPassword to “Don’t require” 9. Create a new category (CAT2 from now on.. CAT1 is the category you made in onboarding process) and set minimum password length to 8 and require strong password 10. Create two new patrons, one with CAT1(patron1) and one with CAT2 (patron2) CHECK => In both cases, try different combinations of length and strength. For patron1 the only requirement is to have 3 letters, but for patron2 the minimum length will be 8 and will require strong password. CHECK => Try changing patron category before saving. Password requirements will change with category change. 11. Edit CAT1 and set minimum password length to 5 12. Go to patron1 details page, and change password. CHECH => Now password minimum length is 5, but still it doesn’t require strong password 13. Edit CAT1, leave blank minimum password length and set require strong password to yes. 14. Go to patron1 details page, and change password. CHECH => Password minimum length is back to 3, but now strong password is required 15. Set minimum password length in CAT2 to 12. 16. Go to patron2 details page, and click to fill a random generated password CHECK => generated password should be 12 characters length 17. Set PatronSelfRegistration to Allow in admin settings 18. Go to OPAC and fill self registration from. CHECK => Play with patron category. For each change in category, password requirements are modified. CHECK => Set CAT1 as patron category, set ‘aA1’ as password (or another valid password for CAT1) and before hitting submit button, change to CAT2. Form should enter invalid state, and CAT2 password requirements should be displayed as error in password input. 19. Create a patron for CAT1 and another for CAT2, leaving password blank CHECK => For CAT1’s patron, generated password length is 8 (minimum length for generated passwords), but for CAT2’s patron should be 12 20. In admin set PatronSelfRegistrationVerifyByEmail to require 21. Fill self registration form again with CAT2 as category CHECK => Password requirements works as previous case. 22. Leave password blank and click submit 23. select * from message_queue; 24. Copy the link in the message and paste it in OPAC CHECH => Generated password is 12 characters long. (Copy user id for next steps) 25. In admin set OpacResetPassword to Allow 26. Go back to OPAC, reload and click on “Forgot password?” link 27. Paste user id and click submit 28. Repeat steps 23 and 24 CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in warning. 29. Login OPAC with the last user and your newly created password 30. Go to “Change your password” option CHECK => Info message says “Your password must contain at least 12 characters, including UPPERCASE, lowercase and numbers.” CHECK => enter an invalid password and you’ll get the same message in below “New password” input. 31. prove t/db_dependent/AuthUtils.t t/db_dependent/Koha/Patron/Category.t 32. Sign off Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #108555|0 |1 is obsolete|| --- Comment #54 from Katrin Fischer --- Created attachment 109250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109250=edit Bug 23816: [DO NOT PUSH] Update category schema Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25584] When a 'return claim' is added, the button disappears, but the claim date doesn't show up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25584 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 109248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109248=edit Bug 25584: Fix minor styling issue This patch makes the button present some space between the icon and the text. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Katrin Fischer changed: What|Removed |Added Attachment #108554|0 |1 is obsolete|| --- Comment #53 from Katrin Fischer --- Created attachment 109249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109249=edit Bug 23816: Update kohastructure and atomic update Sponsored-by: Northeast Kansas Library - NEKLS Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25584] When a 'return claim' is added, the button disappears, but the claim date doesn't show up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25584 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 109247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109247=edit Bug 25584: Refresh checkouts table when a return claim is added This patch triggers a checkouts table refresh when a return claim is added. I also noticed the same when a return claim is deleted so it is now also refreshed. To test: 1. Set the ClaimReturnedLostValue to some valid value (2) 2. Check something out for a patron, and choose to display all checkouts => SUCCES: There's the checkouts table, showing the checkout 3. Click on the 'Claim returned' button and confirm => SUCCESS: There's no 'Claim returned' button anymore => ERROR: The checkout row doesn't display anything about the claim 4. Go to the 'Claims' tab, delete resolve and delete the claim 5. Go to the Checkouts tab => ERROR: It doesn't reflect the changes either 6. Apply this patch and start over => SUCCESS: Once the claim returned is added, the checkouts table is refreshed and the information updated => SUCCESS: On the Claims tab, if you delete the claim and go to the Checkouts tab, you are presented the button again. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 109246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109246=edit Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|gmcha...@gmail.com |and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25584] When a 'return claim' is added, the button disappears, but the claim date doesn't show up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25584 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED CC||tomasco...@gmail.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #52 from Katrin Fischer --- (In reply to Katrin Fischer from comment #51) > (In reply to Agustín Moyano from comment #50) > > When I execute qa of this patchset, I get > > > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt > >FAIL valid_template > > The method > > Koha::Patron::Category->effective_min_password_length is not > > covered by tests! > > > > This must be a qa script bug, because Koha::Patron::Category has the method > > effective_min_password_length, and it's covered by tests.. maybe it's > > checking in Schema class, instead of Koha::Object? > > I don't see that fail when I run the QA tools on it. ... I was looking in the wrong spot - It does fail... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #51 from Katrin Fischer --- (In reply to Agustín Moyano from comment #50) > When I execute qa of this patchset, I get > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >FAIL valid_template > The method > Koha::Patron::Category->effective_min_password_length is not > covered by tests! > > This must be a qa script bug, because Koha::Patron::Category has the method > effective_min_password_length, and it's covered by tests.. maybe it's > checking in Schema class, instead of Koha::Object? I don't see that fail when I run the QA tools on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24597] Add ability to add note on all payment/writeoff screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597 Lucas Gass changed: What|Removed |Added Summary|Add ability to add note on |Add ability to add note on |all payment screens |all payment/writeoff ||screens Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- +1, still valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #50 from Agustín Moyano --- When I execute qa of this patchset, I get FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt FAIL valid_template The method Koha::Patron::Category->effective_min_password_length is not covered by tests! This must be a qa script bug, because Koha::Patron::Category has the method effective_min_password_length, and it's covered by tests.. maybe it's checking in Schema class, instead of Koha::Object? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #49 from Agustín Moyano --- (In reply to Emmi Takkinen from comment #45) > There's a typo on last patch: > > syntax error at /var/Koha/Koha/Patron/Category.pm line 238, near > "->reset_password ) " Thanks Emmi for catching this up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #48 from Agustín Moyano --- Created attachment 109245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109245=edit Bug 23816: (follow-up) Fix many things This patch: * reverts changes on misc/admin/set_password.pl * makes category param mandatory for AuthUtils::is_valid_password and AuthUtils::generate_password * changes onboarding.pl to set category param in AuthUtils::is_valid_password * Completes t/db_dependent/AuthUtils.t and drops t/AuthUtils.t * Removes offending and replaces it by https://bugs.koha-community.org/show_bug.cgi?id=23826 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #47 from Agustín Moyano --- Created attachment 109244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109244=edit Bug 23816: trivial code simplification Ease readability Signed-off-by: Agustin Moyano https://bugs.koha-community.org/show_bug.cgi?id=23826 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Agustín Moyano changed: What|Removed |Added Attachment #108571|0 |1 is obsolete|| Attachment #108572|0 |1 is obsolete|| --- Comment #46 from Agustín Moyano --- Created attachment 109243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109243=edit Bug 23816: Set default value in tests We tell TestBuilder to generate the categories with NULL (and rely on the sysprefs) Signed-off-by: Agustin Moyano https://bugs.koha-community.org/show_bug.cgi?id=23826 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 --- Comment #21 from Nick Clemens --- Created attachment 109242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109242=edit Bug 17661: (follow-up) Update regex to support Unicode characters Rather than limiting initials to [A-Z] we should test for a broad range of uppercase letters. The ES/Zebra changes are slightly different because of Perl vs Java regex conventions. POerl may support either, but I found 'Uppercase' to be a bit more explicit More info here: https://perldoc.perl.org/perlunicode.html TO test: Same plan as before but use Ж. as the ending initial Confirm the period is preserved and other punctuation removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #1 from Nick Clemens --- Created attachment 109241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109241=edit Bug 26312: Catch ES Client errors, log, and continue indexing when error encountered This catches a timeout response from the ES server, logs this, and continues the indexing To test: 1 - perl misc/search_tools/rebuild_elasticsearch.pl 2 - Make the ES server timeout (I don't have good instruction yet) 3 - Watch the job crash 4 - Apply patches 5 - perl misc/search_tools/rebuild_elasticsearch.pl 6 - Make the server timeout 7 - Note the job reports failed commit, and continues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26312] New: Add some error handling during Elasticsearch indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312
Bug ID: 26312
Summary: Add some error handling during Elasticsearch indexing
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Searching - Elasticsearch
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
Currently Elasticsearch dies if we get an error rather than a response from the
ES Client.
Generally we can see something like
[6056] Committing 5000 records...
[Timeout] ** [http://XXX.XXX.XXX.XXX:9200]-[599] Could not write to socket:
'Connection timed out', called from sub
Search::Elasticsearch::Role::Client::Direct::__ANON__ at
/usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/Indexer.pm line 123. With
vars: {'
Rather than killing the whole indexing process, we should catch the error, fail
the commit, and keep indexing records.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26310] Allow setting trace_to parameter in Elaasticsearch config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26310 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26310] Allow setting trace_to parameter in Elaasticsearch config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26310 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26310] Allow setting trace_to parameter in Elaasticsearch config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26310 --- Comment #1 from Nick Clemens --- Created attachment 109240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109240=edit Bug 26310: Allow setting trace_to parameter in Elaasticsearch config For debugging purposes we may wish to see the requests and responses made to Elasticsearch To test: 1 - prove -v t/Koha/SearchEngine/Elasticsearch.t 2 - Set Stderr in koha-conf 3 - Restart all 4 - perl misc/search_tools/rebuild_elasticsearch.pl 5 - Note requests are shown 6 - Set File /var/log/koha/kohadev/plack-error.log in koha-conf 7 - Restart all 8 - perl misc/search_tools/rebuild_elasticsearch.pl 9 - Check the plack log and see the ES requests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 --- Comment #1 from Fridolin SOMERS --- Created attachment 109239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109239=edit Bug 26311: Add patron invalid age to search_for_data_inconsistencies.pl Patron categories may have age limits. Add to script misc/maintenance/search_for_data_inconsistencies.pl the list of patrons which age is invalid regarding there category. Test plan : 1) Create an adult patron category limited to 18-99 years 2) Create a patron in the category 3) Edit in database its date of birth so that he is 17 years old 4) Run misc/maintenance/search_for_data_inconsistencies.pl => You see the patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26307] misc/cronjobs/update_patrons_category.pl --too_old acts a year too early
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26307 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26311 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26307 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26311] New: Add patron invalid age to search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Bug ID: 26311 Summary: Add patron invalid age to search_for_data_inconsistencies.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Patron categories may have age limits. Add to script misc/maintenance/search_for_data_inconsistencies.pl the list of patrons which age is invalid regarding there category. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26310] New: Allow setting trace_to parameter in Elaasticsearch config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26310 Bug ID: 26310 Summary: Allow setting trace_to parameter in Elaasticsearch config Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com When debugging it would be nice to see the requests/responses from Elasticsearch We can set a debug variable: https://metacpan.org/pod/Search::Elasticsearch#trace_to -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 --- Comment #2 from Nick Clemens --- Created attachment 109238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109238=edit Bug 26309: Make cxn_pool configurable In get_elasticsearch_params we set the conf to static if undefined, but we never defined it To test: 1 - Apply unit test patch 2 - prove -v t/Koha/SearchEngine/Elasticsearch.t 3 - It fails 4 - Apply this patch 5 - It succeeds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 --- Comment #1 from Nick Clemens --- Created attachment 109237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109237=edit Bug 26309: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26309] New: Elasticsearch cxn_pool must be configurable (again)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Bug ID: 26309 Summary: Elasticsearch cxn_pool must be configurable (again) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com Bug 21974 added cxn_pool to elasticsearch fongi in koha-conf Bug 24823 broke that -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6416] koha-remove fails when dropping user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26306 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26306] Access denied for user 'koha_library'@'localhost'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26306 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Version|20.05 |master See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=6416 Severity|critical|normal --- Comment #1 from Jonathan Druart --- The correct dump/restore workflow is: systemctl stop apache2 systemctl stop koha-common koha-dump koha-remove koha-restore systemctl start koha-common systemctl start apache2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 --- Comment #11 from Marcel de Rooy --- Bit unpolished yet, but the idea is if you find multiple barcodes, report them on inventory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20206] Inventory: barcodes without or with extra leading zeroes are reported not found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20206 --- Comment #10 from Marcel de Rooy --- Created attachment 109236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109236=edit Bug 20206: Find barcodes with more or less leading zeroes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 109235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109235=edit Bug 25504: (QA follow-up) Remove unused include Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 109234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109234=edit Bug 25504: Use Koha::Logger and display the full stacktrace Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
