[Koha-bugs] [Bug 26497] New: "Hide all columns" throws Javascript error on aqplan.pl

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26497

Bug ID: 26497
   Summary: "Hide all columns" throws Javascript error on
aqplan.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

If you click "Hide all columns" on aqplan.pl, no columns are hidden and you get
a Javascript error saying "$(...).checkCheckboxes is not a function"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26495] Budget Planning interface confusing when budget is locked

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26495

David Cook  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=26496   |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

David Cook  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

David Cook  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=26495   |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

David Cook  changed:

   What|Removed |Added

Version|19.11   |master

--- Comment #5 from David Cook  ---
This is a problem in master too

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

David Cook  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

--- Comment #4 from David Cook  ---
Created attachment 110446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110446=edit
Bug 26496: Add op field to Budget Planning

Without this patch, it's impossible to save a budget plan.

With this patch, it is possible to save a budget plan.

Test:
1. Apply patch
2. Go to a budget (e.g.
http://localhost:8081/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1)
3. Click "Planning" and "Plan by libraries"
4. Click "Auto-fill row" on the first line
5. Click "Save"
6. Note that results are saved and shown on the newly loaded page

To verify this patch is necessary, do the test plan without applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26495] Budget Planning interface confusing when budget is locked

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26495

David Cook  changed:

   What|Removed |Added

Summary|Impossible to save Budget   |Budget Planning interface
   |Plans   |confusing when budget is
   ||locked

--- Comment #1 from David Cook  ---
When the budget is locked, the "Save" button disappears from
/cgi-bin/koha/admin/aqplan.pl, but you can still interact with the text fields
on the page.

These text fields should be marked as read-only, and there should be a warning
that the budget is locked.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

--- Comment #3 from David Cook  ---
(In reply to David Cook from comment #2)
> Also worth noting that this is noted in 19.11. In master, the save button is
> gone all together... Bug 26495.

Ok actually it seems that the budget was locked, and that's why the save button
was hidden. That's actually just suboptimal rather than a major problem...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26495] Impossible to save Budget Plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26495

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26496

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20201] Silence warnings in admin/aqplan.pl

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201

David Cook  changed:

   What|Removed |Added

 Blocks||26496


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496
[Bug 26496] Budget Plan save button doesn't save plans
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26495

--- Comment #2 from David Cook  ---
Also worth noting that this is noted in 19.11. In master, the save button is
gone all together... Bug 26495.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

--- Comment #1 from David Cook  ---
It appears that Bug 20201 probably hid the warning for administrators at
least...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning, and contracts

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

David Cook  changed:

   What|Removed |Added

 Blocks||26496


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496
[Bug 26496] Budget Plan save button doesn't save plans
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

David Cook  changed:

   What|Removed |Added

 Depends on||16754, 20201


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754
[Bug 16754] Use validation plugin in budgets, planning, and contracts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201
[Bug 20201] Silence warnings in admin/aqplan.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26496] New: Budget Plan save button doesn't save plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26496

Bug ID: 26496
   Summary: Budget Plan save button doesn't save plans
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

Bug 16754 removed the "op" input from the Budget Plan (ie
/cgi-bin/koha/admin/aqplan.pl), so clicking "Save" doesn't do anything anymore. 

I'm actually surprised that no one else has noticed this over the last 4
years...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26495] New: Impossible to save Budget Plans

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26495

Bug ID: 26495
   Summary: Impossible to save Budget Plans
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

In master, it's impossible to save Budget Plans as there is no save button.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning, and contracts

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #15 from David Cook  ---
It looks like this change actually broke aqplan.pl because it accidentally
removed the Javascript that was used to add the "op" parameter, and the test
plan didn't include testing saving budget plans. Oops!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20201] Silence warnings in admin/aqplan.pl

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20201

--- Comment #7 from David Cook  ---
Comment on attachment 72269
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72269
Bug 20201: Silence warnings triggered by admin/aqplan.pl

Review of attachment 72269:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20201=72269)
-

::: admin/aqplan.pl
@@ +106,4 @@
>  $authcat = 'Asort1' if  not defined $authcat; # defaults to Asort if no 
> authcat given
>  
>  my $budget_id = $input->param('budget_id');
> +my $op= $input->param("op") // q{};

This line actually hides a bug introduced by Bug 16754.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26494] New: "Next issue publication date" doesn't update if no Expected issues available

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26494

Bug ID: 26494
   Summary: "Next issue publication date" doesn't update if no
Expected issues available
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

If you change the "Next issue publication date", it will only be saved if you
have an "Expected" issue in your serials. 

If you don't have an "Expected" issue, it will silently fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26390] Add transliteration of Ž in ICU chains

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26390

--- Comment #8 from Katrin Fischer  ---
(In reply to David Cook from comment #7)
> (In reply to Katrin Fischer from comment #6)
> > It means, the change here should not be necessary... Nick, can you please
> > double check?
> 
> Although wouldn't that NFD change make Žižek into something like...
> Zizek?

You have to look at the full example in the links I posted. 3 lines:





So yes, but then it uses that form to remove the diacritics:
https://www.compart.com/en/unicode/category/Mn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26390] Add transliteration of Ž in ICU chains

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26390

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #7 from David Cook  ---
(In reply to Katrin Fischer from comment #6)
> It means, the change here should not be necessary... Nick, can you please
> double check?

Although wouldn't that NFD change make Žižek into something like...
Zizek?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable/19.05.x)

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Nightly Build Bot  changed:

   What|Removed |Added

 Attachment #110136|0   |1
is obsolete||

--- Comment #23 from Nightly Build Bot  ---
Created attachment 110445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110445=edit
Bug 17108- Automatic debian/control updates (stable/19.05.x)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808

--- Comment #34 from Katrin Fischer  ---
*** Bug 25739 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25739] Add guarantee doesn't link to parent account

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25739

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Katrin Fischer  ---
(In reply to Owen Leonard from comment #7)
> > I am in 19.11.06, and we do not get the "Guarantor information" fieldset
> > with details about the adult record I started with."
> 
> I think Bug 23808 fixes this as of 19.11.07.

Marking as a duplicate in this case.

*** This bug has been marked as a duplicate of bug 23808 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED

--- Comment #2 from Katrin Fischer  ---
Actually, I was mistaken: cataloguing/addbiblio.pl? doesn't always have the
searches. Once you actually open a record for editing the searches are gone.

I think this was done to save up on space, as the cataloguing form is usually
quite long. Do we want to sacrifice the space here for the full search options
on top?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23656] Add search box to top of page on cataloguing/editor.pl

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
I think this is the case now - when I go to cataloguing we have the normal
tabbed search options showing on top. Marking RESOLVED - please reopen if I
misunderstood.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9251] Add option to print renewal quick slip

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9251

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add option to print checkin |Add option to print renewal
   |and renewal quick slip  |quick slip

--- Comment #8 from Katrin Fischer  ---
Changing the bug description as we have bug 12224 for the checkin slip with a
patch now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22431] Holds to pull report is broken in sql strict mode

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431

--- Comment #10 from Katrin Fischer  ---
(In reply to Owen Leonard from comment #9)
> If duplicate reports have been made on this bug THREE TIMES I think it's
> time to change the title!!

You make an excellent point there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26353] Report with malfunction after update to Koha 20.05

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26353

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
Hi Jonathan, bugzilla is used for reporting bugs and enhancements, but not a
good place to ask for help with reports. Please try the mailing list instead -
it will also get your question out to a lot more people that might be able to
help you.

I took a quick look, but didn't spot it right away. You work with a lot of
tables, some multiple times. If you send this to the mailing list, maybe also
add a description of what you are trying to achieve with this report.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22431] Holds to pull report is broken in sql strict mode

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431

Owen Leonard  changed:

   What|Removed |Added

Summary|Incorrect group by in   |Holds to pull report is
   |circ/pendingreserves.pl |broken in sql strict mode

--- Comment #9 from Owen Leonard  ---
If duplicate reports have been made on this bug THREE TIMES I think it's time
to change the title!!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26436] Quick add patron will not copy over details from cities and towns pull down into patron details

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436

Katrin Fischer  changed:

   What|Removed |Added

   Severity|minor   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26438] Follow up to bug 23463 - return from Koha::Item overwrites existing variable

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26438

--- Comment #2 from Katrin Fischer  ---
Should this be a bug instead of an enh?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||26438


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26438
[Bug 26438] Follow up to bug 23463 - return from Koha::Item overwrites existing
variable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26438] Follow up to bug 23463 - return from Koha::Item overwrites existing variable

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26438

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||23463


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
[Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26452] overdue_notices causes "uninitialized value in string"

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26452

--- Comment #1 from Katrin Fischer  ---
Can you give your exact Koha version for the line numbers? (20.05.xx) 

It's more likely to be a warn than a big issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26455] How can the actual date of deletion be verified?

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26455

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Katrin Fischer  ---
This sounds like a migration issue. It is possible to set the timestamp in
deleteditems to the deletion date when doing the migration, but if that wasn't
done, I think the only place to get this information will be from the exported
data of your last system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26396] Hide toolbar and actions buttons from display when printing OPAC lists

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26396

--- Comment #2 from Katrin Fischer  ---
Maybe we could also remove the navigation? (Advanced search ...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #86 from Katrin Fischer  ---
The follow-up is not dramatic, keeping signed off status here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||26493


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26493
[Bug 26493] Add missing FK constraints to aqbudgets
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26493] New: Add missing FK constraints to aqbudgets

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26493

Bug ID: 26493
   Summary: Add missing FK constraints to aqbudgets
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 18050

There are several column in aqbudgets that should have FK constraints on them:

budget_branchcode
=> branches.branchcode

budget_owner_id
=> borrowers.borrowernumber

sort1_authcat
sort2_authcat
=> authorised_value_categories.category_name


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050
[Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25758] Items scheduled for automatic renewal do not show that they will not renew due to a hold

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25758

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26440

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25758

--- Comment #4 from Katrin Fischer  ---
I think bug 25758 is quite similar, but not sure if it fixes this bug as well.
Adding as a see also.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26486] Group edit buttons in reports toolbar

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26486

--- Comment #1 from Katrin Fischer  ---
I really like the toggle on the hide/show and see no better option than to
group the others in Edit like suggested. I wonder if there is something neat we
could do to the chart ones as they are quite big.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20492

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20492] Add missing case for advanced search year limit in _fix_limit_special_cases

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24807
 Status|Needs Signoff   |Failed QA

--- Comment #6 from Katrin Fischer  ---
I am not sure how this relates to bug 24807. I applied the patch and reindexed
my records with -d, but the search in OPAC doesn't work for me. I did a date
range search for "2000-", but almost all records are way before 2000, both in
008 and 260/264.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Status|NEW |ASSIGNED
   Assignee|agustinmoy...@theke.io  |alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #21 from Aleisha Amohia  ---
Oops sorry I should've thought about that! Understand if this needs to get
signed off again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26488] Overdue report download not respecting custom patron attribute filter

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26488

Katrin Fischer  changed:

   What|Removed |Added

Version|20.05   |master
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #20 from Katrin Fischer  ---
Hi Aleisha, as the requested changes were only "cosmetic" I'd be ok with
keeping this signed off, but was hoping for a separate patch as a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110227|0   |1
is obsolete||

--- Comment #45 from Aleisha Amohia  ---
Created attachment 110444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110444=edit
Bug 14367: (follow-up) Rebasing to make patch work on master

Run through test plan and confirm everything still works as expected.

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110225|0   |1
is obsolete||

--- Comment #43 from Aleisha Amohia  ---
Created attachment 110442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110442=edit
Bug 14367: Add MARC record history

This is a proof-of-concept implementation for adding history
support to MARC records. Every time a change is made a complete
copy of the record is stored along with the date/time and user
identity. The changes are listed under each field in the MARC
record editor and can be reverted with a click.

The changes are stored as a JSON array in a new column named
'history' in the database. The array is re-read from the database
before updating the record to prevent old data lingering in
the session from overwriting newer changes made by other users.

If we decide to implement this feature it might be better to
simply create a new table altogether and link it rather than
the clumsy JSON solution. That would eliminate a lot of bulky
code that transforms MARC-KOHA-JSON and back while ensuring
data integrity.

Also, there are plans to add permissions to the MARC records;
this likely requires more complex interactions that will scale
badly with the current JSON solution.

At present, the history is hardcoded to 10 entries.
This can easily be made into a syspref.

The current implementation should probably be refactored
into a 'BiblioHistory' class before deploying.

Documentation of the functions/methods are also needed.

Icon is ugly and needs to be improved.

Sponsored-By: Halland County Library & Catalyst IT

Test plan:
* Run updatedatabase.pl
* Log into Staff interface, search for a title, choose to edit it's MARC
record.
* Chose a MARC field and modify it, press Save.
* Open the MARC editor again for the same title.
* Next to the edited field a new icon should appear, looking like
  a clock face with a encircling arrow; the history icon.
* Clicking the icon should open a table showing all changes done
  to the record, including value change, date/time and user name.
* Clicking a record in the history log should revert that field to the
  clicked value (a previous value)
* Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110226|0   |1
is obsolete||

--- Comment #44 from Aleisha Amohia  ---
Created attachment 110443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110443=edit
Bug 14367: (follow-up) Fixing merge conflicts...

...and other fixes to make patch work.

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110224|0   |1
is obsolete||

--- Comment #19 from Aleisha Amohia  ---
Created attachment 110441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110441=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22431] Incorrect group by in circ/pendingreserves.pl

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #8 from Katrin Fischer  ---
*** Bug 26489 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26489] Holds to pull report fails if SQL strict mode is on

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26489

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
The other bug title made it hard to find - sadly no patch yet.

*** This bug has been marked as a duplicate of bug 22431 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26490] Column configuration for account-fines hides the wrong columns

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26490] Column configuration for account-fines hides the wrong columns

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490

--- Comment #1 from Katrin Fischer  ---
Created attachment 110440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110440=edit
Bug 24690: Fix column configuration for fines trasactions

Hiding the last columns on the fines transactions in the
patron account in staff didn't work correctly as we had missed
adding Home library to the configuration options when it was
added.

This adds the missing definition and now all columns can be
toggled correctly.

To test:
- Go to any patron account in staff
- Go to Accounting > tab transactions (maybe add some fines)
- Toggle the columns on the table using the menu, especially
  - notes, home library and checkout date
- Go to Administration > Table configuration
- Verify the settings for the table work well from there too -
  with the patch, home_library will show as new option

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26490] Column configuration for account-fines hides the wrong columns

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26490

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22971] New location isn't displayed in OPAC for items added in a course reserves

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22971

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED

--- Comment #3 from Katrin Fischer  ---
We had quite a lot of bugfixes for the change of item values in course reserves
since this was reported - I think it's likely to assume RESOLVED FIXED after
Rogan's testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22971] New location isn't displayed in OPAC for items added in a course reserves

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22971

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361

--- Comment #22 from Katrin Fischer  ---
> But the releases on the download page are 19.11.09 and 20.05.03 both from
> 2020-08-31, which is before this issue was reported.

I am not sure what happened there then with what Mason said. It's good to think
about how to improve workflows for such hotfixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110438|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 110439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110439=edit
Bug 15436: (follow-up) Fix separator for a single 440 in staff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||26492


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26492
[Bug 26492] Missing punctuation in series, when part name ($p) and part number
($n) are used
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26492] New: Missing punctuation in series, when part name ($p) and part number ($n) are used

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26492

Bug ID: 26492
   Summary: Missing punctuation in series, when part name ($p) and
part number ($n) are used
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 15436

The XSLT templates use a 'part' template for displaying information from the $n
and $p subfields. We are missing punctuation before part and probably also
between the n and p.

An example from the sample data:

Scarlet and black / Stendhal ; retold by Duncan Campbell-Smith ; series
editors: Andy-Hopkins and Jocelyn Potter.
By: Campbell-Smith, Duncan
Series: Penguin readersLevel 6


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436
[Bug 15436] MARC21: Use semicolon between series name and volume information
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

--- Comment #15 from Katrin Fischer  ---
Created attachment 110438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110438=edit
Bug 15436: (follow-up) Fix separators

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15436] MARC21: Use semicolon between series name and volume information

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436

--- Comment #14 from Katrin Fischer  ---
Hi David,

first of all, thx for testing!

> 1. For Scéla mucce Meic Dathó, (mentioned in comment 9): after the patch it
> displays as Mediaeval and modern Irish series ; vol. VI | <== there is a |
> and no . after the VI

Good catch! I fixed this in staff, in OPAC it was already ok. 

> 2. For Scarlet and black (also mentioned in comment 9): I noticed no change
> after the patch was applied

This is kind of unrelated to the patch here - if you look at the record on
master the problem appears there as well (missing space between 440a and p) The
problem is that the part template used for displaying n and p is not adding any
space or punctuation. I'd like to move that to a separate bug. Ok?

> 3. For the example in the test plan: that displayed as expected (First
> series | Second series ; 1 | Third series ; 1)
> 
> David Nind

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26134] Error when adding to basket from new/staged file when using MARCItemFieldsToOrder

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks|21539   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539
[Bug 21539] addorderiso2709.pl forces librarian to select a ccode and
notforloan code when using MarcItemFieldsToOrder
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21539] addorderiso2709.pl forces librarian to select a ccode and notforloan code when using MarcItemFieldsToOrder

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21539

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on|26134   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134
[Bug 26134] Error when adding to basket from new/staged file when using
MARCItemFieldsToOrder
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26134] Error when adding to basket from new/staged file when using MARCItemFieldsToOrder

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26134

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #7 from Aleisha Amohia  ---
missing dependencies, not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #42 from Katrin Fischer  ---
Tiny conflict, can you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110415|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 110437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110437=edit
Bug 25193: Add AllowRenewalIfOtherItemsAvailableLocation syspref

This syspref works in conjunction with AllowRenewalIfOtherItemsAvailable
syspref. It has two options - allow renewal if other items are available
to fill holds at any branch, or only at the hold's pickup branch.

To test:
1) Apply patch, update database, restart services
2) Go to Administration -> system preferences. Search for
AllowRenewalIfOtherItemsAvailable. Notice the two sysprefs exist in the
same row. By default they should be set to "Don't allow" and "at any
library".
3) Set up a biblio with two items. Have both items held at Branch A.
4) Check out Item A to Borrower A.
5) Place a biblio-level reserve for Borrower B with pickup branch at
Branch A.
6) View Borrower A's checkouts. Confirm you cannot renew Item A ('On
hold' message).
7) Edit Item B, set the current location to Branch B. The items should
now have different locations.
8) Enable the AllowRenewalIfOtherItemsAvailable syspref. Leave the
AllowRenewalIfOtherItemsAvailableLocation syspref set to "at any library".
9) View Borrower A's checkouts. Confirm you CAN renew Item A (because
Item B can fill Borrower B's reserve).
10) Set the AllowRenewalIfOtherItemsAvailableLocation syspref to "at the
hold's pickup library". Keep AllowRenewalIfOtherItemsAvailable syspref
enabled.
11) View Borrower A's checkouts. Confirm you CANNOT renew Item A
(because Item B cannot fill Borrower B's reserve due to being at a
 different branch).
12) Edit Item B, set the current location to Branch A. The items should
have the same location now.
13) View Borrower A's checkouts. Confirm you CAN renew Item A.

Sponsored-by: Chartered Accountants Australia & New Zealand

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|Small patch |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #9 from Katrin Fischer  ---
Hi Alex, can we please have a unit test highlighting the change?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23420] Add "SuggestionsUnwantedFields" to hide fields from the suggestions form

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23420

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #22 from Katrin Fischer  ---
Hi Lucas, I feel like having 2 switches for the same thing (visibility of
library ) can be confusing. Is there a reason we should not take the chance
here to remove AllowPurchaseSuggestionBranchChoice in favor of the new pref?

We could add a line to the databaseupdate to make the branch invisible if
AllowPurchaseSuggestionBranchChoice is set to don't allow now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26390] Add transliteration of Ž in ICU chains

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26390

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Katrin Fischer  ---
It means, the change here should not be necessary... Nick, can you please
double check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26390] Add transliteration of Ž in ICU chains

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26390

--- Comment #5 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #4)
> I wonder if adding the rules is the best way of achieving this. You can add
> a general rule for using the 'base letter'. We have been doing this I think.
> Found a hint about the rule here:
> 
> https://wiki.koha-community.org/wiki/ICU_do_not_undiacritic

Also see the documentation here:
http://userguide.icu-project.org/transforms/general

And our sample files using it:
https://wiki.koha-community.org/wiki/ICU_Chains_Library

This makes it unnecessary to add transliteration rules for every character
diacritic combination.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26390] Add transliteration of Ž in ICU chains

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26390

--- Comment #4 from Katrin Fischer  ---
I wonder if adding the rules is the best way of achieving this. You can add a
general rule for using the 'base letter'. We have been doing this I think.
Found a hint about the rule here:

https://wiki.koha-community.org/wiki/ICU_do_not_undiacritic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26390] Add transliteration of Ž in ICU chains

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26390

--- Comment #3 from Michal Denar  ---
Sorry,
I forgot some ... all here:



























I'm ready for test :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|ei...@sysmystic.com |alei...@catalyst.net.nz
 Status|Signed Off  |Failed QA

--- Comment #18 from Katrin Fischer  ---
The new rule is named "Decrease loan holds (day)" in the circulation rules. I
have some difficulty translating this in my head, even tho I know what is
meant. Could we improve the phrasing maybe?

Decreased loan period for high holds (day) ?

And instead of placing it last, we could place it after the "hard due date" so
it's closer to the other loan period parameters.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26388] Renew all and Renew selected buttons should account for items that can't be renewed

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26388

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #9 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26390] Add transliteration of Ž in ICU chains

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26390

--- Comment #2 from Michal Denar  ---
Hi Nick,
can we add some other czech and slavic letters into ICU too?























I'm ready for test :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26041] Accessibility: The date picker calendar is not keyboard accessible

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26041

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Version(s)|20.11.00, 20.05.04, |20.11.00, 20.05.04,
released in|19.11.10|19.11.10, 19.05.15
 Status|Pushed to oldstable |Pushed to oldoldstable

--- Comment #24 from Victor Grousset/tuxayo  ---
Backported to 19.05.x branch for 19.05.15

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17801] 'Top Most-circulated items' gives wrong results when filtering by checkout date

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #15 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26271] Call to /api/v1/patrons//account returns 500 error if manager_id is NULL

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26271

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #14 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26236] log viewer does not translate the interface properly

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26236

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #10 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26313] "Show analytics" and "Show volumes" links don't work with Elasticsearch and UseControlNumber

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #13 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26331] svc/letters/preview is not executable which prevents CGI functioning

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26331

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #9 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485

--- Comment #19 from Katrin Fischer  ---
I feel this patch is helpful as it is, but I could imagine more improvements in
the future.

If I have a record with 3 holds on it, first is record level and 2 are item
level, the report will tell me only about the next hold: Get any item. This is
correct, but it might be even nicer if it told me to get barcode a, barcode b
and any other other item. I think this would be not easy to implment, so we
should have this patch here first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25448] Update German (de-DE) framework files

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25448

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #12 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26362] Overdue report shows incorrect branches for patron, holdingbranch, and homebranch

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26362

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #9 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110411|0   |1
is obsolete||

--- Comment #18 from Katrin Fischer  ---
Created attachment 110436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110436=edit
Bug 23485: Show barcode in holds to pull

Updated to only show one barcode number, with either an "only" or an "or any
available" depending on whether it's an item or bib hold.
Also incorporating feedback to simplify the TT logic and remove list
formatting.

To test:
1 - Place an item level hold on a bib with several items with the same
callnumber
2 - View the holds to pull report
3 - Try to guess which one on the shelf is right?
4 - Apply patch
5 - See the barcode in holds to pull report
6 - You can now grab the correct item (but don't yet)
7 - Place a next available hold on the same title
8 - See the report now shows one possible valid barcode with the text "or any
available."
9 - Check in a different item that fills the next available hold
10 - Now the report shows the single item for the borrower

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25792] Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25792

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable
 CC||vic...@tuxayo.net
 Version(s)|20.11.00, 20.05.03, |20.11.00, 20.05.03,
released in|19.11.10|19.11.10, 19.05.15

--- Comment #27 from Victor Grousset/tuxayo  ---
Backported to 19.05.x branch for 19.05.15

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26491] New: With Elastisticsearch search results in staff show always only 1 item even if record has multiple

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26491

Bug ID: 26491
   Summary: With Elastisticsearch search results in staff show
always only 1 item even if record has multiple
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de

This is kind of a strange thing I just noticed while looking for a record with
multiple items: With Elasticsearch active, the result list always says: 1
item... for all records.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26491] With Elastisticsearch search results in staff show always only 1 item even if record has multiple

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26491

Katrin Fischer  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25460] Update OAI set (and optionally embed item information) when adding/editing/deleting items

2020-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25460

David Nind  changed:

   What|Removed |Added

 Attachment #109560|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 110435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110435=edit
Bug 25460: Update OAI sets when adding/editing/deleting item records

Also adds syspref to optionally choose to embed item information in record when
adding/editing bibliographic and item records.

Test plan:
1. Enable OAI-PMH and OAI-PMH:AutoUpdateSets sysprefs
2. Create a biblio record with 1 item with CCODE of NFIC
3. In Administration > OAI Sets configuration create a set and define
the mapping:
Field: 952, Subfield: 8, Operator: is equal to,  Value: FIC

4. Run the build_oai_sets.pl script:
 cd misc/migration_tools
 sudo koha-shell 
 ./build_oai_sets.pl -i

5. Check what items are in the OAI set:
sudo koha-mysql 
select * from oai_sets_biblios;

6. Observe your bib from step 2 is not in the set
7. [ITEM EDIT] Edit the item to have CCODE of FIC repeat step 5 and observe
biblio is still not in OAI set
8. [ITEM ADD] Add a new item with CCODE of FIC and repeat step 5 and observe
biblio
still not in OAI set
9. [ITEM DELETE] Delete one of your 2 items and repeat step 5 and observe
biblio still
not in OAI set

10. Apply patch, update database and restart plack (instruction below on
the latter 2 actions):

cd installer/data/mysql
sudo koha-shell 
./updatedatabase.pl
sudo koha-plack --restart 

11. Enable new syspref OAI-PMH:AutoUpdateSetsEmbedItemData
12. [ITEM ADD] Repeat step 8 and observe biblio is now in the OAI set
13. [ITEM EDIT] Edit both items to have a CCODE of NFIC and repeat step 5 and
observe bib now not in set
14. [ITEM EDIT] Edit one of the items to have CCODE of FIC and repeat step 5
and observe bib now in set
15. [ITEM DELETE] Delete all items off bib and repeat step 5 and observe bib
no longer in set

Sponsored-By: Catalyst IT

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >