[Koha-bugs] [Bug 22343] Add configuration options for SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #215 from Tomás Cohen Arazi --- (In reply to Mason James from comment #214) > Created attachment 111442 [details] [review] > Bug 22343: Add configuration options for SMTP servers > > fix SSL tests for u16, using older Email-Sender-1.300021 We should note on the release notes that STARTTLS is not supported on Ubuntu 16. Just in case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22343] Add configuration options for SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 --- Comment #214 from Mason James --- Created attachment 111442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111442=edit Bug 22343: Add configuration options for SMTP servers fix SSL tests for u16, using older Email-Sender-1.300021 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26655] Accessibility: Checkboxes on OPAC lists do not contain aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26655 Henry Bolshaw changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26655] Accessibility: Checkboxes on OPAC lists do not contain aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26655 --- Comment #1 from Henry Bolshaw --- Created attachment 111441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111441=edit Bug 26655: Add ARIA Labels to OPAC Lists This patch adds ARIA labels to opac-shelves.tt so that checkboxes for list items are meaningful to users of screenreaders and other assistive technology. Test Plan: 1/ Open an OPAC list 2/ Inspect the checkbox for a list item 3/ Confirm the aria-label is missing 4/ Apply the patch 5/ Refresh the Opac list page 6/ Inspect the checkbox for a list item 7/ Note that there is now an aria-label with a meaningful description 8/Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #9 from Agustín Moyano --- Created attachment 111440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111440=edit Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t -- You are receiving
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #7 from Agustín Moyano --- Created attachment 111438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111438=edit Bug 8179: Add syspref to database This patch adds the AcqReceiveMultipleOrderLines syspref by atomicupdate and in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #6 from Agustín Moyano --- Created attachment 111437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111437=edit Bug 8179: Add tests This patch adds tests in: * t/db_dependent/Koha/Acquisition/Fund.t * t/db_dependent/Koha/Acquisitoin/Order.t * t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #8 from Agustín Moyano --- Created attachment 111439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111439=edit Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What|Removed |Added Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26655] New: Accessibility: Checkboxes on OPAC lists do not contain aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26655 Bug ID: 26655 Summary: Accessibility: Checkboxes on OPAC lists do not contain aria labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: bolsh...@parliament.uk Reporter: bolsh...@parliament.uk QA Contact: testo...@bugs.koha-community.org The checkboxes on an OPAC list page do not have aria-labels. This means that users of screenreaders and other assistive technology are not informed of a checkbox's purpose. To reproduce issue: 1/ Open a list on the OPAC 2/ Inspect the checkbox for a list item and confirm that there isn't an aria-label As an extra optional step, use an accessibility checker - e.g. the WAVE Accessibility evaluation tool (https://wave.webaim.org/extension/) or Tota11y (https://khan.github.io/tota11y/) - to confirm that this is an accessibility issue. Current code example: Solution example: Bug 25244 fixed a similar issue for OPAC search results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25244] Accessibility: Checkboxes on the search results page do not contain specific aria labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25244 Henry Bolshaw changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26655 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26654] Add item number column to item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26654 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26654] Add item number column to item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26654 --- Comment #1 from Lucas Gass --- Created attachment 111436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111436=edit Bug 26654: Add item number column to item search Test plan: 1. Apply patch 2. Do an item search and notice the column containing the item number -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26654] New: Add item number column to item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26654 Bug ID: 26654 Summary: Add item number column to item search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When doing an item search some libraries would find it useful if there was a column showing the item number -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Magnus Enger changed: What|Removed |Added Blocks||25952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 [Bug 25952] Github search for plugin throwing errors due to API rate limits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 Magnus Enger changed: What|Removed |Added Depends on||23975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 [Bug 23975] Add ability to search and install plugins from GitHub -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #5 from Magnus Enger --- It does seem a bit brittle if we are already reaching the limits of the API. Do you have another approach in mind or do you think the whole “search and install” feature should be reverted? Setting to “in discussion”. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 --- Comment #6 from Caroline Cyr La Rose --- Oh yeah, we should remove the random price to use in production [%- USE KohaDates -%] [%- USE Price -%] [% totalValue = 0 %] [% totalSavings = 0 %] <> Checked out by <> <> (<>) <> Borrowed today [% FOREACH checkout IN checkouts %] [%~ SET item = checkout.item %] [%~ SET biblio = checkout.item.biblio %] [% totalValue = item.price + totalValue %] [% totalSavings = item.price + totalSavings %] [% biblio.title %] Call number: [% item.itemcallnumber %] Due date: [% checkout.date_due | $KohaDates %] [% END %] [% IF overdues.count %] Overdues [% FOREACH overdue IN overdues %] [%~ SET item = overdue.item %] [%~ SET biblio = overdue.item.biblio %] [% totalValue = item.price + totalValue %] [% totalSavings = item.price + totalSavings %] [% biblio.title %] Call number: [% item.itemcallnumber %] Due date: [% overdue.date_due | $KohaDates %] [% END %] [% END %] [% FOREACH old_checkout IN borrower.old_checkouts %] [% IF old_checkout.item %] [% totalSavings = old_checkout.item.price + totalSavings %] [% END %] [% END %] You saved [% totalValue | $Price %] by using the library today! Since you've been a member of the library, you saved [% totalSavings | $Price %]! News <> <> Published on <> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #4 from Caroline Cyr La Rose --- YES! It works!! I changed the title of the commit to correct a typo and make it more specific. I hope that's ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 --- Comment #5 from Caroline Cyr La Rose --- My complete slip for future reference [%- USE KohaDates -%] [%- USE Price -%] [% totalValue = 0 %] [% totalSavings = 0 %] <> Checked out by <> <> (<>) <> Borrowed today [% FOREACH checkout IN checkouts %] [%~ SET item = checkout.item %] [%~ SET biblio = checkout.item.biblio %] [% totalValue = item.price + totalValue %] [% totalSavings = item.price + totalSavings %] [% biblio.title %] Call number: [% item.itemcallnumber %] Due date: [% checkout.date_due | $KohaDates %] [% END %] [% IF overdues.count %] Overdues [% FOREACH overdue IN overdues %] [%~ SET item = overdue.item %] [%~ SET biblio = overdue.item.biblio %] [% totalValue = item.price + totalValue %] [% totalSavings = item.price + totalSavings %] [% biblio.title %] Call number: [% item.itemcallnumber %] Due date: [% overdue.date_due | $KohaDates %] [% END %] [% END %] [% FOREACH old_checkout IN borrower.old_checkouts %] [% IF old_checkout.item %] [% old_checkout.item.price %] [% totalSavings = old_checkout.item.price + totalSavings %] [% END %] [% END %] You saved [% totalValue | $Price %] by using the library today! Since you've been a member of the library, you saved [% totalSavings | $Price %]! News <> <> Published on <> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 --- Comment #3 from Caroline Cyr La Rose --- Created attachment 111435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111435=edit Bug 26648: Prevent explosion in notices on missing item The item accessor in Koha::Old::Checkouts could explode given a checkout where the item had been deleted. To test 1/ Edit the issueslip notice to output some item details from the borrowers old checkouts [% FOREACH old_checkout IN borrower.old_checkouts %] [% IF old_checkout.item %] [% old_checkout.item.price %] [% END %] [% END %] 2/ Delete the item associated with an old checkout for a test patron 3/ Print the issueslip for the patron 4/ Note a server side error is triggered 5/ Apply the patch 6/ Print the slip again and note the price details for old checkouts are now displayed 7/ Signoff Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 --- Comment #11 from Tomás Cohen Arazi --- Added a few baskets and orders (standing and not), filtering on 'is_standing' works as expected. Tests pass. No QA script complaints. Well done, Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 111433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111433=edit Bug 26503: Add limit for standing orders to acq advanced search This allows to filter on standing orders on the acq advanced search checkbox. For this purpose a new checkbox is shown behind the order status search option. As both not yet ordered and standing orders have the status 'new' or partially received internally, this seems like a good placement as it will help distinguish these cases clearly. new + standing order = standing order, but nothing received yet partially received + standing order = active standing order all status + standing order = all standing orders To test: - Create some baskets with at least one order, some 'standing' and others not - In the top toolbar choose tab Orders search > Advanced search - Make some searches with and without the new 'Standing order' option - Verify the right orders are found - In the search results standing orders will now show with the status + (standing order). Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 111434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111434=edit Bug 26503: Add unit tests Run prove t/db_dependent/Acquisition.t Verify all tests pass. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 Tomás Cohen Arazi changed: What|Removed |Added Attachment #111431|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 Tomás Cohen Arazi changed: What|Removed |Added Attachment #111432|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #34 from Katrin Fischer --- Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 Katrin Fischer changed: What|Removed |Added Attachment #110550|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 111432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111432=edit Bug 26503: Add unit tests Run prove t/db_dependent/Acquisition.t Verify all tests pass. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 Katrin Fischer changed: What|Removed |Added Attachment #110549|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 111431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111431=edit Bug 26503: Add limit for standing orders to acq advanced search This allows to filter on standing orders on the acq advanced search checkbox. For this purpose a new checkbox is shown behind the order status search option. As both not yet ordered and standing orders have the status 'new' or partially received internally, this seems like a good placement as it will help distinguish these cases clearly. new + standing order = standing order, but nothing received yet partially received + standing order = active standing order all status + standing order = all standing orders To test: - Create some baskets with at least one order, some 'standing' and others not - In the top toolbar choose tab Orders search > Advanced search - Make some searches with and without the new 'Standing order' option - Verify the right orders are found - In the search results standing orders will now show with the status + (standing order). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26503] Allow to limit on standing orders in acquisition advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26503 --- Comment #6 from Katrin Fischer --- Sorry, of course, that one slipped in untintentionally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the|This patch adds the |This patch adds a new release notes|transacting library in |column in the accounting |fines that are linked to|tables for a patron. The |checkouts in the accounting |column will show the |section for the patron. |checkout library for ||charges that are tied to ||circulation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #33 from Katrin Fischer --- I am not the patch author :) My thought: the checkout library is the library an item was checked out from. A transacting library for a fine would be the one where it was created manually or if item related it might depend on which library was used for creating the fine (thinking about CircControl) or for payments where it was paid at. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26515] Add Koha::Acquisition::Order->cancel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26515 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 111430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111430=edit Bug 26515: Better feedback on errors This patch makes the possible causes of biblio removal failure to be specified on the passed error message. This way the UI could render better reports on the situation. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26653] New: Allow editing of item notes on moredetail.pl with circulation permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26653 Bug ID: 26653 Summary: Allow editing of item notes on moredetail.pl with circulation permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl If a user has circulation permissions, they can edit the lost/damaged/withdrawn statuses of an item on moredetail.pl (the items tab in the catalog). However, they cannot edit the public and non-public notes for that item. Those notes are only editable on this if one also has edit_items permission, which opens up a lot more actions. I feel the editing of these notes from moredetail should also fall under circulation permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #32 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #31) > Hm, either the bug title or the bug description are wrong - it's either > transacting library or checkout library, but both are not the same > necessarily? The description links transacting+checkouts, that's why I thought it was correct. Feel free to adjust it as I'm not attached to that description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #31 from Katrin Fischer --- Hm, either the bug title or the bug description are wrong - it's either transacting library or checkout library, but both are not the same necessarily? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548
--- Comment #23 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #22)
> Who is volunteering?
Hm, just clearning the inputs won't fix the problem of bug 7607 I think? The
problem is, that people leave search fields empty so idx and search terms don't
match up.
kw - no search term entered
title - some title words
Turns into: kw search for some title words
We have found this workaround from the other bug to be working, but I am not
sure if that will fix the ugliness of the URL.
$(document).ready(function(){
$("input[name='do']").click(function(){
$("input[name='q']").each(function(i){
if (!$(this).val()){
$("select[name='idx']").eq(i).append('');
}
});
});
});
and in intranetuserjs :
$(document).ready(function() {
$("#submit1,#submit2").click(function(){
$("input[name='q']").each(function(i){
if (!$(this).val()){
$("select[name='idx']").eq(i).append('');
}
});
});
});
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #18 from Katrin Fischer --- (In reply to Agustín Moyano from comment #15) > Great job Katrin.. if I may add a comment, in the atomic update, if there > are some budget periods that were not found, instead of not adding the FK > constraint, I would: > > 1. Create a temporary table.. something like _bug_18050_aqbudgets where I > would copy the offending rows > > 2. Update aqbudgets.budget_period_id to null, add the FK constraint > > 3. Emit the warning that some budget periods where not found, and a copy of > those rows where preserved in _bug_18050_aqbudgets table > > If it's ok to you, I can add a follow-up with those steps Hi Augustin, it's not as simple as that I am afraid. If there are orphan aqbudgets, there could also be orders attached to them. And if there are orders, there could be linked items... the rabbit hole is deeper. Maybe another better approach could be to go the other direction: We add a aqbudgetperiods entry - this would also allow the library to deal with things in the GUI. I am not sure I am able to write that one, so if anyone beats me to it I'd be more than happy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26647] The Cancel button in holds table should be translated in context for Swedish.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647
Caroline Cyr La Rose changed:
What|Removed |Added
CC||caroline.cyr-la-rose@inlibr
||o.com
Status|Needs Signoff |Failed QA
--- Comment #2 from Caroline Cyr La Rose ---
It worked, but the msgid and the msgctxt in my sv-SE-messages.po seem to be
inverted?
169 msgctxt "Cancel"
170 msgid "Cancel hold button"
171 msgstr ""
(don't mind the , I put something silly just to make sure I noticed if it
worked, hehe).
It should be msgctxt Cancel hold button and msgid Cancel.
But it works, so I'm not sure.
I think in your holds-table.inc, you should write it in this order
[% tp('Cancel hold button','Cancel') | html %]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25078] Gracefully stop updatedatabase/installer when a database change cannot be applied
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #11 from Agustín Moyano --- A question, can we have upgrade tests?.. I mean, a way to set some tables in a certain condition, execute the upgrade process and check the results all within a single transaction to rollback? Is it possible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #17 from Agustín Moyano --- Hi Katrin, I added the follow-up just in case you'd like to check it out when you've got time. Please feel free to remove it if you feel it's not ok. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18050] Missing constraint on aqbudgets.budget_period_id in aqbudgets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18050 --- Comment #16 from Agustín Moyano --- Created attachment 111429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111429=edit Bug 18050: (follow-up) Force adding FK constraint When there are inconsistent budget_period_id in aqbudgets this patch creates the table _bug_18050_aqbudgets with the original data, then sets the column to null and warns the user that there is inconsistent data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26401] xt/fix-old-fsf-address* are no longer needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26401 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.05 released in|| CC||lu...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #6 from Lucas Gass --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||joonas.kylm...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26652] Add a way to mark messages as 'seen' in Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26652 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26651 CC||agustinmoy...@theke.io, ||jonathan.dru...@bugs.koha-c ||ommunity.org, ||joonas.kylm...@helsinki.fi, ||julian.maur...@biblibre.com ||, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Status|NEW |In Discussion Depends on||26555 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 [Bug 26555] Add a way for Koha::Object(s) to carry execution information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added Blocks||26652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26652 [Bug 26652] Add a way to mark messages as 'seen' in Koha::Object -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26651] Add Koha::Object->reset_messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26651 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26652 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26652] New: Add a way to mark messages as 'seen' in Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26652
Bug ID: 26652
Summary: Add a way to mark messages as 'seen' in Koha::Object
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Bug 26555 adds a way for Koha::Object-derived classes to carry errors messages
between method calls. On bug 26651 there's a proposal for a
Koha::Object->reset_messages method that *could* be used to clean that messages
list, if required.
Another option could be to have Koha::Object::Message carry some flag (seen?)
that tells if the message has already been looked at. So if ->messages is
called twice, the second one returns no results as all messages have been
marked as seen:
=head3 messages
$object->methods
->that
->each
->adds
->messages;
@messages = $object->messages; # all accumulated messages
@messages = $object->messages; # @messages is empty
$object->boo;
@messages = $object->messages; # @messages contains messages added by ->boo
The implementation could look like:
=cut
sub messages {
my ($self) = @_;
my @messages = map { $_->mark_as_seen } @{ grep { $_->unseen } @{
$self->messages } };
return \@messages;
}
package Koha::Object::Message;
sub mark_as_seen {
my ($self) = @_;
$self->{seen} = 1;
return $self;
}
A method for retrieving all messages in the object lifetime could be added.
I put this here for discussing it, and just in case someone is looking for
something like this and finds this bug, adding their two cents here with their
use cases.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26651] Add Koha::Object->reset_messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26651 Tomás Cohen Arazi changed: What|Removed |Added CC||agustinmoy...@theke.io, ||jonathan.dru...@bugs.koha-c ||ommunity.org, ||julian.maur...@biblibre.com ||, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 111428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111428=edit Bug 26555: Make sure _messages is always initialized Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 111427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111427=edit Bug 26555: Add ->messages and ->add_message to Koha::Object This patch adds a way to make Koha::Object-derived classes to carry messages around. This targets non-fatal errors, or around action flags for the caller, to avoid complex exception handling on the controllers when it is not expected to be fatal. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 111426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111426=edit Bug 26555: Add Koha::Object::Message This patch introduces a tiny class for encapsulating execution messages in Koha::Object derived classes. To test: 1. Apply this patch 2. Run; $ kshell k$ prove t/Koha/Object/Message.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110967|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110969|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110983|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110968|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26651] Add Koha::Object->reset_messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26651
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 111425
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111425=edit
Bug 26651: Add ->reset_messages
This patch was orginally part of bug 26555, and introduces a method for
cleaning the accumulated messages.
The idea is that you might run:
$patron->some
->series
->of
->method
->calls;
if ( $patron->messages ) { ... }
and for next calls, want the messages cleared. So you can call
$patron->reset_messages;
To test:
1. Run:
$ kshell
k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
4. Sign off :-D
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26563] Merging patrons will cause the "time queued" column in the message queue to be updated to the current date and time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26563 Kyle M Hall changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26650] New: Add Koha::Object->reset_messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26650 Bug ID: 26650 Summary: Add Koha::Object->reset_messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org This method was originally introduced as part of bug 26555. But it was not clear if it was required, or even if some more complex mechanism for marking 'seen' messages is required. I'm leaving this specific patch here for discussing it once someone finds a real need for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26555] Add a way for Koha::Object(s) to carry execution information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 Tomás Cohen Arazi changed: What|Removed |Added Blocks||26651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26651 [Bug 26651] Add Koha::Object->reset_messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26651] Add Koha::Object->reset_messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26651 Tomás Cohen Arazi changed: What|Removed |Added Depends on||26555 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Status|NEW |In Discussion Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26555 [Bug 26555] Add a way for Koha::Object(s) to carry execution information -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26651] New: Add Koha::Object->reset_messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26651 Bug ID: 26651 Summary: Add Koha::Object->reset_messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org This method was originally introduced as part of bug 26555. But it was not clear if it was required, or even if some more complex mechanism for marking 'seen' messages is required. I'm leaving this specific patch here for discussing it once someone finds a real need for it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||This patch adds the release notes||transacting library in ||fines that are linked to ||checkouts in the accounting ||section for the patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 111424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111424=edit Bug 26327: (QA follow-up) Fix colspan in boraccount.tt Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 111423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111423=edit Bug 26327: (follow-up) Add transacting library to the transactions tab Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 111420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111420=edit Bug 26327: Add ->library method to Koha::*Checkout This patch adds a 'library' relationship to the Issue and OldIssue resultsets, to be used in the Koha::*Checkout classes corresponding accessors. This way we will be able to eventually embed and filter on library fields on the API. The ->library method is then added to the classes- To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old.t t/db_dependent/Koha/Checkout.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 111421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111421=edit Bug 26327: Include transacting library in fines This patch introduces a new column on the fines table to display the checkout library when the fine is tied to a checkout. To test: 1. Have an overdue item that generated a fee 2. Look at the 'Accounting' tab, 'Make a payment' => FAIL: There's no information about the library 3. Apply this patch 4. Restart all 5. Reload and repeat 2 => SUCCESS: There's a column with the library name! 6. Identify the issue_id for the mentioned checkout and: $ koha-mysql kohadev > UPDATE old_issues SET branchcode='TOM' WHERE issue_id=11; (i.e. set the branchcode to an invalid value, to emulate a deleted branch). 7. Reload => SUCCESS: It doesn't explode, it doesn't display a library name. 8. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Attachment #111417|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 111422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111422=edit Bug 26327: Add to columns settings Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110421|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110422|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110424|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26636] New objects.find mojolicious helper
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 --- Comment #2 from Agustín Moyano --- Created attachment 111419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111419=edit Bug 26636: Add objects.find helper This patch adds the objects.find helper. Much like objects.search, it returns the to_api method with embedded children and expanded authorised values. This patch will be implemented in bug 8179, so please test there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110425|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26636] New objects.find mojolicious helper
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 Agustín Moyano changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26636] New objects.find mojolicious helper
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26636 --- Comment #1 from Agustín Moyano --- Created attachment 111418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111418=edit Bug 26636: Add tests Add tests in t/db_dependent/Koha/REST/Plugin/Objects.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Attachment #110423|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 111417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111417=edit Bug 26327: Add to columns settings Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26327] Include checkout library in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26327 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #24 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #23) > Can you rebase please? > > Applying: Bug 26327: (follow-up) Add transacting library to the transactions > tab > error: sha1 information is lacking or useless (admin/columns_settings.yml). What git version are you using? Mine gave me a really trivial merge conflict: $ git --version git version 2.28.0 $ git diff diff --cc admin/columns_settings.yml index 9400dcf3691,3f1d19ee79d..000 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@@ -666,7 -666,7 +666,11 @@@ modules - columnname: issuedate - ++<<< HEAD + columnname: home_library ++=== + columnname: checked_out_from ++>>> Bug 26327: (follow-up) Add transacting library to the transactions tab - columnname: note - -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26649] New: Authorized Value suggest_status doesn't respect branch limitation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26649 Bug ID: 26649 Summary: Authorized Value suggest_status doesn't respect branch limitation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lisettesla...@gmail.com QA Contact: testo...@bugs.koha-community.org If you create a suggest_status AV and set it to only be for certain branches, it does not respect that. Our consortium would like to be able to set up custom statuses without cluttering staff's screens with various status's for each branch both in the drop down for setting a status and on the tabs when looking at suggestions. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 --- Comment #2 from Martin Renvoize --- Dumping this example here so I don't loose it [% USE Price %] [% savings = 0 %] [% FOREACH checkout IN borrower.checkouts %] [% savings = checkout.item.price + savings %] [% END %] [% FOREACH old_checkout IN borrower.old_checkouts %] [% IF old_checkout.item %] [% savings = old_checkout.item.price + savings %] [% END %] [% END %] You have saved [% savings | $Price %] to date by using the library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26644] Keyword search on "Reports" is persistant
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26644 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 --- Comment #1 from Martin Renvoize --- Created attachment 111416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111416=edit Bug 26648: Prevent explosion on missin item The item accessor in Koha::Old::Checkouts could explode given a checkout where the item had been deleted. To test 1/ Edit the issueslip notice to output some item details from the borrowers old checkouts [% FOREACH old_checkout IN borrower.old_checkouts %] [% IF old_checkout.item %] [% old_checkout.item.price %] [% END %] [% END %] 2/ Delete the item associated with an old checkout for a test patron 3/ Print the issueslip for the patron 4/ Note a server side error is triggered 5/ Apply the patch 6/ Print the slip again and note the price details for old checkouts are now displayed 7/ Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26648] New: Prevent internal server error if item attached to old checkout has been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648 Bug ID: 26648 Summary: Prevent internal server error if item attached to old checkout has been removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Whilst playing with notices to see if we could calculate a running total of savings for a library user to add to their issueslip notice I found that if an item relating to an old checkout has been deleted, then the relation accessor can explode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26647] The Cancel button in holds table should be translated in context for Swedish.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 Timothy Alexis Vass changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26647] The Cancel button in holds table should be translated in context for Swedish.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26647 --- Comment #1 from Timothy Alexis Vass --- Created attachment 111415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111415=edit Bug 26647 - The Cancel button in holds table should be translated in context for Swedish 0) Apply the patch and add a hold on an item. 1) Install Swedish language, sv-SE and change interface language to Swedish 2) Modify sv-SE-opac-bootstrap.po and add this: msgctxt "Cancel hold button" msgid "Cancel" msgstr "Ta bort" 3) Go to the Holds table at /cgi-bin/koha/opac-user.pl#opac-user-holds 4) Confirm that the button is translated as "Ta bort" 5) Sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Agustín Moyano changed: What|Removed |Added Attachment #111411|0 |1 is obsolete|| Attachment #111412|0 |1 is obsolete|| --- Comment #6 from Agustín Moyano --- Created attachment 111413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111413=edit Bug 26635: Add tests Add tests in t/db_dependent/Koha/Object.t and t/db_dependent/Koha/REST/Plugin/Objects.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #7 from Agustín Moyano ---
Created attachment 111414
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111414=edit
Bug 26635: Expand authorised values in to_api method
This patch adds the posibility to expand authorised values when to_api
method is called.
The classes where authorised values should expand must implememnt the
_fetch_authorised_values method, and must return a hash like the
following
{
column_name => Koha::AuthorisedValue->unblessed
...
}
This patch will be used in bug 8179, so please test there.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 Agustín Moyano changed: What|Removed |Added Attachment #111401|0 |1 is obsolete|| --- Comment #4 from Agustín Moyano --- Created attachment 111411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111411=edit Bug 26635: Add tests Add tests in t/db_dependent/Koha/Object.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
