[Koha-bugs] [Bug 26733] New: Javascript crashes - makes all holds reservable

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26733

Bug ID: 26733
   Summary: Javascript crashes - makes all holds reservable
 Change sponsored?: ---
   Product: Koha
   Version: 20.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: rickard.lindf...@sh.se
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 111953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111953=edit
JS Crash example

Hello! We've just tested the new version, 20.05.04 a bit and had some problems
with placing a hold in the staff interface.

1. Set On shelf holds allowed to If all unavailable to an item type.
2. Search the catalog for a book with available items with the item type above.
2. Place a hold and choose a user that can make that hold.
3. circ-patron-search-results_20.0504000.js crashes. var override_items should
use a "," instead of a ";". (See picture). This crash result: the librarians
can place a hold on this book, which should not be possible. Note: there is no
problem in the OPAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26130] opacbookbag 'Cart' confuses patrons - add optional name alternatives?

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26130

--- Comment #16 from David Cook  ---
(In reply to Katrin Fischer from comment #15)
> The problem was pointed out in comment#9 - the term is not only used as a
> single word, but also in some sentences. And in these cases, it might not be
> an easy search and replace action, as surrounding words need to be changed
> as well.

Ah, I hadn't thought of someone trying to search and replace all instances of
cart, but I see now why a person would want to. The advantage of the token
model would be that you could cluster all your strings together, so that a
translator could just focus on translating "cart" in context across a range of
strings while on one screen, but that might just be me being overly optimistic
too. 

> I believe what you suggest there is not so different to the new
> mechanics/workflows we have with the I18N code.

Could be! After doing a bit more reading, I think I have more reading to do.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26130] opacbookbag 'Cart' confuses patrons - add optional name alternatives?

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26130

--- Comment #15 from Katrin Fischer  ---
(In reply to David Cook from comment #14)
> (In reply to Katrin Fischer from comment #13)
> > The problem here is a bit specific as we are trying to figure out
> > how to best way would be to have different translations for the same
> > language.
> 
> Ah, that is an interesting idea. That actually fits more with the idea I
> described rather than the one used in Bug 26392 (and all that other I18N
> module stuff I'm seeing). If we used a token/msgid like "cart.nickname1" =
> "Cart", "cart.nickname2" = "Bookbag", or whatever... you could have a
> dropdown system preference to choose the "nickname" code (e.g. nickname1,
> nickname2, etc) that you want to use, and then build the token string and
> pass that off to the I18N system that fetches the translation from a
> dictionary. 

The problem was pointed out in comment#9 - the term is not only used as a
single word, but also in some sentences. And in these cases, it might not be an
easy search and replace action, as surrounding words need to be changed as
well.

I believe what you suggest there is not so different to the new
mechanics/workflows we have with the I18N code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23823] Allow system preferences to be bookmarked

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #30 from David Cook  ---
This looks very useful.

Great to see a Koha patch from you, Ivan!

For those that don't know, Ivan (helix84) has been contributing to DSpace for
quite a few years now. 

Hopefully we'll see more patches :D.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25779] ExcludeHolidaysFromMaxPickUpDelay has opposite effect

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25779

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Katrin Fischer  ---
I believe this has been fixed by switching the options in the pref since this
bug has been filed:


  Ignore the calendar



  Use the calendar


-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23574] Adding a suggestion to a basket when UseACQFrameworkForBiblioRecords is use publication date is not copied

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23574

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Keywords||Academy

--- Comment #7 from Katrin Fischer  ---
Not an enhancement, but more of a bug. Maybe someone else could give it a go in
confirming the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26706] Fix btn-default styling for better contrast

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26706

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26687] Add color to Font Awesome icon for superlibrarian patrons

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687

--- Comment #8 from David Cook  ---
Maybe a superlibrarian should have the shield to denote staff status *plus* a
star to denote superlibrarian status?

That might also be a nice visual sanity check to make sure that only staff are
superlibrarians heh.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26371] Prevent MARC tags from import when using Z39.50

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26371

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Katrin Fischer  ---
Hi Barbara, I think the XSL or bug 17485 could fix your issue. 

I am deduplicating this with bug 17485 (using MARC modification templates on
import) that I think would give a good base for these kind of operations
without having to use XSL that requires more technical knowledge.

*** This bug has been marked as a duplicate of bug 17485 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17485] Add Marc modification templates to z39.50 import

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17485

Katrin Fischer  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #1 from Katrin Fischer  ---
*** Bug 26371 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26687] Add color to Font Awesome icon for superlibrarian patrons

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26687

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #7 from David Cook  ---
I agree with Martin. It's been years since I delved into accessibility
research, but I do recall that using colour as the sole signifier of something
makes something less accessible.

I like your idea, Owen, of using the star!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7972] GUI for Crons

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

--- Comment #8 from Katrin Fischer  ---
You are right, I missed the point of scheduling them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7972] GUI for Crons

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

--- Comment #7 from David Cook  ---
(In reply to Katrin Fischer from comment #6)
> Some of our cronjob scripts are already controlled by system preferences. I
> think that would be the easiest way to move on here: Schedule them all by
> default for all instances, but allow libraries to configure (and turn off by
> configuration) using system preferences or possibly a separate page.
> 
> Examples would be the *LongOverdue prefs*.

Could you clarify what you mean? I think Christopher and Barbara were referring
to changing the time that the cronjobs run? 

(For instance, as a vendor, we only run
/usr/share/koha/bin/cronjobs/process_message_queue.pl between certain hours so
that we're not sending emails out in the middle of the night. I could see
libraries wanting to do that.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Exclude itemtypes from UpdateNotForLoanStatusOnCheckin

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

--- Comment #18 from Katrin Fischer  ---
Still applies, comes with a nice test plan, written in NZ... might be nice for
DIY at KohaCon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25784] Flag to make individual items non-holdable

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25784

Katrin Fischer  changed:

   What|Removed |Added

Version|19.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7972] GUI for Crons

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

--- Comment #6 from Katrin Fischer  ---
Some of our cronjob scripts are already controlled by system preferences. I
think that would be the easiest way to move on here: Schedule them all by
default for all instances, but allow libraries to configure (and turn off by
configuration) using system preferences or possibly a separate page.

Examples would be the *LongOverdue prefs*.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897

--- Comment #4 from Katrin Fischer  ---
Created attachment 111952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111952=edit
Bug 25897: Use cn_sort for sorting callnumbers in inventory table

Instead of using the machine sortable form of the callnumber from
cn_sort the table was only sorting on the callnumber. This tries
to fix it using the same technique as for sorting the differently
formatted dates.

To test:
- If your database has items with suitably cataloged items, use
  these. Otherwise you could use the examples from the bug report:

- Catalog items with the following barcodes:
   B 29 V55 1998
   B29 .C55 2008
   B29 .L24 1983
   B29 .L264 1998
   B29 .P666 2004
  Make sure the LOC is selected in $2 as source of classification
  This makes sure the sortable form of the callnumber is calculated
  correctly.
- Go to inventory
- Search for your items
- Before patch, they should sort on callnumber as above, after the
  patch the correct sort order should be:
   B29 .C55 2008
   B29 .L24 1983
   B29 .L264 1998
   B29 .P666 2004
   B 29 V55 1998

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7972] GUI for Crons

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
I don't think that this is practical.

Generally speaking, cronjobs are really handled at the system administration
level rather than the application level.

With Koha Debian packages, there are cronjobs deployed out of the box, but
they're not manageable by the Koha instance. 

I suppose the cronjobs could be re-engineered, at least for the Koha Debian
packages, but then that becomes a logistical problem for system administrators. 

That being said, there is more work being done in terms of background tasks. 

What kind of cronjobs do people have in mind here? It could be more practical
to move some functionality from cronjobs into a different kind of scheduled
task.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy
   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

--- Comment #3 from Katrin Fischer  ---
I used LOC and they are sorting now as described in the example, will upload a
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897

--- Comment #2 from Katrin Fischer  ---
Can someone tell me which schema these are? Trying a fix and want to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26722] [Omnibus] Don't use "here" and similar as a link text

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26304] Better failure message when patrons can't log into the Opac due to self check permissions

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26304

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
I agree with Jonathan that we can't give away any information about users or
their permissions on the OPAC when unauthenticated due to security concerns. 

I like Katrin's idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25897

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26664] Inventory: Sorting column 'Last seen' goes wrong

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||25897


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897
[Bug 25897] Inventory table call number sort should use cn_sort value
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||26664
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19915


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664
[Bug 26664] Inventory: Sorting column 'Last seen' goes wrong
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25240] Accessibility: The 'Basket' page contains an inaccessible table

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25240

--- Comment #2 from Katrin Fischer  ---
I think maybe this is just saying that aria-label and content of th should be
matching?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8676] Show vendor name in source of acquisition

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676

--- Comment #15 from Katrin Fischer  ---
Hi Jonathan,

I think this could be really nice for libraries just starting out with Koha,
but could be an issue for libraries that already have a lot of data in $e
(existing vendor ids, non-existing vendor ids and actual vendor names). Which
means it probably should be an optional feature.

We run into problems here when:
- Libraries have entered the vendor's name in $e (think of libraries not using
the acq module)
- Libraries have values in $e that cannot be resolved as a vendor, which could
lead to a data loss issue.

Could we somehow allow to display the data directly in the input field, if it
cannot be resolved to a value from the pull down?

Maybe we could split display in the items table (display vendor name when it
can be resolved, otherwise display $e) and the form?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392

--- Comment #16 from Katrin Fischer  ---
I think for that prominent spot on the start page it would be good to put in
the little more work. And syntax can be learned :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392

--- Comment #15 from David Cook  ---
(In reply to Katrin Fischer from comment #14)
> We can also translate using singular/plural forms now - just missing an
> example right now, but there is documentation on the wiki:
> 
> https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,
> _context,_and_more_RFC
> 
> So we can make it read 1 checkout, 2 checkouts depending on the actual
> number.

Yeah, I saw that, but it does require the developer to know the syntax, and it
puts more work on translators. I think there are certainly contexts where you
need to do that, but not in my above example.

I was reading somewhere too about plurals being problematic in other languages
like Chinese and Russian, but my language skills don't extend that far. 

I do see Slovak mentioned in
https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_RFC,
so that's interesting! 

Perhaps I just need to read more before I comment too much.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26130] opacbookbag 'Cart' confuses patrons - add optional name alternatives?

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26130

--- Comment #14 from David Cook  ---
(In reply to Katrin Fischer from comment #13)
> You might want to have a look at bug 26392 and join the discussion there.

Bug 26392 is... well I don't like it at all. I can't see people actually using
it. And if they're forced... then dev times will go up or devs might not happen
at all?

> The problem here is a bit specific as we are trying to figure out
> how to best way would be to have different translations for the same
> language.

Ah, that is an interesting idea. That actually fits more with the idea I
described rather than the one used in Bug 26392 (and all that other I18N module
stuff I'm seeing). If we used a token/msgid like "cart.nickname1" = "Cart",
"cart.nickname2" = "Bookbag", or whatever... you could have a dropdown system
preference to choose the "nickname" code (e.g. nickname1, nickname2, etc) that
you want to use, and then build the token string and pass that off to the I18N
system that fetches the translation from a dictionary. 

You can see that idea a bit in https://metacpan.org/pod/Catalyst::Plugin::I18N
with the following construct:

# MyApp/I18N/i_default.po
msgid "messages.hello.catalyst"
msgstr "Hello Catalyst - fallback translation"

[% l('messages.hello.catalyst') %]

(Of course, I think putting a .po file in a module lib path is horrifying, but
a person wouldn't have to do that.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392

--- Comment #14 from Katrin Fischer  ---

> Then you're just needing to translate "Checkouts" rather than singular and
> plural forms.

We can also translate using singular/plural forms now - just missing an example
right now, but there is documentation on the wiki:

https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_context,_and_more_RFC

So we can make it read 1 checkout, 2 checkouts depending on the actual number.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #13 from David Cook  ---
This does not look developer friendly... 

As an aside...

The following could be written better:
[% checkouts | html %]
checkout(s)

Following the suggestions from
https://developer.atlassian.com/server/framework/atlassian-sdk/pluralising-internationalisation-strings/:
Checkouts: [% checkouts | html
%]

Then you're just needing to translate "Checkouts" rather than singular and
plural forms.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819

--- Comment #9 from Katrin Fischer  ---
Created attachment 111951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111951=edit
Bug 6819: Hide individual cancel order links when order line has been received

This is to prevent mistakes - a received order should not be
cancelled, but 'undo receive' needs to be done first for things
to turn out correctly.

To test:
- Create a basket with at least 2 orders
- Close basket
- Receive one of your orders at least
- Go back to the basket
- Reopen basket
- The cancel links should only show on the "not received" orders

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25596] "Overpayment refund" is not translatable

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25596

--- Comment #9 from Caroline Cyr La Rose  ---
The string is added to the .po file.

However, when I have the patch on, and I try to backdate check in an item, it
gives me a broken FK constraint...

1) Checkout an item to a patron with due date 2020/10/15
2) Run fines.pl
3) Pay fine
4) Checkin with backdate 2020/10/14

With patch, it gives me a software error; without patch, it works...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26703] We should reconsider best practice for our title elements

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

--- Comment #1 from Lisette Scheer  ---
This would also be helpful for folks who bookmark reports as a bookmark
currently shows like this in my version of Koha:

Koha › Reports › Guided reports wizard › Saved reports › GHW - BORROWERS -
'VAL' borrowers with outstanding fines/fees Report

It can be edited as a bookmark (and part of it is a very long report title) but
being able to strip out some of that breadcrumb and/or have the more generic
parts at the end would be helpful for some staff. 

Lisette

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26731] Change default sort order of inactive budgets on aqbudgetperiods.pl

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26731

Katrin Fischer  changed:

   What|Removed |Added

Summary|Improve display of inactive |Change default sort order
   |budgets on  |of inactive budgets on
   |aqbudgetperiods.pl  |aqbudgetperiods.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26732] Add a dropdown box on acqui-home.pl to select which inactive budget to view

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26732

Katrin Fischer  changed:

   What|Removed |Added

Version|19.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26304] Better failure message when patrons can't log into the Opac due to self check permissions

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26304

--- Comment #2 from Katrin Fischer  ---
Maybe we could also display a warning on one account pages on the staff side
that the patron cannot log into the OPAC and is only to be used for the self
check?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26732] New: Add a dropdown box on acqui-home.pl to select which inactive budget to view

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26732

Bug ID: 26732
   Summary: Add a dropdown box on acqui-home.pl to select which
inactive budget to view
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org

When clicking on “Show inactive budgets” from acqui-home.pl you can get a very
long page of data if you have even several inactive budgets causing to user to
have to do lots of scrolling in order to see last year’s budget.  It would be
helpful to create a dropdown box to allow the user to select which inactive
budget they would like to view.  This would be more efficient and prevent
unnecessary scrolling.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26731] New: Improve display of inactive budgets on aqbudgetperiods.pl

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26731

Bug ID: 26731
   Summary: Improve display of inactive budgets on
aqbudgetperiods.pl
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org

It would be useful to display the table of inactive budgets on
aqbudgetperiods.pl in descending order by start date as the default.  Staff is
more likely to want to look at last year’s budget than one from 5 years ago. It
would also save a click every time we view the inactive budgets list.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26730] Cannot receive orders

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26730

--- Comment #2 from Katrin Fischer  ---
Thx Nick, I will leave this open until the follow-up is pushed for better
visibility.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26730] Cannot receive orders

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26730

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
See follow up patch on bug 23376

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23376] Cleanup order receive page code

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||26730


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26730
[Bug 26730] Cannot receive orders
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26730] Cannot receive orders

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26730

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||23376


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376
[Bug 23376] Cleanup order receive page code
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26680] Update (rcvd) to (received) with its own class in basket view

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680

--- Comment #7 from Katrin Fischer  ---
Receiving items is broken for me too - independent of this patch :( I filed bug
26730.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26680] Update (rcvd) to (received) with its own class in basket view

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26730

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26730] New: Cannot receive orders

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26730

Bug ID: 26730
   Summary: Cannot receive orders
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When clicking on receive on any order line, Koha explodes:

Template process failed: undef error - The method Koha::Item->size is not
covered by tests!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26729] New: When adding a new vendor set focus for cursor to name input box on supplier.pl

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26729

Bug ID: 26729
   Summary: When adding a new vendor set focus for cursor to name
input box on supplier.pl
 Change sponsored?: ---
   Product: Koha
   Version: 19.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: barbara.john...@bedfordtx.gov
QA Contact: testo...@bugs.koha-community.org

When adding a new vendor on supplier.pl you have to click in the name input
box, which is a required field, so that you can enter text.  It would be more
efficient to set the focus for the cursor to always be in the vendor name input
box so that you could just begin typing and eliminate an extra click.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26526] Use of checkout notes not clear in OPAC

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26526

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||barbara.johnson@bedfordtx.g
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26680] Update (rcvd) to (received) with its own class in basket view

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680

--- Comment #6 from Katrin Fischer  ---
(In reply to Barbara Johnson from comment #5)
> In the 5th step, when I click on Receive I'm getting the error - "Template
> process failed: undef error - The method Koha::Item->size is not covered by
> tests!" which is followed by lots of details about the error.

Hi Barbara, I wonder if this is related to the patch as I haven't touched the
receive process, only the basket summary page. If you can, could you repeat the
tests with out the patch?

Did you create items on order?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26526] Use of checkout notes not clear in OPAC

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26526

--- Comment #7 from Barbara Johnson  ---
Worked great!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26526] Use of checkout notes not clear in OPAC

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26526

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #111944|0   |1
is obsolete||

--- Comment #6 from ByWater Sandboxes  ---
Created attachment 111950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111950=edit
Bug 26526: Relabel checkout note column in OPAC

When checkout notes are active, there is currently a new
column labelled 'Note' in the checkouts table in OPAC.
When a note is added, this is sent to the library. For
the user it's not clear from the label, that these notes
are not personal, but for reporting to the library.
The new label "Report a problem" aims to make this clearer.

To test:
- Turn on AllowCheckoutNotes system preference
- Check out some items to your account
- Go to the OPAC
- Look at the list of checkouts
- Apply patch
- Reload the page and check the checkouts table again
- Verify the heading has changed from "Notes" to "Report a problem"
- Hover over the heading with your cursor to see some more info

Bonus: Patch adds an id "checkout-notes" to the header cell, that
will make it easier for libraries to change text or style if needed.

Signed-off-by: Barbara Johnson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26728] New: Lifted restrictions will only show on checkouts but not on details tab

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26728

Bug ID: 26728
   Summary: Lifted restrictions will only show on checkouts but
not on details tab
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To test:
- Add several restrictions with dates in the past
- Verify they show when editing the patron
- Verify they show on checkouts tab > Restrictions
- Verify they DON'T show on the details tab > Restrictions

I initially started testing this because of bug 26053 which is asking for
having a clear visual distinction between active and inactive (date in the
past) restrictions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26053] Adding more details to the manual about Patron Restrictions

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26728

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26728] Lifted restrictions will only show on checkouts but not on details tab

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26728

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26053

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26680] Update (rcvd) to (received) with its own class in basket view

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26680

--- Comment #5 from Barbara Johnson  ---
In the 5th step, when I click on Receive I'm getting the error - "Template
process failed: undef error - The method Koha::Item->size is not covered by
tests!" which is followed by lots of details about the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26053] Adding more details to the manual about Patron Restrictions

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053

Katrin Fischer  changed:

   What|Removed |Added

  Component|Patrons |Documentation

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26718] Change 'Your reading history" to "Your checkout history"

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26718

--- Comment #8 from Katrin Fischer  ---
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26718] Change 'Your reading history" to "Your checkout history"

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26718

Barbara Johnson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from Barbara Johnson  ---
Katrin, thanks for clarifying that.  So it all works as expected and I’ve
signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26718] Change 'Your reading history" to "Your checkout history"

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26718

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #111942|0   |1
is obsolete||

--- Comment #6 from ByWater Sandboxes  ---
Created attachment 111949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111949=edit
Bug 26718: Rename "reading history" to "checkout history"

This changes all occurences of reading history to the more
accurate term 'checokut history' as it was correctly pointed out
that 'reading' doesn't apply to all kind of items available
at the library (audio books, games, etc.)

To test:
- Verify that the term reding history has been replaced by checkout
  history in:
  - System preferences
  - OPAC tab "your checkout history"
  - OPAC tab "your privacy" (switch OpacPrivacy pref first)
  - Staff permission for patron batch anonymization

Signed-off-by: Barbara Johnson  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26718] Change 'Your reading history" to "Your checkout history"

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26718

--- Comment #5 from Katrin Fischer  ---
Hi Barbara, thx for testing. I didn't rename the preferences, only changed the
description texts and labels in the GUI. Renaming the prefs would require more
work and they are only visible to system librarians, so hope I can get away
with that :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26718] Change 'Your reading history" to "Your checkout history"

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26718

--- Comment #4 from Barbara Johnson  ---
Everything worked for me except the change for the system preferences.  They
still display as opacreadinghistory and intranetreadinghistory.  Also still
displays opacreadinghistory in the description for the StoreLastBorrower system
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

--- Comment #7 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #5)
> We usually have a "Show inactive" checkbox right after the dropdown list.
> Should not we implement that here as well?

I Believe that would probably be the most consistent solution in regard to the
rest of the GUI. 

But I think we should fix this with some urgency as the list of funds can get
pretty confusing for libraries with several years of acq data right now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23301] Borrower messaging preferences lost when duplicating patron and changing category

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23301

--- Comment #2 from Katrin Fischer  ---
Hm, I think me might not get a clear vote here on if that is intended behaviour
or not. I would have expected the messaging defaults to reset when resetting
the category, while you expect it to remain unchanged.

I am not sure how we could deal with this the best way. Should we have a pop-up
asking about resetting the messaging preferences when the category is changed
so it can be decided on an individual basis?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17976] TT syntax for notices - Add an equivalence for items.fine

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976

--- Comment #2 from Katrin Fischer  ---

[% checkout.overdue_fine.amount | $Price %] would work for me - I imagine
overdue_fine could be used to pull other values from the account line?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26727

--- Comment #40 from Katrin Fischer  ---
(In reply to David Cook from comment #39)
...
> I think that  might be valid XHTML but I'm quite certain that is not
> valid HTML/HTML5 though.

I've filed a separate bug 26727 for this and fixed all occurences I found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21311

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21811] Add warning when order receive form is saved without entering 'quantity received'

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21811] Add warning when order receive form is saved without entering 'quantity received'

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #4 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #3)
> Before this patch we were able to save, and (reading the code) some info
> were used to update the items' order (like price, datelastseen, etc.)
> 
> What is the expected behaviour here?

I am not sure if that behaviour (changing the items when nothing was actually
received) was correct at all. I cannot think of a use case right now where
you'd want that at this point. I think this should not block this patch.

Patch still applied - resetting status in hope to get some more feedback next
week from people testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21820] Zebraqueue should not be added to when only Elasticsearch is used

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820

--- Comment #4 from Katrin Fischer  ---
I think a new option to the existing or a new pref would both work and be about
the same amount of trouble :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21883] Show authorized value description for withdrawn in check-in

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21883

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #9 from Katrin Fischer  ---
Was checkign this one for Academy, but doesn't apply right now (see also
previous comment from David)

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 21883: Pass the item to the template
Applying: Bug 21883: AddShow authorized value description for withdrawn in
check-in
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 21883: AddShow authorized value description for
withdrawn in check-in
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-21883-AddShow-authorized-value-description-for-SKAaMC.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2280] Authorized value option for indicators doesn't work

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2280

--- Comment #14 from Katrin Fischer  ---
I think we should remove the non-functional option of authorised values on the
tag configuration page and start fresh if we wanted to add default values for
first and second indicators as a separate feature bug.

But there is quite a lot to be done after taking a look:

- Remove from the GUI
- Remove from the methods taking care up updating and adding fields
- Remove the database column
- Remove from the all the installer files for MARC frameworks

The last one I am not sure how to tackle - but if not done, the installer would
be broken. Would be happy to get some help there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21884] Writeoff "amount" changed from positive values to negative values.

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21884

--- Comment #5 from Katrin Fischer  ---
I believe if the database updates haven't taken care of it, there is no
official fix and this might need some work locally :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

--- Comment #1 from Katrin Fischer  ---
Created attachment 111948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111948=edit
Bug 26727: Fix  appearing in the templates

The self-closing p is not valid in HTML5:

Error: Self-closing syntax (/>) used on a non-void HTML element.
Ignoring the slash and treating as a start tag.

To test:

1)
- Activate Article requests
- Search for a record to place an article request on in staff
- Look up the patron
- Verify the article request form looks ok
2)
- Search for a list of patrons
- Check 2 patrons and merge them using the button above the list
- Verify the distance between the button and the table looks ok
3)
- Create a new MARC modification template
- Create a new action
- Verify the distances between the first and second line of form
  elements looks ok
4)
- Place a hold in staff
- Click on the Suspend link in the holds table (not below)
- Verify the modal looks ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] Fix appearing in the templates

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26727] New: Fix appearing in the templates

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26727

Bug ID: 26727
   Summary: Fix  appearing in the templates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

They don't appear to be valid in HTML5 and in some cases were actually typos.

The HTML5 validator doesn't like them:

Error: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the
slash and treating as a start tag.

From line 581, column 25; to line 581, column 28

  

See:
https://www.w3.org/TR/2010/WD-html-markup-20100624/p.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20971] Corrupted storable string breaks SubfieldsToUseWhenPrefill functionality

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971

Katrin Fischer  changed:

   What|Removed |Added

Summary|additem Corrupted storable  |Corrupted storable string
   |string  |breaks
   ||SubfieldsToUseWhenPrefill
   ||functionality
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26726] New: Improve link text on Transport cost matrix page

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26726

Bug ID: 26726
   Summary: Improve link text on Transport cost matrix page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Blocks: 26722

When the UseTransportCostMatrix system preference is disabled, the blue box at
the top of Administration > Transport cost matrix contains a link labelled
"here" that should have a more meaningful link text (see bug 26722)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722
[Bug 26722] [Omnibus] Don't use "here" and similar as a link text
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26722] [Omnibus] Don't use "here" and similar as a link text

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||26726


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26726
[Bug 26726] Improve link text on Transport cost matrix page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26722] [Omnibus] Don't use "here" and similar as a link text

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||26725


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725
[Bug 26725] Improve link text on Patron attributes administration page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26725] New: Improve link text on Patron attributes administration page

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26725

Bug ID: 26725
   Summary: Improve link text on Patron attributes administration
page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Blocks: 26722

There is a link labelled "here" that should be improved on the patron
attributes page.

To test:
- Set ExtendedPatronAttributes system preference to "Don't enable"
- Go to Administration > Patron attribute types

The "here" link in the blue box at the top of the page should have a more
meaningful link text.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722
[Bug 26722] [Omnibus] Don't use "here" and similar as a link text
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01,
released in|19.11.11|19.11.11, 19.05.16

--- Comment #43 from Victor Grousset/tuxayo  ---
ok!

Backported to 19.05.x branch for 19.05.16

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26722] [Omnibus] Don't use "here" and similar as a link text

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||26724


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724
[Bug 26724] Improve link text for downloading the CSV file on patron import
page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26724] New: Improve link text for downloading the CSV file on patron import page

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724

Bug ID: 26724
   Summary: Improve link text for downloading the CSV file on
patron import page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Blocks: 26722

On Tools > Patron import there is a link labelled "here" on the right side that
should be improved (see depending bug 26722).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722
[Bug 26722] [Omnibus] Don't use "here" and similar as a link text
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26723] Improve link text on OverDriveAuthName system preference

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||26722


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722
[Bug 26722] [Omnibus] Don't use "here" and similar as a link text
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26723] Improve link text on OverDriveAuthName system preference

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26722] [Omnibus] Don't use "here" and similar as a link text

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |minor
 Blocks|26723   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723
[Bug 26723] Improve link text on OverDriveAuthName system preference
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26722] [Omnibus] Don't use "here" and similar as a link text

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||26723


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723
[Bug 26723] Improve link text on OverDriveAuthName system preference
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26722] [Omnibus] Don't use "here" and similar as a link text

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||26723


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723
[Bug 26723] Improve link text on OverDriveAuthName system preference
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26723] Improve link text on OverDriveAuthName system preference

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|26722   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722
[Bug 26722] [Omnibus] Don't use "here" and similar as a link text
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26723] New: Improve link text on OverDriveAuthName system preference

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26723

Bug ID: 26723
   Summary: Improve link text on OverDriveAuthName system
preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 26722

The OverDriveAuthName system preference contains a link labelled "here" to a
separate administration page that should be labelled better.

(see depending bug 26722)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722
[Bug 26722] [Omnibus] Don't use "here" and similar as a link text
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26722] New: [Omnibus] Don't use "here" and similar as a link text

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722

Bug ID: 26722
   Summary: [Omnibus] Don't use "here" and similar as a link text
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

"Here" should not be used as a link text as it doesn't contain any helpful
information for people scanning the page for information and also is a problem
for blind users using screen readers jumping from link to link on a page.

2.4.4 Link Purpose (In Context): The purpose of each link can be determined
from the link text alone or from the link text together with its
programmatically determined link context, except where the purpose of the link
would be ambiguous to users in general. (Level A) 
https://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-refs.html

There are plenty of other resources with examples too:
https://www.w3.org/QA/Tips/noClickHere
https://www.washington.edu/accessibility/links/
https://webaim.org/techniques/hypertext/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26721] Debit and credit type pages should check for the specific permission

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26721

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Keywords||Academy
   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26721] Debit and credit type pages should check for the specific permission

2020-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26721

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >