[Koha-bugs] [Bug 27345] C4::Auth::get_template_and_user is missing some permissions for superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27345 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > I think maybe the refactor could go onto a separate bug? We will want to > keep this small and easy for easy backport with little risk. I figured we'd have to test to the same degree in both cases so thought refactoring would be more efficient here but no worries if not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #7 from David Cook --- It's worth noting that I've used a different model in the patch than what I described in the description. In this case, I'm using the existing Debian Koha indexer infrastructure. The only difference is with the Zebra Indexer daemon that runs. So each Koha instance will still get its own dedicated indexer daemon. The difference is that the indexer daemon will use 6MB of RAM instead of 170-180MB of RAM. If you scale up to 50 Koha libraries on a server, that's 300MB used instead of 9GB for an idle indexer daemon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #6 from David Cook --- Created attachment 114884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114884=edit Bug 27267: Add memory efficient Zebra indexing daemon This patch adds an alternate Zebra indexing daemon which is much more memory efficient than the current default daemon. (For instance, zebra_indexer.pl uses 6MB of RAM vs rebuild_zebra.pl which uses about 180MB of RAM out of the box while idle.) To test: 0. Apply patch 1. koha-indexer --stop kohadev 2. vi /etc/default/koha-common 3. Update ALTERNATE_INDEXER_DAEMON to be "/kohadevbox/koha/misc/zebra_indexer.pl" 4. koha-indexer --start kohadev 5. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 6. Change 245$a to "Gone" instead of "Gairm" and save the record 7. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=Gairm 8. Repeat Step 7 for 5+ seconds until your search returns no results 9. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 10. Change 245$a from "Gone" to "Gairm" 11. Repeat Step 7 for 5+ seconds until your search redirects you to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29=1 To confirm lower memory usage: 12. ps -efww | grep "zebra_indexer" 13. top -p 14. The top tool should show about 6.1MB usage. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27348] New: Error defining INDEXER_PARAMS in /etc/default/koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27348 Bug ID: 27348 Summary: Error defining INDEXER_PARAMS in /etc/default/koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au The test at line 220 in koha-indexer creates an error since it isn't treating $INDEXER_PARAMS as a string. For example: /usr/sbin/koha-indexer: line 220: [: -sleep: binary operator expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27345] C4::Auth::get_template_and_user is missing some permissions for superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27345 --- Comment #3 from Katrin Fischer --- I think maybe the refactor could go onto a separate bug? We will want to keep this small and easy for easy backport with little risk. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27099] Stage for import button not showing up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #3 from David Cook --- This looks like it will be tough to test although I think it's worth doing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27345] C4::Auth::get_template_and_user is missing some permissions for superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27345 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- This could actually be a good opportunity to do some refactoring... If you go to https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=26791=113660 and click "Auth.pm", you'll see a function called "get_authz_from_flags". That could be further optimized by fetching the permissions from userflags (as you note) to dynamically make sure that the superlibrarian has all the right permissions. By the way, if we refactor it along the lines of what I've done on Bug 26791, we could add unit tests too. Originally I wanted to refactor C4::Auth::get_template_and_user, but I figured there was no hope doing it alone. But if you're interested in proving it, I'm happy to work with you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27343] Use L1 cache for get_all_subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27343 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- What do you mean by every hit? It seems to me that it's basically called for every request, but we clear the L1 cache for every request anyway, so I'm not sure this patch would change anything? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27337] Remove direct use of CGI::Cookie
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27337 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- (In reply to Jonathan Druart from comment #2) > This patch will be a nightmare to test... Agreed. Perhaps it's better to use this as a omnibus bug and do the changes in separate bugs with specific test plans for those pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What|Removed |Added Blocks|13751 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 [Bug 13751] "Begins with" search not possible with ICU indexing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 David Cook changed: What|Removed |Added Depends on|27299 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #12 from David Cook --- *** Bug 13751 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 David Cook changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #20 from David Cook --- *** This bug has been marked as a duplicate of bug 27299 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13751] "Begins with" search not possible with ICU indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13751 --- Comment #19 from David Cook --- (In reply to Katrin Fischer from comment #18) > > That's good to know and I am actually very happy to see it and some other > old glitches resolved! > > Shoudl we close this MOVED or duplicate? When I commented last night I > didn't realize that I was the original bug author - it's been a while :) I was also thinking about marking it as duplicate, so I'll go ahead and do that. Yeah, it's been around a long time! We tend to use CHR but we have a library with ICU with some very observant librarians who helped me to unravel this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27347] Allow automatic item modification by age to match NULL values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27347 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27305] iCal feed for circulation issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 --- Comment #11 from David Cook --- (In reply to Nico Bako from comment #10) > Yeah, that's me. The website is still very much a work in progress... so no > judging please. This is also my website too: > > https://nicobako.pythonanywhere.com/ > > which is also very much a work in progress. I'm pretty new to web > development stuff, and do nearly all of my programming in Python. We all were new at some point! I started off with PHP and now I write whatever I need/want to write. Once you're familiar with one language, it becomes pretty easy to learn another. > > Haha, yeah, I guess I could... I'm not going to make any promises of > contributing to Koha (my life, just like most people's, is pretty busy...), > but I will take a look at those documents and see where the wind takes me. > Also, just like most people, I'm better at complaining about bugs/features > than fixing them... > > I do really appreciate the quick responses. I will definitely take a look at > those links and see if contributing to Koha is something that both peeks my > interests as a programmer and would fit into my schedule. Sounds good to me. I figured that I'd give you the opportunity to take a look at it. I'll get in touch with folks to see if anyone else wants to work on it too. I already have a number of things I'm working on, but I do find the idea interesting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27347] Allow automatic item modification by age to match NULL values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27347 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #1 from George Williams (NEKLS) --- Being able to set a condition to match on a null value would be a very helpful enhancement to this tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27347] New: Allow automatic item modification by age to match NULL values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27347 Bug ID: 27347 Summary: Allow automatic item modification by age to match NULL values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Automatic item modification by age isn't able to match on a null value, so we can't set a rule for something like "all items more than 60 days old that don't have any collection code." That'd be handy. Looks like bug 18752 made it so we could set a blank as our substitution value, but doesn't help on the match value. The issue may be that Koha ends up looking for an empty string rather than for a null. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18752] Automatic item modifications by age should allow 'blank' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18752 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27347 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #57 from Victor Grousset/tuxayo --- There is no dependency on bug 27331 right? It's related but the two bugs address different issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 --- Comment #25 from Tomás Cohen Arazi --- Remote branch updated. Some things need fixing, help welcome. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #10 from Lisette Scheer --- (In reply to Victor Grousset/tuxayo from comment #9) > What would be the test plan? > > Here is a try: > 1) In library groups add a root group and check it as hold group. > 2) Add two libraries to the group > 3) In circulation and fines rules, in 'Default checkout, hold and return > policy', in Hold policy change the value to 'From local hold group' > 4) Place a hold from a patron whose home library is from the group 5) Go to /cgi-bin/koha/circ/view_holdsqueue.pl 6) Select the holding branch of the item with a hold 7) observe no results 8) Apply Patch 9) Repeat 5-6 10) The item should come up on the holds queue results 11) Place a hold on an item where 1 record has 2 copies, 1 in the hold group, 1 not. 12) Run the HoldQueue for the library not in the group and make sure the hold isn't showing. 13) Turn on transportation cost matrix and set costs for the libraries within the group. 14) Place a hold for a patron where multiple copies are on the bib. 15) Check both branch's hold queue for the item, it should only show on the lower cost branch's list if both copies are available. Agustin or Kyle could probably tell us if there are any steps missing in there. These are steps I wrote based on experience with the problem at hand and looking at the diff for the patches. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||and...@bywatersolutions.com
Status|Needs Signoff |Failed QA
--- Comment #15 from Andrew Fuerste-Henry ---
Small issue: it'd be nice to be able to delete more than one quote at a time.
Maybe checkboxes to select multiple and delete them all?
Larger issue:
- perform a search that returns just one quote ("bear" works)
- delete that quote
- your search is now filtering to zero results
- click "clear filter," observe you're still shown zero results
That said, thanks for writing this patch! This interface is frustratingly buggy
and nonstandard as-is.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in|| CC||and...@bywatersolutions.com --- Comment #14 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27305] iCal feed for circulation issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 --- Comment #10 from Nico Bako --- > Actually, Nico, I assume that the following is your website? > > https://nicobako.github.io/ Yeah, that's me. The website is still very much a work in progress... so no judging please. This is also my website too: https://nicobako.pythonanywhere.com/ which is also very much a work in progress. I'm pretty new to web development stuff, and do nearly all of my programming in Python. > In other words, you could always work on this feature yourself. I'd be happy > to review and test it. Haha, yeah, I guess I could... I'm not going to make any promises of contributing to Koha (my life, just like most people's, is pretty busy...), but I will take a look at those documents and see where the wind takes me. Also, just like most people, I'm better at complaining about bugs/features than fixing them... I do really appreciate the quick responses. I will definitely take a look at those links and see if contributing to Koha is something that both peeks my interests as a programmer and would fit into my schedule. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Martha Fuerst changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9598] Ability to split up shipping cost between all items and funds on an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9598 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- Maybe it needs a more detailed behavior description. Does is need to list the used funds and allow setting percentages? Maybe it could allow choosing other funds? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27337] Remove direct use of CGI::Cookie
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27337 --- Comment #2 from Jonathan Druart --- This patch will be a nightmare to test... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27337] Remove direct use of CGI::Cookie
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27337 --- Comment #1 from Jonathan Druart --- Created attachment 114883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114883=edit Bug 27337: Remove direct use of CGI::Cookie There is only 1 occurrence where there is an explanation about the direct use of CGI::Cookie, in tools/upload-file.pl The others don't seem relevant -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26273] Expose cashup summary history for a cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk --- Comment #1 from Sally --- This sounds like a great idea. My instinct would be to also have an index - perhaps where each linked summary is labelled with the cash up date? A bit like this: 05-01-2021 || Link to summary 01-01-2021 || Link to summary 22-12-2020 || Link to summary 15-12-2020 || Link to summary 08-12-2020 || Link to summary 01-12-2020 || Link to summary 29-11-2020 || Link to summary 26-11-2020 || Link to summary 13-11-2020 || Link to summary 04-11-2020 || Link to summary We tend to seek out previous cash ups when there's a problem, so being able to quickly view an index of that till's cash ups to find the correct session would be great. If we had 2-3 cash ups a week and we wanted to go back 6 months, just prev/next controls would be a little frustrating. Or, if it's not too much work, a data table would do the job - then we could always use the search / sort controls? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 114882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114882=edit [20.05 and earlier] Bug 27252: Default to cross fields off Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 114881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114881=edit [20.05 and earlier] Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Tomás Cohen Arazi changed: What|Removed |Added Attachment #114673|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27346] C4::XISBN warning on hash
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27346 Fridolin Somers changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27346] New: C4::XISBN warning on hash
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27346
Bug ID: 27346
Summary: C4::XISBN warning on hash
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs@lists.koha-community.org
Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
When using ThingISBN alone you get a warning :
Failed Can't use string ("1") as a HASH ref while "strict refs" in use at
/home/koha/src/C4/XISBN.pm line 99.
sub get_xisbns {
my ( $isbn, $biblionumber ) = @_;
my ($response,$thing_response,$syndetics_response,$errors);
...
$response->{isbn} = [ @{ $syndetics_response->{isbn} or [] }, @{
$thing_response->{isbn} or [] } ];
Vars $thing_response,$syndetics_response must be initialised as an hashref.
Or maybe rewrite a bit this code.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26272] Allow cashup summaries to be displayed from the library summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24491] Add filters to debit types interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27341] Performance 21.05 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 --- Comment #3 from Jonathan Druart --- I've run some benchmarks using the basic_workflow.t's selenium test, following the same scripts and protocol as https://wiki.koha-community.org/wiki/Benchmark_for_16.11 Script's adjustments (to use KTD instead of KohaDevBox) and results can be found at https://gitlab.com/joubu/koha-misc4dev/-/commits/benchmark_16.11-20.11 The 2 main graphs are attached to this bug report. We clearly see a worrying increase of the time execution between 19.05 and 19.11. I have first focussed on checkin, do some profiling and came to the conclusion that it was caused by ES not updating its index async. A first step has been submitted on bug 27344. Early feedbacks and comments welcomed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27341] Performance 21.05 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 --- Comment #2 from Jonathan Druart --- Created attachment 114880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114880=edit perfs_20.11_cp -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27341] Performance 21.05 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 --- Comment #1 from Jonathan Druart --- Created attachment 114879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114879=edit perfs_20.11_versions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 114878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114878=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Tomás Cohen Arazi changed: What|Removed |Added Attachment #114672|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 --- Comment #1 from Jonathan Druart --- Created attachment 114877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114877=edit Bug 27344: Implement Elastic's update_index_background using Koha::BackgroundJob This patch adds a background job submodule, UpdateElasticIndex, to deal with async ES index update (not the deletion). Using NYTProf (on a checkin): Without 618ms, executing 35676 statements and 26355 subroutine calls in 266 source files and 83 string evals. With 521ms, executing 13282 statements and 7979 subroutine calls in 195 source files and 26 string evals. However there are some problems with this patch: 1. We don't want *all* the index update to be in the background_jobs table (we could add a filter on the list view) 2. We don't track the "progress" of the job as we are sending all the records to Elastic. It is okish in my opinion but it must be noted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #56 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #11 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #10) > (In reply to Joonas Kylmälä from comment #9) > > We show 10 biblios on the pendingreserves.pl page so I don't see any major > > performance issues coming in this case. > > Are you sure about that? IIRC only 10 are shown by DataTables, but all are > loaded. It probably is how you say, but it is not an issue, just have to fix the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27331] fr-FR/1-Obligatoire/authorised_values.sql is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27331 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry --- Missing dependencies for 20.05, not backporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27343] Use L1 cache for get_all_subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27343 --- Comment #1 from Jonathan Druart --- Created attachment 114876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114876=edit Bug 27343: Cache get_all_subpermissions return The permissions are fetched for every hit, we should cache them in L1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #2 from Jonathan Druart --- Created attachment 114875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114875=edit Bug 27342: Remove dbh from C4::Auth We must not pass $dbh but retrieve it when needed instead -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #1 from Jonathan Druart --- Created attachment 114874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114874=edit Bug 27342: Improve test for OPAC We don't need to build allowed_scripts_for_private_opac for staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27345] C4::Auth::get_template_and_user is missing some permissions for superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27345 --- Comment #1 from Jonathan Druart --- Created attachment 114873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114873=edit Bug 27345: Add missing global permissions for superlibrarian When a superlibrarian is logged in, C4::Auth::get_template_and_user pass the CAN_user_$flag to the template, but some are missing: suggestions, lists, cash_management So far they are not used in the template but it will avoid a developer to spend time on it if we fix it now. Test plan: Compare with installer/data/mysql/mandatory/userflags.sql Note that we don't need selfcheck -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27345] C4::Auth::get_template_and_user is missing some permissions for superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27345 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27345] New: C4::Auth::get_template_and_user is missing some permissions for superlibrarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27345 Bug ID: 27345 Summary: C4::Auth::get_template_and_user is missing some permissions for superlibrarian Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org When a superlibrarian is logged in, C4::Auth::get_template_and_user pass the CAN_user_$flag to the template, but some are missing: suggestions, lists, cash_management So far they are not used in the template but it will avoid a developer to spend time on it if we fix it now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Martha Fuerst changed: What|Removed |Added CC||mfue...@hmcpl.org --- Comment #2 from Martha Fuerst --- This adds an extra step to the process, and generally is just a pain (as well as making us look silly with what it thinks are potential duplicates). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27341] Performance 21.05 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 Jonathan Druart changed: What|Removed |Added Depends on||27344 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27344] New: Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 Bug ID: 27344 Summary: Implement Elastic's update_index_background using Koha::BackgroundJob Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Blocks: 27341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 [Bug 27341] Performance 21.05 - Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27341] Performance 21.05 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 Jonathan Druart changed: What|Removed |Added Depends on||27343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27343 [Bug 27343] Use L1 cache for get_all_subpermissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27343] New: Use L1 cache for get_all_subpermissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27343 Bug ID: 27343 Summary: Use L1 cache for get_all_subpermissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Blocks: 27341 The permissions are fetched for every hit, we should cache them in L1. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 [Bug 27341] Performance 21.05 - Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in|| --- Comment #18 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26845] Refactor get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26845 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27342 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27341] Performance 21.05 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 Jonathan Druart changed: What|Removed |Added Depends on||27342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] New: Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Bug ID: 27342 Summary: Improve readability and improvement of C4::Auth::get_template_and_user Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Blocks: 27341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 [Bug 27341] Performance 21.05 - Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17819] Performance 16.11 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27341 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27341 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27341 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27341] New: Performance 21.05 - Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27341 Bug ID: 27341 Summary: Performance 21.05 - Omnibus Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #13 from Jonathan Druart --- Last patch pushed to master for 21.05.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #12 from Victor Grousset/tuxayo --- Created attachment 114872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114872=edit Bug 26847: (follow-up) fix get_attribute() call Since the upgrade to Selenium 3 in bug 27055, an additional parameter is required for get_attribute() to actually work. https://metacpan.org/pod/Selenium::Remote::WebElement#get_attribute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27340] We should introduce Koha::PickupLocation(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27340 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Status|NEW |In Discussion --- Comment #1 from Tomás Cohen Arazi --- I assign it to Martin to have his thoughts and discuss this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27340] New: We should introduce Koha::PickupLocation(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27340 Bug ID: 27340 Summary: We should introduce Koha::PickupLocation(s) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org Looking at the codebase, a pickup location is a combination of a branch/library, and now also a 'desk'. So it would make sense to have a special class for them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 Tomás Cohen Arazi changed: What|Removed |Added Version|master |20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 114871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114871=edit [20.05.x] Bug 25826: fix failing test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 114870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114870=edit [20.05.x] Bug 25826: (QA follow-up) Add filters Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 114869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114869=edit [20.05.x] Bug 25826: Forbid changing the hidden attributes for biblionumber This patch tweaks the UI so it forbids changing the hidden values when they are correct (i.e. when they are not hidden in OPAC and intranet). To test: 1. Apply the first patch 2. Play with the hidden values of the subfield you have mapped to biblio.biblionumber in your picked framework. This is usually 999$c in MARC21, and 001 in UNIMARC. => SUCCESS: When you verify the about.pl, it mentions issues when you hide in some of the interfaces 3. Apply this patch and reload everything 4. Repeat 2 => SUCCESS: If your framework is 'ok', it prevents you from editing this values, otherwise you can change them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25826] Hiding biblionumber in the frameworks breaks links in result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25826 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 114868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114868=edit [20.05.x] Bug 25826: Add a warning to the about page This patch adds a warning to the about page if the biblionumber field is hidden at the OPAC or staff interface. Test plan: Hide the biblionumber to some framework Confirm that there is a warning on the about page Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27015] Add filtering options to the pickup_locations routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27015 Tomás Cohen Arazi changed: What|Removed |Added QA Contact||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27034] $c->objects->search shouldn't use path parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034
--- Comment #5 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #3)
> Patch "Bug 27015: Make pickup locations searchable" is going to add a FIXME
> about this.
>
> This patch must remove it then.
>
> +++ b/Koha/REST/V1/Holds.pm
> @@ -445,6 +445,8 @@ sub pickup_locations {
> my $c = shift->openapi->valid_input or return;
>
> my $hold_id = $c->validation->param('hold_id');
> +# FIXME: We should really skip the path params in $c->objects->search
> +delete $c->validation->output->{hold_id};
Thanks for taking the time to review at this point!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added Text to go in the||This development changes release notes||how the orders table on ||receiving in acquisitions ||is rendered. ||Before this ||patches all active orders ||data was fetched from the ||database, along with all ||the related data (patrons, ||biblio). This lead to ||significant delays because ||all orders matching the ||filtering criteria were ||loaded, even when only 20 ||rows are displayed on the ||UI. ||With this patch, the ||table is rendering using ||server-side pagination, ||provided by the REST API. ||This means ||(1) only the ||information to be rendered ||is fetched (faster drawing ||(2) the page doesn't reload ||anymore when a new filter ||is added: it just refreshes ||the table, very fastly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #102 from Andrew Isherwood --- Hi Jonathan Thanks for that. I've rebased as I was getting conflicts on a couple of commits. > acqui/addorder.pl is logging a MODIFY_BASKET, is that expected? I believe so. addorder processes the submission from the "New order" form when adding an order to a basket, so logging the basket modification makes sense here I think. > Why are you adding borrowernumber? That was a hangover from when ModBasket was explicitly logging the borrower. This was highlighted as unnecessary duplication, so I removed it from the logging in the patch titled "Bug 23971: (follow-up) Remove data duplication", but missed removing it from the ModBasket call. I've now created a new commit that removes it, thanks for highlighting it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #101 from Andrew Isherwood --- Created attachment 114867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114867=edit Bug 23971: (follow-up) Remove stale param As highlighted by Jonathan in comment #90, we were passing borrowernumber to ModBasket. This was a hangover from when we explicitly logged the borrower, which was later discovered to be unnecessary duplication, and was removed in commit "Remove data duplication". This commit removes this unnecessary parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113393|0 |1 is obsolete|| --- Comment #100 from Andrew Isherwood --- Created attachment 114866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114866=edit Bug 23971: (follow-up) Log entire objects As requested by Tomás and Jonathan, we now log the entire basket object when logging an action. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113392|0 |1 is obsolete|| --- Comment #99 from Andrew Isherwood --- Created attachment 114865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114865=edit Bug 23971: (QA follow-up) New DBrev syntax Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113391|0 |1 is obsolete|| --- Comment #98 from Andrew Isherwood --- Created attachment 114864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114864=edit Bug 23971: (follow-up) Make changes for 26582 This commit makes changes necessary to allow this bug to be dependent on Bug 23562: - Move basket closure logging from C4::Acquisision::CloseBasket to Koha::Acquisition::Basket::close - Move basket closure unit test from t/db_dependent/Acquisition.t to t/db_dependent/Koha/Acquisition/Basket.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113390|0 |1 is obsolete|| --- Comment #97 from Andrew Isherwood --- Created attachment 114863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114863=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113389|0 |1 is obsolete|| --- Comment #96 from Andrew Isherwood --- Created attachment 114862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114862=edit Bug 23971: (follow-up) Respond to feedback As requested by Jonathan in commit #28: - We now no longer pass a flag to CloseBasket indicating if the closure was due to an EDI basket approval, we log the closure and approval as separate events. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113388|0 |1 is obsolete|| --- Comment #95 from Andrew Isherwood --- Created attachment 114861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114861=edit Bug 23971: (follow-up) Add unit tests This commit adds unit tests for the logging done in Acquisitions.pm Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113387|0 |1 is obsolete|| --- Comment #94 from Andrew Isherwood --- Created attachment 114860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114860=edit Bug 23971: (QA follow-up) Fix punctuation, doubled up return and syspref order Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113386|0 |1 is obsolete|| --- Comment #93 from Andrew Isherwood --- Created attachment 114859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114859=edit Bug 23971: (follow-up) Add additional basket logging This patch adds additional basket logging as discussed in comment #14 - Basket reopening - Basket users (manager) modification - Basket header modification Signed-off-by: Holly Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113385|0 |1 is obsolete|| --- Comment #92 from Andrew Isherwood --- Created attachment 114858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114858=edit Bug 23971: (follow-up) Remove data duplication In response to Séverine observations in comment #10, this patch removes the duplicate logging of the borrowernumber https://bugs.koha-community.org/show_bug.cgi?id=23971 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood changed: What|Removed |Added Attachment #113384|0 |1 is obsolete|| --- Comment #91 from Andrew Isherwood --- Created attachment 114857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114857=edit Bug 23971: Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27049] Add a script to bulk writeoff debts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27049 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27339] Display opac notes and opac messages on check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27339 --- Comment #1 from Didier Gautheron --- Created attachment 114856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114856=edit Bug 27339: Display opac notes and opac messages on check-in . Adds Opac note (borrowers.opacnote) and Opac messages (messages table) during check-in. Test plan: 1- Add an Opac note and one or several Opac messages to a patron. 2- Checkout and check-in an item for this patron. 3- Check that Opac note and Opac message(s) are not displayed on check-in. 4- Apply the patch. 5- Checkout and check-in an item for this patron. 6- Check that Opac note and Opac message(s) are displayed on check-in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
