[Koha-bugs] [Bug 25495] members-home.pl should allow search for exact borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25495 Michal Denar changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25265] Elasticsearch - Batch editing items on a biblio can lead to incorrect index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25265 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27534] koha upgrade throws SQL error while applying Bug 25333 - Change message transport type for Talking Tech from "phone" to "itiva"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27534 --- Comment #3 from Manos PETRIDIS --- I'm running mariadb 1:10.4.17+maria~stretch on Debian GNU/Linux 9.12 (stretch) with Linux 4.9.0-14-amd64 kernel. Pretty standard I understand. 'UPDATE message_transport_types SET message_transport_type = "asdf" WHERE message_transport_type = "email"' comes up with: 08:45:26 Kernel error: Error( 1451 ) 23000: "Cannot delete or update a parent row: a foreign key constraint fails (`koha_usmarc`.`letter`, CONSTRAINT `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`))" ...while 'SHOW CREATE TABLE letter' produces: INSERT INTO ``( `Table`, `Create Table` ) VALUES ( 'letter', 'CREATE TABLE `letter` ( `module` varchar(20) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT , `code` varchar(20) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT , `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT , `name` varchar(100) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT , `is_html` tinyint(1) DEFAULT 0, `title` varchar(200) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT , `content` mediumtext COLLATE utf8mb4_unicode_ci DEFAULT NULL, `message_transport_type` varchar(20) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT ''email'', `lang` varchar(25) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT ''default'', `updated_on` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp(), PRIMARY KEY (`module`,`code`,`branchcode`,`message_transport_type`,`lang`), KEY `message_transport_type_fk` (`message_transport_type`), CONSTRAINT `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci' ); When were these FK and CONSTRAINT introduced in the database? In my case, upgrade steps begun with 'Upgrade to 20.06.00.023', therefore I gather that they were not [both] present at 20.06.00.022. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #11 from David Cook --- *** Bug 27097 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27097] Make Koha version number and date of update more obvious in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27097 David Cook changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from David Cook --- *** This bug has been marked as a duplicate of bug 27497 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26048] PSGI Koha does not use custom ErrorDocument pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26048 David Cook changed: What|Removed |Added Text to go in the||This change allows PSGI release notes||(Plack) Koha to use the ||custom ErrorDocument pages ||that CGI Koha already uses. ||Without this change, a 500 ||error will show a white ||page with only "Internal ||server error" and a 404 ||will show a white page with ||only "not found". This ||change aligns the error ||reporting for the two ||different Koha web modes. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27540] Allow local definition of gender options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27540 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > (In reply to David Cook from comment #2) > > (In reply to Katrin Fischer from comment #1) > > > I think one reason was that the authorised values are still not > > > translatable > > > > Do we have a bug open for that? > > > > I imagine that the way to fix that would be to add a locale column? > > Initially we could default to English but build up support for passing in > > locales. > > bug 20307 Yikes bug 20307 and bug 24975 look a bit stuck. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 David Nind changed: What|Removed |Added Text to go in the||This patch adds a warning release notes||to the ||PatronSelfRegistrationDefau ||ltCategory system ||preference to not use a ||regular patron category for ||self registration. || ||If a ||regular patron category ||code is used and the ||cleanup_database cronjob is ||setup ||to delete unverified ||and unfinished OPAC self ||registrations, it ||permanently and ||and ||unrecoverably deletes all ||patrons that have ||registered more than ||PatronSelfRegistrationExpir ||eTemporaryAccountsDelay ||days ago. || ||It also removes ||unnecessary apostrophes at ||the end of two self ||registration ||and ||modification system ||preference descriptions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26298] If MaxItemsToProcessForBatchMod is set to 1000, the max is actually 999
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26298 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #1 from Donna --- While I can do a workaround by changing the syspref for MaxItemsToProcessForBatchMod to 1001, this seems a bit silly. The button in reports states "Batch with 1000 visible records" so that is what the behavior should be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27525] 'wich' instead of a 'with' in a sentence
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525 David Nind changed: What|Removed |Added Text to go in the||This patch fixes two release notes||spelling errors in the ||batchMod-del.tt template ||that is used by the batch ||item deletion tool in the ||staff interface: "wich" -> ||"with." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27446] Markup errors in suggestion/suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 David Nind changed: What|Removed |Added Text to go in the||This patch fixes several release notes||markup errors in the ||suggestions template in the ||staff interface, including: ||- Indentation ||- Unclosed ||tags ||- Non-unique IDs ||- ||Adding comments to ||highlight markup structure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10327] Rename poorly named system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Katrin Fischer changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27486] Rename system preference delimiter to CSVDelimiter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27486 Katrin Fischer changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Katrin Fischer changed: What|Removed |Added Depends on||27261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Katrin Fischer changed: What|Removed |Added Blocks||27321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 [Bug 27321] Make excluded database columns in system preferences more clearly disabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27493] Improve structure and style of checkbox columns in tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Katrin Fischer changed: What|Removed |Added Attachment #115754|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 115847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115847=edit Bug 27493: Add styling for hidden columns I'm sure adding a 'hidden' class to a table column used to remove it from display entirely.. seems that's no longer the case so we add the CSS back in here. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27493] Improve structure and style of checkbox columns in tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Katrin Fischer changed: What|Removed |Added Attachment #115734|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 115846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115846=edit Bug 27395: Add a warning to PatronSelfRegistrationDefaultCategory This patch adds a warning to the PatronSelfRegistrationDefaultCategory system preference to not use a regular patron category for self registration. If a regular patron category code is used and the cleanup_database cronjob is setup to delete unverified and unfinished OPAC self registrations, it permanently and and unrecoverably deletes all patrons that have registered more than PatronSelfRegistrationExpireTemporaryAccountsDelay days ago. It also removes unnecessary apostrophes at the end of two self registration and modification system preference descriptions. Test plan: 1. Apply the patch. 2. Check that the warning message for the PatronSelfRegistrationDefaultCategory system preference is clear and makes sense. 3. Sign off! Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27395] Add warning to PatronSelfRegistrationDefaultCategory to avoid accidental patron deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27395 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27531] Remove type attribute from script tags: Cataloging plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531 Katrin Fischer changed: What|Removed |Added Attachment #115714|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 115845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115845=edit Bug 27531: Remove type attribute from script tags: Cataloging plugins This patch removes the no-longer-valid "type" attribute from script tags found in cataloging plugin templates. I don't think testing each plugin individually is a reasonable thing to ask for a test. I think a visual verification of the changes in the patch should be enough. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27531] Remove type attribute from script tags: Cataloging plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27531 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27520] Adding new itemtype images boardgame, zoom-in, and zoom-out to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27520 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA Summary|Adding new itemtype images |Adding new itemtype images |to carredart|boardgame, zoom-in, and ||zoom-out to carredart --- Comment #8 from Katrin Fischer --- Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27521] Adding new itemtype headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer changed: What|Removed |Added Summary|Add new item type headset |Adding new itemtype headset |image for carredart |image for carredart --- Comment #7 from Katrin Fischer --- Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27523] Adding new itemtype lock image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27523 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #10 from Katrin Fischer --- Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #11 from Katrin Fischer --- Victoria, Aleisha or someone else - as these don't appear to belong to the original carredart item set (I believe this came from a library in Nimes - bug 5640)- where were these new icons taken from? Do we need to add any license information? I think it would be good to document the source here or in the commit message. As they don't perfectly fit the style, maybe we should put them on a separate tab? Sorry if I missed something! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer changed: What|Removed |Added Attachment #115750|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 115844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115844=edit Bug 27522: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer changed: What|Removed |Added Attachment #115749|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 115843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115843=edit Bug 27522: Adding new itemtype info image to carredart Test Plan 1. Go to Administration>Item Types>Modify Item Type 2. Under carredart you should see an info item type Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Adding new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer changed: What|Removed |Added Attachment #115752|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 115842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115842=edit Bug 27505: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27505] Add new itemtype controller image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27505 Katrin Fischer changed: What|Removed |Added Summary|Add new item type |Add new itemtype controller |controller image for|image for carredart |carredart | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27446] Markup errors in suggestion/suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 --- Comment #5 from Katrin Fischer --- Created attachment 115841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115841=edit Bug 27446: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27446] Markup errors in suggestion/suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Katrin Fischer changed: What|Removed |Added Attachment #115792|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 115840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115840=edit Bug 27446: Markup errors in suggestion/suggestion.tt This patch makes various corrections to the suggestions template in the staff interface: - Correct indentation - Fix unclosed tags - Fix non-unique IDs - Add comments to highlight markup structure To test, apply the patch and test the suggestions interface in the staff client: - Viewing the list of suggestions - Viewing the details of a single suggestion - Filtering suggestions - Organizing suggestions Test that labels on form controls work correctly, including under each tab. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27446] Markup errors in suggestion/suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27547] Typo in parcel.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27547 Katrin Fischer changed: What|Removed |Added Attachment #115793|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 115839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115839=edit Bug 27547: Typo in parcel.tt Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27547] Typo in parcel.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27547 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27543] Tooltip on opac-messaging.pl obscured by table headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27543 Katrin Fischer changed: What|Removed |Added Attachment #115762|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 115838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115838=edit Bug 27543: Tooltip on opac-messaging.pl obscured by table headers This patch corrects which Bootstrap assets are compiled with the OPAC CSS -- The file for Bootstrap tooltips should be included. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). 1) Log into the OPAC. 2) Go to 'your messaging' (opac-messaging.pl). 3) Hover over the Digests only tooltip. 4) Note that the tooltip looks correct. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27543] Tooltip on opac-messaging.pl obscured by table headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27543 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27525] 'wich' instead of a 'with' in a sentence
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525 Katrin Fischer changed: What|Removed |Added Attachment #115735|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 115837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115837=edit Bug 27525: Replace "wich" with "with" in batch delete template This patch corrects two typos: "wich" -> "with." To test, apply the patch and check the batch delete template (batchMod-del.tt) and confirm that the two instances of this sentence are correct: "Last item for bibliographic record with biblio-level hold on it" Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27525] 'wich' instead of a 'with' in a sentence
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929 Blou changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com Patch complexity|--- |Small patch --- Comment #9 from Blou --- I coded that fix in 20.05 and rebased it for master. It's clean, but it's not "nice" as it really duplicate the code from Shipment Fund. But the problem was serious for our customers so here's a solution that answers Jonathan's comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929 Blou changed: What|Removed |Added Attachment #97399|0 |1 is obsolete|| --- Comment #8 from Blou --- Created attachment 115836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115836=edit Bug 23929 - Invoice adjustments should filter inactive funds Looking at invoice details, this makes the Adjustments Fund dropdown act exactly like the Shipping Fund dropdown above, with a Show inactive checkbox to help filter (by default) the inactive funds out of the list. Test plan: 0) requires a database with inactive (old) funds along with active ones. 1) Go to invoice details page 2) Click "Add adjustment" 3) Open the drop down beside the Fund label, you should see EVERY fund in database. 4) Compare with behavior of Shipping fund dropdown above. Not every fund is listed there 5) Apply patch 6) Now behavior is the same, only active fund are listed by default. 7) click "Show inactive" checkbox and see all the funds in the dropdown. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23939] Title missing from Checked out box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23939
Blou changed:
What|Removed |Added
Attachment #115835|0 |1
is obsolete||
--- Comment #4 from Blou ---
Comment on attachment 115835
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115835
Bug 23939 - Invoice adjustments should filter inactive funds
>From 62ec8d38bdb5778ffc015344fb2d0274476bd1cb Mon Sep 17 00:00:00 2001
>From: Blou
>Date: Tue, 26 Jan 2021 15:36:31 -0500
>Subject: [PATCH] Bug 23939 - Invoice adjustments should filter inactive funds
>
>Looking at invoice details, this makes the Adjustments Fund dropdown act
>exactly like the Shipping Fund dropdown above, with a Show inactive
>checkbox to help filter (by default) the inactive funds out of the list.
>
>Test plan:
>0) requires a database with inactive (old) funds along with active ones.
>1) Go to invoice details page
>2) Click "Add adjustment"
>3) Open the drop down beside the Fund label, you should see EVERY fund in
>database.
>4) Compare with behavior of Shipping fund dropdown above. Not every fund is
>listed there
>5) Apply patch
>6) Now behavior is the same, only active fund are listed by default.
>7) click "Show inactive" checkbox and see all the funds in the dropdown.
>---
> .../prog/en/modules/acqui/invoice.tt | 26 ---
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>index 2348004cd6..6638449a4b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>@@ -278,13 +278,19 @@
>
> Fund:
>
>name="budget_id">
>- value="">No fund
>+ No fund
> [% FOREACH budget IN budgets %]
>-
>- [% budget.b_txt | html %]
>-
>+ [% IF ( budget.selected ) %]
>+ [% budget.b_txt | html %] [% IF (
>!budget.b_active ) %](inactive)[% END %]
>+ [% ELSIF ( budget.b_active ) %]
>+ [% budget.b_txt | html %]
>+ [% ELSE %]
>+ [% budget.b_txt | html %]
>(inactive)
>+ [% END %]
> [% END %]
>
>+ style="float:none;width:auto;">Show inactive:
>+ id="showallfunds_adj" />
>
>
> Encumber
> while invoice open?
>@@ -516,6 +522,18 @@
> $('.b_inactive').remove();
> }
> });
>+// same effort for the adjustments
>+var adjBudgetId = $("#budget_id_new");
>+var disabledAdjBudgetsCopy = adjBudgetId.html();
>+$('.ab_inactive').remove();
>+$('#showallfunds_adj').click(function() {
>+if ($(this).is(":checked")) {
>+adjBudgetId.html(disabledAdjBudgetsCopy); //Puts back all
>the funds
>+}
>+else {
>+$('.ab_inactive').remove();
>+}
>+});
> });
>
> [% END %]
>--
>2.17.1
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23939] Title missing from Checked out box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23939 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com --- Comment #3 from Blou --- wrong BZ id, my apologies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23939] Title missing from Checked out box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23939 --- Comment #2 from Blou --- Created attachment 115835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115835=edit Bug 23939 - Invoice adjustments should filter inactive funds Looking at invoice details, this makes the Adjustments Fund dropdown act exactly like the Shipping Fund dropdown above, with a Show inactive checkbox to help filter (by default) the inactive funds out of the list. Test plan: 0) requires a database with inactive (old) funds along with active ones. 1) Go to invoice details page 2) Click "Add adjustment" 3) Open the drop down beside the Fund label, you should see EVERY fund in database. 4) Compare with behavior of Shipping fund dropdown above. Not every fund is listed there 5) Apply patch 6) Now behavior is the same, only active fund are listed by default. 7) click "Show inactive" checkbox and see all the funds in the dropdown. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25495] members-home.pl should allow search for exact borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25495 Radek Šiman (R-Bit Technology, s.r.o.) changed: What|Removed |Added CC||blac...@gmail.com, ||josef.mora...@gmail.com, ||r...@rbit.cz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 --- Comment #6 from Tomás Cohen Arazi --- After re-reading the original tutorial I rely on for HTTP status codes [1] I think I now read it the same way you do: the user can add the patrons and THEN re-submit. So 409 makes perfect sense. My original interpretation was that some change could be made to the request for resubmitting it. I agree with 409! [1] https://www.restapitutorial.com/httpstatuscodes.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26525] Changing pickup location for multiple holds with transfer limits enforced only passes one bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26525 Sarah Fletcher changed: What|Removed |Added CC||sfletc...@ncrl.org --- Comment #1 from Sarah Fletcher --- Our library system would love if a patch could be attached to this problem! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27510] Download the report in HTML format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #10 from Katrin Fischer --- I think it would be good if the file validated :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27510] Download the report in HTML format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #9 from Ivan Dziuba --- (In reply to Owen Leonard from comment #8) > I think this looks good. I think the label for the menu item should say > "HTML file" instead of "Document HTML." > > My only other concern is that the generated file isn't a complete HTML > document... No , no , etc. > > Does that matter? The file opens fine in a browser. If that matter I can add all tags. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27525] 'wich' instead of a 'with' in a sentence
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27525 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes: - I just reviewed the diff, rather than trying to generate the message in the staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27543] Tooltip on opac-messaging.pl obscured by table headers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27543 Owen Leonard changed: What|Removed |Added Blocks||27005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005 [Bug 27005] Adding a filter in the datatable of opac-readingrecord page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27005] Adding a filter in the datatable of opac-readingrecord page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27005 Owen Leonard changed: What|Removed |Added Depends on||27543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27543 [Bug 27543] Tooltip on opac-messaging.pl obscured by table headers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #156 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #155) > This has moved a fair bit since the first QA run.. the code updates look > good to me.. but as we're back to NSO it might be good to get a library to > test this again.. Yeah, I totally agree. Some remarks about 'what to expect' from the latest changes: - The fact that all 'new' orders were displayed, was solved properly on bug 25670 with regression tests and all. It should solved here, that's something to test, specifically. - Jonathan provided a less hand-crafted way to implement the column filtering feature on bug 27402. It will serve any other API-driven DataTable, so YAY! Jonathan made this table use that instead of the original implementation. Besides that, you shouldn't expect any noticeable behavior change compared to previous testing sessions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27552] Allow batch cleaning & deleting of files in Manage staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27552 Azucena Aguayo changed: What|Removed |Added CC||azucena.agu...@uvu.edu --- Comment #1 from Azucena Aguayo --- This would be useful for our library too. We update our electronic collections often and we clean those as soon as we are done with the uploads. It's very time consuming. While the cronjob can take care of them, we prefer to hold on to our print collection files longer than we do our electronic collection files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27551] Apply reservation to an item in the catalog available or borrowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27551 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ P.S. I think you're looking for "On shelf holds allowed" in Administration -> Circulation and Fine Rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard changed: What|Removed |Added Attachment #115444|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 115834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115834=edit Bug 27497: (follow-up) Suggested new placement This patch modifies include files and SCSS to move the version information into the "About Koha" menu item in the header menu. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). In the staff client, click the "More" menu in the header. You should see version information next to the "About Koha" menu item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #75 from Barbara Johnson --- Yay! Thanks so much to Tomas and Martin for the final push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #155 from Martin Renvoize --- This has moved a fair bit since the first QA run.. the code updates look good to me.. but as we're back to NSO it might be good to get a library to test this again.. Andrew perhaps, do you have time to go through the test plan one last time given all the extra work that has now taken place and double-check it all still performs as expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27552] New: Allow batch cleaning & deleting of files in Manage staged MARC records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27552 Bug ID: 27552 Summary: Allow batch cleaning & deleting of files in Manage staged MARC records Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org In 'Manage staged MARC records' it is a two-step process to remove a .mrc file. It first must be cleaned and then it must be deleted. It would be nice if it was possible to select multiple .mrc files to clean and delete rather than having to perform the two-step process for every single file. We do have a cron job that batch deletes the oldest files on a regular basis. But recently we exported and then re-imported some digital files. The acquisitions staff would rather not all of those .mrc files jumbled in with the .mrc files they are importing for new materials. So it would be helpful to be able to select specific files all at once and get rid of them in a batch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #74 from Martin Renvoize --- Well done everyone, that was a hard slog but the final result is really nicely done. No regressions found, QA scripts are happy and the feature works as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize changed: What|Removed |Added Attachment #115801|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize changed: What|Removed |Added Attachment #115802|0 |1 is obsolete|| --- Comment #73 from Martin Renvoize --- Created attachment 115833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115833=edit Bug 18532: (follow-up) Fix notice message, add notice to all installer languages and fix preference message Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #72 from Martin Renvoize --- Created attachment 115832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115832=edit Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed This patch enhances auto_renewals message, removes auto_renewals messaging preference when AutoRenewalNotices is not set to ‘preferences’ and uses that preference to send notices in automatic_renewals.pl script. To test: 1. Apply patches 2. updatedatabase 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. Check AutoRenewalNotices preference SUCCESS => AutoRenewalNotices has the value ‘cron’ (means that It keeps the usual behaviour) 5. Checkout two items for a patron, and set them as automatic renewal and set due date as your current yesterday 6. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql 7. Repeat step 5 8. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, and there is one message per item in message_queue table in mysql 9. Change AutoRenewalNotices to ‘never’ 10. Repeat step 5 11. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql, even with the -s switch 12. Check any patron’s category, and any detail page in staff or OPAC interface, and in any of them you should find Auto Renewals messaging preference 13. Change AutoRenewalNotices to ‘preferences’ 14. Repeat step 12, but this time all of them shows the Auto Renewals messaging preference. 15. Repeat step 5 with a patron that has no messaging preference setted 16. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql, because patron didn’t choose to receive messages 17. Grab a category and modify auto renewals messaging preferences, and save 18. Create a new patron from that category. SUCCESS => created patron has the same messaging preference for auto renewals 19. Grab that patron and change auto renewals messaging preference to email but not digest 20. Repeat step 5 for that last patron. 21. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => Items were renewed, and there is a message for each item in message_queue table in mysql. 22. Change auto renewals messaging preference from the same patron and set to email and digest. 23. Repeat step 5. 24. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => items where renewed, and now there is only one message in message_queue table with the details of both renewed items. 25. Check that any changes to a patron’s auto renewals messaging preference in staff is reflected in OPAC, and the other way arround too. 26. Sign off Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize changed: What|Removed |Added Attachment #115800|0 |1 is obsolete|| --- Comment #71 from Martin Renvoize --- Created attachment 115831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115831=edit Bug 18532: (follow-up) Remove digest switch and add preference Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize changed: What|Removed |Added Attachment #115799|0 |1 is obsolete|| --- Comment #70 from Martin Renvoize --- Created attachment 115830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115830=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. (Deprecated test plan. Please check the last patch) To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. go to patron categories in administration of staff interface and choose a category. CHECK => in "Default messaging preferences for this patron category" has a "Auto renewals" row and has email and digest options checked 5. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row with email and digest options checked 6. some settings and save 7. go to opac with that same patron to "your messaging" option CHECK => patron's messaging preferences has a "Auto renewals" row, and displays changes made in staff interface. 8. uncheck email and digest from "Auto renewals" row and save 9. check out an item for that patron, and set it as automatic renewal and set due date as your current yesterday 10. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v SUCCESS => item was renewed, and in message_queue table there is no new message for the patron 11. update patrons messaging preferences and set email option of "Auto renewals" row as checked 12. repeat steps 9 and 10 SUCCESS => item was renewed, but in message_queue table there is a new message of type AUTO_RENEWALS 13. update patrons messaging preferences and set email and digest options of "Auto renewals" row as checked 14. repeat steps 9 and 10 CHECK => item was not renewed 15. run step 10 again, but add -d flag, like this: perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v -d SUCCESS => item was renewed, and in message_queue table there is a new message of type AUTO_RENEWALS_DGST 16. Sign off Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize changed: What|Removed |Added Attachment #115798|0 |1 is obsolete|| --- Comment #69 from Martin Renvoize --- Created attachment 115829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115829=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #68 from Martin Renvoize --- (In reply to Barbara Johnson from comment #62) > Martin, what does it mean that the notice templates no longer apply? Is > that an easy fix or are we back to square one? Tomas understood :). It meant that the .SQL files had moved on in Koha and so the patches here no longer applied without some intervention.. Moving on to QAing now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 --- Comment #5 from Martin Renvoize --- Hmm, tests conflict with dependencies so this doesn't apply nicely.. I'll wait for those to get pushed before returning to this one.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27330] Wrong return status when no enrollments in club holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27330 --- Comment #4 from Martin Renvoize --- This feels like it could be a `409 Conflict` response.. but I'm not really sure if it wins us much doing that rather than a `403 Forbidden`... Either way, I think the 4XX is correct, this is a client pre-condition issue.. as in patrons should have been added to a club prior to a hold being placed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27333] Wrong exception thrown in Koha::Club::Hold::add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27333 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Going for a straight QA here. Follows best practice and is a clear improvement. No regressions found, QA scripts pass and regression tests are included. Passing QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27333] Wrong exception thrown in Koha::Club::Hold::add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27333 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27333] Wrong exception thrown in Koha::Club::Hold::add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27333 Martin Renvoize changed: What|Removed |Added Attachment #114794|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 115828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115828=edit Bug 27333: Throw the right exceptions If parameters are missing, we need to throw Koha::Exceptions::MissingParameter exceptions. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Club/Hold.t => FAIL: Tests fail because the method doesn't throw the right exceptions 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27333] Wrong exception thrown in Koha::Club::Hold::add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27333 Martin Renvoize changed: What|Removed |Added Attachment #114793|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 115827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115827=edit Bug 27333: Regression tests Test for the right exceptions Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Going for a straight QA on this one.. trivial patch, improves code quality, tests still pass, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Martin Renvoize changed: What|Removed |Added Attachment #114787|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 115826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115826=edit Bug 27327: Get rid of indirect object notation in Koha::Club::Hold This patch makes the code follow the PERL29 coding guideline. Period. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Nice catch, Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 Martin Renvoize changed: What|Removed |Added Attachment #114339|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 115825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115825=edit Bug 27204: Fix end boundary index, never return results for non-existant accountlines There are two primary issues I've identified with requesting line items for fees via SIP: 1) The end boundary is incorrect. For example, if send a request with a BP ( starting item) of 1, and a BQ (end item) of 1, I should get just the first item. Instead I will get two items 2) Our SIP server does not check bounds. For example, if I have 3 fines, but I send a BP of 1 and a BQ of 5, I will get back 5 AVs, two of them being "empty" because the patron only has 3 accountlines! Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/SIP/Patron.t 3) Note the failures 4) Apply the second patch 5) prove t/db_dependent/SIP/Patron.t 6) All tests should pass! Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 Martin Renvoize changed: What|Removed |Added Attachment #114338|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 115824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115824=edit Bug 27204: Add unit tests for fine_items Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27333] Wrong exception thrown in Koha::Club::Hold::add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27333 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27327] Indirect object notation in Koha::Club::Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27327 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #2 from Tomás Cohen Arazi --- Applies cleanly here: $ git checkout origin/master -b qa_27327 Branch 'qa_27327' set up to track remote branch 'master' from 'origin'. Switched to a new branch 'qa_27327' (base) ✔ ~/git/koha [qa_27327|…1⚑ 28] 13:22 $ git bz apply 27327 Bug 27327 - Indirect object notation in Koha::Club::Hold 114787 - Bug 27327: Get rid of indirect object notation in Koha::Club::Hold Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27327: Get rid of indirect object notation in Koha::Club::Hold (base) ✔ ~/git/koha [qa_27327 ↑·1|…1⚑ 28] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27551] New: Apply reservation to an item in the catalog available or borrowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27551 Bug ID: 27551 Summary: Apply reservation to an item in the catalog available or borrowed Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jcautomatizac...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Hello, At this time, the reservation of items in the catalog only allows it to be applied to the items that are on loan and not to the items that are available. I want to know if there is a way to make the reservation apply to all the elements of the catalog that are borrowed or available, and how can it be done? They tell me that before they had version 3.22 of Koha and this is working. I really appreciate the help. kind regards, Jonathan Cuéllar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #9 from Lisette Scheer --- (In reply to Fridolin Somers from comment #8) > And what do you think displaying the version below "About Koha" in main page > ? > Since version is displayed is this page about.pl +1 I really like this idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23857] Club holds endpoint not setting Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23857 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- This one is a bit weird to me... Whilst it adds a semi-sensible Location header.. I would have thought that header should point to the created resource (rather than the generic 'list all resources' route). But, more than that, neither the `list` or `get` routes actually exist.. so the Location header will point to a 404. I think we aught to add the `get` endpoint to get the individual created resource and update this patch to point to that specific resource rather than the list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27510] Download the report in HTML format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27510 --- Comment #8 from Owen Leonard --- I think this looks good. I think the label for the menu item should say "HTML file" instead of "Document HTML." My only other concern is that the generated file isn't a complete HTML document... No , no , etc. Does that matter? The file opens fine in a browser. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912 gclg changed: What|Removed |Added CC||nglhelpdesk@cityofglasgowco ||llege.ac.uk --- Comment #8 from gclg --- This badly needs a restriction on accounts for Koha access via the staff client. At the moment the only option would appear to be removing the ability to log in from the the permissions. The ability to restrict access based on Patron Category would be the preferred option. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall changed: What|Removed |Added Attachment #81135|0 |1 is obsolete|| Attachment #81136|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 115823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115823=edit Bug 20718: Add ability to have lists that are available to all list editors Some librarians would like to have lists that can be shared among staff that have the lists permission. Test Plan: 1) Apply this patch 2) Create some private, public and 'staff' lists 3) Note only staff that can edit lists have access to the 'staff' lists -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #154 from Tomás Cohen Arazi --- Created attachment 115822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115822=edit Bug 20212: Remove fix_query and assume ugliness It seems better to do things in an ugly way but simple than complicated. This patch removes the fix_query method that deals with ean and isbn and explicitly tell that it's a trick that must not be reused somewhere else. It should only be used by Koha internally and we should not advertised it until it's ready. This problem will have to be fixed properly when the GET /biblios route will be implemented. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #153 from Tomás Cohen Arazi --- Created attachment 115821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115821=edit Bug 20212: Fix query for the global filter Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #151 from Tomás Cohen Arazi --- Created attachment 115819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115819=edit Bug 20212: Use the DT column filtering provided by the wrapper Bug 27402 is adding it, we do not longer need the query_from_filters JS function. This patch also remove the filters on the left. As we have DT remembering the filter on the table we don't need them anymore. Technical note: Prior to this patch, the search on biblio.author, biblio.title and biblio.isbn was done by adding hidden columns. Now we are using: "data": "biblio.author:biblio.title:biblio.isbn" to tell the wrapper we are going to build a search on these 3 attributes. Another trick is to pass a default_filters parameters to the wrapper, to tell it we want to filter on the orders of a given vendor (this is a bugfix, the original implementation was returning all the orders). However We should not use /acq/orders?vendor_id=42 but /acq/vendor/42/orders instead (which does not exist yet), otherwise (with bug 27353 ) we are going to display the wrong number of non-filtering rows. The change in Orders.pm is only formatting to match what's done in Bug 27353: Set X-Base-Total-Count header for REST API Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #152 from Tomás Cohen Arazi --- Created attachment 115820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115820=edit Bug 20212: Re-add EAN for UNIMARC Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #150 from Tomás Cohen Arazi --- Created attachment 115818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115818=edit Bug 20212: Remove fixedHeader It's an extension that needs to be added. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
